[jira] [Commented] (CB-13482) Not asking for android permission.
[ https://issues.apache.org/jira/browse/CB-13482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226210#comment-16226210 ] kushal chandel commented on CB-13482: - Steps to reproduce is simple Firstly device i am using is android on5 and version is 6.0.1 while using media capture plugin i used video capture when i call the function video is open but permission is not asked and while using audio it asked for android device permission. thanks > Not asking for android permission. > -- > > Key: CB-13482 > URL: https://issues.apache.org/jira/browse/CB-13482 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media-capture >Reporter: kushal chandel > Labels: Triaged > > While using media plugin captureVideo it is not asking for android permission. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13511) update coho to work with apache repos that moved over to github
[ https://issues.apache.org/jira/browse/CB-13511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226019#comment-16226019 ] ASF GitHub Bot commented on CB-13511: - stevengill opened a new pull request #163: CB-13511: added github boolean to repos that have moved over to github URL: https://github.com/apache/cordova-coho/pull/163 ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > update coho to work with apache repos that moved over to github > --- > > Key: CB-13511 > URL: https://issues.apache.org/jira/browse/CB-13511 > Project: Apache Cordova > Issue Type: Improvement >Reporter: Steve Gill > > We don't need the apache git repos anymore since our repos have been moved > over to github proper. Update coho to reflect that -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13511) update coho to work with apache repos that moved over to github
Steve Gill created CB-13511: --- Summary: update coho to work with apache repos that moved over to github Key: CB-13511 URL: https://issues.apache.org/jira/browse/CB-13511 Project: Apache Cordova Issue Type: Improvement Reporter: Steve Gill We don't need the apache git repos anymore since our repos have been moved over to github proper. Update coho to reflect that -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12940) Use deployment-target for platform version in Podfile
[ https://issues.apache.org/jira/browse/CB-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225974#comment-16225974 ] ASF GitHub Bot commented on CB-12940: - shazron commented on issue #335: CB-12940: [IOS] Use deployment-target from config.xml for platform version in Podfile URL: https://github.com/apache/cordova-ios/pull/335#issuecomment-340614728 Hmm. I think at minimum it should restore the default deployment target on plugin remove. What do you think? This can get hairy however, if somehow other plugins touched that value as well... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use deployment-target for platform version in Podfile > - > > Key: CB-12940 > URL: https://issues.apache.org/jira/browse/CB-12940 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Affects Versions: cordova-ios@4.4.0 >Reporter: Todd Miller >Assignee: Shazron Abdullah > Labels: backlog > Fix For: cordova-ios@4.5.1 > > > The current Podfile.js script is hardcoded to set the platform ios version to > 8.0. However, there are some pods that require 9.0 or they will fail to > install. The deployment-target preference should be honored and used when > generating the Podfile. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13504) Cordova-Fetch Release 1.2.1 October 27, 2017
[ https://issues.apache.org/jira/browse/CB-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225959#comment-16225959 ] ASF GitHub Bot commented on CB-13504: - audreyso closed pull request #753: CB-13504 : blog post for cordova-fetch@1.2.1 release URL: https://github.com/apache/cordova-docs/pull/753 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/www/_posts/2017-10-30-fetch-release.md b/www/_posts/2017-10-30-fetch-release.md new file mode 100644 index 0..82146a9eb --- /dev/null +++ b/www/_posts/2017-10-30-fetch-release.md @@ -0,0 +1,26 @@ +--- +layout: post +author: +name: Audrey So +url: https://twitter.com/aud_rey_so +title: "Cordova-Fetch@1.2.1 Released!" +date: 2017-10-30 +categories: news +tags: release tools cordova-fetch +--- + +We just released some changes to `cordova-fetch`! + +* [cordova-fetch@1.2.1](https://www.npmjs.com/package/cordova-fetch) + +Release Highlights: +* Added node 8 support to our continuous integration tests. + + +# Changes include: + +## cordova-fetch + +* [CB-13504](https://issues.apache.org/jira/browse/CB-13504) : Updated `package.json` versions for `cordova-fetch`@1.2.1 release. +* [CB-13501](https://issues.apache.org/jira/browse/CB-13501) : Added support for node 8. +* [CB-13492](https://issues.apache.org/jira/browse/CB-13492) : Updated `opts.save` and included tests for no-save. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova-Fetch Release 1.2.1 October 27, 2017 > > > Key: CB-13504 > URL: https://issues.apache.org/jira/browse/CB-13504 > Project: Apache Cordova > Issue Type: Task > Components: cordova-fetch >Reporter: Audrey So > Fix For: 1.2.1 > > > Following steps at: > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13504) Cordova-Fetch Release 1.2.1 October 27, 2017
[ https://issues.apache.org/jira/browse/CB-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225960#comment-16225960 ] ASF subversion and git services commented on CB-13504: -- Commit 959e8136daa75959611fd53ef3f020ba9a0b1184 in cordova-docs's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=959e813 ] CB-13504 : blog post for cordova-fetch@1.2.1 release > Cordova-Fetch Release 1.2.1 October 27, 2017 > > > Key: CB-13504 > URL: https://issues.apache.org/jira/browse/CB-13504 > Project: Apache Cordova > Issue Type: Task > Components: cordova-fetch >Reporter: Audrey So > Fix For: 1.2.1 > > > Following steps at: > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13504) Cordova-Fetch Release 1.2.1 October 27, 2017
[ https://issues.apache.org/jira/browse/CB-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225962#comment-16225962 ] ASF subversion and git services commented on CB-13504: -- Commit d8df1895c60e678acc3ec66bdf0a4d57f196988d in cordova-docs's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=d8df189 ] Merge pull request #753 from audreyso/CB-13504 CB-13504 : blog post for cordova-fetch@1.2.1 release > Cordova-Fetch Release 1.2.1 October 27, 2017 > > > Key: CB-13504 > URL: https://issues.apache.org/jira/browse/CB-13504 > Project: Apache Cordova > Issue Type: Task > Components: cordova-fetch >Reporter: Audrey So > Fix For: 1.2.1 > > > Following steps at: > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13504) Cordova-Fetch Release 1.2.1 October 27, 2017
[ https://issues.apache.org/jira/browse/CB-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225961#comment-16225961 ] ASF subversion and git services commented on CB-13504: -- Commit d8df1895c60e678acc3ec66bdf0a4d57f196988d in cordova-docs's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=d8df189 ] Merge pull request #753 from audreyso/CB-13504 CB-13504 : blog post for cordova-fetch@1.2.1 release > Cordova-Fetch Release 1.2.1 October 27, 2017 > > > Key: CB-13504 > URL: https://issues.apache.org/jira/browse/CB-13504 > Project: Apache Cordova > Issue Type: Task > Components: cordova-fetch >Reporter: Audrey So > Fix For: 1.2.1 > > > Following steps at: > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225950#comment-16225950 ] ASF subversion and git services commented on CB-13501: -- Commit bb7b47b063c81b9e2760f5aea0234058d3a49fbb in cordova-android's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=bb7b47b ] Merge pull request #414 from audreyso/CB-13501 CB-13501 : update appveyor to support node 8 > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225949#comment-16225949 ] ASF subversion and git services commented on CB-13501: -- Commit bb7b47b063c81b9e2760f5aea0234058d3a49fbb in cordova-android's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=bb7b47b ] Merge pull request #414 from audreyso/CB-13501 CB-13501 : update appveyor to support node 8 > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225947#comment-16225947 ] ASF GitHub Bot commented on CB-13501: - audreyso closed pull request #414: CB-13501 : update appveyor to support node 8 URL: https://github.com/apache/cordova-android/pull/414 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/appveyor.yml b/appveyor.yml index 907d0c434..3a78f414e 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -6,6 +6,7 @@ environment: matrix: - nodejs_version: "4" - nodejs_version: "6" + - nodejs_version: "8" init: - mkdir "%ANDROID_HOME% This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225948#comment-16225948 ] ASF subversion and git services commented on CB-13501: -- Commit b2a81c09ec89164d083244903ca990292032363c in cordova-android's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=b2a81c0 ] :CB-13501 : update appveyor node versions to support node 8 > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13510) Copy/Paste functionality is not working for iOS native components.
[ https://issues.apache.org/jira/browse/CB-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aqeel Raza Syed updated CB-13510: - Description: With iOS11 upgrade Cordova-ios library is braking copy/paste functionality for consumer apps utilizing both web and native UI. *Steps to reproduce :* - Copy text to clipboard (e.g. Notes app) - Foreground consumer app (app must be running in background) - Paste clipboard text to native UI component (i.e. UITextField) *Expected:* - Text should be pasted on native UI component *Actual:* - Nothing happens *Note:* This only happens with native UI components and works fine with Web interface. Also once consumer app goes foreground, after backgrounding that app, clipboard text can never be pasted in any other iOS app with native UI. *Investigation:* Seems like following patch fix is causing this issue in iOS 11: https://github.com/apache/cordova-ios/pull/139 *Potential Fix:* Since above patch has been done a while ago, removing that bit of code, doesn't seems to reintroduce original bug (i.e. https://voxpelli.com/2015/03/ios-safari-url-copy-paste-bug/) was: With iOS11 upgrade Cordova-ios library is braking copy/paste functionality for consumer apps utilizing both web and native UI. *Steps to reproduce :* - Copy text to clipboard (e.g. Notes app) - Foreground consumer app (app must be running in background) - Paste clipboard text to native UI component (i.e. UITextField) *Expected:* - Text should be pasted on native UI component *Actual:* - Nothing happens *Note:* This only happens with native UI components and works fine with Web interface. Also once consumer app goes foreground, after backgrounding that app, clipboard text can never be pasted in any other iOS app with native UI. *Investigation:* Seems like this patch fix is causing this issue in iOS 11: https://github.com/apache/cordova-ios/pull/139 *Potential Fix:* Since above patch has been done a while ago, removing that bit of code, doesn't seems to reintroduce original bug (i.e. https://voxpelli.com/2015/03/ios-safari-url-copy-paste-bug/) > Copy/Paste functionality is not working for iOS native components. > -- > > Key: CB-13510 > URL: https://issues.apache.org/jira/browse/CB-13510 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.4.0, cordova-ios 4.5.0 > Environment: iOS 11 and up... Not reproducible in iOS 10.x >Reporter: Aqeel Raza Syed >Assignee: Suraj Pindoria > > With iOS11 upgrade Cordova-ios library is braking copy/paste functionality > for consumer apps utilizing both web and native UI. > *Steps to reproduce :* > - Copy text to clipboard (e.g. Notes app) > - Foreground consumer app (app must be running in background) > - Paste clipboard text to native UI component (i.e. UITextField) > *Expected:* > - Text should be pasted on native UI component > *Actual:* > - Nothing happens > *Note:* This only happens with native UI components and works fine with Web > interface. Also once consumer app goes foreground, after backgrounding that > app, clipboard text can never be pasted in any other iOS app with native UI. > *Investigation:* > Seems like following patch fix is causing this issue in iOS 11: > https://github.com/apache/cordova-ios/pull/139 > *Potential Fix:* Since above patch has been done a while ago, removing that > bit of code, doesn't seems to reintroduce original bug (i.e. > https://voxpelli.com/2015/03/ios-safari-url-copy-paste-bug/) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225929#comment-16225929 ] ASF subversion and git services commented on CB-13501: -- Commit 0e81de2508280c281dfe94fd4615493bb4c923f6 in cordova-js's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-js.git;h=0e81de2 ] CB-13501 : added support for node 8 > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225931#comment-16225931 ] ASF subversion and git services commented on CB-13501: -- Commit 4450a4cea50616e080a82e8ede9e3d6a1fe3c3ec in cordova-js's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-js.git;h=4450a4c ] Merge pull request #150 from audreyso/CB-13501 CB-13501 : added support for node 8 > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13510) Copy/Paste functionality is not working for iOS native components.
Aqeel Raza Syed created CB-13510: Summary: Copy/Paste functionality is not working for iOS native components. Key: CB-13510 URL: https://issues.apache.org/jira/browse/CB-13510 Project: Apache Cordova Issue Type: Bug Components: cordova-ios Affects Versions: cordova-ios 4.5.0, cordova-ios@4.4.0 Environment: iOS 11 and up... Not reproducible in iOS 10.x Reporter: Aqeel Raza Syed Assignee: Suraj Pindoria With iOS11 upgrade Cordova-ios library is braking copy/paste functionality for consumer apps utilizing both web and native UI. *Steps to reproduce :* - Copy text to clipboard (e.g. Notes app) - Foreground consumer app (app must be running in background) - Paste clipboard text to native UI component (i.e. UITextField) *Expected:* - Text should be pasted on native UI component *Actual:* - Nothing happens *Note:* This only happens with native UI components and works fine with Web interface. Also once consumer app goes foreground, after backgrounding that app, clipboard text can never be pasted in any other iOS app with native UI. *Investigation:* Seems like this patch fix is causing this issue in iOS 11: https://github.com/apache/cordova-ios/pull/139 *Potential Fix:* Since above patch has been done a while ago, removing that bit of code, doesn't seems to reintroduce original bug (i.e. https://voxpelli.com/2015/03/ios-safari-url-copy-paste-bug/) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225930#comment-16225930 ] ASF subversion and git services commented on CB-13501: -- Commit 4450a4cea50616e080a82e8ede9e3d6a1fe3c3ec in cordova-js's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-js.git;h=4450a4c ] Merge pull request #150 from audreyso/CB-13501 CB-13501 : added support for node 8 > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225928#comment-16225928 ] ASF GitHub Bot commented on CB-13501: - audreyso closed pull request #150: CB-13501 : added support for node 8 URL: https://github.com/apache/cordova-js/pull/150 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 406a75f9..e56b78ea 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,6 +5,7 @@ git: node_js: - "4" - "6" + - "8" install: - cd .. - git clone https://github.com/apache/cordova-android --depth 10 diff --git a/appveyor.yml b/appveyor.yml index 911b4a7f..f44dffe4 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -4,6 +4,7 @@ environment: matrix: - nodejs_version: "4" - nodejs_version: "6" + - nodejs_version: "8" install: - ps: Install-Product node $env:nodejs_version This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225920#comment-16225920 ] ASF subversion and git services commented on CB-13501: -- Commit 49ab0bec83fd3854f0027117a915ec8144ae821c in cordova-serve's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-serve.git;h=49ab0be ] Merge pull request #5 from audreyso/CB-13501 CB-13501 : added support for node 8 > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225917#comment-16225917 ] ASF GitHub Bot commented on CB-13501: - audreyso closed pull request #5: CB-13501 : added support for node 8 URL: https://github.com/apache/cordova-serve/pull/5 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 59fda3b..53f19a8 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,6 +5,7 @@ git: node_js: - "4" - "6" + - "8" install: - "npm install" script: diff --git a/appveyor.yml b/appveyor.yml index 94714f2..ffe5194 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -5,6 +5,7 @@ environment: matrix: - nodejs_version: "4" - nodejs_version: "6" + - nodejs_version: "8" install: - ps: Install-Product node $env:nodejs_version This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225918#comment-16225918 ] ASF subversion and git services commented on CB-13501: -- Commit 506aac2c121ab0c06a65225e061fdf5afea13003 in cordova-serve's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-serve.git;h=506aac2 ] CB-13501 : added support for node 8 > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225921#comment-16225921 ] ASF subversion and git services commented on CB-13501: -- Commit 49ab0bec83fd3854f0027117a915ec8144ae821c in cordova-serve's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-serve.git;h=49ab0be ] Merge pull request #5 from audreyso/CB-13501 CB-13501 : added support for node 8 > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13504) Cordova-Fetch Release 1.2.1 October 27, 2017
[ https://issues.apache.org/jira/browse/CB-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225897#comment-16225897 ] ASF GitHub Bot commented on CB-13504: - stevengill commented on a change in pull request #753: CB-13504 : blog post for cordova-fetch@1.2.1 release URL: https://github.com/apache/cordova-docs/pull/753#discussion_r147856416 ## File path: www/_posts/2017-10-30-fetch-release.md ## @@ -0,0 +1,27 @@ +--- +layout: post +author: +name: Audrey So +url: https://twitter.com/aud_rey_so +title: "Cordova-Fetch@1.2.1 Released!" +date: 2017-10-30 +categories: news +tags: release tools cordova-fetch +--- + +We just released some changes to `cordova-fetch`! + +* [cordova-fetch@1.2.1](https://www.npmjs.com/package/cordova-fetch) + +Release Highlights: +* Support added for node 8. + + +# Changes include: + +## cordova-fetch + +* [CB-13504](https://issues.apache.org/jira/browse/CB-13504) : Updated `package.json` versions for `cordova-fetch`@1.2.1 release. +* [CB-13501](https://issues.apache.org/jira/browse/CB-13501) : Added support for node 8. +* [CB-13492](https://issues.apache.org/jira/browse/CB-13492) : Updated opts.save and included tests for no-save. Review comment: Maybe add ticks around `opts.save` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova-Fetch Release 1.2.1 October 27, 2017 > > > Key: CB-13504 > URL: https://issues.apache.org/jira/browse/CB-13504 > Project: Apache Cordova > Issue Type: Task > Components: cordova-fetch >Reporter: Audrey So > Fix For: 1.2.1 > > > Following steps at: > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13504) Cordova-Fetch Release 1.2.1 October 27, 2017
[ https://issues.apache.org/jira/browse/CB-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225899#comment-16225899 ] ASF GitHub Bot commented on CB-13504: - stevengill commented on a change in pull request #753: CB-13504 : blog post for cordova-fetch@1.2.1 release URL: https://github.com/apache/cordova-docs/pull/753#discussion_r147856643 ## File path: www/_posts/2017-10-30-fetch-release.md ## @@ -0,0 +1,27 @@ +--- +layout: post +author: +name: Audrey So +url: https://twitter.com/aud_rey_so +title: "Cordova-Fetch@1.2.1 Released!" +date: 2017-10-30 +categories: news +tags: release tools cordova-fetch +--- + +We just released some changes to `cordova-fetch`! + +* [cordova-fetch@1.2.1](https://www.npmjs.com/package/cordova-fetch) + +Release Highlights: +* Support added for node 8. Review comment: Instead of support added for node 8, we should say something like `Added node 8 support to our continuous integration tests` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova-Fetch Release 1.2.1 October 27, 2017 > > > Key: CB-13504 > URL: https://issues.apache.org/jira/browse/CB-13504 > Project: Apache Cordova > Issue Type: Task > Components: cordova-fetch >Reporter: Audrey So > Fix For: 1.2.1 > > > Following steps at: > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13504) Cordova-Fetch Release 1.2.1 October 27, 2017
[ https://issues.apache.org/jira/browse/CB-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225898#comment-16225898 ] ASF GitHub Bot commented on CB-13504: - stevengill commented on a change in pull request #753: CB-13504 : blog post for cordova-fetch@1.2.1 release URL: https://github.com/apache/cordova-docs/pull/753#discussion_r147856340 ## File path: www/_posts/2017-10-30-fetch-release.md ## @@ -0,0 +1,27 @@ +--- +layout: post +author: +name: Audrey So +url: https://twitter.com/aud_rey_so +title: "Cordova-Fetch@1.2.1 Released!" +date: 2017-10-30 +categories: news +tags: release tools cordova-fetch +--- + +We just released some changes to `cordova-fetch`! + +* [cordova-fetch@1.2.1](https://www.npmjs.com/package/cordova-fetch) + +Release Highlights: +* Support added for node 8. + + +# Changes include: + +## cordova-fetch + +* [CB-13504](https://issues.apache.org/jira/browse/CB-13504) : Updated `package.json` versions for `cordova-fetch`@1.2.1 release. +* [CB-13501](https://issues.apache.org/jira/browse/CB-13501) : Added support for node 8. +* [CB-13492](https://issues.apache.org/jira/browse/CB-13492) : Updated opts.save and included tests for no-save. +* [CB-13380](https://issues.apache.org/jira/browse/CB-13380) : Incremented package version to -dev. Review comment: I would delete line 27. It is an automated commit from coho we usually delete out during blog posts This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova-Fetch Release 1.2.1 October 27, 2017 > > > Key: CB-13504 > URL: https://issues.apache.org/jira/browse/CB-13504 > Project: Apache Cordova > Issue Type: Task > Components: cordova-fetch >Reporter: Audrey So > Fix For: 1.2.1 > > > Following steps at: > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225888#comment-16225888 ] ASF subversion and git services commented on CB-13501: -- Commit 5296e279e5aa0ac79bc03726a25b06e562e64176 in cordova-common's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-common.git;h=5296e27 ] CB-13501 : added node 8 support > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225889#comment-16225889 ] ASF subversion and git services commented on CB-13501: -- Commit 722096002b934d55a8de7a3665c61704b535 in cordova-common's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-common.git;h=7220960 ] Merge pull request #11 from audreyso/CB-13501 CB-13501 : added node 8 support > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225887#comment-16225887 ] ASF GitHub Bot commented on CB-13501: - audreyso closed pull request #11: CB-13501 : added node 8 support URL: https://github.com/apache/cordova-common/pull/11 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 459273a..4592c3e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,6 +5,7 @@ git: node_js: - "4" - "6" + - "8" install: - npm install - npm install -g codecov diff --git a/appveyor.yml b/appveyor.yml index 94714f2..ffe5194 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -5,6 +5,7 @@ environment: matrix: - nodejs_version: "4" - nodejs_version: "6" + - nodejs_version: "8" install: - ps: Install-Product node $env:nodejs_version This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225890#comment-16225890 ] ASF subversion and git services commented on CB-13501: -- Commit 722096002b934d55a8de7a3665c61704b535 in cordova-common's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-common.git;h=7220960 ] Merge pull request #11 from audreyso/CB-13501 CB-13501 : added node 8 support > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13509) Need to add nullibility support for method CDVWebViewEngineProtocol.evaluateJavaScript
Guo Li created CB-13509:
---
Summary: Need to add nullibility support for method
CDVWebViewEngineProtocol.evaluateJavaScript
Key: CB-13509
URL: https://issues.apache.org/jira/browse/CB-13509
Project: Apache Cordova
Issue Type: Bug
Components: cordova-ios
Environment: Xcode 9
Reporter: Guo Li
Assignee: Suraj Pindoria
In our project, we consume cordova as framework and want to use
CDVWebViewEngineProtocol in swift code.
After compiling the generated interface of an Objective C object
CDVWebViewEngineProtocol are translated into following.
{code:swift}
public protocol CDVWebViewEngineProtocol : NSObjectProtocol {
@available(iOS 2.0, *)
public var engineWebView: UIView! { get }
public func load(_ request: URLRequest!) -> Any!
public func loadHTMLString(_ string: String!, baseURL: URL!) -> Any!
public func evaluateJavaScript(_ javaScriptString: String!,
completionHandler: ((Any?, Error?) -> Swift.Void)!)
public func url() -> URL!
public func canLoad(_ request: URLRequest!) -> Bool
public init!(frame: CGRect)
public func update(withInfo info: [AnyHashable : Any]!)
}
{code}
Currently method evaluateJavaScript do not support nullibility paramaters
{code:swift}
public func evaluateJavaScript(_ javaScriptString: String!,
completionHandler: ((Any?, Error?) -> Swift.Void)!)
{code}
Thus we have to either use the same signature or manual check for nil in our
implementation. We finally pick the 2nd option as solution since we don't want
to include any '!' in our swift code. But this is not a very adorable practice
since we can not match the method exactly as the same method in the protocal.
To avoid this issue, it would be great to add nullibility support for method
CDVWebViewEngineProtocol.evaluateJavaScript.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13486) adds duplicate element if the existing element has extra attributes
[
https://issues.apache.org/jira/browse/CB-13486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225852#comment-16225852
]
cordovapolymer commented on CB-13486:
-
Very accurate describtion of the issue. It exists in all recent cordova
versions.
I have it with cordova-plugin-braintree
> adds duplicate element if the existing element has extra
> attributes
> -
>
> Key: CB-13486
> URL: https://issues.apache.org/jira/browse/CB-13486
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.1
>Reporter: Ibrahim M. Ghazal
> Labels: reproduced, triaged
>
> If {{}} tries to add an element to a config file, and that
> config file has the same element but with extra attributes, the element is
> added anyway. I expect it to consider it already existing and skip adding it.
> Example:
> 1. Add {{cordova-plugin-file}} plugin, which contains this line in
> {{plugin.xml}}:
> {code}
>
> />
>
> {code}
> 2. Since {{WRITE_EXTERNAL_STORAGE}} is not required on Android API 19+
> (Android 4.4+), I want to add {{android:maxSdkVersion="18"}} to the
> permission. So I add this to the app's {{config.xml}}
> {code}
> target="/manifest/uses-permission[@android:name='android.permission.WRITE_EXTERNAL_STORAGE']"
> xmlns:android="http://schemas.android.com/apk/res/android";>
> android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
>
> {code}
> 3. Run {{cordova run android}}. It succeeds the first time and the permission
> is modified correctly. {{AndroidManifest.xml}} now contains this:
> {code}
> android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
> {code}
> 3. Run {{cordova run android}} again. The {{}} from
> {{cordova-plugin-file}} is applied again. It searches for the exact element
> it wants to add and doesn't find it (because that element now has an extra
> attribute, {{android:maxSdkVersion}}), and so it adds it again.
> {{AndroidManifest.xml}} now contains this:
> {code}
> android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
>
> {code}
> This causes {{cordova run android}} to fail with:
> {code}
> Element uses-permission#android.permission.WRITE_EXTERNAL_STORAGE at
> AndroidManifest.xml:20:5-81 duplicated with element declared at
> AndroidManifest.xml:18:5-108
> See http://g.co/androidstudio/manifest-merger for more information about the
> manifest merger.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13504) Cordova-Fetch Release 1.2.1 October 27, 2017
[ https://issues.apache.org/jira/browse/CB-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225847#comment-16225847 ] ASF GitHub Bot commented on CB-13504: - audreyso opened a new pull request #753: CB-13504 : blog post for cordova-fetch@1.2.1 release URL: https://github.com/apache/cordova-docs/pull/753 ### Platforms affected ### What does this PR do? Blog post for cordova-fetch@1.2.1 release ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova-Fetch Release 1.2.1 October 27, 2017 > > > Key: CB-13504 > URL: https://issues.apache.org/jira/browse/CB-13504 > Project: Apache Cordova > Issue Type: Task > Components: cordova-fetch >Reporter: Audrey So > Fix For: 1.2.1 > > > Following steps at: > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio
[
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225765#comment-16225765
]
ASF GitHub Bot commented on CB-11244:
-
macdonst commented on issue #389: CB-11244: Studio Project Compatibility: Now
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-340590032
@infil00p okay, got it. Once I do that step I get a bit farther but then I
run into other problems. The plugin doesn't compile because it is missing all
of the frameworks it depends on. For instance the push plugin includes:
```
```
None of those things seem to get included in `build.gradle`. Previously I'd
see:
```
// PLUGIN GRADLE EXTENSIONS START
apply from: "phonegap-plugin-push/app-push.gradle"
// PLUGIN GRADLE EXTENSIONS END
dependencies {
compile fileTree(dir: 'libs', include: '*.jar')
// SUB-PROJECT DEPENDENCIES START
debugCompile(project(path: "CordovaLib", configuration: "debug"))
releaseCompile(project(path: "CordovaLib", configuration: "release"))
compile "com.android.support:support-v13:26.+"
compile "me.leolin:ShortcutBadger:1.1.17@aar"
compile "com.google.firebase:firebase-messaging:11.0.1"
// SUB-PROJECT DEPENDENCIES END
}
```
But with this change I only see:
```
dependencies {
compile fileTree(dir: 'libs', include: '*.jar')
// SUB-PROJECT DEPENDENCIES START
debugCompile(project(path: ":CordovaLib", configuration: "debug"))
releaseCompile(project(path: ":CordovaLib", configuration: "release"))
// SUB-PROJECT DEPENDENCIES END
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Android Project Structure to be more compatible with Android Studio
> --
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
> Labels: CordovaAndroidSix, android-next
>
> Currently our existing Android projects have the old Android Project
> structure created by default, even for new projects, which makes no sense
> since we no longer support Eclipse as the default project editor and have
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for
> projects and dependencies to work more like how modern Android projects work
> and to remove as much custom Gradle code as possible. This would also allow
> us in the future to move towards having Android Plugin code work as Android
> Libraries with Resources instead of just copying things across, which gives
> us the ability to add JUnit tests and bundled resources. This would
> dramatically increase the quality of plugins such as InAppBrowser, and third
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would
> be tricky to do. However, the benefits at this point would greatly outweigh
> the costs of maintaining the old project structure. The old cordova-common
> code in Cordova-Android 5.0.x would allow for plugins in the short term to
> work with both projects until we get the new project structure ready.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio
[ https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225715#comment-16225715 ] ASF GitHub Bot commented on CB-11244: - infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-340582879 @macdonst Read @stevegill's note about changing package.json when testing locally. If you don't do this, you will definitely get this error. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update Android Project Structure to be more compatible with Android Studio > -- > > Key: CB-11244 > URL: https://issues.apache.org/jira/browse/CB-11244 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Blocker > Labels: CordovaAndroidSix, android-next > > Currently our existing Android projects have the old Android Project > structure created by default, even for new projects, which makes no sense > since we no longer support Eclipse as the default project editor and have > moved to Android Studio for Android development. > The main reason for doing this is to clean up dependencies and to allow for > projects and dependencies to work more like how modern Android projects work > and to remove as much custom Gradle code as possible. This would also allow > us in the future to move towards having Android Plugin code work as Android > Libraries with Resources instead of just copying things across, which gives > us the ability to add JUnit tests and bundled resources. This would > dramatically increase the quality of plugins such as InAppBrowser, and third > party plugins such as the Barcode Scanner. > This would have to be done on the next major version, and the upgrade would > be tricky to do. However, the benefits at this point would greatly outweigh > the costs of maintaining the old project structure. The old cordova-common > code in Cordova-Android 5.0.x would allow for plugins in the short term to > work with both projects until we get the new project structure ready. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13289) Gradle/Android Plugin DSL change breaks including CordovaLib
[ https://issues.apache.org/jira/browse/CB-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225710#comment-16225710 ] ASF GitHub Bot commented on CB-13289: - codecov-io commented on issue #413: CB-13289: This fixes the Cordova-Android build on cordova-android 6.x URL: https://github.com/apache/cordova-android/pull/413#issuecomment-339514900 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=h1) Report > Merging [#413](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/04fa5d3febe69d7adc91d1e603118f3d33af2606?src=pr&el=desc) will **increase** coverage by `0.23%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #413 +/- ## == + Coverage 43.77% 44.01% +0.23% == Files 17 17 Lines1688 1679 -9 Branches 307 304 -3 == Hits 739 739 + Misses949 940 -9 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz) | `20.71% <0%> (+0.29%)` | :arrow_up: | | [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `48.13% <0%> (+1.52%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=footer). Last update [04fa5d3...a2618dc](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Gradle/Android Plugin DSL change breaks including CordovaLib > > > Key: CB-13289 > URL: https://issues.apache.org/jira/browse/CB-13289 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 6.2.1 >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Blocker > Labels: android-next > Fix For: 7.0.0 > > > Android Studio 3.0.0 uses a new DSL, and this breaks the dependency list. > This directly affects Cordova plugins that work as a Library Module, as well > as adding and removing the Android platform. Basically, once Android Studio > 3.0 updates, Cordova projects will not work properly with the new version of > Android Studio once they're updated. > This depends on CB-11244 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225693#comment-16225693 ] ASF subversion and git services commented on CB-13501: -- Commit 30978e2f9bf411d203741f3fded94c56b614b908 in cordova-browser's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=30978e2 ] Merge pull request #47 from audreyso/CB-13501 CB-13501 : added support for node 8 > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225691#comment-16225691 ] ASF subversion and git services commented on CB-13501: -- Commit d11a998d33501f1d48fc8e70bfe09f8f1d6e96c9 in cordova-browser's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=d11a998 ] CB-13501 : added support for node 8 > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225694#comment-16225694 ] ASF subversion and git services commented on CB-13501: -- Commit 30978e2f9bf411d203741f3fded94c56b614b908 in cordova-browser's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=30978e2 ] Merge pull request #47 from audreyso/CB-13501 CB-13501 : added support for node 8 > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225692#comment-16225692 ] ASF GitHub Bot commented on CB-13501: - audreyso closed pull request #47: CB-13501 : added support for node 8 URL: https://github.com/apache/cordova-browser/pull/47 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 73ccdf6..0690709 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,6 +3,7 @@ sudo: false node_js: - "4" - "6" + - "8" install: - npm install script: diff --git a/appveyor.yml b/appveyor.yml index 7e9a925..9a6d5a4 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -24,6 +24,7 @@ environment: matrix: - nodejs_version: "4" - nodejs_version: "6" + - nodejs_version: "8" install: - ps: Install-Product node $env:nodejs_version This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225689#comment-16225689 ] ASF subversion and git services commented on CB-13501: -- Commit 575ea95e58dc69a63d733767fd66422d7d7e9d40 in cordova-create's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-create.git;h=575ea95 ] CB-13501 : added support for node 8 > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225683#comment-16225683 ] ASF GitHub Bot commented on CB-13501: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/288 > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225682#comment-16225682 ] ASF subversion and git services commented on CB-13501: -- Commit e2e42fd10bbcda65db27be4d3e5e8c998d1beaa3 in cordova-cli's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=e2e42fd ] CB-13501 : updated to include node 8 > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225373#comment-16225373 ] ASF GitHub Bot commented on CB-13501: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-js/pull/150 CB-13501 : added support for node 8 ### Platforms affected ### What does this PR do? Added support for node 8 ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-js CB-13501 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/150.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #150 > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225362#comment-16225362 ] ASF GitHub Bot commented on CB-13501: - codecov-io commented on issue #414: CB-13501 : update appveyor to support node 8 URL: https://github.com/apache/cordova-android/pull/414#issuecomment-340519642 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/414?src=pr&el=h1) Report > Merging [#414](https://codecov.io/gh/apache/cordova-android/pull/414?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/04fa5d3febe69d7adc91d1e603118f3d33af2606?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-android/pull/414?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #414 +/- ## === Coverage 43.77% 43.77% === Files 17 17 Lines1688 1688 Branches 307 307 === Hits 739 739 Misses949 949 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/414?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/414?src=pr&el=footer). Last update [04fa5d3...b2a81c0](https://codecov.io/gh/apache/cordova-android/pull/414?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13482) Not asking for android permission.
[ https://issues.apache.org/jira/browse/CB-13482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishal Mishra updated CB-13482: --- Labels: Triaged (was: ) > Not asking for android permission. > -- > > Key: CB-13482 > URL: https://issues.apache.org/jira/browse/CB-13482 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media-capture >Reporter: kushal chandel > Labels: Triaged > > While using media plugin captureVideo it is not asking for android permission. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225353#comment-16225353 ] ASF GitHub Bot commented on CB-13501: - audreyso opened a new pull request #47: CB-13501 : added support for node 8 URL: https://github.com/apache/cordova-browser/pull/47 ### Platforms affected ### What does this PR do? Added support for node 8 ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13482) Not asking for android permission.
[ https://issues.apache.org/jira/browse/CB-13482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225354#comment-16225354 ] Vishal Mishra commented on CB-13482: Can you provide more details about the problem. Android version? Device? Steps to reproduce ? > Not asking for android permission. > -- > > Key: CB-13482 > URL: https://issues.apache.org/jira/browse/CB-13482 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media-capture >Reporter: kushal chandel > Labels: Triaged > > While using media plugin captureVideo it is not asking for android permission. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225323#comment-16225323 ] ASF GitHub Bot commented on CB-13501: - audreyso opened a new pull request #414: CB-13501 : update appveyor to support node 8 URL: https://github.com/apache/cordova-android/pull/414 ### Platforms affected ### What does this PR do? Update appveyor to support node 8 ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13478) Windows line endings in cordova-lib
[ https://issues.apache.org/jira/browse/CB-13478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So resolved CB-13478. Resolution: Fixed > Windows line endings in cordova-lib > --- > > Key: CB-13478 > URL: https://issues.apache.org/jira/browse/CB-13478 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: cordova@7.0.0 >Reporter: Jarrad Whitaker >Priority: Trivial > Labels: lint > Original Estimate: 1h > Remaining Estimate: 1h > > A few files in cordova-lib have snuck in with CRLFs. > I will open a pr with > - eslint set to error on crlfs > - gitattributes to prevent more crlfs > - files with crlf translated to lf -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13478) Windows line endings in cordova-lib
[ https://issues.apache.org/jira/browse/CB-13478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225272#comment-16225272 ] Audrey So commented on CB-13478: Closing this issue since it has been merged in. Thanks! > Windows line endings in cordova-lib > --- > > Key: CB-13478 > URL: https://issues.apache.org/jira/browse/CB-13478 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: cordova@7.0.0 >Reporter: Jarrad Whitaker >Priority: Trivial > Labels: lint > Original Estimate: 1h > Remaining Estimate: 1h > > A few files in cordova-lib have snuck in with CRLFs. > I will open a pr with > - eslint set to error on crlfs > - gitattributes to prevent more crlfs > - files with crlf translated to lf -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12863) Can't install plugins from a branch (cordova@7)
[
https://issues.apache.org/jira/browse/CB-12863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225019#comment-16225019
]
antonio miranda commented on CB-12863:
--
I face this issue using 7.1.0 When downgrading to 7.0.1 it works.
> Can't install plugins from a branch (cordova@7)
> ---
>
> Key: CB-12863
> URL: https://issues.apache.org/jira/browse/CB-12863
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-fetch
> Environment: cordova-cli@7.0.1
> node@4.6.0
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Labels: cordova-8.0.0, reproduced, triage
> Fix For: cordova-labs-wkwebview-engine-localhost@0.5.1
>
>
> 1st try:
> {code}
> $ cordova plugin add
> https://github.com/apache/cordova-plugins.git\#wkwebview-engine-localhost
> Installing "cordova-labs-wkwebview-engine-localhost" for ios
> Failed to install 'cordova-labs-wkwebview-engine-localhost': CordovaError:
> Failed to fetch plugin
> https://git-wip-us.apache.org/repos/asf/cordova-plugins.git#local-webserver
> via registry.
> Probably this is either a connection problem, or plugin spec is incorrect.
> Check your connection and plugin name/version/URL.
> Error: npm: Command failed with exit code 254 Error output:
> npm WARN package.json helloworld@1.0.0 No repository field.
> npm WARN package.json helloworld@1.0.0 No README data
> npm ERR! not a package
> /var/folders/40/pyxnqlcj6bn_43qrjp3p0xtwgp/T/npm-28533-ff14b1ee/git-wip-us.apache.org/repos/asf/cordova-plugins.git/local-webserver
> npm ERR! Darwin 16.7.0
> npm ERR! argv "/Users/shazron/.nvm/versions/node/v4.6.0/bin/node"
> "/Users/shazron/.nvm/versions/node/v4.6.0/bin/npm" "install"
> "https://git-wip-us.apache.org/repos/asf/cordova-plugins.git#local-webserver";
> "--save"
> npm ERR! node v4.6.0
> npm ERR! npm v2.15.9
> npm ERR! path
> /var/folders/40/pyxnqlcj6bn_43qrjp3p0xtwgp/T/npm-28533-ff14b1ee/unpack-968d75f9eab2/package.json
> npm ERR! code ENOENT
> npm ERR! errno -2
> npm ERR! syscall open
> npm ERR! enoent ENOENT: no such file or directory, open
> '/var/folders/40/pyxnqlcj6bn_43qrjp3p0xtwgp/T/npm-28533-ff14b1ee/unpack-968d75f9eab2/package.json'
> npm ERR! enoent This is most likely not a problem with npm itself
> npm ERR! enoent and is related to npm not being able to find a file.
> npm ERR! enoent
> npm ERR! Please include the following file with any support request:
> npm ERR! /Users/shazron/Desktop/gtm/node_modules/npm-debug.log
> at
> /Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:205:33
> at _rejected
> (/Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:864:24)
> at
> /Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:890:30
> at Promise.when
> (/Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:1142:31)
> at Promise.promise.promiseDispatch
> (/Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:808:41)
> at
> /Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:624:44
> at runSingle
> (/Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:137:13)
> at flush
> (/Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:125:13)
> at nextTickCallbackWith0Args (node.js:420:9)
> at process._tickCallback (node.js:349:13)
> Error: Failed to fetch plugin
> https://git-wip-us.apache.org/repos/asf/cordova-plugins.git#local-webserver
> via registry.
> Probably this is either a connection problem, or plugin spec is incorrect.
> Check your connection and plugin name/version/URL.
> Error: npm: Command failed with exit code 254 Error output:
> npm WARN package.json helloworld@1.0.0 No repository field.
> npm WARN package.json helloworld@1.0.0 No README data
> npm ERR! not a package
> /var/folders/40/pyxnqlcj6bn_43qrjp3p0xtwgp/T/npm-28533-ff14b1ee/git-wip-us.apache.org/repos/asf/cordova-plugins.git/local-webserver
> npm ERR! Darwin 16.7.0
> npm ERR! argv "/Users/shazron/.nvm/versions/node/v4.6.0/bin/node"
> "/Users/shazron/.nvm/versions/node/v4.6.0/bin/npm" "install"
> "https://git-wip-us.apache.org/repos/asf/cordova-plugins.git#local-webserver";
> "--save"
> npm ERR! node v4.6.0
> npm ERR! npm v2.15
[jira] [Commented] (CB-11244) Update Android Project Structure to be more compatible with Android Studio
[ https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224860#comment-16224860 ] ASF GitHub Bot commented on CB-11244: - macdonst commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-340433367 @infil00p I've run the following commands: ``` cordova create androidTest cd ./androidTest cordova platform add git://github.com/infil00p/cordova-android.git#StudioProjectCompat cordova plugin add phonegap-plugin-push@2.0.0 ``` which resulted in the following error: ``` Installing "phonegap-plugin-push" for android Android Studio project detected Failed to install 'phonegap-plugin-push': Error: Unable to graft xml at selector "/manifest" from "/Users/smacdona/code/androidTest/platforms/android/app/src/main/res/xml/config.xml" during config install at ConfigFile_graft_child [as graft_child] (/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigFile.js:122:19) at PlatformMunger_apply_file_munge [as apply_file_munge] (/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:81:34) at munge_helper (/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:236:14) at PlatformMunger.add_plugin_changes (/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:157:12) at /Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:123:29 at _fulfilled (/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/q/q.js:854:54) at self.promiseDispatch.done (/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/q/q.js:883:30) at Promise.promise.promiseDispatch (/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/q/q.js:816:13) at /Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/q/q.js:877:14 at runSingle (/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/q/q.js:137:13) Error: Unable to graft xml at selector "/manifest" from "/Users/smacdona/code/androidTest/platforms/android/app/src/main/res/xml/config.xml" during config install ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update Android Project Structure to be more compatible with Android Studio > -- > > Key: CB-11244 > URL: https://issues.apache.org/jira/browse/CB-11244 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Blocker > Labels: CordovaAndroidSix, android-next > > Currently our existing Android projects have the old Android Project > structure created by default, even for new projects, which makes no sense > since we no longer support Eclipse as the default project editor and have > moved to Android Studio for Android development. > The main reason for doing this is to clean up dependencies and to allow for > projects and dependencies to work more like how modern Android projects work > and to remove as much custom Gradle code as possible. This would also allow > us in the future to move towards having Android Plugin code work as Android > Libraries with Resources instead of just copying things across, which gives > us the ability to add JUnit tests and bundled resources. This would > dramatically increase the quality of plugins such as InAppBrowser, and third > party plugins such as the Barcode Scanner. > This would have to be done on the next major version, and the upgrade would > be tricky to do. However, the benefits at this point would greatly outweigh > the costs of maintaining the old project structure. The old cordova-common > code in Cordova-Android 5.0.x would allow for plugins in the short term to > work with both projects until we get the new project structure ready. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13508) Unable to load PlatformApi from platform
Varacca created CB-13508: Summary: Unable to load PlatformApi from platform Key: CB-13508 URL: https://issues.apache.org/jira/browse/CB-13508 Project: Apache Cordova Issue Type: Bug Components: cordova-ios Affects Versions: cordova@7.1.0 Reporter: Varacca Assignee: Suraj Pindoria Hello, I'm running under cordova@7.1.0, cordova-ios@4.5.2. Installed platforms: ios 4.5.2. I run npm install, bower install then cordova prepare ios and i get the following error: Unable to load PlatformApi from platform. Error: Cannot find module 'unorm' Error: Unhandled "error" event. (The platform "ios" does not appear to be a valid cordova platform. It is missing API.js. ios not supported.) The solution is to cordova platform rm ios and cordova platform add ios. But i have to do this each time i checkout my project from git ... Do you have any suggestion to solve this issue? Best regards ! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13507) git+https or git+ssh fails when trying to install
Pablo Caselas created CB-13507: -- Summary: git+https or git+ssh fails when trying to install Key: CB-13507 URL: https://issues.apache.org/jira/browse/CB-13507 Project: Apache Cordova Issue Type: Bug Components: AllPlatforms Affects Versions: 7.0.2 Environment: I am selecting 7.0.2 since it's the closest but I am running cordova 7.1.0 OS: Mac OS X Sierra. Although I don't think it has anything to do with cordova-ios and cordova-android, my platform versions are: - android 6.3.0 - ios 4.5.2 Reporter: Pablo Caselas Fix For: 7.0.2 I start with adding plugin dependencies with https://.. on package.json (no plugin references on config.xml) and no platforms or plugins installed then I run "cordova platform ios". It installs the plugins without any problem, but changes config.xml and package.json plugin references from https to git+https, and ssh to git+ssh. Failed to restore plugin "cordova-plugin-document-viewer" from config.xml. You might need to try adding it again. Error: Failed to fetch plugin git+https://github.com/kas84/cordova-plugin-document-viewer.git via registry -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13497) Ionic Cordova Android build broken after gradle dependencies update: Execution failed for task ‘:processDebugResources’. > com.android.ide.common.process.ProcessException
[
https://issues.apache.org/jira/browse/CB-13497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224447#comment-16224447
]
Michael Dudek commented on CB-13497:
FYI: I finally found solution for this issue in my project. Just check all your
plugins for referencing of 'com.android.support:support-v4'. Setup all usages
to 'com.android.support:support-v4:23+'.
> Ionic Cordova Android build broken after gradle dependencies update:
> Execution failed for task ‘:processDebugResources’. >
> com.android.ide.common.process.ProcessException: Failed to execute aapt
> --
>
> Key: CB-13497
> URL: https://issues.apache.org/jira/browse/CB-13497
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
> Environment: Ionic Cordova Android
> Markopc:Passarola - Android masamocevic$ ionic info
> cli packages: (/Users/masamocevic/Desktop/Passarola - Android/node_modules)
> @ionic/cli-utils : 1.15.1
> ionic (Ionic CLI) : 3.15.1
> global packages:
> cordova (Cordova CLI) : 7.1.0
> local packages:
> @ionic/app-scripts : 1.3.7
> Cordova Platforms : android 6.2.3 ios 4.4.0
> Ionic Framework: ionic-angular 3.2.1
> System:
> Android SDK Tools : 26.1.1
> ios-deploy: 1.9.2
> Node : v6.11.2
> npm : 5.3.0
> OS: macOS Sierra
> Xcode : Xcode 8.3.3 Build version 8E3004b
> Environment Variables:
> ANDROID_HOME : /Users/masamocevic/Library/Android/sdk
> Misc:
> backend : legacy
> Markopc:Passarola - Android masamocevic$
>Reporter: Boris Isaic
>Assignee: Joe Bowser
>
> Hi, I recently ran the command “ionic cordova run android” and gradle tried
> to download some dependecies:
> {code}
> Incremental java compilation is an incubating feature.
> Download
> https://maven.google.com/com/android/support/support-v4/27.0.0/support-v4-27.0.0.pom
> Download
> https://maven.google.com/com/android/support/customtabs/27.0.0/customtabs-27.0.0.pom
> Download
> https://maven.google.com/com/android/support/support-compat/27.0.0/support-compat-27.0.0.pom
> Download
> https://maven.google.com/com/android/support/support-media-compat/27.0.0/support-media-compat-27.0.0.pom
> Download
> https://maven.google.com/com/android/support/support-core-utils/27.0.0/support-core-utils-27.0.0.pom
> Download
> https://maven.google.com/com/android/support/support-core-ui/27.0.0/support-core-ui-27.0.0.pom
> Download
> https://maven.google.com/com/android/support/support-fragment/27.0.0/support-fragment-27.0.0.pom
> Download
> https://maven.google.com/com/android/support/support-annotations/27.0.0/support-annotations-27.0.0.pom
> Download
> https://maven.google.com/com/android/support/support-annotations/27.0.0/support-annotations-27.0.0.jar
> Download
> https://maven.google.com/com/android/support/support-compat/27.0.0/support-compat-27.0.0.aar
> Download
> https://maven.google.com/com/android/support/support-media-compat/27.0.0/support-media-compat-27.0.0.aar
> Download
> https://maven.google.com/com/android/support/support-core-utils/27.0.0/support-core-utils-27.0.0.aar
> Download
> https://maven.google.com/com/android/support/support-core-ui/27.0.0/support-core-ui-27.0.0.aar
> Download
> https://maven.google.com/com/android/support/support-fragment/27.0.0/support-fragment-27.0.0.aar
> Download
> https://maven.google.com/com/android/support/support-v4/27.0.0/support-v4-27.0.0.aar
> Download
> https://maven.google.com/com/android/support/customtabs/27.0.0/customtabs-27.0.0.aar
> {code}
> After that, at the end the build fails with this message:
> {code}
> ERROR: In FontFamilyFont, unable to find attribute
> android:font
> ERROR: In FontFamilyFont, unable to find attribute
> android:fontStyle
> ERROR: In FontFamilyFont, unable to find attribute
> android:fontWeight
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':processDebugResources'.
> > com.android.ide.common.process.ProcessException: Failed to execute aapt
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output.
> [ERROR] An error occurred while running cordova run android (exit code 1).
> {code}
> I open an issue on ionicframework - but after the troubleshooting they told
> me that this is cordova problem.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
