[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250878#comment-16250878 ] ASF GitHub Bot commented on CB-13543: - stevengill commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150739381 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,22 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. Review comment: Right now it is using my creds. The password is stored as an encrypted variable on travis. We haven't chatted with Infra yet. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13528) Cordova-Android Platform Release November 2, 2017
[ https://issues.apache.org/jira/browse/CB-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser resolved CB-13528. - Resolution: Fixed Cordova-Android 6.4.0 has been released. > Cordova-Android Platform Release November 2, 2017 > - > > Key: CB-13528 > URL: https://issues.apache.org/jira/browse/CB-13528 > Project: Apache Cordova > Issue Type: Task > Components: cordova-android >Affects Versions: 6.3.0 >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Blocker > Fix For: 6.4.0 > > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13568) Update from Cordova file transfer plugin crash Phonegap build for Android
[ https://issues.apache.org/jira/browse/CB-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser resolved CB-13568. - Resolution: Invalid The file plugin is required for File Transfer to work. This problem does not exist on Cordova, since it is marked as a dependency, and this most likely is a PGB problem. Try installing the File plugin on your project to resolve this issue. > Update from Cordova file transfer plugin crash Phonegap build for Android > - > > Key: CB-13568 > URL: https://issues.apache.org/jira/browse/CB-13568 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-cli >Affects Versions: 6.3.0, cordova-cli@6.4.0, cordova@7.0.0 > Environment: Android for all Phonegap build >Reporter: clarklight >Assignee: Joe Bowser >Priority: Critical > > The recent update for the file-transfer plugin started crashing the phonegap > build for android today. Last stable build was on Friday. It produce the > error below. > (More than 19 people had reported the same issue on the adobe forum with no > one assigned, > https://forums.adobe.com/thread/2410942?start=0=0 > https://forums.adobe.com/thread/2411286) > :generateDebugSources > :incrementalDebugJavaCompilationSafeguard > :compileDebugJavaWithJavac > :compileDebugJavaWithJavac - is not incremental (e.g. outputs have changed, > no previous execution, etc.). > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:49: error: > package org.apache.cordova.file does not exist > import org.apache.cordova.file.FileUtils; > ^ > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: > cannot find symbol > FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); > ^ > symbol: class FileUtils > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: > cannot find symbol > FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); > ^ > symbol: class FileUtils > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > Note: Some input files use unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > 3 errors > :compileDebugJavaWithJavac FAILED > > FAILURE: Build failed with an exception. > > * What went wrong: > Execution failed for task ':compileDebugJavaWithJavac'. > > Compilation failed; see the compiler error output for details. > > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. > > BUILD FAILED > > Total time: 6.438 secs > Error: /project/gradlew: Command failed with exit code 1 Error output: > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > warning: string 'menu_settings' has no default translation. > Warning: AndroidManifest.xml already defines debuggable (in > http://schemas.android.com/apk/res/android); using existing value in manifest. > > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:49: error: > package org.apache.cordova.file does not exist > import org.apache.cordova.file.FileUtils; > ^ > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: > cannot find symbol > FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); > ^ > symbol: class FileUtils > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: > cannot find symbol > FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); > ^ > symbol: class FileUtils > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > Note: Some input files use unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > 3 errors > > FAILURE: Build failed with an exception. > > * What went wrong: > Execution failed for task ':compileDebugJavaWithJavac'. > > Compilation failed; see the compiler error output for details. > > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. > at ChildProcess.whenDone > (/project/cordova/node_modules/cordova-common/src/superspawn.js:169:23) > at emitTwo (events.js:106:13) > at ChildProcess.emit (events.js:191:7) > at maybeClose (internal/child_process.js:877:16) > at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional
[jira] [Resolved] (CB-13566) G:\Mobile\colombia\platforms\android\src\org\chromium\customtabsclient\shared\CustomTabsHelper.java:77: error: diamond operator is not supported in -source use -source 7 o
[ https://issues.apache.org/jira/browse/CB-13566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser resolved CB-13566. - Resolution: Won't Fix This is an issue with a Cordova Plugin that's using language features not supported by Cordova. Cordova currently is stuck with Java 1.6 compatibility until the next major version when it will go up to Java 1.8 > G:\Mobile\colombia\platforms\android\src\org\chromium\customtabsclient\shared\CustomTabsHelper.java:77: > error: diamond operator is not supported in -source use -source 7 or higher > to enable diamond operator > -- > > Key: CB-13566 > URL: https://issues.apache.org/jira/browse/CB-13566 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-7 > Environment: G:\Mobile\colombia>cordova platform ls > Installed platforms: > android 6.3.0 > Available platforms: > blackberry10 ~3.8.0 (deprecated) > browser ~5.0.0 > ios ~4.5.1 > osx ~4.0.1 > ubuntu ~4.3.4 (deprecated) > webos ~3.7.0 > windows ~5.0.0 > www ^3.12.0 > G:\Mobile\colombia>cordova plugin ls > com.virtualartifacts.webintent 1.0.0 "WebIntent" > cordova-plugin-camera 3.0.0 "Camera" > cordova-plugin-dialogs 1.3.4 "Notification" > cordova-plugin-file 5.0.0 "File" > cordova-plugin-file-transfer 1.7.0 "File Transfer" > cordova-plugin-inappbrowser 1.7.2 "InAppBrowser" > cordova-plugin-network-information 1.3.4 "Network Information" > cordova-plugin-safariviewcontroller 1.4.7 "SafariViewController" > cordova-plugin-whitelist 1.3.3 "Whitelist" > phonegap-plugin-push 2.1.0 "PushPlugin" > G:\Mobile\colombia>cordova --version > 7.1.0 >Reporter: Krishna >Assignee: Joe Bowser > > Error: cmd: Command failed with exit code 1 Error output: > G:\Mobile\colombia\platforms\android\src\org\chromium\customtabsclient\shared\CustomTabsHelper.java:77: > error: diamond operator is not supported in -source 1.6 List > packagesSupportingCustomTabs = new ArrayList<>(); > ^ (use -source 7 or higher to enable > diamond operator) > G:\Mobile\colombia\platforms\android\src\org\chromium\customtabsclient\shared\ServiceConnection.java:32: > error: diamond operator is not supported in -source 1.6 > mConnectionCallback = new WeakReference<>(connectionCallback); > ^ (use -source 7 or higher to enable > diamond operator) 2 errors FAILURE: Build failed with an exception. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13568) Update from Cordova file transfer plugin crash Phonegap build for Android
[ https://issues.apache.org/jira/browse/CB-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] clarklight updated CB-13568: Description: The recent update for the file-transfer plugin started crashing the phonegap build for android today. Last stable build was on Friday. It produce the error below. (More than 19 people had reported the same issue on the adobe forum with no one assigned, https://forums.adobe.com/thread/2410942?start=0=0 https://forums.adobe.com/thread/2411286) :generateDebugSources :incrementalDebugJavaCompilationSafeguard :compileDebugJavaWithJavac :compileDebugJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.). /project/src/org/apache/cordova/filetransfer/FileTransfer.java:49: error: package org.apache.cordova.file does not exist import org.apache.cordova.file.FileUtils; ^ /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: cannot find symbol FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); ^ symbol: class FileUtils /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: cannot find symbol FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); ^ symbol: class FileUtils Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. 3 errors :compileDebugJavaWithJavac FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileDebugJavaWithJavac'. > Compilation failed; see the compiler error output for details. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 6.438 secs Error: /project/gradlew: Command failed with exit code 1 Error output: Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. warning: string 'menu_settings' has no default translation. Warning: AndroidManifest.xml already defines debuggable (in http://schemas.android.com/apk/res/android); using existing value in manifest. /project/src/org/apache/cordova/filetransfer/FileTransfer.java:49: error: package org.apache.cordova.file does not exist import org.apache.cordova.file.FileUtils; ^ /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: cannot find symbol FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); ^ symbol: class FileUtils /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: cannot find symbol FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); ^ symbol: class FileUtils Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. 3 errors FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileDebugJavaWithJavac'. > Compilation failed; see the compiler error output for details. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. at ChildProcess.whenDone (/project/cordova/node_modules/cordova-common/src/superspawn.js:169:23) at emitTwo (events.js:106:13) at ChildProcess.emit (events.js:191:7) at maybeClose (internal/child_process.js:877:16) at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5) was: The recent update for the file-transfer plugin started crashing the phonegap build for android today. Last stable build was on Friday. It produce the error below. :generateDebugSources :incrementalDebugJavaCompilationSafeguard :compileDebugJavaWithJavac :compileDebugJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.). /project/src/org/apache/cordova/filetransfer/FileTransfer.java:49: error: package org.apache.cordova.file does not exist import org.apache.cordova.file.FileUtils; ^ /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: cannot find symbol FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); ^ symbol: class FileUtils /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: cannot find symbol FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); ^ symbol: class FileUtils Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. 3 errors :compileDebugJavaWithJavac FAILED FAILURE: Build failed with an exception. * What went wrong:
[jira] [Created] (CB-13568) Update from Cordova file transfer plugin crash Phonegap build for Android
clarklight created CB-13568: --- Summary: Update from Cordova file transfer plugin crash Phonegap build for Android Key: CB-13568 URL: https://issues.apache.org/jira/browse/CB-13568 Project: Apache Cordova Issue Type: Bug Components: cordova-android, cordova-cli Affects Versions: cordova@7.0.0, 6.3.0, cordova-cli@6.4.0 Environment: Android for all Phonegap build Reporter: clarklight Assignee: Joe Bowser Priority: Critical The recent update for the file-transfer plugin started crashing the phonegap build for android today. Last stable build was on Friday. It produce the error below. :generateDebugSources :incrementalDebugJavaCompilationSafeguard :compileDebugJavaWithJavac :compileDebugJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.). /project/src/org/apache/cordova/filetransfer/FileTransfer.java:49: error: package org.apache.cordova.file does not exist import org.apache.cordova.file.FileUtils; ^ /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: cannot find symbol FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); ^ symbol: class FileUtils /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: cannot find symbol FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); ^ symbol: class FileUtils Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. 3 errors :compileDebugJavaWithJavac FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileDebugJavaWithJavac'. > Compilation failed; see the compiler error output for details. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 6.438 secs Error: /project/gradlew: Command failed with exit code 1 Error output: Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. warning: string 'menu_settings' has no default translation. Warning: AndroidManifest.xml already defines debuggable (in http://schemas.android.com/apk/res/android); using existing value in manifest. /project/src/org/apache/cordova/filetransfer/FileTransfer.java:49: error: package org.apache.cordova.file does not exist import org.apache.cordova.file.FileUtils; ^ /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: cannot find symbol FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); ^ symbol: class FileUtils /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: cannot find symbol FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); ^ symbol: class FileUtils Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. 3 errors FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileDebugJavaWithJavac'. > Compilation failed; see the compiler error output for details. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. at ChildProcess.whenDone (/project/cordova/node_modules/cordova-common/src/superspawn.js:169:23) at emitTwo (events.js:106:13) at ChildProcess.emit (events.js:191:7) at maybeClose (internal/child_process.js:877:16) at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250754#comment-16250754 ] ASF GitHub Bot commented on CB-13543: - dblotsky commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150727825 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,22 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test Review comment: You probably also want to run `gulp build` locally before committing, or have `npm test` run it for you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250753#comment-16250753 ] ASF GitHub Bot commented on CB-13543: - dblotsky commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150728151 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,22 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. Review comment: Whose SVN account is on Travis, and is it ok with infra that it's there? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250750#comment-16250750 ] ASF GitHub Bot commented on CB-13543: - dblotsky commented on issue #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#issuecomment-344132720 @janpio @stevengill is Infra ok with an SVN password being on Travis? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11248) InAppBrowser no focus on input text fields
[ https://issues.apache.org/jira/browse/CB-11248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250734#comment-16250734 ] ASF GitHub Bot commented on CB-11248: - candidoalbertosilva commented on issue #214: CB-11248 InAppBrowser no focus on input text fields URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/214#issuecomment-344131249 @varshatyagi I was using build.phonegap.com and I think that was the problem. I started using the cordova command line in my computer with the updated Android SDK and it worked perfectly. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > InAppBrowser no focus on input text fields > -- > > Key: CB-11248 > URL: https://issues.apache.org/jira/browse/CB-11248 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: 1.4.0 > Environment: Cordova CLI, Android, Android Studio >Reporter: Mo Pages >Assignee: Sergey Shakhnazarov >Priority: Minor > Labels: android, reproduced, triaged > > When opening a webpage with a form in the Cordova default webview or system > webview focus on an input text box works as normal - a cursor is displayed > (and if there's any js list its displayed). However when using the > InAppBrowser the focus cursor does not display at all when you click in a > text box...the keyboard comes up but no focus cursor. > I've tried injecting js to focus on the text box but this doesn't do > anything..Also it makes no difference what value the option > keyboardDisplayRequiresUserAction is given...Is there a fix for this? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13567) Cannot add plugin from git+ssh URL
[ https://issues.apache.org/jira/browse/CB-13567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Regueiro updated CB-13567: Description: I cannot add a plugin to Cordova using a git+ssh URL. The following error is returned: {noformat} $ yarn cordova plugin add git+ssh://g...@bitbucket.org/bar/foo.git yarn run v1.3.2 $ /Users/alex/Software/IINU/foo/node_modules/.bin/cordova plugin add git+ssh://g...@bitbucket.org/bar/foo.git Error: Failed to fetch plugin git+ssh://g...@bitbucket.org/bar/foo.git via registry. Probably this is either a connection problem, or plugin spec is incorrect. Check your connection and plugin name/version/URL. Failed to get absolute path to installed module error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. {noformat} However, if I specify the _-nofetch_ argument, it succeeds. This is clearly not ideal going forwards, since _-nofetch_ is considered a backwards-compatibility option. was: I cannot add a plugin to Cordova using a git+ssh URL. The following error is returned: {noformat} $ yarn cordova plugin add git+ssh://g...@bitbucket.org/bar/foo.git yarn run v1.3.2 $ /Users/alex/Software/IINU/foo/node_modules/.bin/cordova plugin add git+ssh://g...@bitbucket.org/bar/foo.git Error: Failed to fetch plugin git+ssh://g...@bitbucket.org/bar/foo.git via registry. Probably this is either a connection problem, or plugin spec is incorrect. Check your connection and plugin name/version/URL. Failed to get absolute path to installed module error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. {noformat} However, if I specify the _--nofetch_ argument, it succeeds. This is clearly not ideal going forwards, since _--nofetch_ is considered a backwards-compatibility option. > Cannot add plugin from git+ssh URL > -- > > Key: CB-13567 > URL: https://issues.apache.org/jira/browse/CB-13567 > Project: Apache Cordova > Issue Type: Bug > Environment: OS X 10.13, Node 8.9.1, NPM 5.5.1, Cordova 7.10 >Reporter: Alexander Regueiro >Priority: Blocker > > I cannot add a plugin to Cordova using a git+ssh URL. The following error is > returned: > {noformat} > $ yarn cordova plugin add git+ssh://g...@bitbucket.org/bar/foo.git > yarn run v1.3.2 > $ /Users/alex/Software/IINU/foo/node_modules/.bin/cordova plugin add > git+ssh://g...@bitbucket.org/bar/foo.git > Error: Failed to fetch plugin git+ssh://g...@bitbucket.org/bar/foo.git via > registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Failed to get absolute path to installed module > error Command failed with exit code 1. > info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this > command. > {noformat} > However, if I specify the _-nofetch_ argument, it succeeds. This is clearly > not ideal going forwards, since _-nofetch_ is considered a > backwards-compatibility option. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13567) Cannot add plugin from git+ssh URL
[ https://issues.apache.org/jira/browse/CB-13567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Regueiro updated CB-13567: Description: I cannot add a plugin to Cordova using a git+ssh URL. The following error is returned: {noformat} $ yarn cordova plugin add git+ssh://g...@bitbucket.org/bar/foo.git yarn run v1.3.2 $ /Users/alex/Software/IINU/foo/node_modules/.bin/cordova plugin add git+ssh://g...@bitbucket.org/bar/foo.git Error: Failed to fetch plugin git+ssh://g...@bitbucket.org/bar/foo.git via registry. Probably this is either a connection problem, or plugin spec is incorrect. Check your connection and plugin name/version/URL. Failed to get absolute path to installed module error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. {noformat} However, if I specify the _--nofetch_ argument, it succeeds. This is clearly not ideal going forwards, since _--nofetch_ is considered a backwards-compatibility option. was: I cannot add a plugin to Cordova using a git+ssh URL. The following error is returned: {noformat} $ yarn cordova plugin add git+ssh://g...@bitbucket.org/bar/foo.git yarn run v1.3.2 $ /Users/alex/Software/IINU/foo/node_modules/.bin/cordova plugin add git+ssh://g...@bitbucket.org/bar/foo.git Error: Failed to fetch plugin git+ssh://g...@bitbucket.org/bar/foo.git via registry. Probably this is either a connection problem, or plugin spec is incorrect. Check your connection and plugin name/version/URL. Failed to get absolute path to installed module error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. {noformat} However, if I specify the `--nofetch` argument, it succeeds. This is clearly not ideal going forwards, since `--nofetch` is considered a backwards-compatibility option. > Cannot add plugin from git+ssh URL > -- > > Key: CB-13567 > URL: https://issues.apache.org/jira/browse/CB-13567 > Project: Apache Cordova > Issue Type: Bug > Environment: OS X 10.13, Node 8.9.1, NPM 5.5.1, Cordova 7.10 >Reporter: Alexander Regueiro >Priority: Blocker > > I cannot add a plugin to Cordova using a git+ssh URL. The following error is > returned: > {noformat} > $ yarn cordova plugin add git+ssh://g...@bitbucket.org/bar/foo.git > yarn run v1.3.2 > $ /Users/alex/Software/IINU/foo/node_modules/.bin/cordova plugin add > git+ssh://g...@bitbucket.org/bar/foo.git > Error: Failed to fetch plugin git+ssh://g...@bitbucket.org/bar/foo.git via > registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Failed to get absolute path to installed module > error Command failed with exit code 1. > info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this > command. > {noformat} > However, if I specify the _--nofetch_ argument, it succeeds. This is clearly > not ideal going forwards, since _--nofetch_ is considered a > backwards-compatibility option. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13567) Cannot add plugin from git+ssh URL
Alexander Regueiro created CB-13567: --- Summary: Cannot add plugin from git+ssh URL Key: CB-13567 URL: https://issues.apache.org/jira/browse/CB-13567 Project: Apache Cordova Issue Type: Bug Environment: OS X 10.13, Node 8.9.1, NPM 5.5.1, Cordova 7.10 Reporter: Alexander Regueiro Priority: Blocker I cannot add a plugin to Cordova using a git+ssh URL. The following error is returned: {noformat} $ yarn cordova plugin add git+ssh://g...@bitbucket.org/bar/foo.git yarn run v1.3.2 $ /Users/alex/Software/IINU/foo/node_modules/.bin/cordova plugin add git+ssh://g...@bitbucket.org/bar/foo.git Error: Failed to fetch plugin git+ssh://g...@bitbucket.org/bar/foo.git via registry. Probably this is either a connection problem, or plugin spec is incorrect. Check your connection and plugin name/version/URL. Failed to get absolute path to installed module error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. {noformat} However, if I specify the `--nofetch` argument, it succeeds. This is clearly not ideal going forwards, since `--nofetch` is considered a backwards-compatibility option. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13566) G:\Mobile\colombia\platforms\android\src\org\chromium\customtabsclient\shared\CustomTabsHelper.java:77: error: diamond operator is not supported in -source use -source 7 or
[ https://issues.apache.org/jira/browse/CB-13566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krishna updated CB-13566: - Environment: G:\Mobile\colombia>cordova platform ls Installed platforms: android 6.3.0 Available platforms: blackberry10 ~3.8.0 (deprecated) browser ~5.0.0 ios ~4.5.1 osx ~4.0.1 ubuntu ~4.3.4 (deprecated) webos ~3.7.0 windows ~5.0.0 www ^3.12.0 G:\Mobile\colombia>cordova plugin ls com.virtualartifacts.webintent 1.0.0 "WebIntent" cordova-plugin-camera 3.0.0 "Camera" cordova-plugin-dialogs 1.3.4 "Notification" cordova-plugin-file 5.0.0 "File" cordova-plugin-file-transfer 1.7.0 "File Transfer" cordova-plugin-inappbrowser 1.7.2 "InAppBrowser" cordova-plugin-network-information 1.3.4 "Network Information" cordova-plugin-safariviewcontroller 1.4.7 "SafariViewController" cordova-plugin-whitelist 1.3.3 "Whitelist" phonegap-plugin-push 2.1.0 "PushPlugin" G:\Mobile\colombia>cordova --version 7.1.0 > G:\Mobile\colombia\platforms\android\src\org\chromium\customtabsclient\shared\CustomTabsHelper.java:77: > error: diamond operator is not supported in -source use -source 7 or higher > to enable diamond operator > -- > > Key: CB-13566 > URL: https://issues.apache.org/jira/browse/CB-13566 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-7 > Environment: G:\Mobile\colombia>cordova platform ls > Installed platforms: > android 6.3.0 > Available platforms: > blackberry10 ~3.8.0 (deprecated) > browser ~5.0.0 > ios ~4.5.1 > osx ~4.0.1 > ubuntu ~4.3.4 (deprecated) > webos ~3.7.0 > windows ~5.0.0 > www ^3.12.0 > G:\Mobile\colombia>cordova plugin ls > com.virtualartifacts.webintent 1.0.0 "WebIntent" > cordova-plugin-camera 3.0.0 "Camera" > cordova-plugin-dialogs 1.3.4 "Notification" > cordova-plugin-file 5.0.0 "File" > cordova-plugin-file-transfer 1.7.0 "File Transfer" > cordova-plugin-inappbrowser 1.7.2 "InAppBrowser" > cordova-plugin-network-information 1.3.4 "Network Information" > cordova-plugin-safariviewcontroller 1.4.7 "SafariViewController" > cordova-plugin-whitelist 1.3.3 "Whitelist" > phonegap-plugin-push 2.1.0 "PushPlugin" > G:\Mobile\colombia>cordova --version > 7.1.0 >Reporter: Krishna >Assignee: Joe Bowser > > Error: cmd: Command failed with exit code 1 Error output: > G:\Mobile\colombia\platforms\android\src\org\chromium\customtabsclient\shared\CustomTabsHelper.java:77: > error: diamond operator is not supported in -source 1.6 List > packagesSupportingCustomTabs = new ArrayList<>(); > ^ (use -source 7 or higher to enable > diamond operator) > G:\Mobile\colombia\platforms\android\src\org\chromium\customtabsclient\shared\ServiceConnection.java:32: > error: diamond operator is not supported in -source 1.6 > mConnectionCallback = new WeakReference<>(connectionCallback); > ^ (use -source 7 or higher to enable > diamond operator) 2 errors FAILURE: Build failed with an exception. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13566) G:\Mobile\colombia\platforms\android\src\org\chromium\customtabsclient\shared\CustomTabsHelper.java:77: error: diamond operator is not supported in -source use -source 7 or
[ https://issues.apache.org/jira/browse/CB-13566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krishna updated CB-13566: - Description: Error: cmd: Command failed with exit code 1 Error output: G:\Mobile\colombia\platforms\android\src\org\chromium\customtabsclient\shared\CustomTabsHelper.java:77: error: diamond operator is not supported in -source 1.6 List packagesSupportingCustomTabs = new ArrayList<>(); ^ (use -source 7 or higher to enable diamond operator) G:\Mobile\colombia\platforms\android\src\org\chromium\customtabsclient\shared\ServiceConnection.java:32: error: diamond operator is not supported in -source 1.6 mConnectionCallback = new WeakReference<>(connectionCallback); ^ (use -source 7 or higher to enable diamond operator) 2 errors FAILURE: Build failed with an exception. > G:\Mobile\colombia\platforms\android\src\org\chromium\customtabsclient\shared\CustomTabsHelper.java:77: > error: diamond operator is not supported in -source use -source 7 or higher > to enable diamond operator > -- > > Key: CB-13566 > URL: https://issues.apache.org/jira/browse/CB-13566 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-7 >Reporter: Krishna >Assignee: Joe Bowser > > Error: cmd: Command failed with exit code 1 Error output: > G:\Mobile\colombia\platforms\android\src\org\chromium\customtabsclient\shared\CustomTabsHelper.java:77: > error: diamond operator is not supported in -source 1.6 List > packagesSupportingCustomTabs = new ArrayList<>(); > ^ (use -source 7 or higher to enable > diamond operator) > G:\Mobile\colombia\platforms\android\src\org\chromium\customtabsclient\shared\ServiceConnection.java:32: > error: diamond operator is not supported in -source 1.6 > mConnectionCallback = new WeakReference<>(connectionCallback); > ^ (use -source 7 or higher to enable > diamond operator) 2 errors FAILURE: Build failed with an exception. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13566) G:\Mobile\colombia\platforms\android\src\org\chromium\customtabsclient\shared\CustomTabsHelper.java:77: error: diamond operator is not supported in -source use -source 7 or
Krishna created CB-13566: Summary: G:\Mobile\colombia\platforms\android\src\org\chromium\customtabsclient\shared\CustomTabsHelper.java:77: error: diamond operator is not supported in -source use -source 7 or higher to enable diamond operator Key: CB-13566 URL: https://issues.apache.org/jira/browse/CB-13566 Project: Apache Cordova Issue Type: Bug Components: cordova-android Affects Versions: cordova-7 Reporter: Krishna Assignee: Joe Bowser -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13505) Update LaunchScreen story board constrains
[ https://issues.apache.org/jira/browse/CB-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250596#comment-16250596 ] ASF GitHub Bot commented on CB-13505: - gdvsbp commented on issue #345: CB-13505: (ios) adjust constraint for launchscreen storyboard URL: https://github.com/apache/cordova-ios/pull/345#issuecomment-344109357 Thanks for the quick response! That ought to be perfect for us. Standing by. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update LaunchScreen story board constrains > -- > > Key: CB-13505 > URL: https://issues.apache.org/jira/browse/CB-13505 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Mike Hartington >Assignee: Suraj Pindoria > Attachments: jump.gif > > > LaunchScreen storyboard constraints were never updated for ios11/iphoneX. > This can cause the splashscreen to jump during startup. Sending a patch for > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13528) Cordova-Android Platform Release November 2, 2017
[ https://issues.apache.org/jira/browse/CB-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250576#comment-16250576 ] ASF subversion and git services commented on CB-13528: -- Commit 455acd18956a2a56e7f50a53b88c7427cc26a03d in cordova-docs's branch refs/heads/master from [~bowserj] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=455acd1 ] CB-13528 Updating docs for installing Cordova Android 6.4.0 > Cordova-Android Platform Release November 2, 2017 > - > > Key: CB-13528 > URL: https://issues.apache.org/jira/browse/CB-13528 > Project: Apache Cordova > Issue Type: Task > Components: cordova-android >Affects Versions: 6.3.0 >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Blocker > Fix For: 6.4.0 > > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13528) Cordova-Android Platform Release November 2, 2017
[ https://issues.apache.org/jira/browse/CB-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250578#comment-16250578 ] ASF subversion and git services commented on CB-13528: -- Commit ffa3a1977d7ae573ca37633be6b8dd2894a167c2 in cordova-docs's branch refs/heads/master from [~bowserj] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=ffa3a19 ] CB-13528: Second draft. Can we post this now? > Cordova-Android Platform Release November 2, 2017 > - > > Key: CB-13528 > URL: https://issues.apache.org/jira/browse/CB-13528 > Project: Apache Cordova > Issue Type: Task > Components: cordova-android >Affects Versions: 6.3.0 >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Blocker > Fix For: 6.4.0 > > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13528) Cordova-Android Platform Release November 2, 2017
[ https://issues.apache.org/jira/browse/CB-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250574#comment-16250574 ] ASF GitHub Bot commented on CB-13528: - stevengill closed pull request #757: CB-13528 Cordova Android 6.4.0 release announcement URL: https://github.com/apache/cordova-docs/pull/757 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/www/_posts/2017-11-09-android-release.md b/www/_posts/2017-11-09-android-release.md new file mode 100644 index 0..d2cad7882 --- /dev/null +++ b/www/_posts/2017-11-09-android-release.md @@ -0,0 +1,35 @@ +--- +layout: post +author: +name: Joe Bowser +url: https://twitter.com/infil00p +title: "Cordova Android 6.4.0 Released!" +categories: announcements +tags: news releases +--- + +We would like to announce that `Cordova Android 6.4.0` has been released! + + +Due to the recent changes **Google** made to Android Studio, Cordova Android now requires that Gradle be installed as a dependency for Android development on all platforms. We will be removing the code that uses Android Studio as a dependency in the near future. This release now uses the latest Android Gradle plugin that was released with Android Studio 3.0. + +**Google** has changed the Gradle DSL used and currently support for the Crosswalk WebView is broken in this version of Cordova as a result. Unfortunately, since Crosswalk is no longer supported by the Crosswalk Project, we do not know whether this issue will be fixed. If you require support for Crosswalk, we recommend that you continue using cordova-android 6.3.0 at this time and avoid using your project with Android Studio. + + +To upgrade: + +npm install -g cordova +cd my_project +cordova platform update android@6.4.0 + +To add it explicitly: + +cordova platform add android@6.4.0 + + +## What's new in Android +* [CB-13289](https://issues.apache.org/jira/browse/CB-13289) Fixing build problems with Studio Three, but keeping **Windows** Gradle fix for now, will be deprecated +* [CB-13289](https://issues.apache.org/jira/browse/CB-13289) Fix test to work with new Google **Android** Gradle DSL +* [CB-13499](https://issues.apache.org/jira/browse/CB-13499) Remove duplicate "setting" in error strings +* [CB-13406](https://issues.apache.org/jira/browse/CB-13406) Fixed AVD API level comparison when choosing sub-par API level match. Added tests for the best_image method. +* [CB-13404](https://issues.apache.org/jira/browse/CB-13404) add **Android**-versions to bundledDependencies. Ignore best emulator selection when parsed AVD information does not include API level in the target diff --git a/www/docs/en/dev/guide/platforms/android/index.md b/www/docs/en/dev/guide/platforms/android/index.md index 0a773ae83..99688b243 100644 --- a/www/docs/en/dev/guide/platforms/android/index.md +++ b/www/docs/en/dev/guide/platforms/android/index.md @@ -43,7 +43,7 @@ few cordova-android releases can be found in this table: cordova-android Version | Supported Android API-Levels | Equivalent Android Version |--|- -6.X.X | 16 - 25 | 4.1 - 7.1.1 +6.X.X | 16 - 26 | 4.1 - 8.0.0 5.X.X | 14 - 23 | 4.0 - 6.0.1 4.1.X | 14 - 22 | 4.0 - 5.1 4.0.X | 10 - 22 | 2.3.3 - 5.1 @@ -69,6 +69,12 @@ or later. When installing on Windows you also need to set `JAVA_HOME` Environment Variable according to your JDK installation path (see [Setting Environment Variables](#setting-environment-variables)) +### Gradle + +As of Cordova-Android 6.4.0, [Gradle](https://gradle.org/install/) is now required to be installed to build Android. + +When installing on Windows, you need to add Gradle to your path, (see [Setting Environment Variables](#setting-environment-variables)) + Android SDK Install [Android Studio][android_studio]. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova-Android Platform Release November 2, 2017 > - > > Key: CB-13528 > URL: https://issues.apache.org/jira/browse/CB-13528 > Project: Apache Cordova > Issue Type: Task > Components: cordova-android >
[jira] [Commented] (CB-13528) Cordova-Android Platform Release November 2, 2017
[ https://issues.apache.org/jira/browse/CB-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250577#comment-16250577 ] ASF subversion and git services commented on CB-13528: -- Commit fd988097b3313c101d9587d30ec5bb3fd71c2658 in cordova-docs's branch refs/heads/master from [~bowserj] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=fd98809 ] CB-13528: Minor language tweak, be more explicit about Crosswalk and Android Studio not getting along > Cordova-Android Platform Release November 2, 2017 > - > > Key: CB-13528 > URL: https://issues.apache.org/jira/browse/CB-13528 > Project: Apache Cordova > Issue Type: Task > Components: cordova-android >Affects Versions: 6.3.0 >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Blocker > Fix For: 6.4.0 > > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13528) Cordova-Android Platform Release November 2, 2017
[ https://issues.apache.org/jira/browse/CB-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250575#comment-16250575 ] ASF subversion and git services commented on CB-13528: -- Commit 9ff16d708fc3fd824486ebf24038121550603f9f in cordova-docs's branch refs/heads/master from [~bowserj] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=9ff16d7 ] CB-13528 Cordova Android 6.4.0 release announcement > Cordova-Android Platform Release November 2, 2017 > - > > Key: CB-13528 > URL: https://issues.apache.org/jira/browse/CB-13528 > Project: Apache Cordova > Issue Type: Task > Components: cordova-android >Affects Versions: 6.3.0 >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Blocker > Fix For: 6.4.0 > > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13528) Cordova-Android Platform Release November 2, 2017
[ https://issues.apache.org/jira/browse/CB-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250579#comment-16250579 ] ASF subversion and git services commented on CB-13528: -- Commit 4a67f2b596d61cba3d5c64e892b3e3a144ed6a87 in cordova-docs's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=4a67f2b ] Merge pull request #757 from infil00p/6.4.0_announce CB-13528 Cordova Android 6.4.0 release announcement > Cordova-Android Platform Release November 2, 2017 > - > > Key: CB-13528 > URL: https://issues.apache.org/jira/browse/CB-13528 > Project: Apache Cordova > Issue Type: Task > Components: cordova-android >Affects Versions: 6.3.0 >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Blocker > Fix For: 6.4.0 > > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13331) Update jira-triage.md in cordova-coho to include necessary labels
[ https://issues.apache.org/jira/browse/CB-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-13331. -- Resolution: Fixed > Update jira-triage.md in cordova-coho to include necessary labels > - > > Key: CB-13331 > URL: https://issues.apache.org/jira/browse/CB-13331 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-coho >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > Labels: easy-fix, in-progress > > Revise and add in additional labels to use when triaging -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13555) (ios) Present notification view controller by inappbrowser view controller
[ https://issues.apache.org/jira/browse/CB-13555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250410#comment-16250410 ] ASF GitHub Bot commented on CB-13555: - jcesarmobile commented on a change in pull request #98: CB-13555 (ios) Present notification view controller by inappbrowser view controller URL: https://github.com/apache/cordova-plugin-dialogs/pull/98#discussion_r150687028 ## File path: src/ios/CDVNotification.m ## @@ -228,9 +228,19 @@ - (void)beep:(CDVInvokedUrlCommand*)command -(UIViewController *)getTopPresentedViewController { UIViewController *presentingViewController = self.viewController; -while(presentingViewController.presentedViewController != nil && ![presentingViewController.presentedViewController isBeingDismissed]) -{ -presentingViewController = presentingViewController.presentedViewController; +if (presentingViewController.view.window != [UIApplication sharedApplication].keyWindow){ +//for wkwebview, the privacy screen plugin is presented from a different window object +presentingViewController = [UIApplication sharedApplication].keyWindow.rootViewController; +while (presentingViewController.presentedViewController != nil && ![presentingViewController.presentedViewController isBeingDismissed]){ +presentingViewController = presentingViewController.presentedViewController; +} +} +else { +//for uiwebview viewcontroller, if inappbrowser or privacyscreen viewcontroller is presented, +//then they should be used to repsent the new view control. +while (presentingViewController.presentedViewController != nil && ![presentingViewController.presentedViewController isBeingDismissed]){ Review comment: This while is the same as in the if, so you can remove the else and put the while outside the if. Also, the comments don't make much sense, can you delete them? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > (ios) Present notification view controller by inappbrowser view controller > -- > > Key: CB-13555 > URL: https://issues.apache.org/jira/browse/CB-13555 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-dialogs >Affects Versions: cordova-ios 4.5.0 > Environment: IOS 10 and 11 >Reporter: Jonathan Li > Labels: dialog, inappbrowser > Fix For: Master > > > When inappbrowser window is shown, if main uiwebview or wkwebview calls > cordova Dialog plugin method to show the dialog view, the dialog should show > to user on top of the inappbrowser view controller. > However, currently the dialog view is shown behind the inappbrowser view, so > user cannot see it or click button on the dialog > An similar issue was reported for barcode scanner plugin at > https://github.com/phonegap/phonegap-plugin-barcodescanner/issues/570 > The issue can be repeated with the below method > function confirm(){ > var win = window.open( "https://www.google.com;, "_blank" ); > win.addEventListener( "loadstop", function() { > setTimeout(function() { > function onConfirm(buttonIndex) { > console.log('You selected button ' + buttonIndex); > } > > navigator.notification.confirm( > 'You are the winner!', // message > onConfirm,// callback to invoke with index of button > pressed > 'Game Over', // title > ['Restart','Exit'] // buttonLabels > ); > }, 1000 ); > }); > } -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250380#comment-16250380 ] ASF GitHub Bot commented on CB-13543: - audreyso opened a new pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760 …loy changes ### Platforms affected ### What does this PR do? Updated instructions/documentation around travis build/deploy ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13554) Unable to launch basic auth popup on the inappbrowser
[ https://issues.apache.org/jira/browse/CB-13554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250337#comment-16250337 ] Jan Piotrowski (Sujan) commented on CB-13554: - Can you test with another domain with BASIC auth? Is your site also reachable without https, but http? Does using http fix the problem? > Unable to launch basic auth popup on the inappbrowser > - > > Key: CB-13554 > URL: https://issues.apache.org/jira/browse/CB-13554 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-browser >Affects Versions: cordova@7.0.0 >Reporter: vikram pottam >Assignee: Jesse MacFadyen > Fix For: Master > > > Unable to launch basic auth popup on the inappbrowser > I am trying to launch a url from using cordova inapp browser , every > enterprise url of my company launches a popup (looks like a basic auth one) > I cant see that popup , > also tried with auth plugin but it did not work as well > this is the error i am getting: > {code} > 017-11-08 11:33:44.024401-0600 mytimeapp[2514:8278454] AuthDialog: > willSendRequestForAuthenticationChallenge 0x60811b80>: Host:"", Server:https, > Auth-Scheme:NSURLAuthenticationMethodNTLM, Realm:sts.cerner.com, Port:443, > Proxy:NO, Proxy-Type:(null) > 2017-11-08 11:33:44.042277-0600 mytimeapp[2514:8278454] AuthDialog: > willSendRequestForAuthenticationChallenge 0x60411310>: Host:"", Server:https, > Auth-Scheme:NSURLAuthenticationMethodServerTrust, Realm:(null), Port:443, > Proxy:NO, Proxy-Type:(null) > 2017-11-08 11:33:44.093841-0600 mytimeapp[2514:8281203] CredStore - > performQuery - Error copying matching creds. Error=-25300, query={ > class = inet; > "m_Limit" = "m_LimitAll"; > ptcl = htps; > "r_Attributes" = 1; > sdmn = ""; > srvr = ""; > sync = syna; > } > 2017-11-08 11:33:44.095529-0600 mytimeapp[2514:8281203] CredStore - > updateOrAddCredential - Error update cred. Error=-25300, query={ > acct = ; > atyp = dflt; > class = inet; > port = 443; > ptcl = htps; > sdmn = ""; > srvr = ""; > }, attrs={ > acct = ; > icmt = default; > labl = ")"; > "v_Data" = <4d61726b 69764031 393838>; > } > 2017-11-08 11:33:44.096822-0600 mytimeapp[2514:8281203] CredStore - > updateOrAddCredential - Error add cred. Error=-50, attrs={ > acct = ; > atyp = dflt; > class = inet; > icmt = default; > labl = ")";; > path = ""; > port = 443; > ptcl = htps; > sdmn = ""; > srvr = ""; > "v_Data" = <4d61726b 69764031 393838>; > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13554) Unable to launch basic auth popup on the inappbrowser
[ https://issues.apache.org/jira/browse/CB-13554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250253#comment-16250253 ] vikram pottam commented on CB-13554: it is basic auth iOS 11 Cordova 7 > Unable to launch basic auth popup on the inappbrowser > - > > Key: CB-13554 > URL: https://issues.apache.org/jira/browse/CB-13554 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-browser >Affects Versions: cordova@7.0.0 >Reporter: vikram pottam >Assignee: Jesse MacFadyen > Fix For: Master > > > Unable to launch basic auth popup on the inappbrowser > I am trying to launch a url from using cordova inapp browser , every > enterprise url of my company launches a popup (looks like a basic auth one) > I cant see that popup , > also tried with auth plugin but it did not work as well > this is the error i am getting: > {code} > 017-11-08 11:33:44.024401-0600 mytimeapp[2514:8278454] AuthDialog: > willSendRequestForAuthenticationChallenge 0x60811b80>: Host:"", Server:https, > Auth-Scheme:NSURLAuthenticationMethodNTLM, Realm:sts.cerner.com, Port:443, > Proxy:NO, Proxy-Type:(null) > 2017-11-08 11:33:44.042277-0600 mytimeapp[2514:8278454] AuthDialog: > willSendRequestForAuthenticationChallenge 0x60411310>: Host:"", Server:https, > Auth-Scheme:NSURLAuthenticationMethodServerTrust, Realm:(null), Port:443, > Proxy:NO, Proxy-Type:(null) > 2017-11-08 11:33:44.093841-0600 mytimeapp[2514:8281203] CredStore - > performQuery - Error copying matching creds. Error=-25300, query={ > class = inet; > "m_Limit" = "m_LimitAll"; > ptcl = htps; > "r_Attributes" = 1; > sdmn = ""; > srvr = ""; > sync = syna; > } > 2017-11-08 11:33:44.095529-0600 mytimeapp[2514:8281203] CredStore - > updateOrAddCredential - Error update cred. Error=-25300, query={ > acct = ; > atyp = dflt; > class = inet; > port = 443; > ptcl = htps; > sdmn = ""; > srvr = ""; > }, attrs={ > acct = ; > icmt = default; > labl = ")"; > "v_Data" = <4d61726b 69764031 393838>; > } > 2017-11-08 11:33:44.096822-0600 mytimeapp[2514:8281203] CredStore - > updateOrAddCredential - Error add cred. Error=-50, attrs={ > acct = ; > atyp = dflt; > class = inet; > icmt = default; > labl = ")";; > path = ""; > port = 443; > ptcl = htps; > sdmn = ""; > srvr = ""; > "v_Data" = <4d61726b 69764031 393838>; > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13505) Update LaunchScreen story board constrains
[ https://issues.apache.org/jira/browse/CB-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250249#comment-16250249 ] ASF GitHub Bot commented on CB-13505: - surajpindoria commented on issue #345: CB-13505: (ios) adjust constraint for launchscreen storyboard URL: https://github.com/apache/cordova-ios/pull/345#issuecomment-344060043 @gdvsbp, I am going to begin the release process today, if all goes well it should be out by the end of the week. But everything going in that release will be coming from master. So if you are in a time crunch then I would suggest just to use master, as that is the same as what will be released. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update LaunchScreen story board constrains > -- > > Key: CB-13505 > URL: https://issues.apache.org/jira/browse/CB-13505 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Mike Hartington >Assignee: Suraj Pindoria > Attachments: jump.gif > > > LaunchScreen storyboard constraints were never updated for ios11/iphoneX. > This can cause the splashscreen to jump during startup. Sending a patch for > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13543: --- Description: Automate build/deploy for cordova-docs Cordova-docs should be built and published automatically on every change Replace jsihnt with eslint Update README.md & update instructions in docs to reflect changes https://issues.apache.org/jira/browse/CB-13162 was: Automate build/deploy for cordova-docs Cordova-docs should be built and published automatically on every change Replace jsihnt with eslint Update README.md https://issues.apache.org/jira/browse/CB-13162 > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13505) Update LaunchScreen story board constrains
[ https://issues.apache.org/jira/browse/CB-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250210#comment-16250210 ] ASF GitHub Bot commented on CB-13505: - Lazza commented on issue #345: CB-13505: (ios) adjust constraint for launchscreen storyboard URL: https://github.com/apache/cordova-ios/pull/345#issuecomment-344051899 @gdvsbp you can use this hook: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-334784983 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update LaunchScreen story board constrains > -- > > Key: CB-13505 > URL: https://issues.apache.org/jira/browse/CB-13505 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Mike Hartington >Assignee: Suraj Pindoria > Attachments: jump.gif > > > LaunchScreen storyboard constraints were never updated for ios11/iphoneX. > This can cause the splashscreen to jump during startup. Sending a patch for > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13505) Update LaunchScreen story board constrains
[ https://issues.apache.org/jira/browse/CB-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250198#comment-16250198 ] ASF GitHub Bot commented on CB-13505: - gdvsbp commented on issue #345: CB-13505: (ios) adjust constraint for launchscreen storyboard URL: https://github.com/apache/cordova-ios/pull/345#issuecomment-344049965 Hi @surajpindoria, is there any update on when this will be included in an official numbered release? We're in the process of launching our app and we need this particular change to fix the splash issue on the iPhone X, but our leadership is concerned about pulling in everything from master just to get this fix. I appreciate all the work you folks are doing and I apologize for hassling you, I'm just hoping to get some info I can deliver to my team. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update LaunchScreen story board constrains > -- > > Key: CB-13505 > URL: https://issues.apache.org/jira/browse/CB-13505 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Mike Hartington >Assignee: Suraj Pindoria > Attachments: jump.gif > > > LaunchScreen storyboard constraints were never updated for ios11/iphoneX. > This can cause the splashscreen to jump during startup. Sending a patch for > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13565) Splashscreen does not work when reloading content
Michael Goffioul created CB-13565: - Summary: Splashscreen does not work when reloading content Key: CB-13565 URL: https://issues.apache.org/jira/browse/CB-13565 Project: Apache Cordova Issue Type: Bug Components: cordova-windows Reporter: Michael Goffioul Assignee: Jesse MacFadyen If the app content is reloaded (e.g. calling "location.reload()"), the splashscreen does not work anymore and generate errors (variable "extendedSplashScreen" is not defined). This is because the "acivated" event has already been fired and "splashscreen.firstShow()" is not called. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13562) Asset tag creates a directory with same name of targeted file
[ https://issues.apache.org/jira/browse/CB-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So resolved CB-13562. Resolution: Fixed > Asset tag creates a directory with same name of targeted file > - > > Key: CB-13562 > URL: https://issues.apache.org/jira/browse/CB-13562 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-browser >Affects Versions: 5.0.1 >Reporter: Simon MacDonald >Assignee: Jesse MacFadyen > Labels: reproduced, triaged > > Asset tag appears to be broken in the browser platform. According to the docs > at http://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#asset when > you add an asset tag like: > {code:xml} > > {code} > it should copy www/foo.js to platforms/browser/www/foo.js but instead it > creates a subdirectory called foo.js and the full path to the file is > platforms/browser/www/foo.js/foo.js. > If you want to duplicate this issue please create a new project then: > cordova platform add browser@5.0.1 > cordova plugin add phonegap-plugin-push > cordova build browser > then you will see that > platforms/browser/www/ServiceWorker.js/ServiceWorker.js exists when it should > be platforms/browser/www/ServiceWorker.js. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13562) Asset tag creates a directory with same name of targeted file
[ https://issues.apache.org/jira/browse/CB-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249908#comment-16249908 ] ASF GitHub Bot commented on CB-13562: - audreyso closed pull request #48: CB-13562 : fixed asset tag when adding push plugin to browser URL: https://github.com/apache/cordova-browser/pull/48 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/bin/template/cordova/browser_handler.js b/bin/template/cordova/browser_handler.js index 6e732c7..3e12c25 100644 --- a/bin/template/cordova/browser_handler.js +++ b/bin/template/cordova/browser_handler.js @@ -115,12 +115,13 @@ module.exports = { asset: { install: function (asset, plugin_dir, wwwDest) { var src = path.join(plugin_dir, asset.src); -if (fs.statSync(src).isDirectory()) { -src = path.join(src, '*'); -} var dest = path.join(wwwDest, asset.target); -shell.cp('-rf', src, dest); +if (fs.statSync(src).isDirectory()) { +shell.cp('-Rf', src + '/*', dest); +} else { +shell.cp('-f', src, dest); +} }, uninstall: function (asset, wwwDest, plugin_id) { shell.rm('-rf', path.join(wwwDest, asset.target)); diff --git a/spec/browser_handler.spec.js b/spec/browser_handler.spec.js new file mode 100644 index 000..70a0682 --- /dev/null +++ b/spec/browser_handler.spec.js @@ -0,0 +1,54 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +*/ + +var browser_handler = require('../bin/template/cordova/browser_handler'); +var shell = require('shelljs'); +var fs = require('fs'); +var path = require('path'); + +describe('Asset install tests', function () { +var fsstatMock; +var asset = { itemType: 'asset', src: 'someSrc/ServiceWorker.js', target: 'ServiceWorker.js' }; +var plugin_dir = 'pluginDir'; +var wwwDest = 'dest'; +var cpPath = path.join(plugin_dir, asset.src); + +it('if src is a directory, should be called with cp, -Rf', function () { +var cp = spyOn(shell, 'cp').and.returnValue('-Rf'); +fsstatMock = { +isDirectory: function () { +return true; +} +}; +spyOn(fs, 'statSync').and.returnValue(fsstatMock); +browser_handler.asset.install(asset, plugin_dir, wwwDest); +expect(cp).toHaveBeenCalledWith('-Rf', jasmine.any(String), path.join('dest', asset.target)); +}); +it('if src is not a directory, should be called with cp, -f', function () { +var cp = spyOn(shell, 'cp').and.returnValue('-f'); +fsstatMock = { +isDirectory: function () { +return false; +} +}; +spyOn(fs, 'statSync').and.returnValue(fsstatMock); +browser_handler.asset.install(asset, plugin_dir, wwwDest); +expect(cp).toHaveBeenCalledWith('-f', cpPath, path.join('dest', asset.target)); +}); +}); This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Asset tag creates a directory with same name of targeted file > - > > Key: CB-13562 > URL: https://issues.apache.org/jira/browse/CB-13562 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-browser >Affects Versions: 5.0.1 >Reporter: Simon MacDonald >Assignee: Jesse MacFadyen > Labels: reproduced, triaged > > Asset tag appears to be broken in the browser platform. According to the docs > at
[jira] [Commented] (CB-13562) Asset tag creates a directory with same name of targeted file
[ https://issues.apache.org/jira/browse/CB-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249910#comment-16249910 ] ASF subversion and git services commented on CB-13562: -- Commit af8b71a6a1667111807a00fc51d8b11f39adc4a9 in cordova-browser's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=af8b71a ] Merge pull request #48 from audreyso/CB-13562 CB-13562 : fixed asset tag when adding push plugin to browser > Asset tag creates a directory with same name of targeted file > - > > Key: CB-13562 > URL: https://issues.apache.org/jira/browse/CB-13562 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-browser >Affects Versions: 5.0.1 >Reporter: Simon MacDonald >Assignee: Jesse MacFadyen > Labels: reproduced, triaged > > Asset tag appears to be broken in the browser platform. According to the docs > at http://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#asset when > you add an asset tag like: > {code:xml} > > {code} > it should copy www/foo.js to platforms/browser/www/foo.js but instead it > creates a subdirectory called foo.js and the full path to the file is > platforms/browser/www/foo.js/foo.js. > If you want to duplicate this issue please create a new project then: > cordova platform add browser@5.0.1 > cordova plugin add phonegap-plugin-push > cordova build browser > then you will see that > platforms/browser/www/ServiceWorker.js/ServiceWorker.js exists when it should > be platforms/browser/www/ServiceWorker.js. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13562) Asset tag creates a directory with same name of targeted file
[ https://issues.apache.org/jira/browse/CB-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249911#comment-16249911 ] ASF subversion and git services commented on CB-13562: -- Commit af8b71a6a1667111807a00fc51d8b11f39adc4a9 in cordova-browser's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=af8b71a ] Merge pull request #48 from audreyso/CB-13562 CB-13562 : fixed asset tag when adding push plugin to browser > Asset tag creates a directory with same name of targeted file > - > > Key: CB-13562 > URL: https://issues.apache.org/jira/browse/CB-13562 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-browser >Affects Versions: 5.0.1 >Reporter: Simon MacDonald >Assignee: Jesse MacFadyen > Labels: reproduced, triaged > > Asset tag appears to be broken in the browser platform. According to the docs > at http://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#asset when > you add an asset tag like: > {code:xml} > > {code} > it should copy www/foo.js to platforms/browser/www/foo.js but instead it > creates a subdirectory called foo.js and the full path to the file is > platforms/browser/www/foo.js/foo.js. > If you want to duplicate this issue please create a new project then: > cordova platform add browser@5.0.1 > cordova plugin add phonegap-plugin-push > cordova build browser > then you will see that > platforms/browser/www/ServiceWorker.js/ServiceWorker.js exists when it should > be platforms/browser/www/ServiceWorker.js. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13562) Asset tag creates a directory with same name of targeted file
[ https://issues.apache.org/jira/browse/CB-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249909#comment-16249909 ] ASF subversion and git services commented on CB-13562: -- Commit 829f4adfa5bf842680ff0c50c007f92a072c4a9b in cordova-browser's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=829f4ad ] CB-13562 : fixed asset tag when adding push plugin to browser > Asset tag creates a directory with same name of targeted file > - > > Key: CB-13562 > URL: https://issues.apache.org/jira/browse/CB-13562 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-browser >Affects Versions: 5.0.1 >Reporter: Simon MacDonald >Assignee: Jesse MacFadyen > Labels: reproduced, triaged > > Asset tag appears to be broken in the browser platform. According to the docs > at http://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#asset when > you add an asset tag like: > {code:xml} > > {code} > it should copy www/foo.js to platforms/browser/www/foo.js but instead it > creates a subdirectory called foo.js and the full path to the file is > platforms/browser/www/foo.js/foo.js. > If you want to duplicate this issue please create a new project then: > cordova platform add browser@5.0.1 > cordova plugin add phonegap-plugin-push > cordova build browser > then you will see that > platforms/browser/www/ServiceWorker.js/ServiceWorker.js exists when it should > be platforms/browser/www/ServiceWorker.js. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13564) Multiple edit-config items for Info.plist causing error
[ https://issues.apache.org/jira/browse/CB-13564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249794#comment-16249794 ] Tom Bell edited comment on CB-13564 at 11/13/17 4:38 PM: - It seems that the entry for this inside `platforms/ios/ios.json` is not created during a prepare, and only when you add a platform, so if you add new `edit-config` it fails until you remove/add a platform, which seems overkill. {code} diff --git a/platforms/ios/ios.json b/platforms/ios/ios.json index 8194271b..3e5b7ec9 100644 --- a/platforms/ios/ios.json +++ b/platforms/ios/ios.json @@ -31,6 +31,14 @@ "id": "config.xml" } ], + "UIStatusBarStyle": [ +{ + "xml": "UIViewControllerBasedStatusBarAppearance", + "count": 1, + "mode": "merge", + "id": "config.xml" +} + ], {code} was (Author: tombell): It seems that the entry for this inside `platforms/ios/ios.json` is not created during a prepare, and only when you add a platform, so if you add new `edit-config` it fails until you remove/add a platform, which seems overkill. {code} diff --git a/platforms/ios/ios.json b/platforms/ios/ios.json index 8194271b..3e5b7ec9 100644 --- a/platforms/ios/ios.json +++ b/platforms/ios/ios.json @@ -31,6 +31,14 @@ "id": "config.xml" } ], + "UIStatusBarStyle": [ +{ + "xml": "UIViewControllerBasedStatusBarAppearance", + "count": 1, + "mode": "merge", + "id": "config.xml" +} + ], "CFBundleURLTypes": [ { "xml": "CFBundleURLSchemescapsulemobile", {code} > Multiple edit-config items for Info.plist causing error > --- > > Key: CB-13564 > URL: https://issues.apache.org/jira/browse/CB-13564 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli >Reporter: Tom Bell > > I am on 7.1.0 of `cordova-cli`, there was no `7.1.0` in the "Affects > Versions" dropdown. > I've updated `cordova-ios` to 4.5.3 and `cordova-plugin-contacts` to 3..0.0, > I've got the following > working: > {code:xml} > target="NSContactsUsageDescription"> > We require permission to access your contacts so you can import > contacts into [redacted] > > {code} > However when I decided to move some stuff from an `after_prepare` hook > script, to use edit-config, it fails with an error `doc.find is not a > function` > {code:xml} > target="NSContactsUsageDescription"> > We require permission to access your contacts so you can import > contacts into [redacted] > > > UIStatusBarStyleLightContent > > {code} > If I take out the additional `` everything works. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13564) Multiple edit-config items for Info.plist causing error
[ https://issues.apache.org/jira/browse/CB-13564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249794#comment-16249794 ] Tom Bell edited comment on CB-13564 at 11/13/17 4:33 PM: - It seems that the entry for this inside `platforms/ios/ios.json` is not created during a prepare, and only when you add a platform, so if you add new `edit-config` it fails until you remove/add a platform, which seems overkill. {code} diff --git a/platforms/ios/ios.json b/platforms/ios/ios.json index 8194271b..3e5b7ec9 100644 --- a/platforms/ios/ios.json +++ b/platforms/ios/ios.json @@ -31,6 +31,14 @@ "id": "config.xml" } ], + "UIStatusBarStyle": [ +{ + "xml": "UIViewControllerBasedStatusBarAppearance", + "count": 1, + "mode": "merge", + "id": "config.xml" +} + ], "CFBundleURLTypes": [ { "xml": "CFBundleURLSchemescapsulemobile", {code} was (Author: tombell): It seems that the entry for this inside `platforms/ios/ios.json` is not created during a prepare, and only when you add a platform, so if you add new `edit-config` it fails until you remove/add a platform, which seems overkill. {code:diff} diff --git a/platforms/ios/ios.json b/platforms/ios/ios.json index 8194271b..3e5b7ec9 100644 --- a/platforms/ios/ios.json +++ b/platforms/ios/ios.json @@ -31,6 +31,14 @@ "id": "config.xml" } ], + "UIStatusBarStyle": [ +{ + "xml": "UIViewControllerBasedStatusBarAppearance", + "count": 1, + "mode": "merge", + "id": "config.xml" +} + ], "CFBundleURLTypes": [ { "xml": "CFBundleURLSchemescapsulemobile", {code} > Multiple edit-config items for Info.plist causing error > --- > > Key: CB-13564 > URL: https://issues.apache.org/jira/browse/CB-13564 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli >Reporter: Tom Bell > > I am on 7.1.0 of `cordova-cli`, there was no `7.1.0` in the "Affects > Versions" dropdown. > I've updated `cordova-ios` to 4.5.3 and `cordova-plugin-contacts` to 3..0.0, > I've got the following > working: > {code:xml} > target="NSContactsUsageDescription"> > We require permission to access your contacts so you can import > contacts into [redacted] > > {code} > However when I decided to move some stuff from an `after_prepare` hook > script, to use edit-config, it fails with an error `doc.find is not a > function` > {code:xml} > target="NSContactsUsageDescription"> > We require permission to access your contacts so you can import > contacts into [redacted] > > > UIStatusBarStyleLightContent > > {code} > If I take out the additional `` everything works. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13564) Multiple edit-config items for Info.plist causing error
[ https://issues.apache.org/jira/browse/CB-13564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249794#comment-16249794 ] Tom Bell commented on CB-13564: --- It seems that the entry for this inside `platforms/ios/ios.json` is not created during a prepare, and only when you add a platform, so if you add new `edit-config` it fails until you remove/add a platform, which seems overkill. {code:diff} diff --git a/platforms/ios/ios.json b/platforms/ios/ios.json index 8194271b..3e5b7ec9 100644 --- a/platforms/ios/ios.json +++ b/platforms/ios/ios.json @@ -31,6 +31,14 @@ "id": "config.xml" } ], + "UIStatusBarStyle": [ +{ + "xml": "UIViewControllerBasedStatusBarAppearance", + "count": 1, + "mode": "merge", + "id": "config.xml" +} + ], "CFBundleURLTypes": [ { "xml": "CFBundleURLSchemescapsulemobile", {code} > Multiple edit-config items for Info.plist causing error > --- > > Key: CB-13564 > URL: https://issues.apache.org/jira/browse/CB-13564 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli >Reporter: Tom Bell > > I am on 7.1.0 of `cordova-cli`, there was no `7.1.0` in the "Affects > Versions" dropdown. > I've updated `cordova-ios` to 4.5.3 and `cordova-plugin-contacts` to 3..0.0, > I've got the following > working: > {code:xml} > target="NSContactsUsageDescription"> > We require permission to access your contacts so you can import > contacts into [redacted] > > {code} > However when I decided to move some stuff from an `after_prepare` hook > script, to use edit-config, it fails with an error `doc.find is not a > function` > {code:xml} > target="NSContactsUsageDescription"> > We require permission to access your contacts so you can import > contacts into [redacted] > > > UIStatusBarStyleLightContent > > {code} > If I take out the additional `` everything works. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13564) Multiple edit-config items for Info.plist causing error
Tom Bell created CB-13564: - Summary: Multiple edit-config items for Info.plist causing error Key: CB-13564 URL: https://issues.apache.org/jira/browse/CB-13564 Project: Apache Cordova Issue Type: Bug Components: cordova-cli Reporter: Tom Bell I am on 7.1.0 of `cordova-cli`, there was no `7.1.0` in the "Affects Versions" dropdown. I've updated `cordova-ios` to 4.5.3 and `cordova-plugin-contacts` to 3..0.0, I've got the following working: {code:xml} We require permission to access your contacts so you can import contacts into [redacted] {code} However when I decided to move some stuff from an `after_prepare` hook script, to use edit-config, it fails with an error `doc.find is not a function` {code:xml} We require permission to access your contacts so you can import contacts into [redacted] UIStatusBarStyleLightContent {code} If I take out the additional `` everything works. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12070) edit-config doesn't work with plist files
[ https://issues.apache.org/jira/browse/CB-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249759#comment-16249759 ] Tom Bell commented on CB-12070: --- [~jcesarmobile] removing/adding the iOS platform seemed to have fixed the issue after updating the plugin > edit-config doesn't work with plist files > - > > Key: CB-12070 > URL: https://issues.apache.org/jira/browse/CB-12070 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Darryl Pogue > Fix For: cordova-lib@6.4.1 > > > Trying to use the {{edit-config}} tag in config.xml to add to the iOS > Info.plist file: > {code} mode="merge"> > > foo > > {code} > It's giving me an error in xml_helpers.js: > {code}Error: TypeError: doc.find is not a function > at Object.resolveParent > (/Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/util/xml-helpers.js:210:26) > at > /Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:464:53 > at Array.forEach (native) > at is_conflicting > (/Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:456:17) > at PlatformMunger.add_config_changes > (/Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:204:33) > at > /Users/dpogue/Coding/cordova-app/node_modules/cordova-lib/src/cordova/prepare.js:127:24 > at _fulfilled > (/Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:834:54) > at self.promiseDispatch.done > (/Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:863:30) > at Promise.promise.promiseDispatch > (/Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:796:13) > at > /Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:604:44{code} > This seems to happen because plist files are turned into JS objects when they > are parsed, rather than XML documents like AndroidManifest.xml or config.xml. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12070) edit-config doesn't work with plist files
[ https://issues.apache.org/jira/browse/CB-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249729#comment-16249729 ] jcesarmobile commented on CB-12070: --- [~tombell] Can you create a new issue for this providing all the information you have? Also, try removing the variable tags that you might have on the config.xml. And removing and adding the platforms might also be good > edit-config doesn't work with plist files > - > > Key: CB-12070 > URL: https://issues.apache.org/jira/browse/CB-12070 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Darryl Pogue > Fix For: cordova-lib@6.4.1 > > > Trying to use the {{edit-config}} tag in config.xml to add to the iOS > Info.plist file: > {code} mode="merge"> > > foo > > {code} > It's giving me an error in xml_helpers.js: > {code}Error: TypeError: doc.find is not a function > at Object.resolveParent > (/Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/util/xml-helpers.js:210:26) > at > /Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:464:53 > at Array.forEach (native) > at is_conflicting > (/Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:456:17) > at PlatformMunger.add_config_changes > (/Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:204:33) > at > /Users/dpogue/Coding/cordova-app/node_modules/cordova-lib/src/cordova/prepare.js:127:24 > at _fulfilled > (/Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:834:54) > at self.promiseDispatch.done > (/Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:863:30) > at Promise.promise.promiseDispatch > (/Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:796:13) > at > /Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:604:44{code} > This seems to happen because plist files are turned into JS objects when they > are parsed, rather than XML documents like AndroidManifest.xml or config.xml. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12070) edit-config doesn't work with plist files
[ https://issues.apache.org/jira/browse/CB-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249722#comment-16249722 ] Tom Bell commented on CB-12070: --- [~jcesarmobile] I'm currently using 7.1.0, it worked prior to updating the contacts plugin, as I added the `` before I updated the plugin (I went from 2.3.1 to 3.0.0 of the cordova-plugin-contacts). > edit-config doesn't work with plist files > - > > Key: CB-12070 > URL: https://issues.apache.org/jira/browse/CB-12070 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Darryl Pogue > Fix For: cordova-lib@6.4.1 > > > Trying to use the {{edit-config}} tag in config.xml to add to the iOS > Info.plist file: > {code} mode="merge"> > > foo > > {code} > It's giving me an error in xml_helpers.js: > {code}Error: TypeError: doc.find is not a function > at Object.resolveParent > (/Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/util/xml-helpers.js:210:26) > at > /Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:464:53 > at Array.forEach (native) > at is_conflicting > (/Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:456:17) > at PlatformMunger.add_config_changes > (/Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:204:33) > at > /Users/dpogue/Coding/cordova-app/node_modules/cordova-lib/src/cordova/prepare.js:127:24 > at _fulfilled > (/Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:834:54) > at self.promiseDispatch.done > (/Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:863:30) > at Promise.promise.promiseDispatch > (/Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:796:13) > at > /Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:604:44{code} > This seems to happen because plist files are turned into JS objects when they > are parsed, rather than XML documents like AndroidManifest.xml or config.xml. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12070) edit-config doesn't work with plist files
[ https://issues.apache.org/jira/browse/CB-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249715#comment-16249715 ] jcesarmobile commented on CB-12070: --- [~tombell] which Cordova CLI version are you using? this was introduced in Cordova CLI 6.5.0 > edit-config doesn't work with plist files > - > > Key: CB-12070 > URL: https://issues.apache.org/jira/browse/CB-12070 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Darryl Pogue > Fix For: cordova-lib@6.4.1 > > > Trying to use the {{edit-config}} tag in config.xml to add to the iOS > Info.plist file: > {code} mode="merge"> > > foo > > {code} > It's giving me an error in xml_helpers.js: > {code}Error: TypeError: doc.find is not a function > at Object.resolveParent > (/Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/util/xml-helpers.js:210:26) > at > /Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:464:53 > at Array.forEach (native) > at is_conflicting > (/Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:456:17) > at PlatformMunger.add_config_changes > (/Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:204:33) > at > /Users/dpogue/Coding/cordova-app/node_modules/cordova-lib/src/cordova/prepare.js:127:24 > at _fulfilled > (/Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:834:54) > at self.promiseDispatch.done > (/Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:863:30) > at Promise.promise.promiseDispatch > (/Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:796:13) > at > /Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:604:44{code} > This seems to happen because plist files are turned into JS objects when they > are parsed, rather than XML documents like AndroidManifest.xml or config.xml. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12070) edit-config doesn't work with plist files
[ https://issues.apache.org/jira/browse/CB-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249710#comment-16249710 ] Tom Bell commented on CB-12070: --- I am encountering this `doc.find is not a function` when updating `cordova-plugins-contacts` and adding the recommended `edit-config` from the README. > edit-config doesn't work with plist files > - > > Key: CB-12070 > URL: https://issues.apache.org/jira/browse/CB-12070 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Darryl Pogue > Fix For: cordova-lib@6.4.1 > > > Trying to use the {{edit-config}} tag in config.xml to add to the iOS > Info.plist file: > {code} mode="merge"> > > foo > > {code} > It's giving me an error in xml_helpers.js: > {code}Error: TypeError: doc.find is not a function > at Object.resolveParent > (/Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/util/xml-helpers.js:210:26) > at > /Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:464:53 > at Array.forEach (native) > at is_conflicting > (/Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:456:17) > at PlatformMunger.add_config_changes > (/Users/dpogue/Coding/cordova-app/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:204:33) > at > /Users/dpogue/Coding/cordova-app/node_modules/cordova-lib/src/cordova/prepare.js:127:24 > at _fulfilled > (/Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:834:54) > at self.promiseDispatch.done > (/Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:863:30) > at Promise.promise.promiseDispatch > (/Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:796:13) > at > /Users/dpogue/Coding/cordova-app/platforms/ios/cordova/node_modules/q/q.js:604:44{code} > This seems to happen because plist files are turned into JS objects when they > are parsed, rather than XML documents like AndroidManifest.xml or config.xml. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13554) Unable to launch basic auth popup on the inappbrowser
[ https://issues.apache.org/jira/browse/CB-13554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249704#comment-16249704 ] Jan Piotrowski (Sujan) commented on CB-13554: - I repeat my question: {quote} > looks like a basic auth one Does it look like one or is it one? {quote} Also, what platform are you testing on? iOS or Android? What versions of Cordova and the plugin are you using? > Unable to launch basic auth popup on the inappbrowser > - > > Key: CB-13554 > URL: https://issues.apache.org/jira/browse/CB-13554 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-browser >Affects Versions: cordova@7.0.0 >Reporter: vikram pottam >Assignee: Jesse MacFadyen > Fix For: Master > > > Unable to launch basic auth popup on the inappbrowser > I am trying to launch a url from using cordova inapp browser , every > enterprise url of my company launches a popup (looks like a basic auth one) > I cant see that popup , > also tried with auth plugin but it did not work as well > this is the error i am getting: > {code} > 017-11-08 11:33:44.024401-0600 mytimeapp[2514:8278454] AuthDialog: > willSendRequestForAuthenticationChallenge 0x60811b80>: Host:"", Server:https, > Auth-Scheme:NSURLAuthenticationMethodNTLM, Realm:sts.cerner.com, Port:443, > Proxy:NO, Proxy-Type:(null) > 2017-11-08 11:33:44.042277-0600 mytimeapp[2514:8278454] AuthDialog: > willSendRequestForAuthenticationChallenge 0x60411310>: Host:"", Server:https, > Auth-Scheme:NSURLAuthenticationMethodServerTrust, Realm:(null), Port:443, > Proxy:NO, Proxy-Type:(null) > 2017-11-08 11:33:44.093841-0600 mytimeapp[2514:8281203] CredStore - > performQuery - Error copying matching creds. Error=-25300, query={ > class = inet; > "m_Limit" = "m_LimitAll"; > ptcl = htps; > "r_Attributes" = 1; > sdmn = ""; > srvr = ""; > sync = syna; > } > 2017-11-08 11:33:44.095529-0600 mytimeapp[2514:8281203] CredStore - > updateOrAddCredential - Error update cred. Error=-25300, query={ > acct = ; > atyp = dflt; > class = inet; > port = 443; > ptcl = htps; > sdmn = ""; > srvr = ""; > }, attrs={ > acct = ; > icmt = default; > labl = ")"; > "v_Data" = <4d61726b 69764031 393838>; > } > 2017-11-08 11:33:44.096822-0600 mytimeapp[2514:8281203] CredStore - > updateOrAddCredential - Error add cred. Error=-50, attrs={ > acct = ; > atyp = dflt; > class = inet; > icmt = default; > labl = ")";; > path = ""; > port = 443; > ptcl = htps; > sdmn = ""; > srvr = ""; > "v_Data" = <4d61726b 69764031 393838>; > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13554) Unable to launch basic auth popup on the inappbrowser
[ https://issues.apache.org/jira/browse/CB-13554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249691#comment-16249691 ] vikram pottam commented on CB-13554: Thanks for the response., When i launch the app , it should show me a popup for entering user credentials like the basic auth app. But instead i get this error > 2017-11-08 11:33:44.093841-0600 mytimeapp[2514:8281203] CredStore - > performQuery - Error copying matching creds. Error=-25300, query={ I was not able to find from where this error is coming from. > Unable to launch basic auth popup on the inappbrowser > - > > Key: CB-13554 > URL: https://issues.apache.org/jira/browse/CB-13554 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-browser >Affects Versions: cordova@7.0.0 >Reporter: vikram pottam >Assignee: Jesse MacFadyen > Fix For: Master > > > Unable to launch basic auth popup on the inappbrowser > I am trying to launch a url from using cordova inapp browser , every > enterprise url of my company launches a popup (looks like a basic auth one) > I cant see that popup , > also tried with auth plugin but it did not work as well > this is the error i am getting: > {code} > 017-11-08 11:33:44.024401-0600 mytimeapp[2514:8278454] AuthDialog: > willSendRequestForAuthenticationChallenge 0x60811b80>: Host:"", Server:https, > Auth-Scheme:NSURLAuthenticationMethodNTLM, Realm:sts.cerner.com, Port:443, > Proxy:NO, Proxy-Type:(null) > 2017-11-08 11:33:44.042277-0600 mytimeapp[2514:8278454] AuthDialog: > willSendRequestForAuthenticationChallenge 0x60411310>: Host:"", Server:https, > Auth-Scheme:NSURLAuthenticationMethodServerTrust, Realm:(null), Port:443, > Proxy:NO, Proxy-Type:(null) > 2017-11-08 11:33:44.093841-0600 mytimeapp[2514:8281203] CredStore - > performQuery - Error copying matching creds. Error=-25300, query={ > class = inet; > "m_Limit" = "m_LimitAll"; > ptcl = htps; > "r_Attributes" = 1; > sdmn = ""; > srvr = ""; > sync = syna; > } > 2017-11-08 11:33:44.095529-0600 mytimeapp[2514:8281203] CredStore - > updateOrAddCredential - Error update cred. Error=-25300, query={ > acct = ; > atyp = dflt; > class = inet; > port = 443; > ptcl = htps; > sdmn = ""; > srvr = ""; > }, attrs={ > acct = ; > icmt = default; > labl = ")"; > "v_Data" = <4d61726b 69764031 393838>; > } > 2017-11-08 11:33:44.096822-0600 mytimeapp[2514:8281203] CredStore - > updateOrAddCredential - Error add cred. Error=-50, attrs={ > acct = ; > atyp = dflt; > class = inet; > icmt = default; > labl = ")";; > path = ""; > port = 443; > ptcl = htps; > sdmn = ""; > srvr = ""; > "v_Data" = <4d61726b 69764031 393838>; > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9626) Cordova-Lib requires NPM as a dependency
[ https://issues.apache.org/jira/browse/CB-9626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249658#comment-16249658 ] Yohan Lasorsa commented on CB-9626: --- Another bump on this as I can now reproduce the issue also on OS X. There is really no good reason for having a local dependency on npm, as it is available with every node install. > Cordova-Lib requires NPM as a dependency > > > Key: CB-9626 > URL: https://issues.apache.org/jira/browse/CB-9626 > Project: Apache Cordova > Issue Type: Wish > Components: cordova-lib >Reporter: Robert Baker > Labels: backlog, tools-next > > cordova-create is installing NPM 2.x in my node modules folder. > There should be a way around this, it should use the same version I'm already > using. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13531) cordova-geolocation not working when using wkwebview on ios11
[ https://issues.apache.org/jira/browse/CB-13531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249550#comment-16249550 ] jcesarmobile commented on CB-13531: --- I can't reproduce the issue. Which versions of the plugins are you using? Make sure you have an entry for NSLocationWhenInUseUsageDescription in your info.plist Latest version of geolocation plugin won't add an empty value for it as it used to do before, you have to enter it using an edit-config tag like this: {code} need location access to find things nearby {code} Anyway, I tried with an empty string and also worked. > cordova-geolocation not working when using wkwebview on ios11 > - > > Key: CB-13531 > URL: https://issues.apache.org/jira/browse/CB-13531 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios, cordova-plugin-geolocation, > cordova-plugin-wkwebview-engine >Affects Versions: cordova@7.0.0, cordova-ios 4.5.0 > Environment: OSX 10.12.6 > iOS 11.1 >Reporter: Andrea Fernandes da Fonseca >Assignee: Suraj Pindoria > > I've created two empty cordova projects with latest cordova, cordova-ios and > cordova-plugin-geolocation: > - 1) one uses the default UIWebView > - 2) other uses WKWebView > Those are simple starter projects that simply try to get user GPS location. > When I open project (1) everything is fine, I get the pop-up asking me to > allow location access with the message I specify, as expected. > When I open project (2) I don't get the pop-up and cannot access location > information. > Tested on latest OSX and latest iOS on physical iPhone 6S and iPhone X > simulator > --- > To recreate exactly the same conditions: > - create cordova project > - install plugins > - everything is default, except index.js that looks like this: > {code:javascript} > var app = { > initialize: function () { > document.addEventListener('deviceready', > this.onDeviceReady.bind(this), false); > }, > onDeviceReady: function () { > navigator.geolocation.getCurrentPosition( > function (position) { console.info(position); }, > function (error) { console.error(error); }, > { timeout: 3 } > ); > } > }; > app.initialize(); > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11248) InAppBrowser no focus on input text fields
[ https://issues.apache.org/jira/browse/CB-11248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249347#comment-16249347 ] ASF GitHub Bot commented on CB-11248: - varshatyagi commented on issue #214: CB-11248 InAppBrowser no focus on input text fields URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/214#issuecomment-343874972 @candidoalbertosilva do you get the fix for 6.0.1 ? I am still struggling. Let me know if anyone have found solution for v6.0.1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > InAppBrowser no focus on input text fields > -- > > Key: CB-11248 > URL: https://issues.apache.org/jira/browse/CB-11248 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: 1.4.0 > Environment: Cordova CLI, Android, Android Studio >Reporter: Mo Pages >Assignee: Sergey Shakhnazarov >Priority: Minor > Labels: android, reproduced, triaged > > When opening a webpage with a form in the Cordova default webview or system > webview focus on an input text box works as normal - a cursor is displayed > (and if there's any js list its displayed). However when using the > InAppBrowser the focus cursor does not display at all when you click in a > text box...the keyboard comes up but no focus cursor. > I've tried injecting js to focus on the text box but this doesn't do > anything..Also it makes no difference what value the option > keyboardDisplayRequiresUserAction is given...Is there a fix for this? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13552) iOS Cordova Build overwriting Bundle Display Name
[ https://issues.apache.org/jira/browse/CB-13552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-13552. - Resolution: Not A Problem Cordova used the name tag to set the project name and it was also used as bundle display name, now you can use the short attribute to specify the bundle display name separately. {code} My app long name {code} You should never change anything in Xcode manually, the Xcode project is a build artifact and can be deleted or overwritten. > iOS Cordova Build overwriting Bundle Display Name > - > > Key: CB-13552 > URL: https://issues.apache.org/jira/browse/CB-13552 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios 4.5.0 > Environment: OSX 10.12.6; Cordova 7.1.0 >Reporter: Adam De Lay >Assignee: Suraj Pindoria > > I change my Bundle Display Name in my plist file (or in Xcode) and then I go > to use cordova to build my application and when I do, the Bundle Display Name > is being changed to the name tag from the config.xml. This is something new > that I noticed in 4.5.1. I've built hundreds of apps before and never had > this problem. I tried upgrading to 4.5.3 to see if it would fix the issue > and it doesn't. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13546) Cordova Plugin not calling on loading html
[ https://issues.apache.org/jira/browse/CB-13546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-13546. - Resolution: Cannot Reproduce I can't reproduce this issue. The problem is usually a missing gap: in the CSP. Feel free to reopen if you can provide a sample project where this can be reproduced > Cordova Plugin not calling on loading html > -- > > Key: CB-13546 > URL: https://issues.apache.org/jira/browse/CB-13546 > Project: Apache Cordova > Issue Type: Test > Components: cordova-ios >Affects Versions: 4.4.0 >Reporter: Aravind Raj Vijayakumar >Assignee: Suraj Pindoria > > I have an iPad app using Cordova4.4.0 iOS. Deviceready event is called but > not calling any of the plugin methods. It is triggered when webview loses > focus like pressing home button, opening notifications screen or control > centre screen. I found many SO solutions to add meta tag for content security > policy. But, it doesn't work even after adding meta tag. I tried all possible > combinations of meta tag. Is there anything else to be checked on or > changed..? As anyone faced this issue even after adding meta tag? Any ideas > how to resolve this issue? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13556) I'd like to use Cordova Plugins in _blank Inappbrowser
[ https://issues.apache.org/jira/browse/CB-13556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-13556. - Resolution: Won't Fix That works as intended, InAppBrowser can't use plugins and won't do it as InAppBrowser is used to load external and potentially insecure websites, so we don't want them to have access to device features > I'd like to use Cordova Plugins in _blank Inappbrowser > -- > > Key: CB-13556 > URL: https://issues.apache.org/jira/browse/CB-13556 > Project: Apache Cordova > Issue Type: Wish > Components: cordova-plugin-inappbrowser >Reporter: JianningMu >Priority: Minor > Labels: _blank, cordova, cordova-plugin, inappbrowser, plugin > > I built two Cordova projects which named P and S. > Then, I put S's www into P's www. By this way, I'd like to make S as a > sub-project of P. > Next, one of P's pages uses Inappbrowser to _self open S's index.html. > As a result, S can work well with Cordova Plugins which added by P. > But, when S was _blank opened, it can't use Cordova Plugins. > In short, I'd like to use Cordova Plugins in _blank Inappbrowser. > Could you give me a hand? > Thank you! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13563) InAppBrowser.open opens a browser
[ https://issues.apache.org/jira/browse/CB-13563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-13563. - Resolution: Not A Problem When using self it uses the Cordoa WebView. Cordoa WebView won't allow to show external urls unless you whitelist them with allow-navigation tags > InAppBrowser.open opens a browser > - > > Key: CB-13563 > URL: https://issues.apache.org/jira/browse/CB-13563 > Project: Apache Cordova > Issue Type: Bug >Reporter: Birowsky >Priority: Blocker > > Executing `cordova.InAppBrowser.open('https://google.com', '_self');` opens > in Safari instead of the cordova webview. > Here are the details: [https://stackoverflow.com/q/47253130/592641] -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12754) inAppBrowser crashing on Android
[ https://issues.apache.org/jira/browse/CB-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249296#comment-16249296 ] Tim Brust commented on CB-12754: I'm seeing the same issue on Android 7.0 with a Galaxy Tab A 10.1 (LTE) version. Crash can be found here: https://pastebin.com/0Nfej8HT - as soon as I manage to gather more information or a reproducible example, I'll update this comment. > inAppBrowser crashing on Android > > > Key: CB-12754 > URL: https://issues.apache.org/jira/browse/CB-12754 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-plugin-inappbrowser >Reporter: Peter Olszowka > > Using cordova-plugin-inappbrowser version 1.7.0 > Getting many crash reports from Google play store with following stack trace: > java.lang.NullPointerException: Attempt to invoke virtual method 'void > org.apache.cordova.inappbrowser.InAppBrowserDialog.show()' on a null object > reference > at > org.apache.cordova.inappbrowser.InAppBrowser$2.run(InAppBrowser.java:257) > at android.os.Handler.handleCallback(Handler.java:739) > at android.os.Handler.dispatchMessage(Handler.java:95) > at android.os.Looper.loop(Looper.java:145) > at android.app.ActivityThread.main(ActivityThread.java:6126) > at java.lang.reflect.Method.invoke(Native Method) > at java.lang.reflect.Method.invoke(Method.java:372) > at > com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1399) > at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1194) > The issue appears on many versions of Android including 4.4, 5.1, 6.0, & 7.0. > You can try the app from the Google Play store: "cargurus" > I am unable to reproduce the error myself, but 25 users/day are reporting it. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org