[jira] [Created] (CB-13651) Denying location permission causes app to not function correctly
Sergio Azpiazu Amilibia created CB-13651: Summary: Denying location permission causes app to not function correctly Key: CB-13651 URL: https://issues.apache.org/jira/browse/CB-13651 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-geolocation Affects Versions: cordova@7.0.0 Environment: Android 8.0 Reporter: Sergio Azpiazu Amilibia Denying location access to the app (checking the "do not ask again" box on the second query, or doing this through the app settings in the Settings) causes the app to crash. Apparently, it's trying to check for permissions time and time again making the app completely unusable and unresponsive -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13649) Device plugin `model` doesn't work in iOS simulator
[ https://issues.apache.org/jira/browse/CB-13649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284478#comment-16284478 ] Jan Piotrowski (Sujan) commented on CB-13649: - StackOverflow disagrees: https://stackoverflow.com/questions/31266019/get-the-device-model-name-when-running-on-simulator With Swift there seems to be a workaround though: https://stackoverflow.com/questions/33493800/how-to-get-the-iphone-type-from-simulator-ios Unfortunately the cordova-plugin-device is not using Swift. > Device plugin `model` doesn't work in iOS simulator > --- > > Key: CB-13649 > URL: https://issues.apache.org/jira/browse/CB-13649 > Project: Apache Cordova > Issue Type: Bug >Reporter: Chet Corcos > Original Estimate: 1h > Remaining Estimate: 1h > > When using the cordova device plugin in the simulator, its impossible to > detect which type of iOS device is being used because the model references > the computer thats running the simulator -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13648) Cordova Android Security Concern? What is the correct workflow for apps with this issue? (see description)
[ https://issues.apache.org/jira/browse/CB-13648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284469#comment-16284469 ] Jan Piotrowski (Sujan) commented on CB-13648: - Use Google to look for plugins that implement the API described in the link. This could technically be implemented in cordova-android, yes, but this probably won't happen. It is certainly not _core_ functionality. It can just as well be implemented as a plugin first, then be integrated into the platform if it becomes super popular. > Cordova Android Security Concern? What is the correct workflow for apps with > this issue? (see description) > -- > > Key: CB-13648 > URL: https://issues.apache.org/jira/browse/CB-13648 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Reporter: Abhishek Joshi >Assignee: Joe Bowser > > https://developer.android.com/training/articles/security-gms-provider.html > 1) Is this bug discussed above a concern with Cordova apps out of the Box > (near helloworld level of apps), since Cordova runs off Webviews? > 2) If this bug is a concern, what should the correct workaround be? Do I need > to create my own plugin to manage this? Is there a solution? > 3) Any comments? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13045) Drop android implementation of cordova-plugin-vibration
[ https://issues.apache.org/jira/browse/CB-13045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284248#comment-16284248 ] ASF GitHub Bot commented on CB-13045: - maverickmishra commented on issue #60: CB-13045: Removed android implementation and Updated README URL: https://github.com/apache/cordova-plugin-vibration/pull/60#issuecomment-350376449 Good idea! I'll make the necessary changes now This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Drop android implementation of cordova-plugin-vibration > --- > > Key: CB-13045 > URL: https://issues.apache.org/jira/browse/CB-13045 > Project: Apache Cordova > Issue Type: Task > Components: cordova-plugin-vibration >Reporter: Filip Maj >Assignee: Vishal Mishra > Labels: plugins-next > > Android webviews should support this API natively now. WE should test which > Android versions support this and if its feasible. If it is, the minimum > Android version it supports should also give us a good hint as to which > minimum cordova-android versions the new version of this plugin could support. > This will require a major version bump for the plugin. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13650) Javascript functions with default parameters cause app to be inoperable
Ralph Gossa created CB-13650:
Summary: Javascript functions with default parameters cause app to
be inoperable
Key: CB-13650
URL: https://issues.apache.org/jira/browse/CB-13650
Project: Apache Cordova
Issue Type: Bug
Components: cordova-ios
Affects Versions: cordova@7.1.0
Environment: Xcode
9.2
cordova --version
7.1.0
Installed platforms:
ios 4.5.1
iOS
9.3.5 (which is latest version available for iPod Touch)
Reporter: Ralph Gossa
Assignee: Suraj Pindoria
Having Javascript functions with default parameters cause app to be inoperable
on certain iOS platforms
How to re-create the issue:
cordova create test
cd test
cordova platform add ios
Open the generated test.xcodeproj with Xcode
Add a javascript function with a default parameter to index.js, example:
/* default parameter causes app to be inoperable on iPod touch running iOS 9.3*/
function foo (a, b = 1) {
b = 1;
return b;
}
App with default parameters runs find in emulator and on iPhones running
current iOS.
However app does not initialize properly on iPod Touch running iOS 9.3. It was
working okay until I upgraded XCode and cordova. The function does not even
need to be called for the app to become inoperable.
If the default parameter is removed from the Javascript function, the app runs
fine.
XCode output with Javascript function containing default parameter
-begin--
2017-12-08 10:29:41.783 paramtest[1125:133765] DiskCookieStorage changing
policy from 2 to 0, cookie file:
file:///private/var/mobile/Containers/Data/Application/1C726E4F-A05A-418A-A37F-1877E71B1E60/Library/Cookies/Cookies.binarycookies
2017-12-08 10:29:41.962 paramtest[1125:133765] Apache Cordova native platform
version 4.5.3 is starting.
2017-12-08 10:29:41.964 paramtest[1125:133765] Multi-tasking -> Device: YES,
App: YES
2017-12-08 10:29:41.993 paramtest[1125:133765]
Started backup to iCloud! Please be careful.
Your application might be rejected by Apple if you store too much data.
For more information please read "iOS Data Storage Guidelines" at:
https://developer.apple.com/icloud/documentation/data-storage/
To disable web storage backup to iCloud, set the BackupWebStorage preference to
"local" in the Cordova config.xml file
2017-12-08 10:29:42.132 paramtest[1125:133765] Using UIWebView
2017-12-08 10:29:42.145 paramtest[1125:133765] [CDVTimer][console] 0.753999ms
2017-12-08 10:29:42.148 paramtest[1125:133765] [CDVTimer][handleopenurl]
0.678003ms
2017-12-08 10:29:42.158 paramtest[1125:133765]
[CDVTimer][intentandnavigationfilter] 9.851992ms
2017-12-08 10:29:42.159 paramtest[1125:133765] [CDVTimer][gesturehandler]
0.428021ms
2017-12-08 10:29:42.159 paramtest[1125:133765] [CDVTimer][TotalPluginStartup]
15.917003ms
2017-12-08 10:29:42.799 paramtest[1125:133765] Resetting plugins due to page
load.
2017-12-08 10:29:43.167 paramtest[1125:133765] Finished load of:
file:///var/containers/Bundle/Application/81B5D70F-0B1F-455E-AB84-FA6BE125EEC2/paramtest.app/www/index.html
--end
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13648) Cordova Android Security Concern? What is the correct workflow for apps with this issue? (see description)
[ https://issues.apache.org/jira/browse/CB-13648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284158#comment-16284158 ] Abhishek Joshi commented on CB-13648: - Any idea where I can examine if it exists? Would it be in the core project for cordova-android's platform? Can this be implemented within the runtime? > Cordova Android Security Concern? What is the correct workflow for apps with > this issue? (see description) > -- > > Key: CB-13648 > URL: https://issues.apache.org/jira/browse/CB-13648 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Reporter: Abhishek Joshi >Assignee: Joe Bowser > > https://developer.android.com/training/articles/security-gms-provider.html > 1) Is this bug discussed above a concern with Cordova apps out of the Box > (near helloworld level of apps), since Cordova runs off Webviews? > 2) If this bug is a concern, what should the correct workaround be? Do I need > to create my own plugin to manage this? Is there a solution? > 3) Any comments? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13649) Device plugin `model` doesn't work in iOS simulator
[ https://issues.apache.org/jira/browse/CB-13649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284119#comment-16284119 ] Chet Corcos commented on CB-13649: -- No idea. I'd imagine so. > Device plugin `model` doesn't work in iOS simulator > --- > > Key: CB-13649 > URL: https://issues.apache.org/jira/browse/CB-13649 > Project: Apache Cordova > Issue Type: Bug >Reporter: Chet Corcos > Original Estimate: 1h > Remaining Estimate: 1h > > When using the cordova device plugin in the simulator, its impossible to > detect which type of iOS device is being used because the model references > the computer thats running the simulator -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13649) Device plugin `model` doesn't work in iOS simulator
[ https://issues.apache.org/jira/browse/CB-13649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284073#comment-16284073 ] Jan Piotrowski (Sujan) commented on CB-13649: - Can native iOS code access the "model" of a simulator? > Device plugin `model` doesn't work in iOS simulator > --- > > Key: CB-13649 > URL: https://issues.apache.org/jira/browse/CB-13649 > Project: Apache Cordova > Issue Type: Bug >Reporter: Chet Corcos > Original Estimate: 1h > Remaining Estimate: 1h > > When using the cordova device plugin in the simulator, its impossible to > detect which type of iOS device is being used because the model references > the computer thats running the simulator -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13045) Drop android implementation of cordova-plugin-vibration
[ https://issues.apache.org/jira/browse/CB-13045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284036#comment-16284036 ] ASF GitHub Bot commented on CB-13045: - macdonst commented on issue #60: CB-13045: Removed android implementation and Updated README URL: https://github.com/apache/cordova-plugin-vibration/pull/60#issuecomment-350344380 @maverickmishra considering this is a breaking API change and we'll be bumping the version to 3.0.0 we might as well take out `vibrateWithPattern` & `cancelVibration`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Drop android implementation of cordova-plugin-vibration > --- > > Key: CB-13045 > URL: https://issues.apache.org/jira/browse/CB-13045 > Project: Apache Cordova > Issue Type: Task > Components: cordova-plugin-vibration >Reporter: Filip Maj >Assignee: Vishal Mishra > Labels: plugins-next > > Android webviews should support this API natively now. WE should test which > Android versions support this and if its feasible. If it is, the minimum > Android version it supports should also give us a good hint as to which > minimum cordova-android versions the new version of this plugin could support. > This will require a major version bump for the plugin. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13649) Device plugin `model` doesn't work in iOS simulator
Chet Corcos created CB-13649: Summary: Device plugin `model` doesn't work in iOS simulator Key: CB-13649 URL: https://issues.apache.org/jira/browse/CB-13649 Project: Apache Cordova Issue Type: Bug Reporter: Chet Corcos When using the cordova device plugin in the simulator, its impossible to detect which type of iOS device is being used because the model references the computer thats running the simulator -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284016#comment-16284016 ] ASF subversion and git services commented on CB-12361: -- Commit c3cd66df53bf03007447c2a0d14d057a63d71b97 in cordova-lib's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=c3cd66d ] Merge pull request #603 from audreyso/CB-12361-check.js CB-12361 : added unit tests for check.js > Speed up cordova-lib tests > -- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284014#comment-16284014 ] ASF subversion and git services commented on CB-12361: -- Commit d6a9afe9087327268e0e4c2d5cffb4424908f4d4 in cordova-lib's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=d6a9afe ] CB-12361 : added unit tests for check.js > Speed up cordova-lib tests > -- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-12361. -- Resolution: Fixed > Speed up cordova-lib tests > -- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284015#comment-16284015 ] ASF subversion and git services commented on CB-12361: -- Commit c3cd66df53bf03007447c2a0d14d057a63d71b97 in cordova-lib's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=c3cd66d ] Merge pull request #603 from audreyso/CB-12361-check.js CB-12361 : added unit tests for check.js > Speed up cordova-lib tests > -- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284013#comment-16284013
]
ASF GitHub Bot commented on CB-12361:
-
stevengill closed pull request #603: CB-12361 : added unit tests for check.js
URL: https://github.com/apache/cordova-lib/pull/603
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/spec/cordova/platform/check.spec.js
b/spec/cordova/platform/check.spec.js
new file mode 100644
index 0..bb4456d29
--- /dev/null
+++ b/spec/cordova/platform/check.spec.js
@@ -0,0 +1,83 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var Q = require('q');
+var shell = require('shelljs');
+var events = require('cordova-common').events;
+var superspawn = require('cordova-common').superspawn;
+var rewire = require('rewire');
+var platform_check = rewire('../../../src/cordova/platform/check');
+var cordova_util = require('../../../src/cordova/util');
+
+describe('cordova/platform/check', function () {
+var projectRoot = '/some/path';
+var hooks_mock;
+
+beforeEach(function () {
+spyOn(events, 'emit');
+spyOn(superspawn, 'spawn').and.callThrough();
+spyOn(shell, 'rm');
+spyOn(cordova_util, 'listPlatforms');
+});
+
+it('If no results, platforms cannot be updated', function (done) {
+cordova_util.listPlatforms.and.callThrough();
+platform_check(hooks_mock, projectRoot).then(function () {
+expect(events.emit).toHaveBeenCalledWith('results',
jasmine.stringMatching(/No platforms can be updated/));
+expect(superspawn.spawn).toHaveBeenCalledWith('npm',
['--loglevel=silent', '--json', 'outdated', 'cordova-lib'],
jasmine.any(Object));
+expect(shell.rm).toHaveBeenCalledWith('-rf', jasmine.any(String));
+}).fail(function (err) {
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('Should warn if install failed', function (done) {
+cordova_util.listPlatforms.and.returnValue(['ios']);
+platform_check(hooks_mock, projectRoot).then(function () {
+expect(events.emit).toHaveBeenCalledWith('results',
jasmine.stringMatching(/current did not install/));
+}).fail(function (err) {
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('Should warn if version-empty', function (done) {
+cordova_util.listPlatforms.and.returnValue(['ios']);
+spyOn(require('../../../src/cordova/platform/index'),
'add').and.returnValue(Q());
+superspawn.spawn.and.returnValue(Q());
+platform_check(hooks_mock, projectRoot).then(function () {
+expect(events.emit).toHaveBeenCalledWith('results',
jasmine.stringMatching(/current version script failed to return a version/));
+}).fail(function (err) {
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+
+it('Should warn if version-failed', function (done) {
+cordova_util.listPlatforms.and.returnValue(['ios']);
+spyOn(require('../../../src/cordova/platform/index'),
'add').and.returnValue(Q());
+spyOn(superspawn, 'maybeSpawn').and.returnValue(Q('version-failed'));
+spyOn(Q.defer(), 'resolve').and.returnValue('version-failed');
+platform_check(hooks_mock, projectRoot).then(function () {
+expect(events.emit).toHaveBeenCalledWith('results',
jasmine.stringMatching(/current version script failed, and/));
+}).fail(function (err) {
+fail('unexpected failure handler invoked!');
+console.error(err);
+}).done(done);
+});
+});
This is an automated message from the Apache Git Service.
To respon
[jira] [Commented] (CB-13648) Cordova Android Security Concern? What is the correct workflow for apps with this issue? (see description)
[ https://issues.apache.org/jira/browse/CB-13648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284006#comment-16284006 ] Jan Piotrowski (Sujan) commented on CB-13648: - This "problem" is system level and system wide, so yes, of course it also affects Cordova apps running on Android devices that are vulnerable. All that code there to check if the device is vulnerable and trigger an update would have to be called via a Cordova plugin. I don't know if this exists already. > Cordova Android Security Concern? What is the correct workflow for apps with > this issue? (see description) > -- > > Key: CB-13648 > URL: https://issues.apache.org/jira/browse/CB-13648 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Reporter: Abhishek Joshi >Assignee: Joe Bowser > > https://developer.android.com/training/articles/security-gms-provider.html > 1) Is this bug discussed above a concern with Cordova apps out of the Box > (near helloworld level of apps), since Cordova runs off Webviews? > 2) If this bug is a concern, what should the correct workaround be? Do I need > to create my own plugin to manage this? Is there a solution? > 3) Any comments? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-12810) keep existing formatting in package.json
[ https://issues.apache.org/jira/browse/CB-12810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-12810. -- Resolution: Fixed > keep existing formatting in package.json > > > Key: CB-12810 > URL: https://issues.apache.org/jira/browse/CB-12810 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Affects Versions: 7.0.0 >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: backlog, cordova-8.0.0, cordova-next, tools-next > > We will write our own indentation in package.json. For commands that shell > out to cordova-fetch and therefore npm, we have no control over it (cordova > platform/plugin add/rm). > We could theoretically keep indentaiton for commands where we write to > package.json (also platform/plugin add/rm to cordova key & during restore > when we sync config.xml & package.json). > This issue is probably not worth implementing. > npm@5 seems like it will respect existing formatting. > Previous issue with npm formatting: https://github.com/npm/npm/issues/5694 > npm5 respecting indentation: https://github.com/npm/npm/issues/16244 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12810) keep existing formatting in package.json
[
https://issues.apache.org/jira/browse/CB-12810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283990#comment-16283990
]
ASF GitHub Bot commented on CB-12810:
-
stevengill closed pull request #606: CB-12810 : keep existing formatting in
package.json and fix eslint errors
URL: https://github.com/apache/cordova-lib/pull/606
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/package.json b/package.json
index 07879c3d1..71a732dc6 100644
--- a/package.json
+++ b/package.json
@@ -24,6 +24,7 @@
"cordova-js": "4.2.2",
"cordova-serve": "^2.0.0",
"dep-graph": "1.1.0",
+"detect-indent": "^5.0.0",
"elementtree": "0.1.6",
"glob": "7.1.1",
"init-package-json": "^1.2.0",
diff --git a/spec/cordova/platform/addHelper.spec.js
b/spec/cordova/platform/addHelper.spec.js
index 72f017401..c01f66216 100644
--- a/spec/cordova/platform/addHelper.spec.js
+++ b/spec/cordova/platform/addHelper.spec.js
@@ -284,6 +284,7 @@ describe('cordova/platform/addHelper', function () {
describe('if the project contains a package.json', function () {
it('should write out the platform just added/updated to the
cordova.platforms property of package.json', function (done) {
+spyOn(fs, 'readFileSync').and.returnValue('file');
fs.existsSync.and.callFake(function (filePath) {
if (path.basename(filePath) === 'package.json') {
return true;
diff --git a/spec/cordova/platform/remove.spec.js
b/spec/cordova/platform/remove.spec.js
index 5483ec0a0..9e2e7b3e4 100644
--- a/spec/cordova/platform/remove.spec.js
+++ b/spec/cordova/platform/remove.spec.js
@@ -95,6 +95,7 @@ describe('cordova/platform/remove', function () {
it('should remove from package.json', function (done) {
package_json_mock.cordova = {'platforms': ['atari']};
cordova_util.requireNoCache.and.returnValue(package_json_mock);
+spyOn(fs, 'readFileSync').and.returnValue('file');
fs.existsSync.and.callFake(function (filePath) {
if (path.basename(filePath) === 'package.json') {
return true;
diff --git a/spec/cordova/plugin/add.spec.js b/spec/cordova/plugin/add.spec.js
index 2059ad2a7..e60fdd41b 100644
--- a/spec/cordova/plugin/add.spec.js
+++ b/spec/cordova/plugin/add.spec.js
@@ -167,6 +167,7 @@ describe('cordova/plugin/add', function () {
}
});
+spyOn(fs, 'readFileSync').and.returnValue('file');
add(projectRoot, hook_mock, {plugins:
['cordova-plugin-device'], cli_variables: cli_plugin_variables, save:
'true'}).then(function () {
expect(fs.writeFileSync).toHaveBeenCalledWith(jasmine.any(String),
JSON.stringify({'cordova': {'plugins': {'cordova-plugin-device':
cli_plugin_variables}}, 'dependencies': {}}, null, 2), 'utf8');
}).fail(function (e) {
diff --git a/spec/cordova/plugin/remove.spec.js
b/spec/cordova/plugin/remove.spec.js
index 6721b309b..ec59b11da 100644
--- a/spec/cordova/plugin/remove.spec.js
+++ b/spec/cordova/plugin/remove.spec.js
@@ -165,6 +165,7 @@ describe('cordova/plugin/remove', function () {
});
it('should remove provided plugins from package.json (if exists)',
function (done) {
+spyOn(fs, 'readFileSync').and.returnValue('file');
spyOn(cordova_util,
'requireNoCache').and.returnValue(package_json_mock);
remove.validatePluginId.and.returnValue('cordova-plugin-splashscreen');
fs.existsSync.and.returnValue(true);
diff --git a/src/cordova/platform/addHelper.js
b/src/cordova/platform/addHelper.js
index 1c0b39fc3..1f4123746 100644
--- a/src/cordova/platform/addHelper.js
+++ b/src/cordova/platform/addHelper.js
@@ -34,6 +34,7 @@ var config = require('../config');
var lazy_load = require('../lazy_load');
var platformMetadata = require('../platform_metadata');
var platforms = require('../../platforms/platforms');
+var detectIndent = require('detect-indent');
module.exports = addHelper;
module.exports.getVersionFromConfigFile = getVersionFromConfigFile;
@@ -269,8 +270,9 @@ function addHelper (cmd, hooksRunner, projectRoot, targets,
opts) {
});
// Save to package.json.
if (modifiedPkgJson === true) {
-pkgJson.cordova.platforms = pkgJson.cordova.platforms;
-fs.writeFileSync(pkgJsonPath, JSON.stringify(pkgJson,
null, 2), 'utf8');
+var file = fs.readFileSync(pkgJsonPath, 'utf8');
+
[jira] [Commented] (CB-12810) keep existing formatting in package.json
[ https://issues.apache.org/jira/browse/CB-12810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283989#comment-16283989 ] ASF subversion and git services commented on CB-12810: -- Commit 4d7e848bef10279db28d7738b4f86d38e4dd5029 in cordova-lib's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=4d7e848 ] CB-12810 : updated indenting for pkgJson and fixed eslint errors > keep existing formatting in package.json > > > Key: CB-12810 > URL: https://issues.apache.org/jira/browse/CB-12810 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Affects Versions: 7.0.0 >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: backlog, cordova-8.0.0, cordova-next, tools-next > > We will write our own indentation in package.json. For commands that shell > out to cordova-fetch and therefore npm, we have no control over it (cordova > platform/plugin add/rm). > We could theoretically keep indentaiton for commands where we write to > package.json (also platform/plugin add/rm to cordova key & during restore > when we sync config.xml & package.json). > This issue is probably not worth implementing. > npm@5 seems like it will respect existing formatting. > Previous issue with npm formatting: https://github.com/npm/npm/issues/5694 > npm5 respecting indentation: https://github.com/npm/npm/issues/16244 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13648) Cordova Android Security Concern? What is the correct workflow for apps with this issue? (see description)
Abhishek Joshi created CB-13648: --- Summary: Cordova Android Security Concern? What is the correct workflow for apps with this issue? (see description) Key: CB-13648 URL: https://issues.apache.org/jira/browse/CB-13648 Project: Apache Cordova Issue Type: Bug Components: cordova-android Reporter: Abhishek Joshi Assignee: Joe Bowser https://developer.android.com/training/articles/security-gms-provider.html 1) Is this bug discussed above a concern with Cordova apps out of the Box (near helloworld level of apps), since Cordova runs off Webviews? 2) If this bug is a concern, what should the correct workaround be? Do I need to create my own plugin to manage this? Is there a solution? 3) Any comments? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13637) Unable to handle local plugins properly
[
https://issues.apache.org/jira/browse/CB-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283763#comment-16283763
]
Michael Goffioul commented on CB-13637:
---
After some digging, it appears that although npm can handle relative "file:"
URLs, plugman cannot.
The problem seems to start around this location:
https://github.com/apache/cordova-lib/blob/master/src/plugman/fetch.js#L115
The variable "plugin_src" contains a relative file URL, like
"file:localplugins/testplugin". But the use of that URL in node's fs module
fails, for instance to code fails to detect that it's a local path and handle
it accordingly. I could verify that adding this code just above referenced line
fix the problem for me:
{code}
if (uri.protocol === 'file:' && uri.pathname && uri.pathname[0] !==
'/') {
plugin_src = plugin_src.substring(5);
}
{code}
> Unable to handle local plugins properly
> ---
>
> Key: CB-13637
> URL: https://issues.apache.org/jira/browse/CB-13637
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Reporter: Michael Goffioul
>
> 1) create a new cordova project
> 2) inside the project directory, create folder "localplugins/testplugin"
> containing the file:
> - package.json
> {code}
> {
> "name": "com.example.cordova.plugin",
> "version": "1.0.0"
> }
> {code}
> - plugin.xml
> {code}
>
> http://apache.org/cordova/ns/plugins/1.0";
> id="com.example.cordova.plugin" version="1.0.0">
> Test Plugin
>
>
>
>
>
>
> {code}
> 3) add android patform: cordova platform add android
> 4) prepare android: cordova prepare android
> At this point, both package.json and config.xml contain a reference to the
> plugin using "file:localplugins/testplugin". The problem is that it's
> impossible to use the same plugin reference in both files, and still having
> plugin restoration and/or "npm install" to work.
> If I delete platforms/ and plugins/ subdir (these are typically not under git
> revision control) and run "cordova prepare android" to restore the platforms
> and the plugins, it fails with error:
> {code}
> Discovered plugin "com.example.cordova.plugin" in config.xml. Adding it to
> the project
> Failed to restore plugin "com.example.cordova.plugin" from config.xml. You
> might need to try adding it again. Error: Failed to fetch plugin
> file:localplugins/testplugin via registry.
> Probably this is either a connection problem, or plugin spec is incorrect.
> Check your connection and plugin name/version/URL.
> Failed to get absolute path to installed module
> {code}
> If I edit package.json and config.xml, and remove the prefix "file:" in the
> plugin spec, then restoration works ok. But then, it's "npm install" that
> fails.
> What works is to use the "file:" prefix in package.json and not use it in
> "config.xml". But that's not possible as preparation will make sure both are
> identical.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13637) Unable to handle local plugins properly
[
https://issues.apache.org/jira/browse/CB-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Goffioul updated CB-13637:
--
Component/s: (was: cordova-cli)
> Unable to handle local plugins properly
> ---
>
> Key: CB-13637
> URL: https://issues.apache.org/jira/browse/CB-13637
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Reporter: Michael Goffioul
>
> 1) create a new cordova project
> 2) inside the project directory, create folder "localplugins/testplugin"
> containing the file:
> - package.json
> {code}
> {
> "name": "com.example.cordova.plugin",
> "version": "1.0.0"
> }
> {code}
> - plugin.xml
> {code}
>
> http://apache.org/cordova/ns/plugins/1.0";
> id="com.example.cordova.plugin" version="1.0.0">
> Test Plugin
>
>
>
>
>
>
> {code}
> 3) add android patform: cordova platform add android
> 4) prepare android: cordova prepare android
> At this point, both package.json and config.xml contain a reference to the
> plugin using "file:localplugins/testplugin". The problem is that it's
> impossible to use the same plugin reference in both files, and still having
> plugin restoration and/or "npm install" to work.
> If I delete platforms/ and plugins/ subdir (these are typically not under git
> revision control) and run "cordova prepare android" to restore the platforms
> and the plugins, it fails with error:
> {code}
> Discovered plugin "com.example.cordova.plugin" in config.xml. Adding it to
> the project
> Failed to restore plugin "com.example.cordova.plugin" from config.xml. You
> might need to try adding it again. Error: Failed to fetch plugin
> file:localplugins/testplugin via registry.
> Probably this is either a connection problem, or plugin spec is incorrect.
> Check your connection and plugin name/version/URL.
> Failed to get absolute path to installed module
> {code}
> If I edit package.json and config.xml, and remove the prefix "file:" in the
> plugin spec, then restoration works ok. But then, it's "npm install" that
> fails.
> What works is to use the "file:" prefix in package.json and not use it in
> "config.xml". But that's not possible as preparation will make sure both are
> identical.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13595) cordova build ios --device --release not work
[ https://issues.apache.org/jira/browse/CB-13595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) resolved CB-13595. - Resolution: Invalid Not a problem with Cordova itself, so I close this issue. > cordova build ios --device --release not work > - > > Key: CB-13595 > URL: https://issues.apache.org/jira/browse/CB-13595 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios 4.5.0 > Environment: cordova -v︰7.1.0 > node -v︰8.9.1 > Xcode 9.1(9B55) > cordova ios︰4.5.3 > macOS High Sierra 10.13 >Reporter: Colin Bau >Assignee: Suraj Pindoria > Labels: ios > > step 1 > I import my Provisioning Profiles to keychain (double click) > !https://www.littlebau.com/ios/step1/01.png! > !https://www.littlebau.com/ios/step1/02.png! > step 2 > I prepare the build.json file (I tried the older format and new format but > still no luck) > I am very sure the "provisionProfile" is correct (it was my > provisionProfile's UUID) > [link > title|https://cordova.apache.org/docs/en/latest/guide/platforms/ios/#using-buildjson] > !https://www.littlebau.com/ios/step2/01.png! > !https://www.littlebau.com/ios/step2/02.png! > step 3 > I use Xcode and setting the Signing，it will build success > !https://www.littlebau.com/ios/step3/01.png! > !https://www.littlebau.com/ios/step3/02.png! > step 4 > but if I use︰cordova build ios --device --release > it will "ARCHIVED FAIL" > !https://www.littlebau.com/ios/step4/01.png! > !https://www.littlebau.com/ios/step4/02.png! > !https://www.littlebau.com/ios/step4/03.png! > in previous cordova-ios version，above workflow is work perfect and it will > generate a ipa format file finally > but in new cordova-ios or Xcode version，it seem not work anymore > if I miss something or give me some hint to solve it ? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13595) cordova build ios --device --release not work
[ https://issues.apache.org/jira/browse/CB-13595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283711#comment-16283711 ] Jan Piotrowski (Sujan) commented on CB-13595: - I included a link to the documentation of the command `match`. That site also has a "Getting started" menu option where you will learn how to install. > cordova build ios --device --release not work > - > > Key: CB-13595 > URL: https://issues.apache.org/jira/browse/CB-13595 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios 4.5.0 > Environment: cordova -v︰7.1.0 > node -v︰8.9.1 > Xcode 9.1(9B55) > cordova ios︰4.5.3 > macOS High Sierra 10.13 >Reporter: Colin Bau >Assignee: Suraj Pindoria > Labels: ios > > step 1 > I import my Provisioning Profiles to keychain (double click) > !https://www.littlebau.com/ios/step1/01.png! > !https://www.littlebau.com/ios/step1/02.png! > step 2 > I prepare the build.json file (I tried the older format and new format but > still no luck) > I am very sure the "provisionProfile" is correct (it was my > provisionProfile's UUID) > [link > title|https://cordova.apache.org/docs/en/latest/guide/platforms/ios/#using-buildjson] > !https://www.littlebau.com/ios/step2/01.png! > !https://www.littlebau.com/ios/step2/02.png! > step 3 > I use Xcode and setting the Signing，it will build success > !https://www.littlebau.com/ios/step3/01.png! > !https://www.littlebau.com/ios/step3/02.png! > step 4 > but if I use︰cordova build ios --device --release > it will "ARCHIVED FAIL" > !https://www.littlebau.com/ios/step4/01.png! > !https://www.littlebau.com/ios/step4/02.png! > !https://www.littlebau.com/ios/step4/03.png! > in previous cordova-ios version，above workflow is work perfect and it will > generate a ipa format file finally > but in new cordova-ios or Xcode version，it seem not work anymore > if I miss something or give me some hint to solve it ? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13595) cordova build ios --device --release not work
[ https://issues.apache.org/jira/browse/CB-13595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283540#comment-16283540 ] Colin Bau commented on CB-13595: hi [~jan.polacek] thanks your reply this is my first time to hear fastlane can you give me some hint to show how to install or manage those provisioning profiles (maybe some command ?) > cordova build ios --device --release not work > - > > Key: CB-13595 > URL: https://issues.apache.org/jira/browse/CB-13595 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios 4.5.0 > Environment: cordova -v︰7.1.0 > node -v︰8.9.1 > Xcode 9.1(9B55) > cordova ios︰4.5.3 > macOS High Sierra 10.13 >Reporter: Colin Bau >Assignee: Suraj Pindoria > Labels: ios > > step 1 > I import my Provisioning Profiles to keychain (double click) > !https://www.littlebau.com/ios/step1/01.png! > !https://www.littlebau.com/ios/step1/02.png! > step 2 > I prepare the build.json file (I tried the older format and new format but > still no luck) > I am very sure the "provisionProfile" is correct (it was my > provisionProfile's UUID) > [link > title|https://cordova.apache.org/docs/en/latest/guide/platforms/ios/#using-buildjson] > !https://www.littlebau.com/ios/step2/01.png! > !https://www.littlebau.com/ios/step2/02.png! > step 3 > I use Xcode and setting the Signing，it will build success > !https://www.littlebau.com/ios/step3/01.png! > !https://www.littlebau.com/ios/step3/02.png! > step 4 > but if I use︰cordova build ios --device --release > it will "ARCHIVED FAIL" > !https://www.littlebau.com/ios/step4/01.png! > !https://www.littlebau.com/ios/step4/02.png! > !https://www.littlebau.com/ios/step4/03.png! > in previous cordova-ios version，above workflow is work perfect and it will > generate a ipa format file finally > but in new cordova-ios or Xcode version，it seem not work anymore > if I miss something or give me some hint to solve it ? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13646) Unable to compile native code (android.useDeprecated.Ndk not supported anymore)
[
https://issues.apache.org/jira/browse/CB-13646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283497#comment-16283497
]
Jan Piotrowski (Sujan) commented on CB-13646:
-
As there are no reaction buttons on JIRA: Have a :thumbsup: for the workarounds
:)
> Unable to compile native code (android.useDeprecated.Ndk not supported
> anymore)
> ---
>
> Key: CB-13646
> URL: https://issues.apache.org/jira/browse/CB-13646
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: 7.0.0
>Reporter: Michael Goffioul
>Assignee: Joe Bowser
>Priority: Critical
>
> A cordova project that contains native/jni code fails to compile, because
> android.useDeprecatedNdk is not supported anymore.
> Steps to reproduce:
> 1) create a new cordova project
> 2) add android platform
> 3) mkdir platforms/android/app/src/main/jni
> 4) touch platforms/android/app/src/main/jni/Android.mk
> 5) cordova build android
> It fails with the following error:
> {code}
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':app:compileDebugNdk'.
> > Error: Flag android.useDeprecatedNdk is no longer supported and will be
> > removed in the next version of Android Studio. Please switch to a
> > supported build system.
> Consider using CMake or ndk-build integration. For more information, go to:
>https://d.android.com/r/studio-ui/add-native-code.html#ndkCompile
>To get started, you can use the sample ndk-build script the Android
>plugin generated for you at:
> .../testnative/platforms/android/app/build/intermediates/ndk/debug/Android.mk
> Alternatively, you can use the experimental plugin:
>https://developer.android.com/r/tools/experimental-plugin.html
> To continue using the deprecated NDK compile for another 60 days, set
> android.deprecatedNdkCompileLease=1512654767567 in gradle.properties
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.
[ https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283495#comment-16283495 ] ASF GitHub Bot commented on CB-13641: - IndieSW commented on issue #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-350258370 Thanks for all the help! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen on Windows does not allow for transparent background color. > - > > Key: CB-13641 > URL: https://issues.apache.org/jira/browse/CB-13641 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-windows >Affects Versions: cordova@7.0.0 > Environment: Windows 10. >Reporter: Terence Bandoian >Priority: Trivial > Labels: newbie > Fix For: Master > > > The splash screen background color defaults to #464646. In splashscreen.js, > the background color is expected to be a hex value and values longer than > seven characters are spliced to remove the alpha channel. The configured > value could be checked for the value 'transparent' and, in that case, not > spliced. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13647) Incomplete plugin restoration
[
https://issues.apache.org/jira/browse/CB-13647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283474#comment-16283474
]
Michael Goffioul commented on CB-13647:
---
[~bowserj] I admit that 2 entries with different path types is
more theoretical. The more practical problem I faced was with my own plugin,
using both and . The cordova-android@7.0.0 release
notes only states to modify , it doesn't say anything about
, and more importantly it doesn't state that if you use both, they
MUST refer to the same path type.
I'm using cordova-common@2.2.0
On a side but related note, I also faced inconsistencies when using
, because path translation is enforced, meaning you can't (and
must not) use the prefix "app/src/main" in the target attribute. For instance,
with the following plugin.xml, you end up with a file in
platforms/android/app/src/main/app/src/main/res/drawable/image.png and that's
not what you want:
{code}
http://apache.org/cordova/ns/plugins/1.0";
id="com.example.testplugin1" version="1.0.0">
Test Plugin 1
{code}
So at the moment, the rules I've figured out are (new == with prefix
"app/src/main", legacy == without prefix):
- : you may use new or legacy paths
- : you may only use new paths
- : you may use new or legacy paths for *.java files; for other
files you may only use new paths
- : you may only use legacy paths
It would be easier to have a consistent behavior for all of them.
> Incomplete plugin restoration
> -
>
> Key: CB-13647
> URL: https://issues.apache.org/jira/browse/CB-13647
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: 7.0.0
>Reporter: Michael Goffioul
>Assignee: Joe Bowser
>
> I'm having a problem with plugin restoration since cordova-android 7.0.0,
> when plugins use a mix of config-file and edit-config on the same file (e.g.
> AndroidManifest.xml) and only edit-config uses the real path to the file.
> I've tried both cordova-cli 6.5.0 and 7.1.0 with the same result.
> 1) Create a new corodva project and enter top-level direcotyr
> 2) Create subfolder to contain a local plugin: mkdir -p
> localplugins/testplugin1
> 3) Create the following files to define the local plugin:
> - plugin.xml (adds an attribute to and a category to
> )
> {code}
>
> http://apache.org/cordova/ns/plugins/1.0";
> id="com.example.testplugin1" version="1.0.0">
> Test Plugin 1
>
> parent="/manifest/application/activity/intent-filter">
>
>
> target="/manifest/application" mode="merge">
>
>
>
>
> {code}
> - package.json
> {code}
> {
> "name": "com.example.testplugin1",
> "version": "1.0.0"
> }
> {code}
> 4) Add android platform: cordova platform add android@7.0.0 --save
> 5) Add local plugin: cordova plugin add localplugins/testplugin1 --save
> At this point, if you check
> platforms/android/app/src/main/AndroidManifest.xml, it'll contain the 2
> changes defined in the plugin.
> Now attempt to use platform/plugin restoration with thw following:
> {code}
> cordova platform rm android
> cordova prepare android
> {code}
> If you check again AndroidManifest.xml, it will only contain one of the
> changes defined in the plugin (the attribute to ). The other
> change is missing.
> If you use the real path to AndroidManifest.xml for the definition of
> , then the problem does not occur. BUT, the problem can also
> occur when changes to AndroidManifest.xml are coming from multiple plugins,
> including the standard cordova plugin, most of which do not use the real path
> to AndroidManifest.xml yet.
> The problem can affect other files too. For instance I experienced incomplete
> restoration of plugins trying to register themselves in res/xml/config.xml.
> Only one plugin, out of 7, was using the real path
> app/src/main/res/xml/config.xml and I ended up with only one plugin defined
> in res/xml/config.xml, causing the application to fail to start.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13639) The fetch request has a cross-origin problem
[
https://issues.apache.org/jira/browse/CB-13639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283463#comment-16283463
]
Jan Piotrowski (Sujan) commented on CB-13639:
-
Cordova is not Phonegap.
Depending on the Webview you are using, cross-domain security does apply.
Also depending on the type of API you use, cross-domain security does apply.
If you need to work around CORS issues in your app, use
https://github.com/silkimen/cordova-plugin-advanced-http As far as I know,
there it never applies.
> The fetch request has a cross-origin problem
>
>
> Key: CB-13639
> URL: https://issues.apache.org/jira/browse/CB-13639
> Project: Apache Cordova
> Issue Type: Bug
> Environment: # cordova6/cordova7
> # 华为（HUAWEI）畅享5S Android5.1.1
>Reporter: Lorcan Lai
> Labels: cors, fetch
>
> I used [fetch](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API) to
> request a service，report "...cross-origin..." problem. And then I try to use
> Ajax or XMLHttpRequest to request the same service，there's no problem.
> a part of the content in my config.xml,
> {code:xml}
>
> http://*/*"; />
> https://*/*"; />
>
> {code}
> Cordova is not good for the fetch request?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13639) The fetch request has a cross-origin problem
[
https://issues.apache.org/jira/browse/CB-13639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Piotrowski (Sujan) resolved CB-13639.
-
Resolution: Invalid
Closed this as it is not an issue with Cordova.
> The fetch request has a cross-origin problem
>
>
> Key: CB-13639
> URL: https://issues.apache.org/jira/browse/CB-13639
> Project: Apache Cordova
> Issue Type: Bug
> Environment: # cordova6/cordova7
> # 华为（HUAWEI）畅享5S Android5.1.1
>Reporter: Lorcan Lai
> Labels: cors, fetch
>
> I used [fetch](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API) to
> request a service，report "...cross-origin..." problem. And then I try to use
> Ajax or XMLHttpRequest to request the same service，there's no problem.
> a part of the content in my config.xml,
> {code:xml}
>
> http://*/*"; />
> https://*/*"; />
>
> {code}
> Cordova is not good for the fetch request?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.
[ https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283459#comment-16283459 ] ASF GitHub Bot commented on CB-13641: - janpio commented on issue #244: CB-13641: (windows) allow for transparent splash screen background co… URL: https://github.com/apache/cordova-windows/pull/244#issuecomment-350252969 Hm? You could have just committed the changes to your `IndieSW:master` branch for them to show up here automatically. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Splash screen on Windows does not allow for transparent background color. > - > > Key: CB-13641 > URL: https://issues.apache.org/jira/browse/CB-13641 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-windows >Affects Versions: cordova@7.0.0 > Environment: Windows 10. >Reporter: Terence Bandoian >Priority: Trivial > Labels: newbie > Fix For: Master > > > The splash screen background color defaults to #464646. In splashscreen.js, > the background color is expected to be a hex value and values longer than > seven characters are spliced to remove the alpha channel. The configured > value could be checked for the value 'transparent' and, in that case, not > spliced. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12853) Update available message after update [on Windows]
[ https://issues.apache.org/jira/browse/CB-12853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesse MacFadyen resolved CB-12853. -- Resolution: Fixed > Update available message after update [on Windows] > -- > > Key: CB-12853 > URL: https://issues.apache.org/jira/browse/CB-12853 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Reporter: Chris Brody >Assignee: Jesse MacFadyen >Priority: Minor > > As I reported in https://github.com/cordova/cordova-discuss/issues/68 I saw > the following on my Windows 10 professional dev machine: > C:\Users\Chris > λ > C:\Users\Chris > λ npm update -g cordova > npm WARN deprecated node-uuid@1.4.8: Use uuid module instead > C:\Users\Chris\nvs\default\cordova -> > C:\Users\Chris\nvs\default\node_modules\cordova\bin\cordova > C:\Users\Chris\nvs\default > `-- cordova@7.0.1 > C:\Users\Chris > λ cordova --version > 7.0.1 > ┌──┐ > │ Update available: 7.0.1 (current: 7.0.0) │ > │ Run npm install -g cordova to update.│ > └──┘ > C:\Users\Chris > λ cordova --version > 7.0.1 > C:\Users\Chris > λ -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-12853) Update available message after update [on Windows]
[ https://issues.apache.org/jira/browse/CB-12853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesse MacFadyen reassigned CB-12853: Assignee: Jesse MacFadyen > Update available message after update [on Windows] > -- > > Key: CB-12853 > URL: https://issues.apache.org/jira/browse/CB-12853 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Reporter: Chris Brody >Assignee: Jesse MacFadyen >Priority: Minor > > As I reported in https://github.com/cordova/cordova-discuss/issues/68 I saw > the following on my Windows 10 professional dev machine: > C:\Users\Chris > λ > C:\Users\Chris > λ npm update -g cordova > npm WARN deprecated node-uuid@1.4.8: Use uuid module instead > C:\Users\Chris\nvs\default\cordova -> > C:\Users\Chris\nvs\default\node_modules\cordova\bin\cordova > C:\Users\Chris\nvs\default > `-- cordova@7.0.1 > C:\Users\Chris > λ cordova --version > 7.0.1 > ┌──┐ > │ Update available: 7.0.1 (current: 7.0.0) │ > │ Run npm install -g cordova to update.│ > └──┘ > C:\Users\Chris > λ cordova --version > 7.0.1 > C:\Users\Chris > λ -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12853) Update available message after update [on Windows]
[ https://issues.apache.org/jira/browse/CB-12853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283181#comment-16283181 ] ASF subversion and git services commented on CB-12853: -- Commit 0a5b07a7bf5739b93182a80de17de82b333c8946 in cordova-cli's branch refs/heads/master from [~purplecabbage] [ https://gitbox.apache.org/repos/asf?p=cordova-cli.git;h=0a5b07a ] CB-12853 re-check version before notifying. Actually a update-notifier issue. > Update available message after update [on Windows] > -- > > Key: CB-12853 > URL: https://issues.apache.org/jira/browse/CB-12853 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Reporter: Chris Brody >Priority: Minor > > As I reported in https://github.com/cordova/cordova-discuss/issues/68 I saw > the following on my Windows 10 professional dev machine: > C:\Users\Chris > λ > C:\Users\Chris > λ npm update -g cordova > npm WARN deprecated node-uuid@1.4.8: Use uuid module instead > C:\Users\Chris\nvs\default\cordova -> > C:\Users\Chris\nvs\default\node_modules\cordova\bin\cordova > C:\Users\Chris\nvs\default > `-- cordova@7.0.1 > C:\Users\Chris > λ cordova --version > 7.0.1 > ┌──┐ > │ Update available: 7.0.1 (current: 7.0.0) │ > │ Run npm install -g cordova to update.│ > └──┘ > C:\Users\Chris > λ cordova --version > 7.0.1 > C:\Users\Chris > λ -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
