[jira] [Updated] (CB-13815) Remove old iOS code from cordova-plugin-media-capture
[ https://issues.apache.org/jira/browse/CB-13815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile updated CB-13815: -- Description: cordova-ios supports iOS 9 and newer, but cordova-plugin-media-capture still has IsAtLeastiOSVersion(@"7.0") code that is not needed. Also used UIAlertView which is deprecated We should remove all the IsAtLeastiOSVersion(@"7.0") and replace the UIAlertView with UIAlertController and some other old unused code was: cordova-ios supports iOS 9 and newer, but cordova-plugin-camera still has a lot of IsAtLeastiOSVersion(@"8.0") code that is not needed. Also used UIAlertView which is deprecated We should remove all the IsAtLeastiOSVersion(@"8.0") and replace the UIAlertView with UIAlertController and some other old unused code > Remove old iOS code from cordova-plugin-media-capture > - > > Key: CB-13815 > URL: https://issues.apache.org/jira/browse/CB-13815 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-media-capture >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > cordova-ios supports iOS 9 and newer, but cordova-plugin-media-capture still > has IsAtLeastiOSVersion(@"7.0") code that is not needed. Also used > UIAlertView which is deprecated > We should remove all the IsAtLeastiOSVersion(@"7.0") and replace the > UIAlertView with UIAlertController and some other old unused code -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13813) Remove old iOS code from cordova-plugin-camera
[ https://issues.apache.org/jira/browse/CB-13813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile updated CB-13813: -- Description: cordova-ios supports iOS 9 and newer, but cordova-plugin-camera still has IsAtLeastiOSVersion(@"8.0") code that is not needed. Also used UIAlertView which is deprecated We should remove all the IsAtLeastiOSVersion(@"8.0") and replace the UIAlertView with UIAlertController and some other old unused code was: cordova-ios supports iOS 9 and newer, but cordova-plugin-camera still has a lot of IsAtLeastiOSVersion(@"8.0") code that is not needed. Also used UIAlertView which is deprecated We should remove all the IsAtLeastiOSVersion(@"8.0") and replace the UIAlertView with UIAlertController and some other old unused code > Remove old iOS code from cordova-plugin-camera > -- > > Key: CB-13813 > URL: https://issues.apache.org/jira/browse/CB-13813 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-camera >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > cordova-ios supports iOS 9 and newer, but cordova-plugin-camera still has > IsAtLeastiOSVersion(@"8.0") code that is not needed. Also used UIAlertView > which is deprecated > We should remove all the IsAtLeastiOSVersion(@"8.0") and replace the > UIAlertView with UIAlertController and some other old unused code -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13815) Remove old iOS code from cordova-plugin-media-capture
[ https://issues.apache.org/jira/browse/CB-13815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile updated CB-13815: -- Component/s: (was: cordova-plugin-camera) cordova-plugin-media-capture > Remove old iOS code from cordova-plugin-media-capture > - > > Key: CB-13815 > URL: https://issues.apache.org/jira/browse/CB-13815 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-media-capture >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > cordova-ios supports iOS 9 and newer, but cordova-plugin-camera still has a > lot of IsAtLeastiOSVersion(@"8.0") code that is not needed. Also used > UIAlertView which is deprecated > We should remove all the IsAtLeastiOSVersion(@"8.0") and replace the > UIAlertView with UIAlertController and some other old unused code -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13815) Remove old iOS code from cordova-plugin-media-capture
jcesarmobile created CB-13815: - Summary: Remove old iOS code from cordova-plugin-media-capture Key: CB-13815 URL: https://issues.apache.org/jira/browse/CB-13815 Project: Apache Cordova Issue Type: Improvement Components: cordova-plugin-camera Reporter: jcesarmobile Assignee: jcesarmobile cordova-ios supports iOS 9 and newer, but cordova-plugin-camera still has a lot of IsAtLeastiOSVersion(@"8.0") code that is not needed. Also used UIAlertView which is deprecated We should remove all the IsAtLeastiOSVersion(@"8.0") and replace the UIAlertView with UIAlertController and some other old unused code -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13814) Remove old iOS code from cordova-plugin-dialogs
[ https://issues.apache.org/jira/browse/CB-13814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile updated CB-13814: -- Component/s: (was: cordova-plugin-camera) cordova-plugin-dialogs > Remove old iOS code from cordova-plugin-dialogs > --- > > Key: CB-13814 > URL: https://issues.apache.org/jira/browse/CB-13814 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-dialogs >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > cordova-plugin-dialogs still have UIAlertView code, which is deprecated > We should remove all the UIAlertView code -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13814) Remove old iOS code from cordova-plugin-dialogs
[ https://issues.apache.org/jira/browse/CB-13814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile updated CB-13814: -- Description: cordova-plugin-dialogs still have UIAlertView code, which is deprecated We should remove all the UIAlertView code was: cordova-ios supports iOS 9 and newer, but cordova-plugin-camera still has a lot of IsAtLeastiOSVersion(@"8.0") code that is not needed. Also used UIAlertView which is deprecated We should remove all the IsAtLeastiOSVersion(@"8.0") and replace the UIAlertView with UIAlertController and some other old unused code > Remove old iOS code from cordova-plugin-dialogs > --- > > Key: CB-13814 > URL: https://issues.apache.org/jira/browse/CB-13814 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-dialogs >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > cordova-plugin-dialogs still have UIAlertView code, which is deprecated > We should remove all the UIAlertView code -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13814) Remove old iOS code from cordova-plugin-dialogs
jcesarmobile created CB-13814: - Summary: Remove old iOS code from cordova-plugin-dialogs Key: CB-13814 URL: https://issues.apache.org/jira/browse/CB-13814 Project: Apache Cordova Issue Type: Improvement Components: cordova-plugin-camera Reporter: jcesarmobile Assignee: jcesarmobile cordova-ios supports iOS 9 and newer, but cordova-plugin-camera still has a lot of IsAtLeastiOSVersion(@"8.0") code that is not needed. Also used UIAlertView which is deprecated We should remove all the IsAtLeastiOSVersion(@"8.0") and replace the UIAlertView with UIAlertController and some other old unused code -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13813) Remove old iOS code from cordova-plugin-camera
[ https://issues.apache.org/jira/browse/CB-13813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile updated CB-13813: -- Component/s: (was: cordova-plugin-statusbar) cordova-plugin-camera > Remove old iOS code from cordova-plugin-camera > -- > > Key: CB-13813 > URL: https://issues.apache.org/jira/browse/CB-13813 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-camera >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > cordova-ios supports iOS 9 and newer, but cordova-plugin-camera still has a > lot of IsAtLeastiOSVersion(@"8.0") code that is not needed. Also used > UIAlertView which is deprecated > We should remove all the IsAtLeastiOSVersion(@"8.0") and replace the > UIAlertView with UIAlertController and some other old unused code -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13813) Remove old iOS code from cordova-plugin-camera
[ https://issues.apache.org/jira/browse/CB-13813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile updated CB-13813: -- Description: cordova-ios supports iOS 9 and newer, but cordova-plugin-camera still has a lot of IsAtLeastiOSVersion(@"8.0") code that is not needed. Also used UIAlertView which is deprecated We should remove all the IsAtLeastiOSVersion(@"8.0") and replace the UIAlertView with UIAlertController and some other old unused code was: cordova-ios supports iOS 9 and newer, but cordova-plugin-statusbar still has a lot of IsAtLeastiOSVersion(@"7.0") code that is not needed. We should remove all the IsAtLeastiOSVersion(@"7.0") and remove any code in case there is an else for iOS 6 and iOS 7 specific code > Remove old iOS code from cordova-plugin-camera > -- > > Key: CB-13813 > URL: https://issues.apache.org/jira/browse/CB-13813 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-camera >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > cordova-ios supports iOS 9 and newer, but cordova-plugin-camera still has a > lot of IsAtLeastiOSVersion(@"8.0") code that is not needed. Also used > UIAlertView which is deprecated > We should remove all the IsAtLeastiOSVersion(@"8.0") and replace the > UIAlertView with UIAlertController and some other old unused code -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13813) Remove old iOS code from cordova-plugin-camera
jcesarmobile created CB-13813: - Summary: Remove old iOS code from cordova-plugin-camera Key: CB-13813 URL: https://issues.apache.org/jira/browse/CB-13813 Project: Apache Cordova Issue Type: Improvement Components: cordova-plugin-statusbar Reporter: jcesarmobile Assignee: jcesarmobile cordova-ios supports iOS 9 and newer, but cordova-plugin-statusbar still has a lot of IsAtLeastiOSVersion(@"7.0") code that is not needed. We should remove all the IsAtLeastiOSVersion(@"7.0") and remove any code in case there is an else for iOS 6 and iOS 7 specific code -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13811) jquery-mobile styles lost, when appending with jquery
[
https://issues.apache.org/jira/browse/CB-13811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jcesarmobile closed CB-13811.
-
Resolution: Not A Problem
This is not a Cordova problem, it's a basic jQuery mobile knowledge problem.
jQuery doesn't style the things you append after jQuery is ready. By appending
before device ready you are also doing it before jQuery ready, so it's styled,
once jQuery is ready it won't style new elements. To style the elements you
append jQuery offers different ways based on the version used, read their docs.
> jquery-mobile styles lost, when appending with jquery
> -
>
> Key: CB-13811
> URL: https://issues.apache.org/jira/browse/CB-13811
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
>Reporter: Piotr
>Assignee: Joe Bowser
>Priority: Major
> Labels: JQueryMobile, jquery
> Attachments: input1.png, input2.png
>
>
> Not sure, if this should be considered a bug; it seems unlikely, that nobody
> has encountered it..
> When fields are added with jquery after 'onDeviceReady' in 'index.js'
> jquery mobile styles are lost.
> minimal example:
> index.html:
> ...
>
>
> ...
> index.js:
> ...
> onDeviceReady: function() {
> $("#myone").append("");
> }, ...
> see input2.png
> If the fields are added before 'onDeviceReady' they are styled
> appropriately.
> see input1.png
>
> This is akward and I couldn't find any workaround. Does cordova style
> s in a special way? Some solution would be highly appreciated!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13802) Avoid unnecessary ApplicationView access on Windows 8.1
[
https://issues.apache.org/jira/browse/CB-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333700#comment-16333700
]
Chris Brody commented on CB-13802:
--
As I said in [apache /
cordova-windows/pull/245#issuecomment-359284955|https://github.com/apache/cordova-windows/pull/245#issuecomment-359284955]
(CB-13641): When I tried making the changes for CB-13802 it seemed to resolve
some but not all warnings related to the application view on Windows 8.1 /
Windows Phone 8.1. You can see my raw notes in
[master...brodybits:CB-13802-wiptest1|https://github.com/apache/cordova-windows/compare/master...brodybits:CB-13802-wiptest1]
([brodybits/cordova-windows@1e91c01|https://github.com/brodybits/cordova-windows/commit/1e91c012d5c7fa055c0c450de98aaf0517b77a67]).
I will continue this work another day.
> Avoid unnecessary ApplicationView access on Windows 8.1
> ---
>
> Key: CB-13802
> URL: https://issues.apache.org/jira/browse/CB-13802
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: Chris Brody
>Assignee: Jesse MacFadyen
>Priority: Minor
>
> From changes in CB-12238, CB-12784, and CB-13641 I noticed a few spots where
> {{Windows.UI.ViewManagement.ApplicationView.getForCurrentView()}} is called
> for no good reason on Windows 8.1, along with a couple "else crash on 8.1"
> comments nearby.
> The following changes (NOT TESTED) would resolve this issue:
> {code:sh}
> diff --git a/cordova-js-src/splashscreen.js b/cordova-js-src/splashscreen.js
> index 97fd86c..77bca75 100644
> --- a/cordova-js-src/splashscreen.js
> +++ b/cordova-js-src/splashscreen.js
> @@ -198,7 +198,7 @@ function enableUserInteraction() {
>
> // Enter fullscreen mode
> function enterFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
> var view =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useCoreWindow);
> view.suppressSystemOverlays = true;
> @@ -207,7 +207,7 @@ function enterFullScreen() {
>
> // Exit fullscreen mode
> function exitFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
> var view =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useVisible);
> view.suppressSystemOverlays = false;
> @@ -216,8 +216,10 @@ function exitFullScreen() {
>
> // Make title bg color match splashscreen bg color
> function colorizeTitleBar() {
> -var appView =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
> titleInitialBgColor = appView.titleBar.backgroundColor;
>
> appView.titleBar.backgroundColor = titleBgColor;
> @@ -227,8 +229,10 @@ function colorizeTitleBar() {
>
> // Revert title bg color
> function revertTitleBarColor() {
> -var appView =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
> appView.titleBar.backgroundColor = titleInitialBgColor;
> appView.titleBar.buttonBackgroundColor = titleInitialBgColor;
> }
> {code}
> Unfortunately I do not know how to test splashscreen changes myself, guidance
> would be appreciated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12927) cordova requirements for `windows` show old VS version error message
[ https://issues.apache.org/jira/browse/CB-12927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) resolved CB-12927. - Resolution: Fixed A fix for this has been merged and should be released with 5.1.0. > cordova requirements for `windows` show old VS version error message > > > Key: CB-12927 > URL: https://issues.apache.org/jira/browse/CB-12927 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Affects Versions: 5.0.0 >Reporter: Jan Piotrowski (Sujan) >Assignee: Jesse MacFadyen >Priority: Minor > > If you have `windows` added as a platform and execute `cordova requirements` > it points you to install old Visual Studio: > MSBuild Tools: not installed > MSBuild tools v.14.0 not found. Please install Visual Studio 2015 Community > from https://www.visualstudio.com/downloads/download-visual-studio-vs > Visual Studio: not installed > Required version of Visual Studio not found. Please install Visual Studio > 2015 Community from > https://www.visualstudio.com/downloads/download-visual-studio-vs > (Source: > https://forum.ionicframework.com/t/ionic-3-and-visual-studio-2017-required-version-of-visual-studio-not-found/94538/3) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13201) Javasript runtime error from removeEventListener() in cordova.js
[
https://issues.apache.org/jira/browse/CB-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333661#comment-16333661
]
Jan Piotrowski (Sujan) commented on CB-13201:
-
`handleEvent` is not really part of that function you posted. Are you sure you
are pasting the correct functtion? It might be easier to follow if you link to
the actual code on Github.
> Javasript runtime error from removeEventListener() in cordova.js
>
>
> Key: CB-13201
> URL: https://issues.apache.org/jira/browse/CB-13201
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Environment: Windows 10 UWP
>Reporter: Mazen Debe
>Assignee: Jesse MacFadyen
>Priority: Major
> Labels: cordova-windows, javascript, uwp, windows
>
> I am developing a Cordova-based app for a Windows 10 platform. There is a
> button that whenever I press, cordova.js throws the following exception at
> this function:
> document.removeEventListener = function(evt, handler, capture) {
> var e = evt.toLowerCase();
> // If unsubscribing from an event that is handled by a plugin
> if (typeof documentEventHandlers[e] != "undefined") {
> documentEventHandlers[e].unsubscribe(handler);
> } else {
> m_document_removeEventListener.call(document, evt, handler, capture);
> }
> };
> The exception text is as follows:
> Unhandled exception at line 154, column 9 in
> ms-appx-web://com.something/www/cordova.js
> 0x800a138f - JavaScript runtime error: Unable to get property 'handleEvent'
> of undefined or null reference occurred
> Any idea what could be the issue here??
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13422) Typo in Windows build error message
[ https://issues.apache.org/jira/browse/CB-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) resolved CB-13422. - Resolution: Fixed This has been merged and should be released with 5.1.0. > Typo in Windows build error message > --- > > Key: CB-13422 > URL: https://issues.apache.org/jira/browse/CB-13422 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Affects Versions: Master > Environment: Windows build >Reporter: Christian Wenz >Assignee: Jesse MacFadyen >Priority: Trivial > Original Estimate: 5m > Remaining Estimate: 5m > > One of the dreaded error messages when building Cordova on Windows is when > the AppPackages directory cannot be found. However, there is a typo in the > error message: > "Error: AppPackages doesn't exists" > Correct and easier to understand would be: > "Error: AppPackages folder doesn't exist" -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13812) CI doesn't run with VS 2017
[ https://issues.apache.org/jira/browse/CB-13812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) resolved CB-13812. - Resolution: Fixed > CI doesn't run with VS 2017 > --- > > Key: CB-13812 > URL: https://issues.apache.org/jira/browse/CB-13812 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > We support Visual Studio 2017 (I think at least...) but CI is only run on the > default image which uses VS 2015. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13802) Avoid unnecessary ApplicationView access on Windows 8.1
[
https://issues.apache.org/jira/browse/CB-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333638#comment-16333638
]
Jan Piotrowski (Sujan) commented on CB-13802:
-
May very well be that nobody there knows why this is the case.
As I wrote in another comment a few minutes ago (I really have no overview any
more) the official and best channel for that would probably be the dev mailing
list (although lots of messages are ignored there as well...).
> Avoid unnecessary ApplicationView access on Windows 8.1
> ---
>
> Key: CB-13802
> URL: https://issues.apache.org/jira/browse/CB-13802
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: Chris Brody
>Assignee: Jesse MacFadyen
>Priority: Minor
>
> From changes in CB-12238, CB-12784, and CB-13641 I noticed a few spots where
> {{Windows.UI.ViewManagement.ApplicationView.getForCurrentView()}} is called
> for no good reason on Windows 8.1, along with a couple "else crash on 8.1"
> comments nearby.
> The following changes (NOT TESTED) would resolve this issue:
> {code:sh}
> diff --git a/cordova-js-src/splashscreen.js b/cordova-js-src/splashscreen.js
> index 97fd86c..77bca75 100644
> --- a/cordova-js-src/splashscreen.js
> +++ b/cordova-js-src/splashscreen.js
> @@ -198,7 +198,7 @@ function enableUserInteraction() {
>
> // Enter fullscreen mode
> function enterFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
> var view =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useCoreWindow);
> view.suppressSystemOverlays = true;
> @@ -207,7 +207,7 @@ function enterFullScreen() {
>
> // Exit fullscreen mode
> function exitFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
> var view =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useVisible);
> view.suppressSystemOverlays = false;
> @@ -216,8 +216,10 @@ function exitFullScreen() {
>
> // Make title bg color match splashscreen bg color
> function colorizeTitleBar() {
> -var appView =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
> titleInitialBgColor = appView.titleBar.backgroundColor;
>
> appView.titleBar.backgroundColor = titleBgColor;
> @@ -227,8 +229,10 @@ function colorizeTitleBar() {
>
> // Revert title bg color
> function revertTitleBarColor() {
> -var appView =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
> appView.titleBar.backgroundColor = titleInitialBgColor;
> appView.titleBar.buttonBackgroundColor = titleInitialBgColor;
> }
> {code}
> Unfortunately I do not know how to test splashscreen changes myself, guidance
> would be appreciated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13803) Possible crash on Windows 8.1 in case of fullscreen mode
[
https://issues.apache.org/jira/browse/CB-13803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333637#comment-16333637
]
Chris Brody commented on CB-13803:
--
By "on Windows 8.1" I meant "on Windows 8.1 build" (I tested Windows 8.1 build
on my Windows 10 system).
Here is the full JavaScript console log I get with the log statements added
above:
{code}
The method
Windows.UI.ApplicationSettings.ISettingsPaneStatics.getForCurrentView has been
deprecated. SettingsPane is deprecated and might not work on all platforms. For
more info, see MSDN.
The event Windows.UI.ApplicationSettings.ISettingsPane.add_CommandsRequested
has been deprecated. SettingsPane is deprecated and might not work on all
platforms. For more info, see MSDN.
spashscreen show
enterFullScreen
get application view
The method Windows.UI.ViewManagement.ApplicationView.put_SuppressSystemOverlays
has been deprecated. Use the TryEnterFullScreen method and IsFullScreenMode
property instead of SuppressSystemOverlays. For more info, see MSDN.
Received Event: deviceready
exitFullScreen
get application view
{code}
I would not see the warning messages if I run on Windows 10 (UWP) build. I
would consider these warnings to be a very minor since I think Windows 8.1 /
Windows Phone 8.1 support should be deprecated.
> Possible crash on Windows 8.1 in case of fullscreen mode
>
>
> Key: CB-13803
> URL: https://issues.apache.org/jira/browse/CB-13803
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: Chris Brody
>Assignee: Jesse MacFadyen
>Priority: Major
>
> From CB-13802 I noticed a couple spots in splashscreen.js, related to
> fullscreen mode, marked "else crash on 8.1". The changes I recommended in
> CB-13802 should resolve this issue.
> I would be happy if CB-13802 would be resolved, with this one marked as a
> duplicate.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13802) Avoid unnecessary ApplicationView access on Windows 8.1
[
https://issues.apache.org/jira/browse/CB-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333636#comment-16333636
]
Terence Bandoian commented on CB-13802:
---
By the way, [~Sujan12], I asked a related question on Slack when I noticed
differences between cordova.js and the code in cordova-js-src but didn't get a
reply.
> Avoid unnecessary ApplicationView access on Windows 8.1
> ---
>
> Key: CB-13802
> URL: https://issues.apache.org/jira/browse/CB-13802
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: Chris Brody
>Assignee: Jesse MacFadyen
>Priority: Minor
>
> From changes in CB-12238, CB-12784, and CB-13641 I noticed a few spots where
> {{Windows.UI.ViewManagement.ApplicationView.getForCurrentView()}} is called
> for no good reason on Windows 8.1, along with a couple "else crash on 8.1"
> comments nearby.
> The following changes (NOT TESTED) would resolve this issue:
> {code:sh}
> diff --git a/cordova-js-src/splashscreen.js b/cordova-js-src/splashscreen.js
> index 97fd86c..77bca75 100644
> --- a/cordova-js-src/splashscreen.js
> +++ b/cordova-js-src/splashscreen.js
> @@ -198,7 +198,7 @@ function enableUserInteraction() {
>
> // Enter fullscreen mode
> function enterFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
> var view =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useCoreWindow);
> view.suppressSystemOverlays = true;
> @@ -207,7 +207,7 @@ function enterFullScreen() {
>
> // Exit fullscreen mode
> function exitFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
> var view =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useVisible);
> view.suppressSystemOverlays = false;
> @@ -216,8 +216,10 @@ function exitFullScreen() {
>
> // Make title bg color match splashscreen bg color
> function colorizeTitleBar() {
> -var appView =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
> titleInitialBgColor = appView.titleBar.backgroundColor;
>
> appView.titleBar.backgroundColor = titleBgColor;
> @@ -227,8 +229,10 @@ function colorizeTitleBar() {
>
> // Revert title bg color
> function revertTitleBarColor() {
> -var appView =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
> appView.titleBar.backgroundColor = titleInitialBgColor;
> appView.titleBar.buttonBackgroundColor = titleInitialBgColor;
> }
> {code}
> Unfortunately I do not know how to test splashscreen changes myself, guidance
> would be appreciated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13803) Possible crash on Windows 8.1 in case of fullscreen mode
[
https://issues.apache.org/jira/browse/CB-13803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Brody closed CB-13803.
Resolution: Invalid
Closing as invalid since it does not really crash with any uncaught exception
on Windows 8.1. I I would add log statements to cordova.js from the latest
version of cordova-windows:
{code}
@@ -2034,7 +2034,9 @@
// Enter fullscreen mode
function enterFullScreen () {
+console.log('enterFullScreen');
if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else
crash on 8.1
+console.log('get application view');
var view =
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useCoreWindow);
view.suppressSystemOverlays = true;
@@ -2043,7 +2045,9 @@
// Exit fullscreen mode
function exitFullScreen () {
+console.log('exitFullScreen');
if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else
crash on 8.1
+console.log('get application view');
var view =
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useVisible);
view.suppressSystemOverlays = false;
@@ -2072,6 +2076,7 @@
// Displays the extended splash screen. Pass the splash screen object
retrieved during activation.
function show () {
+console.log('spashscreen show');
enterFullScreen();
colorizeTitleBar();
disableUserInteraction();
{code}
and then run on Windows 8.1 I get the following in the JavaScript Console
(redacted with extra warning messages removed):
{code}
spashscreen show
enterFullScreen
get application view
Received Event: deviceready
exitFullScreen
get application view
{code}
So {{if (Windows.UI.ViewManagement.ApplicationViewBoundsMode)}} proves itself
to work as a guard to avoid possible crash on Windows 8.1.
Remaining task is to remove the incorrrect "else crash on 8.1" comments, will
add this to the code cleanup in CB-13802.
> Possible crash on Windows 8.1 in case of fullscreen mode
>
>
> Key: CB-13803
> URL: https://issues.apache.org/jira/browse/CB-13803
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: Chris Brody
>Assignee: Jesse MacFadyen
>Priority: Major
>
> From CB-13802 I noticed a couple spots in splashscreen.js, related to
> fullscreen mode, marked "else crash on 8.1". The changes I recommended in
> CB-13802 should resolve this issue.
> I would be happy if CB-13802 would be resolved, with this one marked as a
> duplicate.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13802) Avoid unnecessary ApplicationView access on Windows 8.1
[
https://issues.apache.org/jira/browse/CB-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333632#comment-16333632
]
Terence Bandoian commented on CB-13802:
---
Right, [~Sujan12], additional comments might be better here on the issue
[~brodybits] raised.
> Avoid unnecessary ApplicationView access on Windows 8.1
> ---
>
> Key: CB-13802
> URL: https://issues.apache.org/jira/browse/CB-13802
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: Chris Brody
>Assignee: Jesse MacFadyen
>Priority: Minor
>
> From changes in CB-12238, CB-12784, and CB-13641 I noticed a few spots where
> {{Windows.UI.ViewManagement.ApplicationView.getForCurrentView()}} is called
> for no good reason on Windows 8.1, along with a couple "else crash on 8.1"
> comments nearby.
> The following changes (NOT TESTED) would resolve this issue:
> {code:sh}
> diff --git a/cordova-js-src/splashscreen.js b/cordova-js-src/splashscreen.js
> index 97fd86c..77bca75 100644
> --- a/cordova-js-src/splashscreen.js
> +++ b/cordova-js-src/splashscreen.js
> @@ -198,7 +198,7 @@ function enableUserInteraction() {
>
> // Enter fullscreen mode
> function enterFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
> var view =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useCoreWindow);
> view.suppressSystemOverlays = true;
> @@ -207,7 +207,7 @@ function enterFullScreen() {
>
> // Exit fullscreen mode
> function exitFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
> var view =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useVisible);
> view.suppressSystemOverlays = false;
> @@ -216,8 +216,10 @@ function exitFullScreen() {
>
> // Make title bg color match splashscreen bg color
> function colorizeTitleBar() {
> -var appView =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
> titleInitialBgColor = appView.titleBar.backgroundColor;
>
> appView.titleBar.backgroundColor = titleBgColor;
> @@ -227,8 +229,10 @@ function colorizeTitleBar() {
>
> // Revert title bg color
> function revertTitleBarColor() {
> -var appView =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
> appView.titleBar.backgroundColor = titleInitialBgColor;
> appView.titleBar.buttonBackgroundColor = titleInitialBgColor;
> }
> {code}
> Unfortunately I do not know how to test splashscreen changes myself, guidance
> would be appreciated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13812) CI doesn't run with VS 2017
[ https://issues.apache.org/jira/browse/CB-13812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333626#comment-16333626 ] ASF subversion and git services commented on CB-13812: -- Commit f5f4b21ad2c030ff61550bc947dca196c570f0ad in cordova-windows's branch refs/heads/master from [~Sujan12] [ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=f5f4b21 ] CB-13812 run tests on AppVeyor with VS 2017 as well > CI doesn't run with VS 2017 > --- > > Key: CB-13812 > URL: https://issues.apache.org/jira/browse/CB-13812 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > We support Visual Studio 2017 (I think at least...) but CI is only run on the > default image which uses VS 2015. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13812) CI doesn't run with VS 2017
[ https://issues.apache.org/jira/browse/CB-13812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333623#comment-16333623 ] ASF subversion and git services commented on CB-13812: -- Commit e5e15452163b7952974aa5c81f4436b24b348824 in cordova-windows's branch refs/heads/5.1.x from [~Sujan12] [ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=e5e1545 ] CB-13812 run tests on AppVeyor with VS 2017 as well > CI doesn't run with VS 2017 > --- > > Key: CB-13812 > URL: https://issues.apache.org/jira/browse/CB-13812 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > We support Visual Studio 2017 (I think at least...) but CI is only run on the > default image which uses VS 2015. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13799) Cordova-Windows Platform Release January 19/20, 2018
[ https://issues.apache.org/jira/browse/CB-13799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333613#comment-16333613 ] ASF subversion and git services commented on CB-13799: -- Commit ad55fb0612cb6b8291f81c96da2f32b775e9b1dc in cordova-windows's branch refs/heads/5.1.x from [~Sujan12] [ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=ad55fb0 ] CB-13799 run tests on AppVeyor with VS 2017 as well > Cordova-Windows Platform Release January 19/20, 2018 > > > Key: CB-13799 > URL: https://issues.apache.org/jira/browse/CB-13799 > Project: Apache Cordova > Issue Type: Task >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13812) CI doesn't run with VS 2017
[ https://issues.apache.org/jira/browse/CB-13812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333606#comment-16333606 ] Jan Piotrowski (Sujan) commented on CB-13812: - Solution: https://www.appveyor.com/docs/build-environment/#using-multiple-images-for-the-same-build > CI doesn't run with VS 2017 > --- > > Key: CB-13812 > URL: https://issues.apache.org/jira/browse/CB-13812 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jesse MacFadyen >Priority: Major > > We support Visual Studio 2017 (I think at least...) but CI is only run on the > default image which uses VS 2015. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13812) CI doesn't run with VS 2017
[ https://issues.apache.org/jira/browse/CB-13812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) reassigned CB-13812: --- Assignee: Jan Piotrowski (Sujan) (was: Jesse MacFadyen) > CI doesn't run with VS 2017 > --- > > Key: CB-13812 > URL: https://issues.apache.org/jira/browse/CB-13812 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > We support Visual Studio 2017 (I think at least...) but CI is only run on the > default image which uses VS 2015. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13812) CI doesn't run with VS 2017
Jan Piotrowski (Sujan) created CB-13812: --- Summary: CI doesn't run with VS 2017 Key: CB-13812 URL: https://issues.apache.org/jira/browse/CB-13812 Project: Apache Cordova Issue Type: Bug Components: cordova-windows Reporter: Jan Piotrowski (Sujan) Assignee: Jesse MacFadyen We support Visual Studio 2017 (I think at least...) but CI is only run on the default image which uses VS 2015. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13799) Cordova-Windows Platform Release January 19/20, 2018
[ https://issues.apache.org/jira/browse/CB-13799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333580#comment-16333580 ] ASF subversion and git services commented on CB-13799: -- Commit dd91933d7030f6f0bb207a676968c4fdad9e3691 in cordova-windows's branch refs/heads/master from [~Sujan12] [ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=dd91933 ] CB-13799 Updated checked-in node_modules > Cordova-Windows Platform Release January 19/20, 2018 > > > Key: CB-13799 > URL: https://issues.apache.org/jira/browse/CB-13799 > Project: Apache Cordova > Issue Type: Task >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13799) Cordova-Windows Platform Release January 19/20, 2018
[ https://issues.apache.org/jira/browse/CB-13799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333573#comment-16333573 ] Jan Piotrowski (Sujan) commented on CB-13799: - Turns out CI didn't actually run the tests since a change in this version. Have to fix that one first. > Cordova-Windows Platform Release January 19/20, 2018 > > > Key: CB-13799 > URL: https://issues.apache.org/jira/browse/CB-13799 > Project: Apache Cordova > Issue Type: Task >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13799) Cordova-Windows Platform Release January 19/20, 2018
[ https://issues.apache.org/jira/browse/CB-13799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333569#comment-16333569 ] ASF subversion and git services commented on CB-13799: -- Commit dd91933d7030f6f0bb207a676968c4fdad9e3691 in cordova-windows's branch refs/heads/5.1.x from [~Sujan12] [ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=dd91933 ] CB-13799 Updated checked-in node_modules > Cordova-Windows Platform Release January 19/20, 2018 > > > Key: CB-13799 > URL: https://issues.apache.org/jira/browse/CB-13799 > Project: Apache Cordova > Issue Type: Task >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13811) jquery-mobile styles lost, when appending with jquery
Piotr created CB-13811:
--
Summary: jquery-mobile styles lost, when appending with
jquery
Key: CB-13811
URL: https://issues.apache.org/jira/browse/CB-13811
Project: Apache Cordova
Issue Type: Bug
Components: cordova-android
Affects Versions: cordova-android-7.0.0
Reporter: Piotr
Assignee: Joe Bowser
Attachments: input1.png, input2.png
Not sure, if this should be considered a bug; it seems unlikely, that nobody
has encountered it..
When fields are added with jquery after 'onDeviceReady' in 'index.js'
jquery mobile styles are lost.
minimal example:
index.html:
...
...
index.js:
...
onDeviceReady: function() {
$("#myone").append("");
}, ...
see input2.png
If the fields are added before 'onDeviceReady' they are styled
appropriately.
see input1.png
This is akward and I couldn't find any workaround. Does cordova style s
in a special way? Some solution would be highly appreciated!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
