[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384873#comment-16384873 ] ASF GitHub Bot commented on CB-12242: - janpio commented on issue #292: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-370184568 Tests are failing because of a code style problem: > C:\projects\cordova-cli\src\cli.js > 496:34 error Unexpected trailing comma comma-dangle Could you please fix that so the actual tests can run an this can possibly be merged? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13772) CLI `cordova requirements` printing out [object Object] in place of some version numbers
[
https://issues.apache.org/jira/browse/CB-13772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384872#comment-16384872
]
ASF GitHub Bot commented on CB-13772:
-
janpio commented on issue #291: CB-13772: print version numbers correctly in
"cordova requirements"
URL: https://github.com/apache/cordova-cli/pull/291#issuecomment-370184497
Hey @darcymeyer, this looks like a useful change - I also noticed this
happening. Do you know why this suddenly is a problem?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CLI `cordova requirements` printing out [object Object] in place of some
> version numbers
>
>
> Key: CB-13772
> URL: https://issues.apache.org/jira/browse/CB-13772
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova@8.0.0
> Environment: macOS High Sierra 10.13.2
> npm v5.6.0
> node v9.4.0
> cordova CLI v8.0.0
>Reporter: Darcy Meyer
>Priority: Minor
>
> When `cordova requirements` is executed, the output prints [object Object]
> in place of some of the version numbers.
> e.g.
> {code}
> $ cordova requirements
> Android Studio project detected
> Requirements check results for android:
> Java JDK: installed 1.8.0
> Android SDK: installed true
> Android target: not installed
> avdmanager: Command failed with exit code 1
> Gradle: not installed
> Could not find an installed version of Gradle either in Android Studio,
> or on your system to install the gradle wrapper. Please include gradle
> in your path, or install Android Studio
> Requirements check results for ios:
> Apple macOS: installed darwin
> Xcode: installed [object Object]
> ios-deploy: installed [object Object]
> CocoaPods: installed [object Object]
> {code}
> Here, the versions of the ios requirements are not displayed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13947) Back button behavior doesn't revert to default when removing listeners
[ https://issues.apache.org/jira/browse/CB-13947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cedric Reichenbach updated CB-13947: Description: When adding a `backbutton` event listener to `document`, Cordova disables default back button behavior (which is usually closing the app). Later, when removing the last event listener, it should re-enable default behavior, but does not. h2. Technical details Internally, cordova seems to use a channel to handle document event listener registrations, which should update the override state on every listener addition/removal: [https://github.com/apache/cordova-android/blob/eddad666ff60129bf716cee61c24d3d65741640f/bin/templates/project/assets/www/cordova.js#L1664] However, debugging indicates that `onHasSubscribersChange` is only triggered once, when adding a listener for the first time, but never on removal. was: When adding a `backbutton` event listener to `document`, Cordova disables default back button behavior (which is usually closing the app). Later, when removing the last event listener, it should re-enable default behavior, but does not. ## Technical background Internally, cordova seems to use a channel to handle document event listener registrations, which should update the override state on every listener addition/removal: [https://github.com/apache/cordova-android/blob/eddad666ff60129bf716cee61c24d3d65741640f/bin/templates/project/assets/www/cordova.js#L1664] However, debugging indicates that `onHasSubscribersChange` is only triggered once, when adding a listener for the first time, but never on removal. > Back button behavior doesn't revert to default when removing listeners > -- > > Key: CB-13947 > URL: https://issues.apache.org/jira/browse/CB-13947 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android-7.0.0 >Reporter: Cedric Reichenbach >Assignee: Joe Bowser >Priority: Major > > When adding a `backbutton` event listener to `document`, Cordova disables > default back button behavior (which is usually closing the app). > Later, when removing the last event listener, it should re-enable default > behavior, but does not. > h2. Technical details > Internally, cordova seems to use a channel to handle document event listener > registrations, which should update the override state on every listener > addition/removal: > [https://github.com/apache/cordova-android/blob/eddad666ff60129bf716cee61c24d3d65741640f/bin/templates/project/assets/www/cordova.js#L1664] > However, debugging indicates that `onHasSubscribersChange` is only triggered > once, when adding a listener for the first time, but never on removal. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13947) Back button behavior doesn't revert to default when removing listeners
Cedric Reichenbach created CB-13947: --- Summary: Back button behavior doesn't revert to default when removing listeners Key: CB-13947 URL: https://issues.apache.org/jira/browse/CB-13947 Project: Apache Cordova Issue Type: Bug Components: cordova-android Affects Versions: cordova-android-7.0.0 Reporter: Cedric Reichenbach Assignee: Joe Bowser When adding a `backbutton` event listener to `document`, Cordova disables default back button behavior (which is usually closing the app). Later, when removing the last event listener, it should re-enable default behavior, but does not. ## Technical background Internally, cordova seems to use a channel to handle document event listener registrations, which should update the override state on every listener addition/removal: [https://github.com/apache/cordova-android/blob/eddad666ff60129bf716cee61c24d3d65741640f/bin/templates/project/assets/www/cordova.js#L1664] However, debugging indicates that `onHasSubscribersChange` is only triggered once, when adding a listener for the first time, but never on removal. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384748#comment-16384748 ] Gandhirajan commented on CB-13400: -- Correctness of "installing-a-development-environment.md" is taken care for mac as well. > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
