[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins

2018-06-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505747#comment-16505747
 ] 

ASF GitHub Bot commented on CB-12242:
-

qkdreyer commented on issue #292: CB-12242 : Use yarn instead of npm
URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-395661577
 
 
   Not sure what do you mean here guys...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use yarn js instead of npm when adding plugins
> --
>
> Key: CB-12242
> URL: https://issues.apache.org/jira/browse/CB-12242
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-cli, cordova-lib
>Reporter: Jacques de Villiers
>Priority: Major
>
> Currently it can take quite long to add certain plugins to my project (using 
> cordova plugin add), especially if I need to re-add the plugins. My 
> suggestion is to update the cordova cli to start using yarn js instead of npm 
> directly.
> When I looked at this page, I realised yarn was just a wrapper for npm, and 
> much better at caching packages locally.
> https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc
> I would imagine this change would be relatively straightforward, and would be 
> a massive win for the cli.
> I was thinking of creating a fork to do a PR but realised I am not totally 
> sure how to proceed on this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14120) Playback issues in iOS 11.3/11.4

2018-06-07 Thread Ken Naito (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505728#comment-16505728
 ] 

Ken Naito commented on CB-14120:


Hmm, perhaps this issue depends on mp3 file itself?

I tried to check following ionic codes, but I cannot reproduce this issue.

home.ts
{code}
import { Component } from '@angular/core';
import { NavController } from 'ionic-angular';
import { Media, MediaObject } from '@ionic-native/media';

@Component({
  selector: 'page-home',
  templateUrl: 'home.html'
})
export class HomePage {

  private _mFile: MediaObject;
  private musicIndex: number;

  private musics = ["A.mp3","B.mp3","C.mp3"];

  constructor(public navCtrl: NavController, private media: Media) {
  }

  playAudioStart() {
this.musicIndex = 0;
this.playAudio();
  }

  playAudio() {

this._mFile = this.media.create('assets/res/' + 
this.musics[this.musicIndex]);

this._mFile.stop();
this._mFile.play();

this._mFile.onSuccess.subscribe(result => {
  this._mFile.release();
  this.musicIndex += 1;
  if (this.musicIndex < this.musics.length) {
this.playAudio();
  } else {
alert("Finished");
  }
})
  }

}
{code}

home.html
{code}
  Primary 
Outline
{code}

My environments are
ionic-cli 3.20.0
 cli-utils 1.19.2

 cordova (cordova-cli) 7.1.0
 @ionic/app-scripts: 3.1.9
 cordova platform: ios 4.5.4
 Ionic Framework (ionic-angular): 3.9.2

I have built project by both Xcode 9.4 and Xcode 9.3.1.
I have confirmed this on iPhone 5S/iOS 11.3.1 and iPhone 8/iOS 11.3.0

Could you please try the above code?

> Playback issues in iOS 11.3/11.4 
> -
>
> Key: CB-14120
> URL: https://issues.apache.org/jira/browse/CB-14120
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-media
> Environment: Ionic 3, Angular JS 4
>Reporter: Muddasir Lakhani
>Priority: Blocker
>
> I am trying to play multiple audio tracks one after the other using the Media 
> Plugin.
> On pressing play, I download all the tracks as a zip file, and then play them 
> one after the other until the last track is played. This works fine on 
> Android (all models) and also on iOS up to 11.2. On iOS 11.3 onwards, the 
> next track never starts from the beginning, but from a random duration. So 
> basically if an Album has 4 tracks, first one will play from duration 00:00, 
> and then the next ones will start to play from random duration, and never 
> from 00:00.
> Code Snippet is below:
> {{if (ContainerClass.GetPlatformName() == "android") { this._mFile = 
> this.media.create(this._URL + "/" + AlbumNo + "/" + this._fileName[index]); } 
> else if (ContainerClass.GetPlatformName() == "ios") { this._mFile = 
> this.media.create((this._URL + "/" + AlbumNo + "/" + 
> this._fileName[index]).replace(/^file:\/\//, '')); } 
> this._mFile.onStatusUpdate.subscribe(status => console.log(status)); 
> this._mFile.stop(); this._mFile.play(); ServicesClass._mFile = this._mFile; 
> ServicesClass._isPlaying = 1; ServicesClass._playingAlbumNo = this.AlbumNo; 
> ServicesClass._isPlaying = 1 this._isPlaying = 1; 
> this._mFile.onSuccess.subscribe(result => { index++; this._playingIndex = 
> index; this._mFile.release(); if (ServicesClass._stopPlaying == false) { 
> this.PlayFiles(AlbumNo, index); this.showMp3Player(true); } else { return; } 
> }); this._mFile.onError.subscribe(error => console.log('Error!', 
> JSON.stringify(error))); } }}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13797) Fetch failing to install plugin dependencies

2018-06-07 Thread Ken Naito (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505604#comment-16505604
 ] 

Ken Naito commented on CB-13797:


I see. That PR looks nice.

> Fetch failing to install plugin dependencies
> 
>
> Key: CB-13797
> URL: https://issues.apache.org/jira/browse/CB-13797
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-fetch
> Environment: cordova@8.0.0
> cordova-common@2.2.1
> cordova-lib@8.0.0
> cordova-fetch@1.3.0
> npm@5.6.0
> node@9.4.0
>  
>Reporter: Darryl Pogue
>Assignee: Steve Gill
>Priority: Critical
>
> I'm currently unable to install Microsoft's cordova-plugin-code-push due to 
> some incredibly confusing errors when installing the plugin dependencies.
> The plugin [lists 3 
> dependencies|https://github.com/Microsoft/cordova-plugin-code-push/blob/e828a5eacd42dcd81bacf121a3e62735c3500227/plugin.xml#L10-L12]
>  in plugin.xml.
> Cordova successfully installs the first (code-push) dependency.
> Cordova attempts to install the second (cordova-plugin-device) dependency. It 
> appears that the npm install is successful.
> At the end of the npm install, cordova-fetch [attempts to 
> discover|https://github.com/apache/cordova-fetch/blob/master/index.js#L100] 
> what was just installed. Rather than finding "cordova-plugin-device", it 
> finds "code-push" for a second time.
> Then it fails with the following confusing error message:
> {noformat}
> Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have 
> ID "cordova-plugin-dialogs" but got "code-push".{noformat}
> The full verbose output from {{cordova prepare}} is below:
> {noformat}
> Discovered plugin "cordova-plugin-code-push" in config.xml. Adding it to the 
> project
> No scripts found for hook "before_plugin_add".
> Calling plugman.fetch on plugin "cordova-plugin-code-push@^1.11.2"
> Running command: npm install cordova-plugin-code-push@^1.11.2 --production 
> --no-save
> Command finished with error code 0: npm 
> install,cordova-plugin-code-push@^1.11.2,--production,--no-save
> Copying plugin "/PROJECT/node_modules/cordova-plugin-code-push" => 
> "/PROJECT/plugins/cordova-plugin-code-push"
> Calling plugman.install on plugin "/PROJECT/plugins/cordova-plugin-code-push" 
> for platform "android
> Installing "cordova-plugin-code-push" for android
> Running command: /PROJECT/platforms/android/cordova/version 
> Command finished with error code 0: 
> /PROJECT/platforms/android/cordova/version 
> Dependencies detected, iterating through them...
> Requesting plugin "code-push@2.0.4".
> Plugin dependency "code-push" not fetched, retrieving then installing.
> Running command: npm install code-push@2.0.4 --production --no-save
> Command finished with error code 0: npm 
> install,code-push@2.0.4,--production,--no-save
> Copying plugin "/PROJECT/node_modules/code-push" => 
> "/PROJECT/plugins/code-push"
> Installing "code-push" for android
> Finding scripts for "before_plugin_install" hook from plugin code-push on 
> android platform only.
> No scripts found for hook "before_plugin_install".
> Install start for "code-push" on android.
> Beginning processing of action stack for android project...
> Action stack processing complete.
> Install complete for code-push on android.
> Finding scripts for "after_plugin_install" hook from plugin code-push on 
> android platform only.
> No scripts found for hook "after_plugin_install".
> Requesting plugin "cordova-plugin-dialogs@>=1.1.1".
> Plugin dependency "cordova-plugin-dialogs" not fetched, retrieving then 
> installing.
> Running command: npm install cordova-plugin-dialogs@>=1.1.1 --production 
> --no-save
> Command finished with error code 0: npm 
> install,cordova-plugin-dialogs@>=1.1.1,--production,--no-save
> Copying plugin "/PROJECT/node_modules/code-push" => 
> "/PROJECT/plugins/code-push"
> Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have 
> ID "cordova-plugin-dialogs" but got "code-push".
> at checkID (/PROJECT/node_modules/cordova-lib/src/plugman/fetch.js:215:15)
> at /PROJECT/node_modules/cordova-lib/src/plugman/fetch.js:199:9
> at _fulfilled (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at /PROJECT/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> Failed to restore plugin "cordova-plugin-code-push" from config.xml. You 
> might need to try adding it again. Error: Error: Expected plugin to have ID 
> "cordova-plugin-d

[jira] [Commented] (CB-12551) File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2

2018-06-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505569#comment-16505569
 ] 

ASF GitHub Bot commented on CB-12551:
-

macdonst commented on a change in pull request #197: CB-12551: (android) Patch 
Security Provider to support TLS 1.2
URL: 
https://github.com/apache/cordova-plugin-file-transfer/pull/197#discussion_r193927829
 
 

 ##
 File path: plugin.xml
 ##
 @@ -54,6 +54,8 @@
 
 
 
+
+
 
 Review comment:
   @davidofwatkins can you make this line:
   
   ```


   ```
   
   and also add in an engine tag:
   
   ```
   
   
   
   
   ```
   
   This gets around the Play Services issue: 
https://blog.phonegap.com/the-play-services-problem-with-cordova-applications-489c9aeb2e89


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2
> -
>
> Key: CB-12551
> URL: https://issues.apache.org/jira/browse/CB-12551
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-file-transfer (DEPRECATED)
>Reporter: Dani Palou
>Priority: Major
>
> FileTransfer's download function fails when trying to download a file from a 
> site using TLS 1.2. This works fine in Android 5 or higher, but it fails in 
> Android 4.x.
> I searched a bit and I found that Android 4.4 should support TLS1.2 but it is 
> disabled by default. I applied the solution proposed in this post and it 
> worked for me:
> http://stackoverflow.com/a/33567745
> That is, I created the _MySSLSocketFactory_ class in the FileTransfer 
> project, and I used it in the _trustAllHosts_ function (line 636 of 
> _FileTransfer.java_):
> {noformat}
> SSLSocketFactory newFactory = new MySSLSocketFactory(sc.getSocketFactory());
> {noformat}
> I'm not sure if this can cause problems with other certificates, I don't know 
> much about this. It would be nice if the Cordova team could take a look at 
> this and check if it can be solved.
> This is the stacktrace:
> {noformat}
> Error getting HTTP status code from connection.
> javax.net.ssl.SSLException: Connection closed by peer
>  at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
>  at 
> com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:405)
>  at com.android.okhttp.Connection.upgradeToTls(Connection.java:146)
>  at com.android.okhttp.Connection.connect(Connection.java:107)
>  at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:294)
>  at 
> com.android.okhttp.internal.http.HttpEngine.sendSocketRequest(HttpEngine.java:255)
>  at 
> com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:206)
>  at 
> com.android.okhttp.internal.http.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:345)
>  at 
> com.android.okhttp.internal.http.HttpURLConnectionImpl.connect(HttpURLConnectionImpl.java:89)
>  at 
> com.android.okhttp.internal.http.HttpsURLConnectionImpl.connect(HttpsURLConnectionImpl.java:161)
>  at org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:869)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
>  at java.lang.Thread.run(Thread.java:841)
> {noformat}
> It can be tested with this code:
> {noformat}
> var ft = new FileTransfer(),
> path = 'squirrel.jpg',
> uri = 
> 'https://prototype.moodle.net/mobile/moodle32/webservice/pluginfile.php/314/mod_resource/content/3/squirrel.jpg?forcedownload=1&token=616455be9f363cc9631cab89cfcfa1cd';
> ft.download(uri, path, success, error, true);
> function success() {
> console.log('Success');
> }
> function error(data) {
> console.log('Error', data);
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12551) File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2

2018-06-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505571#comment-16505571
 ] 

ASF GitHub Bot commented on CB-12551:
-

macdonst commented on issue #197: CB-12551: (android) Patch Security Provider 
to support TLS 1.2
URL: 
https://github.com/apache/cordova-plugin-file-transfer/pull/197#issuecomment-395611577
 
 
   @davidofwatkins sorry, one more comment I forgot earlier.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2
> -
>
> Key: CB-12551
> URL: https://issues.apache.org/jira/browse/CB-12551
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-file-transfer (DEPRECATED)
>Reporter: Dani Palou
>Priority: Major
>
> FileTransfer's download function fails when trying to download a file from a 
> site using TLS 1.2. This works fine in Android 5 or higher, but it fails in 
> Android 4.x.
> I searched a bit and I found that Android 4.4 should support TLS1.2 but it is 
> disabled by default. I applied the solution proposed in this post and it 
> worked for me:
> http://stackoverflow.com/a/33567745
> That is, I created the _MySSLSocketFactory_ class in the FileTransfer 
> project, and I used it in the _trustAllHosts_ function (line 636 of 
> _FileTransfer.java_):
> {noformat}
> SSLSocketFactory newFactory = new MySSLSocketFactory(sc.getSocketFactory());
> {noformat}
> I'm not sure if this can cause problems with other certificates, I don't know 
> much about this. It would be nice if the Cordova team could take a look at 
> this and check if it can be solved.
> This is the stacktrace:
> {noformat}
> Error getting HTTP status code from connection.
> javax.net.ssl.SSLException: Connection closed by peer
>  at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
>  at 
> com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:405)
>  at com.android.okhttp.Connection.upgradeToTls(Connection.java:146)
>  at com.android.okhttp.Connection.connect(Connection.java:107)
>  at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:294)
>  at 
> com.android.okhttp.internal.http.HttpEngine.sendSocketRequest(HttpEngine.java:255)
>  at 
> com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:206)
>  at 
> com.android.okhttp.internal.http.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:345)
>  at 
> com.android.okhttp.internal.http.HttpURLConnectionImpl.connect(HttpURLConnectionImpl.java:89)
>  at 
> com.android.okhttp.internal.http.HttpsURLConnectionImpl.connect(HttpsURLConnectionImpl.java:161)
>  at org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:869)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
>  at java.lang.Thread.run(Thread.java:841)
> {noformat}
> It can be tested with this code:
> {noformat}
> var ft = new FileTransfer(),
> path = 'squirrel.jpg',
> uri = 
> 'https://prototype.moodle.net/mobile/moodle32/webservice/pluginfile.php/314/mod_resource/content/3/squirrel.jpg?forcedownload=1&token=616455be9f363cc9631cab89cfcfa1cd';
> ft.download(uri, path, success, error, true);
> function success() {
> console.log('Success');
> }
> function error(data) {
> console.log('Error', data);
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12551) File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2

2018-06-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505275#comment-16505275
 ] 

ASF GitHub Bot commented on CB-12551:
-

davidofwatkins commented on a change in pull request #197: CB-12551: (android) 
Patch Security Provider to support TLS 1.2
URL: 
https://github.com/apache/cordova-plugin-file-transfer/pull/197#discussion_r193888502
 
 

 ##
 File path: src/android/FileTransfer.java
 ##
 @@ -53,8 +53,13 @@ Licensed to the Apache Software Foundation (ASF) under one
 
 import android.net.Uri;
 import android.os.Build;
+import android.util.Log;
 import android.webkit.CookieManager;
 
+import com.google.android.gms.common.GooglePlayServicesNotAvailableException;
 
 Review comment:
   Good catch! Yep, I forgot to include that here. Added!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2
> -
>
> Key: CB-12551
> URL: https://issues.apache.org/jira/browse/CB-12551
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-file-transfer (DEPRECATED)
>Reporter: Dani Palou
>Priority: Major
>
> FileTransfer's download function fails when trying to download a file from a 
> site using TLS 1.2. This works fine in Android 5 or higher, but it fails in 
> Android 4.x.
> I searched a bit and I found that Android 4.4 should support TLS1.2 but it is 
> disabled by default. I applied the solution proposed in this post and it 
> worked for me:
> http://stackoverflow.com/a/33567745
> That is, I created the _MySSLSocketFactory_ class in the FileTransfer 
> project, and I used it in the _trustAllHosts_ function (line 636 of 
> _FileTransfer.java_):
> {noformat}
> SSLSocketFactory newFactory = new MySSLSocketFactory(sc.getSocketFactory());
> {noformat}
> I'm not sure if this can cause problems with other certificates, I don't know 
> much about this. It would be nice if the Cordova team could take a look at 
> this and check if it can be solved.
> This is the stacktrace:
> {noformat}
> Error getting HTTP status code from connection.
> javax.net.ssl.SSLException: Connection closed by peer
>  at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
>  at 
> com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:405)
>  at com.android.okhttp.Connection.upgradeToTls(Connection.java:146)
>  at com.android.okhttp.Connection.connect(Connection.java:107)
>  at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:294)
>  at 
> com.android.okhttp.internal.http.HttpEngine.sendSocketRequest(HttpEngine.java:255)
>  at 
> com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:206)
>  at 
> com.android.okhttp.internal.http.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:345)
>  at 
> com.android.okhttp.internal.http.HttpURLConnectionImpl.connect(HttpURLConnectionImpl.java:89)
>  at 
> com.android.okhttp.internal.http.HttpsURLConnectionImpl.connect(HttpsURLConnectionImpl.java:161)
>  at org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:869)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
>  at java.lang.Thread.run(Thread.java:841)
> {noformat}
> It can be tested with this code:
> {noformat}
> var ft = new FileTransfer(),
> path = 'squirrel.jpg',
> uri = 
> 'https://prototype.moodle.net/mobile/moodle32/webservice/pluginfile.php/314/mod_resource/content/3/squirrel.jpg?forcedownload=1&token=616455be9f363cc9631cab89cfcfa1cd';
> ft.download(uri, path, success, error, true);
> function success() {
> console.log('Success');
> }
> function error(data) {
> console.log('Error', data);
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12551) File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2

2018-06-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505276#comment-16505276
 ] 

ASF GitHub Bot commented on CB-12551:
-

davidofwatkins commented on issue #197: CB-12551: (android) Patch Security 
Provider to support TLS 1.2
URL: 
https://github.com/apache/cordova-plugin-file-transfer/pull/197#issuecomment-395564285
 
 
   @almas Thanks for the review! Feedback is addressed. Please let me know if 
you spot anything else :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2
> -
>
> Key: CB-12551
> URL: https://issues.apache.org/jira/browse/CB-12551
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-file-transfer (DEPRECATED)
>Reporter: Dani Palou
>Priority: Major
>
> FileTransfer's download function fails when trying to download a file from a 
> site using TLS 1.2. This works fine in Android 5 or higher, but it fails in 
> Android 4.x.
> I searched a bit and I found that Android 4.4 should support TLS1.2 but it is 
> disabled by default. I applied the solution proposed in this post and it 
> worked for me:
> http://stackoverflow.com/a/33567745
> That is, I created the _MySSLSocketFactory_ class in the FileTransfer 
> project, and I used it in the _trustAllHosts_ function (line 636 of 
> _FileTransfer.java_):
> {noformat}
> SSLSocketFactory newFactory = new MySSLSocketFactory(sc.getSocketFactory());
> {noformat}
> I'm not sure if this can cause problems with other certificates, I don't know 
> much about this. It would be nice if the Cordova team could take a look at 
> this and check if it can be solved.
> This is the stacktrace:
> {noformat}
> Error getting HTTP status code from connection.
> javax.net.ssl.SSLException: Connection closed by peer
>  at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
>  at 
> com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:405)
>  at com.android.okhttp.Connection.upgradeToTls(Connection.java:146)
>  at com.android.okhttp.Connection.connect(Connection.java:107)
>  at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:294)
>  at 
> com.android.okhttp.internal.http.HttpEngine.sendSocketRequest(HttpEngine.java:255)
>  at 
> com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:206)
>  at 
> com.android.okhttp.internal.http.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:345)
>  at 
> com.android.okhttp.internal.http.HttpURLConnectionImpl.connect(HttpURLConnectionImpl.java:89)
>  at 
> com.android.okhttp.internal.http.HttpsURLConnectionImpl.connect(HttpsURLConnectionImpl.java:161)
>  at org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:869)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
>  at java.lang.Thread.run(Thread.java:841)
> {noformat}
> It can be tested with this code:
> {noformat}
> var ft = new FileTransfer(),
> path = 'squirrel.jpg',
> uri = 
> 'https://prototype.moodle.net/mobile/moodle32/webservice/pluginfile.php/314/mod_resource/content/3/squirrel.jpg?forcedownload=1&token=616455be9f363cc9631cab89cfcfa1cd';
> ft.download(uri, path, success, error, true);
> function success() {
> console.log('Success');
> }
> function error(data) {
> console.log('Error', data);
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14120) Playback issues in iOS 11.3/11.4

2018-06-07 Thread Bilal Adhi (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504864#comment-16504864
 ] 

Bilal Adhi commented on CB-14120:
-

I am facing the same problem.

1st thing i can not get the duration of media file, then i try to use recursive 
function on (onSuccess) event of mp3 with new file name or index everything is 
fine with Android (any version) and iOS (except 11.3 and 11.4).

*Here are details of my ionic versions*

li packages: (/usr/local/lib/node_modules)

@ionic/cli-utils  : 1.19.2
ionic (Ionic CLI) : 3.20.0

global packages:

cordova (Cordova CLI) : 7.1.0

local packages:

@ionic/app-scripts : 2.1.3
Cordova Platforms  : android 6.3.0 ios 4.5.4
Ionic Framework: ionic-angular 3.6.0

System:

ios-deploy : 1.9.2
ios-sim: 5.0.13
Node   : v6.11.0
npm: 3.10.10
OS : macOS High Sierra
Xcode  : Xcode 9.3.1 Build version 9E501

Environment Variables:

ANDROID_HOME : not set

Misc:

backend : pro

> Playback issues in iOS 11.3/11.4 
> -
>
> Key: CB-14120
> URL: https://issues.apache.org/jira/browse/CB-14120
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-media
> Environment: Ionic 3, Angular JS 4
>Reporter: Muddasir Lakhani
>Priority: Blocker
>
> I am trying to play multiple audio tracks one after the other using the Media 
> Plugin.
> On pressing play, I download all the tracks as a zip file, and then play them 
> one after the other until the last track is played. This works fine on 
> Android (all models) and also on iOS up to 11.2. On iOS 11.3 onwards, the 
> next track never starts from the beginning, but from a random duration. So 
> basically if an Album has 4 tracks, first one will play from duration 00:00, 
> and then the next ones will start to play from random duration, and never 
> from 00:00.
> Code Snippet is below:
> {{if (ContainerClass.GetPlatformName() == "android") { this._mFile = 
> this.media.create(this._URL + "/" + AlbumNo + "/" + this._fileName[index]); } 
> else if (ContainerClass.GetPlatformName() == "ios") { this._mFile = 
> this.media.create((this._URL + "/" + AlbumNo + "/" + 
> this._fileName[index]).replace(/^file:\/\//, '')); } 
> this._mFile.onStatusUpdate.subscribe(status => console.log(status)); 
> this._mFile.stop(); this._mFile.play(); ServicesClass._mFile = this._mFile; 
> ServicesClass._isPlaying = 1; ServicesClass._playingAlbumNo = this.AlbumNo; 
> ServicesClass._isPlaying = 1 this._isPlaying = 1; 
> this._mFile.onSuccess.subscribe(result => { index++; this._playingIndex = 
> index; this._mFile.release(); if (ServicesClass._stopPlaying == false) { 
> this.PlayFiles(AlbumNo, index); this.showMp3Player(true); } else { return; } 
> }); this._mFile.onError.subscribe(error => console.log('Error!', 
> JSON.stringify(error))); } }}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14119) Cant Disable Debugger Chrome

2018-06-07 Thread edoofx (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504803#comment-16504803
 ] 

edoofx commented on CB-14119:
-

[~jcesarmobile] no, 3 device no root no custom firmware , when im Enable usb 
debugging , and i can see my device on chrome://inspect..

> Cant Disable Debugger Chrome
> 
>
> Key: CB-14119
> URL: https://issues.apache.org/jira/browse/CB-14119
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: AllPlatforms, cordova-cli
>Affects Versions: cordova-android-7.0.0
>Reporter: edoofx
>Priority: Major
>  Labels: security
>
> how i can disable debug when using release APK from cordova ? im using 
> *cordova build android --release – --keystore="PATH KEYSTORE" 
> --storePassword=PASS --alias=ALIAS --password=PASS*
>  when ** apk created succesfully , then im trying to real phone, enable usb 
> debug , plug into PC , then boom! i can see debug on chrome , even with param 
> --release
>  
> *using cordova 8 and android 7.0.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13797) Fetch failing to install plugin dependencies

2018-06-07 Thread Darryl Pogue (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504735#comment-16504735
 ] 

Darryl Pogue commented on CB-13797:
---

I'm hoping [~raphinesse]'s pull request for 
[https://github.com/apache/cordova-fetch/pull/18] will fix this, since it 
replaces the treeDep and diffJson stuff in favour of parsing the output on 
{{npm install}}

> Fetch failing to install plugin dependencies
> 
>
> Key: CB-13797
> URL: https://issues.apache.org/jira/browse/CB-13797
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-fetch
> Environment: cordova@8.0.0
> cordova-common@2.2.1
> cordova-lib@8.0.0
> cordova-fetch@1.3.0
> npm@5.6.0
> node@9.4.0
>  
>Reporter: Darryl Pogue
>Assignee: Steve Gill
>Priority: Critical
>
> I'm currently unable to install Microsoft's cordova-plugin-code-push due to 
> some incredibly confusing errors when installing the plugin dependencies.
> The plugin [lists 3 
> dependencies|https://github.com/Microsoft/cordova-plugin-code-push/blob/e828a5eacd42dcd81bacf121a3e62735c3500227/plugin.xml#L10-L12]
>  in plugin.xml.
> Cordova successfully installs the first (code-push) dependency.
> Cordova attempts to install the second (cordova-plugin-device) dependency. It 
> appears that the npm install is successful.
> At the end of the npm install, cordova-fetch [attempts to 
> discover|https://github.com/apache/cordova-fetch/blob/master/index.js#L100] 
> what was just installed. Rather than finding "cordova-plugin-device", it 
> finds "code-push" for a second time.
> Then it fails with the following confusing error message:
> {noformat}
> Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have 
> ID "cordova-plugin-dialogs" but got "code-push".{noformat}
> The full verbose output from {{cordova prepare}} is below:
> {noformat}
> Discovered plugin "cordova-plugin-code-push" in config.xml. Adding it to the 
> project
> No scripts found for hook "before_plugin_add".
> Calling plugman.fetch on plugin "cordova-plugin-code-push@^1.11.2"
> Running command: npm install cordova-plugin-code-push@^1.11.2 --production 
> --no-save
> Command finished with error code 0: npm 
> install,cordova-plugin-code-push@^1.11.2,--production,--no-save
> Copying plugin "/PROJECT/node_modules/cordova-plugin-code-push" => 
> "/PROJECT/plugins/cordova-plugin-code-push"
> Calling plugman.install on plugin "/PROJECT/plugins/cordova-plugin-code-push" 
> for platform "android
> Installing "cordova-plugin-code-push" for android
> Running command: /PROJECT/platforms/android/cordova/version 
> Command finished with error code 0: 
> /PROJECT/platforms/android/cordova/version 
> Dependencies detected, iterating through them...
> Requesting plugin "code-push@2.0.4".
> Plugin dependency "code-push" not fetched, retrieving then installing.
> Running command: npm install code-push@2.0.4 --production --no-save
> Command finished with error code 0: npm 
> install,code-push@2.0.4,--production,--no-save
> Copying plugin "/PROJECT/node_modules/code-push" => 
> "/PROJECT/plugins/code-push"
> Installing "code-push" for android
> Finding scripts for "before_plugin_install" hook from plugin code-push on 
> android platform only.
> No scripts found for hook "before_plugin_install".
> Install start for "code-push" on android.
> Beginning processing of action stack for android project...
> Action stack processing complete.
> Install complete for code-push on android.
> Finding scripts for "after_plugin_install" hook from plugin code-push on 
> android platform only.
> No scripts found for hook "after_plugin_install".
> Requesting plugin "cordova-plugin-dialogs@>=1.1.1".
> Plugin dependency "cordova-plugin-dialogs" not fetched, retrieving then 
> installing.
> Running command: npm install cordova-plugin-dialogs@>=1.1.1 --production 
> --no-save
> Command finished with error code 0: npm 
> install,cordova-plugin-dialogs@>=1.1.1,--production,--no-save
> Copying plugin "/PROJECT/node_modules/code-push" => 
> "/PROJECT/plugins/code-push"
> Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have 
> ID "cordova-plugin-dialogs" but got "code-push".
> at checkID (/PROJECT/node_modules/cordova-lib/src/plugman/fetch.js:215:15)
> at /PROJECT/node_modules/cordova-lib/src/plugman/fetch.js:199:9
> at _fulfilled (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at /PROJECT/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next

[jira] [Resolved] (CB-14066) Remove Node 4 from CI - cordova-fetch

2018-06-07 Thread Darryl Pogue (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darryl Pogue resolved CB-14066.
---
Resolution: Fixed
  Assignee: Raphael  (was: Darryl Pogue)

> Remove Node 4 from CI - cordova-fetch
> -
>
> Key: CB-14066
> URL: https://issues.apache.org/jira/browse/CB-14066
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-fetch
>Reporter: Darryl Pogue
>Assignee: Raphael
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14066) Remove Node 4 from CI - cordova-fetch

2018-06-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504728#comment-16504728
 ] 

ASF GitHub Bot commented on CB-14066:
-

dpogue closed pull request #21: CB-14066: Drop support for Node 4
URL: https://github.com/apache/cordova-fetch/pull/21
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.travis.yml b/.travis.yml
index 53f19a8..f50997f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -3,9 +3,9 @@ sudo: false
 git:
   depth: 10
 node_js:
-  - "4"
   - "6"
   - "8"
+  - "10"
 install:
   - "npm install"
 script:
diff --git a/appveyor.yml b/appveyor.yml
index ffe5194..eb430ca 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -3,10 +3,10 @@
 
 environment:
   matrix:
-  - nodejs_version: "4"
   - nodejs_version: "6"
   - nodejs_version: "8"
-  
+  - nodejs_version: "10"
+
 install:
   - ps: Install-Product node $env:nodejs_version
   - npm install
@@ -16,4 +16,7 @@ build: off
 test_script:
   - node --version
   - npm --version
+  # Solution proposed in 
https://stackoverflow.com/questions/49256190/how-to-fix-git-sh-setup-file-not-found-in-windows#comment88245403_49256190
+  # to work around https://github.com/appveyor/ci/issues/2420
+  - set "PATH=%PATH%;C:\Program Files\Git\mingw64\libexec\git-core"
   - npm test
diff --git a/package.json b/package.json
index 305030c..04ede01 100644
--- a/package.json
+++ b/package.json
@@ -45,7 +45,7 @@
 "jasmine": "jasmine spec/fetch.spec.js spec/fetch-unit.spec.js"
   },
   "engines": {
-"node": ">=4.0.0",
-"npm": ">= 2.5.1"
+"node": ">= 6",
+"npm": ">= 3"
   }
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove Node 4 from CI - cordova-fetch
> -
>
> Key: CB-14066
> URL: https://issues.apache.org/jira/browse/CB-14066
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-fetch
>Reporter: Darryl Pogue
>Assignee: Darryl Pogue
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-13797) Fetch failing to install plugin dependencies

2018-06-07 Thread Ken Naito (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504597#comment-16504597
 ] 

Ken Naito edited comment on CB-13797 at 6/7/18 12:31 PM:
-

I confirmed this issue.
One solution for https://github.com/dpogue/cb-13797 is removing  
"code-push": "^2.0.4" in dependencies in package.json.

When we do 'npm install', the npm installs code-push@2.0.5 in node_modules.
Then we do 'cordova prepare', the cordova installs cordova-plugin-code-push.
Because the cordova-plugin-code-push depends on code-push@2.0.4, the cordova 
will install code-push@2.0.4.
At this time, depTree in cordova-fetch is as follows (npm ls --depth=0)

{code}
├─┬ UNMET DEPENDENCY code-push@2.0.5
│ ├── q@1.5.1
│ ├── recursive-fs@0.1.4
│ ├── slash@1.0.0
│ ├── superagent@3.8.3
│ ├── superagent-proxy@1.0.3
│ └── yazl@2.4.3
├── cordova@8.0.0
├── cordova-android@7.1.0
├── cordova-ios@4.5.4
├── cordova-plugin-code-push@1.11.11
├── cordova-plugin-device@2.0.2
└── cordova-plugin-whitelist@1.3.3
{code}

Next the cordova will install cordova-plugin-dialogs, then treeDep becomes
{code}
├── code-push@2.0.5
├── cordova@8.0.0
├── cordova-android@7.1.0
├── cordova-ios@4.5.4
├── cordova-plugin-code-push@1.11.11
├── cordova-plugin-device@2.0.2
└── cordova-plugin-whitelist@1.3.3
{code}

Comparing both two depTrees, getJsonDiff(tree1, tree2) in cordova-fetch returns 
'code-push'.
This is because 'cordova install cordova-plugin-dialogs' fails with the error 
{code}
Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have ID 
"cordova-plugin-dialogs" but got "code-push".
{code}

In order to resolve this issue, cordova-fetch must find the correct id of 
installed package.




was (Author: knaito):
I confirmed this issue.
One solution for https://github.com/dpogue/cb-13797 is removing  
"code-push": "^2.0.4" in dependencies in package.json.

When we do 'npm install', the npm installs code-push@2.0.5 in node_modules.
Then we do 'cordova prepare', the cordova installs cordova-plugin-code-push.
Because the cordova-plugin-code-push depends code-push@2.0.4, the cordova will 
install code-push@2.0.4.
At this time, depTree in cordova-fetch is as follows (npm ls --depth=0)

{code}
├─┬ UNMET DEPENDENCY code-push@2.0.5
│ ├── q@1.5.1
│ ├── recursive-fs@0.1.4
│ ├── slash@1.0.0
│ ├── superagent@3.8.3
│ ├── superagent-proxy@1.0.3
│ └── yazl@2.4.3
├── cordova@8.0.0
├── cordova-android@7.1.0
├── cordova-ios@4.5.4
├── cordova-plugin-code-push@1.11.11
├── cordova-plugin-device@2.0.2
└── cordova-plugin-whitelist@1.3.3
{code}

Next the cordova will install cordova-plugin-dialogs, then treeDep becomes
{code}
├── code-push@2.0.5
├── cordova@8.0.0
├── cordova-android@7.1.0
├── cordova-ios@4.5.4
├── cordova-plugin-code-push@1.11.11
├── cordova-plugin-device@2.0.2
└── cordova-plugin-whitelist@1.3.3
{code}

Comparing both two depTrees, getJsonDiff(tree1, tree2) in cordova-fetch returns 
'code-push'.
This is because 'cordova install cordova-plugin-dialogs' fails with the error 
{code}
Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have ID 
"cordova-plugin-dialogs" but got "code-push".
{code}

In order to resolve this issue, cordova-fetch must find the correct id of 
installed package.



> Fetch failing to install plugin dependencies
> 
>
> Key: CB-13797
> URL: https://issues.apache.org/jira/browse/CB-13797
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-fetch
> Environment: cordova@8.0.0
> cordova-common@2.2.1
> cordova-lib@8.0.0
> cordova-fetch@1.3.0
> npm@5.6.0
> node@9.4.0
>  
>Reporter: Darryl Pogue
>Assignee: Steve Gill
>Priority: Critical
>
> I'm currently unable to install Microsoft's cordova-plugin-code-push due to 
> some incredibly confusing errors when installing the plugin dependencies.
> The plugin [lists 3 
> dependencies|https://github.com/Microsoft/cordova-plugin-code-push/blob/e828a5eacd42dcd81bacf121a3e62735c3500227/plugin.xml#L10-L12]
>  in plugin.xml.
> Cordova successfully installs the first (code-push) dependency.
> Cordova attempts to install the second (cordova-plugin-device) dependency. It 
> appears that the npm install is successful.
> At the end of the npm install, cordova-fetch [attempts to 
> discover|https://github.com/apache/cordova-fetch/blob/master/index.js#L100] 
> what was just installed. Rather than finding "cordova-plugin-device", it 
> finds "code-push" for a second time.
> Then it fails with the following confusing error message:
> {noformat}
> Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have 
> ID "cordova-plugin-dialogs" but got "code-push".{noformat}
> The full verbose output from {{cordova prepare}} is below:
> {noformat}
> Discovered plugin "cordova-plugin-cod

[jira] [Comment Edited] (CB-13797) Fetch failing to install plugin dependencies

2018-06-07 Thread Ken Naito (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504603#comment-16504603
 ] 

Ken Naito edited comment on CB-13797 at 6/7/18 12:31 PM:
-

We can see this situation  (UNMET DEPENDENCY) as follows,

{code}
$ git checkout https://github.com/dpogue/cb-13797.git
$ cd cb-13797
$ npm install
$ npm install code-push@2.0.4 --production --no-save
$ npm ls --depth=0 
├─┬ UNMET DEPENDENCY code-push@2.0.5
│ ├── q@1.5.1
│ ├── recursive-fs@0.1.4
│ ├── slash@1.0.0
│ ├── superagent@3.8.3
│ ├── superagent-proxy@1.0.3
│ └── yazl@2.4.3
├── cordova@8.0.0
├── cordova-android@7.1.0
├── cordova-ios@4.5.4
├── cordova-plugin-code-push@1.11.11
├── cordova-plugin-device@2.0.2
└── cordova-plugin-whitelist@1.3.3
$ npm install cordova-plugin-dialogs@1.1.1 --production --no-save
$ npm ls --depth=0
├── code-push@2.0.5
├── cordova@8.0.0
├── cordova-android@7.1.0
├── cordova-ios@4.5.4
├── cordova-plugin-code-push@1.11.11
├── cordova-plugin-device@2.0.2
└── cordova-plugin-whitelist@1.3.3

{code}



was (Author: knaito):
We can see this situation  (UNMET DEPENDENCY) as follows,

{code}
$ git checkout https://github.com/dpogue/cb-13797.git
$ npm install
$ npm install code-push@2.0.4 --production --no-save
$ npm ls --depth=0 
├─┬ UNMET DEPENDENCY code-push@2.0.5
│ ├── q@1.5.1
│ ├── recursive-fs@0.1.4
│ ├── slash@1.0.0
│ ├── superagent@3.8.3
│ ├── superagent-proxy@1.0.3
│ └── yazl@2.4.3
├── cordova@8.0.0
├── cordova-android@7.1.0
├── cordova-ios@4.5.4
├── cordova-plugin-code-push@1.11.11
├── cordova-plugin-device@2.0.2
└── cordova-plugin-whitelist@1.3.3
$ npm install cordova-plugin-dialogs@1.1.1 --production --no-save
$ npm ls --depth=0
├── code-push@2.0.5
├── cordova@8.0.0
├── cordova-android@7.1.0
├── cordova-ios@4.5.4
├── cordova-plugin-code-push@1.11.11
├── cordova-plugin-device@2.0.2
└── cordova-plugin-whitelist@1.3.3

{code}


> Fetch failing to install plugin dependencies
> 
>
> Key: CB-13797
> URL: https://issues.apache.org/jira/browse/CB-13797
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-fetch
> Environment: cordova@8.0.0
> cordova-common@2.2.1
> cordova-lib@8.0.0
> cordova-fetch@1.3.0
> npm@5.6.0
> node@9.4.0
>  
>Reporter: Darryl Pogue
>Assignee: Steve Gill
>Priority: Critical
>
> I'm currently unable to install Microsoft's cordova-plugin-code-push due to 
> some incredibly confusing errors when installing the plugin dependencies.
> The plugin [lists 3 
> dependencies|https://github.com/Microsoft/cordova-plugin-code-push/blob/e828a5eacd42dcd81bacf121a3e62735c3500227/plugin.xml#L10-L12]
>  in plugin.xml.
> Cordova successfully installs the first (code-push) dependency.
> Cordova attempts to install the second (cordova-plugin-device) dependency. It 
> appears that the npm install is successful.
> At the end of the npm install, cordova-fetch [attempts to 
> discover|https://github.com/apache/cordova-fetch/blob/master/index.js#L100] 
> what was just installed. Rather than finding "cordova-plugin-device", it 
> finds "code-push" for a second time.
> Then it fails with the following confusing error message:
> {noformat}
> Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have 
> ID "cordova-plugin-dialogs" but got "code-push".{noformat}
> The full verbose output from {{cordova prepare}} is below:
> {noformat}
> Discovered plugin "cordova-plugin-code-push" in config.xml. Adding it to the 
> project
> No scripts found for hook "before_plugin_add".
> Calling plugman.fetch on plugin "cordova-plugin-code-push@^1.11.2"
> Running command: npm install cordova-plugin-code-push@^1.11.2 --production 
> --no-save
> Command finished with error code 0: npm 
> install,cordova-plugin-code-push@^1.11.2,--production,--no-save
> Copying plugin "/PROJECT/node_modules/cordova-plugin-code-push" => 
> "/PROJECT/plugins/cordova-plugin-code-push"
> Calling plugman.install on plugin "/PROJECT/plugins/cordova-plugin-code-push" 
> for platform "android
> Installing "cordova-plugin-code-push" for android
> Running command: /PROJECT/platforms/android/cordova/version 
> Command finished with error code 0: 
> /PROJECT/platforms/android/cordova/version 
> Dependencies detected, iterating through them...
> Requesting plugin "code-push@2.0.4".
> Plugin dependency "code-push" not fetched, retrieving then installing.
> Running command: npm install code-push@2.0.4 --production --no-save
> Command finished with error code 0: npm 
> install,code-push@2.0.4,--production,--no-save
> Copying plugin "/PROJECT/node_modules/code-push" => 
> "/PROJECT/plugins/code-push"
> Installing "code-push" for android
> Finding scripts for "before_plugin_install" hook from plugin code-push on 
> android platform only.
> No scripts found for hook "before_plugin

[jira] [Comment Edited] (CB-13797) Fetch failing to install plugin dependencies

2018-06-07 Thread Ken Naito (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504603#comment-16504603
 ] 

Ken Naito edited comment on CB-13797 at 6/7/18 12:30 PM:
-

We can see this situation  (UNMET DEPENDENCY) as follows,

{code}
$ git checkout https://github.com/dpogue/cb-13797.git
$ npm install
$ npm install code-push@2.0.4 --production --no-save
$ npm ls --depth=0 
├─┬ UNMET DEPENDENCY code-push@2.0.5
│ ├── q@1.5.1
│ ├── recursive-fs@0.1.4
│ ├── slash@1.0.0
│ ├── superagent@3.8.3
│ ├── superagent-proxy@1.0.3
│ └── yazl@2.4.3
├── cordova@8.0.0
├── cordova-android@7.1.0
├── cordova-ios@4.5.4
├── cordova-plugin-code-push@1.11.11
├── cordova-plugin-device@2.0.2
└── cordova-plugin-whitelist@1.3.3
$ npm install cordova-plugin-dialogs@1.1.1 --production --no-save
$ npm ls --depth=0
├── code-push@2.0.5
├── cordova@8.0.0
├── cordova-android@7.1.0
├── cordova-ios@4.5.4
├── cordova-plugin-code-push@1.11.11
├── cordova-plugin-device@2.0.2
└── cordova-plugin-whitelist@1.3.3

{code}



was (Author: knaito):
We can see this situation  (UNMET DEPENDENCY) as follows,

{code}
$ git checkout https://github.com/dpogue/cb-13797.git
$ npm install
$ npm install code-push@2.0.4 --production --no-save
$ npm ls --depth=0 
$ npm install cordova-plugin-dialogs@1.1.1 --production --no-save
$ npm ls --depth=0
{code}


> Fetch failing to install plugin dependencies
> 
>
> Key: CB-13797
> URL: https://issues.apache.org/jira/browse/CB-13797
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-fetch
> Environment: cordova@8.0.0
> cordova-common@2.2.1
> cordova-lib@8.0.0
> cordova-fetch@1.3.0
> npm@5.6.0
> node@9.4.0
>  
>Reporter: Darryl Pogue
>Assignee: Steve Gill
>Priority: Critical
>
> I'm currently unable to install Microsoft's cordova-plugin-code-push due to 
> some incredibly confusing errors when installing the plugin dependencies.
> The plugin [lists 3 
> dependencies|https://github.com/Microsoft/cordova-plugin-code-push/blob/e828a5eacd42dcd81bacf121a3e62735c3500227/plugin.xml#L10-L12]
>  in plugin.xml.
> Cordova successfully installs the first (code-push) dependency.
> Cordova attempts to install the second (cordova-plugin-device) dependency. It 
> appears that the npm install is successful.
> At the end of the npm install, cordova-fetch [attempts to 
> discover|https://github.com/apache/cordova-fetch/blob/master/index.js#L100] 
> what was just installed. Rather than finding "cordova-plugin-device", it 
> finds "code-push" for a second time.
> Then it fails with the following confusing error message:
> {noformat}
> Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have 
> ID "cordova-plugin-dialogs" but got "code-push".{noformat}
> The full verbose output from {{cordova prepare}} is below:
> {noformat}
> Discovered plugin "cordova-plugin-code-push" in config.xml. Adding it to the 
> project
> No scripts found for hook "before_plugin_add".
> Calling plugman.fetch on plugin "cordova-plugin-code-push@^1.11.2"
> Running command: npm install cordova-plugin-code-push@^1.11.2 --production 
> --no-save
> Command finished with error code 0: npm 
> install,cordova-plugin-code-push@^1.11.2,--production,--no-save
> Copying plugin "/PROJECT/node_modules/cordova-plugin-code-push" => 
> "/PROJECT/plugins/cordova-plugin-code-push"
> Calling plugman.install on plugin "/PROJECT/plugins/cordova-plugin-code-push" 
> for platform "android
> Installing "cordova-plugin-code-push" for android
> Running command: /PROJECT/platforms/android/cordova/version 
> Command finished with error code 0: 
> /PROJECT/platforms/android/cordova/version 
> Dependencies detected, iterating through them...
> Requesting plugin "code-push@2.0.4".
> Plugin dependency "code-push" not fetched, retrieving then installing.
> Running command: npm install code-push@2.0.4 --production --no-save
> Command finished with error code 0: npm 
> install,code-push@2.0.4,--production,--no-save
> Copying plugin "/PROJECT/node_modules/code-push" => 
> "/PROJECT/plugins/code-push"
> Installing "code-push" for android
> Finding scripts for "before_plugin_install" hook from plugin code-push on 
> android platform only.
> No scripts found for hook "before_plugin_install".
> Install start for "code-push" on android.
> Beginning processing of action stack for android project...
> Action stack processing complete.
> Install complete for code-push on android.
> Finding scripts for "after_plugin_install" hook from plugin code-push on 
> android platform only.
> No scripts found for hook "after_plugin_install".
> Requesting plugin "cordova-plugin-dialogs@>=1.1.1".
> Plugin dependency "cordova-plugin-dialogs" not fetched, retrieving then 
> installing.
> Running command: npm install cordova-plugi

[jira] [Comment Edited] (CB-13797) Fetch failing to install plugin dependencies

2018-06-07 Thread Ken Naito (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504597#comment-16504597
 ] 

Ken Naito edited comment on CB-13797 at 6/7/18 12:29 PM:
-

I confirmed this issue.
One solution for https://github.com/dpogue/cb-13797 is removing  
"code-push": "^2.0.4" in dependencies in package.json.

When we do 'npm install', the npm installs code-push@2.0.5 in node_modules.
Then we do 'cordova prepare', the cordova installs cordova-plugin-code-push.
Because the cordova-plugin-code-push depends code-push@2.0.4, the cordova will 
install code-push@2.0.4.
At this time, depTree in cordova-fetch is as follows (npm ls --depth=0)

{code}
├─┬ UNMET DEPENDENCY code-push@2.0.5
│ ├── q@1.5.1
│ ├── recursive-fs@0.1.4
│ ├── slash@1.0.0
│ ├── superagent@3.8.3
│ ├── superagent-proxy@1.0.3
│ └── yazl@2.4.3
├── cordova@8.0.0
├── cordova-android@7.1.0
├── cordova-ios@4.5.4
├── cordova-plugin-code-push@1.11.11
├── cordova-plugin-device@2.0.2
└── cordova-plugin-whitelist@1.3.3
{code}

Next the cordova will install cordova-plugin-dialogs, then treeDep becomes
{code}
├── code-push@2.0.5
├── cordova@8.0.0
├── cordova-android@7.1.0
├── cordova-ios@4.5.4
├── cordova-plugin-code-push@1.11.11
├── cordova-plugin-device@2.0.2
└── cordova-plugin-whitelist@1.3.3
{code}

Comparing both two depTrees, getJsonDiff(tree1, tree2) in cordova-fetch returns 
'code-push'.
This is because 'cordova install cordova-plugin-dialogs' fails with the error 
{code}
Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have ID 
"cordova-plugin-dialogs" but got "code-push".
{code}

In order to resolve this issue, cordova-fetch must find the correct id of 
installed package.




was (Author: knaito):
I confirmed this issue.
One solution for https://github.com/dpogue/cb-13797 is removing  
"code-push": "^2.0.4" in dependencies in package.json.

When we do 'npm install', the npm installs code-push@2.0.5 in node_modules.
Then we do 'cordova prepare', the cordova installs cordova-plugin-code-push.
Because the cordova-plugin-code-push depends code-push@2.0.4, the cordova will 
install code-push@2.0.4.
At this time, depTree in cordova-fetch is as follows (npm ls --depth=0)

{code}
├─┬ UNMET DEPENDENCY code-push@2.0.5
│ ├── q@1.5.1
│ ├── recursive-fs@0.1.4
│ ├── slash@1.0.0
│ ├── superagent@3.8.3
│ ├── superagent-proxy@1.0.3
│ └── yazl@2.4.3
├── cordova@8.0.0
├── cordova-android@7.1.0
├── cordova-ios@4.5.4
├── cordova-plugin-code-push@1.11.11
├── cordova-plugin-device@2.0.2
└── cordova-plugin-whitelist@1.3.3
{code}

Next the cordova will install cordova-plugin-dialogs, then treeDep becomes
{code}
├── code-push@2.0.5
├── cordova@8.0.0
├── cordova-android@7.1.0
├── cordova-ios@4.5.4
├── cordova-plugin-code-push@1.11.11
├── cordova-plugin-device@2.0.2
└── cordova-plugin-whitelist@1.3.3
{code}

Comparing both two depTree, getJsonDiff(tree1, tree2) in cordova-fetch returns 
'code-push'.
This is because 'cordova install cordova-plugin-dialogs' fails with the error 
{code}
Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have ID 
"cordova-plugin-dialogs" but got "code-push".
{code}

In order to resolve this issue, cordova-fetch must find the correct id of 
installed package.



> Fetch failing to install plugin dependencies
> 
>
> Key: CB-13797
> URL: https://issues.apache.org/jira/browse/CB-13797
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-fetch
> Environment: cordova@8.0.0
> cordova-common@2.2.1
> cordova-lib@8.0.0
> cordova-fetch@1.3.0
> npm@5.6.0
> node@9.4.0
>  
>Reporter: Darryl Pogue
>Assignee: Steve Gill
>Priority: Critical
>
> I'm currently unable to install Microsoft's cordova-plugin-code-push due to 
> some incredibly confusing errors when installing the plugin dependencies.
> The plugin [lists 3 
> dependencies|https://github.com/Microsoft/cordova-plugin-code-push/blob/e828a5eacd42dcd81bacf121a3e62735c3500227/plugin.xml#L10-L12]
>  in plugin.xml.
> Cordova successfully installs the first (code-push) dependency.
> Cordova attempts to install the second (cordova-plugin-device) dependency. It 
> appears that the npm install is successful.
> At the end of the npm install, cordova-fetch [attempts to 
> discover|https://github.com/apache/cordova-fetch/blob/master/index.js#L100] 
> what was just installed. Rather than finding "cordova-plugin-device", it 
> finds "code-push" for a second time.
> Then it fails with the following confusing error message:
> {noformat}
> Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have 
> ID "cordova-plugin-dialogs" but got "code-push".{noformat}
> The full verbose output from {{cordova prepare}} is below:
> {noformat}
> Discovered plugin "cordova-plugin-code-pu

[jira] [Commented] (CB-13797) Fetch failing to install plugin dependencies

2018-06-07 Thread Ken Naito (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504603#comment-16504603
 ] 

Ken Naito commented on CB-13797:


We can see this situation  (UNMET DEPENDENCY) as follows,

{code}
$ git checkout https://github.com/dpogue/cb-13797.git
$ npm install
$ npm install code-push@2.0.4 --production --no-save
$ npm ls --depth=0 
$ npm install cordova-plugin-dialogs@1.1.1 --production --no-save
$ npm ls --depth=0
{code}


> Fetch failing to install plugin dependencies
> 
>
> Key: CB-13797
> URL: https://issues.apache.org/jira/browse/CB-13797
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-fetch
> Environment: cordova@8.0.0
> cordova-common@2.2.1
> cordova-lib@8.0.0
> cordova-fetch@1.3.0
> npm@5.6.0
> node@9.4.0
>  
>Reporter: Darryl Pogue
>Assignee: Steve Gill
>Priority: Critical
>
> I'm currently unable to install Microsoft's cordova-plugin-code-push due to 
> some incredibly confusing errors when installing the plugin dependencies.
> The plugin [lists 3 
> dependencies|https://github.com/Microsoft/cordova-plugin-code-push/blob/e828a5eacd42dcd81bacf121a3e62735c3500227/plugin.xml#L10-L12]
>  in plugin.xml.
> Cordova successfully installs the first (code-push) dependency.
> Cordova attempts to install the second (cordova-plugin-device) dependency. It 
> appears that the npm install is successful.
> At the end of the npm install, cordova-fetch [attempts to 
> discover|https://github.com/apache/cordova-fetch/blob/master/index.js#L100] 
> what was just installed. Rather than finding "cordova-plugin-device", it 
> finds "code-push" for a second time.
> Then it fails with the following confusing error message:
> {noformat}
> Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have 
> ID "cordova-plugin-dialogs" but got "code-push".{noformat}
> The full verbose output from {{cordova prepare}} is below:
> {noformat}
> Discovered plugin "cordova-plugin-code-push" in config.xml. Adding it to the 
> project
> No scripts found for hook "before_plugin_add".
> Calling plugman.fetch on plugin "cordova-plugin-code-push@^1.11.2"
> Running command: npm install cordova-plugin-code-push@^1.11.2 --production 
> --no-save
> Command finished with error code 0: npm 
> install,cordova-plugin-code-push@^1.11.2,--production,--no-save
> Copying plugin "/PROJECT/node_modules/cordova-plugin-code-push" => 
> "/PROJECT/plugins/cordova-plugin-code-push"
> Calling plugman.install on plugin "/PROJECT/plugins/cordova-plugin-code-push" 
> for platform "android
> Installing "cordova-plugin-code-push" for android
> Running command: /PROJECT/platforms/android/cordova/version 
> Command finished with error code 0: 
> /PROJECT/platforms/android/cordova/version 
> Dependencies detected, iterating through them...
> Requesting plugin "code-push@2.0.4".
> Plugin dependency "code-push" not fetched, retrieving then installing.
> Running command: npm install code-push@2.0.4 --production --no-save
> Command finished with error code 0: npm 
> install,code-push@2.0.4,--production,--no-save
> Copying plugin "/PROJECT/node_modules/code-push" => 
> "/PROJECT/plugins/code-push"
> Installing "code-push" for android
> Finding scripts for "before_plugin_install" hook from plugin code-push on 
> android platform only.
> No scripts found for hook "before_plugin_install".
> Install start for "code-push" on android.
> Beginning processing of action stack for android project...
> Action stack processing complete.
> Install complete for code-push on android.
> Finding scripts for "after_plugin_install" hook from plugin code-push on 
> android platform only.
> No scripts found for hook "after_plugin_install".
> Requesting plugin "cordova-plugin-dialogs@>=1.1.1".
> Plugin dependency "cordova-plugin-dialogs" not fetched, retrieving then 
> installing.
> Running command: npm install cordova-plugin-dialogs@>=1.1.1 --production 
> --no-save
> Command finished with error code 0: npm 
> install,cordova-plugin-dialogs@>=1.1.1,--production,--no-save
> Copying plugin "/PROJECT/node_modules/code-push" => 
> "/PROJECT/plugins/code-push"
> Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have 
> ID "cordova-plugin-dialogs" but got "code-push".
> at checkID (/PROJECT/node_modules/cordova-lib/src/plugman/fetch.js:215:15)
> at /PROJECT/node_modules/cordova-lib/src/plugman/fetch.js:199:9
> at _fulfilled (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at /PROJECT/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush (/PROJECT/node_modules/cordova

[jira] [Commented] (CB-12551) File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2

2018-06-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504598#comment-16504598
 ] 

ASF GitHub Bot commented on CB-12551:
-

macdonst commented on a change in pull request #197: CB-12551: (android) Patch 
Security Provider to support TLS 1.2
URL: 
https://github.com/apache/cordova-plugin-file-transfer/pull/197#discussion_r193724088
 
 

 ##
 File path: src/android/FileTransfer.java
 ##
 @@ -53,8 +53,13 @@ Licensed to the Apache Software Foundation (ASF) under one
 
 import android.net.Uri;
 import android.os.Build;
+import android.util.Log;
 
 Review comment:
   @davidofwatkins use `org.apache.cordova.LOG` instead. It has the same method 
signature as `android.util.Log` and it fixes an issue where `android.util.Log` 
doesn't get stripped properly from binaries.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2
> -
>
> Key: CB-12551
> URL: https://issues.apache.org/jira/browse/CB-12551
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-file-transfer (DEPRECATED)
>Reporter: Dani Palou
>Priority: Major
>
> FileTransfer's download function fails when trying to download a file from a 
> site using TLS 1.2. This works fine in Android 5 or higher, but it fails in 
> Android 4.x.
> I searched a bit and I found that Android 4.4 should support TLS1.2 but it is 
> disabled by default. I applied the solution proposed in this post and it 
> worked for me:
> http://stackoverflow.com/a/33567745
> That is, I created the _MySSLSocketFactory_ class in the FileTransfer 
> project, and I used it in the _trustAllHosts_ function (line 636 of 
> _FileTransfer.java_):
> {noformat}
> SSLSocketFactory newFactory = new MySSLSocketFactory(sc.getSocketFactory());
> {noformat}
> I'm not sure if this can cause problems with other certificates, I don't know 
> much about this. It would be nice if the Cordova team could take a look at 
> this and check if it can be solved.
> This is the stacktrace:
> {noformat}
> Error getting HTTP status code from connection.
> javax.net.ssl.SSLException: Connection closed by peer
>  at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
>  at 
> com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:405)
>  at com.android.okhttp.Connection.upgradeToTls(Connection.java:146)
>  at com.android.okhttp.Connection.connect(Connection.java:107)
>  at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:294)
>  at 
> com.android.okhttp.internal.http.HttpEngine.sendSocketRequest(HttpEngine.java:255)
>  at 
> com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:206)
>  at 
> com.android.okhttp.internal.http.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:345)
>  at 
> com.android.okhttp.internal.http.HttpURLConnectionImpl.connect(HttpURLConnectionImpl.java:89)
>  at 
> com.android.okhttp.internal.http.HttpsURLConnectionImpl.connect(HttpsURLConnectionImpl.java:161)
>  at org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:869)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
>  at java.lang.Thread.run(Thread.java:841)
> {noformat}
> It can be tested with this code:
> {noformat}
> var ft = new FileTransfer(),
> path = 'squirrel.jpg',
> uri = 
> 'https://prototype.moodle.net/mobile/moodle32/webservice/pluginfile.php/314/mod_resource/content/3/squirrel.jpg?forcedownload=1&token=616455be9f363cc9631cab89cfcfa1cd';
> ft.download(uri, path, success, error, true);
> function success() {
> console.log('Success');
> }
> function error(data) {
> console.log('Error', data);
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12551) File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2

2018-06-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504600#comment-16504600
 ] 

ASF GitHub Bot commented on CB-12551:
-

macdonst commented on a change in pull request #197: CB-12551: (android) Patch 
Security Provider to support TLS 1.2
URL: 
https://github.com/apache/cordova-plugin-file-transfer/pull/197#discussion_r193726833
 
 

 ##
 File path: src/android/FileTransfer.java
 ##
 @@ -53,8 +53,13 @@ Licensed to the Apache Software Foundation (ASF) under one
 
 import android.net.Uri;
 import android.os.Build;
+import android.util.Log;
 import android.webkit.CookieManager;
 
+import com.google.android.gms.common.GooglePlayServicesNotAvailableException;
 
 Review comment:
   @davidofwatkins Don't you need to add Play Services as a `framework` tag in 
the `plugin.xml` file in order for this to compile?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2
> -
>
> Key: CB-12551
> URL: https://issues.apache.org/jira/browse/CB-12551
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-file-transfer (DEPRECATED)
>Reporter: Dani Palou
>Priority: Major
>
> FileTransfer's download function fails when trying to download a file from a 
> site using TLS 1.2. This works fine in Android 5 or higher, but it fails in 
> Android 4.x.
> I searched a bit and I found that Android 4.4 should support TLS1.2 but it is 
> disabled by default. I applied the solution proposed in this post and it 
> worked for me:
> http://stackoverflow.com/a/33567745
> That is, I created the _MySSLSocketFactory_ class in the FileTransfer 
> project, and I used it in the _trustAllHosts_ function (line 636 of 
> _FileTransfer.java_):
> {noformat}
> SSLSocketFactory newFactory = new MySSLSocketFactory(sc.getSocketFactory());
> {noformat}
> I'm not sure if this can cause problems with other certificates, I don't know 
> much about this. It would be nice if the Cordova team could take a look at 
> this and check if it can be solved.
> This is the stacktrace:
> {noformat}
> Error getting HTTP status code from connection.
> javax.net.ssl.SSLException: Connection closed by peer
>  at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
>  at 
> com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:405)
>  at com.android.okhttp.Connection.upgradeToTls(Connection.java:146)
>  at com.android.okhttp.Connection.connect(Connection.java:107)
>  at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:294)
>  at 
> com.android.okhttp.internal.http.HttpEngine.sendSocketRequest(HttpEngine.java:255)
>  at 
> com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:206)
>  at 
> com.android.okhttp.internal.http.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:345)
>  at 
> com.android.okhttp.internal.http.HttpURLConnectionImpl.connect(HttpURLConnectionImpl.java:89)
>  at 
> com.android.okhttp.internal.http.HttpsURLConnectionImpl.connect(HttpsURLConnectionImpl.java:161)
>  at org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:869)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
>  at java.lang.Thread.run(Thread.java:841)
> {noformat}
> It can be tested with this code:
> {noformat}
> var ft = new FileTransfer(),
> path = 'squirrel.jpg',
> uri = 
> 'https://prototype.moodle.net/mobile/moodle32/webservice/pluginfile.php/314/mod_resource/content/3/squirrel.jpg?forcedownload=1&token=616455be9f363cc9631cab89cfcfa1cd';
> ft.download(uri, path, success, error, true);
> function success() {
> console.log('Success');
> }
> function error(data) {
> console.log('Error', data);
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13797) Fetch failing to install plugin dependencies

2018-06-07 Thread Ken Naito (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504597#comment-16504597
 ] 

Ken Naito commented on CB-13797:


I confirmed this issue.
One solution for https://github.com/dpogue/cb-13797 is removing  
"code-push": "^2.0.4" in dependencies in package.json.

When we do 'npm install', the npm installs code-push@2.0.5 in node_modules.
Then we do 'cordova prepare', the cordova installs cordova-plugin-code-push.
Because the cordova-plugin-code-push depends code-push@2.0.4, the cordova will 
install code-push@2.0.4.
At this time, depTree in cordova-fetch is as follows (npm ls --depth=0)

{code}
├─┬ UNMET DEPENDENCY code-push@2.0.5
│ ├── q@1.5.1
│ ├── recursive-fs@0.1.4
│ ├── slash@1.0.0
│ ├── superagent@3.8.3
│ ├── superagent-proxy@1.0.3
│ └── yazl@2.4.3
├── cordova@8.0.0
├── cordova-android@7.1.0
├── cordova-ios@4.5.4
├── cordova-plugin-code-push@1.11.11
├── cordova-plugin-device@2.0.2
└── cordova-plugin-whitelist@1.3.3
{code}

Next the cordova will install cordova-plugin-dialogs, then treeDep becomes
{code}
├── code-push@2.0.5
├── cordova@8.0.0
├── cordova-android@7.1.0
├── cordova-ios@4.5.4
├── cordova-plugin-code-push@1.11.11
├── cordova-plugin-device@2.0.2
└── cordova-plugin-whitelist@1.3.3
{code}

Comparing both two depTree, getJsonDiff(tree1, tree2) in cordova-fetch returns 
'code-push'.
This is because 'cordova install cordova-plugin-dialogs' fails with the error 
{code}
Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have ID 
"cordova-plugin-dialogs" but got "code-push".
{code}

In order to resolve this issue, cordova-fetch must find the correct id of 
installed package.



> Fetch failing to install plugin dependencies
> 
>
> Key: CB-13797
> URL: https://issues.apache.org/jira/browse/CB-13797
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-fetch
> Environment: cordova@8.0.0
> cordova-common@2.2.1
> cordova-lib@8.0.0
> cordova-fetch@1.3.0
> npm@5.6.0
> node@9.4.0
>  
>Reporter: Darryl Pogue
>Assignee: Steve Gill
>Priority: Critical
>
> I'm currently unable to install Microsoft's cordova-plugin-code-push due to 
> some incredibly confusing errors when installing the plugin dependencies.
> The plugin [lists 3 
> dependencies|https://github.com/Microsoft/cordova-plugin-code-push/blob/e828a5eacd42dcd81bacf121a3e62735c3500227/plugin.xml#L10-L12]
>  in plugin.xml.
> Cordova successfully installs the first (code-push) dependency.
> Cordova attempts to install the second (cordova-plugin-device) dependency. It 
> appears that the npm install is successful.
> At the end of the npm install, cordova-fetch [attempts to 
> discover|https://github.com/apache/cordova-fetch/blob/master/index.js#L100] 
> what was just installed. Rather than finding "cordova-plugin-device", it 
> finds "code-push" for a second time.
> Then it fails with the following confusing error message:
> {noformat}
> Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have 
> ID "cordova-plugin-dialogs" but got "code-push".{noformat}
> The full verbose output from {{cordova prepare}} is below:
> {noformat}
> Discovered plugin "cordova-plugin-code-push" in config.xml. Adding it to the 
> project
> No scripts found for hook "before_plugin_add".
> Calling plugman.fetch on plugin "cordova-plugin-code-push@^1.11.2"
> Running command: npm install cordova-plugin-code-push@^1.11.2 --production 
> --no-save
> Command finished with error code 0: npm 
> install,cordova-plugin-code-push@^1.11.2,--production,--no-save
> Copying plugin "/PROJECT/node_modules/cordova-plugin-code-push" => 
> "/PROJECT/plugins/cordova-plugin-code-push"
> Calling plugman.install on plugin "/PROJECT/plugins/cordova-plugin-code-push" 
> for platform "android
> Installing "cordova-plugin-code-push" for android
> Running command: /PROJECT/platforms/android/cordova/version 
> Command finished with error code 0: 
> /PROJECT/platforms/android/cordova/version 
> Dependencies detected, iterating through them...
> Requesting plugin "code-push@2.0.4".
> Plugin dependency "code-push" not fetched, retrieving then installing.
> Running command: npm install code-push@2.0.4 --production --no-save
> Command finished with error code 0: npm 
> install,code-push@2.0.4,--production,--no-save
> Copying plugin "/PROJECT/node_modules/code-push" => 
> "/PROJECT/plugins/code-push"
> Installing "code-push" for android
> Finding scripts for "before_plugin_install" hook from plugin code-push on 
> android platform only.
> No scripts found for hook "before_plugin_install".
> Install start for "code-push" on android.
> Beginning processing of action stack for android project...
> Action stack processing complete.
> Install complete for code-push on android.
> Finding scripts 

[jira] [Commented] (CB-12551) File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2

2018-06-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504599#comment-16504599
 ] 

ASF GitHub Bot commented on CB-12551:
-

macdonst commented on a change in pull request #197: CB-12551: (android) Patch 
Security Provider to support TLS 1.2
URL: 
https://github.com/apache/cordova-plugin-file-transfer/pull/197#discussion_r193725018
 
 

 ##
 File path: src/android/FileTransfer.java
 ##
 @@ -168,6 +173,17 @@ public boolean execute(String action, JSONArray args, 
final CallbackContext call
 String source = args.getString(0);
 String target = args.getString(1);
 
+// Patch the Security Provider via Google Play Services to improve 
support for newer TLS/SSL standards in
+// older versions of Android (@jira:CB-12551). More info here:
+// 
https://developer.android.com/training/articles/security-gms-provider.html
+try {
+
ProviderInstaller.installIfNeeded(this.cordova.getActivity().getApplicationContext());
+} catch (GooglePlayServicesRepairableException e) {
+Log.e(LOG_TAG, "Google Play Services is out of date. Unable to 
patch security provider");
 
 Review comment:
   @davidofwatkins besides logging the error we should probably tell the user 
to update Play Services. Failing silently doesn't really help.
   
   ```
   // Prompt the user to install/update/enable Google Play services.
   GoogleApiAvailability.getInstance()
 .showErrorNotification(context, e.connectionStatusCode)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2
> -
>
> Key: CB-12551
> URL: https://issues.apache.org/jira/browse/CB-12551
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-file-transfer (DEPRECATED)
>Reporter: Dani Palou
>Priority: Major
>
> FileTransfer's download function fails when trying to download a file from a 
> site using TLS 1.2. This works fine in Android 5 or higher, but it fails in 
> Android 4.x.
> I searched a bit and I found that Android 4.4 should support TLS1.2 but it is 
> disabled by default. I applied the solution proposed in this post and it 
> worked for me:
> http://stackoverflow.com/a/33567745
> That is, I created the _MySSLSocketFactory_ class in the FileTransfer 
> project, and I used it in the _trustAllHosts_ function (line 636 of 
> _FileTransfer.java_):
> {noformat}
> SSLSocketFactory newFactory = new MySSLSocketFactory(sc.getSocketFactory());
> {noformat}
> I'm not sure if this can cause problems with other certificates, I don't know 
> much about this. It would be nice if the Cordova team could take a look at 
> this and check if it can be solved.
> This is the stacktrace:
> {noformat}
> Error getting HTTP status code from connection.
> javax.net.ssl.SSLException: Connection closed by peer
>  at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
>  at 
> com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:405)
>  at com.android.okhttp.Connection.upgradeToTls(Connection.java:146)
>  at com.android.okhttp.Connection.connect(Connection.java:107)
>  at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:294)
>  at 
> com.android.okhttp.internal.http.HttpEngine.sendSocketRequest(HttpEngine.java:255)
>  at 
> com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:206)
>  at 
> com.android.okhttp.internal.http.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:345)
>  at 
> com.android.okhttp.internal.http.HttpURLConnectionImpl.connect(HttpURLConnectionImpl.java:89)
>  at 
> com.android.okhttp.internal.http.HttpsURLConnectionImpl.connect(HttpsURLConnectionImpl.java:161)
>  at org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:869)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
>  at java.lang.Thread.run(Thread.java:841)
> {noformat}
> It can be tested with this code:
> {noformat}
> var ft = new FileTransfer(),
> path = 'squirrel.jpg',
> uri = 
> 'https://prototype.moodle.net/mobile/moodle32/webservice/pluginfile.php/314/mod_resource/content/3/squirrel.jpg?forcedownload=1&token=616455be9f363cc9631cab89cfcfa1cd';
> ft.download(uri, path, success, error, true);
> function success

[jira] [Commented] (CB-12551) File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2

2018-06-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504543#comment-16504543
 ] 

ASF GitHub Bot commented on CB-12551:
-

almas commented on issue #197: CB-12551: (android) Patch Security Provider to 
support TLS 1.2
URL: 
https://github.com/apache/cordova-plugin-file-transfer/pull/197#issuecomment-395385751
 
 
   I need this one. Please merge it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2
> -
>
> Key: CB-12551
> URL: https://issues.apache.org/jira/browse/CB-12551
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-file-transfer (DEPRECATED)
>Reporter: Dani Palou
>Priority: Major
>
> FileTransfer's download function fails when trying to download a file from a 
> site using TLS 1.2. This works fine in Android 5 or higher, but it fails in 
> Android 4.x.
> I searched a bit and I found that Android 4.4 should support TLS1.2 but it is 
> disabled by default. I applied the solution proposed in this post and it 
> worked for me:
> http://stackoverflow.com/a/33567745
> That is, I created the _MySSLSocketFactory_ class in the FileTransfer 
> project, and I used it in the _trustAllHosts_ function (line 636 of 
> _FileTransfer.java_):
> {noformat}
> SSLSocketFactory newFactory = new MySSLSocketFactory(sc.getSocketFactory());
> {noformat}
> I'm not sure if this can cause problems with other certificates, I don't know 
> much about this. It would be nice if the Cordova team could take a look at 
> this and check if it can be solved.
> This is the stacktrace:
> {noformat}
> Error getting HTTP status code from connection.
> javax.net.ssl.SSLException: Connection closed by peer
>  at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
>  at 
> com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:405)
>  at com.android.okhttp.Connection.upgradeToTls(Connection.java:146)
>  at com.android.okhttp.Connection.connect(Connection.java:107)
>  at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:294)
>  at 
> com.android.okhttp.internal.http.HttpEngine.sendSocketRequest(HttpEngine.java:255)
>  at 
> com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:206)
>  at 
> com.android.okhttp.internal.http.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:345)
>  at 
> com.android.okhttp.internal.http.HttpURLConnectionImpl.connect(HttpURLConnectionImpl.java:89)
>  at 
> com.android.okhttp.internal.http.HttpsURLConnectionImpl.connect(HttpsURLConnectionImpl.java:161)
>  at org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:869)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
>  at java.lang.Thread.run(Thread.java:841)
> {noformat}
> It can be tested with this code:
> {noformat}
> var ft = new FileTransfer(),
> path = 'squirrel.jpg',
> uri = 
> 'https://prototype.moodle.net/mobile/moodle32/webservice/pluginfile.php/314/mod_resource/content/3/squirrel.jpg?forcedownload=1&token=616455be9f363cc9631cab89cfcfa1cd';
> ft.download(uri, path, success, error, true);
> function success() {
> console.log('Success');
> }
> function error(data) {
> console.log('Error', data);
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Resolved] (CB-13501) Update cordova repos to also use node 8

2018-06-07 Thread Raphael (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raphael resolved CB-13501.
--
Resolution: Fixed

I think this should be resolved. We're on track of dropping Node 4 and adding 
10. So if 8 is still missing somewhere, we'll figure it out.

> Update cordova repos to also use node 8
> ---
>
> Key: CB-13501
> URL: https://issues.apache.org/jira/browse/CB-13501
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-browser, cordova-cli, cordova-fetch, cordova-js, 
> cordova-serve
>Affects Versions: cordova@7.1.0
>Reporter: Audrey So
>Priority: Major
>
> Update cordova repos to also use node 8



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14119) Cant Disable Debugger Chrome

2018-06-07 Thread jcesarmobile (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504487#comment-16504487
 ] 

jcesarmobile commented on CB-14119:
---

Is your device rooted or using some custom firmware? 

> Cant Disable Debugger Chrome
> 
>
> Key: CB-14119
> URL: https://issues.apache.org/jira/browse/CB-14119
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: AllPlatforms, cordova-cli
>Affects Versions: cordova-android-7.0.0
>Reporter: edoofx
>Priority: Major
>  Labels: security
>
> how i can disable debug when using release APK from cordova ? im using 
> *cordova build android --release – --keystore="PATH KEYSTORE" 
> --storePassword=PASS --alias=ALIAS --password=PASS*
>  when ** apk created succesfully , then im trying to real phone, enable usb 
> debug , plug into PC , then boom! i can see debug on chrome , even with param 
> --release
>  
> *using cordova 8 and android 7.0.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Closed] (CB-14118) iOS 11 UIViewAlertForUnsatisfiableConstraints Error when displaying Keyboard

2018-06-07 Thread jcesarmobile (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-14118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-14118.
-
Resolution: Not A Problem

That's not a Cordova problem, sometimes the keyboard show those messages, but 
they are harmless. 

The problem about InAppBrowser getting frozen, there is another issue about it 
already.

> iOS 11 UIViewAlertForUnsatisfiableConstraints Error when displaying Keyboard
> 
>
> Key: CB-14118
> URL: https://issues.apache.org/jira/browse/CB-14118
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios@4.5.4, cordova-ios@4.6.0
>Reporter: Alberto Hernández Cerezo
>Assignee: Suraj Pindoria
>Priority: Major
>  Labels: bug
>
> I am facing a problem with the iOS version of my project since I updated my 
> cordova-ios version to 4.5.4 (and now with 4.6.0).
> It happens anytime I click on an input element and the keyboard gets 
> displayed. There is a constraint error that did not appear before and I don't 
> know from where it comes from:
> {code:java}
> [LayoutConstraints] Unable to simultaneously satisfy constraints. Probably at 
> least one of the constraints in the following list is one you don't want. Try 
> this: (1) look at each constraint and try to figure out which you don't 
> expect; (2) find the code that added the unwanted constraint or constraints 
> and fix it. (Note: If you're seeing NSAutoresizingMaskLayoutConstraints that 
> you don't understand, refer to the documentation for the UIView property 
> translatesAutoresizingMaskIntoConstraints) (     
> " _UIToolbarContentView:0x1035988e0.width == UIToolbar:0x103598690.width   
> (active)>",     " H:|-(0)-[_UIButtonBarStackView:0x103652760]   (active, names: 
> '|':_UIToolbarContentView:0x1035988e0 )>",     
> " == _UIToolbarContentView:0x1035988e0.trailing + 8   (active)>",     
> " (active, names: '|':_UIButtonBarButton:0x10366e4a0 )>",     
> "=8)-|   
> (active, names: '|':_UIButtonBarButton:0x10366e4a0 )>",     
> "=5)-[_UIModernBarButton:0x10366f560]   
> (active, names: '|':_UIButtonBarButton:0x10366f310 )>",     
> "=5)-|   
> (active, names: '|':_UIButtonBarButton:0x10366f310 )>",     
> " H:|-(8)-[_UIModernBarButton:0x10366fce0'Done']   (active, names: 
> '|':_UIButtonBarButton:0x10366fa90 )>",     " H:[_UIModernBarButton:0x10366fce0'Done']-(0)-|   (active, names: 
> '|':_UIButtonBarButton:0x10366fa90 )>",     " 'UISV-canvas-connection' 
> UILayoutGuide:0x1c41bdea0'UIViewLayoutMarginsGuide'.leading == 
> _UIButtonBarButton:0x10366e4a0.leading   (active)>",     
> " UILayoutGuide:0x1c41bdea0'UIViewLayoutMarginsGuide'.trailing == 
> _UIButtonBarButton:0x10366fa90.trailing   (active)>",     
> " H:[_UIButtonBarButton:0x10366e4a0]-(0)-[UIView:0x10366f120]   (active)>",     
> " H:[UIView:0x10366f120]-(0)-[_UIButtonBarButton:0x10366f310]   (active)>",     
> " H:[_UIButtonBarButton:0x10366f310]-(0)-[UIView:0x10366f8a0]   (active)>",     
> " H:[UIView:0x10366f8a0]-(0)-[_UIButtonBarButton:0x10366fa90]   (active)>",     
> " UIToolbar:0x103598690.width == 0   (active)>",     
> " H:|-(0)-[UILayoutGuide:0x1c41bdea0'UIViewLayoutMarginsGuide'](LTR)   (active, 
> names: '|':_UIButtonBarStackView:0x103652760 )>",     
> " H:[UILayoutGuide:0x1c41bdea0'UIViewLayoutMarginsGuide']-(0)-|(LTR)   (active, 
> names: '|':_UIButtonBarStackView:0x103652760 )>" )
> {code}
> After getting this error the APP keeps working fine. But in case I use the 
> inAppBrowser plugin and display an input element on a page, after closing the 
> browser and coming back to the APP it gets frozen.
> I have tried by updating the Cordova iOS version and installing the cordova 
> keyboard plugin with not result (different solutions suggested on different 
> blogs).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14123) Css issue in cordova when loading the vue application

2018-06-07 Thread jcesarmobile (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504482#comment-16504482
 ] 

jcesarmobile commented on CB-14123:
---

can you provide a sample project?

> Css issue in cordova when loading the vue application
> -
>
> Key: CB-14123
> URL: https://issues.apache.org/jira/browse/CB-14123
> Project: Apache Cordova
>  Issue Type: Bug
>Reporter: Akashdeep
>Priority: Major
>
> Hello,
> I have created an application using the vue js. After running the yarn build 
> command i am copying the app.js , manifest.js vendor.js and app.css file form 
> the build folder to cordova application folder.
> The app run fine in mobile browser perfectly with UI and functionality. But 
> when i am using the same code in cordova by calling them as normal javascript 
> and css file. The application get loaded but i facing a lots of css issue 
> which i am not facing in the mobile browser.
> I compared both codes line by line and found no difference. Any help would be 
> really appreciated. The css is really causing the css. Any configuration or 
> any code changes in vue or cordova is needed then please let me share ir



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14066) Remove Node 4 from CI - cordova-fetch

2018-06-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504440#comment-16504440
 ] 

ASF GitHub Bot commented on CB-14066:
-

raphinesse commented on issue #21: CB-14066: Drop support for Node 4
URL: https://github.com/apache/cordova-fetch/pull/21#issuecomment-395350884
 
 
   Created issue for the failing AppVeyor/Node10 build here: 
https://github.com/appveyor/ci/issues/2420


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove Node 4 from CI - cordova-fetch
> -
>
> Key: CB-14066
> URL: https://issues.apache.org/jira/browse/CB-14066
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-fetch
>Reporter: Darryl Pogue
>Assignee: Darryl Pogue
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14066) Remove Node 4 from CI - cordova-fetch

2018-06-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504438#comment-16504438
 ] 

ASF GitHub Bot commented on CB-14066:
-

raphinesse opened a new pull request #21: CB-14066: Drop support for Node 4
URL: https://github.com/apache/cordova-fetch/pull/21
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove Node 4 from CI - cordova-fetch
> -
>
> Key: CB-14066
> URL: https://issues.apache.org/jira/browse/CB-14066
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-fetch
>Reporter: Darryl Pogue
>Assignee: Darryl Pogue
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-06-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504416#comment-16504416
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-395340508
 
 
   @infil00p @stevengill @agrieve @shazron @purplecabbage Could you guys review 
this when you get a chance?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-06-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504411#comment-16504411
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-395338674
 
 
   Travis CI build is failing because, as noted above, __has_include macro 
appears to only work in the device environment, so fails when Travis spins up 
the iOS Simulator 😞 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-06-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504412#comment-16504412
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-395338674
 
 
   Travis CI build is failing because, as noted above, the `__has_include` 
macro appears to only work in the device environment, so fails when Travis 
spins up the iOS Simulator 😞 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14120) Playback issues in iOS 11.3/11.4

2018-06-07 Thread Ken Naito (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504351#comment-16504351
 ] 

Ken Naito commented on CB-14120:


Could you please tell me how to reproduce this issue in detail?

I try to test using following project.
(Cordova 8.0, Cordova-iOS 4.5.4)

However I can't reproduce this issue on both iOS 11.3.1/iPhone5S and iOS 
11.3.0/iPhone8.

JavaScript:
{code:javascript}
var musics = ["A.mp3","B.mp3","C.mp3"];
var musicIndex = 0;
var media = null;
var mediaTimer = null;

function startPlayAudio() {
  musicIndex = 0;
  media = null;
  mediaTimer = null;
  playAudio1();
  var elem = document.getElementById("musicPosition");
  var showMusicPosition = function() {
if (media != null) {
  var dur = media.getDuration();
  media.getCurrentPosition( function(position) {
elem.innerHTML = musics[musicIndex] + " " + position + "/" + dur + " 
[sec]";
  });
}
mediaTimer = setTimeout(showMusicPosition, 250);
  }
  mediaTimer = setTimeout(showMusicPosition, 1);
}

function playAudio1() {
  var url = "res/"+musics[musicIndex];
  media = new Media(url,
function() {
},
function(err) {
},
function(status) {
  if (status === Media.MEDIA_STOPPED) {
media.release();
musicIndex += 1;
if (musicIndex < musics.length) {
  playAudio1();
} else {
  mediaTimer.clearTimeout();
}
  }
}
  );
  media.stop();
  media.play();
}
{code}

HTML:
{code:HTML}
StartPlayAudio


{code}

> Playback issues in iOS 11.3/11.4 
> -
>
> Key: CB-14120
> URL: https://issues.apache.org/jira/browse/CB-14120
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-media
> Environment: Ionic 3, Angular JS 4
>Reporter: Muddasir Lakhani
>Priority: Blocker
>
> I am trying to play multiple audio tracks one after the other using the Media 
> Plugin.
> On pressing play, I download all the tracks as a zip file, and then play them 
> one after the other until the last track is played. This works fine on 
> Android (all models) and also on iOS up to 11.2. On iOS 11.3 onwards, the 
> next track never starts from the beginning, but from a random duration. So 
> basically if an Album has 4 tracks, first one will play from duration 00:00, 
> and then the next ones will start to play from random duration, and never 
> from 00:00.
> Code Snippet is below:
> {{if (ContainerClass.GetPlatformName() == "android") { this._mFile = 
> this.media.create(this._URL + "/" + AlbumNo + "/" + this._fileName[index]); } 
> else if (ContainerClass.GetPlatformName() == "ios") { this._mFile = 
> this.media.create((this._URL + "/" + AlbumNo + "/" + 
> this._fileName[index]).replace(/^file:\/\//, '')); } 
> this._mFile.onStatusUpdate.subscribe(status => console.log(status)); 
> this._mFile.stop(); this._mFile.play(); ServicesClass._mFile = this._mFile; 
> ServicesClass._isPlaying = 1; ServicesClass._playingAlbumNo = this.AlbumNo; 
> ServicesClass._isPlaying = 1 this._isPlaying = 1; 
> this._mFile.onSuccess.subscribe(result => { index++; this._playingIndex = 
> index; this._mFile.release(); if (ServicesClass._stopPlaying == false) { 
> this.PlayFiles(AlbumNo, index); this.showMp3Player(true); } else { return; } 
> }); this._mFile.onError.subscribe(error => console.log('Error!', 
> JSON.stringify(error))); } }}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org