[jira] [Closed] (CB-11524) [iOS 10] Using localStorage with WKWebView gives a security error

[Darryl Pogue (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darryl Pogue closed CB-11524.
-
Resolution: Cannot Reproduce

This was an Apple issue, and is fixed in newer versions of iOS.

> [iOS 10] Using localStorage with WKWebView gives a security error
> -
>
> Key: CB-11524
> URL: https://issues.apache.org/jira/browse/CB-11524
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-wkwebview-engine
>Reporter: Saúl Ibarra Corretgé
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: wkwebview-known-issues
>
> When using window.localStorage on iOS 10 with WKWebView, the following error 
> happens: SecurityError: DOM Exception 18: An attempt was made to break 
> through the security policy of the user agent.
> This does not happen with UIWebView, or with WKWebView on iOS 9.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-10142) WebSQL (window.openDatabase) will not work in WKWebViewEngine

[Darryl Pogue (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darryl Pogue closed CB-10142.
-
Resolution: Cannot Reproduce

This was an Apple bug, and is fixed in newer versions of iOS

> WebSQL (window.openDatabase) will not work in WKWebViewEngine
> -
>
> Key: CB-10142
> URL: https://issues.apache.org/jira/browse/CB-10142
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-wkwebview-engine
>Reporter: Shazron Abdullah
>Priority: Major
>  Labels: wkwebview-known-issues
>
> It fails mobile-spec storage.spec.18 and is a known WKWebView bug (not fixed 
> as of iOS 9.1): https://bugs.webkit.org/show_bug.cgi?id=137760
> The test is skipped when you run the engine on mobile-spec.
> window.openDatabase is defined, but throws an error when you use it.
> This is an Apple bug.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14091) Fails Streaming test for iOS and Browser

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516646#comment-16516646
 ] 

ASF GitHub Bot commented on CB-14091:
-

shazron commented on issue #166: CB-14091: fix tests code for stream url and 
remove browser
URL: 
https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398271806
 
 
   Follow the discussion here: 
https://lists.apache.org/thread.html/3178fd3d36491e6e0777d8ee104de93e2aef09c7c3ec19dbbdbcbcc3@%3Cdev.cordova.apache.org%3E


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fails Streaming test for iOS and Browser
> 
>
> Key: CB-14091
> URL: https://issues.apache.org/jira/browse/CB-14091
> Project: Apache Cordova
>  Issue Type: Test
>  Components: cordova-plugin-media
>Affects Versions: 8.0.0
>Reporter: Ken Naito
>Priority: Trivial
> Fix For: 8.0.0
>
>
> tests/tests.js fails.
> spec.19 and spec.20 for Browser
> spec.25 for iOS
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11315) WkWebview + DisallowOverscroll breaks fixed positioned elements

[Darryl Pogue (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darryl Pogue closed CB-11315.
-
Resolution: Cannot Reproduce
  Assignee: Darryl Pogue

This problem _seems_ to be solved in iOS 11, but even the WebKit team can't 
confirm that. It's unfortunately not something that Cordova is able to have any 
control over, so I'm going to close this issue and direct everyone to the issue 
on the WebKit bug tracker.

> WkWebview + DisallowOverscroll breaks fixed positioned elements
> ---
>
> Key: CB-11315
> URL: https://issues.apache.org/jira/browse/CB-11315
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-wkwebview-engine
>Reporter: Bjorn Rombaut
>Assignee: Darryl Pogue
>Priority: Major
>  Labels: DisallowOverscroll, ios, wkwebview-1.0.2
> Attachments: IMG_0656.PNG, wkwebview-disallowoverscroll-issue.zip
>
>
> Hi!
> When using both the DisallowOverscroll property and WkWebview, there seems to 
> be an issue when scrolling and repainting fixed elements.
> When you scroll to the end of the page (where it would bounce if you don't 
> set the DisallowOverscroll), fixed positioned elements seem to bounce but 
> never return to their original position. Visually there is no issue but when 
> you try to click something inside the fixed element (for example a button 
> inside a fixed footer) the click action will not be triggered. Also when you 
> hover the node in the Safari Debug Tools it thinks the element is displayed 
> somewhere else.
> I've attached a screenshot and some code to make it a bit more clear.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11315) WkWebview + DisallowOverscroll breaks fixed positioned elements

[Darryl Pogue (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darryl Pogue updated CB-11315:
--
External issue URL: https://bugs.webkit.org/show_bug.cgi?id=158325

> WkWebview + DisallowOverscroll breaks fixed positioned elements
> ---
>
> Key: CB-11315
> URL: https://issues.apache.org/jira/browse/CB-11315
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-wkwebview-engine
>Reporter: Bjorn Rombaut
>Priority: Major
>  Labels: DisallowOverscroll, ios, wkwebview-1.0.2
> Attachments: IMG_0656.PNG, wkwebview-disallowoverscroll-issue.zip
>
>
> Hi!
> When using both the DisallowOverscroll property and WkWebview, there seems to 
> be an issue when scrolling and repainting fixed elements.
> When you scroll to the end of the page (where it would bounce if you don't 
> set the DisallowOverscroll), fixed positioned elements seem to bounce but 
> never return to their original position. Visually there is no issue but when 
> you try to click something inside the fixed element (for example a button 
> inside a fixed footer) the click action will not be triggered. Also when you 
> hover the node in the Safari Debug Tools it thinks the element is displayed 
> somewhere else.
> I've attached a screenshot and some code to make it a bit more clear.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13695) cordova-fetch: ignores npm registry

[Darryl Pogue (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516629#comment-16516629
 ] 

Darryl Pogue commented on CB-13695:
---

[~raphinesse]: You were refactoring the code that calls out to npm recently... 
any idea what might cause it to ignore config files? We just shell out to it, 
right?

> cordova-fetch: ignores npm registry
> ---
>
> Key: CB-13695
> URL: https://issues.apache.org/jira/browse/CB-13695
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-fetch
>Affects Versions: cordova@8.0.0
>Reporter: Heiko
>Priority: Critical
>
> My situation:
> a build server that has no access to the internet.
> By to a local npm mirror.
> If i do at my build job:
> npm config set registry "http://my.local.server/repository/mirror.npm";
> npm install
> npm install cordova ionic npm --no-save
> cordova platform add ios --no-update-notifier
> i get:
> Using cordova-fetch for cordova-ios@4.5.3
> (node:391) UnhandledPromiseRejectionWarning: Unhandled promise rejection 
> (rejection id: 1): Error: Cannot find module './index'
> (node:391) [DEP0018] DeprecationWarning: Unhandled promise rejections are 
> deprecated. In the future, promise rejections that are not handled will 
> terminate the Node.js process with a non-zero exit code.
> My work around for cordova 7 was to use: --nofetch



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13685) Android Adaptive Icons

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516583#comment-16516583
 ] 

ASF GitHub Bot commented on CB-13685:
-

codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon 
Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=h1) 
Report
   > Merging 
[#448](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/393dad6349d8df55d8fca7d3e5014f36dfa4610c?src=pr&el=desc)
 will **decrease** coverage by `0.42%`.
   > The diff coverage is `66.92%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/448/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #448  +/-   ##
   ==
   - Coverage   44.27%   43.84%   -0.43% 
   ==
 Files  17   18   +1 
 Lines1694 2023 +329 
 Branches  311  383  +72 
   ==
   + Hits  750  887 +137 
   - Misses944 1136 +192
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[bin/templates/cordova/lib/AndroidManifest.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkTWFuaWZlc3QuanM=)
 | `35.44% <40%> (+0.3%)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz)
 | `41.66% <68%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=footer).
 Last update 
[393dad6...5a2bd7a](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to 
> create app icons using a background and a foreground image file. This feature 
> is called "adaptive icons". One major change that goes with this feature is 
> that icons get now clipped into a shape by the system. This leads to a very 
> uniform and clean design like on iOS where all icons are a rounded rectangle. 
> The other advantage is that visual effects can be applied to the icon by the 
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon 
> resources because it creates backwards compatible icons for older devices 
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │   ├── ic_launcher_background.xml
> │   └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │   ├── ic_launcher.xml
> │   └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │   ├── ic_launcher.png
> │   └── ic_launcher_round.png
> ├── mipmap-mdpi
> │   ├── ic_launcher.png
> │   └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │   ├── ic_launcher.png
> │   └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │   ├── ic_launcher.png
> │   └── ic_launcher_round.png
> └── mipmap-xxxhdpi
>      ├── ic_launcher.png
>      └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova 
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points 

[jira] [Commented] (CB-13685) Android Adaptive Icons

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516582#comment-16516582
 ] 

ASF GitHub Bot commented on CB-13685:
-

codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon 
Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=h1) 
Report
   > Merging 
[#448](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/393dad6349d8df55d8fca7d3e5014f36dfa4610c?src=pr&el=desc)
 will **decrease** coverage by `0.42%`.
   > The diff coverage is `66.92%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/448/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #448  +/-   ##
   ==
   - Coverage   44.27%   43.84%   -0.43% 
   ==
 Files  17   18   +1 
 Lines1694 2023 +329 
 Branches  311  383  +72 
   ==
   + Hits  750  887 +137 
   - Misses944 1136 +192
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[bin/templates/cordova/lib/AndroidManifest.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkTWFuaWZlc3QuanM=)
 | `35.44% <40%> (+0.3%)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz)
 | `41.66% <68%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=footer).
 Last update 
[393dad6...5a2bd7a](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to 
> create app icons using a background and a foreground image file. This feature 
> is called "adaptive icons". One major change that goes with this feature is 
> that icons get now clipped into a shape by the system. This leads to a very 
> uniform and clean design like on iOS where all icons are a rounded rectangle. 
> The other advantage is that visual effects can be applied to the icon by the 
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon 
> resources because it creates backwards compatible icons for older devices 
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │   ├── ic_launcher_background.xml
> │   └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │   ├── ic_launcher.xml
> │   └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │   ├── ic_launcher.png
> │   └── ic_launcher_round.png
> ├── mipmap-mdpi
> │   ├── ic_launcher.png
> │   └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │   ├── ic_launcher.png
> │   └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │   ├── ic_launcher.png
> │   └── ic_launcher_round.png
> └── mipmap-xxxhdpi
>      ├── ic_launcher.png
>      └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova 
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points 

[jira] [Commented] (CB-14145) Resolve npm audit issues

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516572#comment-16516572
 ] 

ASF GitHub Bot commented on CB-14145:
-

brodybits opened a new pull request #30: [CB-14145] npm audit in CI TEST WIP - 
DO NOT MERGE
URL: https://github.com/apache/cordova-common/pull/30
 
 
   
   
   ### Platforms affected
   
   All
   
   ### What does this PR do?
   
   - `npm audit` in Travis CI
   
   FUTURE TBD:
   - `npm audit` in AppVeyor CI
   
   NOTE: This is a TEST WIP PR, based on 
9b4937493a397246188fee8284f62b9507a14c75 (right before dependencies were 
updated in d473b190960ae3401ede0993994220c89d262bc0), expected to fail with 
`npm audit` issue. This change is intended to be included in 2.2.x and master 
for next major release, to verify that any `npm audit` issues would be spotted 
and resolved in the future.
   
   ### What testing has been done on this change?
   
   Check CI results from this PR
   
   ### Checklist
   - ~~[Reported an issue](http://cordova.apache.org/contribute/issues.html) in 
the JIRA database~~
   - ~~Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.~~
   - ~~Added automated test coverage as appropriate for this change.~~


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Resolve npm audit issues
> 
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-app-hello-world, 
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, 
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number 
> of components would report dependencies with security issues. While we could 
> not see any {{npm audit}} issues that may affect applications built using 
> Cordova I think it is extremely important to resolve these issues as soon as 
> possible. Most affect devDependencies used for testing of Cordova itself; a 
> minority seem to affect Cordova scripts that may be run by Cordova 
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}}, 
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova 
> platform implementations, major plugins, etc. (expected to be fixed in minor 
> release branch; do not want to pollute the master branch with extra reverts, 
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release, 
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14145) Resolve npm audit issues

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516571#comment-16516571
 ] 

ASF GitHub Bot commented on CB-14145:
-

brodybits closed pull request #30: [CB-14145] npm audit in CI TEST WIP - DO NOT 
MERGE
URL: https://github.com/apache/cordova-common/pull/30
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.eslintrc.yml b/.eslintrc.yml
index 7701c82..21a8e7b 100644
--- a/.eslintrc.yml
+++ b/.eslintrc.yml
@@ -8,4 +8,6 @@ rules:
   padded-blocks: off
   operator-linebreak: off
   no-throw-literal: off
-  
\ No newline at end of file
+  no-unused-vars:
+- error
+- args: after-used
diff --git a/.travis.yml b/.travis.yml
index 459273a..d647b88 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,15 +1,25 @@
 language: node_js
 sudo: false
+
 git:
   depth: 10
+
 node_js:
-  - "4"
   - "6"
+  - "8"
+  - "10"
+
 install:
   - npm install
   - npm install -g codecov
+  - node --version
+  - npm --version
+
 script:
   - npm test
   - npm run cover
+  - npm install npm@latest
+  - npm audit
+
 after_script:
   - codecov
diff --git a/README.md b/README.md
index 5659c57..422c98b 100644
--- a/README.md
+++ b/README.md
@@ -24,11 +24,11 @@
 
[![NPM](https://nodei.co/npm/cordova-common.png)](https://nodei.co/npm/cordova-common/)
 
 # cordova-common
-Expoeses shared functionality used by 
[cordova-lib](https://github.com/apache/cordova-lib/) and Cordova platforms.
+Exposes shared functionality used by 
[cordova-lib](https://github.com/apache/cordova-lib/) and Cordova platforms.
 ## Exposed APIs
 
 ### `events`
-  
+
 Represents special instance of NodeJS EventEmitter which is intended to be 
used to post events to cordova-lib and cordova-cli
 
 Usage:
@@ -122,7 +122,7 @@ superspawn.spawn('adb', ['devices'])
 
 ### `xmlHelpers`
 
-A set of utility methods for dealing with xml files.
+A set of utility methods for dealing with XML files.
 
 Usage:
 ```js
@@ -148,10 +148,8 @@ mungeUtil
 
 ## Setup
 * Clone this repository onto your local machine
-`git clone https://git-wip-us.apache.org/repos/asf/cordova-lib.git`
-* In terminal, navigate to the inner cordova-common directory
-`cd cordova-lib/cordova-common`
-* Install dependencies and npm-link
-`npm install && npm link`
+`git clone https://github.com/apache/cordova-common.git`
+* Navigate to cordova-common directory, install dependencies and npm-link
+`cd cordova-common && npm install && npm link`
 * Navigate to cordova-lib directory and link cordova-common
-`cd ../cordova-lib && npm link cordova-common && npm install`
+`cd  && npm link cordova-common && npm install`
diff --git a/RELEASENOTES.md b/RELEASENOTES.md
index 89593ea..5dda362 100644
--- a/RELEASENOTES.md
+++ b/RELEASENOTES.md
@@ -20,6 +20,13 @@
 -->
 # Cordova-common Release Notes
 
+### 2.2.1 (Dec 14, 2017)
+* [CB-13674](https://issues.apache.org/jira/browse/CB-13674): updated 
dependencies
+
+### 2.2.0 (Nov 22, 2017)
+* [CB-13471](https://issues.apache.org/jira/browse/CB-13471) File Provider fix 
belongs in cordova-common 
+* [CB-11244](https://issues.apache.org/jira/browse/CB-11244) Spot fix for 
upcoming `cordova-android@7` changes. 
https://github.com/apache/cordova-android/pull/389
+
 ### 2.1.1 (Oct 04, 2017)
 * [CB-13145](https://issues.apache.org/jira/browse/CB-13145) added 
`getFrameworks` to unit tests
 * [CB-13145](https://issues.apache.org/jira/browse/CB-13145) added variable 
replacing to framework tag
diff --git a/appveyor.yml b/appveyor.yml
index 94714f2..f34dfbd 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -3,9 +3,10 @@
 
 environment:
   matrix:
-  - nodejs_version: "4"
   - nodejs_version: "6"
-  
+  - nodejs_version: "8"
+  - nodejs_version: "10"
+
 install:
   - ps: Install-Product node $env:nodejs_version
   - npm install
diff --git a/package.json b/package.json
index cd5fa09..7e0b096 100644
--- a/package.json
+++ b/package.json
@@ -3,10 +3,10 @@
   "name": "cordova-common",
   "description": "Apache Cordova tools and platforms shared routines",
   "license": "Apache-2.0",
-  "version": "2.1.1",
+  "version": "2.2.2-dev",
   "repository": {
 "type": "git",
-"url": "https://github.com/apache/cordova-lib";
+"url": "https://github.com/apache/cordova-common";
   },
   "bugs": {
 "url": "https://issues.apache.org/jira/browse/CB";,
@@ -18,7 +18,7 @@
   },
   "scripts": {
 "test": "npm run eslint && npm run jasmine",
-"eslint": "eslint src && eslint spec",
+"eslint": "eslint src spec",
 "jasmine": "jasmine JASMINE_CONFIG_PATH=spec/support/jasmine.json",
 "cover": "istanbul cover --root src --print detail jasmine"
   },
diff --git a/spec/ConfigChanges/ConfigChanges.s

[jira] [Commented] (CB-14145) Resolve npm audit issues

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516564#comment-16516564
 ] 

ASF GitHub Bot commented on CB-14145:
-

brodybits closed pull request #30: [CB-14145] npm audit in CI TEST WIP - DO NOT 
MERGE
URL: https://github.com/apache/cordova-common/pull/30
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.travis.yml b/.travis.yml
index 4592c3e..b7d9f9c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,16 +1,26 @@
 language: node_js
 sudo: false
+
 git:
   depth: 10
+
 node_js:
-  - "4"
   - "6"
   - "8"
+  - "10"
+
 install:
   - npm install
+  - npm audit
   - npm install -g codecov
+  - node --version
+  - npm --version
+
 script:
   - npm test
   - npm run cover
+  - npm install npm@latest
+  - npm audit
+
 after_script:
   - codecov
diff --git a/appveyor.yml b/appveyor.yml
index ffe5194..8bac918 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -3,13 +3,15 @@
 
 environment:
   matrix:
-  - nodejs_version: "4"
   - nodejs_version: "6"
   - nodejs_version: "8"
-  
+  - nodejs_version: "10"
+
 install:
   - ps: Install-Product node $env:nodejs_version
   - npm install
+  - node --version
+  - npm --version
 
 build: off
 
@@ -17,3 +19,5 @@ test_script:
   - node --version
   - npm --version
   - npm test
+  - npm install npm@latest
+  - npm audit


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Resolve npm audit issues
> 
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-app-hello-world, 
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, 
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number 
> of components would report dependencies with security issues. While we could 
> not see any {{npm audit}} issues that may affect applications built using 
> Cordova I think it is extremely important to resolve these issues as soon as 
> possible. Most affect devDependencies used for testing of Cordova itself; a 
> minority seem to affect Cordova scripts that may be run by Cordova 
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}}, 
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova 
> platform implementations, major plugins, etc. (expected to be fixed in minor 
> release branch; do not want to pollute the master branch with extra reverts, 
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release, 
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14145) Resolve npm audit issues

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516565#comment-16516565
 ] 

ASF GitHub Bot commented on CB-14145:
-

brodybits opened a new pull request #30: [CB-14145] npm audit in CI TEST WIP - 
DO NOT MERGE
URL: https://github.com/apache/cordova-common/pull/30
 
 
   
   
   ### Platforms affected
   
   All
   
   ### What does this PR do?
   
   - `npm audit` in Travis CI
   
   FUTURE TBD:
   - `npm audit` in AppVeyor CI
   
   NOTE: This is a TEST WIP PR, based on 
9b4937493a397246188fee8284f62b9507a14c75 (right before dependencies were 
updated in d473b190960ae3401ede0993994220c89d262bc0), expected to fail with 
`npm audit` issue. This change is intended to be included in 2.2.x and master 
for next major release, to verify that any `npm audit` issues would be spotted 
and resolved in the future.
   
   ### What testing has been done on this change?
   
   Check CI results from this PR
   
   ### Checklist
   - ~~[Reported an issue](http://cordova.apache.org/contribute/issues.html) in 
the JIRA database~~
   - ~~Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.~~
   - ~~Added automated test coverage as appropriate for this change.~~


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Resolve npm audit issues
> 
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-app-hello-world, 
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, 
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number 
> of components would report dependencies with security issues. While we could 
> not see any {{npm audit}} issues that may affect applications built using 
> Cordova I think it is extremely important to resolve these issues as soon as 
> possible. Most affect devDependencies used for testing of Cordova itself; a 
> minority seem to affect Cordova scripts that may be run by Cordova 
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}}, 
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova 
> platform implementations, major plugins, etc. (expected to be fixed in minor 
> release branch; do not want to pollute the master branch with extra reverts, 
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release, 
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14145) Resolve npm audit issues

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516551#comment-16516551
 ] 

ASF GitHub Bot commented on CB-14145:
-

brodybits opened a new pull request #30: [CB-14145] npm audit in CI TEST WIP - 
DO NOT MERGE
URL: https://github.com/apache/cordova-common/pull/30
 
 
   
   
   ### Platforms affected
   
   All
   
   ### What does this PR do?
   
   - `npm audit` in Travis CI
   
   FUTURE TBD:
   - `npm audit` in AppVeyor CI
   
   NOTE: This is a TEST WIP PR, based on 
9b4937493a397246188fee8284f62b9507a14c75 (right before dependencies were 
updated in d473b190960ae3401ede0993994220c89d262bc0), expected to fail with 
`npm audit` issue. This change is intended to be included in 2.2.x and master 
for next major release, to verify that any `npm audit` issues would be spotted 
and resolved in the future.
   
   ### What testing has been done on this change?
   
   Check CI results from this PR
   
   ### Checklist
   - ~~[Reported an issue](http://cordova.apache.org/contribute/issues.html) in 
the JIRA database~~
   - ~~Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.~~
   - ~~Added automated test coverage as appropriate for this change.~~


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Resolve npm audit issues
> 
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-app-hello-world, 
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, 
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number 
> of components would report dependencies with security issues. While we could 
> not see any {{npm audit}} issues that may affect applications built using 
> Cordova I think it is extremely important to resolve these issues as soon as 
> possible. Most affect devDependencies used for testing of Cordova itself; a 
> minority seem to affect Cordova scripts that may be run by Cordova 
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}}, 
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova 
> platform implementations, major plugins, etc. (expected to be fixed in minor 
> release branch; do not want to pollute the master branch with extra reverts, 
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release, 
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14145) Resolve npm audit issues

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516519#comment-16516519
 ] 

ASF GitHub Bot commented on CB-14145:
-

brodybits commented on issue #618: [CB-14145] npm audit in CI on 8.0.0 - TEST 
WIP DO NOT MERGE
URL: https://github.com/apache/cordova-lib/pull/618#issuecomment-398245318
 
 
   Not working yet, will fix this another day.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Resolve npm audit issues
> 
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-app-hello-world, 
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, 
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number 
> of components would report dependencies with security issues. While we could 
> not see any {{npm audit}} issues that may affect applications built using 
> Cordova I think it is extremely important to resolve these issues as soon as 
> possible. Most affect devDependencies used for testing of Cordova itself; a 
> minority seem to affect Cordova scripts that may be run by Cordova 
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}}, 
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova 
> platform implementations, major plugins, etc. (expected to be fixed in minor 
> release branch; do not want to pollute the master branch with extra reverts, 
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release, 
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14145) Resolve npm audit issues

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516520#comment-16516520
 ] 

ASF GitHub Bot commented on CB-14145:
-

brodybits closed pull request #618: [CB-14145] npm audit in CI on 8.0.0 - TEST 
WIP DO NOT MERGE
URL: https://github.com/apache/cordova-lib/pull/618
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.travis.yml b/.travis.yml
index cc0eebf34..032a4a740 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -10,6 +10,7 @@ node_js:
 before_install: if [[ `npm -v` < 3 ]]; then npm i -g npm@3; fi
 install:
   - npm install
+  - npm audit
   # Workaround for npm/npm#10343 when dependency of linked module is moved to 
dependent
   # module's 'node_modules' In our case 'cordova-common' -> jshint' -> 'cli' 
dependency
   # is moved to 'cordova-lib' and hence 'npm run jshint' on 'cordova-common' 
is failing
diff --git a/appveyor.yml b/appveyor.yml
index 4c3d2982b..ab883fd3b 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -10,6 +10,7 @@ environment:
 install:
   - ps: Install-Product node $env:nodejs_version
   - npm install
+  - npm audit
   # Workaround for npm/npm#10343 when dependency of linked module is moved to 
dependent
   # module's 'node_modules' In our case 'cordova-common' -> jshint' -> 'cli' 
dependency
   # is moved to 'cordova-lib' and hence 'npm run jshint' on 'cordova-common' 
is failing


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Resolve npm audit issues
> 
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-app-hello-world, 
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, 
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number 
> of components would report dependencies with security issues. While we could 
> not see any {{npm audit}} issues that may affect applications built using 
> Cordova I think it is extremely important to resolve these issues as soon as 
> possible. Most affect devDependencies used for testing of Cordova itself; a 
> minority seem to affect Cordova scripts that may be run by Cordova 
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}}, 
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova 
> platform implementations, major plugins, etc. (expected to be fixed in minor 
> release branch; do not want to pollute the master branch with extra reverts, 
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release, 
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14145) Resolve npm audit issues

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516517#comment-16516517
 ] 

ASF GitHub Bot commented on CB-14145:
-

brodybits opened a new pull request #618: [CB-14145] npm audit in CI on 8.0.0 - 
TEST WIP DO NOT MERGE
URL: https://github.com/apache/cordova-lib/pull/618
 
 
   
   
   ### Platforms affected
   
   All
   
   ### What does this PR do?
   
   Check that `npm audit` passes in AppVeyor CI & Travis CI, on 
`cordova-lib@8.0.0` (`8.0.x` branch).
   
   NOTE: THIS IS a TEST WIP, EXPECTED TO FAIL on `cordova-lib@8.0.0` due to 
known `npm audit` issues.
   
   This change is to be included by `git cherry-pick` on `master` and 
eventually on `8.0.x` branch to verify that `npm audit` issues to not come back 
in the future.
   
   ### What testing has been done on this change?
   
   TBD
   
   ### Checklist
   
   - ~~[Reported an issue](http://cordova.apache.org/contribute/issues.html) in 
the JIRA database~~
   - ~~Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.~~
   - ~~Added automated test coverage as appropriate for this change.~~


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Resolve npm audit issues
> 
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-app-hello-world, 
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, 
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number 
> of components would report dependencies with security issues. While we could 
> not see any {{npm audit}} issues that may affect applications built using 
> Cordova I think it is extremely important to resolve these issues as soon as 
> possible. Most affect devDependencies used for testing of Cordova itself; a 
> minority seem to affect Cordova scripts that may be run by Cordova 
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}}, 
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova 
> platform implementations, major plugins, etc. (expected to be fixed in minor 
> release branch; do not want to pollute the master branch with extra reverts, 
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release, 
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-14145) Resolve npm audit issues

[Chris Brody (JIRA)]

Chris Brody created CB-14145:


 Summary: Resolve npm audit issues
 Key: CB-14145
 URL: https://issues.apache.org/jira/browse/CB-14145
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-android, cordova-app-hello-world, 
cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, 
cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
Reporter: Chris Brody
Assignee: Chris Brody


>From private discussions I discovered that running {{npm audit}} on a number 
>of components would report dependencies with security issues. While we could 
>not see any {{npm audit}} issues that may affect applications built using 
>Cordova I think it is extremely important to resolve these issues as soon as 
>possible. Most affect devDependencies used for testing of Cordova itself; a 
>minority seem to affect Cordova scripts that may be run by Cordova application 
>developers. Better safe than sorry!

I would like to resolve this issue as follows:
* patch release of common library components such as {{cordova-common}}, 
{{cordova-lib}}, etc. (fixed in minor release branch)
* patch or minor release of other affected components such as CLI, Cordova 
platform implementations, major plugins, etc. (expected to be fixed in minor 
release branch; do not want to pollute the master branch with extra reverts, 
updated node_modules committed, etc.)
* {{npm audit}} issues resolved in master branch for next major release, which 
should NOT be shipped with any {{npm audit}} issues lurking
* {{npm audit}} step added to CI for both patch release and next major release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14138) cordova-common patch release June 2018

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516495#comment-16516495
 ] 

ASF GitHub Bot commented on CB-14138:
-

brodybits commented on a change in pull request #832: CB-14138: add 
cordova-common@2.2.4 blog post
URL: https://github.com/apache/cordova-docs/pull/832#discussion_r196264799
 
 

 ##
 File path: www/_posts/2018-06-15-common-release-2.2.4.md
 ##
 @@ -0,0 +1,23 @@
+---
+layout: post
+author:
+name: Chris Brody
+url: https://twitter.com/brodybits
+title:  "Cordova-Common Release"
+categories: news
+tags: release tools
+---
+
+We are happy to announce that `cordova-common 2.2.4` has been released. This 
is one of the libraries used behind-the-scenes by nearly all of the Cordova 
tooling and provides utilities for dealing with things like config.xml parsing.
+
+## Release Highlights
+
+The purpose of this release is to resolve issues with dependencies on 
cordova-ios@4. Here are the major changes:
+
+* Revert change to update dependencies in package.json (needed to resolve 
issues with cordova-ios@4)
+* Revert change to use strip-bom package to strip BOM
+* Continue to use plist@^3.0.1 in package.json
 
 Review comment:
   The end result is a lack of change to this dependency. Most other 
dependencies would be affected (changed) by the the revert. That is why I said 
"continue to use plist@^3.0.1". Confusing enough?
   
   I think (hope) that you understand what actually happened in this patch 
release, very open to suggestions if we can improve the working somehow.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-common patch release June 2018
> --
>
> Key: CB-14138
> URL: https://issues.apache.org/jira/browse/CB-14138
> Project: Apache Cordova
>  Issue Type: Task
>  Components: cordova-common
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> A new cordova-common patch release is needed to deliver a single 
> cordova-common package version with updated plist@3 dep, working on 
> cordova-ios as well as cordova-android, cordova-windows, cordova-osx, 
> cordova-lib, cordova-cli, etc.
> More detailed discussion will be in the GH pull request.
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md
>  (with some minor adjustments)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14138) cordova-common patch release June 2018

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516489#comment-16516489
 ] 

ASF GitHub Bot commented on CB-14138:
-

dpogue commented on a change in pull request #832: CB-14138: add 
cordova-common@2.2.4 blog post
URL: https://github.com/apache/cordova-docs/pull/832#discussion_r196263949
 
 

 ##
 File path: www/_posts/2018-06-15-common-release-2.2.4.md
 ##
 @@ -0,0 +1,23 @@
+---
+layout: post
+author:
+name: Chris Brody
+url: https://twitter.com/brodybits
+title:  "Cordova-Common Release"
+categories: news
+tags: release tools
+---
+
+We are happy to announce that `cordova-common 2.2.4` has been released. This 
is one of the libraries used behind-the-scenes by nearly all of the Cordova 
tooling and provides utilities for dealing with things like config.xml parsing.
+
+## Release Highlights
+
+The purpose of this release is to resolve issues with dependencies on 
cordova-ios@4. Here are the major changes:
+
+* Revert change to update dependencies in package.json (needed to resolve 
issues with cordova-ios@4)
+* Revert change to use strip-bom package to strip BOM
+* Continue to use plist@^3.0.1 in package.json
 
 Review comment:
   I'm not sure that "Continue to use plist@^3.0.1" is especially clear... is 
that a change to a dependency or a lack of a change to a dependency?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-common patch release June 2018
> --
>
> Key: CB-14138
> URL: https://issues.apache.org/jira/browse/CB-14138
> Project: Apache Cordova
>  Issue Type: Task
>  Components: cordova-common
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> A new cordova-common patch release is needed to deliver a single 
> cordova-common package version with updated plist@3 dep, working on 
> cordova-ios as well as cordova-android, cordova-windows, cordova-osx, 
> cordova-lib, cordova-cli, etc.
> More detailed discussion will be in the GH pull request.
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md
>  (with some minor adjustments)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-10967) IndexedDB API not properly exposed?

[Darryl Pogue (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darryl Pogue closed CB-10967.
-
Resolution: Not A Problem

The IndexedDB API is supported in both UIWebView and WKWebView as of iOS 10.

> IndexedDB API not properly exposed?
> ---
>
> Key: CB-10967
> URL: https://issues.apache.org/jira/browse/CB-10967
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-wkwebview-engine
>Affects Versions: 4.0.0
> Environment: Cordova CLI 6.x.x, Cordova-iOS 4.x.x
>Reporter: Brent Allen
>Priority: Major
>  Labels: triaged, wkwebview-known-issues
>
> So before cordova-ios 4.0.0 I was using 
> https://github.com/Telerik-Verified-Plugins/WKWebView.git as a workaround to 
> get the extra webkit apis/performance.
> Clearly not an ideal workaround since it requires a localhost origin. Making 
> several CORS and iFrame operations a major headache.
> So I need to update to the latest frameworks. And I was successful in doing 
> so with one catch.
> The webkit api for IndexDB is not exposed anymore. I am a little confused as 
> to how this could be since it was expose when using the workaround. The only 
> diff that I can find that seems to relate to webkit is this:
> From 'plugins/com.telerik.plugins.wkwebview/www/wkwebview.js'
> ```
> var origNativeFetchMessages = exec.nativeFetchMessages;
> exec.nativeFetchMessages = function() {
> var cmds = origNativeFetchMessages();
> cmds = JSON.parse(cmds);
> for(var i=0;i var cmd = cmds[i];
> if(cmd[1]==='WKWebView') continue;
> 
> window.webkit.messageHandlers.cordova.postMessage(cmd);
> }
> return '';
> };
> ```
> Which was also still available in cordova-ios@3.9.2(I think)
> I can't help but wonder if this has something to do with exposing the open 
> versions of the api(s). And if so was this supposed to be re-implemented 
> using the latest patterns?
> I am using mWater/minimongo which relies on this api. I already opened an 
> issue on that repo. But I am not optimistic that it will be addressed there 
> since the api hasn't technically changed as far as I can tell. It is just 
> being hidden by the webview and the cordova platform is no longer exposing it 
> manually.
> Any advice would be greatly appreciated. I am hoping to avoid cloning the 
> minimongo repo. Since I am not even sure the apples implementation will work 
> as I have yet to find any documentation on it.
> I am also concerned that this may have implications for other webkit apis 
> that I have yet to discover as broken in this context.
> Thanks in advance for any help.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-12886) white area where status bar is in iOS 11

[Darryl Pogue (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darryl Pogue reassigned CB-12886:
-

Assignee: Darryl Pogue

> white area where status bar is in iOS 11
> 
>
> Key: CB-12886
> URL: https://issues.apache.org/jira/browse/CB-12886
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
> Environment: iOS 11 beta 1
>Reporter: Shazron Abdullah
>Assignee: Darryl Pogue
>Priority: Major
>  Labels: backlog, ios11
> Fix For: cordova-ios@5.0.0
>
> Attachments: ios11.png, screenshot-1.png, screenshot-2.png, 
> screenshot-3.png, screenshot-4.png, screenshot-5.png, screenshot-6.png
>
>
> See attached screenshot. Using WKWebView plugin, new app.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12886) white area where status bar is in iOS 11

[Darryl Pogue (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516477#comment-16516477
 ] 

Darryl Pogue commented on CB-12886:
---

I have new information to add to this bug, and to reiterate it is *not* a 
Cordova bug. Let me present 3 scenarios:
 * {{viewport-fit=auto}} and CSS {{height: 100%}} on the body element:
*UIWebView:* The webview is the height of the device screen, minus the unsafe 
area, offset at the top by the unsafe area.
*WKWebView:* The webview is the height of the device screen, minus the unsafe 
area, offset at the top by the unsafe area.


 * {{viewport-fit=cover}} and CSS {{height: 100%}} on the body element:
*UIWebView:* The webview is the height of the device screen.
*WKWebView:* The webview is the height of the safe area, showing a gap at the 
bottom.


 * {{viewport-fit=cover}} and CSS {{height: 100vh}} on the body element:
*UIWebView:* The webview is the height of the device screen.
*WKWebView:* The webview is the height of the device screen.

 

I have a PR to submit to make changes to the cordova-app-hello-world template 
to address this issue there, but the correct fix is to change {{100%}} to 
{{100vh}} on the html or body elements in applications that are affected by 
this.

> white area where status bar is in iOS 11
> 
>
> Key: CB-12886
> URL: https://issues.apache.org/jira/browse/CB-12886
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
> Environment: iOS 11 beta 1
>Reporter: Shazron Abdullah
>Priority: Major
>  Labels: backlog, ios11
> Fix For: cordova-ios@5.0.0
>
> Attachments: ios11.png, screenshot-1.png, screenshot-2.png, 
> screenshot-3.png, screenshot-4.png, screenshot-5.png, screenshot-6.png
>
>
> See attached screenshot. Using WKWebView plugin, new app.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14144) BackButton Event Listeners do not fire on Android API 23 or below

[altShiftDev (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516082#comment-16516082
 ] 

altShiftDev commented on CB-14144:
--

Android API 24 is stable. The bug is found in versions 23 and below.

> BackButton Event Listeners do not fire on Android API 23 or below
> -
>
> Key: CB-14144
> URL: https://issues.apache.org/jira/browse/CB-14144
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: Using Android Studio emulators Galaxy, Pixel, Nexus 5... 
> all exhibit this behaviour. 
> Quasar Framework is building my project a long with webpack but I've no 
> reason to suspect Quasar as the cause, they only register a single 
> eventListener for backbutton and I've manually gone in and edited the source 
> code for this listener and it never fires leading me to believe the problem 
> is with Cordova.
>Reporter: altShiftDev
>Assignee: Joe Bowser
>Priority: Blocker
>
> App exits immediately on back button press without ever firing the 
> eventListener designed to capture and reroute it.
> There is nothing wrong with my eventListener code, it's been tested on Api 25 
> and higher and is very stable:
> `document.addEventListener('backbutton', this.onBackButton, false)`
> I have not yet tested to confirm if API 24 has this bug or not.
> This affects many of my users, including myself as I've got a phone running 
> Android at these versions. The app is completely killed with every tap of the 
> back button (new launches of the app cold boot with splashscreen) making it 
> impossible to properly navigate the app: closing modals, moving backwards in 
> operations, etc...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-14144) BackButton Event Listeners do not fire on Android API 23 or below

[altShiftDev (JIRA)]

altShiftDev created CB-14144:


 Summary: BackButton Event Listeners do not fire on Android API 23 
or below
 Key: CB-14144
 URL: https://issues.apache.org/jira/browse/CB-14144
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-android
Affects Versions: cordova-android-7.0.0
 Environment: Using Android Studio emulators Galaxy, Pixel, Nexus 5... 
all exhibit this behaviour. 

Quasar Framework is building my project a long with webpack but I've no reason 
to suspect Quasar as the cause, they only register a single eventListener for 
backbutton and I've manually gone in and edited the source code for this 
listener and it never fires leading me to believe the problem is with Cordova.
Reporter: altShiftDev
Assignee: Joe Bowser


App exits immediately on back button press without ever firing the 
eventListener designed to capture and reroute it.

There is nothing wrong with my eventListener code, it's been tested on Api 25 
and higher and is very stable:
`document.addEventListener('backbutton', this.onBackButton, false)`

I have not yet tested to confirm if API 24 has this bug or not.

This affects many of my users, including myself as I've got a phone running 
Android at these versions. The app is completely killed with every tap of the 
back button (new launches of the app cold boot with splashscreen) making it 
impossible to properly navigate the app: closing modals, moving backwards in 
operations, etc...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-14138) cordova-common patch release June 2018

[Chris Brody (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Brody reassigned CB-14138:


Assignee: Chris Brody

> cordova-common patch release June 2018
> --
>
> Key: CB-14138
> URL: https://issues.apache.org/jira/browse/CB-14138
> Project: Apache Cordova
>  Issue Type: Task
>  Components: cordova-common
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> A new cordova-common patch release is needed to deliver a single 
> cordova-common package version with updated plist@3 dep, working on 
> cordova-ios as well as cordova-android, cordova-windows, cordova-osx, 
> cordova-lib, cordova-cli, etc.
> More detailed discussion will be in the GH pull request.
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md
>  (with some minor adjustments)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-14143) allow-navigation isn't taking precedence over allow-intent on iOS

[Pablo Cantero (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pablo Cantero updated CB-14143:
---
Description: 
I generated an iOS and Android Pollyfill for my PWA app with 
[PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
I'm running into an issue with the iOS one.

I want external links to open in the external browser, so I added this 
`allow-intent`:
{code:xml}
http://*/*"; />
https://*/*"; />{code}
This worked fine, if I click on any external link (*not-under-my-domain.com*), 
it opens in the external browser.

For opening *my-domain.com* within the app, I added

 
{code:xml}
 
{code}
{{}}According to the docs, `allow-navigation` should take precedence over 
`allow-intent`, but it does not seem to be working.

My app first page opens fine within the app, but then if I click on any link 
*/other-page*, it opens in the external browser, then if I remove the 
`allow-intent`, when I click on any external link (*not-under-my-domain.com*), 
it gives the error:

 
{code}
Internal navigation rejected -  not set for url='...
{code}
I would like to have any link not defined in `allow-navigation` to open in the 
external browser, and all others (under *my-domain.com*) within the app.

Any ideas?

  was:
I generated an iOS and Android Pollyfill for my PWA app with 
[PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
I'm running into an issue with the iOS one.

I want external links to open in the external browser, so I added this 
`allow-intent`:
{code:java}
http://*/*"; />
 https://*/*"; />{code}
This worked fine, if I click on any external link (*not-under-my-domain.com*), 
it opens in the external browser.

For opening *my-domain.com* within the app, I added

 
{code:java}
 
{code}
{{}}According to the docs, `allow-navigation` should take precedence over 
`allow-intent`, but it does not seem to be working.

My app first page opens fine within the app, but then if I click on any link 
*/other-page*, it opens in the external browser, then if I remove the 
`allow-intent`, when I click on any external link (*not-under-my-domain.com*), 
it gives the error:

 
{code:java}
Internal navigation rejected -  not set for url='...
{code}
I would like to have any link not defined in `allow-navigation` to open in the 
external browser, and all others (under **my-domain.com**) within the app.

Any ideas?


> allow-navigation isn't taking precedence over allow-intent on iOS
> -
>
> Key: CB-14143
> URL: https://issues.apache.org/jira/browse/CB-14143
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-whitelist
> Environment: cordova-plugin-whitelist version 1.3.3
>Reporter: Pablo Cantero
>Priority: Major
>
> I generated an iOS and Android Pollyfill for my PWA app with 
> [PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
> I'm running into an issue with the iOS one.
> I want external links to open in the external browser, so I added this 
> `allow-intent`:
> {code:xml}
> http://*/*"; />
> https://*/*"; />{code}
> This worked fine, if I click on any external link 
> (*not-under-my-domain.com*), it opens in the external browser.
> For opening *my-domain.com* within the app, I added
>  
> {code:xml}
>  
> {code}
> {{}}According to the docs, `allow-navigation` should take precedence over 
> `allow-intent`, but it does not seem to be working.
> My app first page opens fine within the app, but then if I click on any link 
> */other-page*, it opens in the external browser, then if I remove the 
> `allow-intent`, when I click on any external link 
> (*not-under-my-domain.com*), it gives the error:
>  
> {code}
> Internal navigation rejected -  not set for url='...
> {code}
> I would like to have any link not defined in `allow-navigation` to open in 
> the external browser, and all others (under *my-domain.com*) within the app.
> Any ideas?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-14143) allow-navigation isn't taking precedence over allow-intent on iOS

[Pablo Cantero (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pablo Cantero updated CB-14143:
---
Description: 
I generated an iOS and Android Pollyfill for my PWA app with 
[PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
I'm running into an issue with the iOS one.

I want external links to open in the external browser, so I added this 
`allow-intent`:
{code:java}
http://*/*"; />
 https://*/*"; />{code}
This worked fine, if I click on any external link 
(**not-under-my-domain.com**), it opens in the external browser.

For opening **my-domain.com** within the app, I added

 
{code:java}
 
{code}
{{}}According to the docs, `allow-navigation` should take precedence over 
`allow-intent`, but it does not seem to be working.

My app first page opens fine within the app, but then if I click on any link 
*/other-page*, it opens in the external browser, then if I remove the 
`allow-intent`, when I click on any external link (*not-under-my-domain.com*), 
it gives the error:

 
{code:java}
Internal navigation rejected -  not set for url='...
{code}
I would like to have any link not defined in `allow-navigation` to open in the 
external browser, and all others (under **my-domain.com**) within the app.

Any ideas?

  was:
I generated an iOS and Android Pollyfill for my PWA app with 
[PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
I'm running into an issue with the iOS one.

I want external links to open in the external browser, so I added this 
`allow-intent`:
{code:java}
http://*/*"; />
 https://*/*"; />{code}
This worked fine, if I click on any external link 
(**not-under-my-domain.com**), it opens in the external browser.

For opening **my-domain.com** within the app, I added

 
{code:java}
 
{code}
{{}}According to the docs, `allow-navigation` should take precedence over 
`allow-intent`, but it does not seem to be working.

My app first page opens fine within the app, but then if I click on any link 
*/other-page*, it opens in the external browser, then if I remove the 
`allow-intent`, when I click on any external link 
(**not-under-my-domain.com**), it gives the error:

 
{code:java}
Internal navigation rejected -  not set for url='...
{code}
I would like to have any link not defined in `allow-navigation` to open in the 
external browser, and all others (under **my-domain.com**) within the app.

Any ideas?


> allow-navigation isn't taking precedence over allow-intent on iOS
> -
>
> Key: CB-14143
> URL: https://issues.apache.org/jira/browse/CB-14143
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-whitelist
> Environment: cordova-plugin-whitelist version 1.3.3
>Reporter: Pablo Cantero
>Priority: Major
>
> I generated an iOS and Android Pollyfill for my PWA app with 
> [PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
> I'm running into an issue with the iOS one.
> I want external links to open in the external browser, so I added this 
> `allow-intent`:
> {code:java}
> http://*/*"; />
>  https://*/*"; />{code}
> This worked fine, if I click on any external link 
> (**not-under-my-domain.com**), it opens in the external browser.
> For opening **my-domain.com** within the app, I added
>  
> {code:java}
>  
> {code}
> {{}}According to the docs, `allow-navigation` should take precedence over 
> `allow-intent`, but it does not seem to be working.
> My app first page opens fine within the app, but then if I click on any link 
> */other-page*, it opens in the external browser, then if I remove the 
> `allow-intent`, when I click on any external link 
> (*not-under-my-domain.com*), it gives the error:
>  
> {code:java}
> Internal navigation rejected -  not set for url='...
> {code}
> I would like to have any link not defined in `allow-navigation` to open in 
> the external browser, and all others (under **my-domain.com**) within the app.
> Any ideas?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-14143) allow-navigation isn't taking precedence over allow-intent on iOS

[Pablo Cantero (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pablo Cantero updated CB-14143:
---
Description: 
I generated an iOS and Android Pollyfill for my PWA app with 
[PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
I'm running into an issue with the iOS one.

I want external links to open in the external browser, so I added this 
`allow-intent`:
{code:java}
http://*/*"; />
 https://*/*"; />{code}
This worked fine, if I click on any external link (*not-under-my-domain.com*), 
it opens in the external browser.

For opening *my-domain.com* within the app, I added

 
{code:java}
 
{code}
{{}}According to the docs, `allow-navigation` should take precedence over 
`allow-intent`, but it does not seem to be working.

My app first page opens fine within the app, but then if I click on any link 
*/other-page*, it opens in the external browser, then if I remove the 
`allow-intent`, when I click on any external link (*not-under-my-domain.com*), 
it gives the error:

 
{code:java}
Internal navigation rejected -  not set for url='...
{code}
I would like to have any link not defined in `allow-navigation` to open in the 
external browser, and all others (under **my-domain.com**) within the app.

Any ideas?

  was:
I generated an iOS and Android Pollyfill for my PWA app with 
[PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
I'm running into an issue with the iOS one.

I want external links to open in the external browser, so I added this 
`allow-intent`:
{code:java}
http://*/*"; />
 https://*/*"; />{code}
This worked fine, if I click on any external link 
(**not-under-my-domain.com**), it opens in the external browser.

For opening **my-domain.com** within the app, I added

 
{code:java}
 
{code}
{{}}According to the docs, `allow-navigation` should take precedence over 
`allow-intent`, but it does not seem to be working.

My app first page opens fine within the app, but then if I click on any link 
*/other-page*, it opens in the external browser, then if I remove the 
`allow-intent`, when I click on any external link (*not-under-my-domain.com*), 
it gives the error:

 
{code:java}
Internal navigation rejected -  not set for url='...
{code}
I would like to have any link not defined in `allow-navigation` to open in the 
external browser, and all others (under **my-domain.com**) within the app.

Any ideas?


> allow-navigation isn't taking precedence over allow-intent on iOS
> -
>
> Key: CB-14143
> URL: https://issues.apache.org/jira/browse/CB-14143
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-whitelist
> Environment: cordova-plugin-whitelist version 1.3.3
>Reporter: Pablo Cantero
>Priority: Major
>
> I generated an iOS and Android Pollyfill for my PWA app with 
> [PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
> I'm running into an issue with the iOS one.
> I want external links to open in the external browser, so I added this 
> `allow-intent`:
> {code:java}
> http://*/*"; />
>  https://*/*"; />{code}
> This worked fine, if I click on any external link 
> (*not-under-my-domain.com*), it opens in the external browser.
> For opening *my-domain.com* within the app, I added
>  
> {code:java}
>  
> {code}
> {{}}According to the docs, `allow-navigation` should take precedence over 
> `allow-intent`, but it does not seem to be working.
> My app first page opens fine within the app, but then if I click on any link 
> */other-page*, it opens in the external browser, then if I remove the 
> `allow-intent`, when I click on any external link 
> (*not-under-my-domain.com*), it gives the error:
>  
> {code:java}
> Internal navigation rejected -  not set for url='...
> {code}
> I would like to have any link not defined in `allow-navigation` to open in 
> the external browser, and all others (under **my-domain.com**) within the app.
> Any ideas?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-14143) allow-navigation isn't taking precedence over allow-intent on iOS

[Pablo Cantero (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pablo Cantero updated CB-14143:
---
Description: 
I generated an iOS and Android Pollyfill for my PWA app with 
[PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
I'm running into an issue with the iOS one.

I want external links to open in the external browser, so I added this 
`allow-intent`:
{code:java}
http://*/*"; />
 https://*/*"; />{code}
This worked fine, if I click on any external link 
(**not-under-my-domain.com**), it opens in the external browser.

For opening **my-domain.com** within the app, I added

 
{code:java}
 
{code}
{{}}According to the docs, `allow-navigation` should take precedence over 
`allow-intent`, but it does not seem to be working.

My app first page opens fine within the app, but then if I click on any link 
*/other-page*, it opens in the external browser, then if I remove the 
`allow-intent`, when I click on any external link 
(**not-under-my-domain.com**), it gives the error:

 
{code:java}
Internal navigation rejected -  not set for url='...
{code}
I would like to have any link not defined in `allow-navigation` to open in the 
external browser, and all others (under **my-domain.com**) within the app.

Any ideas?

  was:
I generated an iOS and Android Pollyfill for my PWA app with 
[PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
I'm running into an issue with the iOS one.

I want external links to open in the external browser, so I added this 
`allow-intent`:
{code:java}
http://*/*"; />
 https://*/*"; />{code}
This worked fine, if I click on any external link 
(**not-under-my-domain.com**), it opens in the external browser.

For opening **my-domain.com** within the app, I added

 
{code:java}
 
{code}
{{}}According to the docs, `allow-navigation` should take precedence over 
`allow-intent`, but it does not seem to be working.

My app first page opens fine within the app, but then if I click on any link 
**/other-page**, it opens in the external browser, then if I remove the 
`allow-intent`, when I click on any external link 
(**not-under-my-domain.com**), it gives the error:

 
{code:java}
Internal navigation rejected -  not set for url='...
{code}
I would like to have any link not defined in `allow-navigation` to open in the 
external browser, and all others (under **my-domain.com**) within the app.

Any ideas?


> allow-navigation isn't taking precedence over allow-intent on iOS
> -
>
> Key: CB-14143
> URL: https://issues.apache.org/jira/browse/CB-14143
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-whitelist
> Environment: cordova-plugin-whitelist version 1.3.3
>Reporter: Pablo Cantero
>Priority: Major
>
> I generated an iOS and Android Pollyfill for my PWA app with 
> [PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
> I'm running into an issue with the iOS one.
> I want external links to open in the external browser, so I added this 
> `allow-intent`:
> {code:java}
> http://*/*"; />
>  https://*/*"; />{code}
> This worked fine, if I click on any external link 
> (**not-under-my-domain.com**), it opens in the external browser.
> For opening **my-domain.com** within the app, I added
>  
> {code:java}
>  
> {code}
> {{}}According to the docs, `allow-navigation` should take precedence over 
> `allow-intent`, but it does not seem to be working.
> My app first page opens fine within the app, but then if I click on any link 
> */other-page*, it opens in the external browser, then if I remove the 
> `allow-intent`, when I click on any external link 
> (**not-under-my-domain.com**), it gives the error:
>  
> {code:java}
> Internal navigation rejected -  not set for url='...
> {code}
> I would like to have any link not defined in `allow-navigation` to open in 
> the external browser, and all others (under **my-domain.com**) within the app.
> Any ideas?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-14143) allow-navigation isn't taking precedence over allow-intent on iOS

[Pablo Cantero (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pablo Cantero updated CB-14143:
---
Description: 
I generated an iOS and Android Pollyfill for my PWA app with 
[PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
I'm running into an issue with the iOS one.

I want external links to open in the external browser, so I added this 
`allow-intent`:
{code:java}
http://*/*"; />
 https://*/*"; />{code}
This worked fine, if I click on any external link 
(**not-under-my-domain.com**), it opens in the external browser.

For opening **my-domain.com** within the app, I added

 
{code:java}
 
{code}
{{}}According to the docs, `allow-navigation` should take precedence over 
`allow-intent`, but it does not seem to be working.

My app first page opens fine within the app, but then if I click on any link 
**/other-page**, it opens in the external browser, then if I remove the 
`allow-intent`, when I click on any external link 
(**not-under-my-domain.com**), it gives the error:

 
{code:java}
Internal navigation rejected -  not set for url='...
{code}
I would like to have any link not defined in `allow-navigation` to open in the 
external browser, and all others (under **my-domain.com**) within the app.

Any ideas?

  was:
I generated an iOS and Android Pollyfill for my PWA app with 
[PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
I'm running into an issue with the iOS one.

I want external links to open in the external browser, so I added this 
`allow-intent`:

```

http://*/*"; />
 https://*/*"; />

```

This worked fine, if I click on any external link 
(**not-under-my-domain.com**), it opens in the external browser.

For opening **my-domain.com** within the app, I added

{{}}

According to the docs, `allow-navigation` should take precedence over 
`allow-intent`, but it does not seem to be working.

My app first page opens fine within the app, but then if I click on any link 
**/other-page**, it opens in the external browser, then if I remove the 
`allow-intent`, when I click on any external link 
(**not-under-my-domain.com**), it gives the error:

Internal navigation rejected -  not set for url='...

I would like to have any link not defined in `allow-navigation` to open in the 
external browser, and all others (under **my-domain.com**) within the app.

Any ideas?


> allow-navigation isn't taking precedence over allow-intent on iOS
> -
>
> Key: CB-14143
> URL: https://issues.apache.org/jira/browse/CB-14143
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-whitelist
> Environment: cordova-plugin-whitelist version 1.3.3
>Reporter: Pablo Cantero
>Priority: Major
>
> I generated an iOS and Android Pollyfill for my PWA app with 
> [PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
> I'm running into an issue with the iOS one.
> I want external links to open in the external browser, so I added this 
> `allow-intent`:
> {code:java}
> http://*/*"; />
>  https://*/*"; />{code}
> This worked fine, if I click on any external link 
> (**not-under-my-domain.com**), it opens in the external browser.
> For opening **my-domain.com** within the app, I added
>  
> {code:java}
>  
> {code}
> {{}}According to the docs, `allow-navigation` should take precedence over 
> `allow-intent`, but it does not seem to be working.
> My app first page opens fine within the app, but then if I click on any link 
> **/other-page**, it opens in the external browser, then if I remove the 
> `allow-intent`, when I click on any external link 
> (**not-under-my-domain.com**), it gives the error:
>  
> {code:java}
> Internal navigation rejected -  not set for url='...
> {code}
> I would like to have any link not defined in `allow-navigation` to open in 
> the external browser, and all others (under **my-domain.com**) within the app.
> Any ideas?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-14143) allow-navigation isn't taking precedence over allow-intent on iOS

[Pablo Cantero (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pablo Cantero updated CB-14143:
---
Description: 
I generated an iOS and Android Pollyfill for my PWA app with 
[PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
I'm running into an issue with the iOS one.

I want external links to open in the external browser, so I added this 
`allow-intent`:

```

http://*/*"; />
 https://*/*"; />

```

This worked fine, if I click on any external link 
(**not-under-my-domain.com**), it opens in the external browser.

For opening **my-domain.com** within the app, I added

{{}}

According to the docs, `allow-navigation` should take precedence over 
`allow-intent`, but it does not seem to be working.

My app first page opens fine within the app, but then if I click on any link 
**/other-page**, it opens in the external browser, then if I remove the 
`allow-intent`, when I click on any external link 
(**not-under-my-domain.com**), it gives the error:

Internal navigation rejected -  not set for url='...

I would like to have any link not defined in `allow-navigation` to open in the 
external browser, and all others (under **my-domain.com**) within the app.

Any ideas?

  was:
I generated an iOS and Android Pollyfill for my PWA app with 
[PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
I'm running into an issue with the iOS one.

I want external links to open in the external browser, so I added this 
`allow-intent`:

{{http://***"; />}}
 {{https://***"; />}}

This worked fine, if I click on any external link 
(**not-under-my-domain.com**), it opens in the external browser.

For opening **my-domain.com** within the app, I added

{{}}

According to the docs, `allow-navigation` should take precedence over 
`allow-intent`, but it does not seem to be working.

My app first page opens fine within the app, but then if I click on any link 
**/other-page**, it opens in the external browser, then if I remove the 
`allow-intent`, when I click on any external link 
(**not-under-my-domain.com**), it gives the error:

Internal navigation rejected -  not set for url='...

I would like to have any link not defined in `allow-navigation` to open in the 
external browser, and all others (under **my-domain.com**) within the app.

Any ideas?


> allow-navigation isn't taking precedence over allow-intent on iOS
> -
>
> Key: CB-14143
> URL: https://issues.apache.org/jira/browse/CB-14143
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-whitelist
> Environment: cordova-plugin-whitelist version 1.3.3
>Reporter: Pablo Cantero
>Priority: Major
>
> I generated an iOS and Android Pollyfill for my PWA app with 
> [PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
> I'm running into an issue with the iOS one.
> I want external links to open in the external browser, so I added this 
> `allow-intent`:
> ```
> http://*/*"; />
>  https://*/*"; />
> ```
> This worked fine, if I click on any external link 
> (**not-under-my-domain.com**), it opens in the external browser.
> For opening **my-domain.com** within the app, I added
> {{}}
> According to the docs, `allow-navigation` should take precedence over 
> `allow-intent`, but it does not seem to be working.
> My app first page opens fine within the app, but then if I click on any link 
> **/other-page**, it opens in the external browser, then if I remove the 
> `allow-intent`, when I click on any external link 
> (**not-under-my-domain.com**), it gives the error:
> Internal navigation rejected -  not set for url='...
> I would like to have any link not defined in `allow-navigation` to open in 
> the external browser, and all others (under **my-domain.com**) within the app.
> Any ideas?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-14143) allow-navigation isn't taking precedence over allow-intent on iOS

[Pablo Cantero (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pablo Cantero updated CB-14143:
---
Description: 
I generated an iOS and Android Pollyfill for my PWA app with 
[PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
I'm running into an issue with the iOS one.

I want external links to open in the external browser, so I added this 
`allow-intent`:

{{http://***"; />}}
 {{https://***"; />}}

This worked fine, if I click on any external link 
(**not-under-my-domain.com**), it opens in the external browser.

For opening **my-domain.com** within the app, I added

{{}}

According to the docs, `allow-navigation` should take precedence over 
`allow-intent`, but it does not seem to be working.

My app first page opens fine within the app, but then if I click on any link 
**/other-page**, it opens in the external browser, then if I remove the 
`allow-intent`, when I click on any external link 
(**not-under-my-domain.com**), it gives the error:

Internal navigation rejected -  not set for url='...

I would like to have any link not defined in `allow-navigation` to open in the 
external browser, and all others (under **my-domain.com**) within the app.

Any ideas?

  was:
I generated an iOS and Android Pollyfill for my PWA app with 
[PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
I'm running into an issue with the iOS one.

I want external links to open in the external browser, so I added this 
`allow-intent`:

{{http://*/*"; />}}
{{https://*/*"; />}}

This worked fine, if I click on any external link 
(**not-under-my-domain.com**), it opens in the external browser.

For opening **my-domain.com** within the app, I added

{{}}

According to the docs, `allow-navigation` should take precedence over 
`allow-intent`, but it does not seem to be working.

My app first page opens fine within the app, but then if I click on any link 
**/other-page**, it opens in the external browser, then if I remove the 
`allow-intent`, when I click on any external link 
(**not-under-my-domain.com**), it gives the error:

Internal navigation rejected -  not set for url='...

I would like to have any link not defined in `allow-navigation` to open in the 
external browser, and all others (under **my-domain.com**) within the app.

Any ideas?


> allow-navigation isn't taking precedence over allow-intent on iOS
> -
>
> Key: CB-14143
> URL: https://issues.apache.org/jira/browse/CB-14143
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-whitelist
> Environment: cordova-plugin-whitelist version 1.3.3
>Reporter: Pablo Cantero
>Priority: Major
>
> I generated an iOS and Android Pollyfill for my PWA app with 
> [PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
> I'm running into an issue with the iOS one.
> I want external links to open in the external browser, so I added this 
> `allow-intent`:
> {{http://***"; />}}
>  {{https://***"; />}}
> This worked fine, if I click on any external link 
> (**not-under-my-domain.com**), it opens in the external browser.
> For opening **my-domain.com** within the app, I added
> {{}}
> According to the docs, `allow-navigation` should take precedence over 
> `allow-intent`, but it does not seem to be working.
> My app first page opens fine within the app, but then if I click on any link 
> **/other-page**, it opens in the external browser, then if I remove the 
> `allow-intent`, when I click on any external link 
> (**not-under-my-domain.com**), it gives the error:
> Internal navigation rejected -  not set for url='...
> I would like to have any link not defined in `allow-navigation` to open in 
> the external browser, and all others (under **my-domain.com**) within the app.
> Any ideas?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-14143) allow-navigation isn't taking precedence over allow-intent on iOS

[Pablo Cantero (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pablo Cantero updated CB-14143:
---
Description: 
I generated an iOS and Android Pollyfill for my PWA app with 
[PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
I'm running into an issue with the iOS one.

I want external links to open in the external browser, so I added this 
`allow-intent`:

{{http://*/*"; />}}
{{https://*/*"; />}}

This worked fine, if I click on any external link 
(**not-under-my-domain.com**), it opens in the external browser.

For opening **my-domain.com** within the app, I added

{{}}

According to the docs, `allow-navigation` should take precedence over 
`allow-intent`, but it does not seem to be working.

My app first page opens fine within the app, but then if I click on any link 
**/other-page**, it opens in the external browser, then if I remove the 
`allow-intent`, when I click on any external link 
(**not-under-my-domain.com**), it gives the error:

Internal navigation rejected -  not set for url='...

I would like to have any link not defined in `allow-navigation` to open in the 
external browser, and all others (under **my-domain.com**) within the app.

Any ideas?

  was:
I generated an iOS and Android Pollyfill for my PWA app with 
[PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
I'm running into an issue with the iOS one.

I want external links to open in the external browser, so I added this 
`allow-intent`:

{{http://*/*"; />}}
{{ https://*/*"; />}}

This worked fine, if I click on any external link 
(**not-under-my-domain.com**), it opens in the external browser.

For opening **my-domain.com** within the app, I added

{{}}

According to the docs, `allow-navigation` should take precedence over 
`allow-intent`, but it does not seem to be working.

My app first page opens fine within the app, but then if I click on any link 
**/other-page**, it opens in the external browser, then if I remove the 
`allow-intent`, when I click on any external link 
(**not-under-my-domain.com**), it gives the error:

Internal navigation rejected -  not set for url='...


I would like to have any link not defined in `allow-navigation` to open in the 
external browser, and all others (under **my-domain.com**) within the app.

Any ideas?


> allow-navigation isn't taking precedence over allow-intent on iOS
> -
>
> Key: CB-14143
> URL: https://issues.apache.org/jira/browse/CB-14143
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-whitelist
> Environment: cordova-plugin-whitelist version 1.3.3
>Reporter: Pablo Cantero
>Priority: Major
>
> I generated an iOS and Android Pollyfill for my PWA app with 
> [PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
> I'm running into an issue with the iOS one.
> I want external links to open in the external browser, so I added this 
> `allow-intent`:
> {{http://*/*"; />}}
> {{https://*/*"; />}}
> This worked fine, if I click on any external link 
> (**not-under-my-domain.com**), it opens in the external browser.
> For opening **my-domain.com** within the app, I added
> {{}}
> According to the docs, `allow-navigation` should take precedence over 
> `allow-intent`, but it does not seem to be working.
> My app first page opens fine within the app, but then if I click on any link 
> **/other-page**, it opens in the external browser, then if I remove the 
> `allow-intent`, when I click on any external link 
> (**not-under-my-domain.com**), it gives the error:
> Internal navigation rejected -  not set for url='...
> I would like to have any link not defined in `allow-navigation` to open in 
> the external browser, and all others (under **my-domain.com**) within the app.
> Any ideas?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-14143) allow-navigation isn't taking precedence over allow-intent on iOS

[Pablo Cantero (JIRA)]

Pablo Cantero created CB-14143:
--

 Summary: allow-navigation isn't taking precedence over 
allow-intent on iOS
 Key: CB-14143
 URL: https://issues.apache.org/jira/browse/CB-14143
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-plugin-whitelist
 Environment: cordova-plugin-whitelist version 1.3.3
Reporter: Pablo Cantero


I generated an iOS and Android Pollyfill for my PWA app with 
[PWAbuilder|https://www.pwabuilder.com/]. It is working great on Android, but 
I'm running into an issue with the iOS one.

I want external links to open in the external browser, so I added this 
`allow-intent`:

{{http://*/*"; />}}
{{ https://*/*"; />}}

This worked fine, if I click on any external link 
(**not-under-my-domain.com**), it opens in the external browser.

For opening **my-domain.com** within the app, I added

{{}}

According to the docs, `allow-navigation` should take precedence over 
`allow-intent`, but it does not seem to be working.

My app first page opens fine within the app, but then if I click on any link 
**/other-page**, it opens in the external browser, then if I remove the 
`allow-intent`, when I click on any external link 
(**not-under-my-domain.com**), it gives the error:

Internal navigation rejected -  not set for url='...


I would like to have any link not defined in `allow-navigation` to open in the 
external browser, and all others (under **my-domain.com**) within the app.

Any ideas?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7949) Cli command/documentation for workflow with multiple versions of cordova

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515923#comment-16515923
 ] 

ASF GitHub Bot commented on CB-7949:


brodybits commented on issue #61: CB-7949 add cordova-local to tools release 
process
URL: https://github.com/apache/cordova-coho/pull/61#issuecomment-398102374
 
 
   > Why not use `npx cordova`?
   
   - extra typing
   - not everyone has `npx` (Node 6)
   
   I think the ideal solution would be to have an extremely lightweight CLI 
that uses scripts from local packages. Not sure how much the newer Node.js 
tooling works like this or not.
   
   Gotta say that I am starting to agree with your point. I do sometimes use 
`npx` to run local tooling that is not yet integrated with scripts in 
package.json. Closing in favor of your point.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cli command/documentation for workflow with multiple versions of cordova
> 
>
> Key: CB-7949
> URL: https://issues.apache.org/jira/browse/CB-7949
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-cli
>Reporter: Staci Cooper
>Assignee: Staci Cooper
>Priority: Minor
>
> Not sure if this is correctly categorized...
> Current suggested workflow when using multiple versions of cordova on the 
> same machine is described here: 
> http://www.mooreds.com/wordpress/archives/1379. Basically, use local 
> installations of cordova and then run cordova with 
> "./node_modules/cordova/bin/cordova", or a bunch of corresponding aliases.
> I want to add a command to the cli, something like 'cordova-local', which can 
> be run anywhere instead of 'cordova', and finds the closest local 
> installation of cordova in your directory's ancestors and passes its 
> arguments to it. Basically it would mirror the workflow of grunt-cli.
> There's also nothing in the official docs about this workflow. That blog post 
> was the only reference I could find.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7949) Cli command/documentation for workflow with multiple versions of cordova

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515924#comment-16515924
 ] 

ASF GitHub Bot commented on CB-7949:


brodybits closed pull request #61: CB-7949 add cordova-local to tools release 
process
URL: https://github.com/apache/cordova-coho/pull/61
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/tools-release-process.md b/docs/tools-release-process.md
index 4c2330a..09ca0f3 100644
--- a/docs/tools-release-process.md
+++ b/docs/tools-release-process.md
@@ -50,6 +50,7 @@ E.g.:
  - cli@
  - plugman@
  - cordova-js@
+ - cordova-local@
 
 
 ## Create JIRA issues
@@ -74,6 +75,7 @@ See if any dependencies are outdated
 (cd cordova-lib/cordova-lib && npm outdated --depth=0)
 (cd cordova-plugman && npm outdated --depth=0)
 (cd cordova-cli && npm outdated --depth=0)
+(cd cordova-utility/cordova-local && npm outdated --depth=0)
 
 Update them in each project's `pacakge.json` file. Make sure to run through 
the test section below for compatability issues. The `--depth=0` prevents from 
listing dependencies of dependencies. As of this writing, the following 
packages are behind and are not safe to upgrade:
  * semver - in latest versions of semver-node "^0.x.y" is always equivalent to 
"=0.x.y" (for major=0). This breaks some cordova engine compat checks. 
[Background](https://github.com/npm/npm/issues/5695#issuecomment-49765893).
@@ -95,6 +97,7 @@ Ensure license headers are present everywhere. For reference, 
see this [backgrou
 coho audit-license-headers -r cli | less
 coho audit-license-headers -r plugman | less
 coho audit-license-headers -r lib | less
+coho audit-license-headers -r utility | less
 
 Ensure all dependencies and subdependencies have Apache-compatible licenses
 
@@ -119,6 +122,7 @@ Ensure unit tests pass (plugman tests are included in lib):
 (cd cordova-lib/cordova-lib; npm test)
 (cd cordova-cli; npm test)
 (cd cordova-js; grunt test --platformVersion=3.7.0)
+(cd cordova-utility/cordova-local; npm test)
 
 Add a comment to the JIRA issue stating what you tested, and what the results 
were.
 
@@ -126,7 +130,7 @@ Add a comment to the JIRA issue stating what you tested, 
and what the results we
 
 Increase the version within package.json using SemVer, and remove the ''-dev'' 
suffix
 
-for l in cordova-lib/cordova-lib cordova-plugman cordova-cli cordova-js; 
do ( cd $l; v="$(grep '"version"' package.json | cut -d'"' -f4)"; if [[ $v = 
*-dev ]]; then v2="${v%-dev}"; echo "$l: Setting version to $v2"; sed -i '' -E 
's/version":.*/version": "'$v2'",/' package.json; fi) ; done
+for l in cordova-lib/cordova-lib cordova-plugman cordova-cli cordova-js 
cordova-utility/cordova-local; do ( cd $l; v="$(grep '"version"' package.json | 
cut -d'"' -f4)"; if [[ $v = *-dev ]]; then v2="${v%-dev}"; echo "$l: Setting 
version to $v2"; sed -i '' -E 's/version":.*/version": "'$v2'",/' package.json; 
fi) ; done
 
 If the changes merit it, manually bump the major / minor version instead of 
the micro. List the changes via:
 
@@ -138,14 +142,16 @@ If the changes merit it, manually bump the major / minor 
version instead of the
 
 ( cd cordova-js; git log --pretty=format:'* %s' --topo-order --no-merges 
$(git describe --tags --abbrev=0)..master | grep -v "Incremented plugin 
version" )
 
+( cd cordova-utility/cordova-local; git log --pretty=format:'* %s' 
--topo-order --no-merges $(git describe --tags --abbrev=0)..master | grep -v 
"Incremented plugin version" )
+
 Update each repo's RELEASENOTES.md file with changes
 
 # Add new heading to release notes with version and date
 DATE=$(date "+%h %d, %Y")
 
-for l in cordova-lib/cordova-lib cordova-plugman cordova-cli cordova-js; 
do ( cd $l; v="$(grep '"version"' package.json | cut -d'"' -f4)"; echo -e 
"\n### $v ($DATE)" >> RELEASENOTES.md; git log --pretty=format:'* %s' 
--topo-order --no-merges $(git describe --tags --abbrev=0)..master | grep -v 
"Incremented plugin version" >> RELEASENOTES.md); done
+for l in cordova-lib/cordova-lib cordova-plugman cordova-cli cordova-js 
cordova-utility/cordova-local; do ( cd $l; v="$(grep '"version"' package.json | 
cut -d'"' -f4)"; echo -e "\n### $v ($DATE)" >> RELEASENOTES.md; git log 
--pretty=format:'* %s' --topo-order --no-merges $(git describe --tags 
--abbrev=0)..master | grep -v "Incremented plugin version" >> RELEASENOTES.md); 
done
 # Then curate:
-vim cordova-lib/cordova-lib/RELEASENOTES.md cordova-cli/RELEASENOTES.md 
cordova-plugman/RELEASENOTES.md cordova-js/RELEASENOTES.md
+vim cordova-lib/cordova-lib/RELEASENOTES.md cordova-cli/RELEASENOT

[jira] [Commented] (CB-7949) Cli command/documentation for workflow with multiple versions of cordova

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515906#comment-16515906
 ] 

ASF GitHub Bot commented on CB-7949:


raphinesse commented on issue #61: CB-7949 add cordova-local to tools release 
process
URL: https://github.com/apache/cordova-coho/pull/61#issuecomment-39806
 
 
   Why not use `npx cordova`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cli command/documentation for workflow with multiple versions of cordova
> 
>
> Key: CB-7949
> URL: https://issues.apache.org/jira/browse/CB-7949
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-cli
>Reporter: Staci Cooper
>Assignee: Staci Cooper
>Priority: Minor
>
> Not sure if this is correctly categorized...
> Current suggested workflow when using multiple versions of cordova on the 
> same machine is described here: 
> http://www.mooreds.com/wordpress/archives/1379. Basically, use local 
> installations of cordova and then run cordova with 
> "./node_modules/cordova/bin/cordova", or a bunch of corresponding aliases.
> I want to add a command to the cli, something like 'cordova-local', which can 
> be run anywhere instead of 'cordova', and finds the closest local 
> installation of cordova in your directory's ancestors and passes its 
> arguments to it. Basically it would mirror the workflow of grunt-cli.
> There's also nothing in the official docs about this workflow. That blog post 
> was the only reference I could find.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7949) Cli command/documentation for workflow with multiple versions of cordova

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515738#comment-16515738
 ] 

ASF GitHub Bot commented on CB-7949:


brodybits commented on issue #61: CB-7949 add cordova-local to tools release 
process
URL: https://github.com/apache/cordova-coho/pull/61#issuecomment-398064956
 
 
   What a shame that nobody reviewed this wonderful contribution from 3 years 
ago, would like to revive it when I get some spare cycles. I just made a fork 
at  to be sure to preserve it.
   
   FYI I noticed that @stacic (Staci Cooper) is in 
 so we know that the needed CLA 
is in place.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cli command/documentation for workflow with multiple versions of cordova
> 
>
> Key: CB-7949
> URL: https://issues.apache.org/jira/browse/CB-7949
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-cli
>Reporter: Staci Cooper
>Assignee: Staci Cooper
>Priority: Minor
>
> Not sure if this is correctly categorized...
> Current suggested workflow when using multiple versions of cordova on the 
> same machine is described here: 
> http://www.mooreds.com/wordpress/archives/1379. Basically, use local 
> installations of cordova and then run cordova with 
> "./node_modules/cordova/bin/cordova", or a bunch of corresponding aliases.
> I want to add a command to the cli, something like 'cordova-local', which can 
> be run anywhere instead of 'cordova', and finds the closest local 
> installation of cordova in your directory's ancestors and passes its 
> arguments to it. Basically it would mirror the workflow of grunt-cli.
> There's also nothing in the official docs about this workflow. That blog post 
> was the only reference I could find.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-13784) Broken tests on cordova-plugin-media

[jcesarmobile (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-13784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-13784.
-
Resolution: Duplicate

Closing as duplicate of CB-14091, it's older but it has a PR, so keeping that 
one

> Broken tests on cordova-plugin-media
> 
>
> Key: CB-13784
> URL: https://issues.apache.org/jira/browse/CB-13784
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-paramedic, cordova-plugin-media
>Reporter: jcesarmobile
>Assignee: Jesse MacFadyen
>Priority: Major
>
> The tests of cordova-plugin-media for browser-safari and android are failing. 
> Other platforms are ok.
>  There are multiple specs failing
> See https://travis-ci.org/apache/cordova-plugin-media/builds/327034161 for 
> reference



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-13784) Broken tests on cordova-plugin-media

[jcesarmobile (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-13784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile updated CB-13784:
--
Description: 
The tests of cordova-plugin-media for browser-safari and android are failing. 
Other platforms are ok.
 There are multiple specs failing

See https://travis-ci.org/apache/cordova-plugin-media/builds/327034161 for 
reference

  was:
The tests of cordova-plugin-file for browser-safari and android are failing. 
Other platforms are ok.
 There are multiple specs failing

See https://travis-ci.org/apache/cordova-plugin-media/builds/327034161 for 
reference


> Broken tests on cordova-plugin-media
> 
>
> Key: CB-13784
> URL: https://issues.apache.org/jira/browse/CB-13784
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-paramedic, cordova-plugin-media
>Reporter: jcesarmobile
>Assignee: Jesse MacFadyen
>Priority: Major
>
> The tests of cordova-plugin-media for browser-safari and android are failing. 
> Other platforms are ok.
>  There are multiple specs failing
> See https://travis-ci.org/apache/cordova-plugin-media/builds/327034161 for 
> reference



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14142) Error when run command: cordova run android

[jcesarmobile (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515594#comment-16515594
 ] 

jcesarmobile commented on CB-14142:
---

what's the error?

> Error when run command: cordova run android
> ---
>
> Key: CB-14142
> URL: https://issues.apache.org/jira/browse/CB-14142
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: 7.0.0, 7.1.0
>Reporter: JOSE FREDERICO DE SOUZA SILVA
>Assignee: Joe Bowser
>Priority: Major
>
> When run command: cordova run android not started android emulator but if 
> android emulator already is started and run command works fine



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9366) Log error.stack when a call to a plugin throws an exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515512#comment-16515512
 ] 

ASF GitHub Bot commented on CB-9366:


purplecabbage commented on issue #118: CB-9366 Log error.stack as it helps with 
diagnosing the source of the…
URL: https://github.com/apache/cordova-js/pull/118#issuecomment-397989478
 
 
   I am okay if you want to merge it, my initial point of view was just that 
there are other ways of handling this, but it’s not a huge deal to me ...
   
   > On Jun 18, 2018, at 1:29 AM, Christopher J. Brody 
 wrote:
   > 
   > Looks like it would be really nice to have this enhancement, maybe for the 
next major release.
   > 
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub, or mute the thread.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Log error.stack when a call to a plugin throws an exception
> ---
>
> Key: CB-9366
> URL: https://issues.apache.org/jira/browse/CB-9366
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-js
>Affects Versions: Master
>Reporter: Nikhil Khandelwal
>Assignee: Nikhil Khandelwal
>Priority: Minor
>
> This can help in isolating the cause of the error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9366) Log error.stack when a call to a plugin throws an exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515488#comment-16515488
 ] 

ASF GitHub Bot commented on CB-9366:


brodybits commented on issue #118: CB-9366 Log error.stack as it helps with 
diagnosing the source of the…
URL: https://github.com/apache/cordova-js/pull/118#issuecomment-397979799
 
 
   Looks like it would be really nice to have this enhancement, maybe for the 
next major release.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Log error.stack when a call to a plugin throws an exception
> ---
>
> Key: CB-9366
> URL: https://issues.apache.org/jira/browse/CB-9366
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-js
>Affects Versions: Master
>Reporter: Nikhil Khandelwal
>Assignee: Nikhil Khandelwal
>Priority: Minor
>
> This can help in isolating the cause of the error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org