[jira] [Commented] (CB-14139) Can't run android commands with 32bit Java
[ https://issues.apache.org/jira/browse/CB-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525989#comment-16525989 ] ASF GitHub Bot commented on CB-14139: - raphinesse commented on issue #459: CB-14139 android: Add jvmargs flag for custom values URL: https://github.com/apache/cordova-android/pull/459#issuecomment-400930583 Couldn't we instead remove the default jvmargs setting and use one of the various other transparent methods of setting this? As in environment variables (per command) or Gradle properties. I'm just asking. New features are hard to get rid of, once added. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Can't run android commands with 32bit Java > -- > > Key: CB-14139 > URL: https://issues.apache.org/jira/browse/CB-14139 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 8.0.0 > Environment: Win 10 Pro x64 >Reporter: misterTi >Assignee: Joe Bowser >Priority: Blocker > > GradleBuilder.js has a buiit-in option org.gradle.jvmargs=---Xmx2048m on line > 59, which prevents it from running on 32bit Java. It always fails with VM > heap error. The workaround is to create an environment variable > __JAVA__OPTIONS=-Xmx512m, but this then affects the whole system. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14178) Add missing test coverage badges and fix broken link in cordova-status
[ https://issues.apache.org/jira/browse/CB-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Ellis updated CB-14178: - Description: *Goal of this ticket* * Fix a broken link in cordova-status * Add missing report badges to show test results and coverage in cordova-status * Request [https://apache.github.io/cordova-status/] to be rebuilt to reflect changes from this and last PR. *Missing Badges:* * cordova-common codecov.io report * cordova-docs travis-ci report *Broken Links:* * cordova-plugin-camera was:Remove the deprecated platforms and plugins from the `cordova-status` README.md to reflect the current supported components. > Add missing test coverage badges and fix broken link in cordova-status > -- > > Key: CB-14178 > URL: https://issues.apache.org/jira/browse/CB-14178 > Project: Apache Cordova > Issue Type: Task >Reporter: Bryan Ellis >Priority: Trivial > Labels: documentation > Original Estimate: 1h > Remaining Estimate: 1h > > *Goal of this ticket* > * Fix a broken link in cordova-status > * Add missing report badges to show test results and coverage in > cordova-status > * Request [https://apache.github.io/cordova-status/] to be rebuilt to > reflect changes from this and last PR. > *Missing Badges:* > * cordova-common codecov.io report > * cordova-docs travis-ci report > *Broken Links:* > * cordova-plugin-camera -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14178) Add missing test coverage badges and fix broken link in cordova-status
Bryan Ellis created CB-14178: Summary: Add missing test coverage badges and fix broken link in cordova-status Key: CB-14178 URL: https://issues.apache.org/jira/browse/CB-14178 Project: Apache Cordova Issue Type: Task Reporter: Bryan Ellis Remove the deprecated platforms and plugins from the `cordova-status` README.md to reflect the current supported components. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14167) User's current location is not correct
[
https://issues.apache.org/jira/browse/CB-14167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525928#comment-16525928
]
Sanjay Kumar commented on CB-14167:
---
[~jcesarmobile]
Code:
navigator.geolocation.watchPosition(
function(position) {
deviceCords = [position.coords.longitude,
position.coords.latitude];
Session.set('deviceLocation',deviceCords);
},
function(error) {
console.log('code: '+ error.code,'message: ' +
error.message);
},
{
enableHighAccuracy: true,
maximumAge: 0,
timeout: 1
}
);
Version:
cordova-plugin-geolocation@2.4.1
This issue is happening mainly on iPhone
> User's current location is not correct
> ---
>
> Key: CB-14167
> URL: https://issues.apache.org/jira/browse/CB-14167
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Sanjay Kumar
>Priority: Major
>
> We are using
> [https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-geolocation/]
> in our app. We are getting the user's current position using
> navigator.geolocation.getCurrentPosition and we are getting the correct
> location.
> Then we are using navigator.geolocation.watchPosition to get the user's
> updated location which is also working well mostly.
> Here is the issue - When the phone is not moving - we are getting different
> co-ordinates which are up to 500 meters away from the actual user location.
> If needed, I can share screenshots and code. Do let me know.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525923#comment-16525923 ] Ken Naito commented on CB-14166: I checked this issue on both Windows 10 1607 and Windows 10 1803. The results are same. Does anyone know this issue? > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14139) Can't run android commands with 32bit Java
[ https://issues.apache.org/jira/browse/CB-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525906#comment-16525906 ] ASF GitHub Bot commented on CB-14139: - erisu opened a new pull request #839: CB-14139 android: Add jvmargs flag for custom values URL: https://github.com/apache/cordova-docs/pull/839 ### Platforms affected Android ### What does this PR do? Updated docs to explain how to custom define the Gradle JVM memory settings. ### What testing has been done on this change? - Built the docs. ### Checklist - [X] Commit message follows the format: "GH-3232: (android) Fix bug with resolving file paths", where GH- is the GitHub issue ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Can't run android commands with 32bit Java > -- > > Key: CB-14139 > URL: https://issues.apache.org/jira/browse/CB-14139 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 8.0.0 > Environment: Win 10 Pro x64 >Reporter: misterTi >Assignee: Joe Bowser >Priority: Blocker > > GradleBuilder.js has a buiit-in option org.gradle.jvmargs=---Xmx2048m on line > 59, which prevents it from running on 32bit Java. It always fails with VM > heap error. The workaround is to create an environment variable > __JAVA__OPTIONS=-Xmx512m, but this then affects the whole system. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14139) Can't run android commands with 32bit Java
[ https://issues.apache.org/jira/browse/CB-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525905#comment-16525905 ] ASF GitHub Bot commented on CB-14139: - erisu opened a new pull request #459: CB-14139 android: Add jvmargs flag for custom values URL: https://github.com/apache/cordova-android/pull/459 ### Platforms affected Android ### What does this PR do? Added an additional flag `--jvmargs` to allow users to customize the Gradle's JVM memory heap size settings. ### What testing has been done on this change? - cordova build and run with and without flag settings. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Can't run android commands with 32bit Java > -- > > Key: CB-14139 > URL: https://issues.apache.org/jira/browse/CB-14139 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 8.0.0 > Environment: Win 10 Pro x64 >Reporter: misterTi >Assignee: Joe Bowser >Priority: Blocker > > GradleBuilder.js has a buiit-in option org.gradle.jvmargs=---Xmx2048m on line > 59, which prevents it from running on 32bit Java. It always fails with VM > heap error. The workaround is to create an environment variable > __JAVA__OPTIONS=-Xmx512m, but this then affects the whole system. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14026) Android installation requirements are out of date
[ https://issues.apache.org/jira/browse/CB-14026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525878#comment-16525878 ] ASF GitHub Bot commented on CB-14026: - Menardi commented on issue #836: CB-14026 (android): Update Android SDK instructions URL: https://github.com/apache/cordova-docs/pull/836#issuecomment-40090 Thanks! As a more general Cordova repository question, is the general practice to wait for multiple reviews before merging? I am hoping to become more active in the project and am trying to learn the processes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Android installation requirements are out of date > - > > Key: CB-14026 > URL: https://issues.apache.org/jira/browse/CB-14026 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Simon MacDonald >Priority: Major > > In this section of the docs: > [http://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#installing-the-requirements] > we talk about running the sdkmanager from the command line but it is no > longer available. > We should instead tell the users to run the sdkmanager from Android Studio. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14026) Android installation requirements are out of date
[ https://issues.apache.org/jira/browse/CB-14026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525855#comment-16525855 ] ASF GitHub Bot commented on CB-14026: - Menardi commented on issue #836: CB-14026 (android): Update Android SDK instructions URL: https://github.com/apache/cordova-docs/pull/836#issuecomment-400895981 @dpogue I have updated this, do you think it's good to merge now? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Android installation requirements are out of date > - > > Key: CB-14026 > URL: https://issues.apache.org/jira/browse/CB-14026 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Simon MacDonald >Priority: Major > > In this section of the docs: > [http://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#installing-the-requirements] > we talk about running the sdkmanager from the command line but it is no > longer available. > We should instead tell the users to run the sdkmanager from Android Studio. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-14115) Error with NDK - Android Studio
[ https://issues.apache.org/jira/browse/CB-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JOSE FREDERICO DE SOUZA SILVA closed CB-14115. -- Resolution: Not A Problem Fix Version/s: 7.1.0 > Error with NDK - Android Studio > --- > > Key: CB-14115 > URL: https://issues.apache.org/jira/browse/CB-14115 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 7.1.0 >Reporter: JOSE FREDERICO DE SOUZA SILVA >Assignee: Joe Bowser >Priority: Major > Fix For: 7.1.0 > > > Error with version 7.1.0 of cordova-android > when run cordova run android, show error, but when uninstall NDK and run the > command again works fine > > [https://stackoverflow.com/questions/42739916/aarch64-linux-android-strip-file-missing#answer-50316120] > > [https://github.com/android-ndk/ndk/issues/707] > > [https://i.stack.imgur.com/SgKnF.png] > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14115) Error with NDK - Android Studio
[ https://issues.apache.org/jira/browse/CB-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525804#comment-16525804 ] JOSE FREDERICO DE SOUZA SILVA commented on CB-14115: I changed *Windows Variable Environment* with another Android SDK Build Tools and now works with *NDK R17B* > Error with NDK - Android Studio > --- > > Key: CB-14115 > URL: https://issues.apache.org/jira/browse/CB-14115 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 7.1.0 >Reporter: JOSE FREDERICO DE SOUZA SILVA >Assignee: Joe Bowser >Priority: Major > > Error with version 7.1.0 of cordova-android > when run cordova run android, show error, but when uninstall NDK and run the > command again works fine > > [https://stackoverflow.com/questions/42739916/aarch64-linux-android-strip-file-missing#answer-50316120] > > [https://github.com/android-ndk/ndk/issues/707] > > [https://i.stack.imgur.com/SgKnF.png] > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-14033) `cordova plugin add` skips directory on windows
[
https://issues.apache.org/jira/browse/CB-14033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525725#comment-16525725
]
Raphael edited comment on CB-14033 at 6/27/18 11:29 PM:
Could you please check if the fix in
[https://github.com/apache/cordova-lib/pull/621] resolves your problems? If you
need help installing Cordova from source, let us know.
was (Author: raphinesse):
Could you check if the fix in [https://github.com/apache/cordova-lib/pull/621]
resolves your problems? If you need help installing Cordova from source, let us
know.
> `cordova plugin add` skips directory on windows
> ---
>
> Key: CB-14033
> URL: https://issues.apache.org/jira/browse/CB-14033
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
> Environment: Cordova 6.2.0
>Reporter: Jack Lu
>Assignee: Raphael
>Priority: Major
>
> Suppose we have a cordova plugin project and a test project that are under
> the same directory. The {color:#33}cordova plugin project {color}is in
> directory p, and the test project in directory t. When I run following
> command in directory t:
>
> {code:java}
> cordova plugin add ..\p
> {code}
> the install fails, and I found it's due to the src directory missing during
> copying.
> After digging into the source, I found it's caused by a special handling in
> the fetch action{color:#33} on windows{color}. The source is
> {color:#33}[https://github.com/apache/cordova-lib/blob/master/src/plugman/fetch.js#L299]{color}.
> {code:java}
> /*
> [CB-10423]
> This is a special case. On windows we cannot create a symlink
> unless we are run as admin
> The error that we have is because src contains dest, so we
> end up with a recursive folder explosion
> This code avoids copy the one folder that will explode, and
> allows plugins to contain a demo project
> and to install the plugin via `cordova plugin add ../`
> */
> var resolvedSrcPath = path.resolve(plugin_dir);
> var filenames = fs.readdirSync(resolvedSrcPath);
> var relPath = path.relative(resolvedSrcPath,dest);
> var relativeRootFolder = relPath.split('\\')[0];
> filenames.splice(filenames.indexOf(relativeRootFolder),1);
> {code}
> in this case {color:#33}relPath{color} will be "..\t\plugins\plugin
> id", {color:#33}relativeRootFolder{color} be "..", then
> {color:#33}filenames.indexOf(relativeRootFolder){color} be -1, finally
> filenames lost the last element, which is the src directory in my case.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14033) `cordova plugin add` skips directory on windows
[
https://issues.apache.org/jira/browse/CB-14033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525725#comment-16525725
]
Raphael commented on CB-14033:
--
Could you check if the fix in [https://github.com/apache/cordova-lib/pull/621]
resolves your problems? If you need help installing Cordova from source, let us
know.
> `cordova plugin add` skips directory on windows
> ---
>
> Key: CB-14033
> URL: https://issues.apache.org/jira/browse/CB-14033
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
> Environment: Cordova 6.2.0
>Reporter: Jack Lu
>Assignee: Raphael
>Priority: Major
>
> Suppose we have a cordova plugin project and a test project that are under
> the same directory. The {color:#33}cordova plugin project {color}is in
> directory p, and the test project in directory t. When I run following
> command in directory t:
>
> {code:java}
> cordova plugin add ..\p
> {code}
> the install fails, and I found it's due to the src directory missing during
> copying.
> After digging into the source, I found it's caused by a special handling in
> the fetch action{color:#33} on windows{color}. The source is
> {color:#33}[https://github.com/apache/cordova-lib/blob/master/src/plugman/fetch.js#L299]{color}.
> {code:java}
> /*
> [CB-10423]
> This is a special case. On windows we cannot create a symlink
> unless we are run as admin
> The error that we have is because src contains dest, so we
> end up with a recursive folder explosion
> This code avoids copy the one folder that will explode, and
> allows plugins to contain a demo project
> and to install the plugin via `cordova plugin add ../`
> */
> var resolvedSrcPath = path.resolve(plugin_dir);
> var filenames = fs.readdirSync(resolvedSrcPath);
> var relPath = path.relative(resolvedSrcPath,dest);
> var relativeRootFolder = relPath.split('\\')[0];
> filenames.splice(filenames.indexOf(relativeRootFolder),1);
> {code}
> in this case {color:#33}relPath{color} will be "..\t\plugins\plugin
> id", {color:#33}relativeRootFolder{color} be "..", then
> {color:#33}filenames.indexOf(relativeRootFolder){color} be -1, finally
> filenames lost the last element, which is the src directory in my case.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-14033) `cordova plugin add` skips directory on windows
[
https://issues.apache.org/jira/browse/CB-14033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522597#comment-16522597
]
Raphael edited comment on CB-14033 at 6/27/18 11:27 PM:
I see you are using Cordova 6. This version is no longer supported.
was (Author: raphinesse):
I see you are using Cordova 6. This version is no longer supported. Please
check if the issue persists in cordova@nightly and let us know.
> `cordova plugin add` skips directory on windows
> ---
>
> Key: CB-14033
> URL: https://issues.apache.org/jira/browse/CB-14033
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
> Environment: Cordova 6.2.0
>Reporter: Jack Lu
>Assignee: Raphael
>Priority: Major
>
> Suppose we have a cordova plugin project and a test project that are under
> the same directory. The {color:#33}cordova plugin project {color}is in
> directory p, and the test project in directory t. When I run following
> command in directory t:
>
> {code:java}
> cordova plugin add ..\p
> {code}
> the install fails, and I found it's due to the src directory missing during
> copying.
> After digging into the source, I found it's caused by a special handling in
> the fetch action{color:#33} on windows{color}. The source is
> {color:#33}[https://github.com/apache/cordova-lib/blob/master/src/plugman/fetch.js#L299]{color}.
> {code:java}
> /*
> [CB-10423]
> This is a special case. On windows we cannot create a symlink
> unless we are run as admin
> The error that we have is because src contains dest, so we
> end up with a recursive folder explosion
> This code avoids copy the one folder that will explode, and
> allows plugins to contain a demo project
> and to install the plugin via `cordova plugin add ../`
> */
> var resolvedSrcPath = path.resolve(plugin_dir);
> var filenames = fs.readdirSync(resolvedSrcPath);
> var relPath = path.relative(resolvedSrcPath,dest);
> var relativeRootFolder = relPath.split('\\')[0];
> filenames.splice(filenames.indexOf(relativeRootFolder),1);
> {code}
> in this case {color:#33}relPath{color} will be "..\t\plugins\plugin
> id", {color:#33}relativeRootFolder{color} be "..", then
> {color:#33}filenames.indexOf(relativeRootFolder){color} be -1, finally
> filenames lost the last element, which is the src directory in my case.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14033) `cordova plugin add` skips directory on windows
[
https://issues.apache.org/jira/browse/CB-14033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525724#comment-16525724
]
ASF GitHub Bot commented on CB-14033:
-
raphinesse opened a new pull request #621: CB-14033 Support symbolic links on
Windows
URL: https://github.com/apache/cordova-lib/pull/621
### Platforms affected
Windows
### What does this PR do?
This uses junctions whenever creating symlinks on Windows since that does
not require any special privileges.
### What testing has been done on this change?
None on Windows yet.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> `cordova plugin add` skips directory on windows
> ---
>
> Key: CB-14033
> URL: https://issues.apache.org/jira/browse/CB-14033
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
> Environment: Cordova 6.2.0
>Reporter: Jack Lu
>Assignee: Raphael
>Priority: Major
>
> Suppose we have a cordova plugin project and a test project that are under
> the same directory. The {color:#33}cordova plugin project {color}is in
> directory p, and the test project in directory t. When I run following
> command in directory t:
>
> {code:java}
> cordova plugin add ..\p
> {code}
> the install fails, and I found it's due to the src directory missing during
> copying.
> After digging into the source, I found it's caused by a special handling in
> the fetch action{color:#33} on windows{color}. The source is
> {color:#33}[https://github.com/apache/cordova-lib/blob/master/src/plugman/fetch.js#L299]{color}.
> {code:java}
> /*
> [CB-10423]
> This is a special case. On windows we cannot create a symlink
> unless we are run as admin
> The error that we have is because src contains dest, so we
> end up with a recursive folder explosion
> This code avoids copy the one folder that will explode, and
> allows plugins to contain a demo project
> and to install the plugin via `cordova plugin add ../`
> */
> var resolvedSrcPath = path.resolve(plugin_dir);
> var filenames = fs.readdirSync(resolvedSrcPath);
> var relPath = path.relative(resolvedSrcPath,dest);
> var relativeRootFolder = relPath.split('\\')[0];
> filenames.splice(filenames.indexOf(relativeRootFolder),1);
> {code}
> in this case {color:#33}relPath{color} will be "..\t\plugins\plugin
> id", {color:#33}relativeRootFolder{color} be "..", then
> {color:#33}filenames.indexOf(relativeRootFolder){color} be -1, finally
> filenames lost the last element, which is the src directory in my case.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-14177) Remove all usage of opts.link when calling cordova-fetch
[ https://issues.apache.org/jira/browse/CB-14177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raphael resolved CB-14177. -- Resolution: Not A Problem The link option was never set for fetch only. Instead option objects received from callers were passed through to fetch while the link option was used in the function calling fetch too. > Remove all usage of opts.link when calling cordova-fetch > > > Key: CB-14177 > URL: https://issues.apache.org/jira/browse/CB-14177 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Raphael >Assignee: Raphael >Priority: Minor > > Since opts.link was removed from cordova-fetch, we should no longer set it. > At the very least not explicitly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-14175) Splashscreen plugin ignoring preference on iOS
[
https://issues.apache.org/jira/browse/CB-14175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jcesarmobile closed CB-14175.
-
Resolution: Invalid
SplashScreenDelay is set in millisecons, so 2 is 20 seconds, not 2 minutes
> Splashscreen plugin ignoring preference on iOS
> --
>
> Key: CB-14175
> URL: https://issues.apache.org/jira/browse/CB-14175
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Daniela Ferrai
>Priority: Major
>
> Configurations not to automatically hide splashscreen or to display it for 2
> minutes are completely ignored on iOS.
>
> {{preference name="SplashScreen" value="splash" /> name="AutoHideSplashScreen" value="false" /> name="SplashScreenDelay" value="2" /> name="FadeSplashScreenDuration" value="300" /> name="ShowSplashScreenSpinner" value="false" /> name="SplashMaintainAspectRatio" value="false" />}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12129) Do we have any implements to apply our custom CSS-Style into the Notification prompts?
[ https://issues.apache.org/jira/browse/CB-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525708#comment-16525708 ] ASF GitHub Bot commented on CB-12129: - jcesarmobile commented on issue #103: CB-12129 (android): Add ability to set dialog style URL: https://github.com/apache/cordova-plugin-dialogs/pull/103#issuecomment-400854630 Thanks for the PR, but CB-12129 is closed and it's not exactly the same as what you implemented. So it's better if you create a new issue and use the new id instead of CB-12129. Also, for new features, specially if they are platform specific, is recommended to send a mail to the cordova dev list ( d...@cordova.apache.org ) so it can be discussed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Do we have any implements to apply our custom CSS-Style into the Notification > prompts? > -- > > Key: CB-12129 > URL: https://issues.apache.org/jira/browse/CB-12129 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-dialogs >Affects Versions: 1.2.1 >Reporter: kxiao >Assignee: jcesarmobile >Priority: Major > > I have a HTML5+Cordova application for mobile user > (androd/iOS/WindowsPhone/BB), do we have any chance to implement our CSS > style into the prompts from navigator.notification, such as title bg, button, > font, etc.? Or could you please provide some examples for us? thanks. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14177) Remove all usage of opts.link when calling cordova-fetch
Raphael created CB-14177: Summary: Remove all usage of opts.link when calling cordova-fetch Key: CB-14177 URL: https://issues.apache.org/jira/browse/CB-14177 Project: Apache Cordova Issue Type: Improvement Components: cordova-lib Reporter: Raphael Assignee: Raphael Since opts.link was removed from cordova-fetch, we should no longer set it. At the very least not explicitly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14173) cordova-fetch nightly breaks with --link
[
https://issues.apache.org/jira/browse/CB-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525690#comment-16525690
]
ASF GitHub Bot commented on CB-14173:
-
raphinesse opened a new pull request #26: CB-14173 Fix cordova
add --link
URL: https://github.com/apache/cordova-fetch/pull/26
This drops support for the untested and undocumented `link` option
which when set, caused `npm link` to be run instead of `npm install`.
However, the installed package's name cannot be extracted from the
output of `npm link`. Thus we always failed in that case.
Now, we always run `npm install` instead. This works for the use case of
`cordova add --link` since packages identified by a
local path are always installed as symbolic links by npm.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> cordova-fetch nightly breaks with --link
>
>
> Key: CB-14173
> URL: https://issues.apache.org/jira/browse/CB-14173
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-fetch
>Reporter: Darryl Pogue
>Assignee: Raphael
>Priority: Major
>
> A coworker just ran this:
> {code:java}
> npx cordova platform add --link ../cordova-ios/{code}
> It failed with this error:
> {noformat}
> Warning: using prerelease version 8.0.1-nightly.2018.6.26.77b7324f
> (cordova-lib@8.0.1-nightly.2018.6.26.da4b4b37)
> { CordovaError: Could not determine package name from output:
> up to date in 6.878s
> [!] 3 vulnerabilities found [2885 packages audited]
> Severity: 3 low
> Run `npm audit` for more detail/usr/local/lib/node_modules/cordova-ios ->
> /Projects/cordova-ios
> /Projects/launch-cordova-test/node_modules/cordova-ios ->
> /usr/local/lib/node_modules/cordova-ios -> /Projects/cordova-ios
> at getTargetPackageSpecFromNpmInstallOutput
> (/Projects/launch-cordova-test/node_modules/cordova-fetch/index.js:97:15)
> at _fulfilled (/Projects/launch-cordova-test/node_modules/q/q.js:854:54)
> at /Projects/launch-cordova-test/node_modules/q/q.js:883:30
> at Promise.promise.promiseDispatch
> (/Projects/launch-cordova-test/node_modules/q/q.js:816:13)
> at /Projects/launch-cordova-test/node_modules/q/q.js:624:44
> at runSingle (/Projects/launch-cordova-test/node_modules/q/q.js:137:13)
> at flush (/Projects/launch-cordova-test/node_modules/q/q.js:125:13)
> at process._tickCallback (internal/process/next_tick.js:172:11)
> name: 'CordovaError',
> message: 'Could not determine package name from output:\nup to date in
> 6.878s\n[!] 3 vulnerabilities found [2885 packages audited]\n Severity: 3
> low\n Run `npm audit` for more
> detail\n\n/usr/local/lib/node_modules/cordova-ios ->
> /Projects/cordova-ios\n/Projects/launch-cordova-test/node_modules/cordova-ios
> -> /usr/local/lib/node_modules/cordova-ios -> /Projects/cordova-ios',
> code: 0,
> context: undefined }{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12129) Do we have any implements to apply our custom CSS-Style into the Notification prompts?
[ https://issues.apache.org/jira/browse/CB-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525573#comment-16525573 ] ASF GitHub Bot commented on CB-12129: - hvaughan3 opened a new pull request #103: CB-12129 (android): Add ability to set dialog style URL: https://github.com/apache/cordova-plugin-dialogs/pull/103 ### Platforms affected Android ### What does this PR do? Created new `setAndroidStyleName` function to allow specifying the name of a style to apply to dialogs on Android. Also updated README to explain how to create a named style and correctly copy it to the correct location. ### What testing has been done on this change? Tested on Android 7.1.1 emulator. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Do we have any implements to apply our custom CSS-Style into the Notification > prompts? > -- > > Key: CB-12129 > URL: https://issues.apache.org/jira/browse/CB-12129 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-dialogs >Affects Versions: 1.2.1 >Reporter: kxiao >Assignee: jcesarmobile >Priority: Major > > I have a HTML5+Cordova application for mobile user > (androd/iOS/WindowsPhone/BB), do we have any chance to implement our CSS > style into the prompts from navigator.notification, such as title bg, button, > font, etc.? Or could you please provide some examples for us? thanks. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14176) inappbrowser CSS -webkit-mask-image broken by iOS 11.x?
Andrew Holmes created CB-14176: -- Summary: inappbrowser CSS -webkit-mask-image broken by iOS 11.x? Key: CB-14176 URL: https://issues.apache.org/jira/browse/CB-14176 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-inappbrowser Affects Versions: 3.0.0 Reporter: Andrew Holmes As described here: [https://stackoverflow.com/questions/51069792/css-image-mask-broken-in-cordova-for-ios-11-x] it seems that something has broken webkit-mask-image in iOS 11.x (11.3 or 11.4, I think). Icons using image masking in Cordova iOS are now invisible (still tappable, though). This may not be Cordova, it may be an iOS issue, because it's working fine in Android, but since Apple changed the minor version of iOS, they may not be considering it a bug on their side. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12922) [iOS] In-app browser does not cede control after actions on certain pages
[ https://issues.apache.org/jira/browse/CB-12922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525490#comment-16525490 ] Doug Davies commented on CB-12922: -- Ya, I hate to go back to an earlier version. We needed some of the stuff in 3.0.0. We used 1.6.x for quite a while but recently upgraded. I'd like to figure out what changed. > [iOS] In-app browser does not cede control after actions on certain pages > - > > Key: CB-12922 > URL: https://issues.apache.org/jira/browse/CB-12922 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Reporter: Ben Williams >Priority: Critical > Attachments: nest_iab.zip > > > This issue only occurs on the iOS version of inappbrowser. > When opening the Nest login (https://home.nest.com/login/) page in the > inappbrowser, clicking Sign In (with or without valid credentials) and > subsequently closing the browser, the main cordova page becomes unresponsive, > receiving no touch events whatsoever. > I have created a barebones application which exhibits the issue, which I will > attach. > Thank you. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12922) [iOS] In-app browser does not cede control after actions on certain pages
[ https://issues.apache.org/jira/browse/CB-12922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525487#comment-16525487 ] Archesh Patel commented on CB-12922: [~csddavies], try following my solution. It will work > [iOS] In-app browser does not cede control after actions on certain pages > - > > Key: CB-12922 > URL: https://issues.apache.org/jira/browse/CB-12922 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Reporter: Ben Williams >Priority: Critical > Attachments: nest_iab.zip > > > This issue only occurs on the iOS version of inappbrowser. > When opening the Nest login (https://home.nest.com/login/) page in the > inappbrowser, clicking Sign In (with or without valid credentials) and > subsequently closing the browser, the main cordova page becomes unresponsive, > receiving no touch events whatsoever. > I have created a barebones application which exhibits the issue, which I will > attach. > Thank you. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12922) [iOS] In-app browser does not cede control after actions on certain pages
[ https://issues.apache.org/jira/browse/CB-12922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525483#comment-16525483 ] Doug Davies commented on CB-12922: -- This one is biting me as well. > [iOS] In-app browser does not cede control after actions on certain pages > - > > Key: CB-12922 > URL: https://issues.apache.org/jira/browse/CB-12922 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Reporter: Ben Williams >Priority: Critical > Attachments: nest_iab.zip > > > This issue only occurs on the iOS version of inappbrowser. > When opening the Nest login (https://home.nest.com/login/) page in the > inappbrowser, clicking Sign In (with or without valid credentials) and > subsequently closing the browser, the main cordova page becomes unresponsive, > receiving no touch events whatsoever. > I have created a barebones application which exhibits the issue, which I will > attach. > Thank you. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11665) Navigation to Fragment locations within Webview are parsed as an error
[ https://issues.apache.org/jira/browse/CB-11665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525456#comment-16525456 ] Doug Davies commented on CB-11665: -- I'm having this same issue, but it is affecting cordova-plugin-inappbrowser of all places. Seems like progress on this has stalled? > Navigation to Fragment locations within Webview are parsed as an error > -- > > Key: CB-11665 > URL: https://issues.apache.org/jira/browse/CB-11665 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: cordova-ios >Reporter: Brian Anderson >Priority: Major > Labels: easyfix > Original Estimate: 1h > Remaining Estimate: 1h > > In the CDVUIWebviewDelegate if a fragment is loaded on a url the > shouldStartLoadWithRequest gets called and sets the _state to > STATE_WAITING_FOR_LOAD_START. Being that when a fragment is loaded the > didStartLoading and didFinishLoading callbacks are not called, the next time > a link is clicked within our WebView the _state doesn't match any cases, > falls into the default case which then handles the request as an error by > explicitly calling didFailLoadWithError. I am curious if this is by design as > I do notice that STATE_IOS5_POLLING_FOR_LOAD_START is handled in > shouldStartLoadWithRequest. Is there a specific case that we would actually > want to throw an error? > My suggestion for fixing this would be to add STATE_WAITING_FOR_LOAD_START to > the same fall through case as STATE_IDLE, STATE_IOS5_POLLING_FOR_LOAD_START, > STATE_CANCELLED. Which would basically just reset the state and loadCount > seeing as we have essentially 'cancelled' that pending request from the eyes > of cordova. > Hoping to get more information about these decisions. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14094) Remove deprecated platforms and plugins from cordova-status
[ https://issues.apache.org/jira/browse/CB-14094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525168#comment-16525168 ] Bryan Ellis commented on CB-14094: -- [~raphinesse] Thank you for closing my task ticket. Is there anyone I should specifically @ when I complete a ticket but has no one assigned? Or if I want to be assigned? Sometimes I noticed merged PRs but the ticket is not resolved or closed so I not sure what to do in these cases. Also, I will create one more ticket similar to this ticket to fix one broken link and add one missing Code Coverage report badge. Since I also don't have permission to the repo GH page settings, I can not rebuild the https://apache.github.io/cordova-status/ page. Do you have the ability to rebuild this page? I would like to try and get this page updated after. > Remove deprecated platforms and plugins from cordova-status > --- > > Key: CB-14094 > URL: https://issues.apache.org/jira/browse/CB-14094 > Project: Apache Cordova > Issue Type: Task >Reporter: Bryan Ellis >Priority: Trivial > Labels: documentation > Original Estimate: 1h > Remaining Estimate: 1h > > Remove the deprecated platforms and plugins from the `cordova-status` > README.md to reflect the current supported components. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525148#comment-16525148
]
ASF GitHub Bot commented on CB-13273:
-
mhartington commented on issue #85: CB-13273: fix statusbar spacing with new
iphoneX
URL:
https://github.com/apache/cordova-plugin-statusbar/pull/85#issuecomment-400694293
@ManigandanRaamanathan this was closed as there was a better PR sent here
https://github.com/apache/cordova-plugin-statusbar/pull/87
Which itself was merged and is available.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>Priority: Major
> Labels: iPhoneX, ios11
> Attachments: Simulator Screen Shot - iPhone X - 2017-09-14 at
> 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at 09.20.48.png,
> Simulator Screen Shot - iPhone X - 2017-09-19 at 11.29.00.png, fig1.png,
> fig2.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)
[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525115#comment-16525115
]
ASF GitHub Bot commented on CB-13273:
-
ManigandanRaamanathan commented on issue #85: CB-13273: fix statusbar spacing
with new iphoneX
URL:
https://github.com/apache/cordova-plugin-statusbar/pull/85#issuecomment-400680456
Why is this closed?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Webview is sized incorrectly on iPhone X (Simulator)
>
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>Priority: Major
> Labels: iPhoneX, ios11
> Attachments: Simulator Screen Shot - iPhone X - 2017-09-14 at
> 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at 09.20.48.png,
> Simulator Screen Shot - iPhone X - 2017-09-19 at 11.29.00.png, fig1.png,
> fig2.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14175) Splashscreen plugin ignoring preference on iOS
Daniela Ferrai created CB-14175:
---
Summary: Splashscreen plugin ignoring preference on iOS
Key: CB-14175
URL: https://issues.apache.org/jira/browse/CB-14175
Project: Apache Cordova
Issue Type: Bug
Reporter: Daniela Ferrai
Configurations not to automatically hide splashscreen or to display it for 2
minutes are completely ignored on iOS.
{{preference name="SplashScreen" value="splash" /> }}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13801) Fail to restore plugins with relative path
[
https://issues.apache.org/jira/browse/CB-13801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525018#comment-16525018
]
Robert Weiser edited comment on CB-13801 at 6/27/18 1:00 PM:
-
The following workaround works (confirmed for Windows):
* Adapt your _package.json_ to copy the local plugin to the _plugins_ folder
when building the project
* Delete your _plugins_ folder
* When the _plugins_ folder is re-created by the tooling and your plugin has
been copied there beforehand it should be linked in the _plugins/.json_
file and therefore be active.
was (Author: death-knight):
The following workaround works (confirmed for Windows):
* Adapt your _package.json_ to copy the local plugin to the _plugins_ folder
when building the project
* Delete your _plugins_ folder
* When the _plugins_ folder is re-created by the tooling and your plugin has
been copied there beforehand it should be linked in the _plugins/.json_ file
...I can only confirm this for windows.
> Fail to restore plugins with relative path
> --
>
> Key: CB-13801
> URL: https://issues.apache.org/jira/browse/CB-13801
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Reporter: Michael Goffioul
>Priority: Major
>
> 1. Create a cordova project
> 2. Add android platform
> 3. Add a local plugin using a relative path: {{cordova plugin add
> myplugins/testplugin}}
> 4. Delete directories platforms/ and plugins/
> 5. Prepare android: {{cordova prepare android}}
> Cordova will fail to restore the local plugin. The plugin has been added to
> {{package.json}} using the spec {{file:myplugins/testplugin}} and the
> restoration utility is unable to handle such URL. Note that {{config.xml}}
> contains the spec {{myplugins/testplugin}} (that is, without the file:
> scheme), but the one in {{package.json}} takes precedence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13801) Fail to restore plugins with relative path
[
https://issues.apache.org/jira/browse/CB-13801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525018#comment-16525018
]
Robert Weiser edited comment on CB-13801 at 6/27/18 12:59 PM:
--
The following workaround works (confirmed for Windows):
* Adapt your _package.json_ to copy the local plugin to the _plugins_ folder
when building the project
* Delete your _plugins_ folder
* When the _plugins_ folder is re-created by the tooling and your plugin has
been copied there beforehand it should be linked in the _plugins/.json_ file
...I can only confirm this for windows.
was (Author: death-knight):
The following workaround works (confirmed for Windows):
* Adapt your _package.json_ to copy the local plugin to the _plugins_ folder
when building the project
* Delete your _plugins_ folder
* When the _plugins_ folder is populated re-created by the tooling and your
plugin has been copied there beforehand it should be linked in the
_plugins/.json_ file
...I can only confirm this for windows.
> Fail to restore plugins with relative path
> --
>
> Key: CB-13801
> URL: https://issues.apache.org/jira/browse/CB-13801
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Reporter: Michael Goffioul
>Priority: Major
>
> 1. Create a cordova project
> 2. Add android platform
> 3. Add a local plugin using a relative path: {{cordova plugin add
> myplugins/testplugin}}
> 4. Delete directories platforms/ and plugins/
> 5. Prepare android: {{cordova prepare android}}
> Cordova will fail to restore the local plugin. The plugin has been added to
> {{package.json}} using the spec {{file:myplugins/testplugin}} and the
> restoration utility is unable to handle such URL. Note that {{config.xml}}
> contains the spec {{myplugins/testplugin}} (that is, without the file:
> scheme), but the one in {{package.json}} takes precedence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13801) Fail to restore plugins with relative path
[
https://issues.apache.org/jira/browse/CB-13801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525018#comment-16525018
]
Robert Weiser commented on CB-13801:
The following workaround works (confirmed for Windows):
* Adapt your _package.json_ to copy the local plugin to the _plugins_ folder
when building the project
* Delete your _plugins_ folder
* When the _plugins_ folder is populated re-created by the tooling and your
plugin has been copied there beforehand it should be linked in the
_plugins/.json_ file
...I can only confirm this for windows.
> Fail to restore plugins with relative path
> --
>
> Key: CB-13801
> URL: https://issues.apache.org/jira/browse/CB-13801
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Reporter: Michael Goffioul
>Priority: Major
>
> 1. Create a cordova project
> 2. Add android platform
> 3. Add a local plugin using a relative path: {{cordova plugin add
> myplugins/testplugin}}
> 4. Delete directories platforms/ and plugins/
> 5. Prepare android: {{cordova prepare android}}
> Cordova will fail to restore the local plugin. The plugin has been added to
> {{package.json}} using the spec {{file:myplugins/testplugin}} and the
> restoration utility is unable to handle such URL. Note that {{config.xml}}
> contains the spec {{myplugins/testplugin}} (that is, without the file:
> scheme), but the one in {{package.json}} takes precedence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14013) cordova-plugin-inappbrowser support for custom URL schemes, as needed for oAuth
[ https://issues.apache.org/jira/browse/CB-14013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524964#comment-16524964 ] ASF GitHub Bot commented on CB-14013: - wvengen commented on issue #263: CB-14013: (android) Change the InAppBrowser to allow custom schemes for oAuth URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/263#issuecomment-400647898 Wow, this is **huge** as it (finally) allows 'events' from the inAppBrowser to the Cordova app. Its use goes way beyond OAuth 2. Thanks a lot! As a sidenote: I do see a use-case for allowing `http` and `https` in `AllowedSchemes`: deciding in the Cordova app whether a URL needs to be loaded or not. This would allow for more easily deciding which URLs are opened in the app, and which URLs are opened in the system web browser. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-plugin-inappbrowser support for custom URL schemes, as needed for > oAuth > --- > > Key: CB-14013 > URL: https://issues.apache.org/jira/browse/CB-14013 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Steve Podell >Priority: Major > Original Estimate: 72h > Remaining Estimate: 72h > > A very common usage of the inappbrowser is to open a URL to the apps server, > as part of the oAuth flow. After a secure token is created, the final step > in the oAuth flow is to redirect back to the Cordova app, to proceed as > authenticated. At the WeVote open source project we use this to authenticate > with Twitter and Facebook, other projects want to authenticate with Google, > Whatsapp, Skype, etc. > There is a package for React Native react-native-oauth that does this, and I > was able to get oAuth working for iOS with > cordova-plugin-safariviewcontroller, but there is nothing that is stable, > maintained, and working that is equivalent for Android. > A pull request will follow that uses whitelisted schemes to allow the oAuth > redirect to complete through the InAppBrowser. It is a fairly simple code > change, that leads to a simple end user implementation, that should be widely > appreciated (based on years of mostly unfulfilled Stack Overflow chatter.) > > This PR builds on > [https://github.com/apache/cordova-plugin-inappbrowser/pull/99] and > [https://github.com/apache/cordova-plugin-inappbrowser/pull/261] and builds > on a good suggestion from *[NGumby|https://github.com/NGumby]* and comments > about viability from *[infil00p|https://github.com/infil00p]* > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen
[ https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524853#comment-16524853 ] ASF GitHub Bot commented on CB-10893: - goinnn commented on issue #124: CB-10893: (android) Allow setting status bar color on Android splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/124#issuecomment-400614963 I have improved it a little with color in navigation bar too: https://github.com/goinnn/cordova-plugin-splashscreen/commit/7e5bafd628ebe0478c51800171f72ce4b84d325a This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow setting status bar color on Android splashscreen > -- > > Key: CB-10893 > URL: https://issues.apache.org/jira/browse/CB-10893 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-splashscreen > Environment: Android >Reporter: Martin Buchalik >Priority: Major > > When creating a custom Android theme, you can also set a status bar > background color. > The splash screen doesn't seem to use the application's theme - the status > bar becomes black while displaying the splash screen image (no matter which > color I specify in android:colorPrimaryDark). > Please add an option to set the status bar background color while the splash > screen image is displayed. Alternatively, inherit the application's status > bar settings. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-14142) Error when run command: cordova run android
[ https://issues.apache.org/jira/browse/CB-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-14142. - Resolution: Duplicate Yeah, it's a duplicate of CB-14165. Closing > Error when run command: cordova run android > --- > > Key: CB-14142 > URL: https://issues.apache.org/jira/browse/CB-14142 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 7.0.0, 7.1.0 >Reporter: JOSE FREDERICO DE SOUZA SILVA >Assignee: Joe Bowser >Priority: Major > > When run command: cordova run android not started android emulator but if > android emulator already is started and run command works fine -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-14171) Unable to install scoped npm plugin from git
[
https://issues.apache.org/jira/browse/CB-14171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Salzburg resolved CB-14171.
--
Resolution: Fixed
I couldn't reproduce this with cordova@nightly, so I consider this fixed.
> Unable to install scoped npm plugin from git
>
>
> Key: CB-14171
> URL: https://issues.apache.org/jira/browse/CB-14171
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-fetch
>Affects Versions: 1.3.0
>Reporter: Oliver Salzburg
>Priority: Major
>
> When attempting to install a plugin from a git URL and the plugin is under an
> npm scope, the installation fails.
>
> {{$ cordova plugin add
> [https://github.com/fairmanager-cordova/plugin-push.git] --verbose --debug}}
> {{No scripts found for hook "before_plugin_add".}}
> {{Calling plugman.fetch on plugin
> "https://github.com/fairmanager-cordova/plugin-push.git"}}
> {{saving}}
> {{Running command: cmd "/s /c
> "C:\Users\OliverSalzburg\AppData\Local\nvs\default\npm.cmd install
> [https://github.com/fairmanager-cordova/plugin-push.git] --production
> --save""}}
> {{Command finished with error code 0: cmd /s /c
> "C:\Users\OliverSalzburg\AppData\Local\nvs\default\npm.cmd install
> [https://github.com/fairmanager-cordova/plugin-push.git] --production
> --save"}}
> {{
> { CordovaError: Failed to get absolute path to installed module}
> }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14126) cordova-ios does not build with node 10.4.0
[ https://issues.apache.org/jira/browse/CB-14126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524703#comment-16524703 ] Ronald Ligteringen commented on CB-14126: - Problem seems solved after uninstalling cordova and alike with `npm -g uninstall cordova cordova-ios ios-deploy ios-sim`. After that an update of node to the latest version with `brew uninstall node@8; brew install node; brew doctor; brew prune`. And reinstalling cordova with the new npm: `npm -g install cordova ios-deploy`. Now I can do: ```bash $ cordova create test $ cd test $ cordova platform add ios $ cordova requirements ``` Can someone confirm this solution? > cordova-ios does not build with node 10.4.0 > --- > > Key: CB-14126 > URL: https://issues.apache.org/jira/browse/CB-14126 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: 8.0.0, 7.1.0 > Environment: macOS 10.13.5 > Xcode 9.4 > Homebrew 1.6.7-72 > Node 10.4.0 >Reporter: Ronald Ligteringen >Assignee: Suraj Pindoria >Priority: Blocker > Labels: PhaseScriptExecution, cordova, cordova-ios, ios, node > > The latest version of Node hangs the building process of cordova-ios during > the PhaseScriptExecution. Furthermore with this version of Node in Cordova > 8.0 the command > cordova requirements > fails during execution > FIX: These problems do not arise when using Node 8.11.2 (LTS) instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14142) Error when run command: cordova run android
[ https://issues.apache.org/jira/browse/CB-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524686#comment-16524686 ] Bryan Ellis commented on CB-14142: -- Hey [~fredroo] I think this is the same issue as [CB-14165|https://issues.apache.org/jira/browse/CB-14165] and has been fixed a couple of days ago in [PR #457|https://github.com/apache/cordova-android/pull/457]. If this is the same issue, it is fixed in 7.2.0-dev > Error when run command: cordova run android > --- > > Key: CB-14142 > URL: https://issues.apache.org/jira/browse/CB-14142 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 7.0.0, 7.1.0 >Reporter: JOSE FREDERICO DE SOUZA SILVA >Assignee: Joe Bowser >Priority: Major > > When run command: cordova run android not started android emulator but if > android emulator already is started and run command works fine -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
