date:20180917

[jira] [Assigned] (CB-10608) iOS - update to recommended project settings warning

2018-09-17 Thread Darryl Pogue (JIRA)



 [ 
https://issues.apache.org/jira/browse/CB-10608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darryl Pogue reassigned CB-10608:
-

Assignee: Darryl Pogue  (was: Shazron Abdullah)

> iOS - update to recommended project settings warning
> 
>
> Key: CB-10608
> URL: https://issues.apache.org/jira/browse/CB-10608
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Reporter: Edna Morales
>Assignee: Darryl Pogue
>Priority: Major
>  Labels: backlog, cordova-ios-4.0.1, triaged
> Fix For: cordova-ios@4.5.1
>
> Attachments: screenshot-1.png
>
>
> With a cordova-ios@4.0.1 project, Xcode throws an 'Update to recommended 
> project Settings' Warning



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-10186) Update PROJECTNAME.xcodeproj to recommended settings in Xcode 7.2

2018-09-17 Thread Darryl Pogue (JIRA)



 [ 
https://issues.apache.org/jira/browse/CB-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darryl Pogue reassigned CB-10186:
-

Assignee: Darryl Pogue

> Update __PROJECTNAME__.xcodeproj to recommended settings in Xcode 7.2
> -
>
> Key: CB-10186
> URL: https://issues.apache.org/jira/browse/CB-10186
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Reporter: Shazron Abdullah
>Assignee: Darryl Pogue
>Priority: Major
>  Labels: backlog
> Fix For: cordova-ios@5.0.0
>
>
> This is the default template project. Do for CLI and non-CLI



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-10169) Fetch API support

2018-09-17 Thread Darryl Pogue (JIRA)



 [ 
https://issues.apache.org/jira/browse/CB-10169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darryl Pogue closed CB-10169.
-
   Resolution: Won't Fix
Fix Version/s: (was: 3.6.0)

This is outside the scope of what Cordova provides. The Fetch API is available 
if you're using the WKWebView plugin, or via a 
[|https://www.npmjs.com/package/whatwg-fetch] 
[polyfill|https://www.npmjs.com/package/whatwg-fetch].

> Fetch API support
> -
>
> Key: CB-10169
> URL: https://issues.apache.org/jira/browse/CB-10169
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-ios
>Affects Versions: 3.5.0
> Environment: Apple Ipad 2, Apple Iphone 5, Apple Iphone 5
>Reporter: Arthur Battut
>Priority: Minor
>  Labels: apple, fetch, javascript, triaged
>
> Fetch API is unavailable on Apple devices. 
> Did you plan to support fetch API or you think it's to Apple to handle it ?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618370#comment-16618370
 ] 

ASF GitHub Bot commented on CB-14166:
-

knight commented on issue #697: CB-14166 distinguish npm.cmd and npm.exe in 
win32, to check if escape is necessary (workaround solution in 8.1.x only)
URL: https://github.com/apache/cordova-lib/pull/697#issuecomment-46622
 
 
   Thanks @brodybits !


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit 
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that 
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618364#comment-16618364
 ] 

ASF GitHub Bot commented on CB-14166:
-

brodybits commented on issue #688: CB-14166 distinguish npm.cmd and npm.exe in 
win32, to check if escape is necessary (workaround solution)
URL: https://github.com/apache/cordova-lib/pull/688#issuecomment-44793
 
 
   This workaround solution is included in 8.1.x in PR #697.
   
   This proposal as raised on master is now closed in favor of original 
solution proposed in #622.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit 
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that 
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618365#comment-16618365
 ] 

ASF GitHub Bot commented on CB-14166:
-

brodybits closed pull request #688: CB-14166 distinguish npm.cmd and npm.exe in 
win32, to check if escape is necessary (workaround solution)
URL: https://github.com/apache/cordova-lib/pull/688
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/package.json b/package.json
index 277b0c7a0..47290081e 100644
--- a/package.json
+++ b/package.json
@@ -34,7 +34,8 @@
 "read-chunk": "^3.0.0",
 "semver": "^5.3.0",
 "shebang-command": "^1.2.0",
-"underscore": "^1.9.0"
+"underscore": "^1.9.0",
+"which": "^1.3.1"
   },
   "devDependencies": {
 "codecov": "^3.0.1",
diff --git a/src/plugman/fetch.js b/src/plugman/fetch.js
index d52bae7aa..dd1e28d8c 100644
--- a/src/plugman/fetch.js
+++ b/src/plugman/fetch.js
@@ -18,6 +18,7 @@
 */
 
 var fs = require('fs-extra');
+var which = require('which');
 var url = require('url');
 var underscore = require('underscore');
 var semver = require('semver');
@@ -136,10 +137,13 @@ function fetchPlugin (plugin_src, plugins_dir, options) {
 }
 
 if (process.platform === 'win32' && parsedSpec.version) {
-var windowsShellSpecialCharacters = ['&', '\\', '<', '>', 
'^', '|'];
-specContainsSpecialCharacters = 
windowsShellSpecialCharacters.some(function (character) {
-return parsedSpec.version.indexOf(character);
-});
+var npmExtension = path.extname(which.sync('npm'));
+if (npmExtension && npmExtension.toUpperCase() !== '.EXE') 
{
+var windowsShellSpecialCharacters = ['&', '\\', '<', 
'>', '^', '|'];
+specContainsSpecialCharacters = 
windowsShellSpecialCharacters.some(function (character) {
+return parsedSpec.version.indexOf(character) >= 0;
+});
+}
 }
 
 var fetchPluginSrc = specContainsSpecialCharacters ?


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit 
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that 
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618361#comment-16618361
 ] 

ASF GitHub Bot commented on CB-14166:
-

brodybits closed pull request #697: CB-14166 distinguish npm.cmd and npm.exe in 
win32, to check if escape is necessary (workaround solution in 8.1.x only)
URL: https://github.com/apache/cordova-lib/pull/697
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/package.json b/package.json
index 838da6c74..30664785c 100644
--- a/package.json
+++ b/package.json
@@ -38,7 +38,8 @@
 "shebang-command": "^1.2.0",
 "shelljs": "0.3.0",
 "tar": "^4.4.1",
-"underscore": "^1.9.0"
+"underscore": "^1.9.0",
+"which": "^1.3.1"
   },
   "devDependencies": {
 "codecov": "^3.0.1",
diff --git a/src/plugman/fetch.js b/src/plugman/fetch.js
index 7fe69209e..1221e64fb 100644
--- a/src/plugman/fetch.js
+++ b/src/plugman/fetch.js
@@ -19,6 +19,7 @@
 
 var shell = require('shelljs');
 var fs = require('fs');
+var which = require('which');
 var url = require('url');
 var underscore = require('underscore');
 var semver = require('semver');
@@ -137,10 +138,13 @@ function fetchPlugin (plugin_src, plugins_dir, options) {
 }
 
 if (process.platform === 'win32' && parsedSpec.version) {
-var windowsShellSpecialCharacters = ['&', '\\', '<', '>', 
'^', '|'];
-specContainsSpecialCharacters = 
windowsShellSpecialCharacters.some(function (character) {
-return parsedSpec.version.indexOf(character);
-});
+var npmExtension = path.extname(which.sync('npm'));
+if (npmExtension && npmExtension.toUpperCase() !== '.EXE') 
{
+var windowsShellSpecialCharacters = ['&', '\\', '<', 
'>', '^', '|'];
+specContainsSpecialCharacters = 
windowsShellSpecialCharacters.some(function (character) {
+return parsedSpec.version.indexOf(character) >= 0;
+});
+}
 }
 
 var fetchPluginSrc = specContainsSpecialCharacters ?


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit 
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that 
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin

2018-09-17 Thread ASF subversion and git services (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618362#comment-16618362
 ] 

ASF subversion and git services commented on CB-14166:
--

Commit 7f795a05dfa7ab7fde317b0145b1215dacbd11a8 in cordova-lib's branch 
refs/heads/8.1.x from [~brodybits]
[ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=7f795a0 ]

CB-14166 distinguish npm.cmd and npm.exe in win32 (#697)

to check if escape is necessary

(workaround solution in 8.1.x only)

> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit 
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that 
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618321#comment-16618321
 ] 

ASF GitHub Bot commented on CB-14166:
-

brodybits opened a new pull request #697: CB-14166 distinguish npm.cmd and 
npm.exe in win32 to check escape necessary
URL: https://github.com/apache/cordova-lib/pull/697
 
 
   Cherry-pick of #688 for 8.1.0 as discussed in 
[[1]](https://lists.apache.org/thread.html/23b1a44a35b0bf58792ab2820230dac4236bdcab90573127bf7e91c6@%3Cdev.cordova.apache.org%3E)
   
   [1] 



This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit 
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that 
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618202#comment-16618202
 ] 

ASF GitHub Bot commented on CB-7179:


rafaelberrocalj commented on issue #271: CB-7179 (iOS): Add WKWebView support 
for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422186721
 
 
   Everything looks good and works fine.
   
   One thing i've notice is that the window.alert is not blocking/waiting:
   
   Android: show first alert and stop everything untill i click 'ok' then 
inappbrowser open and second alert block everything untill i click 'ok'.
   iOS: show first alert then inappbrowser open and the second alert is behind 
the inappbrowser. 
   
   Same behavior happens when using events (loadstart/loadstop).
   Android: ok
   iOS: alert is behind inappbrowser
   
   Example (after deviceready):
   ```
   window.alert('test');
   var iap = cordova.inAppBrowser.open('url');
   window.alert('another test');
   iap.addEventListener('loadstart', function(){
  alert('loadstart')
   });
   iap.addEventListener('loadstop', function(){
  alert('loadstop')
   });
   ```
   config.xml
   ```
   https://github.com/dpa99c/cordova-plugin-inappbrowser#CB-7179; />
   
   
  
   
   
   ```
   Build with phonegap-version=cli-8.0.0
   Android Phonegap Version = 7.0.0
   iOS Phonegap Version = 4.5.4
   
   This might be some error or this behavior is expected?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618012#comment-16618012
 ] 

ASF GitHub Bot commented on CB-7179:


rafaelberrocalj commented on issue #271: CB-7179 (iOS): Add WKWebView support 
for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422133965
 
 
   Ah ok, i still need to force the use of it.
   Since iOS 12 is out now i thought it was the primary choice.
   Testing :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617996#comment-16617996
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422130207
 
 
   @rafaelberrocalj yes, if you want to use the WKWebView implementation, 
you'll need the WKWebView engine plugin


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617991#comment-16617991
 ] 

ASF GitHub Bot commented on CB-7179:


rafaelberrocalj commented on issue #271: CB-7179 (iOS): Add WKWebView support 
for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422128475
 
 
   With this changes i still need to use 
https://github.com/apache/cordova-plugin-wkwebview-engine ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617918#comment-16617918
 ] 

ASF GitHub Bot commented on CB-7179:


NiklasMerz edited a comment on issue #271: CB-7179 (iOS): Add WKWebView support 
for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422110912
 
 
   You can install the plugin from the branch which this pull request is based 
on via:
   
   `cordova plugin add 
https://github.com/dpa99c/cordova-plugin-inappbrowser#CB-7179`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617916#comment-16617916
 ] 

ASF GitHub Bot commented on CB-7179:


NiklasMerz commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422110912
 
 
   Just install the plugin from the branch which this pull request is based on 
via:
   
   `cordova plugin add 
https://github.com/dpa99c/cordova-plugin-inappbrowser#CB-7179`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617914#comment-16617914
 ] 

ASF GitHub Bot commented on CB-13179:
-

JiaLiPassion commented on issue #215: CB-13179:(all) invoke onEvent listener 
with _realReader as applyThis
URL: 
https://github.com/apache/cordova-plugin-file/pull/215#issuecomment-422110537
 
 
   @janpio, @raphinesse, sure, I will try it, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova file plugin onEvent(such as onload) should be invoked with 
> _realReader as this
> --
>
> Key: CB-13179
> URL: https://issues.apache.org/jira/browse/CB-13179
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-file
> Environment: Android, ios, Browser
>Reporter: Jia Li
>Priority: Minor
>  Labels: features
>
> When `FileReader` add onEvent listener such as `onload`, it will add the 
> listener to inner `_realReader` , but when it invoke the listener, it use the 
> FileReader as `this`.
> 1. When add onload listener in application code.
> ```javascript
> var fileReader = new FileReader();
> fileReader.onload = function() {};
> ```
> it will call `www/FileReader.js defineEvent`
> ```javascript
> function defineEvent(eventName) {
> utils.defineGetterSetter(FileReader.prototype, eventName, function() {
> return this._realReader[eventName] || null;
> }, function(value) {
> this._realReader[eventName] = value;
> });
> }
> ```  
> the listener is added to `this._realReader`.
> And when the listener is triggered for example in `readSuccessCallback`
> it will invoke the method with `this`.
> ```javascript
> this.onload(new ProgressEvent("load", {target:this}));
> ```
> in the normal senario, it will ok, but when it work with some polyfilles such 
> as `zone.js of angular4`, it will fail because `zone.js` have some special 
> handling which require the `this` object be the same when add listener and 
> invoke listener.
> https://github.com/angular/zone.js/issues/868



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617912#comment-16617912
 ] 

ASF GitHub Bot commented on CB-13179:
-

raphinesse commented on issue #215: CB-13179:(all) invoke onEvent listener with 
_realReader as applyThis
URL: 
https://github.com/apache/cordova-plugin-file/pull/215#issuecomment-422110071
 
 
   @JiaLiPassion you can also set up Travis for your fork of the repo. Might be 
less work and you can make use of the CI config


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova file plugin onEvent(such as onload) should be invoked with 
> _realReader as this
> --
>
> Key: CB-13179
> URL: https://issues.apache.org/jira/browse/CB-13179
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-file
> Environment: Android, ios, Browser
>Reporter: Jia Li
>Priority: Minor
>  Labels: features
>
> When `FileReader` add onEvent listener such as `onload`, it will add the 
> listener to inner `_realReader` , but when it invoke the listener, it use the 
> FileReader as `this`.
> 1. When add onload listener in application code.
> ```javascript
> var fileReader = new FileReader();
> fileReader.onload = function() {};
> ```
> it will call `www/FileReader.js defineEvent`
> ```javascript
> function defineEvent(eventName) {
> utils.defineGetterSetter(FileReader.prototype, eventName, function() {
> return this._realReader[eventName] || null;
> }, function(value) {
> this._realReader[eventName] = value;
> });
> }
> ```  
> the listener is added to `this._realReader`.
> And when the listener is triggered for example in `readSuccessCallback`
> it will invoke the method with `this`.
> ```javascript
> this.onload(new ProgressEvent("load", {target:this}));
> ```
> in the normal senario, it will ok, but when it work with some polyfilles such 
> as `zone.js of angular4`, it will fail because `zone.js` have some special 
> handling which require the `this` object be the same when add listener and 
> invoke listener.
> https://github.com/angular/zone.js/issues/868



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617906#comment-16617906
 ] 

ASF GitHub Bot commented on CB-13179:
-

janpio edited a comment on issue #215: CB-13179:(all) invoke onEvent listener 
with _realReader as applyThis
URL: 
https://github.com/apache/cordova-plugin-file/pull/215#issuecomment-422109188
 
 
   Meh, you're right - sorry. No experience here either :/
   
   Looking at 
https://github.com/apache/cordova-plugin-file/blob/master/.appveyor.yml, 
running both `npm install -g 
cordova-paramedic@https://github.com/apache/cordova-paramedic.git` and `npm 
install -g cordova` might be enough though.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova file plugin onEvent(such as onload) should be invoked with 
> _realReader as this
> --
>
> Key: CB-13179
> URL: https://issues.apache.org/jira/browse/CB-13179
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-file
> Environment: Android, ios, Browser
>Reporter: Jia Li
>Priority: Minor
>  Labels: features
>
> When `FileReader` add onEvent listener such as `onload`, it will add the 
> listener to inner `_realReader` , but when it invoke the listener, it use the 
> FileReader as `this`.
> 1. When add onload listener in application code.
> ```javascript
> var fileReader = new FileReader();
> fileReader.onload = function() {};
> ```
> it will call `www/FileReader.js defineEvent`
> ```javascript
> function defineEvent(eventName) {
> utils.defineGetterSetter(FileReader.prototype, eventName, function() {
> return this._realReader[eventName] || null;
> }, function(value) {
> this._realReader[eventName] = value;
> });
> }
> ```  
> the listener is added to `this._realReader`.
> And when the listener is triggered for example in `readSuccessCallback`
> it will invoke the method with `this`.
> ```javascript
> this.onload(new ProgressEvent("load", {target:this}));
> ```
> in the normal senario, it will ok, but when it work with some polyfilles such 
> as `zone.js of angular4`, it will fail because `zone.js` have some special 
> handling which require the `this` object be the same when add listener and 
> invoke listener.
> https://github.com/angular/zone.js/issues/868



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617904#comment-16617904
 ] 

ASF GitHub Bot commented on CB-13179:
-

janpio commented on issue #215: CB-13179:(all) invoke onEvent listener with 
_realReader as applyThis
URL: 
https://github.com/apache/cordova-plugin-file/pull/215#issuecomment-422109188
 
 
   Meh, you're right - sorry. No experience here either :/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova file plugin onEvent(such as onload) should be invoked with 
> _realReader as this
> --
>
> Key: CB-13179
> URL: https://issues.apache.org/jira/browse/CB-13179
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-file
> Environment: Android, ios, Browser
>Reporter: Jia Li
>Priority: Minor
>  Labels: features
>
> When `FileReader` add onEvent listener such as `onload`, it will add the 
> listener to inner `_realReader` , but when it invoke the listener, it use the 
> FileReader as `this`.
> 1. When add onload listener in application code.
> ```javascript
> var fileReader = new FileReader();
> fileReader.onload = function() {};
> ```
> it will call `www/FileReader.js defineEvent`
> ```javascript
> function defineEvent(eventName) {
> utils.defineGetterSetter(FileReader.prototype, eventName, function() {
> return this._realReader[eventName] || null;
> }, function(value) {
> this._realReader[eventName] = value;
> });
> }
> ```  
> the listener is added to `this._realReader`.
> And when the listener is triggered for example in `readSuccessCallback`
> it will invoke the method with `this`.
> ```javascript
> this.onload(new ProgressEvent("load", {target:this}));
> ```
> in the normal senario, it will ok, but when it work with some polyfilles such 
> as `zone.js of angular4`, it will fail because `zone.js` have some special 
> handling which require the `this` object be the same when add listener and 
> invoke listener.
> https://github.com/angular/zone.js/issues/868



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617894#comment-16617894
 ] 

ASF GitHub Bot commented on CB-13179:
-

JiaLiPassion commented on issue #215: CB-13179:(all) invoke onEvent listener 
with _realReader as applyThis
URL: 
https://github.com/apache/cordova-plugin-file/pull/215#issuecomment-422108053
 
 
   @janpio, @raphinesse, `npm test` will  only run `eslint`, and `CI` will run 
the `real test`, 
   
   ```
   - node /tmp/paramedic/main.js --config pr/$PLATFORM --plugin $(pwd) 
--shouldUseSauce
 --buildName travis-plugin-file-$TRAVIS_JOB_NUMBER
   ```
   
   So may be I have to setup a `cordova` environment to run those `error case`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova file plugin onEvent(such as onload) should be invoked with 
> _realReader as this
> --
>
> Key: CB-13179
> URL: https://issues.apache.org/jira/browse/CB-13179
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-file
> Environment: Android, ios, Browser
>Reporter: Jia Li
>Priority: Minor
>  Labels: features
>
> When `FileReader` add onEvent listener such as `onload`, it will add the 
> listener to inner `_realReader` , but when it invoke the listener, it use the 
> FileReader as `this`.
> 1. When add onload listener in application code.
> ```javascript
> var fileReader = new FileReader();
> fileReader.onload = function() {};
> ```
> it will call `www/FileReader.js defineEvent`
> ```javascript
> function defineEvent(eventName) {
> utils.defineGetterSetter(FileReader.prototype, eventName, function() {
> return this._realReader[eventName] || null;
> }, function(value) {
> this._realReader[eventName] = value;
> });
> }
> ```  
> the listener is added to `this._realReader`.
> And when the listener is triggered for example in `readSuccessCallback`
> it will invoke the method with `this`.
> ```javascript
> this.onload(new ProgressEvent("load", {target:this}));
> ```
> in the normal senario, it will ok, but when it work with some polyfilles such 
> as `zone.js of angular4`, it will fail because `zone.js` have some special 
> handling which require the `this` object be the same when add listener and 
> invoke listener.
> https://github.com/angular/zone.js/issues/868



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617892#comment-16617892
 ] 

ASF GitHub Bot commented on CB-7179:


rafaelberrocalj commented on issue #271: CB-7179 (iOS): Add WKWebView support 
for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422107711
 
 
   Hi, can i test this pull request somehow in config.xml?
   I know it's possible use a github url/branch but i don't know a pull request.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617890#comment-16617890
 ] 

ASF GitHub Bot commented on CB-13179:
-

raphinesse commented on issue #215: CB-13179:(all) invoke onEvent listener with 
_realReader as applyThis
URL: 
https://github.com/apache/cordova-plugin-file/pull/215#issuecomment-422107430
 
 
   Frankly, I have no idea how tests for this repo are set up. But there's 
quite a bit happening in the CI config files. So there might be prerequisites. 
:man_shrugging:


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova file plugin onEvent(such as onload) should be invoked with 
> _realReader as this
> --
>
> Key: CB-13179
> URL: https://issues.apache.org/jira/browse/CB-13179
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-file
> Environment: Android, ios, Browser
>Reporter: Jia Li
>Priority: Minor
>  Labels: features
>
> When `FileReader` add onEvent listener such as `onload`, it will add the 
> listener to inner `_realReader` , but when it invoke the listener, it use the 
> FileReader as `this`.
> 1. When add onload listener in application code.
> ```javascript
> var fileReader = new FileReader();
> fileReader.onload = function() {};
> ```
> it will call `www/FileReader.js defineEvent`
> ```javascript
> function defineEvent(eventName) {
> utils.defineGetterSetter(FileReader.prototype, eventName, function() {
> return this._realReader[eventName] || null;
> }, function(value) {
> this._realReader[eventName] = value;
> });
> }
> ```  
> the listener is added to `this._realReader`.
> And when the listener is triggered for example in `readSuccessCallback`
> it will invoke the method with `this`.
> ```javascript
> this.onload(new ProgressEvent("load", {target:this}));
> ```
> in the normal senario, it will ok, but when it work with some polyfilles such 
> as `zone.js of angular4`, it will fail because `zone.js` have some special 
> handling which require the `this` object be the same when add listener and 
> invoke listener.
> https://github.com/angular/zone.js/issues/868



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617880#comment-16617880
 ] 

ASF GitHub Bot commented on CB-13179:
-

janpio commented on issue #215: CB-13179:(all) invoke onEvent listener with 
_realReader as applyThis
URL: 
https://github.com/apache/cordova-plugin-file/pull/215#issuecomment-422105631
 
 
   Just running `npm test` in the checkout of the project should work. 
(@raphinesse ?)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova file plugin onEvent(such as onload) should be invoked with 
> _realReader as this
> --
>
> Key: CB-13179
> URL: https://issues.apache.org/jira/browse/CB-13179
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-file
> Environment: Android, ios, Browser
>Reporter: Jia Li
>Priority: Minor
>  Labels: features
>
> When `FileReader` add onEvent listener such as `onload`, it will add the 
> listener to inner `_realReader` , but when it invoke the listener, it use the 
> FileReader as `this`.
> 1. When add onload listener in application code.
> ```javascript
> var fileReader = new FileReader();
> fileReader.onload = function() {};
> ```
> it will call `www/FileReader.js defineEvent`
> ```javascript
> function defineEvent(eventName) {
> utils.defineGetterSetter(FileReader.prototype, eventName, function() {
> return this._realReader[eventName] || null;
> }, function(value) {
> this._realReader[eventName] = value;
> });
> }
> ```  
> the listener is added to `this._realReader`.
> And when the listener is triggered for example in `readSuccessCallback`
> it will invoke the method with `this`.
> ```javascript
> this.onload(new ProgressEvent("load", {target:this}));
> ```
> in the normal senario, it will ok, but when it work with some polyfilles such 
> as `zone.js of angular4`, it will fail because `zone.js` have some special 
> handling which require the `this` object be the same when add listener and 
> invoke listener.
> https://github.com/angular/zone.js/issues/868



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617876#comment-16617876
 ] 

ASF GitHub Bot commented on CB-13179:
-

JiaLiPassion commented on issue #215: CB-13179:(all) invoke onEvent listener 
with _realReader as applyThis
URL: 
https://github.com/apache/cordova-plugin-file/pull/215#issuecomment-422104503
 
 
   @janpio, thanks, I have fixed the format staff, but the test case such as 
`file.spec.106 should be able to write a File to a FileWriter`, is that 
possible to run locally?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova file plugin onEvent(such as onload) should be invoked with 
> _realReader as this
> --
>
> Key: CB-13179
> URL: https://issues.apache.org/jira/browse/CB-13179
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-file
> Environment: Android, ios, Browser
>Reporter: Jia Li
>Priority: Minor
>  Labels: features
>
> When `FileReader` add onEvent listener such as `onload`, it will add the 
> listener to inner `_realReader` , but when it invoke the listener, it use the 
> FileReader as `this`.
> 1. When add onload listener in application code.
> ```javascript
> var fileReader = new FileReader();
> fileReader.onload = function() {};
> ```
> it will call `www/FileReader.js defineEvent`
> ```javascript
> function defineEvent(eventName) {
> utils.defineGetterSetter(FileReader.prototype, eventName, function() {
> return this._realReader[eventName] || null;
> }, function(value) {
> this._realReader[eventName] = value;
> });
> }
> ```  
> the listener is added to `this._realReader`.
> And when the listener is triggered for example in `readSuccessCallback`
> it will invoke the method with `this`.
> ```javascript
> this.onload(new ProgressEvent("load", {target:this}));
> ```
> in the normal senario, it will ok, but when it work with some polyfilles such 
> as `zone.js of angular4`, it will fail because `zone.js` have some special 
> handling which require the `this` object be the same when add listener and 
> invoke listener.
> https://github.com/angular/zone.js/issues/868



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617724#comment-16617724
 ] 

ASF GitHub Bot commented on CB-14166:
-

brodybits commented on issue #622: [WIP] CB-14166: (cli) Fixed issue when 
installing plugins on windows
URL: https://github.com/apache/cordova-lib/pull/622#issuecomment-422070440
 
 
   Marked "WIP" since this change waiting for 
 to be merged ref: 



This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit 
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that 
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617725#comment-16617725
 ] 

ASF GitHub Bot commented on CB-14166:
-

AlmirKadric opened a new pull request #622: [WIP] CB-14166: (cli) Fixed issue 
when installing plugins on windows
URL: https://github.com/apache/cordova-lib/pull/622
 
 
   The npm package name is already wrapped in quotes to prevent special 
characters from being execute. However the additional win32 code was further 
injecting quotes around the version causing npm to return a EINVALIDTAGNAME 
error. The win32 code is redundant and seems to not be required.
   
   
   
   ### Platforms affected
   Windows, CLI
   
   ### What does this PR do?
   Fix plugin installation on windows platform
   
   ### What testing has been done on this change?
   Ran it locally and error vanished
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova on windows fails when adding plugin
> ---
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: takuya
>Assignee: Jesse MacFadyen
>Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit 
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that 
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14170) Parsing /platforms/android/res/xml/config.xml failed

2018-09-17 Thread Dave Alden (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-14170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617395#comment-16617395
 ] 

Dave Alden commented on CB-14170:
-

It's just I'm seeing this bug being reported multiple times against my various 
plugins, for example:  
[here|https://github.com/dpa99c/phonegap-launch-navigator/issues/203], 
[here|https://github.com/dpa99c/cordova-custom-config/issues/146], 
[here|https://forum.ionicframework.com/t/cordova-plugins-diagnostic-compatible-with-cordova-android-7-1-1/140683]

> Parsing /platforms/android/res/xml/config.xml failed
> 
>
> Key: CB-14170
> URL: https://issues.apache.org/jira/browse/CB-14170
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: *local packages:*
>     Cordova Platforms : android 7.1.0 ios 4.5.4
>     Cordova Plugins: none
> *System:*
>     Android SDK Tools : 26.1.1
>     ios-deploy        : 1.9.2 
>     ios-sim           : 6.1.2 
>     Node              : v10.4.1
>     npm               : 6.1.0 
>     OS                : macOS High Sierra
>     Xcode             : Xcode 9.4.1 Build version 9F2000 
> *Environment Variables:* 
>     ANDROID_HOME : /Users/alejandro/Library/Android/sdk
>Reporter: Alejandro
>Priority: Major
>
>  
> I get the following error when running cordova run android. Furthermore, the 
> command works with cordova-android 6.4.0 and I am running without any plugin 
> to isolate the issue.
> {code:java}
> Parsing 
> /Users/alejandro/Developer/example/platforms/android/res/xml/config.xml failed
> (node:14144) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or 
> directory, open 
> '/Users/alejandro/Developer/example/platforms/android/res/xml/config.xml'
>     at Object.fs.openSync (fs.js:579:3)
>     at Object.fs.readFileSync (fs.js:485:33)
>     at Object.parseElementtreeSync 
> (/Users/alejandro/Developer/example/platforms/android/cordova/node_modules/cordova-common/src/util/xml-helpers.js:180:27)
>     at new ConfigParser 
> (/Users/alejandro/Developer/example/platforms/android/cordova/node_modules/cordova-common/src/ConfigParser/ConfigParser.js:30:24)
>     at updateConfigFilesFrom 
> (/Users/alejandro/Developer/example/platforms/android/cordova/lib/prepare.js:106:18)
>     at Api.module.exports.prepare 
> (/Users/alejandro/Developer/example/platforms/android/cordova/lib/prepare.js:42:20)
>     at Api.prepare 
> (/Users/alejandro/Developer/example/platforms/android/cordova/Api.js:192:45)
>     at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/prepare.js:106:36
>     at _fulfilled 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
>     at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14170) Parsing /platforms/android/res/xml/config.xml failed

2018-09-17 Thread Dave Alden (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-14170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617392#comment-16617392
 ] 

Dave Alden commented on CB-14170:
-

[~jcesarmobile] is this fixed by  
[#490|https://github.com/apache/cordova-android/pull/490]?

> Parsing /platforms/android/res/xml/config.xml failed
> 
>
> Key: CB-14170
> URL: https://issues.apache.org/jira/browse/CB-14170
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: *local packages:*
>     Cordova Platforms : android 7.1.0 ios 4.5.4
>     Cordova Plugins: none
> *System:*
>     Android SDK Tools : 26.1.1
>     ios-deploy        : 1.9.2 
>     ios-sim           : 6.1.2 
>     Node              : v10.4.1
>     npm               : 6.1.0 
>     OS                : macOS High Sierra
>     Xcode             : Xcode 9.4.1 Build version 9F2000 
> *Environment Variables:* 
>     ANDROID_HOME : /Users/alejandro/Library/Android/sdk
>Reporter: Alejandro
>Priority: Major
>
>  
> I get the following error when running cordova run android. Furthermore, the 
> command works with cordova-android 6.4.0 and I am running without any plugin 
> to isolate the issue.
> {code:java}
> Parsing 
> /Users/alejandro/Developer/example/platforms/android/res/xml/config.xml failed
> (node:14144) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or 
> directory, open 
> '/Users/alejandro/Developer/example/platforms/android/res/xml/config.xml'
>     at Object.fs.openSync (fs.js:579:3)
>     at Object.fs.readFileSync (fs.js:485:33)
>     at Object.parseElementtreeSync 
> (/Users/alejandro/Developer/example/platforms/android/cordova/node_modules/cordova-common/src/util/xml-helpers.js:180:27)
>     at new ConfigParser 
> (/Users/alejandro/Developer/example/platforms/android/cordova/node_modules/cordova-common/src/ConfigParser/ConfigParser.js:30:24)
>     at updateConfigFilesFrom 
> (/Users/alejandro/Developer/example/platforms/android/cordova/lib/prepare.js:106:18)
>     at Api.module.exports.prepare 
> (/Users/alejandro/Developer/example/platforms/android/cordova/lib/prepare.js:42:20)
>     at Api.prepare 
> (/Users/alejandro/Developer/example/platforms/android/cordova/Api.js:192:45)
>     at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/prepare.js:106:36
>     at _fulfilled 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
>     at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617197#comment-16617197
 ] 

ASF GitHub Bot commented on CB-13179:
-

janpio commented on issue #215: CB-13179:(all) invoke onEvent listener with 
_realReader as applyThis
URL: 
https://github.com/apache/cordova-plugin-file/pull/215#issuecomment-421924223
 
 
   Yes, it seems to be some formatting things for now:
   
   ```
   cordova-plugin-file/www/FileReader.js
   139:72error  Strings must use singlequotequotes
   139:92error  Missing space before value for key 'loaded'key-spacing
   139:114error  Missing space before value for key 'total'key-spacing
   159:68error  Strings must use singlequotequotes
   159:84error  Missing space before value for key 'target'key-spacing
   163:71error  Strings must use singlequotequotes
   163:90error  Missing space before value for key 'target'key-spacing
   182:65error  Strings must use singlequotequotes
   182:82error  Missing space before value for key 'target'key-spacing
   186:67error  Strings must use singlequotequotes
   186:86error  Missing space before value for key 'target'key-spacing
   207:82error  Missing space before value for key 'target'key-spacing
   211:86error  Missing space before value for key 'target'key-spacing
   ```
   
   Run locally with `npm run eslint`.
   
   But there are also actual test failures later on:
   
   ```
   ✗ file.spec.106 should be able to write a File to a FileWriter
   -writer.onerror - Error writing content on file: verify.txt
   
{"type":"error","bubbles":false,"cancelBubble":false,"cancelable":false,"lengthComputable":false,"loaded":0,"total":0,"target":{"fileName":"","length":0,"localURL":"file:///persistent/verify.txt","position":0,"readyState":2,"result":null,"error":{"code":9},"onwritestart":null,"onprogress":null,"onwrite":null,"onabort":null}}
   ✗ file.spec.107 should be able to write a sliced File to a FileWriter
   -Expected 0 to be 40.
   -Expected 0 to be 40.
   -writer.onerror - Error writing content on file: verify2.txt
   
{"type":"error","bubbles":false,"cancelBubble":false,"cancelable":false,"lengthComputable":false,"loaded":0,"total":0,"target":{"fileName":"","length":0,"localURL":"file:///persistent/verify2.txt","position":0,"readyState":2,"result":null,"error":{"code":9},"onwritestart":null,"onprogress":null,"onwrite":null,"onabort":null}}
   ✗ file.spec.108 should be able to write binary data from a File
   -Expected 0 to be 10.
   -Expected 0 to be 10.
   -writer.onerror - Error writing content on file: verify.bin
   
{"type":"error","bubbles":false,"cancelBubble":false,"cancelable":false,"lengthComputable":false,"loaded":0,"total":0,"target":{"fileName":"","length":0,"localURL":"file:///persistent/verify.bin","position":0,"readyState":2,"result":null,"error":{"code":9},"onwritestart":null,"onprogress":null,"onwrite":null,"onabort":null}}
 1.1.13 Backwards compatibility
   ✗ file.spec.109 should be able to resolve a file:/// URL
   -Expected 0 to be 32.
   -Expected 0 to be 32.
   ```
   
   You run those with `npm test`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova file plugin onEvent(such as onload) should be invoked with 
> _realReader as this
> --
>
> Key: CB-13179
> URL: https://issues.apache.org/jira/browse/CB-13179
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-file
> Environment: Android, ios, Browser
>Reporter: Jia Li
>Priority: Minor
>  Labels: features
>
> When `FileReader` add onEvent listener such as `onload`, it will add the 
> listener to inner `_realReader` , but when it invoke the listener, it use the 
> FileReader as `this`.
> 1. When add onload listener in application code.
> ```javascript
> var fileReader = new FileReader();
> fileReader.onload = function() {};
> ```
> it will call `www/FileReader.js defineEvent`
> ```javascript
> function defineEvent(eventName) {
> utils.defineGetterSetter(FileReader.prototype, eventName, function() {
> return this._realReader[eventName] || null;
> }, function(value) {
> this._realReader[eventName] = value;
> });
> }
> ```  
> the listener is added to `this._realReader`.
> And when the listener is triggered for example in `readSuccessCallback`
> it will invoke the method with `this`.
> ```javascript
> this.onload(new ProgressEvent("load", {target:this}));
> ```
> in the normal senario, it will ok, but when it work with some polyfilles such 
> as

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617199#comment-16617199
 ] 

ASF GitHub Bot commented on CB-13179:
-

janpio edited a comment on issue #215: CB-13179:(all) invoke onEvent listener 
with _realReader as applyThis
URL: 
https://github.com/apache/cordova-plugin-file/pull/215#issuecomment-421924223
 
 
   Yes, it seems to be some formatting things for now:
   
   ```
   cordova-plugin-file/www/FileReader.js
   139:72error  Strings must use singlequotequotes
   139:92error  Missing space before value for key 'loaded'key-spacing
   139:114error  Missing space before value for key 'total'key-spacing
   159:68error  Strings must use singlequotequotes
   159:84error  Missing space before value for key 'target'key-spacing
   163:71error  Strings must use singlequotequotes
   163:90error  Missing space before value for key 'target'key-spacing
   182:65error  Strings must use singlequotequotes
   182:82error  Missing space before value for key 'target'key-spacing
   186:67error  Strings must use singlequotequotes
   186:86error  Missing space before value for key 'target'key-spacing
   207:82error  Missing space before value for key 'target'key-spacing
   211:86error  Missing space before value for key 'target'key-spacing
   ```
   
   Run locally with `npm run eslint`.
   
   But there are also actual test failures later on:
   
   ```
   ✗ file.spec.106 should be able to write a File to a FileWriter
   -writer.onerror - Error writing content on file: verify.txt
   
{"type":"error","bubbles":false,"cancelBubble":false,"cancelable":false,"lengthComputable":false,"loaded":0,"total":0,"target":{"fileName":"","length":0,"localURL":"file:///persistent/verify.txt","position":0,"readyState":2,"result":null,"error":{"code":9},"onwritestart":null,"onprogress":null,"onwrite":null,"onabort":null}}
   ✗ file.spec.107 should be able to write a sliced File to a FileWriter
   -Expected 0 to be 40.
   -Expected 0 to be 40.
   -writer.onerror - Error writing content on file: verify2.txt
   
{"type":"error","bubbles":false,"cancelBubble":false,"cancelable":false,"lengthComputable":false,"loaded":0,"total":0,"target":{"fileName":"","length":0,"localURL":"file:///persistent/verify2.txt","position":0,"readyState":2,"result":null,"error":{"code":9},"onwritestart":null,"onprogress":null,"onwrite":null,"onabort":null}}
   ✗ file.spec.108 should be able to write binary data from a File
   -Expected 0 to be 10.
   -Expected 0 to be 10.
   -writer.onerror - Error writing content on file: verify.bin
   
{"type":"error","bubbles":false,"cancelBubble":false,"cancelable":false,"lengthComputable":false,"loaded":0,"total":0,"target":{"fileName":"","length":0,"localURL":"file:///persistent/verify.bin","position":0,"readyState":2,"result":null,"error":{"code":9},"onwritestart":null,"onprogress":null,"onwrite":null,"onabort":null}}
 1.1.13 Backwards compatibility
   ✗ file.spec.109 should be able to resolve a file:/// URL
   -Expected 0 to be 32.
   -Expected 0 to be 32.
   ```
   
   You run those with `npm test`.
   
   But thanks for rebasing!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova file plugin onEvent(such as onload) should be invoked with 
> _realReader as this
> --
>
> Key: CB-13179
> URL: https://issues.apache.org/jira/browse/CB-13179
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-file
> Environment: Android, ios, Browser
>Reporter: Jia Li
>Priority: Minor
>  Labels: features
>
> When `FileReader` add onEvent listener such as `onload`, it will add the 
> listener to inner `_realReader` , but when it invoke the listener, it use the 
> FileReader as `this`.
> 1. When add onload listener in application code.
> ```javascript
> var fileReader = new FileReader();
> fileReader.onload = function() {};
> ```
> it will call `www/FileReader.js defineEvent`
> ```javascript
> function defineEvent(eventName) {
> utils.defineGetterSetter(FileReader.prototype, eventName, function() {
> return this._realReader[eventName] || null;
> }, function(value) {
> this._realReader[eventName] = value;
> });
> }
> ```  
> the listener is added to `this._realReader`.
> And when the listener is triggered for example in `readSuccessCallback`
> it will invoke the method with `this`.
> ```javascript
> this.onload(new ProgressEvent("load", {target:this}));
> ```
> in the normal senario, it will ok, but when it

[jira] [Commented] (CB-9393) Embedded use case is undocumented for Cordova-Android 4.0.x

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-9393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617190#comment-16617190
 ] 

ASF GitHub Bot commented on CB-9393:


janpio commented on a change in pull request #544: CB-9393: Documenting how to 
embed a SystemWebView
URL: https://github.com/apache/cordova-docs/pull/544#discussion_r217978219
 
 

 ##
 File path: www/docs/en/dev/guide/platforms/android/webview.md
 ##
 @@ -29,106 +29,86 @@ components can communicate with each other, see 
Application Plugins.
 If you're unfamiliar with Android, you should first familiarize
 yourself with the [Android Platform Guide](index.html) and have the latest 
Android
 SDK installed before you attempt the more unusual development option
-of embedding a WebView.  Starting with Cordova 1.9, the Android
-platform relies on a `CordovaWebView` component, which builds on a
-legacy `CordovaActivity` component that pre-dates the 1.9 release.
+of embedding a WebView.  Starting with Cordova 4.0, the Android
+platform relies on a `SystemWebView` component.
 
 1. To follow these instructions, make sure you have the latest Cordova
distribution. Download it from
[cordova.apache.org](http://cordova.apache.org) and unzip its
Android package.
 
-1. Navigate to the Android package's `/framework` directory and run
-   `ant jar`. It creates the Cordova `.jar` file, formed as
-   `/framework/cordova-x.x.x.jar`.
+1. Create a project in Android Studio
 
-1. Copy the `.jar` file into the Android project's `/libs` directory.
+1. Copy the framework directory into your project's root directory and name it
+CordovaLib
+
+1. Add CordovaLib in your settings.gradle file
+
+include ':app', ':CordovaLib'
+
+1. Add that project as a library project to your main project.  This can be 
done in your application's build.gradle file found in
+app/build.gradle:
+
+dependencies {
+  compile fileTree(dir: 'libs', include: ['*.jar'])
+  compile 'com.android.support:appcompat-v7:21.0.3'
+  //Add Cordova below
+  debugCompile project(path: ":CordovaLib", configuration: "debug")
+  releaseCompile project(path: ":CordovaLib", configuration: 
"release")
+}
 
 1. Add the following to the application's `/res/xml/main.xml` file,
with the `layout_height`, `layout_width` and `id` modified to suit
the application:
 
-
 
-1. Modify the activity so that it implements the `CordovaInterface`.
-   It should implement the included methods.  You may wish to copy
-   them from `/framework/src/org/apache/cordova/CordovaActivity.java`,
-   or else implement them on your own.  The following code fragment
-   shows a basic application that relies on the interface. Note how
-   the referenced view id matches the `id` attribute specified in the
-   XML fragment shown above:
-
-public class CordovaViewTestActivity extends Activity implements 
CordovaInterface {
-CordovaWebView cwv;
-/* Called when the activity is first created. */
-@Override
-public void onCreate(Bundle savedInstanceState) {
-super.onCreate(savedInstanceState);
-setContentView(R.layout.main);
-cwv = (CordovaWebView) findViewById(R.id.tutorialView);
-Config.init(this);
-cwv.loadUrl(Config.getStartUrl());
-}
+1. Add the following code to setup your Activity so that you have an interface
 
-1. If the application needs to use the camera, implement the
-   following:
+private CordovaInterfaceImpl iface = new CordovaInterfaceImpl(this);
+
+1. Add the following to intialize the WebView
 
 Review comment:
   Commenting on old docs PRs is never the right solution. Better create a 
Stack Overflow question.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Embedded use case is undocumented for Cordova-Android 4.0.x
> ---
>
> Key: CB-9393
> URL: https://issues.apache.org/jira/browse/CB-9393
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: 4.0.1
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Major
> Fix For: 5.0.0
>
>
> We broke the embedded webview use case for Android 4.0.x. and it's currently 
> difficult to embed a webview without some gradle editing.  We should probably 
> work on getting the Embedded WebView use case to work out of the box for 
> Gradle, and in the meantime document all the workarounds for

[jira] [Commented] (CB-9393) Embedded use case is undocumented for Cordova-Android 4.0.x

2018-09-17 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-9393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617152#comment-16617152
 ] 

ASF GitHub Bot commented on CB-9393:


sandeep2244 commented on a change in pull request #544: CB-9393: Documenting 
how to embed a SystemWebView
URL: https://github.com/apache/cordova-docs/pull/544#discussion_r217961511
 
 

 ##
 File path: www/docs/en/dev/guide/platforms/android/webview.md
 ##
 @@ -29,106 +29,86 @@ components can communicate with each other, see 
Application Plugins.
 If you're unfamiliar with Android, you should first familiarize
 yourself with the [Android Platform Guide](index.html) and have the latest 
Android
 SDK installed before you attempt the more unusual development option
-of embedding a WebView.  Starting with Cordova 1.9, the Android
-platform relies on a `CordovaWebView` component, which builds on a
-legacy `CordovaActivity` component that pre-dates the 1.9 release.
+of embedding a WebView.  Starting with Cordova 4.0, the Android
+platform relies on a `SystemWebView` component.
 
 1. To follow these instructions, make sure you have the latest Cordova
distribution. Download it from
[cordova.apache.org](http://cordova.apache.org) and unzip its
Android package.
 
-1. Navigate to the Android package's `/framework` directory and run
-   `ant jar`. It creates the Cordova `.jar` file, formed as
-   `/framework/cordova-x.x.x.jar`.
+1. Create a project in Android Studio
 
-1. Copy the `.jar` file into the Android project's `/libs` directory.
+1. Copy the framework directory into your project's root directory and name it
+CordovaLib
+
+1. Add CordovaLib in your settings.gradle file
+
+include ':app', ':CordovaLib'
+
+1. Add that project as a library project to your main project.  This can be 
done in your application's build.gradle file found in
+app/build.gradle:
+
+dependencies {
+  compile fileTree(dir: 'libs', include: ['*.jar'])
+  compile 'com.android.support:appcompat-v7:21.0.3'
+  //Add Cordova below
+  debugCompile project(path: ":CordovaLib", configuration: "debug")
+  releaseCompile project(path: ":CordovaLib", configuration: 
"release")
+}
 
 1. Add the following to the application's `/res/xml/main.xml` file,
with the `layout_height`, `layout_width` and `id` modified to suit
the application:
 
-
 
-1. Modify the activity so that it implements the `CordovaInterface`.
-   It should implement the included methods.  You may wish to copy
-   them from `/framework/src/org/apache/cordova/CordovaActivity.java`,
-   or else implement them on your own.  The following code fragment
-   shows a basic application that relies on the interface. Note how
-   the referenced view id matches the `id` attribute specified in the
-   XML fragment shown above:
-
-public class CordovaViewTestActivity extends Activity implements 
CordovaInterface {
-CordovaWebView cwv;
-/* Called when the activity is first created. */
-@Override
-public void onCreate(Bundle savedInstanceState) {
-super.onCreate(savedInstanceState);
-setContentView(R.layout.main);
-cwv = (CordovaWebView) findViewById(R.id.tutorialView);
-Config.init(this);
-cwv.loadUrl(Config.getStartUrl());
-}
+1. Add the following code to setup your Activity so that you have an interface
 
-1. If the application needs to use the camera, implement the
-   following:
+private CordovaInterfaceImpl iface = new CordovaInterfaceImpl(this);
+
+1. Add the following to intialize the WebView
 
 Review comment:
   what if i want to override 
   
   > setWebChromeClient(WebChromeClient client)
   
   method of systemWebView
   
   I got rutime error of class cast exception 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Embedded use case is undocumented for Cordova-Android 4.0.x
> ---
>
> Key: CB-9393
> URL: https://issues.apache.org/jira/browse/CB-9393
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: 4.0.1
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Major
> Fix For: 5.0.0
>
>
> We broke the embedded webview use case for Android 4.0.x. and it's currently 
> difficult to embed a webview without some gradle editing.  We should probably 
> work on getting the Embedded WebView use case to work out of the box for

[jira] [Assigned] (CB-10608) iOS - update to recommended project settings warning

[jira] [Assigned] (CB-10186) Update PROJECTNAME.xcodeproj to recommended settings in Xcode 7.2

[jira] [Closed] (CB-10169) Fetch API support

[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin

[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin

[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin

[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin

[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin

[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin

[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin

[jira] [Commented] (CB-14170) Parsing /platforms/android/res/xml/config.xml failed

[jira] [Commented] (CB-14170) Parsing /platforms/android/res/xml/config.xml failed

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this

[jira] [Commented] (CB-9393) Embedded use case is undocumented for Cordova-Android 4.0.x

[jira] [Commented] (CB-9393) Embedded use case is undocumented for Cordova-Android 4.0.x

32 matches

Site Navigation

Mail list logo

Footer information