[jira] [Commented] (CB-10141) cdvfile:// urls will not work in WKWebViewEngine

2018-09-25 Thread Shazron Abdullah (JIRA) 


[ 
https://issues.apache.org/jira/browse/CB-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628251#comment-16628251
 ] 

Shazron Abdullah commented on CB-10141:
---

You'll need to handle this in native code with WKURLSchemeHandler. Our plugin 
does not have a generalized solution for this.
https://developer.apple.com/documentation/webkit/wkurlschemehandler

> cdvfile:// urls will not work in WKWebViewEngine
> 
>
> Key: CB-10141
> URL: https://issues.apache.org/jira/browse/CB-10141
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-file, cordova-plugin-wkwebview-engine
>Reporter: Shazron Abdullah
>Priority: Major
>  Labels: wkwebview-baked-in, wkwebview-known-issues
>
> This was handled in a NSURLProtocol (in the File plugin), which cannot 
> intercept WKWebView connections.
> This affects native URIs returned by the Camera and File plugins.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13740) CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)

2018-09-25 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628066#comment-16628066
 ] 

ASF subversion and git services commented on CB-13740:
--

Commit 9a38451467eb5a9b75adc39c74508dd512dbec2d in cordova-browser's branch 
refs/heads/master from [~purplecabbage]
[ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=9a38451 ]

CB-13740 return expected promise resolving with array


> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
> 
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node:  v7.5.0
> NPM:  4.1.2
> Cordova CLI:  8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM:  5.6.0
> Cordova CLI:  8.0.0
>Reporter: Sasha Kalmikov
>Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection 
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated. 
> In the future, promise rejections that are not handled will terminate the 
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read 
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map ()
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> at Function.Module.runMain (module.js:703:11)
> (node:72094) UnhandledPromiseRejectionWarning: Unhandled promise rejection. 
> This error originated either by throwing inside of an async function without 
> a catch block, or by rejecting a promise which was not handled with .catch(). 
> (rejection id: 1)
> (node:72094) [DEP0018] DeprecationWarning: Unhandled promise rejections are 
> deprecated. In the future, promise rejections that are not handled will 
> terminate the Node.js process with a non-zero exit code.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13740) CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)

2018-09-25 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628068#comment-16628068
 ] 

ASF subversion and git services commented on CB-13740:
--

Commit 5ce40e53e2ea2be61c78dd3c9c6b9f27c58cc80a in cordova-browser's branch 
refs/heads/master from [~purplecabbage]
[ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=5ce40e5 ]

Merge pull request #61 from purplecabbage/CB-13740

CB-13740 return expected promise resolving with array

> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
> 
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node:  v7.5.0
> NPM:  4.1.2
> Cordova CLI:  8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM:  5.6.0
> Cordova CLI:  8.0.0
>Reporter: Sasha Kalmikov
>Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection 
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated. 
> In the future, promise rejections that are not handled will terminate the 
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read 
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map ()
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> at Function.Module.runMain (module.js:703:11)
> (node:72094) UnhandledPromiseRejectionWarning: Unhandled promise rejection. 
> This error originated either by throwing inside of an async function without 
> a catch block, or by rejecting a promise which was not handled with .catch(). 
> (rejection id: 1)
> (node:72094) [DEP0018] DeprecationWarning: Unhandled promise rejections are 
> deprecated. In the future, promise rejections that are not handled will 
> terminate the Node.js process with a non-zero exit code.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13740) CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)

2018-09-25 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628065#comment-16628065
 ] 

ASF GitHub Bot commented on CB-13740:
-

purplecabbage closed pull request #61: CB-13740 return expected promise 
resolving with array
URL: https://github.com/apache/cordova-browser/pull/61
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bin/lib/check_reqs.js b/bin/lib/check_reqs.js
index 172aa38..c615e14 100644
--- a/bin/lib/check_reqs.js
+++ b/bin/lib/check_reqs.js
@@ -22,5 +22,6 @@ under the License.
 // add methods as we determine what are the requirements
 
 module.exports.run = function () {
-return Promise.resolve();
+// caller expects a promise resolved with an array of conditions
+return Promise.resolve([]);
 };


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
> 
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node:  v7.5.0
> NPM:  4.1.2
> Cordova CLI:  8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM:  5.6.0
> Cordova CLI:  8.0.0
>Reporter: Sasha Kalmikov
>Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection 
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated. 
> In the future, promise rejections that are not handled will terminate the 
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read 
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map ()
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> at Function.Module.runMain (module.js:703:11)
> (node:72094) UnhandledPromiseRejectionWarning: Unhandled promise rejection. 
> This error originated either by throwing inside of an async function without 
> a catch block, or by rejecting a promise which was not handled with .catch(). 
> (rejection id: 1)
> (node:72094) [DEP0018] DeprecationWarning: Unhandled promise rejections are 
> deprecated. In the future, promise rejections that are not handled will 
> terminate the Node.js process with a non-zero exit code.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13740) CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)

2018-09-25 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628067#comment-16628067
 ] 

ASF subversion and git services commented on CB-13740:
--

Commit 5ce40e53e2ea2be61c78dd3c9c6b9f27c58cc80a in cordova-browser's branch 
refs/heads/master from [~purplecabbage]
[ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=5ce40e5 ]

Merge pull request #61 from purplecabbage/CB-13740

CB-13740 return expected promise resolving with array

> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
> 
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node:  v7.5.0
> NPM:  4.1.2
> Cordova CLI:  8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM:  5.6.0
> Cordova CLI:  8.0.0
>Reporter: Sasha Kalmikov
>Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection 
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated. 
> In the future, promise rejections that are not handled will terminate the 
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read 
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map ()
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> at Function.Module.runMain (module.js:703:11)
> (node:72094) UnhandledPromiseRejectionWarning: Unhandled promise rejection. 
> This error originated either by throwing inside of an async function without 
> a catch block, or by rejecting a promise which was not handled with .catch(). 
> (rejection id: 1)
> (node:72094) [DEP0018] DeprecationWarning: Unhandled promise rejections are 
> deprecated. In the future, promise rejections that are not handled will 
> terminate the Node.js process with a non-zero exit code.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-13740) CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)

2018-09-25 Thread Jesse MacFadyen (JIRA) 


 [ 
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesse MacFadyen resolved CB-13740.
--
Resolution: Fixed

> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
> 
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node:  v7.5.0
> NPM:  4.1.2
> Cordova CLI:  8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM:  5.6.0
> Cordova CLI:  8.0.0
>Reporter: Sasha Kalmikov
>Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection 
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated. 
> In the future, promise rejections that are not handled will terminate the 
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read 
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map ()
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> at Function.Module.runMain (module.js:703:11)
> (node:72094) UnhandledPromiseRejectionWarning: Unhandled promise rejection. 
> This error originated either by throwing inside of an async function without 
> a catch block, or by rejecting a promise which was not handled with .catch(). 
> (rejection id: 1)
> (node:72094) [DEP0018] DeprecationWarning: Unhandled promise rejections are 
> deprecated. In the future, promise rejections that are not handled will 
> terminate the Node.js process with a non-zero exit code.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13740) CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)

2018-09-25 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628009#comment-16628009
 ] 

ASF GitHub Bot commented on CB-13740:
-

purplecabbage closed pull request #335: CB-13740 safe requirements check
URL: https://github.com/apache/cordova-cli/pull/335
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/cli.js b/src/cli.js
index 77cdbbd2..26082975 100644
--- a/src/cli.js
+++ b/src/cli.js
@@ -381,17 +381,21 @@ function cli (inputArgs) {
 }
 
 var someChecksFailed = false;
-platformCheck.forEach(function (checkItem) {
-var checkSummary = checkItem.name + ': ' +
-(checkItem.installed ? 'installed ' : 'not 
installed ') +
-(checkItem.installed ? 
checkItem.metadata.version.version || checkItem.metadata.version : '');
-events.emit('log', checkSummary);
-if (!checkItem.installed) {
-someChecksFailed = true;
-events.emit('warn', checkItem.metadata.reason);
-}
-});
 
+// platformCheck is expected to be an array of conditions 
that must be met
+// the browser platform currently returns nothing, which 
was breaking here.
+if (platformCheck && platformCheck.forEach) {
+platformCheck.forEach(function (checkItem) {
+var checkSummary = checkItem.name + ': ' +
+(checkItem.installed ? 'installed ' : 'not 
installed ') +
+(checkItem.installed ? 
checkItem.metadata.version.version || checkItem.metadata.version : '');
+events.emit('log', checkSummary);
+if (!checkItem.installed) {
+someChecksFailed = true;
+events.emit('warn', checkItem.metadata.reason);
+}
+});
+}
 return someChecksFailed;
 }).some(function (isCheckFailedForPlatform) {
 return isCheckFailedForPlatform;


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
> 
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node:  v7.5.0
> NPM:  4.1.2
> Cordova CLI:  8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM:  5.6.0
> Cordova CLI:  8.0.0
>Reporter: Sasha Kalmikov
>Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection 
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated. 
> In the future, promise rejections that are not handled will terminate the 
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read 
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map ()
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush 
> (/usr/local/lib/node_modules/cordova/node_m

[jira] [Commented] (CB-13740) CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)

2018-09-25 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628011#comment-16628011
 ] 

ASF subversion and git services commented on CB-13740:
--

Commit 890d336a29c586633b4cfa1f714c1afe5e604ac6 in cordova-cli's branch 
refs/heads/master from [~purplecabbage]
[ https://gitbox.apache.org/repos/asf?p=cordova-cli.git;h=890d336 ]

Merge pull request #335 from purplecabbage/CB-13740

CB-13740 safe requirements check

> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
> 
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node:  v7.5.0
> NPM:  4.1.2
> Cordova CLI:  8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM:  5.6.0
> Cordova CLI:  8.0.0
>Reporter: Sasha Kalmikov
>Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection 
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated. 
> In the future, promise rejections that are not handled will terminate the 
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read 
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map ()
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> at Function.Module.runMain (module.js:703:11)
> (node:72094) UnhandledPromiseRejectionWarning: Unhandled promise rejection. 
> This error originated either by throwing inside of an async function without 
> a catch block, or by rejecting a promise which was not handled with .catch(). 
> (rejection id: 1)
> (node:72094) [DEP0018] DeprecationWarning: Unhandled promise rejections are 
> deprecated. In the future, promise rejections that are not handled will 
> terminate the Node.js process with a non-zero exit code.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13740) CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)

2018-09-25 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628008#comment-16628008
 ] 

ASF GitHub Bot commented on CB-13740:
-

purplecabbage opened a new pull request #61: CB-13740 return expected promise 
resolving with array
URL: https://github.com/apache/cordova-browser/pull/61
 
 
   
   ### Platforms affected
   - browser
   
   ### What does this PR do?
   - returns what is expected, fixes error in cordova-cli where the return 
value from here was not checked
   
   ### What testing has been done on this change?
   none
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [x] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
> 
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node:  v7.5.0
> NPM:  4.1.2
> Cordova CLI:  8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM:  5.6.0
> Cordova CLI:  8.0.0
>Reporter: Sasha Kalmikov
>Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection 
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated. 
> In the future, promise rejections that are not handled will terminate the 
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read 
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map ()
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> at Function.Module.runMain (module.js:703:11)
> (node:72094) UnhandledPromiseRejectionWarning: Unhandled promise rejection. 
> This error originated either by throwing inside of an async function without 
> a catch block, or by rejecting a promise which was not handled with .catch(). 
> (rejection id: 1)
> (node:72094) [DEP0018] DeprecationWarning: Unhandled promise rejections are 
> deprecated. In the future, promise rejections that are not handled will 
> terminate the Node.js process with a non-zero exit code.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13740) CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)

2018-09-25 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628010#comment-16628010
 ] 

ASF subversion and git services commented on CB-13740:
--

Commit f10a3719dce40f165f00864110ea6bcae336b38e in cordova-cli's branch 
refs/heads/master from [~purplecabbage]
[ https://gitbox.apache.org/repos/asf?p=cordova-cli.git;h=f10a371 ]

CB-13740 gracefully handle platforms that don't pass back requirements to check


> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
> 
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node:  v7.5.0
> NPM:  4.1.2
> Cordova CLI:  8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM:  5.6.0
> Cordova CLI:  8.0.0
>Reporter: Sasha Kalmikov
>Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection 
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated. 
> In the future, promise rejections that are not handled will terminate the 
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read 
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map ()
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> at Function.Module.runMain (module.js:703:11)
> (node:72094) UnhandledPromiseRejectionWarning: Unhandled promise rejection. 
> This error originated either by throwing inside of an async function without 
> a catch block, or by rejecting a promise which was not handled with .catch(). 
> (rejection id: 1)
> (node:72094) [DEP0018] DeprecationWarning: Unhandled promise rejections are 
> deprecated. In the future, promise rejections that are not handled will 
> terminate the Node.js process with a non-zero exit code.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13740) CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)

2018-09-25 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628012#comment-16628012
 ] 

ASF subversion and git services commented on CB-13740:
--

Commit 890d336a29c586633b4cfa1f714c1afe5e604ac6 in cordova-cli's branch 
refs/heads/master from [~purplecabbage]
[ https://gitbox.apache.org/repos/asf?p=cordova-cli.git;h=890d336 ]

Merge pull request #335 from purplecabbage/CB-13740

CB-13740 safe requirements check

> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
> 
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node:  v7.5.0
> NPM:  4.1.2
> Cordova CLI:  8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM:  5.6.0
> Cordova CLI:  8.0.0
>Reporter: Sasha Kalmikov
>Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection 
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated. 
> In the future, promise rejections that are not handled will terminate the 
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read 
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map ()
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> at Function.Module.runMain (module.js:703:11)
> (node:72094) UnhandledPromiseRejectionWarning: Unhandled promise rejection. 
> This error originated either by throwing inside of an async function without 
> a catch block, or by rejecting a promise which was not handled with .catch(). 
> (rejection id: 1)
> (node:72094) [DEP0018] DeprecationWarning: Unhandled promise rejections are 
> deprecated. In the future, promise rejections that are not handled will 
> terminate the Node.js process with a non-zero exit code.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13740) CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)

2018-09-25 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627994#comment-16627994
 ] 

ASF GitHub Bot commented on CB-13740:
-

purplecabbage opened a new pull request #335: CB-13740 safe requirements check
URL: https://github.com/apache/cordova-cli/pull/335
 
 
   gracefully handle platforms that don't pass back requirements to check
   
   
   
   ### Platforms affected
   - any platform that does not correctly return an array of requirements to 
check
   
   ### What does this PR do?
   - skips gracefully
   
   ### What testing has been done on this change?
   
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [x] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
> 
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node:  v7.5.0
> NPM:  4.1.2
> Cordova CLI:  8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM:  5.6.0
> Cordova CLI:  8.0.0
>Reporter: Sasha Kalmikov
>Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection 
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated. 
> In the future, promise rejections that are not handled will terminate the 
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read 
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map ()
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> at Function.Module.runMain (module.js:703:11)
> (node:72094) UnhandledPromiseRejectionWarning: Unhandled promise rejection. 
> This error originated either by throwing inside of an async function without 
> a catch block, or by rejecting a promise which was not handled with .catch(). 
> (rejection id: 1)
> (node:72094) [DEP0018] DeprecationWarning: Unhandled promise rejections are 
> deprecated. In the future, promise rejections that are not handled will 
> terminate the Node.js process with a non-zero exit code.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10141) cdvfile:// urls will not work in WKWebViewEngine

2018-09-25 Thread Shan Lin (JIRA) 


[ 
https://issues.apache.org/jira/browse/CB-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627713#comment-16627713
 ] 

Shan Lin commented on CB-10141:
---

Shazron, I built a simple cordova app with Xcode 9.4.1 and cordova-ios 4.5.4, 
and tested with IOS 11 device.  The app still cannot handle custom url scheme, 
like: otpauth://  It complaints with message of "Failed to load webpage 
with error: unsupported URL".  Do you know if it is the limitation of 
cordova-plugin-wkwebview-engine?

> cdvfile:// urls will not work in WKWebViewEngine
> 
>
> Key: CB-10141
> URL: https://issues.apache.org/jira/browse/CB-10141
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-file, cordova-plugin-wkwebview-engine
>Reporter: Shazron Abdullah
>Priority: Major
>  Labels: wkwebview-baked-in, wkwebview-known-issues
>
> This was handled in a NSURLProtocol (in the File plugin), which cannot 
> intercept WKWebView connections.
> This affects native URIs returned by the Camera and File plugins.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org