date:20181002

[jira] [Commented] (CB-12074) Cookies are ignored on first application execution

2018-10-02 Thread Christopher Cook (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-12074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636361#comment-16636361
 ] 

Christopher Cook commented on CB-12074:
---

For what it's worth, the Apple Webkit developers are waiting on someone to 
provide a test case: [https://bugs.webkit.org/show_bug.cgi?id=177478] so if 
anyone can prove this issue directly in a short swift/obj-c sample that would 
be great as you would literally be helping to fix thousands of apps/workflows.

> Cookies are ignored on first application execution
> --
>
> Key: CB-12074
> URL: https://issues.apache.org/jira/browse/CB-12074
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-wkwebview-engine
> Environment: Cordova 5.4.0, iOS 9.3.5
>Reporter: Maxim
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: wkwebview-known-issues
>
> Our application authenticates to the server. The server sets a 'JSESSIONID' 
> cookie. The cookie is used by the server for session management. 
> The issue is WKWebView does not send this cookie back to the server on 
> subsequent requests. However, this only happens on first execution of the 
> application, after its installation. Once the application closed and 
> re-opened, the cookies are properly sent and authentication completes 
> successfully. 
> The problematic behavior is consistent, and was observed on several devices. 
> On the other hand, there are no such issues with UIWebView. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-10-02 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636107#comment-16636107
 ] 

ASF GitHub Bot commented on CB-13396:
-

kenmickles commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-426427107
 
 
   @janpio I don't even remember what this did at this point. Gonna close the 
PR...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>Priority: Major
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-10-02 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636108#comment-16636108
 ] 

ASF GitHub Bot commented on CB-13396:
-

kenmickles closed pull request #135: CB-13396: (ios) Fix image sizing on iPhone 
X
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/ios/CDVSplashScreen.m b/src/ios/CDVSplashScreen.m
index ab97055a..fdab6ee3 100644
--- a/src/ios/CDVSplashScreen.m
+++ b/src/ios/CDVSplashScreen.m
@@ -352,7 +352,15 @@ - (void)updateBounds
 if ([self isUsingCDVLaunchScreen]) {
 // CB-9762's launch screen expects the image to fill the screen and be 
scaled using AspectFill.
 CGSize viewportSize = [UIApplication 
sharedApplication].delegate.window.bounds.size;
-_imageView.frame = CGRectMake(0, 0, viewportSize.width, 
viewportSize.height);
+CGFloat imageHeight = viewportSize.height;
+
+// make LaunchStoryboard bottom space constraint work with iOS 11 safe 
areas
+if (@available(iOS 11.0, *)) {
+UIEdgeInsets safeAreaInsets = [UIApplication 
sharedApplication].delegate.window.safeAreaInsets;
+imageHeight -= safeAreaInsets.bottom;
+}
+
+_imageView.frame = CGRectMake(0, 0, viewportSize.width, imageHeight);
 _imageView.contentMode = UIViewContentModeScaleAspectFill;
 return; 
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>Priority: Major
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app

2018-10-02 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636064#comment-16636064
 ] 

ASF GitHub Bot commented on CB-13415:
-

janpio commented on issue #310: CB-13415 (iOS) Importing corrupt images using 
the Camera plugin crashes the app
URL: 
https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-426414158
 
 
   1 test failure left:
   ```
   Test Case '-[CameraTest testProcessImage]' failed (0.174 seconds).
   Test Case '-[CameraTest testRetrieveImage]' started.
   Test Case '-[CameraTest testRetrieveImage]' passed (0.316 seconds).
   Test Suite 'CameraTest' failed at 2018-09-30 01:20:33.535.
 Executed 7 tests, with 1 failure (1 unexpected) in 5.831 (5.848) 
seconds
   Test Suite 'CDVCameraLibTests.xctest' failed at 2018-09-30 01:20:33.537.
 Executed 7 tests, with 1 failure (1 unexpected) in 5.831 (5.852) 
seconds
   Test Suite 'All tests' failed at 2018-09-30 01:20:33.543.
 Executed 7 tests, with 1 failure (1 unexpected) in 5.831 (5.858) 
seconds
   Failing tests:
-[CameraTest testProcessImage]
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Importing corrupt images using the Camera plugin crashes the app
> 
>
> Key: CB-13415
> URL: https://issues.apache.org/jira/browse/CB-13415
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
> Environment: Android: OS 7.0, Phone Model: Moto G5 Plus
> iOS: OS 10.1.1 (14B150)
>Reporter: Shemrick Flannigan
>Priority: Critical
>  Labels: android, camera, cameraui, ios
>
> ISSUE
> Importing corrupt images using the Camera plugin crashes the app
> Current Behavior
> # Importing a corrupt image using the Cordova Camera plugin crashes the 
> Cordova app which uses the plugin
> Expected Behavior
> # Importing a corrupt image using the Cordova Camera plugin:
> #* Throws an exception which can be caught by the Cordova app which uses the 
> plugin
> #* Does not crash the Cordova app which uses the plugin
> #* Allows the Cordova app which uses the plugin to render a Toast error 
> message relaying the error
> # # Platforms affected
> #* Android
> #* iOS
> REFERENCES
> # [Sample corrupt image which crashes the app | 
> https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0]
> # [Technique used to wrap the call in a Try/Catch block in a callable inner 
> class to prevent an app crash | 
> https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] 
> ADDITIONAL INFORMATION
> # Importing corrupt images does not crash apps which do not use the Camera 
> plugin, such as:
> #* Yelp mobile app
> #* Slack mobile app



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13316) Update documentation regarding browser quirks

2018-10-02 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636059#comment-16636059
 ] 

ASF GitHub Bot commented on CB-13316:
-

janpio commented on issue #287: CB-13316: (browser) Updated readme browser 
quirks
URL: 
https://github.com/apache/cordova-plugin-camera/pull/287#issuecomment-426413154
 
 
   @andreszs, you removed the previous quirk. Was that not true?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update documentation regarding browser quirks
> -
>
> Key: CB-13316
> URL: https://issues.apache.org/jira/browse/CB-13316
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Affects Versions: Master, 2.4.1
> Environment: CLI 6.5.0@browser 4.1.0
> Using [cordova-simulate|https://github.com/Microsoft/cordova-simulate] in 
> Chrome
>Reporter: Andres Zsogon
>Priority: Major
>  Labels: browser, readme
>
> According to the README, the only *Browser Quirk* is:
> {quote}Can only return photos as Base64-encoded image.{quote}
> However this is not the case from my testing. Instead, I get this result:
> {noformat}
> blob:http://localhost:8000/259e6e9e-bb2f-47d0-939d-51461bd7d47c
> {noformat}
> Also, the image is not resized, it's returned in its natural size.
> This is the {{options}} object used:
> {code:javascript}
> var options = {
>   quality: 100,
>   destinationType: Camera.DestinationType.FILE_URI,
>   sourceType: Camera.PictureSourceType.SAVEDPHOTOALBUM,
>   encodingType: Camera.EncodingType.JPEG,
>   mediaType: Camera.MediaType.PICTURE,
>   allowEdit: true,
>   correctOrientation: true,
>   targetHeight: 240,
>   targetWidth: 240
> }
> {code}
> Using {{Camera.DestinationType.DATA_URI}} does return a base64 encoded image 
> but it *does not resize it* either, it returns in its original size.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-10-02 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636053#comment-16636053
 ] 

ASF GitHub Bot commented on CB-13396:
-

janpio commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-426412447
 
 
   @kenmickles Tests are failing on iOS, app cannot be built. Can you have a 
look please? Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>Priority: Major
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12479) InAppBrowser: Add Loading Spinner for Android

2018-10-02 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636037#comment-16636037
 ] 

ASF GitHub Bot commented on CB-12479:
-

janpio commented on issue #88: CB-12479: Add loading spinner for android
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/88#issuecomment-426409145
 
 
   (After final changes on our test environment the tests are now passing. 
Thanks for your help)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> InAppBrowser: Add Loading Spinner for Android
> -
>
> Key: CB-12479
> URL: https://issues.apache.org/jira/browse/CB-12479
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 2.5.0, 2.6.0, 2.7.0, 2.8.0
> Environment: Android (at least)
>Reporter: jcesarmobile
>Priority: Trivial
>  Labels: Triaged
>
> In CB-3750 a loader spinner was added for iOS. There was another PR for 
> Android but it was never merged, so I'm creating this new issue for Android.
> PR https://github.com/apache/cordova-plugin-inappbrowser/pull/88



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method

2018-10-02 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636023#comment-16636023
 ] 

ASF GitHub Bot commented on CB-12468:
-

janpio commented on issue #213: CB-12468 added ability to set|get default 
options;
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/213#issuecomment-426405042
 
 
   One last rebase on `master` should get the tests passing now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-inappbrowser-plugin setDefaultOptions method
> 
>
> Key: CB-12468
> URL: https://issues.apache.org/jira/browse/CB-12468
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-lib
>Affects Versions: 3.5.0
> Environment: IOS/Android
>Reporter: Ivan Prodaiko
>Priority: Major
>  Labels: features
> Fix For: Master
>
>
> While using cordova-inappbrowser-plugin I must set popup features only when 
> calling window.open method. But a lot of libraries (firebase, openFB) use 
> window.open inside their own code where I can't directly menage the features 
> of window to be opened, and on IOS, where we do not a have a 'back' button we 
> could have a problem. For example window, opened with 'toolbar=no' will make 
> app to stack with no ability to close the window. Another thing to be 
> mentioned is when on IOS you use  attribute, after opening a 
> new window without setting 'allowInlineMediaPlayback=yes' all inline 
> attributes will stop working properly and video will start to open in a 
> fullscreen mode.
> So, my proposal is to provide an ability to setDefaultOptions method that 
> will help to prevent external libraries to manage the options of of window to 
> be opened directly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14188) Callback to decide whether to open link or not.

2018-10-02 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636021#comment-16636021
 ] 

ASF GitHub Bot commented on CB-14188:
-

janpio commented on issue #276: CB-14188: Add beforeload event, catching 
navigation before it happens
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/276#issuecomment-426404710
 
 
   And passing :) (context: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-426404322)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Callback to decide whether to open link or not.
> ---
>
> Key: CB-14188
> URL: https://issues.apache.org/jira/browse/CB-14188
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> Several times I've found myself wanting to tell inAppBrowser whether it can 
> open a link in the embedded webview or using the system web browser. It would 
> be great if there's a callback _before_ loading a page (loadstart is too late 
> there), where I can tell inAppBrowser to load the page or not.
> CB-14013 introduced AllowedSchemes, but excluded the use of http and https. 
> -It would be useful to allow intercepting http and https links, e.g. to 
> decide whether to open the link in the system web browser or not.- At first I 
> thought this mechanism could be used, but because of the asynchronous nature 
> of Cordova callbacks, this didn't work out, and I added a beforeload 
> callback. See comment for an example.
> I've submitted a PR -(my approach would be to generate a regexp based on 
> AllowedSchemes and match the URL on that, instead of the current if logic)-.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

2018-10-02 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636022#comment-16636022
 ] 

ASF GitHub Bot commented on CB-14187:
-

janpio commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-426404825
 
 
   And passing :) (context: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-426404322)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-12941) Update typings to latest DefinitelyTyped revision

2018-10-02 Thread Jan Piotrowski (Sujan) (JIRA)



 [ 
https://issues.apache.org/jira/browse/CB-12941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) resolved CB-12941.
-
Resolution: Fixed

was merged

> Update typings to latest DefinitelyTyped revision
> -
>
> Key: CB-12941
> URL: https://issues.apache.org/jira/browse/CB-12941
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
>Reporter: Tim Brust
>Priority: Major
>  Labels: inappbrowser, plugins, typescript, typings
>
> Update the typings in the cordova-plugin-inappbrowser to match the current 
> revision published via DefinitelyTyped.
> This fixes e.g. this issue: https://stackoverflow.com/q/42095516/1902598
> DefinitelyTyped PR: 
> https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17192



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12941) Update typings to latest DefinitelyTyped revision

2018-10-02 Thread ASF subversion and git services (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-12941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635224#comment-16635224
 ] 

ASF subversion and git services commented on CB-12941:
--

Commit a0c267fe36be9a97c974f73b9d2160eca54b9828 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~timbru31]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=a0c267f 
]

CB-12941: update typings (#267)

### Platforms affected
n/a - development with TypeScript

### What does this PR do?
Updates the typings to match the latest published version on DefinitelyTyped.  
See https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17192 and 
https://stackoverflow.com/q/42095516/1902598

### What testing has been done on this change?
Project compiles again ;)

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in 
the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- n/a: Added automated test coverage as appropriate for this change.

fixes #300


> Update typings to latest DefinitelyTyped revision
> -
>
> Key: CB-12941
> URL: https://issues.apache.org/jira/browse/CB-12941
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
>Reporter: Tim Brust
>Priority: Major
>  Labels: inappbrowser, plugins, typescript, typings
>
> Update the typings in the cordova-plugin-inappbrowser to match the current 
> revision published via DefinitelyTyped.
> This fixes e.g. this issue: https://stackoverflow.com/q/42095516/1902598
> DefinitelyTyped PR: 
> https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17192



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12941) Update typings to latest DefinitelyTyped revision

2018-10-02 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-12941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635223#comment-16635223
 ] 

ASF GitHub Bot commented on CB-12941:
-

janpio closed pull request #267: CB-12941: update typings
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/267
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/types/index.d.ts b/types/index.d.ts
index ea3d3adba..3bac6707b 100644
--- a/types/index.d.ts
+++ b/types/index.d.ts
@@ -2,38 +2,13 @@
 // Project: https://github.com/apache/cordova-plugin-inappbrowser
 // Definitions by: Microsoft Open Technologies Inc 
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
-// 
+//
 // Copyright (c) Microsoft Open Technologies Inc
 // Licensed under the MIT license.
+// TypeScript Version: 2.3
+type channel = "loadstart" | "loadstop" | "loaderror" | "exit";
 
 interface Window {
-/**
- * Opens a URL in a new InAppBrowser instance, the current browser 
instance, or the system browser.
- * @param  url The URL to load.
- * @param  target  The target in which to load the URL, an optional 
parameter that defaults to _self.
- * @param  options Options for the InAppBrowser. Optional, defaulting to: 
location=yes.
- * The options string must not contain any blank space, 
and each feature's
- * name/value pairs must be separated by a comma. Feature 
names are case insensitive.
- */
-open(url: string, target?: "_self", options?: string): InAppBrowser;
-/**
- * Opens a URL in a new InAppBrowser instance, the current browser 
instance, or the system browser.
- * @param  url The URL to load.
- * @param  target  The target in which to load the URL, an optional 
parameter that defaults to _self.
- * @param  options Options for the InAppBrowser. Optional, defaulting to: 
location=yes.
- * The options string must not contain any blank space, 
and each feature's
- * name/value pairs must be separated by a comma. Feature 
names are case insensitive.
- */
-open(url: string, target?: "_blank", options?: string): InAppBrowser;
-/**
- * Opens a URL in a new InAppBrowser instance, the current browser 
instance, or the system browser.
- * @param  url The URL to load.
- * @param  target  The target in which to load the URL, an optional 
parameter that defaults to _self.
- * @param  options Options for the InAppBrowser. Optional, defaulting to: 
location=yes.
- * The options string must not contain any blank space, 
and each feature's
- * name/value pairs must be separated by a comma. Feature 
names are case insensitive.
- */
-open(url: string, target?: "_system", options?: string): InAppBrowser;
 /**
  * Opens a URL in a new InAppBrowser instance, the current browser 
instance, or the system browser.
  * @param  url The URL to load.
@@ -50,66 +25,21 @@ interface Window {
  * NOTE: The InAppBrowser window behaves like a standard web browser, and 
can't access Cordova APIs.
  */
 interface InAppBrowser extends Window {
-onloadstart: (type: InAppBrowserEvent) => void;
-onloadstop: (type: InAppBrowserEvent) => void;
-onloaderror: (type: InAppBrowserEvent) => void;
-onexit: (type: InAppBrowserEvent) => void;
+onloadstart(type: Event): void;
+onloadstop(type: InAppBrowserEvent): void;
+onloaderror(type: InAppBrowserEvent): void;
+onexit(type: InAppBrowserEvent): void;
 // addEventListener overloads
 /**
  * Adds a listener for an event from the InAppBrowser.
- * @param type  the event to listen for
- *  loadstart: event fires when the InAppBrowser starts to 
load a URL.
- *  loadstop: event fires when the InAppBrowser finishes 
loading a URL.
- *  loaderror: event fires when the InAppBrowser 
encounters an error when loading a URL.
- *  exit: event fires when the InAppBrowser window is 
closed.
- * @param callback  the function that executes when the event fires. The 
function is
- *  passed an InAppBrowserEvent object as a parameter.
- */
-addEventListener(type: "loadstart", callback: (event: InAppBrowserEvent) 
=> void): void;
-/**
- * Adds a listener for an event from the InAppBrowser.
- * @param type  the event to listen for
- *  loadstart: event fires when the InAppBrowser starts to 
load a URL.
- *  loadstop: event fires when the InAppBrowser finishes 
loading a UR

[jira] [Commented] (CB-14188) Callback to decide whether to open link or not.

2018-10-02 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635156#comment-16635156
 ] 

ASF GitHub Bot commented on CB-14188:
-

janpio commented on issue #276: CB-14188: WIP Add beforeload event, catching 
navigation before it happens
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/276#issuecomment-426194174
 
 
   Yep, you are unfortunately hitting this: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/307


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Callback to decide whether to open link or not.
> ---
>
> Key: CB-14188
> URL: https://issues.apache.org/jira/browse/CB-14188
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> Several times I've found myself wanting to tell inAppBrowser whether it can 
> open a link in the embedded webview or using the system web browser. It would 
> be great if there's a callback _before_ loading a page (loadstart is too late 
> there), where I can tell inAppBrowser to load the page or not.
> CB-14013 introduced AllowedSchemes, but excluded the use of http and https. 
> -It would be useful to allow intercepting http and https links, e.g. to 
> decide whether to open the link in the system web browser or not.- At first I 
> thought this mechanism could be used, but because of the asynchronous nature 
> of Cordova callbacks, this didn't work out, and I added a beforeload 
> callback. See comment for an example.
> I've submitted a PR -(my approach would be to generate a regexp based on 
> AllowedSchemes and match the URL on that, instead of the current if logic)-.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14188) Callback to decide whether to open link or not.

2018-10-02 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/CB-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635115#comment-16635115
 ] 

ASF GitHub Bot commented on CB-14188:
-

wvengen commented on issue #276: CB-14188: add beforeload event, catching 
navigation before it happens
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/276#issuecomment-426181862
 
 
   @janpio still failing on Android 7 :(


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Callback to decide whether to open link or not.
> ---
>
> Key: CB-14188
> URL: https://issues.apache.org/jira/browse/CB-14188
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> Several times I've found myself wanting to tell inAppBrowser whether it can 
> open a link in the embedded webview or using the system web browser. It would 
> be great if there's a callback _before_ loading a page (loadstart is too late 
> there), where I can tell inAppBrowser to load the page or not.
> CB-14013 introduced AllowedSchemes, but excluded the use of http and https. 
> -It would be useful to allow intercepting http and https links, e.g. to 
> decide whether to open the link in the system web browser or not.- At first I 
> thought this mechanism could be used, but because of the asynchronous nature 
> of Cordova callbacks, this didn't work out, and I added a beforeload 
> callback. See comment for an example.
> I've submitted a PR -(my approach would be to generate a regexp based on 
> AllowedSchemes and match the URL on that, instead of the current if logic)-.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12074) Cookies are ignored on first application execution

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app

[jira] [Commented] (CB-13316) Update documentation regarding browser quirks

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

[jira] [Commented] (CB-12479) InAppBrowser: Add Loading Spinner for Android

[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method

[jira] [Commented] (CB-14188) Callback to decide whether to open link or not.

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[jira] [Resolved] (CB-12941) Update typings to latest DefinitelyTyped revision

[jira] [Commented] (CB-12941) Update typings to latest DefinitelyTyped revision

[jira] [Commented] (CB-12941) Update typings to latest DefinitelyTyped revision

[jira] [Commented] (CB-14188) Callback to decide whether to open link or not.

[jira] [Commented] (CB-14188) Callback to decide whether to open link or not.

15 matches

Site Navigation

Mail list logo

Footer information