date:20200521

[GitHub] [cordova-android] breautek closed issue #947: ionic cordova platform add - fails to update build.gradle with proper android gradle plugin

2020-05-21 Thread GitBox



breautek closed issue #947:
URL: https://github.com/apache/cordova-android/issues/947


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] breautek commented on issue #947: ionic cordova platform add - fails to update build.gradle with proper android gradle plugin

2020-05-21 Thread GitBox



breautek commented on issue #947:
URL: https://github.com/apache/cordova-android/issues/947#issuecomment-632454347


   Closing this as https://github.com/apache/cordova-android/pull/962 is merged 
in, and apparently solves this issue.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] breautek commented on issue #968: Ionic 5 cordova android chrome debug console not removed in release

2020-05-21 Thread GitBox



breautek commented on issue #968:
URL: https://github.com/apache/cordova-android/issues/968#issuecomment-632453691


   That does not reproduce the issue for me.
   
   I've tried:
   - cordova-android@8.1
   - with & without cordova-plugin-ionic-webview
   - signing apk manually via jarsigner
   - Letting cordova sign app automatically via `build.json`
   
   None of which allowed me to connect to the web inspector while the released 
version was installed. For reassurance, I've confirmed that the web inspector 
did work when a debug variant of the apk was installed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-splashscreen] breautek closed pull request #228: fix README that cause errors

2020-05-21 Thread GitBox



breautek closed pull request #228:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/228


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-splashscreen] breautek commented on pull request #228: fix README that cause errors

2020-05-21 Thread GitBox



breautek commented on pull request #228:
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/228#issuecomment-632443743


   Thank you for your contribution. It looks like your changes have been 
applied via another PR based on the merge conflict. For this reason I'm closing 
this PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] breautek commented on a change in pull request #851: breaking: replace shelljs with fs-extra

2020-05-21 Thread GitBox



breautek commented on a change in pull request #851:
URL: https://github.com/apache/cordova-ios/pull/851#discussion_r429007820



##
File path: bin/lib/utils.js
##
@@ -0,0 +1,65 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+/*
+Provides a set of utility methods, which can also be spied on during unit 
tests.
+*/
+
+// TODO: Perhaps this should live in cordova-common?
+
+const fs = require('fs-extra');
+
+/**
+ * Reads, searches, and replaces the found occurences with replacementString 
and then writes the file back out.
+ * A backup is not made.
+ *
+ * @param {string} file A file path to a readable & writable file
+ * @param {RegExp} searchRegex The search regex
+ * @param {string} replacementString The string to replace the found occurences
+ * @returns {void}
+ */
+exports.replaceFileContents = function (file, searchRegex, replacementString) {
+let contents;
+try {
+contents = fs.readFileSync(file).toString();
+} catch (ex) {
+console.log('TRYING TO READ: ', file);

Review comment:
   This I made the comment on the wrong PR, but I think this should be 
using the cordova log system so this is only printed during `-v` verbose mode.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] breautek commented on pull request #860: breaking: drop q dependency

2020-05-21 Thread GitBox



breautek commented on pull request #860:
URL: https://github.com/apache/cordova-ios/pull/860#issuecomment-632439236


   Also note that I ignored anything related to the prerequisite PRs.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] breautek commented on a change in pull request #860: breaking: drop q dependency

2020-05-21 Thread GitBox



breautek commented on a change in pull request #860:
URL: https://github.com/apache/cordova-ios/pull/860#discussion_r429002345



##
File path: bin/templates/scripts/cordova/Api.js
##
@@ -278,10 +277,7 @@ Api.prototype.addPlugin = function (plugin, 
installOptions) {
 const frameworkPods = frameworkTags.filter(obj => obj.type === 
'podspec');
 return this.addPodSpecs(plugin, podSpecs, frameworkPods, 
installOptions);
 }
-})
-// CB-11022 return non-falsy value to indicate
-// that there is no need to run prepare after
-.thenResolve(true);

Review comment:
   Is it safe to remove this without adding `.then(() => 
Promise.resolve(true))` (the equivilant of `.thenResolve(true)`)?
   
   The block above it may not return a promise, which I believe is an 
implicitly returns `Promise.resolve()`, thus the consumer receives `undefined`, 
a non-truthy value.

##
File path: bin/templates/scripts/cordova/Api.js
##
@@ -327,10 +323,7 @@ Api.prototype.removePlugin = function (plugin, 
uninstallOptions) {
 const frameworkPods = frameworkTags.filter(obj => obj.type === 
'podspec');
 return this.removePodSpecs(plugin, podSpecs, frameworkPods, 
uninstallOptions);
 }
-})
-// CB-11022 return non-falsy value to indicate
-// that there is no need to run prepare after
-.thenResolve(true);

Review comment:
   same concern as above

##
File path: bin/lib/utils.js
##
@@ -0,0 +1,65 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+/*
+Provides a set of utility methods, which can also be spied on during unit 
tests.
+*/
+
+// TODO: Perhaps this should live in cordova-common?
+
+const fs = require('fs-extra');
+
+/**
+ * Reads, searches, and replaces the found occurences with replacementString 
and then writes the file back out.
+ * A backup is not made.
+ *
+ * @param {string} file A file path to a readable & writable file
+ * @param {RegExp} searchRegex The search regex
+ * @param {string} replacementString The string to replace the found occurences
+ * @returns {void}
+ */
+exports.replaceFileContents = function (file, searchRegex, replacementString) {
+let contents;
+try {
+contents = fs.readFileSync(file).toString();
+} catch (ex) {
+console.log('TRYING TO READ: ', file);

Review comment:
   I know I'm the one that originally wrote this, but this `console.log` 
was debug code that apparently got left behind. Using the cordova log for 
verbose/trace output might be better for this.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] breautek commented on pull request #965: Increased detectArchitecture() timeout

2020-05-21 Thread GitBox



breautek commented on pull request #965:
URL: https://github.com/apache/cordova-android/pull/965#issuecomment-632429146


   Thank you for your contribution. I'd like to see one other PMC member vote 
positive before I merge.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #978: fix: wait_for_boot waiting forever

2020-05-21 Thread GitBox



codecov-commenter edited a comment on pull request #978:
URL: https://github.com/apache/cordova-android/pull/978#issuecomment-632427756


   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=h1) 
Report
   > Merging 
[#978](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/e86b211cd18e3df1932a970d2f431b208a98ae42&el=desc)
 will **not change** coverage.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/978/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #978   +/-   ##
   ===
 Coverage   68.11%   68.11%   
   ===
 Files  21   21   
 Lines1866 1866   
   ===
 Hits 1271 1271   
 Misses595  595   
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/978/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==)
 | `89.83% <100.00%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=footer).
 Last update 
[e86b211...297cd02](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] codecov-commenter commented on pull request #978: fix: wait_for_boot waiting forever

2020-05-21 Thread GitBox



codecov-commenter commented on pull request #978:
URL: https://github.com/apache/cordova-android/pull/978#issuecomment-632427756


   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=h1) 
Report
   > Merging 
[#978](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/e86b211cd18e3df1932a970d2f431b208a98ae42&el=desc)
 will **decrease** coverage by `0.05%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/978/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #978  +/-   ##
   ==
   - Coverage   68.11%   68.06%   -0.06% 
   ==
 Files  21   21  
 Lines1866 1866  
   ==
   - Hits 1271 1270   -1 
   - Misses595  596   +1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/978/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==)
 | `89.83% <100.00%> (ø)` | |
   | 
[bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/978/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz)
 | `58.06% <0.00%> (-0.47%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=footer).
 Last update 
[e86b211...297cd02](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #978: fix: wait_for_boot waiting forever

2020-05-21 Thread GitBox



codecov-commenter edited a comment on pull request #978:
URL: https://github.com/apache/cordova-android/pull/978#issuecomment-632427756


   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=h1) 
Report
   > Merging 
[#978](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/e86b211cd18e3df1932a970d2f431b208a98ae42&el=desc)
 will **decrease** coverage by `0.05%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/978/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #978  +/-   ##
   ==
   - Coverage   68.11%   68.06%   -0.06% 
   ==
 Files  21   21  
 Lines1866 1866  
   ==
   - Hits 1271 1270   -1 
   - Misses595  596   +1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/978/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==)
 | `89.83% <100.00%> (ø)` | |
   | 
[bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/978/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz)
 | `58.06% <0.00%> (-0.47%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=footer).
 Last update 
[e86b211...297cd02](https://codecov.io/gh/apache/cordova-android/pull/978?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] breautek opened a new pull request #978: fix: wait_for_boot waiting forever

2020-05-21 Thread GitBox



breautek opened a new pull request #978:
URL: https://github.com/apache/cordova-android/pull/978


   
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   
   
   Fixes: #698 
   
   
   ### Description
   
   Changes `wait_for_boot` from using `ps` shell command to check for 
`android.process.acore` to `getprop sys.boot_completed`
   
   `android.process.acore` is a process that (despite it's name) is used for 
the `ContactsProvider`. The process is launched on boot, but will get killed 
after some amount of inactivity. When this happens, emulators that are opened 
for approximately 15 minutes or more will cause `cordova run android` to hang 
indefinitely.
   
   Using `getprop sys.boot_completed` is a more reliable way to determine if 
the simulator has been booted.
   
   A longer research comment I have posted on the issue ticket at 
https://github.com/apache/cordova-android/issues/698#issuecomment-632300908
   
   Additionally one unit test has been updated to reflect this change.
   
   ### Testing
   
   - Ran `npm test`
   - Tested android emulators between API 22 through R (API 30) to ensure that 
`getprop sys.boot_completed` indeed returns a value when expected to.
   - Ran `cordova run android` while the emulator was off to ensure emulator 
starts and installs the app properly.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] breautek edited a comment on issue #698: 'cordova run android --emulator' command line tool stuck at 'Waiting for emulator to start...'

2020-05-21 Thread GitBox

breautek edited a comment on issue #698:
URL: https://github.com/apache/cordova-android/issues/698#issuecomment-632300908

A bit more information n this issue.

Cordova repeately does `ps` command in the adb shell

https://github.com/apache/cordova-android/blob/e86b211cd18e3df1932a970d2f431b208a98ae42/bin/templates/cordova/lib/emulator.js#L356

And looks for `android.process.acore`. On a fresh boot of the emulator
running `ps` command on the emulator I clearly see this process. Over time
however `ps` returns:

```
generic_x86_arm:/ $ ps
USERPID PPID VSZRSS WCHANADDR S NAME

shell 5113 25902 12176 3848 0 0 R ps
shell 25902386 12932 3124 __ia32_co+ 0 S sh
```

Even `ps -A` to return all processes, including processes owned by root
fails to have `android.process.acore` listed.

Further research shows that `android.proces.acore` is a process responsible
for android's
[ContactsProvider](https://android.googlesource.com/platform/packages/providers/ContactsProvider/+/android-5.1.1_r29/AndroidManifest.xml#22)
system.

I don't believe scanning for the `android.process.acore` is a reliable way
to determine if the system is booted. It looks like it works on cold boots, but
eventually the process is killed (probably when it isn't being used). Despite
it's name, it has nothing to do with it being an android core (which I think
was probably what the original author of the cordova codebase thought, with no
blame... I'd would come to the same conclusion myself...)

Unfortunately it seems to be very difficult to determine if the emulator is
ready to be used.

`get prop sys.boot_completed` appears to be one approach, but not all
simulators use it (according to SO comments). Personally if android simulators
(from what google provides) from android 5.1 to latest (ie the android versions
cordova-android@9 will support) all supports `sys.boot_completed` prop, I think
that is our best path forward.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] breautek commented on issue #698: 'cordova run android --emulator' command line tool stuck at 'Waiting for emulator to start...'

2020-05-21 Thread GitBox



breautek commented on issue #698:
URL: https://github.com/apache/cordova-android/issues/698#issuecomment-632403298


   I've been running into this issue about every 20 minutes... I have my local 
copy usng `sys.boot_completed` for now.
   
   Later tonight I'll test the `sys.boot_completed` prop on each simulator 
provided by the android sdk. If that prop exists on each simulator, I'll make a 
PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] pcwSlide commented on issue #698: 'cordova run android --emulator' command line tool stuck at 'Waiting for emulator to start...'

2020-05-21 Thread GitBox



pcwSlide commented on issue #698:
URL: https://github.com/apache/cordova-android/issues/698#issuecomment-632392754


   Thanks for your reseach - as a user I just find it frustrating that it keeps 
getting broken - as I say I am sure it is because of lack of information from 
the developers.. Currently I have to start an AVD - then cordova sees it.. I 
hope someone fxes it.. P  -



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-camera] breautek commented on issue #600: Significant quality reduction in images when scaling on Android

2020-05-21 Thread GitBox



breautek commented on issue #600:
URL: 
https://github.com/apache/cordova-plugin-camera/issues/600#issuecomment-632311889


   I think a demo app might be worth while here so that we can see the before 
and after, and could serve as a testing app for variety of different devices.
   
   PRs are much welcome, but I'm not sure what would be the best path to take. 
My concern is mostly with budget phones that are maybe run on limited memory... 
but at the same time I'm not sure if they are even as significant as they were 
in the past.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] breautek commented on issue #698: 'cordova run android --emulator' command line tool stuck at 'Waiting for emulator to start...'

2020-05-21 Thread GitBox

breautek commented on issue #698:
URL: https://github.com/apache/cordova-android/issues/698#issuecomment-632300908