[GitHub] [cordova-osx] codecov-commenter edited a comment on pull request #93: Bump lodash from 4.17.11 to 4.17.15

[GitBox]

codecov-commenter edited a comment on pull request #93:
URL: https://github.com/apache/cordova-osx/pull/93#issuecomment-643580677


   # [Codecov](https://codecov.io/gh/apache/cordova-osx/pull/93?src=pr&el=h1) 
Report
   > Merging 
[#93](https://codecov.io/gh/apache/cordova-osx/pull/93?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-osx/commit/ad715b407c1bd7b9641b1fa2b1f8cc23b6367fde&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-osx/pull/93/graphs/tree.svg?width=650&height=150&src=pr&token=GzDpVsjgvn)](https://codecov.io/gh/apache/cordova-osx/pull/93?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master  #93   +/-   ##
   ===
 Coverage   39.34%   39.34%   
   ===
 Files   55   
 Lines 427  427   
   ===
 Hits  168  168   
 Misses259  259   
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-osx/pull/93?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-osx/pull/93?src=pr&el=footer). 
Last update 
[ad715b4...0e42d51](https://codecov.io/gh/apache/cordova-osx/pull/93?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-osx] codecov-commenter edited a comment on pull request #92: Bump eslint-utils from 1.3.1 to 1.4.3

[GitBox]

codecov-commenter edited a comment on pull request #92:
URL: https://github.com/apache/cordova-osx/pull/92#issuecomment-643580702


   # [Codecov](https://codecov.io/gh/apache/cordova-osx/pull/92?src=pr&el=h1) 
Report
   > Merging 
[#92](https://codecov.io/gh/apache/cordova-osx/pull/92?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-osx/commit/ad715b407c1bd7b9641b1fa2b1f8cc23b6367fde&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-osx/pull/92/graphs/tree.svg?width=650&height=150&src=pr&token=GzDpVsjgvn)](https://codecov.io/gh/apache/cordova-osx/pull/92?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master  #92   +/-   ##
   ===
 Coverage   39.34%   39.34%   
   ===
 Files   55   
 Lines 427  427   
   ===
 Hits  168  168   
 Misses259  259   
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-osx/pull/92?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-osx/pull/92?src=pr&el=footer). 
Last update 
[ad715b4...1240197](https://codecov.io/gh/apache/cordova-osx/pull/92?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-osx] codecov-commenter commented on pull request #93: Bump lodash from 4.17.11 to 4.17.15

[GitBox]

codecov-commenter commented on pull request #93:
URL: https://github.com/apache/cordova-osx/pull/93#issuecomment-643580677


   # [Codecov](https://codecov.io/gh/apache/cordova-osx/pull/93?src=pr&el=h1) 
Report
   > Merging 
[#93](https://codecov.io/gh/apache/cordova-osx/pull/93?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-osx/commit/ad715b407c1bd7b9641b1fa2b1f8cc23b6367fde&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-osx/pull/93/graphs/tree.svg?width=650&height=150&src=pr&token=GzDpVsjgvn)](https://codecov.io/gh/apache/cordova-osx/pull/93?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master  #93   +/-   ##
   ===
 Coverage   39.34%   39.34%   
   ===
 Files   55   
 Lines 427  427   
   ===
 Hits  168  168   
 Misses259  259   
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-osx/pull/93?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-osx/pull/93?src=pr&el=footer). 
Last update 
[ad715b4...0e42d51](https://codecov.io/gh/apache/cordova-osx/pull/93?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-osx] codecov-commenter commented on pull request #92: Bump eslint-utils from 1.3.1 to 1.4.3

[GitBox]

codecov-commenter commented on pull request #92:
URL: https://github.com/apache/cordova-osx/pull/92#issuecomment-643580702


   # [Codecov](https://codecov.io/gh/apache/cordova-osx/pull/92?src=pr&el=h1) 
Report
   > Merging 
[#92](https://codecov.io/gh/apache/cordova-osx/pull/92?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-osx/commit/ad715b407c1bd7b9641b1fa2b1f8cc23b6367fde&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-osx/pull/92/graphs/tree.svg?width=650&height=150&src=pr&token=GzDpVsjgvn)](https://codecov.io/gh/apache/cordova-osx/pull/92?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master  #92   +/-   ##
   ===
 Coverage   39.34%   39.34%   
   ===
 Files   55   
 Lines 427  427   
   ===
 Hits  168  168   
 Misses259  259   
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-osx/pull/92?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-osx/pull/92?src=pr&el=footer). 
Last update 
[ad715b4...1240197](https://codecov.io/gh/apache/cordova-osx/pull/92?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-osx] codecov-commenter edited a comment on pull request #99: Bump js-yaml from 3.12.1 to 3.14.0

[GitBox]

codecov-commenter edited a comment on pull request #99:
URL: https://github.com/apache/cordova-osx/pull/99#issuecomment-643580686


   # [Codecov](https://codecov.io/gh/apache/cordova-osx/pull/99?src=pr&el=h1) 
Report
   > Merging 
[#99](https://codecov.io/gh/apache/cordova-osx/pull/99?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-osx/commit/ad715b407c1bd7b9641b1fa2b1f8cc23b6367fde&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-osx/pull/99/graphs/tree.svg?width=650&height=150&src=pr&token=GzDpVsjgvn)](https://codecov.io/gh/apache/cordova-osx/pull/99?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master  #99   +/-   ##
   ===
 Coverage   39.34%   39.34%   
   ===
 Files   55   
 Lines 427  427   
   ===
 Hits  168  168   
 Misses259  259   
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-osx/pull/99?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-osx/pull/99?src=pr&el=footer). 
Last update 
[ad715b4...d0f5787](https://codecov.io/gh/apache/cordova-osx/pull/99?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-osx] codecov-commenter commented on pull request #99: Bump js-yaml from 3.12.1 to 3.14.0

[GitBox]

codecov-commenter commented on pull request #99:
URL: https://github.com/apache/cordova-osx/pull/99#issuecomment-643580686


   # [Codecov](https://codecov.io/gh/apache/cordova-osx/pull/99?src=pr&el=h1) 
Report
   > Merging 
[#99](https://codecov.io/gh/apache/cordova-osx/pull/99?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-osx/commit/ad715b407c1bd7b9641b1fa2b1f8cc23b6367fde&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-osx/pull/99/graphs/tree.svg?width=650&height=150&src=pr&token=GzDpVsjgvn)](https://codecov.io/gh/apache/cordova-osx/pull/99?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master  #99   +/-   ##
   ===
 Coverage   39.34%   39.34%   
   ===
 Files   55   
 Lines 427  427   
   ===
 Hits  168  168   
 Misses259  259   
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-osx/pull/99?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-osx/pull/99?src=pr&el=footer). 
Last update 
[ad715b4...d0f5787](https://codecov.io/gh/apache/cordova-osx/pull/99?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-osx] dependabot[bot] closed pull request #91: Bump js-yaml from 3.12.1 to 3.13.1

[GitBox]

dependabot[bot] closed pull request #91:
URL: https://github.com/apache/cordova-osx/pull/91


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-osx] dependabot[bot] opened a new pull request #99: Bump js-yaml from 3.12.1 to 3.14.0

[GitBox]

dependabot[bot] opened a new pull request #99:
URL: https://github.com/apache/cordova-osx/pull/99


   Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.12.1 to 3.14.0.
   
   Changelog
   Sourced from https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md";>js-yaml's 
changelog.
   
   [3.14.0] - 2020-05-22
   Changed
   
   Support safe/loadAll(input, options) variant of call.
   CI: drop outdated nodejs versions.
   Dev deps bump.
   
   Fixed
   
   Quote = in plain scalars https://github-redirect.dependabot.com/nodeca/js-yaml/issues/519";>#519.
   Check the node type for ! tag in case user 
manually specifies it.
   Verify that there are no null-bytes in input.
   Fix wrong quote position when writing condensed flow, https://github-redirect.dependabot.com/nodeca/js-yaml/issues/526";>#526.
   
   [3.13.1] - 2019-04-05
   Security
   
   Fix possible code execution in (already unsafe) .load(), https://github-redirect.dependabot.com/nodeca/js-yaml/issues/480";>#480.
   
   [3.13.0] - 2019-03-20
   Security
   
   Security fix: safeLoad() can hang when arrays with nested 
refs
   used as key. Now throws exception for nested arrays. https://github-redirect.dependabot.com/nodeca/js-yaml/issues/475";>#475.
   
   [3.12.2] - 2019-02-26
   Fixed
   
   Fix noArrayIndent option for root level, https://github-redirect.dependabot.com/nodeca/js-yaml/issues/468";>#468.
   
   
   
   
   Commits
   
   https://github.com/nodeca/js-yaml/commit/34e5072f43fd36b08d433da73c10d47c41e5";>34e5072
 3.14.0 released
   https://github.com/nodeca/js-yaml/commit/7b25c83a6dc77097c2bf14bf714e168f60ee199b";>7b25c83
 Browser files rebuild
   https://github.com/nodeca/js-yaml/commit/6f7347396867b8dcfc042722c2aae810dfe4caae";>6f73473
 Dev deps bump
   https://github.com/nodeca/js-yaml/commit/0c293491d903cddcd41b41c165bc45eeb9a8d720";>0c29349
 Travis-CI: drop old nodejs versions
   https://github.com/nodeca/js-yaml/commit/10be97ebbd588e68907e6c67e0b3843a4caab475";>10be97e
 fix(loader): Add support for safe/loadAll(input, options)
   https://github.com/nodeca/js-yaml/commit/d6983dd4291849b2854e8d26e1beb302edfd4c76";>d6983dd
 Fix issue https://github-redirect.dependabot.com/nodeca/js-yaml/issues/526";>#526:
 wrong quote position writing condensed flow (https://github-redirect.dependabot.com/nodeca/js-yaml/issues/527";>#527)
   https://github.com/nodeca/js-yaml/commit/93fbf7d4ddecea60709c8379397247af28f11e10";>93fbf7d
 fix issue 526 (wrong quote position writing condensed flow)
   https://github.com/nodeca/js-yaml/commit/e569cc70ec9b41760d0d37b805a1d9b3ada519ca";>e569cc7
 readme: update titelift info
   https://github.com/nodeca/js-yaml/commit/8fb29059223b5f700dec4ea09b3d5550cd3a8e32";>8fb2905
 changelog format update
   https://github.com/nodeca/js-yaml/commit/33c2236d702fee430cac27ab41d75069b6647765";>33c2236
 Verify that there are no null-bytes in input
   Additional commits viewable in https://github.com/nodeca/js-yaml/compare/3.12.1...3.14.0";>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=js-yaml&package-manager=npm_and_yarn&previous-version=3.12.1&new-version=3.14.0)](https://help.github.com/articles/configuring-automated-security-fixes)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the curr

[GitHub] [cordova-osx] dependabot[bot] commented on pull request #91: Bump js-yaml from 3.12.1 to 3.13.1

[GitBox]

dependabot[bot] commented on pull request #91:
URL: https://github.com/apache/cordova-osx/pull/91#issuecomment-643580314


   Superseded by #99.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-osx] NiklasMerz merged pull request #97: breaking: bump cordova-common@^4.0.0

[GitBox]

NiklasMerz merged pull request #97:
URL: https://github.com/apache/cordova-osx/pull/97


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-docs] NiklasMerz commented on pull request #1085: Plugin release post June 2020

[GitBox]

NiklasMerz commented on pull request #1085:
URL: https://github.com/apache/cordova-docs/pull/1085#issuecomment-643578906


   The releases are done. Good to post that?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-osx] codecov-commenter commented on pull request #97: breaking: bump cordova-common@^4.0.0

[GitBox]

codecov-commenter commented on pull request #97:
URL: https://github.com/apache/cordova-osx/pull/97#issuecomment-643578662


   # [Codecov](https://codecov.io/gh/apache/cordova-osx/pull/97?src=pr&el=h1) 
Report
   > Merging 
[#97](https://codecov.io/gh/apache/cordova-osx/pull/97?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-osx/commit/bfcb4bdbc73decc67905fdbdc2c762208d8b4427&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-osx/pull/97/graphs/tree.svg?width=650&height=150&src=pr&token=GzDpVsjgvn)](https://codecov.io/gh/apache/cordova-osx/pull/97?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master  #97   +/-   ##
   ===
 Coverage   39.34%   39.34%   
   ===
 Files   55   
 Lines 427  427   
   ===
 Hits  168  168   
 Misses259  259   
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-osx/pull/97?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-osx/pull/97?src=pr&el=footer). 
Last update 
[bfcb4bd...605bc97](https://codecov.io/gh/apache/cordova-osx/pull/97?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-osx] codecov-commenter edited a comment on pull request #97: breaking: bump cordova-common@^4.0.0

[GitBox]

codecov-commenter edited a comment on pull request #97:
URL: https://github.com/apache/cordova-osx/pull/97#issuecomment-643578662


   # [Codecov](https://codecov.io/gh/apache/cordova-osx/pull/97?src=pr&el=h1) 
Report
   > Merging 
[#97](https://codecov.io/gh/apache/cordova-osx/pull/97?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-osx/commit/bfcb4bdbc73decc67905fdbdc2c762208d8b4427&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-osx/pull/97/graphs/tree.svg?width=650&height=150&src=pr&token=GzDpVsjgvn)](https://codecov.io/gh/apache/cordova-osx/pull/97?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master  #97   +/-   ##
   ===
 Coverage   39.34%   39.34%   
   ===
 Files   55   
 Lines 427  427   
   ===
 Hits  168  168   
 Misses259  259   
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-osx/pull/97?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-osx/pull/97?src=pr&el=footer). 
Last update 
[bfcb4bd...605bc97](https://codecov.io/gh/apache/cordova-osx/pull/97?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-osx] NiklasMerz merged pull request #98: (ci) drop nodejs <10 from Travis

[GitBox]

NiklasMerz merged pull request #98:
URL: https://github.com/apache/cordova-osx/pull/98


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-lib] breautek commented on issue #834: NodeJS14: Warning: Accessing non-existent property 'android'

[GitBox]

breautek commented on issue #834:
URL: https://github.com/apache/cordova-lib/issues/834#issuecomment-643563467


   Closing this as it doesn't reproduce on nightly.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-lib] breautek closed issue #834: NodeJS14: Warning: Accessing non-existent property 'android'

[GitBox]

breautek closed issue #834:
URL: https://github.com/apache/cordova-lib/issues/834


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] breautek commented on issue #916: Bug: input capture="camera" doesn't open camera

[GitBox]

breautek commented on issue #916:
URL: https://github.com/apache/cordova-android/issues/916#issuecomment-643562674


   A workaround would be to use the `cordova-plugin-camera` APIs, although with 
this route, you'd probably want to build your own custom button instead of 
using the browser's `` tag.
   
   I believe this doesn't work because most of the input file attribute the 
native app actually needs to intercept and handle it explicitly. It's not 
"automatic" like the chrome browser. This could be a feature request, but there 
are some hurdles to jump through. Namely the requirement for apps to declare 
what features they use, including if they use the camera feature, which is 
something that the `cordova-plugin-camera` already does... and adding that into 
the core library is not really feasible imo.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] breautek edited a comment on issue #991: Cordova net::ERR_INVALID_RESPONSE

[GitBox]

breautek edited a comment on issue #991:
URL: https://github.com/apache/cordova-android/issues/991#issuecomment-643559830


   `ERR_INVALID_RESPONSE` means the client (the webview) received something 
that it doesn't understand or know how to handle.
   
   I don't believe this is a bug with Cordova.
   
   I don't observe this behaviour if I try it myself.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] breautek commented on issue #991: Cordova net::ERR_INVALID_RESPONSE

[GitBox]

breautek commented on issue #991:
URL: https://github.com/apache/cordova-android/issues/991#issuecomment-643559830


   `ERR_INVALID_RESPONSE` means the client (the webview) received something 
that it doesn't understand or know how to handle.
   
   I don't believe this is a bug with Cordova.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] breautek commented on issue #891: App rejected by Apple: App does not clarify the use of Motion Sensor in the applicable purpose string

[GitBox]

breautek commented on issue #891:
URL: https://github.com/apache/cordova-ios/issues/891#issuecomment-643552470


   Duplicate of https://github.com/apache/cordova-plugin-device-motion/issues/69



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] breautek closed issue #891: App rejected by Apple: App does not clarify the use of Motion Sensor in the applicable purpose string

[GitBox]

breautek closed issue #891:
URL: https://github.com/apache/cordova-ios/issues/891


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] breautek commented on issue #695: Missing Intent type and category prevent file upload - [solution included]

[GitBox]

breautek commented on issue #695:
URL: https://github.com/apache/cordova-android/issues/695#issuecomment-643551119


   Thank you @ksch10bob I've confirmed the issue using your information.
   
   I tried the following:
   * ``
   * ``
   * ``
   * ``
   
   Each of these cases I've observed that jpg were not selectable, when they 
were expected to be.
   
   I've also pulled down the PR #971 (not sure if it implements the same 
solution provided in this issue) and confirmed that the PR does address the 
problem :+1: 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] mosabab edited a comment on issue #868: SVG no longer shown in ios 13.5

[GitBox]

mosabab edited a comment on issue #868:
URL: https://github.com/apache/cordova-ios/issues/868#issuecomment-642568621


   Please update to ios@6.0.0
   and remove the wkwebview plugin, there is no need for it anymore (it is 
already integrated to ios@6.0.0).
   
   And take in your mind that SVG may take long to appear in simulator, but in 
real device it appear fast .
   
   Just to confirm did you add the svg in `` tag ?
   like this ``?
   
   If yes, I think it should work.
   
   Regards



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] mosabab edited a comment on issue #891: App rejected by Apple: App does not clarify the use of Motion Sensor in the applicable purpose string

[GitBox]

mosabab edited a comment on issue #891:
URL: https://github.com/apache/cordova-ios/issues/891#issuecomment-643513847


   Your issue should be moved to the plugin itself which is: 
   https://github.com/apache/cordova-plugin-camera
   
   You need to clarify to users why you use the camera, this can be done by 
adding the reasons in your `config.xml` under paltform `ios` like this way:
   
   ``
   
   ``
  `need camera access to take pictures`
   ``
   
   ``
   `need photo library access to get pictures from there`
   ``
   
   ``
   `need location access to find things nearby`
   ``
   
   ``
   `need photo library access to save pictures there`
   ``
   
   ``
   
   You can refer to this:
   https://github.com/apache/cordova-plugin-camera#ios-quirks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] mosabab edited a comment on issue #891: App rejected by Apple: App does not clarify the use of Motion Sensor in the applicable purpose string

[GitBox]

mosabab edited a comment on issue #891:
URL: https://github.com/apache/cordova-ios/issues/891#issuecomment-643513847


   You need to clarify to users why you use the camera, this can be done by 
adding the reasons in your `config.xml` under paltform `ios` like this way:
   
   ``
   
   ``
  `need camera access to take pictures`
   ``
   
   ``
   `need photo library access to get pictures from there`
   ``
   
   ``
   `need location access to find things nearby`
   ``
   
   ``
   `need photo library access to save pictures there`
   ``
   
   ``
   
   You can refer to this:
   https://github.com/apache/cordova-plugin-camera#ios-quirks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] mosabab edited a comment on issue #891: App rejected by Apple: App does not clarify the use of Motion Sensor in the applicable purpose string

[GitBox]

mosabab edited a comment on issue #891:
URL: https://github.com/apache/cordova-ios/issues/891#issuecomment-643513847


   You need to clarify to users why you use the camera, this can be done by 
adding the reasons in your `config.xml` under paltform `ios` like this way:
   
   ``
   
   `
  `need camera access to take pictures`
   ``
   
   ``
   `need photo library access to get pictures from there`
   ``
   
   ``
   `need location access to find things nearby`
   ``
   
   ``
   `need photo library access to save pictures there`
   ``
   
   ``
   
   You can refer to this:
   https://github.com/apache/cordova-plugin-camera#ios-quirks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] mosabab edited a comment on issue #891: App rejected by Apple: App does not clarify the use of Motion Sensor in the applicable purpose string

[GitBox]

mosabab edited a comment on issue #891:
URL: https://github.com/apache/cordova-ios/issues/891#issuecomment-643513847







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] mosabab edited a comment on issue #891: App rejected by Apple: App does not clarify the use of Motion Sensor in the applicable purpose string

[GitBox]

mosabab edited a comment on issue #891:
URL: https://github.com/apache/cordova-ios/issues/891#issuecomment-643513847


   You need to clarify to users why you use the camera, this can be done by 
adding the reasons in your `config.xml` under paltform `ios` like this way:
   `
   need camera access to take pictures
   
   
   
   need photo library access to get pictures from there
   
   
   
   need location access to find things nearby
   
   
   
   need photo library access to save pictures there
   `
   
you can refer to this:
   https://github.com/apache/cordova-plugin-camera#ios-quirks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] mosabab edited a comment on issue #891: App rejected by Apple: App does not clarify the use of Motion Sensor in the applicable purpose string

[GitBox]

mosabab edited a comment on issue #891:
URL: https://github.com/apache/cordova-ios/issues/891#issuecomment-643513847


   You need to clarify to users why you use the camera, this can be done by 
adding the reasons in this way:
   `
   need camera access to take pictures
   
   
   need photo library access to get pictures from there
   
   
   need location access to find things nearby
   
   
   need photo library access to save pictures there
   `
   
you can refer to this:
   https://github.com/apache/cordova-plugin-camera#ios-quirks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] mosabab commented on issue #891: App rejected by Apple: App does not clarify the use of Motion Sensor in the applicable purpose string

[GitBox]

mosabab commented on issue #891:
URL: https://github.com/apache/cordova-ios/issues/891#issuecomment-643513847


   You need to clarify to users why you use the camera, this can be done by 
adding the reasons in this way, you can refer to this:
   https://github.com/apache/cordova-plugin-camera#ios-quirks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-osx] codecov-commenter commented on pull request #98: (ci) drop nodejs <10 from Travis

[GitBox]

codecov-commenter commented on pull request #98:
URL: https://github.com/apache/cordova-osx/pull/98#issuecomment-643476584


   # [Codecov](https://codecov.io/gh/apache/cordova-osx/pull/98?src=pr&el=h1) 
Report
   > Merging 
[#98](https://codecov.io/gh/apache/cordova-osx/pull/98?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-osx/commit/ea0d691d67093fd1dd9418a8fce9097d4a29f217&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-osx/pull/98/graphs/tree.svg?width=650&height=150&src=pr&token=GzDpVsjgvn)](https://codecov.io/gh/apache/cordova-osx/pull/98?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master  #98   +/-   ##
   ===
 Coverage   39.34%   39.34%   
   ===
 Files   55   
 Lines 427  427   
   ===
 Hits  168  168   
 Misses259  259   
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-osx/pull/98?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-osx/pull/98?src=pr&el=footer). 
Last update 
[ea0d691...751fc09](https://codecov.io/gh/apache/cordova-osx/pull/98?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-osx] codecov-commenter edited a comment on pull request #98: (ci) drop nodejs <10 from Travis

[GitBox]

codecov-commenter edited a comment on pull request #98:
URL: https://github.com/apache/cordova-osx/pull/98#issuecomment-643476584


   # [Codecov](https://codecov.io/gh/apache/cordova-osx/pull/98?src=pr&el=h1) 
Report
   > Merging 
[#98](https://codecov.io/gh/apache/cordova-osx/pull/98?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-osx/commit/ea0d691d67093fd1dd9418a8fce9097d4a29f217&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-osx/pull/98/graphs/tree.svg?width=650&height=150&src=pr&token=GzDpVsjgvn)](https://codecov.io/gh/apache/cordova-osx/pull/98?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master  #98   +/-   ##
   ===
 Coverage   39.34%   39.34%   
   ===
 Files   55   
 Lines 427  427   
   ===
 Hits  168  168   
 Misses259  259   
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-osx/pull/98?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-osx/pull/98?src=pr&el=footer). 
Last update 
[ea0d691...751fc09](https://codecov.io/gh/apache/cordova-osx/pull/98?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-osx] NiklasMerz opened a new pull request #98: (ci) drop nodejs <10 from Travis

[GitBox]

NiklasMerz opened a new pull request #98:
URL: https://github.com/apache/cordova-osx/pull/98


   
   
   ### Platforms affected
   OSX
   
   
   ### Motivation and Context
   
   
   Removing failing CI from #97 
   
   
   ### Description
   
   
   
   
   ### Testing
   
   CI
   
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] mosabab edited a comment on issue #728: [iOS] Set StatusBarStyle from config.xml

[GitBox]

mosabab edited a comment on issue #728:
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/728#issuecomment-643454954


   You are right.
   
   The latest PR which remove the fake statusbar generate a new issue like what 
you mentioned.
   
   I think the best way to solve this new issue is to make a new options for 
inappbrowser like:
   Statubar.lightcontent / dark theme
   Statusbar.darkcontent / light theme
   
   Or as preferences in config.xml as you mentioned
   
   And so
   
   Because with introduced dark theme for iPhone devices i think it is 
important now to change the way that inappbrowser show the statusbar.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] mosabab commented on issue #728: [iOS] Set StatusBarStyle from config.xml

[GitBox]

mosabab commented on issue #728:
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/728#issuecomment-643454954


   You are right.
   
   The latest PR which remove the fake statusbar generate a new issue like what 
you mentioned.
   
   I think the best way to solve this new issue is to make a new options for 
inappbrowser like:
   Statubar.lightcontent / dark theme
   Statusbar.darkcontent / light theme
   
   And so
   
   Because with introduced dark theme for iPhone devices i think it is 
important now to change the way that inappbrowser show the statusbar.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-node-xcode] Panajev commented on pull request #87: Add support for On Demand Resources tags on iOS

[GitBox]

Panajev commented on pull request #87:
URL: https://github.com/apache/cordova-node-xcode/pull/87#issuecomment-643453442


   Hello Chris,
   
   Thanks for your reply, I will be talking to the devs to update this PR with 
some additional comments.
   
   As we were discussing earlier in the thread, we were in need of adding ODR 
asset tags to our whitelabelled application and each “variant” may need a 
sizeable variety of different On Demand Resources that would not be feasible to 
add manually.
   
   This set of changes adds features to add and remove On Demand Resources tags 
you the Xcode Project allowing you to also support some variants with and some 
without ODR support without leaving lots of cruft behind. We have extended the 
sample project a bit, but if useful we can expand more on it. What would you 
suggest to add to make it compatible with the upstream project?
   
   Sent from my iPhone
   
   > On 12 Jun 2020, at 19:55, Chris Brody  wrote:
   > 
   > 
   > Maintainers have been pretty overloaded with major release items, many of 
us have limited time due to day jobs as well. Anything that can help us better 
understand and test this functionality would be much appreciated.
   > 
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub, or unsubscribe.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] brodybits commented on pull request #867: Feat: add custom repositories support

[GitBox]

brodybits commented on pull request #867:
URL: https://github.com/apache/cordova-android/pull/867#issuecomment-643434951


   We are still awaiting response to help resolve the conflicts. Anything that 
can simplify the our understanding & testing would be much appreciated as well.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-node-xcode] brodybits commented on pull request #87: Add support for On Demand Resources tags on iOS

[GitBox]

brodybits commented on pull request #87:
URL: https://github.com/apache/cordova-node-xcode/pull/87#issuecomment-643433908


   Maintainers have been pretty overloaded with major release items, many of us 
have limited time due to day jobs as well. Anything that can help us better 
understand and test this functionality would be much appreciated.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-node-xcode] codecov-commenter commented on pull request #87: Add support for On Demand Resources tags on iOS

[GitBox]

codecov-commenter commented on pull request #87:
URL: https://github.com/apache/cordova-node-xcode/pull/87#issuecomment-643430899


   # 
[Codecov](https://codecov.io/gh/apache/cordova-node-xcode/pull/87?src=pr&el=h1) 
Report
   > Merging 
[#87](https://codecov.io/gh/apache/cordova-node-xcode/pull/87?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-node-xcode/commit/e81ecabc18b0e43a1ae5457f16ebcbb8b0b62460&el=desc)
 will **decrease** coverage by `1.39%`.
   > The diff coverage is `11.62%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-node-xcode/pull/87/graphs/tree.svg?width=650&height=150&src=pr&token=hF6uWuFokA)](https://codecov.io/gh/apache/cordova-node-xcode/pull/87?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master  #87  +/-   ##
   ==
   - Coverage   89.97%   88.58%   -1.40% 
   ==
 Files   66  
 Lines2374 2417  +43 
   ==
   + Hits 2136 2141   +5 
   - Misses238  276  +38 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-node-xcode/pull/87?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[lib/pbxProject.js](https://codecov.io/gh/apache/cordova-node-xcode/pull/87/diff?src=pr&el=tree#diff-bGliL3BieFByb2plY3QuanM=)
 | `92.75% <11.62%> (-3.33%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-node-xcode/pull/87?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-node-xcode/pull/87?src=pr&el=footer).
 Last update 
[e81ecab...9b53a05](https://codecov.io/gh/apache/cordova-node-xcode/pull/87?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-node-xcode] codecov-commenter edited a comment on pull request #87: Add support for On Demand Resources tags on iOS

[GitBox]

codecov-commenter edited a comment on pull request #87:
URL: https://github.com/apache/cordova-node-xcode/pull/87#issuecomment-643430899


   # 
[Codecov](https://codecov.io/gh/apache/cordova-node-xcode/pull/87?src=pr&el=h1) 
Report
   > Merging 
[#87](https://codecov.io/gh/apache/cordova-node-xcode/pull/87?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-node-xcode/commit/e81ecabc18b0e43a1ae5457f16ebcbb8b0b62460&el=desc)
 will **decrease** coverage by `1.39%`.
   > The diff coverage is `11.62%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-node-xcode/pull/87/graphs/tree.svg?width=650&height=150&src=pr&token=hF6uWuFokA)](https://codecov.io/gh/apache/cordova-node-xcode/pull/87?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master  #87  +/-   ##
   ==
   - Coverage   89.97%   88.58%   -1.40% 
   ==
 Files   66  
 Lines2374 2417  +43 
   ==
   + Hits 2136 2141   +5 
   - Misses238  276  +38 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-node-xcode/pull/87?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[lib/pbxProject.js](https://codecov.io/gh/apache/cordova-node-xcode/pull/87/diff?src=pr&el=tree#diff-bGliL3BieFByb2plY3QuanM=)
 | `92.75% <11.62%> (-3.33%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-node-xcode/pull/87?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-node-xcode/pull/87?src=pr&el=footer).
 Last update 
[e81ecab...9b53a05](https://codecov.io/gh/apache/cordova-node-xcode/pull/87?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] brodybits commented on pull request #971: Accept multiple mime types on file input

[GitBox]

brodybits commented on pull request #971:
URL: https://github.com/apache/cordova-android/pull/971#issuecomment-643430324


   It looks like someone gave us a minimal reproduction in 
, 
needs our investigation.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] brodybits commented on pull request #468: Update CordovaResourceApi.java

[GitBox]

brodybits commented on pull request #468:
URL: https://github.com/apache/cordova-android/pull/468#issuecomment-643424404


   I think this needs investigation, adding the **discussion** label for now.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] brodybits commented on pull request #595: Add a warning about the using of `android.bat`

[GitBox]

brodybits commented on pull request #595:
URL: https://github.com/apache/cordova-android/pull/595#issuecomment-643423822


   > Wouldn't it be better to remove usages of the `android` command?
   
   +1
   
   > I realise this is 2 years old now... does this even apply still?
   
   Needs investigation, adding **bug** & **discussion** labels for now.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] mrbberra opened a new issue #728: [iOS] Set StatusBarStyle from config.xml

[GitBox]

mrbberra opened a new issue #728:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/728


   # Feature Request
   
   ## Motivation Behind Feature
   With the merge of 
[GH-656](https://github.com/apache/cordova-plugin-inappbrowser/pull/656), the 
status bar now shows up with the color of the app status bar, which I've been 
setting using 
[cordova-plugin-statusbar](https://github.com/apache/cordova-plugin-statusbar). 
The InAppBrowser, however, still overrides the text in the status bar with 
`UIStatusBarStyleDefault` (black text), which is a problem if the status bar 
has a dark background color.
   
   ## Example
   ```
 StatusBar.styleLightContent();
 StatusBar.backgroundColorByHexString("#281e36");
   ```
   https://user-images.githubusercontent.com/10442753/84533846-8db5a480-acae-11ea-89d7-cdbff41e4119.png";>
   https://user-images.githubusercontent.com/10442753/84533802-7c6c9800-acae-11ea-88ac-75ba1277e490.png";>
   
   ## Feature Description
   Set IAB iOS status bar color from the cordova config file. I'm imagining 
something like ``
   
   
   I've got some work on this I've started I can submit a PR for- just changing 
the `preferredStatusBarStyle`. I guess a more complex implementation would be 
to add a method to modify it dynamically (since you can modify the status bar 
color dynamically using that plugin)... seems like overkill to me though.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] brodybits commented on pull request #928: Update check_reqs.js

[GitBox]

brodybits commented on pull request #928:
URL: https://github.com/apache/cordova-android/pull/928#issuecomment-643412343


   I would like to get this fixed, would definitely agree with @timbru31 to 
check for JDK < 8.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] brodybits commented on pull request #795: [minor] fix *-Info.plist & config.xml functionality

[GitBox]

brodybits commented on pull request #795:
URL: https://github.com/apache/cordova-ios/pull/795#issuecomment-643408727


   The good news is that I would no longer consider this to be a breaking 
change. If I would remove the xcworkspace file and then build from the command 
line, it results in an error from xcodebuild. (I was able to remove the 
xcworkspace file and then build & run from Xcode, which I think is a side 
point.)
   
   I do think this is too much change for a patch, though, should probably 
target a minor release.
   
   I did try merging. The changes did not seem to work after merging, and some 
of the tests need rework due to removing shelljs. I think we should really 
rebase and rework. I will try to fit this in as soon as I can.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] jonamat opened a new issue #898: window.open() with _system does not work with wkwebview (on cordova-ios 6.0.0)

[GitBox]

jonamat opened a new issue #898:
URL: https://github.com/apache/cordova-ios/issues/898


   # Bug Report
   
   ## Problem
   Safari does not open with wkwebview. With UIwebview, before the updates, it 
worked
   
   `window.open('https://google.com', "_self")` - this opens a new page in 
inappbrowser (as expected)
   `window.open('https://google.com', "_blank")` - nothing
   `window.open('https://google.com', "_system") `- nothing
   I've tried also with `https://google.com"; target="_system">foo` 
but nothing happens
   
   ### What is expected to happen?
   Open the system browser
   
   ### What does actually happen?
   Nothing
   
   ## Information
   
   ### Command or Code
   
   Noteworthy lines on config.xml
   ```
   
   
   
   ```
   
   Dependencies
   ```
 "dependencies": {
   "cordova-android": "^8.1.0",
   "cordova-ios": "^6.0.0",
   "cordova-plugin-androidx": "^2.0.0",
   "cordova-plugin-androidx-adapter": "^1.1.1",
   "cordova-plugin-browsertab": "0.2.0",
   "cordova-plugin-buildinfo": "4.0.0",
   "cordova-plugin-compat": "1.2.0",
   "cordova-plugin-customurlscheme": "5.0.1",
   "cordova-plugin-device": "^2.0.3",
   "cordova-plugin-firebase-messaging": "^4.0.2",
   "cordova-plugin-inappbrowser": 
"git+https://github.com/apache/cordova-plugin-inappbrowser.git";,
   "cordova-support-android-plugin": "^1.0.2",
   "cordova-support-google-services": "^1.4.0",
   "cordova-universal-links-plugin-fix": "1.2.1"
 },
 "devDependencies": {
   "cordova-plugin-whitelist": "1"
 },
 "cordova": {
   "plugins": {
 "cordova-plugin-whitelist": {},
 "cordova-plugin-firebase-messaging": {
   "FIREBASE_ANALYTICS_VERSION": "17.2.+",
   "FIREBASE_MESSAGING_VERSION": "20.1.+",
   "ANDROIDX_CORE_VERSION": "1.0.+"
 },
 "cordova-plugin-device": {},
 "cordova-plugin-buildinfo": {},
 "cordova-universal-links-plugin": {},
 "cordova-plugin-browsertab": {},
 "cordova-plugin-customurlscheme": {
   "URL_SCHEME": ""
 },
 "cordova-plugin-androidx": {},
 "cordova-plugin-androidx-adapter": {},
 "cordova-plugin-inappbrowser": {}
   },
   "platforms": [
 "ios",
 "android"
   ]
 }
   
   ```
   
   ### Environment, Platform, Device
   iOS 13.3 on Catalina simulator
   
   ### Version information
   cordova version: 9.0.0 (cordova-lib@9.0.1)
   cordova platform: cordova-ios 6.0.0
   tested on: iOS 13.3 on Catalina simulator
   
   ## Checklist
   
   - [x] I searched for existing GitHub issues
   - [x] I updated all Cordova tooling to most recent version
   - [x] I included all the necessary information above
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] NIYASSURABHI commented on issue #727: Route change in angular webapp cannot detect using ionic 4 Inapp browser

[GitBox]

NIYASSURABHI commented on issue #727:
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/727#issuecomment-643386024


   > > > Your issue is missing the required version information, can you please 
add those? Otherwise, we are unable to help.
   > > > Thanks!
   > > 
   > > 
   > > I have updated my question with the package json file.
   > 
   > Thanks. However, it's still not clear if this affect iOS, Android or both.
   
   its affect both iOS and Android.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] codecov-commenter edited a comment on pull request #886: Add PreferredContentMode preference

[GitBox]

codecov-commenter edited a comment on pull request #886:
URL: https://github.com/apache/cordova-ios/pull/886#issuecomment-639029590


   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=h1) 
Report
   > Merging 
[#886](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-ios/commit/02448ceb3b837e66890e702879bac9298f8a896a&el=desc)
 will **increase** coverage by `1.89%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-ios/pull/886/graphs/tree.svg?width=650&height=150&src=pr&token=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #886  +/-   ##
   ==
   + Coverage   74.40%   76.30%   +1.89% 
   ==
 Files  13   13  
 Lines1676 1941 +265 
   ==
   + Hits 1247 1481 +234 
   - Misses429  460  +31 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/886/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=)
 | `86.60% <0.00%> (+1.19%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=footer). 
Last update 
[02448ce...d27a366](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] codecov-commenter edited a comment on pull request #886: Add PreferredContentMode preference

[GitBox]

codecov-commenter edited a comment on pull request #886:
URL: https://github.com/apache/cordova-ios/pull/886#issuecomment-639029590


   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=h1) 
Report
   > Merging 
[#886](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-ios/commit/02448ceb3b837e66890e702879bac9298f8a896a&el=desc)
 will **increase** coverage by `1.89%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-ios/pull/886/graphs/tree.svg?width=650&height=150&src=pr&token=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #886  +/-   ##
   ==
   + Coverage   74.40%   76.30%   +1.89% 
   ==
 Files  13   13  
 Lines1676 1941 +265 
   ==
   + Hits 1247 1481 +234 
   - Misses429  460  +31 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/886/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=)
 | `86.60% <0.00%> (+1.19%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=footer). 
Last update 
[02448ce...d27a366](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-browser] NiklasMerz commented on pull request #96: breaking: @cordova/eslint-config w/ applied fix

[GitBox]

NiklasMerz commented on pull request #96:
URL: https://github.com/apache/cordova-browser/pull/96#issuecomment-643362640


   Good to merge for major release?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-browser] NiklasMerz merged pull request #97: breaking: bump cordova dependencies to latest

[GitBox]

NiklasMerz merged pull request #97:
URL: https://github.com/apache/cordova-browser/pull/97


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] codecov-commenter edited a comment on pull request #886: Add PreferredContentMode preference

[GitBox]

codecov-commenter edited a comment on pull request #886:
URL: https://github.com/apache/cordova-ios/pull/886#issuecomment-639029590


   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=h1) 
Report
   > Merging 
[#886](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-ios/commit/02448ceb3b837e66890e702879bac9298f8a896a&el=desc)
 will **increase** coverage by `1.89%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-ios/pull/886/graphs/tree.svg?width=650&height=150&src=pr&token=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #886  +/-   ##
   ==
   + Coverage   74.40%   76.30%   +1.89% 
   ==
 Files  13   13  
 Lines1676 1941 +265 
   ==
   + Hits 1247 1481 +234 
   - Misses429  460  +31 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/886/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=)
 | `86.60% <0.00%> (+1.19%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=footer). 
Last update 
[02448ce...d27a366](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] codecov-commenter edited a comment on pull request #886: Add PreferredContentMode preference

[GitBox]

codecov-commenter edited a comment on pull request #886:
URL: https://github.com/apache/cordova-ios/pull/886#issuecomment-639029590


   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=h1) 
Report
   > Merging 
[#886](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-ios/commit/02448ceb3b837e66890e702879bac9298f8a896a&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-ios/pull/886/graphs/tree.svg?width=650&height=150&src=pr&token=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #886   +/-   ##
   ===
 Coverage   74.40%   74.40%   
   ===
 Files  13   13   
 Lines1676 1676   
   ===
 Hits 1247 1247   
 Misses429  429   
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=footer). 
Last update 
[02448ce...d27a366](https://codecov.io/gh/apache/cordova-ios/pull/886?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-wkwebview-engine] breautek merged pull request #161: added WKWebViewOnly to Readme

[GitBox]

breautek merged pull request #161:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/161


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on issue #727: Route change in angular webapp cannot detect using ionic 4 Inapp browser

[GitBox]

timbru31 commented on issue #727:
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/727#issuecomment-643332580


   > 
   > 
   > > Your issue is missing the required version information, can you please 
add those? Otherwise, we are unable to help.
   > > Thanks!
   > 
   > I have updated my question with the package json file.
   
   Thanks. However, it's still not clear if this affect iOS, Android or both.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-wkwebview-engine] machinaeXphilip commented on pull request #161: added WKWebViewOnly to Readme

[GitBox]

machinaeXphilip commented on pull request #161:
URL: 
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/161#issuecomment-643332393


   thanks! i commited those. indeed better wording!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-electron] erisu merged pull request #154: feature: support custom scheme & hostname

[GitBox]

erisu merged pull request #154:
URL: https://github.com/apache/cordova-electron/pull/154


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-wkwebview-engine] erisu commented on a change in pull request #161: added WKWebViewOnly to Readme

[GitBox]

erisu commented on a change in pull request #161:
URL: 
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/161#discussion_r439483505



##
File path: README.md
##
@@ -65,6 +65,12 @@ WKWebView may not fully launch (the deviceready event may 
not fire) unless if th
 
 ```
 
+If using cordova-ios versions >= 5.1.0 you might have to include the following 
tag in order to only use the WKWebView (which is required for new Apps to the 
AppStore):

Review comment:
   Here is my recommendation on wording and presentation formatting.

##
File path: README.md
##
@@ -65,6 +65,12 @@ WKWebView may not fully launch (the deviceready event may 
not fire) unless if th
 
 ```
 
+If using cordova-ios versions >= 5.1.0 you might have to include the following 
tag in order to only use the WKWebView (which is required for new Apps to the 
AppStore):

Review comment:
   ```suggestion
   If using `cordova-ios >= 5.1.0`, it is recommended to include the following 
`preference` tag to only use the `WKWebView` which is a requirement for new App 
submissions to the AppStore:
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-electron] erisu merged pull request #153: refactor: cleanup unused code

[GitBox]

erisu merged pull request #153:
URL: https://github.com/apache/cordova-electron/pull/153


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-wkwebview-engine] breautek commented on pull request #161: added WKWebViewOnly to Readme

[GitBox]

breautek commented on pull request #161:
URL: 
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/161#issuecomment-643322131


   If I don't receive a second review by Monday I'll just go ahead and merge 
since this is a trivial change.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] dpa99c closed issue #144: config-file is merged into wrong *-Info.plist when other plugin has podspec.

[GitBox]

dpa99c closed issue #144:
URL: https://github.com/apache/cordova-common/issues/144


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-wkwebview-engine] machinaeXphilip commented on pull request #161: added WKWebViewOnly to Readme

[GitBox]

machinaeXphilip commented on pull request #161:
URL: 
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/161#issuecomment-643309425


   awkward. sorry for the extra work. 
   
   this is what i get for multitasking.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-wkwebview-engine] breautek commented on pull request #161: added WKWebViewOnly to Readme

[GitBox]

breautek commented on pull request #161:
URL: 
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/161#issuecomment-643294277


   > you might also have to you might have to also 
   
   Think you might have doubled up some words here :)
   
   > is there information to be referenced about the behaviour above 5.1.0 that 
could be included additionally?
   
   I don't believe so... this plugin is not usable on cordova-ios@6, but that's 
already documented from 
https://github.com/apache/cordova-plugin-wkwebview-engine/commit/486e5a74ec826b88d156dafe427aabf0827162ab
   
   There isn't an official conclusion from Apache yet, but I'm pretty sure this 
plugin is going to become deprecated soon.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-5989) Properties defined in plugin.xml are not created in *-Info.plist

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/CB-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134245#comment-17134245
 ] 

ASF subversion and git services commented on CB-5989:
-

Commit a18bf0e2774b40dda11e3475b11a2dc3639bdb80 in cordova-common's branch 
refs/heads/master from Dave Alden
[ https://gitbox.apache.org/repos/asf?p=cordova-common.git;h=a18bf0e ]

(ios) fix: resolve correct path to app info plist when multiple plist files are 
present (#144).

When multiple plist files exists in a cordova-ios project (e.g. due to a plugin 
containing ``), ConfigFile was updated under CB-5989 to select the app 
plist as the target for changes destined for *-Info.plist.
However, the change made under CB-5989 incorrectly constructed the path to the 
app plist by omitting the project name subdirectory from the path, causing the 
fix to fail to work.

This commit fixes this by correcting the constructed path to the app plist.


> Properties defined in plugin.xml are not created in *-Info.plist
> 
>
> Key: CB-5989
> URL: https://issues.apache.org/jira/browse/CB-5989
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-plugman
>Affects Versions: 3.3.0
> Environment: Mavericks 10.9.1; Xcode 5.0.2; Cordova 3.3.1-0.3.0
>Reporter: Kelvin Dart
>Priority: Major
>  Labels: CLI, Plugin
> Attachments: after_platform_add_plist_fix.sh, 
> before_platform_add_plist_fix.sh
>
>
> I have the following tag in my  tag, within plugin.xml:
>  parent="UISupportedExternalAccessoryProtocols">
> 
> jp.star-m.starpro
> 
> 
> However, whenever I attempt to add in my plugin, this setting is not applied 
> to my project's plist file and I have to do it manually.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-5989) Properties defined in plugin.xml are not created in *-Info.plist

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/CB-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134244#comment-17134244
 ] 

ASF subversion and git services commented on CB-5989:
-

Commit a18bf0e2774b40dda11e3475b11a2dc3639bdb80 in cordova-common's branch 
refs/heads/master from Dave Alden
[ https://gitbox.apache.org/repos/asf?p=cordova-common.git;h=a18bf0e ]

(ios) fix: resolve correct path to app info plist when multiple plist files are 
present (#144).

When multiple plist files exists in a cordova-ios project (e.g. due to a plugin 
containing ``), ConfigFile was updated under CB-5989 to select the app 
plist as the target for changes destined for *-Info.plist.
However, the change made under CB-5989 incorrectly constructed the path to the 
app plist by omitting the project name subdirectory from the path, causing the 
fix to fail to work.

This commit fixes this by correcting the constructed path to the app plist.


> Properties defined in plugin.xml are not created in *-Info.plist
> 
>
> Key: CB-5989
> URL: https://issues.apache.org/jira/browse/CB-5989
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-plugman
>Affects Versions: 3.3.0
> Environment: Mavericks 10.9.1; Xcode 5.0.2; Cordova 3.3.1-0.3.0
>Reporter: Kelvin Dart
>Priority: Major
>  Labels: CLI, Plugin
> Attachments: after_platform_add_plist_fix.sh, 
> before_platform_add_plist_fix.sh
>
>
> I have the following tag in my  tag, within plugin.xml:
>  parent="UISupportedExternalAccessoryProtocols">
> 
> jp.star-m.starpro
> 
> 
> However, whenever I attempt to add in my plugin, this setting is not applied 
> to my project's plist file and I have to do it manually.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] dpa99c merged pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)

[GitBox]

dpa99c merged pull request #148:
URL: https://github.com/apache/cordova-common/pull/148


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] codecov-commenter edited a comment on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)

[GitBox]

codecov-commenter edited a comment on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643286829


   # 
[Codecov](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=h1) 
Report
   > Merging 
[#148](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-common/commit/b5ba4db84b993e1c31f0d73a1d37d6a7f92b845d&el=desc)
 will **increase** coverage by `0.01%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-common/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=jsbcYRuqT5)](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #148  +/-   ##
   ==
   + Coverage   88.23%   88.24%   +0.01% 
   ==
 Files  20   20  
 Lines1173 1174   +1 
   ==
   + Hits 1035 1036   +1 
 Misses138  138  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[src/ConfigChanges/ConfigFile.js](https://codecov.io/gh/apache/cordova-common/pull/148/diff?src=pr&el=tree#diff-c3JjL0NvbmZpZ0NoYW5nZXMvQ29uZmlnRmlsZS5qcw==)
 | `92.23% <100.00%> (+0.07%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=footer).
 Last update 
[b5ba4db...a18bf0e](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] codecov-commenter commented on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)

[GitBox]

codecov-commenter commented on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643286829


   # 
[Codecov](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=h1) 
Report
   > Merging 
[#148](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-common/commit/b5ba4db84b993e1c31f0d73a1d37d6a7f92b845d&el=desc)
 will **increase** coverage by `0.01%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-common/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=jsbcYRuqT5)](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #148  +/-   ##
   ==
   + Coverage   88.23%   88.24%   +0.01% 
   ==
 Files  20   20  
 Lines1173 1174   +1 
   ==
   + Hits 1035 1036   +1 
 Misses138  138  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[src/ConfigChanges/ConfigFile.js](https://codecov.io/gh/apache/cordova-common/pull/148/diff?src=pr&el=tree#diff-c3JjL0NvbmZpZ0NoYW5nZXMvQ29uZmlnRmlsZS5qcw==)
 | `92.23% <100.00%> (+0.07%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=footer).
 Last update 
[b5ba4db...a18bf0e](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] dpa99c commented on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)

[GitBox]

dpa99c commented on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643284186


   > I don't see any passing tests.
   > 
   > Two test, ubuntu, failed and caused GitHub Actions to cancelled the other 
4 tests.
   
   ah, yes, I misread the cancelled as passed (no big red X)
   
   will run/fix the tests locally and update my branch.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] erisu edited a comment on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)

[GitBox]

erisu edited a comment on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643283534


   I don't see any passing tests.
   
   Two test, ubuntu, had failed and caused GitHub Actions to trigger the cancel 
procedure of the other four remaining tests with out either starting or 
finishing.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] erisu edited a comment on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)

[GitBox]

erisu edited a comment on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643283534


   I don't see any passing tests.
   
   Two test, ubuntu, failed and caused GitHub Actions to cancelled the other 4 
tests with out either starting or finishing.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] erisu commented on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)

[GitBox]

erisu commented on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643283534


   I don't see any passing tests.
   
   Two test, ubuntu, failed and caused GitHub Actions to cancelled the other 4 
tests.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] erisu edited a comment on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)

[GitBox]

erisu edited a comment on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643279209


   Looks like a test file though might need to be updated.
   
   This line specifically will need the change:
   ```javascript
 const expectedPlistPath = `${projName}-Info.plist`;
   ```
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] erisu edited a comment on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)

[GitBox]

erisu edited a comment on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643279209


   Looks like a test file though might need to be updated.
   
   Looks like its this line that will need to be changed.
   ```javascript
 const expectedPlistPath = `${projName}-Info.plist`;
   ```
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] dpa99c commented on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)

[GitBox]

dpa99c commented on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643282320


   Interesting that the ubuntu tests failed but windows & osx passed.
   Is there some platform-specific difference between the paths on windows/osx 
vs ubuntu?
   This may explain why CB-5989 failed to fix the issue on osx?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] dpa99c commented on issue #144: config-file is merged into wrong *-Info.plist when other plugin has podspec.

[GitBox]

dpa99c commented on issue #144:
URL: https://github.com/apache/cordova-common/issues/144#issuecomment-643280523


   The above PR fixes this issue. To confirm, run the following test 
(continuing on from my test scenarios above):
   
% git checkout Podt-fixed
   
   
   This checks out a branch where the app name is still "Podt" but it 
references my [fork of `cordova-ios`](https://github.com/dpa99c/cordova-ios) 
which in turn references [my fork on 
`cordova-common`](https://github.com/dpa99c/cordova-common/tree/GH-144) which 
contains [the 
fix](https://github.com/dpa99c/cordova-common/commit/c9afe77ab2b004f87a0426753a58a4aaaf0aded4).
   
   Re-add the platform using my fork:
   
% cordova platform rm ios --nosave && cordova platform add ios --nosave
   
   
   Now search for the plugin plist strings:
   
% grep -r "TestPluginA-present" platforms/ios | grep plist
platforms/ios/Podt/Podt-Info.plist: 
TestPluginA-present

% grep -r "TestPluginB-present" platforms/ios | grep plist
platforms/ios/Podt/Podt-Info.plist: 
TestPluginB-present
   
   They are now in the expected app plist location.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] erisu edited a comment on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)

[GitBox]

erisu edited a comment on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643279209


   Looks like a test file though might need to be updated. Could be some 
hard-coded mocked test.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] erisu commented on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)

[GitBox]

erisu commented on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643279209


   Looks like a test file though might need to be updated.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] dpa99c opened a new pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)

[GitBox]

dpa99c opened a new pull request #148:
URL: https://github.com/apache/cordova-common/pull/148


   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   
   
   
   When multiple plist files exists in a cordova-ios project (e.g. due to a 
plugin containing ``), ConfigFile was updated under CB-5989 to select 
the app plist as the target for changes destined for *-Info.plist.
   However, the change made under CB-5989 incorrectly constructed the path to 
the app plist by omitting the project name subdirectory from the path, causing 
the fix to fail to work.
   
   This bug is outlined in #144. 
   
   ### Description
   
   This commit fixes this by correcting the constructed path to the app plist.
   
   
   ### Testing
   
   I've created a repo containing a test Cordova project which reproduces the 
various scenarios to illustrate the issue:
   https://github.com/dpa99c/cordova-common-issue-144
   
   Details of these scenarios can be found in [this 
comment](https://github.com/apache/cordova-common/issues/144#issuecomment-643215608).
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change **N/A**
   - [x] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary **N/A**
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] dpa99c commented on issue #144: config-file is merged into wrong *-Info.plist when other plugin has podspec.

[GitBox]

dpa99c commented on issue #144:
URL: https://github.com/apache/cordova-common/issues/144#issuecomment-643273934


   Oops, that was implicit - didn't mean to close without review



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-wkwebview-engine] machinaeXphilip commented on pull request #161: added WKWebViewOnly to Readme

[GitBox]

machinaeXphilip commented on pull request #161:
URL: 
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/161#issuecomment-643271990


   > Thanks for your contribution!
   > 
   > I would actually add a note to this preference stating that 
`WKWebViewOnly` only works on `cordova-ios` versions >= 5.1.0
   
   thank you! implemented the version limitation. 
   
   is there information to be referenced about the behaviour above 5.1.0 that 
could be included additionally?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-android] ksch10bob commented on issue #695: Missing Intent type and category prevent file upload - [solution included]

[GitBox]

ksch10bob commented on issue #695:
URL: https://github.com/apache/cordova-android/issues/695#issuecomment-643270137


   @breautek 
   i can only speak for android Versions from 5.xx 
   
   case 1 : no or an empty accept attribute is specified. Works like intended, 
you get the fully featured file picker
   
   case 2 : your specify an accept attribute on the input tag that contains at 
least 2 entries
   try `` in 
your minimal cordova repo
   
   ## expected
   you can choose jpegs and pdfs
   
   ## actually
   
   you can only choose pdfs



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] dpa99c closed issue #144: config-file is merged into wrong *-Info.plist when other plugin has podspec.

[GitBox]

dpa99c closed issue #144:
URL: https://github.com/apache/cordova-common/issues/144


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-splashscreen] 11digits commented on issue #186: [Android 9 - target SDK 28] Backbutton not working

[GitBox]

11digits commented on issue #186:
URL: 
https://github.com/apache/cordova-plugin-splashscreen/issues/186#issuecomment-643250017


   I used this, and it works for me 
https://github.com/prageeth/cordova-plugin-splashscreen



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] StaymanHou commented on issue #897: origin is null for requests sent with window.fetch on WKWebView engine

[GitBox]

StaymanHou commented on issue #897:
URL: https://github.com/apache/cordova-ios/issues/897#issuecomment-643244312


   Managed to workaround that by using 
https://github.com/aporat/cordova-plugin-fetch
   
   Still would love to figure out the cause when get a chance, but the fetch 
plugin by @aporat would do it for now.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] erisu edited a comment on pull request #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard

[GitBox]

erisu edited a comment on pull request #790:
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-643238933


   @kanongil Please test against nightly or master.
   
   The Issue you are mentioning sound relatively similar to what has already 
been reported and fixed in master.
   
   * https://github.com/apache/cordova-ios/issues/890
   * https://github.com/apache/cordova-ios/pull/896
   
   If you have any issues please open a new ticket instead of messaging inside 
a PR which has already been merged and released.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] erisu edited a comment on pull request #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard

[GitBox]

erisu edited a comment on pull request #790:
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-643238933


   @kanongil Please test against nightly or master.
   
   The Issue you are mentioning sound relatively similar to what has already 
been reported and fixed in master.
   
   * https://github.com/apache/cordova-ios/issues/890
   * https://github.com/apache/cordova-plugin-splashscreen/issues/268
   
   If you have any issues please open a new ticket instead of messaging inside 
a PR which has already been merged and released.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] erisu edited a comment on pull request #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard

[GitBox]

erisu edited a comment on pull request #790:
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-643238933


   @kanongil Please test against nightly or master.
   
   The Issue you are mentioning sound relatively similar to what has already 
been reported and fixed in master.
   
   * https://github.com/apache/cordova-ios/issues/890
   * https://github.com/apache/cordova-ios/pull/790
   
   If you have any issues please open a new ticket instead of messaging inside 
a PR which has already been merged and released.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] erisu commented on pull request #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard

[GitBox]

erisu commented on pull request #790:
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-643238933


   @kanongil Please test against nightly or master.
   
   The Issue you mentioning sound relatively similar to what has already been 
reported and fixed in master.
   
   If you have any issues please open a new ticket instead of messaging inside 
a PR which has already been merged and released.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] kanongil commented on a change in pull request #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard

[GitBox]

kanongil commented on a change in pull request #790:
URL: https://github.com/apache/cordova-ios/pull/790#discussion_r439379483



##
File path: CordovaLib/Classes/Public/CDVViewController.m
##
@@ -729,6 +760,43 @@ - 
(void)onAppDidEnterBackground:(NSNotification*)notification
 [self.commandDelegate evalJs:@"cordova.fireDocumentEvent('pause', null, 
true);" scheduledOnRunLoop:NO];
 }
 
+/**
+ Show the webview and fade out the intermediary view
+ This is to prevent the flashing of the mainViewController
+ */
+- (void)onWebViewPageDidLoad:(NSNotification*)notification
+{
+self.webView.hidden = NO;
+
+if ([self.settings cordovaBoolSettingForKey:@"AutoHideSplashScreen" 
defaultValue:YES]) {
+   [self showLaunchScreen:NO];
+}
+}
+
+/**
+ Method to be called from the plugin JavaScript to show or hide the launch 
screen.
+ */
+- (void)showLaunchScreen:(BOOL)visible

Review comment:
   This method delays showing the splash screen by `SplashScreenDelay` ms 
when `visible = YES`.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-common] dpa99c commented on issue #144: config-file is merged into wrong *-Info.plist when other plugin has podspec.

[GitBox]

dpa99c commented on issue #144:
URL: https://github.com/apache/cordova-common/issues/144#issuecomment-643215608


   This is still an issue with `cordova-common@4.0.1` / `cordova-ios@6`:
   
   If the app `` in `config.xml` starts with a name which places it 
before `Pods` in the alphabet, then the issue manifests.
   
   I've created a repo to a reproducible test case: 
https://github.com/dpa99c/cordova-common-issue-144
   
   It contains 2 test plugins - both of which use a `` to add an 
arbitrary cocoapod to the project and both of which insert values into the app 
`.plist`.
   
   First clone the repo:
   
% git clone https://github.com/dpa99c/cordova-common-issue-144 && cd 
cordova-common-issue-144
   
   Now checkout the branch which contains the app name "Podr" (one letter 
before "Pods" in the alphabet):
   
% git checkout Podr
   
   
   Now let's add `cordova-ios@6` platform:
   
% cordova platform add ios
   
   And we confirm we're using the expected versions of `cordova-ios` and 
`cordova-common`:
   
% npm list cordova-common
helloworld@1.0.0 /projects/@scratch/temp/cordova-common-issue-144
└─┬ cordova-ios@6.0.0
  └── cordova-common@4.0.1 
   
   
   We're expecting to see that both our plugins add their entries to the app 
info plist.
   Because our app name is "Podr", our app list will be 
`platforms/ios/Podr/Podr-Info.plist`.
   
   So if we search for our first plugin entry:
   
% grep -r "TestPluginA-present" platforms/ios | grep plist
   
   We should see:

platforms/ios/Podr/Podr-Info.plist: 
TestPluginA-present
   
   Same for our second plugin:
   
% grep -r "TestPluginB-present" platforms/ios | grep plist  
platforms/ios/Podr/Podr-Info.plist: 
TestPluginB-present
   
   
   Now checkout the "Podt" branch (one letter after "Pods" in the alphabet)
   
% git checkout Podt
   
   Remove and re-add the ios platform:
   
% cordova platform rm ios --nosave && cordova platform add ios --nosave
   
   This time when we search for the first plugin plist entry, the result is 
unexpected:
   
% grep -r "TestPluginA-present" platforms/ios | grep plist
platforms/ios/Podt/Podt-Info.plist: 
TestPluginA-present
platforms/ios/Pods/Target Support Files/Pods-Podt/Pods-Podt-Info.plist: 
TestPluginA-present
   
   We see it's in both the app plist as expected, but also in the Pods plist.
   
   And the second plugin:
   
% grep -r "TestPluginB-present" platforms/ios | grep plist
platforms/ios/Pods/Target Support Files/Pods-Podt/Pods-Podt-Info.plist: 
TestPluginB-present
   
   Is **only** present in the Pods plist - it's missing from the app plist.
   
   
   To confirm that the `` in the first plugin is responsible for this, 
check out the "plugin-A-no-pods" branch in which the `` is commented 
out in the `plugin.xml` of the first plugin:
   
% git checkout plugin-A-no-pods
   
   The app name is "Z"  on this branch, which of course comes after "Pods" in 
the alphabet, so we'd expect to see the issue manifest (you can confirm this by 
checking out the "Z" branch which has the same app name but no commented out 
``).
   
   Remove and re-add the ios platform:
   
% cordova platform rm ios --nosave && cordova platform add ios --nosave
   
   
   As before, the first plugin entry is present in both plists:
   
% grep -r "TestPluginA-present" platforms/ios | grep plist
platforms/ios/Z/Z-Info.plist:   TestPluginA-present
platforms/ios/Pods/Target Support Files/Pods-Z/Pods-Z-Info.plist:   
TestPluginA-present
   
   But the second plugin entry is now also present in both plists:
   
% grep -r "TestPluginB-present" platforms/ios | grep plist
platforms/ios/Z/Z-Info.plist:   TestPluginB-present
platforms/ios/Pods/Target Support Files/Pods-Z/Pods-Z-Info.plist:   
TestPluginB-present
   
   
   This issue is affecting a production project of mine, so I'm keen to find a 
fix (currently my workaround is to manually move the missing keys from the Pods 
plist to the app plist).
   If I'm able to track down/fix the issue, I'll submit a PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-statusbar] mosabab removed a comment on issue #191: [iOS] StatusBarStyle preference {broken} on iOS 13.5

[GitBox]

mosabab removed a comment on issue #191:
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/191#issuecomment-642266013


   @breautek @NiklasMerz 
   
   Did you face this problem ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] kanongil edited a comment on pull request #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard

[GitBox]

kanongil edited a comment on pull request #790:
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-643212844


   This displays an empty screen for me (transparent, unless backgroundcolor is 
set). The storyboard is loaded and ok, but the view returned from 
`snapshotViewAfterScreenUpdates:` is blank.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-wkwebview-engine] Vito96 commented on issue #147: Tel or mailto links not working on WKWebview

[GitBox]

Vito96 commented on issue #147:
URL: 
https://github.com/apache/cordova-plugin-wkwebview-engine/issues/147#issuecomment-643213088


   Any news about this?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-ios] kanongil commented on pull request #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard

[GitBox]

kanongil commented on pull request #790:
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-643212844


   This displays an empty screen for me (transparent, unless backgroundcolor is 
is). The storyboard is loaded and ok, but the view returned from 
`snapshotViewAfterScreenUpdates:` is blank.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-plugin-wkwebview-engine] machinaeXphilip opened a new pull request #161: added WKWebViewOnly to Readme

[GitBox]

machinaeXphilip opened a new pull request #161:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/161


   added WKWebViewOnly to Readme to config Readme explanation.
   
   ### Motivation and Context
   
   This is (afaik) needed in order to be able to upload new apps to the iOS App 
Store. I assume because without it both WebViews get delivered which then 
triggers Apples ITMS-90809: Deprecated API Usage Error on processing of the App
   
   
   ### Testing
   
   try upload app to AppStoreConnect via XCode without the added xml tag and 
without.
   
   with the tag:  ITMS-90809: Deprecated API Usage Error
   
   with the tag: passes
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-electron] erisu commented on a change in pull request #154: feature: support custom scheme & hostname

[GitBox]

erisu commented on a change in pull request #154:
URL: https://github.com/apache/cordova-electron/pull/154#discussion_r439324809



##
File path: bin/templates/platform_www/cdv-electron-main.js
##
@@ -62,10 +89,27 @@ function createWindow () {
 });
 }
 
+function configureProtocol () {
+protocol.registerFileProtocol(scheme, (request, _cb) => {
+const url = request.url.substr(basePath.length + 1);
+_cb({ path: path.normalize(`${__dirname}/${url}`) });
+}, (error) => {
+if (error) console.error('Failed to register protocol');

Review comment:
   I have removed error method. It is deprecated.
   
   > (node:53460) ProtocolDeprecateCallback: The callback argument of protocol 
module APIs is no longer needed.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-electron] erisu commented on a change in pull request #154: feature: support custom scheme & hostname

[GitBox]

erisu commented on a change in pull request #154:
URL: https://github.com/apache/cordova-electron/pull/154#discussion_r439324809



##
File path: bin/templates/platform_www/cdv-electron-main.js
##
@@ -62,10 +89,27 @@ function createWindow () {
 });
 }
 
+function configureProtocol () {
+protocol.registerFileProtocol(scheme, (request, _cb) => {
+const url = request.url.substr(basePath.length + 1);
+_cb({ path: path.normalize(`${__dirname}/${url}`) });
+}, (error) => {
+if (error) console.error('Failed to register protocol');

Review comment:
   I have removed method that prints error.
   
   It is deprecated.
   
   > (node:53460) ProtocolDeprecateCallback: The callback argument of protocol 
module APIs is no longer needed.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[GitHub] [cordova-electron] erisu commented on a change in pull request #154: feature: support custom scheme & hostname

[GitBox]

erisu commented on a change in pull request #154:
URL: https://github.com/apache/cordova-electron/pull/154#discussion_r439324202



##
File path: bin/templates/platform_www/cdv-electron-main.js
##
@@ -62,10 +89,27 @@ function createWindow () {
 });
 }
 
+function configureProtocol () {
+protocol.registerFileProtocol(scheme, (request, _cb) => {

Review comment:
   I updated the `.eslintrc` to exclude all `standard/no-callback-literal` 
checks to that file.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org