[GitHub] [cordova-plugin-device] RSATom opened a new pull request, #179: [iOs] Device properties request can crash if invoked on locked device
RSATom opened a new pull request, #179: URL: https://github.com/apache/cordova-plugin-device/pull/179 ### Platforms affected iOs ### Motivation and Context I think it should fix #108 ### Description Just replace nil values with empty string since NSDictionary crashes in that case ### Testing Don't sure how to test it, since it's pretty rare case. ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-docs] breautek opened a new issue, #1255: Document new android preferences
breautek opened a new issue, #1255:
URL: https://github.com/apache/cordova-docs/issues/1255
# Feature Request
## Motivation Behind Feature
To document new preferences that was added in cordova-android.
Brought to our attention by:
https://github.com/apache/cordova-android/pull/1410#issuecomment-1193351277
Most of the new preferences was introduced in
https://github.com/apache/cordova-android/pull/1212
The current list of preferences for android can be found at (omitting the
preferences that is already documented):
https://github.com/apache/cordova-android/blob/60e3803c67734087b7a6ff8ee8bd3a659cb050f8/lib/prepare.js#L99-L111
```javascript
{ xmlKey: 'android-compileSdkVersion', gradleKey:
'COMPILE_SDK_VERSION', type: Number },
{ xmlKey: 'android-buildToolsVersion', gradleKey:
'BUILD_TOOLS_VERSION', type: String },
{ xmlKey: 'GradleVersion', gradleKey: 'GRADLE_VERSION', type: String
},
{ xmlKey: 'AndroidGradlePluginVersion', gradleKey: 'AGP_VERSION',
type: String },
{ xmlKey: 'AndroidXAppCompatVersion', gradleKey:
'ANDROIDX_APP_COMPAT_VERSION', type: String },
{ xmlKey: 'AndroidXWebKitVersion', gradleKey:
'ANDROIDX_WEBKIT_VERSION', type: String },
{ xmlKey: 'GradlePluginGoogleServicesVersion', gradleKey:
'GRADLE_PLUGIN_GOOGLE_SERVICES_VERSION', type: String },
{ xmlKey: 'GradlePluginGoogleServicesEnabled', gradleKey:
'IS_GRADLE_PLUGIN_GOOGLE_SERVICES_ENABLED', type: Boolean },
```
I'll list some suggested brief descriptions, which is not set in stone, and
definitely not meant to be copied and pasted. They are just general highlights
of what the preference is used for. Reviews can be done in any given PRs.
### android-compileSdkVersion
Defaults to `android-targetSdkVersion`. Sets the compile sdk version
setting. Should find android doc link.
### android-buildToolsVersion
Defaults are cordova-android version dependent. Expects a full version
string `eg. "32.0.0"`. Changing this may also requires changing the `PATH`
environment variable to find the proper build tools.
This preference is primarily for cordova development, for testing upcoming
versions of the Android SDK. Changing this has a high risk of breaking builds
as newer build tools frequently introduce breaking changes.
### GradleVersion
Sets the gradle wrapper version to use.
This preference is primarily for cordova development, for testing upcoming
versions of the Android SDK. Changing this has a high risk of breaking builds
as newer build tools frequently introduce breaking changes.
### AndroidGradlePluginVersion
Sets the Android Gradle Plugin version to use.
This preference is primarily for cordova development, for testing upcoming
versions of the Android SDK. Changing this has a high risk of breaking builds
as newer build tools frequently introduce breaking changes.
### AndroidXAppCompatVersion
Someone more knowledgeable will have to fill in the description for me.
(Maybe brief description of what the AndroidX App Compat is used for?)
### AndroidXWebKitVersion
Someone more knowledgeable will have to fill in the description for me.
(Maybe brief description of what the AndroidX Webkit dependency is for?)
### GradlePluginGoogleServicesVersion
Overrides the google services library version.
### GradlePluginGoogleServicesEnabled
Enables Google Services. (I think google API keys are required?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-android] breautek commented on pull request #1410: feat!: API 31 support
breautek commented on PR #1410: URL: https://github.com/apache/cordova-android/pull/1410#issuecomment-1194255087 I wasn't aware there can be some restrictions in the gradle version + android studio, I figured they'd support at least a given major with any minor/patch version. Thanks for the [compatibility](https://developer.android.com/studio/releases/gradle-plugin#agp-studio-compatibility) table, this is definitely good to know. Regarding the preferences, yah there are a number of preferences that was added (back in v10 if I recall correctly) without actually being documented. Some of these preferences will very likely break builds if you use something other than the default configured. Cordova is only ever tested against the default configuration for build tools, AGP version, etc... I think we can document these but I think some of these new preferences needs to be stressed that they are for advanced usage / cordova development only I'll create a issue on the docs repo as a reminder. Eventually I'll get to it, if someone else doesn't get to it first. PRs are welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-camera] Houdhey commented on issue #797: Android 13 : Camera/Gallery doesn't open
Houdhey commented on issue #797: URL: https://github.com/apache/cordova-plugin-camera/issues/797#issuecomment-1194203605 Can we have an update on this bug please? I think Android 13 is gonna be released soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-ios] dpogue commented on issue #1244: DisallowOverscroll does not work on iOS 16
dpogue commented on issue #1244: URL: https://github.com/apache/cordova-ios/issues/1244#issuecomment-1194109267 iOS 16 supports the [CSS `overscroll-behaviour` property](https://developer.mozilla.org/en-US/docs/Web/CSS/overscroll-behavior) to control this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-ios] PeterBenko opened a new issue, #1244: DisallowOverscroll does not work on iOS 16
PeterBenko opened a new issue, #1244: URL: https://github.com/apache/cordova-ios/issues/1244 # Bug Report ## Problem The same code that worked as expected on iOS 15 seems to now be broken on the latest iOS 16 public beta. DisallowOverscroll used to successfully prevent the full app from bouncing, but on iOS 16 seems to have no effect. ### What is expected to happen? The full app should not bounce on scroll. ### What does actually happen? The app bounces on scroll ## Information We have investigated the issue and it seems like [setting the scrollView bounces to NO](https://github.com/apache/cordova-ios/blob/f12abcc9973fd0618ddc8999df3fa2e96468ecf1/CordovaLib/Classes/Private/Plugins/CDVWebViewEngine/CDVWebViewEngine.m#L392) doesn't fulfill its purpose anymore. This would imply a change on iOS 16 side, but it is unclear if this is a bug or the new intended behaviour and thus a necessary change for cordova-ios. Note: We could fix the issue in our application by additionally setting `alwaysBounceVertical` to `NO` but [this doesn't align with Apple's documentation](https://developer.apple.com/documentation/uikit/uiscrollview/1619383-alwaysbouncevertical?language=objc). The fix did however not work on a clean cordova-ios project so there must be some other factor to this that we could not yet determine. ### Command or Code The issue is reproducible with the base Cordova iOS app, with the "DisallowOverscroll" config set to TRUE: the same application behaves differently on iOS 15 than on iOS 16 when scrolling (at least for vertical scrolls). ### Environment, Platform, Device iOS 16, iPad ### Version information cordova 11.0 cordova-ios 6.2.0 ## Checklist - [X] I searched for existing GitHub issues - [X] I updated all Cordova tooling to most recent version - [X] I included all the necessary information above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] joanbat opened a new pull request, #968: GH-706 android: Allow permissions requests
joanbat opened a new pull request, #968: URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/968 ### Platforms affected Android ### Motivation and Context Android in-app-browser does not allow in-browser camera/webcamera usage (permission denied) With this change, camera usage will be allowed as long as the app has permissions. Issue GH-706: https://github.com/apache/cordova-plugin-inappbrowser/issues/706 ### Description Allows permissions requests from ChromeWebView ### Testing IAB would show permissions denied error in website https://webcam-test.com/ After the changes it successfuly works (requires app's camera permission to be enabled) ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
