[jira] [Commented] (CB-11641) MediaError object missing message member

2022-09-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/CB-11641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599497#comment-17599497
 ] 

ASF subversion and git services commented on CB-11641:
--

Commit 081fa5ed2fe9492b1b8a02272796901c64658894 in cordova-plugin-media's 
branch refs/heads/master from エリス
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-media.git;h=081fa5e ]

feat(android): add 'message' field to media error CB-11641 (#357)

* CB-11641 android: add 'message' field to media error

It was not possible before to get error message.This updated Android 
implementation to return error code with message similar to iOS.

* style: apply lint corrections
* refactor(android): private API sendStatusChange

Co-authored-by: Nikita Matrosov 

> MediaError object missing message member
> 
>
> Key: CB-11641
> URL: https://issues.apache.org/jira/browse/CB-11641
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-media
>Affects Versions: 2.3.0
> Environment: Building on OSX 10.11.5, Android 5.1.1 and 5.2.0
>Reporter: Madison Dickson
>Assignee: Nikita Matrosov
>Priority: Minor
>  Labels: pull-request-available
>
> on iOS, the MediaError object contains both the error code and the message. 
> On Android, the object is missing the message.
> {code}
> new Media(this.src,
> // success callback
> successCallback,
> // error callback
> function(err) {
> console.log("recordAudio():Audio Error Code: "+ err.code + ", "+ 
> err.message, err);
> if(app.file){
> app.file.release();
> app.file = null;
> // app.stop();
> }
> }
> {code}
> outputs: {{recordAudio():Audio Error Code: 0, undefined}}
> I have seen both error code 0 and error code 1, the former of which is not 
> documented. 
> https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-media/index.html#mediaerror



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[GitHub] [cordova-plugin-media] erisu merged pull request #357: feat(android): add 'message' field to media error CB-11641

2022-09-02 Thread GitBox


erisu merged PR #357:
URL: https://github.com/apache/cordova-plugin-media/pull/357


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[GitHub] [cordova-plugin-media] erisu closed pull request #117: CB-11641 android: add 'message' field to media error

2022-09-02 Thread GitBox


erisu closed pull request #117: CB-11641 android: add 'message' field to media 
error
URL: https://github.com/apache/cordova-plugin-media/pull/117


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[GitHub] [cordova-ios] stupidchou opened a new issue, #1252: https requests cannot be intercepted by NSURLProtocol

2022-09-02 Thread GitBox


stupidchou opened a new issue, #1252:
URL: https://github.com/apache/cordova-ios/issues/1252

   
   ### Issue Type
   
   
   - [ ] Bug Report
   - [ ] Feature Request
   - [x] Support Question
   
   ## Description
   When I call the https request, I want to use the local js file and find that 
the local js cannot be intercepted
   
   ## Information
   When using cordova to access remote html, I use 

[GitHub] [cordova-docs] manojchandrashekar opened a new pull request, #1259: Corrected typos for OS name (window -> windows)

2022-09-02 Thread GitBox


manojchandrashekar opened a new pull request, #1259:
URL: https://github.com/apache/cordova-docs/pull/1259

   
   
   ### Platforms affected
   
   Windows?
   
   ### Motivation and Context
   Documentation errors correction
   
   
   
   ### Description
   Changed spelling "window" to "windows" incorrectly used for the name of the 
OS.
   
   
   
   ### Testing
   Visually.
   
   
   
   ### Checklist
   
   - [?] I've run the tests to see all new and existing tests pass
   - [?] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   
   Not sure if steps 1-2 in the checklist are valid for a documentation 
correction.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org