[jira] [Commented] (CB-13865) Making CameraPopover for imagePicker bigger on Ipad
[
https://issues.apache.org/jira/browse/CB-13865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372957#comment-16372957
]
Ams commented on CB-13865:
--
Hi,
I am trying to implement the change and I need to figure out how to run the
test cases.
For tests/ios: I figured it out using the commands below:
cd tests/ios && npm install && npm test
However, there is a file called tests.js: (tests/tests.js) this file has the
javascript tests for the function I need such as window.onorientationchange.
However, I do not know how to run those tests. I tried the commands below but
they do nothing.
cd tests && npm install && npm test
Output: Error: no test specified
> Making CameraPopover for imagePicker bigger on Ipad
> ---
>
> Key: CB-13865
> URL: https://issues.apache.org/jira/browse/CB-13865
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-camera
>Reporter: Ams
>Priority: Major
> Fix For: Master
>
>
> The popover for imagePicker from gallery is way too small and people complain
> about not being able to see images before selecting them.
>
> The fix is simple:
>
> Adding this line to willShowViewController method will set it to 960 by 960
> or as big as the screen widht/height
> [viewController setPreferredContentSize:CGSizeMake(960,960)];
> It should be added right in the if statement:
> if([navigationController isKindOfClass:[UIImagePickerController class]]){
>
> HOW CAN I COMMIT THIS CHANGE?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13865) Making CameraPopover for imagePicker bigger on Ipad
[
https://issues.apache.org/jira/browse/CB-13865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ams updated CB-13865:
-
Description:
The popover for imagePicker from gallery is way too small and people complain
about not being able to see images before selecting them.
The fix is simple:
Adding this line to willShowViewController method will set it to 960 by 960 or
as big as the screen widht/height
[viewController setPreferredContentSize:CGSizeMake(960,960)];
It should be added right in the if statement:
if([navigationController isKindOfClass:[UIImagePickerController class]]){
HOW CAN I COMMIT THIS CHANGE?
was:
The popover for imagePicker from gallery is way too small and people complain
about not begin able to see images before selecting them.
The fix is simple:
Adding this line to willShowViewController method will set it to 960 by 960 or
as big as the screen widht/height
[viewController setPreferredContentSize:CGSizeMake(960,960)];
It should be added right in the if statement:
if([navigationController isKindOfClass:[UIImagePickerController class]]){
HOW CAN WE COMMIT THIS CHANGE?
> Making CameraPopover for imagePicker bigger on Ipad
> ---
>
> Key: CB-13865
> URL: https://issues.apache.org/jira/browse/CB-13865
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-camera
>Reporter: Ams
>Priority: Major
> Fix For: Master
>
>
> The popover for imagePicker from gallery is way too small and people complain
> about not being able to see images before selecting them.
>
> The fix is simple:
>
> Adding this line to willShowViewController method will set it to 960 by 960
> or as big as the screen widht/height
> [viewController setPreferredContentSize:CGSizeMake(960,960)];
> It should be added right in the if statement:
> if([navigationController isKindOfClass:[UIImagePickerController class]]){
>
> HOW CAN I COMMIT THIS CHANGE?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13865) Making CameraPopover for imagePicker bigger on Ipad
Ams created CB-13865:
Summary: Making CameraPopover for imagePicker bigger on Ipad
Key: CB-13865
URL: https://issues.apache.org/jira/browse/CB-13865
Project: Apache Cordova
Issue Type: Improvement
Components: cordova-plugin-camera
Reporter: Ams
Fix For: Master
The popover for imagePicker from gallery is way too small and people complain
about not begin able to see images before selecting them.
The fix is simple:
Adding this line to willShowViewController method will set it to 960 by 960 or
as big as the screen widht/height
[viewController setPreferredContentSize:CGSizeMake(960,960)];
It should be added right in the if statement:
if([navigationController isKindOfClass:[UIImagePickerController class]]){
HOW CAN WE COMMIT THIS CHANGE?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13863) CameraPopoverOptions not working properly on Ipad IOS 11
Ams created CB-13863:
Summary: CameraPopoverOptions not working properly on Ipad IOS 11
Key: CB-13863
URL: https://issues.apache.org/jira/browse/CB-13863
Project: Apache Cordova
Issue Type: Bug
Components: cordova-plugin-camera
Environment: Ipad IOS 11
Reporter: Ams
{{CameraPopoverOptions not working properly on Ipad IOS 11. Regardless what you
set the width and height it is always around 200 by 200. Increasing width and
height just moves the popover around but never makes it bigger.}}
{{var popover = new
CameraPopoverOptions(300,300,100,100,Camera.PopoverArrowDirection.ARROW_ANY);
var options = \{ quality: 50, destinationType:
Camera.DestinationType.DATA_URL,sourceType:
Camera.PictureSource.SAVEDPHOTOALBUM, popoverOptions : popover };
navigator.camera.getPicture(onSuccess, onFail, options);}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
