[jira] [Comment Edited] (CB-8401) Android permissions don't merge nicely when maxSdkVersion is set

2017-07-12 Thread Ctibor Laky (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085235#comment-16085235
 ] 

Ctibor Laky edited comment on CB-8401 at 7/13/17 6:05 AM:
--

[~johnvh] How did you fix your issue? I came into same problem. I need solution 
which can be committed to git with project and solved for everyone in a team. 
Thanks


was (Author: luckylooke):
[~johnvh] How did you fix your issue, I came into same problem. I need solution 
which can be committed to git with project and solved for everyone in a team. 
Thanks

> Android permissions don't merge nicely when maxSdkVersion is set
> 
>
> Key: CB-8401
> URL: https://issues.apache.org/jira/browse/CB-8401
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugman
> Environment: Android
>Reporter: Eddy Verbruggen
>
> If two plugins request the same permission they are nicely merged into one 
> line in AndroidManifest.xml.
> However, if one of those two has 'android:maxSdkVersion="18"', both lines 
> show up in the resulting AndroidManifest.xml which is not allowed, so the 
> Android build fails.
> As an example you can create a Cordova CLI project with the core File plugin 
> and SocialSharing (the latter has the maxSdkVersion set):
> cordova create duplicatepermissiontest
> cd duplicatepermissiontest
> cordova platform add android
> cordova plugin add org.apache.cordova.file
> cordova plugin add nl.x-services.plugins.socialsharing
> cordova prepare
> The AndroidManifest.xml now has the duplicate permission.
> I think what you'd want is the broader permission to 'win' this fight, so I'd 
> expect the manifest to contain only ' android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>'.
> Note that I added the maxSdkVersion restriction because according to Google 
> SDK 19+ no longer requires the permission in my case and the permission tends 
> to scare off people using apps with this plugin installed.
> I hope you will consider creating something clever to merge these duplicate 
> permissions.
> This issue was first reported here: 
> https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/295
> Best,
> Eddy



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8401) Android permissions don't merge nicely when maxSdkVersion is set

2017-07-12 Thread Ctibor Laky (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085235#comment-16085235
 ] 

Ctibor Laky commented on CB-8401:
-

[~johnvh] How did you fix your issue, I came into same problem. I need solution 
which can be committed to git with project and solved for everyone in a team. 
Thanks

> Android permissions don't merge nicely when maxSdkVersion is set
> 
>
> Key: CB-8401
> URL: https://issues.apache.org/jira/browse/CB-8401
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugman
> Environment: Android
>Reporter: Eddy Verbruggen
>
> If two plugins request the same permission they are nicely merged into one 
> line in AndroidManifest.xml.
> However, if one of those two has 'android:maxSdkVersion="18"', both lines 
> show up in the resulting AndroidManifest.xml which is not allowed, so the 
> Android build fails.
> As an example you can create a Cordova CLI project with the core File plugin 
> and SocialSharing (the latter has the maxSdkVersion set):
> cordova create duplicatepermissiontest
> cd duplicatepermissiontest
> cordova platform add android
> cordova plugin add org.apache.cordova.file
> cordova plugin add nl.x-services.plugins.socialsharing
> cordova prepare
> The AndroidManifest.xml now has the duplicate permission.
> I think what you'd want is the broader permission to 'win' this fight, so I'd 
> expect the manifest to contain only ' android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>'.
> Note that I added the maxSdkVersion restriction because according to Google 
> SDK 19+ no longer requires the permission in my case and the permission tends 
> to scare off people using apps with this plugin installed.
> I hope you will consider creating something clever to merge these duplicate 
> permissions.
> This issue was first reported here: 
> https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/295
> Best,
> Eddy



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-6026) Orientation preference is ignored on iOS

2017-06-22 Thread Ctibor Laky (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059154#comment-16059154
 ] 

Ctibor Laky commented on CB-6026:
-

Orientation ignored in:
Cordova CLI: 7.0.1 
Ionic Framework Version: 2.3.0
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.1.0
ios-deploy version: 1.9.1 
ios-sim version: 5.0.13 
OS: macOS Sierra
Node Version: v6.9.5
Xcode version: Xcode 8.3.3 Build version 8E3004b


> Orientation preference is ignored on iOS
> 
>
> Key: CB-6026
> URL: https://issues.apache.org/jira/browse/CB-6026
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-ios
>Reporter: Andrew Grieve
>Priority: Minor
>
> [Docs|http://cordova.apache.org/docs/en/edge/config_ref_index.md.html] say 
> that this should work:
> {quote}
>  
> {quote}
> But it doesn't.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12863) Can't install plugins from a branch (cordova@7)

2017-06-21 Thread Ctibor Laky (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057266#comment-16057266
 ] 

Ctibor Laky commented on CB-12863:
--

I have same problem installing it with command "cordova plugin add 
cordova-plugin-wkwebview-engine"

{code:terminal}
cordova plugin add cordova-plugin-wkwebview-engine
Error: Failed to fetch plugin 
git+https://github.com/ionic-team/cordova-plugin-wkwebview-engine.git via 
registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Failed to get absolute path to installed module
{code}



> Can't install plugins from a branch (cordova@7)
> ---
>
> Key: CB-12863
> URL: https://issues.apache.org/jira/browse/CB-12863
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-fetch
> Environment: cordova-cli@7.0.1
> node@4.6.0
>Reporter: Shazron Abdullah
>Assignee: Audrey So
>  Labels: reproduced, triage
>
> 1st try:
> {code}
> $ cordova plugin add 
> https://github.com/apache/cordova-plugins.git\#wkwebview-engine-localhost
> Installing "cordova-labs-wkwebview-engine-localhost" for ios
> Failed to install 'cordova-labs-wkwebview-engine-localhost': CordovaError: 
> Failed to fetch plugin 
> https://git-wip-us.apache.org/repos/asf/cordova-plugins.git#local-webserver 
> via registry.
> Probably this is either a connection problem, or plugin spec is incorrect.
> Check your connection and plugin name/version/URL.
> Error: npm: Command failed with exit code 254 Error output:
> npm WARN package.json helloworld@1.0.0 No repository field.
> npm WARN package.json helloworld@1.0.0 No README data
> npm ERR! not a package 
> /var/folders/40/pyxnqlcj6bn_43qrjp3p0xtwgp/T/npm-28533-ff14b1ee/git-wip-us.apache.org/repos/asf/cordova-plugins.git/local-webserver
> npm ERR! Darwin 16.7.0
> npm ERR! argv "/Users/shazron/.nvm/versions/node/v4.6.0/bin/node" 
> "/Users/shazron/.nvm/versions/node/v4.6.0/bin/npm" "install" 
> "https://git-wip-us.apache.org/repos/asf/cordova-plugins.git#local-webserver"; 
> "--save"
> npm ERR! node v4.6.0
> npm ERR! npm  v2.15.9
> npm ERR! path 
> /var/folders/40/pyxnqlcj6bn_43qrjp3p0xtwgp/T/npm-28533-ff14b1ee/unpack-968d75f9eab2/package.json
> npm ERR! code ENOENT
> npm ERR! errno -2
> npm ERR! syscall open
> npm ERR! enoent ENOENT: no such file or directory, open 
> '/var/folders/40/pyxnqlcj6bn_43qrjp3p0xtwgp/T/npm-28533-ff14b1ee/unpack-968d75f9eab2/package.json'
> npm ERR! enoent This is most likely not a problem with npm itself
> npm ERR! enoent and is related to npm not being able to find a file.
> npm ERR! enoent
> npm ERR! Please include the following file with any support request:
> npm ERR! /Users/shazron/Desktop/gtm/node_modules/npm-debug.log
> at 
> /Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:205:33
> at _rejected 
> (/Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:864:24)
> at 
> /Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:890:30
> at Promise.when 
> (/Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:1142:31)
> at Promise.promise.promiseDispatch 
> (/Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:808:41)
> at 
> /Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:624:44
> at runSingle 
> (/Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:137:13)
> at flush 
> (/Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:125:13)
> at nextTickCallbackWith0Args (node.js:420:9)
> at process._tickCallback (node.js:349:13)
> Error: Failed to fetch plugin 
> https://git-wip-us.apache.org/repos/asf/cordova-plugins.git#local-webserver 
> via registry.
> Probably this is either a connection problem, or plugin spec is incorrect.
> Check your connection and plugin name/version/URL.
> Error: npm: Command failed with exit code 254 Error output:
> npm WARN package.json helloworld@1.0.0 No repository field.
> npm WARN package.json helloworld@1.0.0 No README data
> npm ERR! not a package 
> /var/folders/40/pyxnqlcj6bn_43qrjp3p0xtwgp/T/npm-28533-ff14b1ee/git-wip-us.apache.org/repos/asf/cordova-plugins.git/local-webs

[jira] [Comment Edited] (CB-12863) Can't install plugins from a branch (cordova@7)

2017-06-21 Thread Ctibor Laky (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057266#comment-16057266
 ] 

Ctibor Laky edited comment on CB-12863 at 6/21/17 9:55 AM:
---

I have same problem installing it with command "cordova plugin add 
cordova-plugin-wkwebview-engine"

{code:none}
cordova plugin add cordova-plugin-wkwebview-engine
Error: Failed to fetch plugin 
git+https://github.com/ionic-team/cordova-plugin-wkwebview-engine.git via 
registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Failed to get absolute path to installed module
{code}




was (Author: luckylooke):
I have same problem installing it with command "cordova plugin add 
cordova-plugin-wkwebview-engine"

{code:terminal}
cordova plugin add cordova-plugin-wkwebview-engine
Error: Failed to fetch plugin 
git+https://github.com/ionic-team/cordova-plugin-wkwebview-engine.git via 
registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Failed to get absolute path to installed module
{code}



> Can't install plugins from a branch (cordova@7)
> ---
>
> Key: CB-12863
> URL: https://issues.apache.org/jira/browse/CB-12863
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-fetch
> Environment: cordova-cli@7.0.1
> node@4.6.0
>Reporter: Shazron Abdullah
>Assignee: Audrey So
>  Labels: reproduced, triage
>
> 1st try:
> {code}
> $ cordova plugin add 
> https://github.com/apache/cordova-plugins.git\#wkwebview-engine-localhost
> Installing "cordova-labs-wkwebview-engine-localhost" for ios
> Failed to install 'cordova-labs-wkwebview-engine-localhost': CordovaError: 
> Failed to fetch plugin 
> https://git-wip-us.apache.org/repos/asf/cordova-plugins.git#local-webserver 
> via registry.
> Probably this is either a connection problem, or plugin spec is incorrect.
> Check your connection and plugin name/version/URL.
> Error: npm: Command failed with exit code 254 Error output:
> npm WARN package.json helloworld@1.0.0 No repository field.
> npm WARN package.json helloworld@1.0.0 No README data
> npm ERR! not a package 
> /var/folders/40/pyxnqlcj6bn_43qrjp3p0xtwgp/T/npm-28533-ff14b1ee/git-wip-us.apache.org/repos/asf/cordova-plugins.git/local-webserver
> npm ERR! Darwin 16.7.0
> npm ERR! argv "/Users/shazron/.nvm/versions/node/v4.6.0/bin/node" 
> "/Users/shazron/.nvm/versions/node/v4.6.0/bin/npm" "install" 
> "https://git-wip-us.apache.org/repos/asf/cordova-plugins.git#local-webserver"; 
> "--save"
> npm ERR! node v4.6.0
> npm ERR! npm  v2.15.9
> npm ERR! path 
> /var/folders/40/pyxnqlcj6bn_43qrjp3p0xtwgp/T/npm-28533-ff14b1ee/unpack-968d75f9eab2/package.json
> npm ERR! code ENOENT
> npm ERR! errno -2
> npm ERR! syscall open
> npm ERR! enoent ENOENT: no such file or directory, open 
> '/var/folders/40/pyxnqlcj6bn_43qrjp3p0xtwgp/T/npm-28533-ff14b1ee/unpack-968d75f9eab2/package.json'
> npm ERR! enoent This is most likely not a problem with npm itself
> npm ERR! enoent and is related to npm not being able to find a file.
> npm ERR! enoent
> npm ERR! Please include the following file with any support request:
> npm ERR! /Users/shazron/Desktop/gtm/node_modules/npm-debug.log
> at 
> /Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:205:33
> at _rejected 
> (/Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:864:24)
> at 
> /Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:890:30
> at Promise.when 
> (/Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:1142:31)
> at Promise.promise.promiseDispatch 
> (/Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:808:41)
> at 
> /Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:624:44
> at runSingle 
> (/Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:137:13)
> at flush 
> (/Users/shazron/.nvm/versions/node/v4.6.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/cordova-fetch/node_modules/q/q.js:125:13)
> at nextTickCallbackWith0Args (node.js:420:9)
> at process._tickCallback (node.js:349:13)
> Error: Failed to fetch plugin 
> https://git-wip-us.a