[jira] [Commented] (CB-14170) Parsing /platforms/android/res/xml/config.xml failed

2018-09-17 Thread Dave Alden (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617395#comment-16617395
 ] 

Dave Alden commented on CB-14170:
-

It's just I'm seeing this bug being reported multiple times against my various 
plugins, for example:  
[here|https://github.com/dpa99c/phonegap-launch-navigator/issues/203], 
[here|https://github.com/dpa99c/cordova-custom-config/issues/146], 
[here|https://forum.ionicframework.com/t/cordova-plugins-diagnostic-compatible-with-cordova-android-7-1-1/140683]

> Parsing /platforms/android/res/xml/config.xml failed
> 
>
> Key: CB-14170
> URL: https://issues.apache.org/jira/browse/CB-14170
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: *local packages:*
>     Cordova Platforms : android 7.1.0 ios 4.5.4
>     Cordova Plugins: none
> *System:*
>     Android SDK Tools : 26.1.1
>     ios-deploy        : 1.9.2 
>     ios-sim           : 6.1.2 
>     Node              : v10.4.1
>     npm               : 6.1.0 
>     OS                : macOS High Sierra
>     Xcode             : Xcode 9.4.1 Build version 9F2000 
> *Environment Variables:* 
>     ANDROID_HOME : /Users/alejandro/Library/Android/sdk
>Reporter: Alejandro
>Priority: Major
>
>  
> I get the following error when running cordova run android. Furthermore, the 
> command works with cordova-android 6.4.0 and I am running without any plugin 
> to isolate the issue.
> {code:java}
> Parsing 
> /Users/alejandro/Developer/example/platforms/android/res/xml/config.xml failed
> (node:14144) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or 
> directory, open 
> '/Users/alejandro/Developer/example/platforms/android/res/xml/config.xml'
>     at Object.fs.openSync (fs.js:579:3)
>     at Object.fs.readFileSync (fs.js:485:33)
>     at Object.parseElementtreeSync 
> (/Users/alejandro/Developer/example/platforms/android/cordova/node_modules/cordova-common/src/util/xml-helpers.js:180:27)
>     at new ConfigParser 
> (/Users/alejandro/Developer/example/platforms/android/cordova/node_modules/cordova-common/src/ConfigParser/ConfigParser.js:30:24)
>     at updateConfigFilesFrom 
> (/Users/alejandro/Developer/example/platforms/android/cordova/lib/prepare.js:106:18)
>     at Api.module.exports.prepare 
> (/Users/alejandro/Developer/example/platforms/android/cordova/lib/prepare.js:42:20)
>     at Api.prepare 
> (/Users/alejandro/Developer/example/platforms/android/cordova/Api.js:192:45)
>     at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/prepare.js:106:36
>     at _fulfilled 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
>     at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14170) Parsing /platforms/android/res/xml/config.xml failed

2018-09-17 Thread Dave Alden (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617392#comment-16617392
 ] 

Dave Alden commented on CB-14170:
-

[~jcesarmobile] is this fixed by  
[#490|https://github.com/apache/cordova-android/pull/490]?

> Parsing /platforms/android/res/xml/config.xml failed
> 
>
> Key: CB-14170
> URL: https://issues.apache.org/jira/browse/CB-14170
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: *local packages:*
>     Cordova Platforms : android 7.1.0 ios 4.5.4
>     Cordova Plugins: none
> *System:*
>     Android SDK Tools : 26.1.1
>     ios-deploy        : 1.9.2 
>     ios-sim           : 6.1.2 
>     Node              : v10.4.1
>     npm               : 6.1.0 
>     OS                : macOS High Sierra
>     Xcode             : Xcode 9.4.1 Build version 9F2000 
> *Environment Variables:* 
>     ANDROID_HOME : /Users/alejandro/Library/Android/sdk
>Reporter: Alejandro
>Priority: Major
>
>  
> I get the following error when running cordova run android. Furthermore, the 
> command works with cordova-android 6.4.0 and I am running without any plugin 
> to isolate the issue.
> {code:java}
> Parsing 
> /Users/alejandro/Developer/example/platforms/android/res/xml/config.xml failed
> (node:14144) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or 
> directory, open 
> '/Users/alejandro/Developer/example/platforms/android/res/xml/config.xml'
>     at Object.fs.openSync (fs.js:579:3)
>     at Object.fs.readFileSync (fs.js:485:33)
>     at Object.parseElementtreeSync 
> (/Users/alejandro/Developer/example/platforms/android/cordova/node_modules/cordova-common/src/util/xml-helpers.js:180:27)
>     at new ConfigParser 
> (/Users/alejandro/Developer/example/platforms/android/cordova/node_modules/cordova-common/src/ConfigParser/ConfigParser.js:30:24)
>     at updateConfigFilesFrom 
> (/Users/alejandro/Developer/example/platforms/android/cordova/lib/prepare.js:106:18)
>     at Api.module.exports.prepare 
> (/Users/alejandro/Developer/example/platforms/android/cordova/lib/prepare.js:42:20)
>     at Api.prepare 
> (/Users/alejandro/Developer/example/platforms/android/cordova/Api.js:192:45)
>     at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/prepare.js:106:36
>     at _fulfilled 
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
>     at 
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-14132) [cordova-plugin-network-information] connection.type is stale on Android 7+ if network connectivity state changes while device is in Doze mode

2018-06-13 Thread Dave Alden (JIRA)
Dave Alden created CB-14132:
---

 Summary: [cordova-plugin-network-information] connection.type is 
stale on Android 7+ if network connectivity state changes while device is in 
Doze mode
 Key: CB-14132
 URL: https://issues.apache.org/jira/browse/CB-14132
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-plugin-network-information
Affects Versions: 2.0.0
Reporter: Dave Alden
 Attachments: connection_type.png

The {{navigator.connection.type}} plugin property [is 
set|https://github.com/apache/cordova-plugin-network-information/blob/2.0.1/www/network.js#L60]
 when a change in device network connectivity triggers a native callback.
 On Android, this [native 
callback|https://github.com/apache/cordova-plugin-network-information/blob/master/src/android/NetworkManager.java#L108]
 is via a BroadcastReceiver, triggered by the {{CONNECTIVITY_ACTION}} broadcast.
 This [sends the result back to the JS 
layer|https://github.com/apache/cordova-plugin-network-information/blob/master/src/android/NetworkManager.java#L233]
 which [triggers the JS plugin 
handler|https://github.com/apache/cordova-plugin-network-information/blob/2.0.1/www/network.js#L59]
 to set the property.

However, Android 7 introduces ["background 
optimization"|https://developer.android.com/topic/performance/background-optimization]
 limitations and Android 8 introduces further [broadcast 
limitations|https://developer.android.com/about/versions/oreo/background#broadcasts].
 The consequence is that the plugin's broadcast receiver is not guaranteed to 
be invoked if the network state changes while the device is in Doze mode.
 And therefore the {{navigator.connection.type}} property state can be stale 
with respect to the actual network connectivity state.

This may be the root cause of CB-13585 and CB-12035.

The solution to this issue on Android is probably to do the same as the [iOS 
implementation|https://github.com/apache/cordova-plugin-network-information/blob/2.0.1/src/ios/CDVConnection.m#L143]:
 on resuming the app from the background, trigger an update of the 
{{navigator.connection.type}} property.
 On Android, this should mitigate the fact that the broadcast receiver may not 
have been called while the app was in the background.

Note: my current workaround solution to this issue to is call the plugin's 
[getInfo()|https://github.com/apache/cordova-plugin-network-information/blob/2.0.1/www/network.js#L47]
 function when my app resumes from the background.
 Although this function is not in the API documentation, calling it invokes a 
[native 
method|https://github.com/apache/cordova-plugin-network-information/blob/2.0.1/src/android/NetworkManager.java#L130]
 to retrieve the current device connectivity state asyncronously via a 
callback. I then use the callback result to manually update the 
{{navigator.connection.type}} property, making sure it's fresh when the app is 
resumed from the background.
 Since {{getInfo()}} is querying the native {{ConnectivityManager}} directly, 
it's guaranteed to get the correct network state from the device, as the 
following screenshot illustrates:

!connection_type.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Reopened] (CB-13791) Add Android support for a footer close button.

2018-01-22 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden reopened CB-13791:
-

As indicated above, this was prematurely closed because the PR is still open 
and has yet to be reviewed/merged/closed:

https://github.com/apache/cordova-plugin-inappbrowser/pull/258

> Add Android support for a footer close button.
> --
>
> Key: CB-13791
> URL: https://issues.apache.org/jira/browse/CB-13791
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: Android
>Reporter: Dave Alden
>Priority: Minor
>  Labels: features, newbie
>
> Extending the work done in [PR 
> #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under 
> CB-13409, this adds support to Android for a footer close button similar to 
> the "Done" button on iOS.
> The following options are added for Android:
>  * *footer* - set to "yes" to show a close button in the footer similar to 
> the iOS "Done" button.
>  The close button will appear the same as for the header hence use 
> _closebuttoncaption_ and _closebuttoncolor_ to set its properties.
>  * *footercolor* - set to a valid hex color string, for example #00ff00 or 
> #CC00ff00 (#aarrggbb) , and it will change the footer color from default. 
> Only has effect if user has _footer_ set to "yes".
> Here are some example screenshots with the relevant options:
> _location=yes,footer=yes_
>  
> !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300!
> _location=no,footer=yes_
>  
> !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300!
> _location=yes,footer=yes,closebuttoncaption=Done_
>  
> !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300!
> _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_
>  
> !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300!
> _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_
>  
> !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300!
> _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_
>  
> !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300!
> _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_
>  
> !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13791) Add Android support for a footer close button.

2018-01-18 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331070#comment-16331070
 ] 

Dave Alden commented on CB-13791:
-

[~bowserj] How is this Fixed/Resolved if the PR is still open and not merged?

[https://github.com/apache/cordova-plugin-inappbrowser/pull/258]

> Add Android support for a footer close button.
> --
>
> Key: CB-13791
> URL: https://issues.apache.org/jira/browse/CB-13791
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: Android
>Reporter: Dave Alden
>Priority: Minor
>  Labels: features, newbie
>
> Extending the work done in [PR 
> #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under 
> CB-13409, this adds support to Android for a footer close button similar to 
> the "Done" button on iOS.
> The following options are added for Android:
>  * *footer* - set to "yes" to show a close button in the footer similar to 
> the iOS "Done" button.
>  The close button will appear the same as for the header hence use 
> _closebuttoncaption_ and _closebuttoncolor_ to set its properties.
>  * *footercolor* - set to a valid hex color string, for example #00ff00 or 
> #CC00ff00 (#aarrggbb) , and it will change the footer color from default. 
> Only has effect if user has _footer_ set to "yes".
> Here are some example screenshots with the relevant options:
> _location=yes,footer=yes_
>  
> !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300!
> _location=no,footer=yes_
>  
> !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300!
> _location=yes,footer=yes,closebuttoncaption=Done_
>  
> !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300!
> _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_
>  
> !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300!
> _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_
>  
> !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300!
> _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_
>  
> !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300!
> _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_
>  
> !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13791) Add Android support for a footer close button.

2018-01-17 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13791:

External issue URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/258

> Add Android support for a footer close button.
> --
>
> Key: CB-13791
> URL: https://issues.apache.org/jira/browse/CB-13791
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: Android
>Reporter: Dave Alden
>Priority: Minor
>  Labels: features, newbie
>
> Extending the work done in [PR 
> #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under 
> CB-13409, this adds support to Android for a footer close button similar to 
> the "Done" button on iOS.
> The following options are added for Android:
>  * *footer* - set to "yes" to show a close button in the footer similar to 
> the iOS "Done" button.
>  The close button will appear the same as for the header hence use 
> _closebuttoncaption_ and _closebuttoncolor_ to set its properties.
>  * *footercolor* - set to a valid hex color string, for example #00ff00 or 
> #CC00ff00 (#aarrggbb) , and it will change the footer color from default. 
> Only has effect if user has _footer_ set to "yes".
> Here are some example screenshots with the relevant options:
> _location=yes,footer=yes_
>  
> !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300!
> _location=no,footer=yes_
>  
> !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300!
> _location=yes,footer=yes,closebuttoncaption=Done_
>  
> !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300!
> _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_
>  
> !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300!
> _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_
>  
> !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300!
> _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_
>  
> !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300!
> _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_
>  
> !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13791) Add Android support for a footer close button.

2018-01-17 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13791:

Description: 
Extending the work done in [PR 
#246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under 
CB-13409, this adds support to Android for a footer close button similar to the 
"Done" button on iOS.

The following options are added for Android:
 * *footer* - set to "yes" to show a close button in the footer similar to the 
iOS "Done" button.
 The close button will appear the same as for the header hence use 
_closebuttoncaption_ and _closebuttoncolor_ to set its properties.
 * *footercolor* - set to a valid hex color string, for example #00ff00 or 
#CC00ff00 (#aarrggbb) , and it will change the footer color from default. Only 
has effect if user has _footer_ set to "yes".

Here are some example screenshots with the relevant options:

_location=yes,footer=yes_
 
!https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300!

_location=no,footer=yes_
 
!https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300!

_location=yes,footer=yes,closebuttoncaption=Done_
 
!https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300!

_location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_
 
!https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300!

_location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_
 
!https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300!

_location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_
 
!https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300!

_location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_
 
!https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300!

  was:
Extending the work done in [PR 
#246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under 
CB-13409, this adds support to Android for a footer close button similar to the 
"Done" button one iOS.

The following options are added for Android:

* *footer* - set to "yes" to show a close button in the footer similar to the 
iOS "Done" button. 
The close button will appear the same as for the header hence use 
_closebuttoncaption_ and _closebuttoncolor_ to set its properties.
* *footercolor* - set to a valid hex color string, for example #00ff00 or 
#CC00ff00 (#aarrggbb) , and it will change the footer color from default. Only 
has effect if user has _footer_ set to "yes".

Here are some example screenshots with the relevant options:

_location=yes,footer=yes_
!https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300!
 

_location=no,footer=yes_
!https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300!

_location=yes,footer=yes,closebuttoncaption=Done_
!https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300!

_location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_
!https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300!

_location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_
!https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300!

_location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_
!https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300!

_location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_
!https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300!


> Add Android support for a footer close button.
> --
>
> Key: CB-13791
> URL: https://issues.apache.org/jira/browse/CB-13791
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: Android
>Reporter: Dave Alden
>Priority: Minor
>  Labels: features, newbie
>
> Extending the work done in [PR 
> #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under 
> CB-13409, this adds support to Android for a footer close button similar to 
> the "Done" button on iOS.
> The following options are added for Android:
>  * *footer* - set to "yes" to show a close button in the footer similar to 
> the

[jira] [Created] (CB-13791) Add Android support for a footer close button.

2018-01-17 Thread Dave Alden (JIRA)
Dave Alden created CB-13791:
---

 Summary: Add Android support for a footer close button.
 Key: CB-13791
 URL: https://issues.apache.org/jira/browse/CB-13791
 Project: Apache Cordova
  Issue Type: Improvement
  Components: cordova-plugin-inappbrowser
 Environment: Android
Reporter: Dave Alden


Extending the work done in [PR 
#246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under 
CB-13409, this adds support to Android for a footer close button similar to the 
"Done" button one iOS.

The following options are added for Android:

* *footer* - set to "yes" to show a close button in the footer similar to the 
iOS "Done" button. 
The close button will appear the same as for the header hence use 
_closebuttoncaption_ and _closebuttoncolor_ to set its properties.
* *footercolor* - set to a valid hex color string, for example #00ff00 or 
#CC00ff00 (#aarrggbb) , and it will change the footer color from default. Only 
has effect if user has _footer_ set to "yes".

Here are some example screenshots with the relevant options:

_location=yes,footer=yes_
!https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300!
 

_location=no,footer=yes_
!https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300!

_location=yes,footer=yes,closebuttoncaption=Done_
!https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300!

_location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_
!https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300!

_location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_
!https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300!

_location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_
!https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300!

_location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_
!https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13643) Cannot build: Cannot write /res/xml/config.xml

2018-01-08 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317072#comment-16317072
 ] 

Dave Alden commented on CB-13643:
-

[~Sujan12], [~jcesarmobile] just so I've got this straight: does this mean 
every plugin needs to update its  block that defines the  
for Android? 

i.e. should this:

{code:xml}





{code}

become this:

{code:xml}





{code}

???

> Cannot build: Cannot write /res/xml/config.xml
> --
>
> Key: CB-13643
> URL: https://issues.apache.org/jira/browse/CB-13643
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: 7.0.0, 6.5.0
> Environment: Darwin Kernel Version 16.7.0 (osx)
>Reporter: Marcos Almeida Jr
>Assignee: Joe Bowser
>Priority: Blocker
>  Labels: build
>
> Same project compiles with no problem with cordova-android@6.1.0
> *When I set it to build using cordova-android@7.0.0 i get the following 
> error:*
> cp: copyFileSync: could not write to dest file 
> (code=ENOENT):/Users/dtap/tfsagent/_work/r1/a/zip/TvGlobo.Samara.Mobile/platforms/android/res/xml/config.xml
> Seems that the res folder is not being generated. 
> {noformat}
> 2017-12-06T20:12:22.7306300Z ##[section]Starting: Ionic Build Android
> 2017-12-06T20:12:22.7357040Z 
> ==
> 2017-12-06T20:12:22.7367170Z Task : Ionic Command
> 2017-12-06T20:12:22.7379360Z Description  : Run an Ionic CLI command
> 2017-12-06T20:12:22.7390120Z Version  : 1.3.11
> 2017-12-06T20:12:22.7400860Z Author   : Microsoft Corporation
> 2017-12-06T20:12:22.7411880Z Help : [More 
> Information](http://go.microsoft.com/fwlink/?LinkID=692057)
> 2017-12-06T20:12:22.7423510Z 
> ==
> 2017-12-06T20:12:24.1904470Z Module cache at 
> /Users/dtap/.taco_home/node_modules
> 2017-12-06T20:12:24.7130830Z cordova@6.5.0 already installed.
> 2017-12-06T20:12:24.7148980Z Cordova Module Path: 
> /Users/dtap/.taco_home/node_modules/cordova/6.5.0/node_modules/cordova
> 2017-12-06T20:12:24.7166780Z Module cache at 
> /Users/dtap/.taco_home/node_modules
> 2017-12-06T20:12:25.9630700Z ionic@3.12.0 already installed.
> 2017-12-06T20:12:25.9648550Z Ionic Module Path: 
> /Users/dtap/.taco_home/node_modules/ionic/3.12.0/node_modules/ionic
> 2017-12-06T20:12:28.7001080Z [INFO] Running app-scripts build: --prod 
> --platform android --target cordova
> 2017-12-06T20:12:28.7023500Z
> 2017-12-06T20:12:28.7041760Z [18:12:28]  build prod started ... 
> 2017-12-06T20:12:28.7796910Z [18:12:28]  clean started ... 
> 2017-12-06T20:12:28.7814780Z [18:12:28]  clean finished in 1 ms 
> 2017-12-06T20:12:28.7833010Z [18:12:28]  copy started ... 
> 2017-12-06T20:12:28.8980020Z [18:12:28]  deeplinks started ... 
> 2017-12-06T20:12:29.1374580Z [18:12:29]  deeplinks finished in 240 ms 
> 2017-12-06T20:12:29.1397430Z [18:12:29]  ngc started ... 
> 2017-12-06T20:12:38.1104050Z [18:12:38]  ngc finished in 8.97 s 
> 2017-12-06T20:12:38.1121910Z [18:12:38]  preprocess started ... 
> 2017-12-06T20:12:38.1139910Z [18:12:38]  preprocess finished in 1 ms 
> 2017-12-06T20:12:38.1158400Z [18:12:38]  webpack started ... 
> 2017-12-06T20:12:39.3028600Z [18:12:39]  copy finished in 10.52 s 
> 2017-12-06T20:14:02.4833200Z [18:14:02]  webpack finished in 84.37 s 
> 2017-12-06T20:14:02.4851040Z [18:14:02]  uglify started ... 
> 2017-12-06T20:14:02.5017620Z [18:14:02]  sass started ... 
> 2017-12-06T20:14:07.7085830Z [18:14:07]  sass finished in 5.21 s 
> 2017-12-06T20:14:07.7103690Z [18:14:07]  cleancss started ... 
> 2017-12-06T20:14:10.4118170Z [18:14:10]  cleancss finished in 2.70 s 
> 2017-12-06T20:14:29.9190970Z [18:14:29]  uglify finished in 27.43 s 
> 2017-12-06T20:14:29.9208780Z [18:14:29]  postprocess started ... 
> 2017-12-06T20:14:29.9456540Z [18:14:29]  postprocess finished in 26 ms 
> 2017-12-06T20:14:29.9474240Z [18:14:29]  lint started ... 
> 2017-12-06T20:14:29.9555930Z [18:14:29]  build prod finished in 121.25 s 
> 2017-12-06T20:14:29.9587670Z > ionic cordova prepare android
> 2017-12-06T20:14:30.0773410Z > cordova prepare android
> 2017-12-06T20:14:30.7694920Z Android Studio project detected
> 2017-12-06T20:14:31.2500880Z 
> 2017-12-06T20:14:31.2524240Z > cordova build android --release
> 2017-12-06T20:14:32.3066820Z ✖ Running command - failed!
> 2017-12-06T20:14:32.3211570Z [ERROR] An error occurred while running cordova 
> build android --release (exit code 1):
> 2017-12-06T20:14:32.3228570Z 
> 2017-12-06T20:14:32.3244550Z 
> 2017-12-06T20:14:32.3259840Z android: copy resource files
> 2017-12-06T20:14:32.3275410Z

[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-09-27 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182638#comment-16182638
 ] 

Dave Alden commented on CB-7179:


[~shazron] Here's the pull request. 
It brings your 2014 wkwebview branch up-to-date with master with respect to 
other platforms and of course finishes off the implementation of iOS to use 
WKWebView.

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-19 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171932#comment-16171932
 ] 

Dave Alden commented on CB-13273:
-

Yes Mike, the rotation issue has nothing to do with cordova-plugin-statusbar: 
this is occurring in the attached test project which doesn't include that 
plugin. As noted, it only happens when using UIWebView. With WKWebView (via 
cordova-plugin-wkwebview-engine), the issue does not manifest itself.

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X - 
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at 
> 09.20.48.png, Simulator Screen Shot - iPhone X - 2017-09-19 at 11.29.00.png, 
> webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-19 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171591#comment-16171591
 ] 

Dave Alden edited comment on CB-13273 at 9/19/17 12:31 PM:
---

When using UIWebView, rotating the iPhone X Simulator from portrait > landscape 
> portrait causes the safe-area-inset not to be re-applied, causing the content 
to be obscured by the notch again. This doesn't happen when using WKWebView via 
cordova-plugin-wkwebview-engine.


was (Author: dpa99c):
When using UIWebView, rotating the iPhone X Simulator from portrait > landscape 
> portrait causes the safe-area-inset not to be re-applied, causing the content 
to be obscured by the notch again. This doesn't happen when using WKWebView via 
`cordova-plugin-wkwebview-engine'.

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X - 
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at 
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-19 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171591#comment-16171591
 ] 

Dave Alden edited comment on CB-13273 at 9/19/17 12:30 PM:
---

When using UIWebView, rotating the iPhone X Simulator from portrait > landscape 
> portrait causes the safe-area-inset not to be re-applied, causing the content 
to be obscured by the notch again. This doesn't happen when using WKWebView via 
`cordova-plugin-wkwebview-engine'.


was (Author: dpa99c):
Rotating the iPhone X Simulator from portrait > landscape > portrait causes the 
safe-area-inset not to be re-applied, causing the content to be obscured by the 
notch again

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X - 
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at 
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-19 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171591#comment-16171591
 ] 

Dave Alden commented on CB-13273:
-

Rotating the iPhone X Simulator from portrait > landscape > portrait causes the 
safe-area-inset not to be re-applied, causing the content to be obscured by the 
notch again

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X - 
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at 
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-15 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168003#comment-16168003
 ] 

Dave Alden commented on CB-13273:
-

Thanks Mike, good to know: I'm not using it so hadn't hit that problem. Will 
update my SO post with your PR.

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X - 
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at 
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-15 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167977#comment-16167977
 ] 

Dave Alden commented on CB-13273:
-

I've used safe-area-insets, but just applied with CSS (no forking required):
{code:html}
body{
padding-top: constant(safe-area-inset-top);
}
{code}

FYI I also needed to do so for footer toolbar buttons in my app to avoid them 
being overlapped by the virtual Home button on iPhone X (couldn't apply this to 
 as footer is absolutely positioned):

{code:html}
.toolbar-footer{
margin-bottom: constant(safe-area-inset-bottom);
}
{code}


> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X - 
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at 
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-15 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167554#comment-16167554
 ] 

Dave Alden commented on CB-13273:
-

If you land up here looking for a solution, see my stackoverflow answer: 
https://stackoverflow.com/a/46232813/777265

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X - 
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at 
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Resolved] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-15 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden resolved CB-13273.
-
Resolution: Not A Bug

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X - 
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at 
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-15 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13273:

Attachment: webview-test.zip

Updated project with LaunchStoryboard config and images attached
[^webview-test.zip]

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X - 
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at 
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-15 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13273:

Attachment: (was: webview-test.zip)

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X - 
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at 
> 09.20.48.png
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-15 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167526#comment-16167526
 ] 

Dave Alden edited comment on CB-13273 at 9/15/17 8:29 AM:
--

Thanks Darryl, I've tried this out with a LaunchStoryboard using 
cordova-plugin-splashscreen with the following in config.xml and, in 
combination with viewport-fit and safe-area-inset-*, it resolves the issue.

{code:xml}








{code}

[^Simulator Screen Shot - iPhone X - 2017-09-15 at 09.20.48.png]




was (Author: dpa99c):
Thanks Darryl, I've tried this out with a LaunchStoryboard using 
cordova-plugin-splashscreen with the following in config.xml and, in 
combination with viewport-fit and safe-area-inset-*, it resolves the issue.

{code:xml}








{code}

[^Simulator Screen Shot - iPhone X - 2017-09-15 at 09.20.48.png]



> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X - 
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at 
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-15 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167526#comment-16167526
 ] 

Dave Alden edited comment on CB-13273 at 9/15/17 8:28 AM:
--

Thanks Darryl, I've tried this out with a LaunchStoryboard using 
cordova-plugin-splashscreen with the following in config.xml and, in 
combination with viewport-fit and safe-area-inset-*, it resolves the issue.

{code:xml}








{code}

[^Simulator Screen Shot - iPhone X - 2017-09-15 at 09.20.48.png]




was (Author: dpa99c):
Thanks Darryl, I've tried this out with a LaunchStoryboard using 
cordova-plugin-splashscreen with the following in config.xml and, in 
combination with viewport-fit and safe-area-inset-*, it resolves the issue.

{code:xml}








{code}



> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X - 
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at 
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-15 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167526#comment-16167526
 ] 

Dave Alden commented on CB-13273:
-

Thanks Darryl, I've tried this out with a LaunchStoryboard using 
cordova-plugin-splashscreen with the following in config.xml and, in 
combination with viewport-fit and safe-area-inset-*, it resolves the issue.

{code:xml}








{code}



> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X - 
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at 
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-15 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13273:

Attachment: Simulator Screen Shot - iPhone X - 2017-09-15 at 09.20.48.png

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X - 
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at 
> 09.20.48.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-14 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13273:

Description: 
New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
Simulator does not size correctly, leaving black areas above and below the app 
content and white bars between the black areas and app content.

Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars go 
away, but the black areas remain:

!https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!


Setting 
{code:html}viewport-fit=cover{code}
fixes the white bar issue with UIWebView, as outlined here 
[http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], but 
the black areas remain:

[^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]

Attached Cordova project illustrates the issue.

  was:
New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
Simulator does not size correctly, leaving black areas above and below the app 
content and white bars between the black areas and app content.

Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars go 
away, but the black areas remain:

!https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!


Setting 
{code:html}viewport-fit=cover{code}
fixes the white bar issue with UIWebView, as outlined here 
[http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], but 
the black areas remain:

[^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]

Probably need some some tweaking of Launch Images in cordova-ios to get rid of 
those black areas.

Attached Cordova project illustrates the issue.


> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: Simulator Screen Shot - iPhone X - 2017-09-14 at 
> 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-14 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13273:

Description: 
New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
Simulator does not size correctly, leaving black areas above and below the app 
content and white bars between the black areas and app content.

Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars go 
away, but the black areas remain:

!https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!


Setting 
{code:html}viewport-fit=cover{code}
fixes the white bar issue with UIWebView, as outlined here 
[http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], but 
the black areas remain:

[^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]

Probably need some some tweaking of Launch Images in cordova-ios to get rid of 
those black areas.

Attached Cordova project illustrates the issue.

  was:
New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
Simulator does not size correctly, leaving black areas above and below the app 
content and white bars between the black areas and app content.

Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars go 
away, but the black areas remain:

!https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!


Setting 
{code:html}viewport-fit=cover{code}
fixes the white bar issue with UIWebView, as outlined here 
[http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], but 
the black areas remain:

[^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]


Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 Plus 
Simulators.

Attached Cordova project illustrates the issue.




> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: Simulator Screen Shot - iPhone X - 2017-09-14 at 
> 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Probably need some some tweaking of Launch Images in cordova-ios to get rid 
> of those black areas.
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Issue Comment Deleted] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-14 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13273:

Comment: was deleted

(was: However, the black bars still remain, so probably still need some some 
tweaking of Launch Images in cordova-ios to get rid of those)

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: Simulator Screen Shot - iPhone X - 2017-09-14 at 
> 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 
> Plus Simulators.
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Issue Comment Deleted] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-14 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13273:

Comment: was deleted

(was: Setting 
{code:html}viewport-fit=cover{code}
fixes the white bar issue with UIWebView, as outlined here 
[http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/]

[^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
)

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: Simulator Screen Shot - iPhone X - 2017-09-14 at 
> 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 
> Plus Simulators.
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-14 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13273:

Description: 
New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
Simulator does not size correctly, leaving black areas above and below the app 
content and white bars between the black areas and app content.

Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars go 
away, but the black areas remain:

!https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!


Setting 
{code:html}viewport-fit=cover{code}
fixes the white bar issue with UIWebView, as outlined here 
[http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], but 
the black areas remain:

[^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]


Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 Plus 
Simulators.

Attached Cordova project illustrates the issue.



  was:
New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
Simulator does not size correctly, leaving black areas above and below the app 
content and white bars between the black areas and app content.

Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars go 
away, but the black areas remain.

Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 Plus 
Simulators.

Attached Cordova project illustrates the issue.

See screenshots:

!https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: Simulator Screen Shot - iPhone X - 2017-09-14 at 
> 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting 
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here 
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/], 
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 
> Plus Simulators.
> Attached Cordova project illustrates the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-14 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13273:

Description: 
New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
Simulator does not size correctly, leaving black areas above and below the app 
content and white bars between the black areas and app content.

Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars go 
away, but the black areas remain.

Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 Plus 
Simulators.

Attached Cordova project illustrates the issue.

See screenshots:

!https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!


  was:
New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
Simulator does not size correctly, leaving white bars above and below the 
Webview frame.

Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
frame is sized correctly.

Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 Plus 
Simulators.

Attached Cordova project illustrates the issue.

See screenshots:

!https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: Simulator Screen Shot - iPhone X - 2017-09-14 at 
> 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving black areas above and below the 
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars 
> go away, but the black areas remain.
> Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 
> Plus Simulators.
> Attached Cordova project illustrates the issue.
> See screenshots:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-14 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166407#comment-16166407
 ] 

Dave Alden commented on CB-13273:
-

However, the black bars still remain, so probably still need some some tweaking 
of Launch Images in cordova-ios to get rid of those

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: Simulator Screen Shot - iPhone X - 2017-09-14 at 
> 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving white bars above and below the 
> Webview frame.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
> frame is sized correctly.
> Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 
> Plus Simulators.
> Attached Cordova project illustrates the issue.
> See screenshots:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-14 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166402#comment-16166402
 ] 

Dave Alden edited comment on CB-13273 at 9/14/17 2:57 PM:
--

Setting 
{code:html}viewport-fit=cover{code}
fixes the white bar issue with UIWebView, as outlined here 
[http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/]



was (Author: dpa99c):
Setting 
{code:html}viewport-fit=cover{code}


> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: Simulator Screen Shot - iPhone X - 2017-09-14 at 
> 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving white bars above and below the 
> Webview frame.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
> frame is sized correctly.
> Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 
> Plus Simulators.
> Attached Cordova project illustrates the issue.
> See screenshots:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-14 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166402#comment-16166402
 ] 

Dave Alden edited comment on CB-13273 at 9/14/17 2:57 PM:
--

Setting 
{code:html}viewport-fit=cover{code}
fixes the white bar issue with UIWebView, as outlined here 
[http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/]

[^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]



was (Author: dpa99c):
Setting 
{code:html}viewport-fit=cover{code}
fixes the white bar issue with UIWebView, as outlined here 
[http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/]


> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: Simulator Screen Shot - iPhone X - 2017-09-14 at 
> 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving white bars above and below the 
> Webview frame.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
> frame is sized correctly.
> Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 
> Plus Simulators.
> Attached Cordova project illustrates the issue.
> See screenshots:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-14 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166402#comment-16166402
 ] 

Dave Alden commented on CB-13273:
-

Setting 
{code:html}viewport-fit=cover{code}


> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: Simulator Screen Shot - iPhone X - 2017-09-14 at 
> 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving white bars above and below the 
> Webview frame.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
> frame is sized correctly.
> Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 
> Plus Simulators.
> Attached Cordova project illustrates the issue.
> See screenshots:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-14 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13273:

Attachment: Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: Simulator Screen Shot - iPhone X - 2017-09-14 at 
> 15.52.54.png, webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving white bars above and below the 
> Webview frame.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
> frame is sized correctly.
> Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 
> Plus Simulators.
> Attached Cordova project illustrates the issue.
> See screenshots:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-14 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166355#comment-16166355
 ] 

Dave Alden commented on CB-13273:
-

Possibly related: 
https://stackoverflow.com/questions/46184859/seeing-black-bars-at-the-top-and-bottom-of-the-iphone-x-simulator

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving white bars above and below the 
> Webview frame.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
> frame is sized correctly.
> Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 
> Plus Simulators.
> Attached Cordova project illustrates the issue.
> See screenshots:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640! 
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-14 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166057#comment-16166057
 ] 

Dave Alden commented on CB-13273:
-

They are a screenshots of the iPhone X Simulator when running a simple Cordova 
test app, which has a blue background for the whole page (i.e. ).

The first image shows the app running with the default (UIWebView) - the white 
bars above and below the blue area indicating the Webview is not sized 
correctly to fill the screen.
The second images show the same running running with WKWebView (using 
cordova-plugin-wkwebview-engine) and shows that the same issue is not present: 
no white bars, i.e. the Webview is correctly sized to fill the full screen area.

Note: you have made it more difficult to see the issue by editing the 
description and forcing the images to display above/below rather than 
side-by-side

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving white bars above and below the 
> Webview frame.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
> frame is sized correctly.
> Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 
> Plus Simulators.
> Attached Cordova project illustrates the issue.
> See screenshots:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Issue Comment Deleted] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-13 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13273:

Comment: was deleted

(was: Cordova project which illustrates the issue)

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving white bars above and below the 
> Webview frame.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
> frame is sized correctly.
> Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 
> Plus Simulators.
> Attached Cordova project illustrates the issue.
> See screenshots:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-13 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13273:

Attachment: webview-test.zip

Cordova project which illustrates the issue

> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving white bars above and below the 
> Webview frame.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
> frame is sized correctly.
> Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 
> Plus Simulators.
> See screenshots:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-13 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden updated CB-13273:

Description: 
New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
Simulator does not size correctly, leaving white bars above and below the 
Webview frame.

Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
frame is sized correctly.

Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 Plus 
Simulators.

Attached Cordova project illustrates the issue.

See screenshots:

!https://cdn.pbrd.co/images/GKeaEPg.png|height=640!!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!


  was:
New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
Simulator does not size correctly, leaving white bars above and below the 
Webview frame.

Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
frame is sized correctly.

Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 Plus 
Simulators.

See screenshots:

!https://cdn.pbrd.co/images/GKeaEPg.png|height=640!!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



> Webview is sized incorrectly on iPhone X (Simulator)
> 
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
>Reporter: Dave Alden
>Assignee: Shazron Abdullah
>  Labels: iPhoneX, ios11
> Attachments: webview-test.zip
>
>
> New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
> Simulator does not size correctly, leaving white bars above and below the 
> Webview frame.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
> frame is sized correctly.
> Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 
> Plus Simulators.
> Attached Cordova project illustrates the issue.
> See screenshots:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-13273) Webview is sized incorrectly on iPhone X (Simulator)

2017-09-13 Thread Dave Alden (JIRA)
Dave Alden created CB-13273:
---

 Summary: Webview is sized incorrectly on iPhone X (Simulator)
 Key: CB-13273
 URL: https://issues.apache.org/jira/browse/CB-13273
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-ios
Affects Versions: cordova-ios 4.5.0
 Environment: Xcode 9.0 (9A235)
Simulator 10.0 (SimulatorApp-829.6) - iPhone X
Reporter: Dave Alden
Assignee: Shazron Abdullah


New app with cordova-ios@4.5.0 (using default UIWebView) running on iPhone X 
Simulator does not size correctly, leaving white bars above and below the 
Webview frame.

Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, the Webview 
frame is sized correctly.

Note: the sizing of UIWebView appears correct in the iPhone 8 and iPhone 8 Plus 
Simulators.

See screenshots:

!https://cdn.pbrd.co/images/GKeaEPg.png|height=640!!https://cdn.pbrd.co/images/GKeaWwK.png|height=640!




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-09-10 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160433#comment-16160433
 ] 

Dave Alden commented on CB-7179:


Yes, I will put together a PR. My aim has been not to change the plugin 
functionality, just the implementation.
Main changes are obviously it now depends on cordova-plugin-wkwebview-engine 
and drops support for iOS 8 since I've removed the UIWebView implementation 
entirely, rather than conditionally switched it. It will require a good 
regression test and probably contains bugs somewhere. Some of the changes are 
non-obvious and work around issues that may not be immediately obvious, so I'm 
happy to further comment the code if that helps.

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-09-08 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158663#comment-16158663
 ] 

Dave Alden commented on CB-7179:


I have fixed the remaining known issues in my fork and published it as 
[cordova-plugin-inappbrowser-wkwebview|https://github.com/dpa99c/cordova-plugin-inappbrowser-wkwebview].

Hopefully it will soon become redundant when cordova-plugin-inappbrowser 
officially switches over to WKWebView.

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-09-06 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125372#comment-16125372
 ] 

Dave Alden edited comment on CB-7179 at 9/6/17 3:31 PM:


I'm continuing to push improvements to [my 
branch|https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview]
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* -on changing device orientation, webview content does not resize to fill page-
* -closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)-
* -security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation-


was (Author: dpa99c):
I'm continuing to push improvements to [my 
branch|https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview]
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* -on changing device orientation, webview content does not resize to fill page-
* -closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)-
* security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-09-05 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125372#comment-16125372
 ] 

Dave Alden edited comment on CB-7179 at 9/5/17 2:04 PM:


I'm continuing to push improvements to [my 
branch|https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview]
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* -on changing device orientation, webview content does not resize to fill page-
* -closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)-
* security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation


was (Author: dpa99c):
I'm continuing to push improvements to [my 
branch|https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview]
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* -on changing device orientation, webview content does not resize to fill page-
* closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)
* security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-08-14 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125372#comment-16125372
 ] 

Dave Alden edited comment on CB-7179 at 8/14/17 8:51 AM:
-

I'm continuing to push improvements to [my 
branch|https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview]
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* -on changing device orientation, webview content does not resize to fill page-
* closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)
* security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation


was (Author: dpa99c):
I'm continuing to push improvements to [my 
branch|https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview]
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* on changing device orientation, webview content does not resize to fill page
* closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)
* security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-08-14 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125372#comment-16125372
 ] 

Dave Alden edited comment on CB-7179 at 8/14/17 8:37 AM:
-

I'm continuing to push improvements to [my 
branch|https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview]
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* on changing device orientation, webview content does not resize to fill page
* closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)
* security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation


was (Author: dpa99c):
I'm continuing to push improvements to [my 
branch](https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview)
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* on changing device orientation, webview content does not resize to fill page
* closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)
* security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-08-14 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125372#comment-16125372
 ] 

Dave Alden commented on CB-7179:


I'm continuing to push improvements to [my 
branch](https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview)
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* on changing device orientation, webview content does not resize to fill page
* closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)
* security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12668) support arbitrary creation of resources in the Asset Catalog

2017-05-10 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004243#comment-16004243
 ] 

Dave Alden commented on CB-12668:
-

I really needed to be able to create custom image asset catalogs for the above 
plugin, so I've added functionality to the 
[cordova-custom-config|https://github.com/dpa99c/cordova-custom-config] plugin 
to do so, until such time as the Cordova CLI itself supports this. 
Documentation here: 
https://github.com/dpa99c/cordova-custom-config#ios-image-resources

> support arbitrary creation of resources in the Asset Catalog
> 
>
> Key: CB-12668
> URL: https://issues.apache.org/jira/browse/CB-12668
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-ios
>Affects Versions: 3.6.4
>Reporter: Josh Sharpe
>Priority: Critical
>  Labels: cordova-ios
>
> A handful of plugins* recommend the use of an image/asset out of the Asset 
> Catalog.  It would be great if we could create those just by setting tags in 
> config.xml, similar to  and  that then generate the resource in 
> Xcode.
> My specific use case is to add a "back" image to be used by 
> 'cordova-plugin-themeablebrowser'.  I can do this manually by:
> - opening xCode
> - Click on Project -> Resources -> Image.xcassets
> - Click '+' in the bottom task bar -> New Image Set
> - Rename the new Set 'back'
> - Manually drag and drop 3 images into xcode
> To be clear - I'm not asking that cordova produce different sized images as I 
> believe that's out of scope.  I just need it to build the new resource in 
> xcode referencing certain files on disk with tags like:
> 
>   
>   
>   
>  * Example plugins:
> https://github.com/arnesson/cordova-plugin-firebase
> https://github.codifferent m/phonegap/phonegap-plugin-push
> https://github.com/initialxy/cordova-plugin-themeablebrowser
> **Bonus!**
> It'd be extra great, since I'm sure some folks want this, if cordova could 
> add sound files to be used by firebase/push plugins that can leverage those 
> if they exist, but I'm not sure how those get set up in xcode such that 
> phonegap-plugin-push can use them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12668) support arbitrary creation of resources in the Asset Catalog

2017-05-09 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002430#comment-16002430
 ] 

Dave Alden commented on CB-12668:
-

https://github.com/EddyVerbruggen/cordova-plugin-3dtouch is another plugin 
which requires a custom asset catalog

> support arbitrary creation of resources in the Asset Catalog
> 
>
> Key: CB-12668
> URL: https://issues.apache.org/jira/browse/CB-12668
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-ios
>Affects Versions: 3.6.4
>Reporter: Josh Sharpe
>Priority: Critical
>  Labels: cordova-ios
>
> A handful of plugins* recommend the use of an image/asset out of the Asset 
> Catalog.  It would be great if we could create those just by setting tags in 
> config.xml, similar to  and  that then generate the resource in 
> Xcode.
> My specific use case is to add a "back" image to be used by 
> 'cordova-plugin-themeablebrowser'.  I can do this manually by:
> - opening xCode
> - Click on Project -> Resources -> Image.xcassets
> - Click '+' in the bottom task bar -> New Image Set
> - Rename the new Set 'back'
> - Manually drag and drop 3 images into xcode
> To be clear - I'm not asking that cordova produce different sized images as I 
> believe that's out of scope.  I just need it to build the new resource in 
> xcode referencing certain files on disk with tags like:
> 
>   
>   
>   
>  * Example plugins:
> https://github.com/arnesson/cordova-plugin-firebase
> https://github.codifferent m/phonegap/phonegap-plugin-push
> https://github.com/initialxy/cordova-plugin-themeablebrowser
> **Bonus!**
> It'd be extra great, since I'm sure some folks want this, if cordova could 
> add sound files to be used by firebase/push plugins that can leverage those 
> if they exist, but I'm not sure how those get set up in xcode such that 
> phonegap-plugin-push can use them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-12668) support arbitrary creation of resources in the Asset Catalog

2017-05-09 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002430#comment-16002430
 ] 

Dave Alden edited comment on CB-12668 at 5/9/17 10:12 AM:
--

https://github.com/EddyVerbruggen/cordova-plugin-3dtouch is another plugin 
which requires a custom asset catalog to set custom icons


was (Author: dpa99c):
https://github.com/EddyVerbruggen/cordova-plugin-3dtouch is another plugin 
which requires a custom asset catalog

> support arbitrary creation of resources in the Asset Catalog
> 
>
> Key: CB-12668
> URL: https://issues.apache.org/jira/browse/CB-12668
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-ios
>Affects Versions: 3.6.4
>Reporter: Josh Sharpe
>Priority: Critical
>  Labels: cordova-ios
>
> A handful of plugins* recommend the use of an image/asset out of the Asset 
> Catalog.  It would be great if we could create those just by setting tags in 
> config.xml, similar to  and  that then generate the resource in 
> Xcode.
> My specific use case is to add a "back" image to be used by 
> 'cordova-plugin-themeablebrowser'.  I can do this manually by:
> - opening xCode
> - Click on Project -> Resources -> Image.xcassets
> - Click '+' in the bottom task bar -> New Image Set
> - Rename the new Set 'back'
> - Manually drag and drop 3 images into xcode
> To be clear - I'm not asking that cordova produce different sized images as I 
> believe that's out of scope.  I just need it to build the new resource in 
> xcode referencing certain files on disk with tags like:
> 
>   
>   
>   
>  * Example plugins:
> https://github.com/arnesson/cordova-plugin-firebase
> https://github.codifferent m/phonegap/phonegap-plugin-push
> https://github.com/initialxy/cordova-plugin-themeablebrowser
> **Bonus!**
> It'd be extra great, since I'm sure some folks want this, if cordova could 
> add sound files to be used by firebase/push plugins that can leverage those 
> if they exist, but I'm not sure how those get set up in xcode such that 
> phonegap-plugin-push can use them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11752) cordova plugins update

2016-12-21 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767490#comment-15767490
 ] 

Dave Alden commented on CB-11752:
-

In the meantime, an interim solution: 
[cordova-check-plugins|https://github.com/dpa99c/cordova-check-plugins] enables 
you to update all or specified plugins

> cordova plugins update
> --
>
> Key: CB-11752
> URL: https://issues.apache.org/jira/browse/CB-11752
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI
>Reporter: Philipp Kursawe
>Priority: Minor
>
> Would be nice to have such a CLI command to update all or specific plugins.
> The current `rm --save` && `add --save` is sub-optimal.
> {code}
> #!/bin/bash
> PLUGINS=$(cordova plugin list | awk '{print $1'})
> for PLUGIN in $PLUGINS; do
> cordova plugin rm $PLUGIN --save && cordova plugin add $PLUGIN --save
> done
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-10478) getCurrentPosition should trigger system dialog for enabling location services

2016-07-20 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385645#comment-15385645
 ] 

Dave Alden commented on CB-10478:
-

cordova-plugin-request-location-accuracy@2.0.0 
(https://github.com/dpa99c/cordova-plugin-request-location-accuracy) enables a 
direct location request to be made which triggers the native iOS dialog to 
directly open the Privacy page in the Settings app where the switch for 
Location Services is located.

> getCurrentPosition should trigger system dialog for enabling location services
> --
>
> Key: CB-10478
> URL: https://issues.apache.org/jira/browse/CB-10478
> Project: Apache Cordova
>  Issue Type: Wish
>  Components: Plugin Geolocation
> Environment: iOS, Android
>Reporter: Zarko Hristovski
>  Labels: features, iOS, triaged
>
> The use case is when an app/user needs to access geoposition while 
> device's location services are disabled. Let's say for the first time / 
> attempt.
> While I've been able to find a way to send the user directly to the 
> system setting on Android (via cordova-diagnostic-plugin's 
> switchToLocationSettings),
> it seems to be no obvious way to achieve the same on iOS with the 
> plugin(s) at present.
> I'll point you to two existing threads that explain in more detail so 
> that I don't repeat myself here:
> - 
> https://forum.ionicframework.com/t/ios-plugin-for-sending-user-to-settings-privacy-location-services
> - https://github.com/dpa99c/cordova-diagnostic-plugin/issues/31
> I thus suggest extending getCurrentPosition with an option for a better UX in 
> case the device's location services are disabled. On iOS it should trigger 
> the system dialog where the user is given a choice between "Settings" and 
> "Cancel". "Settings" gives the user the possibility to go straight into 
> Settings->Privacy->Location Services.
> I would suggest covering the same for Android, even thought this issue is 
> concerned mainly with the UX on iOS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-10310) iOS Build fails after upgrade to cordova-ios@4.0.1

2016-01-16 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-10310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103242#comment-15103242
 ] 

Dave Alden commented on CB-10310:
-

cordova.plugins.diagnostic@2.3.7 published to npm which resolves build issues 
with cordova-ios@4.x

sorry for the delay - the dev has been actively busy with other things - i.e. 
on holiday ;-)

> iOS Build fails after upgrade to cordova-ios@4.0.1
> --
>
> Key: CB-10310
> URL: https://issues.apache.org/jira/browse/CB-10310
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
> Environment: Cordova CLI: 5.4.1
> Ionic Version: 1.2.1-nightly-1867
> Ionic CLI Version: 1.7.12
> Ionic App Lib Version: 0.6.5
> ios-deploy version: 1.8.4
> ios-sim version: 5.0.6
> OS: Mac OS X El Capitan
> Node Version: v5.4.0
> Xcode version: Xcode 7.2 Build version 7C68
> npm -v : 3.5.3
> bower -v : 1.7.2
> cordova platform :
> Installed platforms: android 5.0.0, ios 4.0.1
> Android tools and Platform-tools :
> Pkg.Revision=24.4.1
> Pkg.Revision=23.1
> brew config :
> HOMEBREW_VERSION: 0.9.5
> CPU: quad-core 64-bit ivybridge
> OS X: 10.11.2-x86_64
> Xcode: 7.2
> CLT: 7.2.0.0.1.1447826929
> Clang: 7.0 build 700
> X11: N/A
> System Ruby: 2.0.0-p645
> Perl: /usr/bin/perl
> Python: /usr/local/bin/python => 
> /usr/local/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/bin/python2.7
> Ruby: /Users/jagdish/.rbenv/shims/ruby => 
> /Users/jagdish/.rbenv/versions/2.3.0/bin/ruby
> Java: 1.8.0_66
> psql --version: psql (PostgreSQL) 9.4.5
>Reporter: Jagdish Adusumalli
>  Labels: build-failure, build-problem, cordova-ios-4.0.1, ios
> Attachments: build error cordova-plugin-diagnostic.png, build error 
> with cordova-plugin-camera.png, build error with cordova-plugin-sms.png
>
>
> I'm working on an ionic app and just upgrade the ios platform to 4.0.1.
> i am unable to build the ios app now using the command
> "ionic build ios" or "cordova build ios"
> i observed the error is arising from the various plugins which are failing 
> now.
> i removed the plugins one after another to see how many plugins are 
> incompatible 
> and not working and found the below 5 plugins are raising the same error
> cordova-plugin-camera 1.2.0 "Camera"
> cordova.plugins.diagnostic 2.3.5 "Diagnostic"
> com.cordova.plugins.sms 0.1.6 "Cordova SMS Plugin"
> com.dbaq.cordova.contactsPhoneNumbers 0.0.5 "Contacts Phone Numbers"
> cordova-plugin-sms 1.0.5 "SMS"
> Error sample raised for sms plugin looks as below
> ** BUILD FAILED **
> The following build commands failed:
>   CompileC 
> build/qiddlestage.build/Debug-iphonesimulator/qiddlestage.build/Objects-normal/i386/Sms.o
>  qiddlestage/Plugins/com.cordova.plugins.sms/Sms.m normal i386 objective-c 
> com.apple.compilers.llvm.clang.1_0.compiler
> (1 failure)
> ERROR building one of the platforms: Error code 65 for command: xcodebuild 
> with args: 
> -xcconfig,/Users/jagdish/work/ywt-moms/platforms/ios/cordova/build-debug.xcconfig,-project,qiddlestage.xcodeproj,ARCHS=i386,-target,qiddlestage,-configuration,Debug,-sdk,iphonesimulator,build,VALID_ARCHS=i386,CONFIGURATION_BUILD_DIR=/Users/jagdish/work/ywt-moms/platforms/ios/build/emulator,SHARED_PRECOMPS_DIR=/Users/jagdish/work/ywt-moms/platforms/ios/build/sharedpch
> You may not have the required environment or OS to build this project
> Error: Error code 65 for command: xcodebuild with args: 
> -xcconfig,/Users/jagdish/work/ywt-moms/platforms/ios/cordova/build-debug.xcconfig,-project,qiddlestage.xcodeproj,ARCHS=i386,-target,qiddlestage,-configuration,Debug,-sdk,iphonesimulator,build,VALID_ARCHS=i386,CONFIGURATION_BUILD_DIR=/Users/jagdish/work/ywt-moms/platforms/ios/build/emulator,SHARED_PRECOMPS_DIR=/Users/jagdish/work/ywt-moms/platforms/ios/build/sharedpch
> also attaching error screenshots with various plugins.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Reopened] (CB-9945) Geolocation plugin not working in Android 6.0 emulator

2015-11-26 Thread Dave Alden (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Alden reopened CB-9945:


This issue is still occurring with the latest cordova-android (5.1.0-dev) and 
cordova-plugin-geolocation (2.0.0).

See this screen capture video illustrating the issue: 
http://ge.tt/api/1/files/3NdclVS2/0/blob?download

I've updated the project in the bitbucket repo with these versions. The result 
still the same: requesting location causes emulator to reboot with exception: 
java.lang.IllegalArgumentException: provider doesn't exist: network

Is this likely to be an Android issue rather than a Cordova issue?

> Geolocation plugin not working in Android 6.0 emulator
> --
>
> Key: CB-9945
> URL: https://issues.apache.org/jira/browse/CB-9945
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android, Plugin Geolocation
> Environment: AVD Android 6.0
> Genymotion Android 6.0 PREVIEW
>Reporter: Dave Alden
>
> Calling the Cordova geolocation API in an Android emulator environment causes 
> the Android OS to crash and reboot.
> The issue is reproducible with Cordova geolocation plugin from npm release 
> version 1.0.1 and latest version on master branch 1.0.2-dev.
> Steps to reproduce:
> Use the Cordova geolocation API to request a location in Android 6.0 emulator 
> environment:
> navigator.geolocation.getCurrentPosition(onPosition, onPositionError, {
> maxAge: 0,
> timeout: 1,
> enableHighAccuracy: false
> });
> 
> OR clone the bitbucket repo 
> https://bitbucket.org/dpa99c/android-m-location-test/src, build and run
> OR install and run the pre-built APK for that project: 
> https://bitbucket.org/dpa99c/android-m-location-test/raw/9a836ca3e3185db55fa75b263a4abbb76b4713ea/android-debug.apk



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-9945) Geolocation plugin not working in Android 6.0 emulator

2015-11-03 Thread Dave Alden (JIRA)
Dave Alden created CB-9945:
--

 Summary: Geolocation plugin not working in Android 6.0 emulator
 Key: CB-9945
 URL: https://issues.apache.org/jira/browse/CB-9945
 Project: Apache Cordova
  Issue Type: Bug
  Components: Android, Plugin Geolocation
 Environment: AVD Android 6.0
Genymotion Android 6.0 PREVIEW
Reporter: Dave Alden


Calling the Cordova geolocation API in an Android emulator environment causes 
the Android OS to crash and reboot.

The issue is reproducible with Cordova geolocation plugin from npm release 
version 1.0.1 and latest version on master branch 1.0.2-dev.

Steps to reproduce:
Use the Cordova geolocation API to request a location in Android 6.0 emulator 
environment:

navigator.geolocation.getCurrentPosition(onPosition, onPositionError, {
maxAge: 0,
timeout: 1,
enableHighAccuracy: false
});

OR clone the bitbucket repo 
https://bitbucket.org/dpa99c/android-m-location-test/src, build and run

OR install and run the pre-built APK for that project: 
https://bitbucket.org/dpa99c/android-m-location-test/raw/9a836ca3e3185db55fa75b263a4abbb76b4713ea/android-debug.apk



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-8953) Cordova iOS prepare is removing UISupportedInterfaceOrientations from the plist file

2015-05-28 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562592#comment-14562592
 ] 

Dave Alden edited comment on CB-8953 at 5/28/15 9:46 AM:
-

This bug means that it's not possible to create an app which supports all 
orientations on iPhone.

Previously I had the following config in my .plist:

UISupportedInterfaceOrientations

UIInterfaceOrientationPortrait
UIInterfaceOrientationLandscapeLeft
UIInterfaceOrientationPortraitUpsideDown
UIInterfaceOrientationLandscapeRight

UISupportedInterfaceOrientations~ipad

UIInterfaceOrientationPortrait
UIInterfaceOrientationLandscapeLeft
UIInterfaceOrientationPortraitUpsideDown
UIInterfaceOrientationLandscapeRight


After running 'cordova prepare', the UISupportedInterfaceOrientations section 
is removed, meaning the app is fixed to portrait orientation.

Adding the orientation preference to the config.xml enables portrait OR 
landscape keys to be added to the plist under UISupportedInterfaceOrientations, 
but not both:


inserts:
UISupportedInterfaceOrientations

UIInterfaceOrientationPortrait
UIInterfaceOrientationPortraitUpsideDown



inserts:
UISupportedInterfaceOrientations

UIInterfaceOrientationLandscapeLeft
UIInterfaceOrientationLandscapeRight


 OR omitting the preference 
key entirely, causes UISupportedInterfaceOrientations to be removed from the 
plist


was (Author: dpa99c):
This bug means that it's not possible to create an app which supports all 
orientations on iPhone.

Previously I had the following config in my .plist:

UISupportedInterfaceOrientations

UIInterfaceOrientationPortrait
UIInterfaceOrientationLandscapeLeft
UIInterfaceOrientationPortraitUpsideDown
UIInterfaceOrientationLandscapeRight

UISupportedInterfaceOrientations~ipad

UIInterfaceOrientationPortrait
UIInterfaceOrientationLandscapeLeft
UIInterfaceOrientationPortraitUpsideDown
UIInterfaceOrientationLandscapeRight


After running 'cordova prepare', the UISupportedInterfaceOrientations section 
is removed, meaning the app is fixed to portrait orientation.

Adding the orientation preference to the config.xml allows enables portrait OR 
landscape keys to be added to the plist under UISupportedInterfaceOrientations, 
but not both:


inserts:
UISupportedInterfaceOrientations

UIInterfaceOrientationPortrait
UIInterfaceOrientationPortraitUpsideDown



inserts:
UISupportedInterfaceOrientations

UIInterfaceOrientationLandscapeLeft
UIInterfaceOrientationLandscapeRight


 OR omitting the preference 
key entirely, causes UISupportedInterfaceOrientations to be removed from the 
plist

> Cordova iOS prepare is removing UISupportedInterfaceOrientations from the 
> plist file
> 
>
> Key: CB-8953
> URL: https://issues.apache.org/jira/browse/CB-8953
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 5.0.0
> Environment: iOS
>Reporter: Vinoth Kumar
>
> I just installed the CLI 5.0.0 and when I try to run,
> 'cordova prepare ios', it is modifying the app plist file.
> That is, the prepare is removing the UISupportedInterfaceOrientations key and 
> the array list from the plist.
> Before Prepare: 
> UISupportedInterfaceOrientations
>   
>   UIInterfaceOrientationPortrait
>   UIInterfaceOrientationPortraitUpsideDown
>   
>   UISupportedInterfaceOrientations~ipad
>   
>   UIInterfaceOrientationPortrait
>   UIInterfaceOrientationLandscapeLeft
>   UIInterfaceOrientationPortraitUpsideDown
>   UIInterfaceOrientationLandscapeRight
>   
> After Prepare:
>  UISupportedInterfaceOrientations~ipad
> 
>   UIInterfaceOrientationPortrait
>   UIInterfaceOrientationLandscapeLeft
>   UIInterfaceOrientationPortraitUpsideDown
>   UIInterfaceOrientationLandscapeRight
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-8953) Cordova iOS prepare is removing UISupportedInterfaceOrientations from the plist file

2015-05-28 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562592#comment-14562592
 ] 

Dave Alden commented on CB-8953:


This bug means that it's not possible to create an app which supports all 
orientations on iPhone.

Previously I had the following config in my .plist:

UISupportedInterfaceOrientations

UIInterfaceOrientationPortrait
UIInterfaceOrientationLandscapeLeft
UIInterfaceOrientationPortraitUpsideDown
UIInterfaceOrientationLandscapeRight

UISupportedInterfaceOrientations~ipad

UIInterfaceOrientationPortrait
UIInterfaceOrientationLandscapeLeft
UIInterfaceOrientationPortraitUpsideDown
UIInterfaceOrientationLandscapeRight


After running 'cordova prepare', the UISupportedInterfaceOrientations section 
is removed, meaning the app is fixed to portrait orientation.

Adding the orientation preference to the config.xml allows enables portrait OR 
landscape keys to be added to the plist under UISupportedInterfaceOrientations, 
but not both:


inserts:
UISupportedInterfaceOrientations

UIInterfaceOrientationPortrait
UIInterfaceOrientationPortraitUpsideDown



inserts:
UISupportedInterfaceOrientations

UIInterfaceOrientationLandscapeLeft
UIInterfaceOrientationLandscapeRight


 OR omitting the preference 
key entirely, causes UISupportedInterfaceOrientations to be removed from the 
plist

> Cordova iOS prepare is removing UISupportedInterfaceOrientations from the 
> plist file
> 
>
> Key: CB-8953
> URL: https://issues.apache.org/jira/browse/CB-8953
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 5.0.0
> Environment: iOS
>Reporter: Vinoth Kumar
>
> I just installed the CLI 5.0.0 and when I try to run,
> 'cordova prepare ios', it is modifying the app plist file.
> That is, the prepare is removing the UISupportedInterfaceOrientations key and 
> the array list from the plist.
> Before Prepare: 
> UISupportedInterfaceOrientations
>   
>   UIInterfaceOrientationPortrait
>   UIInterfaceOrientationPortraitUpsideDown
>   
>   UISupportedInterfaceOrientations~ipad
>   
>   UIInterfaceOrientationPortrait
>   UIInterfaceOrientationLandscapeLeft
>   UIInterfaceOrientationPortraitUpsideDown
>   UIInterfaceOrientationLandscapeRight
>   
> After Prepare:
>  UISupportedInterfaceOrientations~ipad
> 
>   UIInterfaceOrientationPortrait
>   UIInterfaceOrientationLandscapeLeft
>   UIInterfaceOrientationPortraitUpsideDown
>   UIInterfaceOrientationLandscapeRight
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org