[jira] [Created] (CB-8063) CDVCommandStatus.NO_RESULT calls fail on ios

2014-11-24 Thread James Keshavarzi (JIRA)
James Keshavarzi created CB-8063:


 Summary: CDVCommandStatus.NO_RESULT calls fail on ios
 Key: CB-8063
 URL: https://issues.apache.org/jira/browse/CB-8063
 Project: Apache Cordova
  Issue Type: Bug
  Components: CordovaLib, iOS
Affects Versions: 4.0.0
Reporter: James Keshavarzi


Cordova version: 4.1.2

When returning a pluginResult with a resultWithStatus of NO_RESULT, the fail 
callback gets called for a plugin, when it shouldn't. Previously nothing was 
called in the client (success/fail) and the plugin was free to continue 
execution and later send a status of OK or ERROR as it deemed necessary. 
Sending a NO_RESULT seems to perform the same operations as sending an ERROR, 
which seems wrong.

The below code ends up calling the fail callback.

---CODE---
pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_NO_RESULT];

pluginResult.keepCallback = [NSNumber numberWithInt:1];

[self.commandDelegate sendPluginResult:pluginResult 
callbackId:command.callbackId];



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-8063) CDVCommandStatus.NO_RESULT calls fail on ios

2014-11-24 Thread James Keshavarzi (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-8063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Keshavarzi updated CB-8063:
-
Description: 
Cordova version: 4.1.2

When returning a pluginResult with a resultWithStatus of NO_RESULT, the fail 
callback gets called for a plugin, when it shouldn't. Previously nothing was 
called in the client (success/fail) and the plugin was free to continue 
execution and later send a status of OK or ERROR as it deemed necessary. 
Sending a NO_RESULT seems to perform the same operations as sending an ERROR, 
which seems wrong.

The below code ends up calling the fail callback.

Code:
pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_NO_RESULT];

pluginResult.keepCallback = [NSNumber numberWithInt:1];

[self.commandDelegate sendPluginResult:pluginResult 
callbackId:command.callbackId];

  was:
Cordova version: 4.1.2

When returning a pluginResult with a resultWithStatus of NO_RESULT, the fail 
callback gets called for a plugin, when it shouldn't. Previously nothing was 
called in the client (success/fail) and the plugin was free to continue 
execution and later send a status of OK or ERROR as it deemed necessary. 
Sending a NO_RESULT seems to perform the same operations as sending an ERROR, 
which seems wrong.

The below code ends up calling the fail callback.

---CODE---
pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_NO_RESULT];

pluginResult.keepCallback = [NSNumber numberWithInt:1];

[self.commandDelegate sendPluginResult:pluginResult 
callbackId:command.callbackId];


 CDVCommandStatus.NO_RESULT calls fail on ios
 

 Key: CB-8063
 URL: https://issues.apache.org/jira/browse/CB-8063
 Project: Apache Cordova
  Issue Type: Bug
  Components: CordovaLib, iOS
Affects Versions: 4.0.0
Reporter: James Keshavarzi

 Cordova version: 4.1.2
 When returning a pluginResult with a resultWithStatus of NO_RESULT, the fail 
 callback gets called for a plugin, when it shouldn't. Previously nothing was 
 called in the client (success/fail) and the plugin was free to continue 
 execution and later send a status of OK or ERROR as it deemed necessary. 
 Sending a NO_RESULT seems to perform the same operations as sending an ERROR, 
 which seems wrong.
 The below code ends up calling the fail callback.
 Code:
 pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_NO_RESULT];
 pluginResult.keepCallback = [NSNumber numberWithInt:1];
 [self.commandDelegate sendPluginResult:pluginResult 
 callbackId:command.callbackId];



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-8063) CDVCommandStatus.NO_RESULT calls fail on ios

2014-11-24 Thread James Keshavarzi (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-8063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223563#comment-14223563
 ] 

James Keshavarzi commented on CB-8063:
--

Hey, can you please assign this issue to me?

James K


 CDVCommandStatus.NO_RESULT calls fail on ios
 

 Key: CB-8063
 URL: https://issues.apache.org/jira/browse/CB-8063
 Project: Apache Cordova
  Issue Type: Bug
  Components: iOS
Affects Versions: 4.0.0
Reporter: James Keshavarzi

 Cordova version: 4.1.2
 When returning a pluginResult with a resultWithStatus of NO_RESULT, the fail 
 callback gets called for a plugin, when it shouldn't. Previously nothing was 
 called in the client (success/fail) and the plugin was free to continue 
 execution and later send a status of OK or ERROR as it deemed necessary. 
 Sending a NO_RESULT seems to perform the same operations as sending an ERROR, 
 which seems wrong.
 The below code ends up calling the fail callback.
 {code}
 pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_NO_RESULT];
 pluginResult.keepCallback = [NSNumber numberWithInt:1];
 [self.commandDelegate sendPluginResult:pluginResult 
 callbackId:command.callbackId];
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-8063) CDVCommandStatus.NO_RESULT calls fail on ios

2014-11-24 Thread James Keshavarzi (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-8063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223643#comment-14223643
 ] 

James Keshavarzi commented on CB-8063:
--

Pretty sure it's this line thats the problem.

https://github.com/apache/cordova-js/blob/1fc2526faa6197e1637ecb48ebe0f876f008ba0f/src/cordova.js#L205

It use to read like this;

else if (!isSuccess)

instead of

else

The NO_RESULT use case seems to be falling into the else clause.

Can you please assign the issue to me and i'll put up a fix.

Thanks.

 CDVCommandStatus.NO_RESULT calls fail on ios
 

 Key: CB-8063
 URL: https://issues.apache.org/jira/browse/CB-8063
 Project: Apache Cordova
  Issue Type: Bug
  Components: CordovaJS
Affects Versions: 4.0.0
 Environment: iOS
Reporter: James Keshavarzi

 Cordova version: 4.1.2
 When returning a pluginResult with a resultWithStatus of NO_RESULT, the fail 
 callback gets called for a plugin, when it shouldn't. Previously nothing was 
 called in the client (success/fail) and the plugin was free to continue 
 execution and later send a status of OK or ERROR as it deemed necessary. 
 Sending a NO_RESULT seems to perform the same operations as sending an ERROR, 
 which seems wrong.
 The below code ends up calling the fail callback.
 {code}
 pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_NO_RESULT];
 pluginResult.keepCallback = [NSNumber numberWithInt:1];
 [self.commandDelegate sendPluginResult:pluginResult 
 callbackId:command.callbackId];
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-8063) CDVCommandStatus.NO_RESULT calls fail on ios

2014-11-24 Thread James Keshavarzi (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-8063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223643#comment-14223643
 ] 

James Keshavarzi edited comment on CB-8063 at 11/24/14 10:26 PM:
-

Pretty sure it's this line thats the problem.

https://github.com/apache/cordova-js/blob/1fc2526faa6197e1637ecb48ebe0f876f008ba0f/src/cordova.js#L205

It use to read like this;
{code}
else if (!isSuccess)
{code}
instead of
{code}
else
{code}
The NO_RESULT use case seems to be falling into the else clause.

Can you please assign the issue to me and i'll put up a fix.

Thanks.


was (Author: jkeshavarzi):
Pretty sure it's this line thats the problem.

https://github.com/apache/cordova-js/blob/1fc2526faa6197e1637ecb48ebe0f876f008ba0f/src/cordova.js#L205

It use to read like this;

else if (!isSuccess)

instead of

else

The NO_RESULT use case seems to be falling into the else clause.

Can you please assign the issue to me and i'll put up a fix.

Thanks.

 CDVCommandStatus.NO_RESULT calls fail on ios
 

 Key: CB-8063
 URL: https://issues.apache.org/jira/browse/CB-8063
 Project: Apache Cordova
  Issue Type: Bug
  Components: CordovaJS
Affects Versions: 4.0.0
 Environment: iOS
Reporter: James Keshavarzi

 Cordova version: 4.1.2
 When returning a pluginResult with a resultWithStatus of NO_RESULT, the fail 
 callback gets called for a plugin, when it shouldn't. Previously nothing was 
 called in the client (success/fail) and the plugin was free to continue 
 execution and later send a status of OK or ERROR as it deemed necessary. 
 Sending a NO_RESULT seems to perform the same operations as sending an ERROR, 
 which seems wrong.
 The below code ends up calling the fail callback.
 {code}
 pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_NO_RESULT];
 pluginResult.keepCallback = [NSNumber numberWithInt:1];
 [self.commandDelegate sendPluginResult:pluginResult 
 callbackId:command.callbackId];
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-8063) CDVCommandStatus.NO_RESULT calls fail on ios

2014-11-24 Thread James Keshavarzi (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-8063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223670#comment-14223670
 ] 

James Keshavarzi commented on CB-8063:
--

Yea, i'm pretty sure that's what's expected for NO_RESULT and your pseudo-code 
seems correct.
As far as i understand it essentially allows execution to continue and the 
plugin can do some processing before calling one of ERROR or OK.

 CDVCommandStatus.NO_RESULT calls fail on ios
 

 Key: CB-8063
 URL: https://issues.apache.org/jira/browse/CB-8063
 Project: Apache Cordova
  Issue Type: Bug
  Components: CordovaJS
Affects Versions: 4.0.0
 Environment: iOS
Reporter: James Keshavarzi

 Cordova version: 4.1.2
 When returning a pluginResult with a resultWithStatus of NO_RESULT, the fail 
 callback gets called for a plugin, when it shouldn't. Previously nothing was 
 called in the client (success/fail) and the plugin was free to continue 
 execution and later send a status of OK or ERROR as it deemed necessary. 
 Sending a NO_RESULT seems to perform the same operations as sending an ERROR, 
 which seems wrong.
 The below code ends up calling the fail callback.
 {code}
 pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_NO_RESULT];
 pluginResult.keepCallback = [NSNumber numberWithInt:1];
 [self.commandDelegate sendPluginResult:pluginResult 
 callbackId:command.callbackId];
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-7808) loadLocalPlugins error when installing local plugin with dependency on local plugin

2014-10-16 Thread James Keshavarzi (JIRA)
James Keshavarzi created CB-7808:


 Summary: loadLocalPlugins error when installing local plugin with 
dependency on local plugin
 Key: CB-7808
 URL: https://issues.apache.org/jira/browse/CB-7808
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugman
Affects Versions: 3.6.0, 4.0.0
Reporter: James Keshavarzi


The following error occurs when adding a local plugin that has a dependency on 
a local plugin. Most common use case is adding a test plugin that uses the 
org.apache.cordova.test-framework and adds the plugins being tested using a 
relative path (see below).

dependency id=com.blackberry.document
url=.
subdir=plugin /

dependency id=org.apache.cordova.test-framework

url=https://git-wip-us.apache.org/repos/asf/cordova-plugin-test-framework.git; 
/

Steps to reproduce
cordova create appTest
cordova platform add blackberry10
cordova platform add android
cordova plugin add ~/local-plugin/

Installing com.blackberry.document for blackberry10
Failed to install 'com.blackberry.document':Error: loadLocalPlugins called 
twice with different search paths.Support for this is not implemented.
at loadLocalPlugins 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:165:19)
at findLocalPlugin 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:193:5)
at Object.fetchPlugin 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:111:25)
at possiblyFetch 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:101:24)
at installDependency 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:498:16)
at 
/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:364:32
at _fulfilled 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:798:54)
at self.promiseDispatch.done 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:827:30)
at Promise.promise.promiseDispatch 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:760:13)
at /usr/local/lib/node_modules/cordova/node_modules/q/q.js:821:14
Failed to install 'com.blackberry.document.tests':Error: loadLocalPlugins 
called twice with different search paths.Support for this is not implemented.
at loadLocalPlugins 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:165:19)
at findLocalPlugin 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:193:5)
at Object.fetchPlugin 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:111:25)
at possiblyFetch 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:101:24)
at installDependency 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:498:16)
at 
/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:364:32
at _fulfilled 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:798:54)
at self.promiseDispatch.done 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:827:30)
at Promise.promise.promiseDispatch 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:760:13)
at /usr/local/lib/node_modules/cordova/node_modules/q/q.js:821:14
Error: loadLocalPlugins called twice with different search paths.Support for 
this is not implemented.
at loadLocalPlugins 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:165:19)
at findLocalPlugin 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:193:5)
at Object.fetchPlugin 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:111:25)
at possiblyFetch 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:101:24)
at installDependency 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:498:16)
at 
/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:364:32
at _fulfilled 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:798:54)
at self.promiseDispatch.done 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:827:30)
at Promise.promise.promiseDispatch 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:760:13)
at /usr/local/lib/node_modules/cordova/node_modules/q/q.js:821:14



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-7808) loadLocalPlugins error when installing local plugin with dependency on local plugin

2014-10-16 Thread James Keshavarzi (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-7808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Keshavarzi updated CB-7808:
-
Description: 
The following error occurs when adding a local plugin that has a dependency on 
a local plugin. Most common use case is adding a test plugin that uses the 
org.apache.cordova.test-framework and adds the plugins being tested using a 
relative path (see below).

dependency id=com.blackberry.document
url=.
subdir=plugin /

dependency id=org.apache.cordova.test-framework

url=https://git-wip-us.apache.org/repos/asf/cordova-plugin-test-framework.git; 
/

[Steps to reproduce]
cordova create appTest
cordova platform add blackberry10
cordova platform add android
cordova plugin add ~/local-plugin/

Installing com.blackberry.document for blackberry10
Failed to install 'com.blackberry.document':Error: loadLocalPlugins called 
twice with different search paths.Support for this is not implemented.
at loadLocalPlugins 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:165:19)
at findLocalPlugin 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:193:5)
at Object.fetchPlugin 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:111:25)
at possiblyFetch 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:101:24)
at installDependency 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:498:16)
at 
/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:364:32
at _fulfilled 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:798:54)
at self.promiseDispatch.done 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:827:30)
at Promise.promise.promiseDispatch 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:760:13)
at /usr/local/lib/node_modules/cordova/node_modules/q/q.js:821:14
Failed to install 'com.blackberry.document.tests':Error: loadLocalPlugins 
called twice with different search paths.Support for this is not implemented.
at loadLocalPlugins 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:165:19)
at findLocalPlugin 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:193:5)
at Object.fetchPlugin 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:111:25)
at possiblyFetch 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:101:24)
at installDependency 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:498:16)
at 
/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:364:32
at _fulfilled 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:798:54)
at self.promiseDispatch.done 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:827:30)
at Promise.promise.promiseDispatch 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:760:13)
at /usr/local/lib/node_modules/cordova/node_modules/q/q.js:821:14
Error: loadLocalPlugins called twice with different search paths.Support for 
this is not implemented.
at loadLocalPlugins 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:165:19)
at findLocalPlugin 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:193:5)
at Object.fetchPlugin 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:111:25)
at possiblyFetch 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:101:24)
at installDependency 
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:498:16)
at 
/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:364:32
at _fulfilled 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:798:54)
at self.promiseDispatch.done 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:827:30)
at Promise.promise.promiseDispatch 
(/usr/local/lib/node_modules/cordova/node_modules/q/q.js:760:13)
at /usr/local/lib/node_modules/cordova/node_modules/q/q.js:821:14

  was:
The following error occurs when adding a local plugin that has a dependency on 
a local plugin. Most common use case is adding a test plugin that uses the 
org.apache.cordova.test-framework and adds the plugins being tested using a 
relative path (see below).

dependency id=com.blackberry.document
url=.
subdir=plugin /

dependency id=org.apache.cordova.test-framework

url=https://git-wip-us.apache.org/repos/asf/cordova-plugin-test-framework.git; 
/

Steps to reproduce
cordova create appTest
cordova 

[jira] [Created] (CB-6163) [BlackBerry10] NaN returned for Cordova Geolocation heading value

2014-03-04 Thread James Keshavarzi (JIRA)
James Keshavarzi created CB-6163:


 Summary: [BlackBerry10] NaN returned for Cordova Geolocation 
heading value
 Key: CB-6163
 URL: https://issues.apache.org/jira/browse/CB-6163
 Project: Apache Cordova
  Issue Type: Bug
  Components: BlackBerry
Affects Versions: 3.3.0
Reporter: James Keshavarzi


When using the mobile spec, a NaN value is returned for Heading when testing 
the Cordova Geolocation plugin using the Location test page.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (CB-6058) [BlackBerry10] Output bar file should not include the options file

2014-02-18 Thread James Keshavarzi (JIRA)
James Keshavarzi created CB-6058:


 Summary: [BlackBerry10] Output bar file should not include the 
options file
 Key: CB-6058
 URL: https://issues.apache.org/jira/browse/CB-6058
 Project: Apache Cordova
  Issue Type: Bug
  Components: BlackBerry
Affects Versions: 3.5.0
Reporter: James Keshavarzi


During building of the bar file this native/option file is included. 

This file should not be included as it contains the file structure of your 
machine as well as any additional params that you provide to the native 
packager (ie. devicepass, keystore password, ip of your device etc)

This is a security issue.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Created] (CB-5909) [BlackBerry10] check-reqs skips all checking logic on second pass-through even if there are errors

2014-01-27 Thread James Keshavarzi (JIRA)
James Keshavarzi created CB-5909:


 Summary: [BlackBerry10] check-reqs skips all checking logic on 
second pass-through even if there are errors
 Key: CB-5909
 URL: https://issues.apache.org/jira/browse/CB-5909
 Project: Apache Cordova
  Issue Type: Bug
  Components: BlackBerry
 Environment: Windows
Reporter: James Keshavarzi


Steps to reproduce:
1) Force an error in the check-reqs script (i.e. rename npm to npm2, so it 
can't find it)
2) call .\bin\check-reqs and note the error is shown correctly (npm cannot be 
found on path etc)
3) call .\bin\check-reqs again and note there is no error shown.




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Created] (CB-5283) Cordova serve server running message should be more descriptive

2013-11-05 Thread James Keshavarzi (JIRA)
James Keshavarzi created CB-5283:


 Summary: Cordova serve server running message should be more 
descriptive
 Key: CB-5283
 URL: https://issues.apache.org/jira/browse/CB-5283
 Project: Apache Cordova
  Issue Type: Improvement
  Components: CLI
Reporter: James Keshavarzi
Priority: Minor


The current message displayed from cordova serve when the server is running is 
a bit confusing to some users. Suggested message below.

Current message:
Static file server running at = http://0.0.0.0:8000/ CTRL + C to shutdown

Suggested message:
Static file server running on port 8000 (i.e http://localhost:8000) CTRL + C to 
shutdown



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Created] (CB-3830) [BlackBerry10] Refactor Packager to remove dependency on BBNDK

2013-06-14 Thread James Keshavarzi (JIRA)
James Keshavarzi created CB-3830:


 Summary: [BlackBerry10] Refactor Packager to remove dependency on 
BBNDK
 Key: CB-3830
 URL: https://issues.apache.org/jira/browse/CB-3830
 Project: Apache Cordova
  Issue Type: Bug
  Components: BlackBerry
Affects Versions: 2.8.0
Reporter: James Keshavarzi
Assignee: Lorin Beer
 Fix For: 2.9.0


The packager is currently dependent on the BBNDK and its environment variables 
to run. If you don't execute the bbndk-env script prior to running the Packager 
won't work. We need to remove this dependency.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira