[jira] [Closed] (CB-5972) update firefox os docs pages
[ https://issues.apache.org/jira/browse/CB-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Long closed CB-5972. -- Resolution: Fixed update firefox os docs pages Key: CB-5972 URL: https://issues.apache.org/jira/browse/CB-5972 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Reporter: James Long Please merge this PR: https://github.com/apache/cordova-docs/pull/183/files It adds a page for Firefox OS in the docs. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5972) update firefox os docs pages
[ https://issues.apache.org/jira/browse/CB-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947986#comment-13947986 ] James Long commented on CB-5972: Yep, it's live: http://cordova.apache.org/docs/en/3.4.0/guide_platforms_firefoxos_index.md.html#Firefox%20OS%20Platform%20Guide update firefox os docs pages Key: CB-5972 URL: https://issues.apache.org/jira/browse/CB-5972 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Reporter: James Long Please merge this PR: https://github.com/apache/cordova-docs/pull/183/files It adds a page for Firefox OS in the docs. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5033) Write tests for firefoxos in cordova-cli
[ https://issues.apache.org/jira/browse/CB-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947988#comment-13947988 ] James Long commented on CB-5033: I never really got anywhere. The tests were too confusing and it was more important to get tests for each plugin. I never figured out why a lot of the tests were failing out of the box. Write tests for firefoxos in cordova-cli Key: CB-5033 URL: https://issues.apache.org/jira/browse/CB-5033 Project: Apache Cordova Issue Type: Task Components: FirefoxOS Reporter: James Long I'm going to add firefox os to the spec/metadata folder in cordova-cli so that we can test it. Might have some questions as I go through it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6200) plugman has broken all plugins for firefoxos
James Long created CB-6200: -- Summary: plugman has broken all plugins for firefoxos Key: CB-6200 URL: https://issues.apache.org/jira/browse/CB-6200 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Reporter: James Long Somehow the firefoxos code in plugman got broken and all `plugin add` commands throw this error: Fetching plugin org.apache.cordova.camera via plugin registry Installing org.apache.cordova.camera (firefoxos) ReferenceError: xml_helpers is not defined This line here uses `xml_helpers` but it's not defined: https://github.com/apache/cordova-plugman/blob/master/src/platforms/firefoxos.js#L25. This looks like it's in the live version. Are all of our plugins broken for cordova and phonegap? This person fixed it with this PR. Please merge it: https://github.com/apache/cordova-plugman/pull/61 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-3204) initial implementation of cordova apis
[ https://issues.apache.org/jira/browse/CB-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13913275#comment-13913275 ] James Long commented on CB-3204: the contacts plugin on the dev branch was messed up and really old. We've updated it to the latest and opened a PR here: https://github.com/apache/cordova-plugin-contacts/pull/24 Can it be merged? initial implementation of cordova apis -- Key: CB-3204 URL: https://issues.apache.org/jira/browse/CB-3204 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Herm Wong Assignee: James Long -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5972) update firefox os docs pages
James Long created CB-5972: -- Summary: update firefox os docs pages Key: CB-5972 URL: https://issues.apache.org/jira/browse/CB-5972 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Reporter: James Long Please merge this PR: https://github.com/apache/cordova-docs/pull/183/files It adds a page for Firefox OS in the docs. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-3204) initial implementation of cordova apis
[ https://issues.apache.org/jira/browse/CB-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13880031#comment-13880031 ] James Long commented on CB-3204: This still hasn't been pushed. We really need to get this out. Also, this hasn't been tagged with 3.4 yet right?? The camera plugin is totally broken. initial implementation of cordova apis -- Key: CB-3204 URL: https://issues.apache.org/jira/browse/CB-3204 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Herm Wong Assignee: Herm Wong -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-4919) camera
[ https://issues.apache.org/jira/browse/CB-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873750#comment-13873750 ] James Long commented on CB-4919: Herm, you merged my changes into the dev branch but not in the main branch. We really need to get it in the main branch as the camera plugin is completely broken right now. (PR: https://github.com/apache/cordova-plugin-camera/pull/6) camera -- Key: CB-4919 URL: https://issues.apache.org/jira/browse/CB-4919 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 3.0.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.3.0 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-4919) camera
[ https://issues.apache.org/jira/browse/CB-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873774#comment-13873774 ] James Long commented on CB-4919: Ah ok, thanks. So it is happening today or tomorrow? camera -- Key: CB-4919 URL: https://issues.apache.org/jira/browse/CB-4919 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 3.0.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.3.0 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-4919) camera
[ https://issues.apache.org/jira/browse/CB-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867048#comment-13867048 ] James Long commented on CB-4919: The camera plugin is currently broken on firefoxos because it's pulling in the wrong file. I fixed it and opened a PR here: https://github.com/apache/cordova-plugin-camera/pull/6 Please merge. I don't have permissions to re-open this bug. camera -- Key: CB-4919 URL: https://issues.apache.org/jira/browse/CB-4919 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 3.0.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.3.0 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5757) contacts tests can't run on Firefox OS
James Long created CB-5757: -- Summary: contacts tests can't run on Firefox OS Key: CB-5757 URL: https://issues.apache.org/jira/browse/CB-5757 Project: Apache Cordova Issue Type: Bug Components: Plugin Contacts Reporter: James Long The contacts tests can't run on Firefox OS because contacts require a privileged app and privileged apps require CSP. Piotr has fixed this and improved the tests in this PR: https://github.com/apache/cordova-mobile-spec/pull/44. Please test this and merge. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (CB-5757) contacts tests can't run on Firefox OS
[ https://issues.apache.org/jira/browse/CB-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Long updated CB-5757: --- Issue Type: Sub-task (was: Bug) Parent: CB-3204 contacts tests can't run on Firefox OS --- Key: CB-5757 URL: https://issues.apache.org/jira/browse/CB-5757 Project: Apache Cordova Issue Type: Sub-task Components: Plugin Contacts Reporter: James Long The contacts tests can't run on Firefox OS because contacts require a privileged app and privileged apps require CSP. Piotr has fixed this and improved the tests in this PR: https://github.com/apache/cordova-mobile-spec/pull/44. Please test this and merge. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-3208) contacts
[ https://issues.apache.org/jira/browse/CB-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13840264#comment-13840264 ] James Long commented on CB-3208: Let's not mark this as resolved until all tests pass. Piotr, can you fire up the mobilespec app and run the tests and let us know if they all pass? contacts Key: CB-3208 URL: https://issues.apache.org/jira/browse/CB-3208 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.3.0 Contacts API spec: https://wiki.mozilla.org/WebAPI/ContactsAPI -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13840270#comment-13840270 ] James Long commented on CB-4966: Ok, so I guess this is resolved, and we just need to make a documentation note about including the CSS file. dialog -- Key: CB-4966 URL: https://issues.apache.org/jira/browse/CB-4966 Project: Apache Cordova Issue Type: Sub-task Components: Plugin Dialogs Environment: firefoxos Reporter: Piotr Zalewa I started developing it - only the CSS is left - no idea how to conect it to main CSS (is it needed?) https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4919) camera
[ https://issues.apache.org/jira/browse/CB-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832774#comment-13832774 ] James Long commented on CB-4919: Can this be merged in? camera -- Key: CB-4919 URL: https://issues.apache.org/jira/browse/CB-4919 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 3.0.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832771#comment-13832771 ] James Long commented on CB-4966: Steve, what is your opinion? The builtin alert is less customizable and worse, is blocking. It doesn't seem like we can offer it as it's too restricted. I wonder if there's anyway we can get the styles on the native alert though... dialog -- Key: CB-4966 URL: https://issues.apache.org/jira/browse/CB-4966 Project: Apache Cordova Issue Type: Sub-task Components: Plugin Dialogs Environment: firefoxos Reporter: Piotr Zalewa I started developing it - only the CSS is left - no idea how to conect it to main CSS (is it needed?) https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830147#comment-13830147 ] James Long commented on CB-4966: Hey guys, can you answer the above questions? dialog -- Key: CB-4966 URL: https://issues.apache.org/jira/browse/CB-4966 Project: Apache Cordova Issue Type: Sub-task Components: Plugin Dialogs Environment: firefoxos Reporter: Piotr Zalewa I started developing it - only the CSS is left - no idea how to conect it to main CSS (is it needed?) https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816443#comment-13816443 ] James Long commented on CB-3209: Thanks! There are going to be several pieces of documentation to add like that with these various APIs. I like putting it there, but how can we track the doc changes that we need to give you guys? geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815218#comment-13815218 ] James Long commented on CB-3209: Ok, I think we can close this. Piotr fixed the last bug in the plugin and the final code is here: https://github.com/jlongster/cordova-plugin-geolocation I've run all the tests and they pass: http://jlongster.com/s/geolocation-tests.png The only problem is that the user can't rely on a correct manifest.webapp being generated. They need to make a manifest.webapp in the proejct's www folder and add the geolocation permission to it. How should we communicate documentation like this to you guys? geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812910#comment-13812910 ] James Long commented on CB-3209: Yep, we need to go ahead and generate the permissions automatically. I don't know how hard it will be, but it might be easy. We need to check out how cordova specifies permissions and see if it's easy to map that. I'll look into it. geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813107#comment-13813107 ] James Long commented on CB-3209: I just did a proper implementation for geolocation on firefoxos: https://github.com/jlongster/cordova-plugin-geolocation You can see the code here: https://github.com/jlongster/cordova-plugin-geolocation/blob/master/src/firefoxos/GeolocationProxy.js The plugin.xml was missing several entries and it was completely broken before. It was never even using the plugin, so it was just using the native API. Unfortunately, I haven't been able to get it to actually work on the device yet because the native geolocation call never gives me back a position. The code should work, though. I haven't fixed the manifest.webapp permissions yet, I was just manually adding the permission. geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[
https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810663#comment-13810663
]
James Long commented on CB-3209:
Ok, looks like you have to add this to the manifest.webapp:
permissions: {
geolocation: {
description: Used to position the map to your current position
}
}
which sucks. We have to figure out how to generate the right manifest now,
instead of doing it later like we've talked about.
geolocation
---
Key: CB-3209
URL: https://issues.apache.org/jira/browse/CB-3209
Project: Apache Cordova
Issue Type: Sub-task
Components: FirefoxOS
Affects Versions: 2.6.0
Reporter: Herm Wong
Assignee: Herm Wong
Fix For: 3.2.0
geolocation spec: http://www.w3.org/TR/geolocation-API/
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808105#comment-13808105 ] James Long commented on CB-4966: The last thing needed here is the CSS. How is the user expected to pull in the CSS needed for the dialog? The plugin.xml file tells it to copy the CSS into into the app directory, but then user needs to manually add a link tag, right? How does that work cross-platform? dialog -- Key: CB-4966 URL: https://issues.apache.org/jira/browse/CB-4966 Project: Apache Cordova Issue Type: Sub-task Components: Plugin Dialogs Environment: firefoxos Reporter: Piotr Zalewa I started developing it - only the CSS is left - no idea how to conect it to main CSS (is it needed?) https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3206) vibration
[ https://issues.apache.org/jira/browse/CB-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808255#comment-13808255 ] James Long commented on CB-3206: In the code, why is this check there? if (navigator.notification.vibrate) and it errors if that check fails. vibration - Key: CB-3206 URL: https://issues.apache.org/jira/browse/CB-3206 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.1.0 -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4919) camera
[ https://issues.apache.org/jira/browse/CB-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808369#comment-13808369 ] James Long commented on CB-4919: The camera plugin was broken. The backend call should have been takePicture, not getPicture. I have committed fixes to https://github.com/jlongster/cordova-plugin-camera/tree/dev (notice it's the dev branch). With my fixes, all tests pass: http://jlongster.com/s/camera-tests.png camera -- Key: CB-4919 URL: https://issues.apache.org/jira/browse/CB-4919 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 3.0.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4967) device-motion
[ https://issues.apache.org/jira/browse/CB-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13805704#comment-13805704 ] James Long commented on CB-4967: Hey, a few more commits were added to my repo. Zalun and I fixed a few small bugs and added the timestamp (that's why the test was failing). I got the mobilespec app up and running now and am making sure all tests pass for the plugins I work on. See this: http://jlongster.com/s/accel-tests.png This bug is officially resolved. Going through the other plugins now. device-motion - Key: CB-4967 URL: https://issues.apache.org/jira/browse/CB-4967 Project: Apache Cordova Issue Type: Sub-task Components: Plugin Device Motion Environment: firefoxos Reporter: Piotr Zalewa Assignee: Steve Gill I started development of the Accelerator https://github.com/zalun/cordova-plugin-device-motion I've got issues on FxOS device, works on Android (via Firefox browser) -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4967) device-motion
[ https://issues.apache.org/jira/browse/CB-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13805705#comment-13805705 ] James Long commented on CB-4967: Mean to paste link to my repo: https://github.com/jlongster/cordova-plugin-device-motion device-motion - Key: CB-4967 URL: https://issues.apache.org/jira/browse/CB-4967 Project: Apache Cordova Issue Type: Sub-task Components: Plugin Device Motion Environment: firefoxos Reporter: Piotr Zalewa Assignee: Steve Gill I started development of the Accelerator https://github.com/zalun/cordova-plugin-device-motion I've got issues on FxOS device, works on Android (via Firefox browser) -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13805721#comment-13805721 ] James Long commented on CB-4966: All the tests pass except one: https://github.com/apache/cordova-mobile-spec/blob/master/autotest/tests/notification.tests.js#L29 How do plugin dependencies work? Do we have to add the vibration plugin for this to work? Actually, I just noticed that vibration isn't even listed as a plugin in the documentation. Is vibration a part of the notification plugin? That seems weird. dialog -- Key: CB-4966 URL: https://issues.apache.org/jira/browse/CB-4966 Project: Apache Cordova Issue Type: Sub-task Components: Plugin Dialogs Environment: firefoxos Reporter: Piotr Zalewa I started developing it - only the CSS is left - no idea how to conect it to main CSS (is it needed?) https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4967) device-motion
[ https://issues.apache.org/jira/browse/CB-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801201#comment-13801201 ] James Long commented on CB-4967: I have a working accelerometer plugin here: https://github.com/jlongster/cordova-plugin-device-motion Can you guys pull it in? device-motion - Key: CB-4967 URL: https://issues.apache.org/jira/browse/CB-4967 Project: Apache Cordova Issue Type: Sub-task Components: Plugin Device Motion Environment: firefoxos Reporter: Piotr Zalewa I started development of the Accelerator https://github.com/zalun/cordova-plugin-device-motion I've got issues on FxOS device, works on Android (via Firefox browser) -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4919) camera
[ https://issues.apache.org/jira/browse/CB-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13798440#comment-13798440 ] James Long commented on CB-4919: Why is this not reflected on github? https://github.com/apache/cordova-plugin-camera/blob/master/plugin.xml camera -- Key: CB-4919 URL: https://issues.apache.org/jira/browse/CB-4919 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 3.0.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (CB-5033) Write tests for firefoxos in cordova-cli
James Long created CB-5033: -- Summary: Write tests for firefoxos in cordova-cli Key: CB-5033 URL: https://issues.apache.org/jira/browse/CB-5033 Project: Apache Cordova Issue Type: Task Components: FirefoxOS Reporter: James Long I'm going to add firefox os to the spec/metadata folder in cordova-cli so that we can test it. Might have some questions as I go through it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-5033) Write tests for firefoxos in cordova-cli
[ https://issues.apache.org/jira/browse/CB-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790662#comment-13790662 ] James Long commented on CB-5033: I sent an email about this, but maybe this is a better place to discuss... A bunch of tests seem to be failing. It looks like iOS and android are find, but wp8 and blackberry fail. Are you guys doing continuous integration and running these tests anywhere automatically? `npm test` shouldn't have any errors, so if those platforms are deprecated or known not to be ready, they should be removed. Write tests for firefoxos in cordova-cli Key: CB-5033 URL: https://issues.apache.org/jira/browse/CB-5033 Project: Apache Cordova Issue Type: Task Components: FirefoxOS Reporter: James Long I'm going to add firefox os to the spec/metadata folder in cordova-cli so that we can test it. Might have some questions as I go through it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13784327#comment-13784327 ] James Long commented on CB-3209: Does this actually work? https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-geolocation.git;a=blob;f=src/firefoxos/GeolocationProxy.js;h=0f05f0271a51707bf68050dbd9ff39a664565ccc;hb=8840c938ea7909e7e74dd3a8e7ef61a96629b7d9 All the code does is call `win(position)`, and skips the error handler. `position` isn't even defined. geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.1.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4919) camera
[ https://issues.apache.org/jira/browse/CB-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13784409#comment-13784409 ] James Long commented on CB-4919: This isn't quite working yet. Should we not resolve these issues until they are at least mostly working? When I try to use the plugin, I get an error that CameraPopoverHandle can't be loaded. All the other platforms have this in the plugin.xml: js-module src=www/CameraPopoverHandle.js name=CameraPopoverHandle clobbers target=CameraPopoverHandle / /js-module But firefoxos doesn't. I guess we need to add it? camera -- Key: CB-4919 URL: https://issues.apache.org/jira/browse/CB-4919 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 3.0.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.1.0 -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3204) initial implementation of cordova apis
[ https://issues.apache.org/jira/browse/CB-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13784411#comment-13784411 ] James Long commented on CB-3204: I'd like to start writing tests for these. Can you all guide me on how to use your testing infrastructure? initial implementation of cordova apis -- Key: CB-3204 URL: https://issues.apache.org/jira/browse/CB-3204 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Herm Wong Assignee: Herm Wong -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3206) notification
[ https://issues.apache.org/jira/browse/CB-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13782190#comment-13782190 ] James Long commented on CB-3206: I'm confused, the commit above is referencing the Vibration API, not notifications. Piotr has done a lot of work on the notification about says he's about 90% done with it: https://github.com/zalun/cordova-plugin-dialogs I'd really like to collaborate better so that we don't duplicate work. I think it will help if we (Piotr and I) start using Jira to work with you guys. I'm in the process of updating some of the bugs with what we've done. notification Key: CB-3206 URL: https://issues.apache.org/jira/browse/CB-3206 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Steve Gill Fix For: 3.1.0 -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (CB-4957) Firefox OS platform is broken
James Long created CB-4957: -- Summary: Firefox OS platform is broken Key: CB-4957 URL: https://issues.apache.org/jira/browse/CB-4957 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Affects Versions: 3.1.0 Reporter: James Long The firefox os platform is broken in 3.1.0 because it was refactored without testing at all. The basic command cordova platform add firefoxos doesn't work. Code that references this has been wrapped in functions without rebinding this. All the code in the file should be tested. Example: https://github.com/apache/cordova-cli/blob/master/src/metadata/firefoxos_parser.js#L119 -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4957) Firefox OS platform is broken
[ https://issues.apache.org/jira/browse/CB-4957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13782246#comment-13782246 ] James Long commented on CB-4957: I agree. If you guys can write a really basic test, we can help expand it and write more. It would help to see how the testing framework works first though. Firefox OS platform is broken - Key: CB-4957 URL: https://issues.apache.org/jira/browse/CB-4957 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Affects Versions: 3.1.0 Reporter: James Long The firefox os platform is broken in 3.1.0 because it was refactored without testing at all. The basic command cordova platform add firefoxos doesn't work. Code that references this has been wrapped in functions without rebinding this. All the code in the file should be tested. Example: https://github.com/apache/cordova-cli/blob/master/src/metadata/firefoxos_parser.js#L119 -- This message was sent by Atlassian JIRA (v6.1#6144)
