[jira] [Commented] (CB-8661) executeScript doesn't return the a result on Windows platform
[
https://issues.apache.org/jira/browse/CB-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894034#comment-15894034
]
John Little commented on CB-8661:
-
Thanks for the fix
Looking at the code I see that line 323 (similar code inside the
injectScriptFile method) is implemented like this
var result = [e.target.result];
Rather than the more protected line 296 (inside the injectScriptCode method)
var result = (e && e.target) ? [e.target.result] : [null];
Both methods call the invokeScriptAsync method which may or may not return an e
and an e.target
It might be an idea to make them both the same :D
John
> executeScript doesn't return the a result on Windows platform
> -
>
> Key: CB-8661
> URL: https://issues.apache.org/jira/browse/CB-8661
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin InAppBrowser, Windows
> Environment: Windows 8
> Latest version of Cordova 4.3.0
> Latest version of Plugin InAppBrowser 0.6.0
>Reporter: John Little
>Assignee: Vladimir Kotikov
>
> executeScript is supposed to provide a variable to the function called when
> the script is completed as per this clip from the documentation :-
> If the injected script is of type code, the callback executes with a single
> parameter, which is the return value of the script, wrapped in an Array. For
> multi-line scripts, this is the return value of the last statement, or the
> last expression evaluated.
> When running as a Windows app the array is empty.
> Looking in the Windows InAppBrowserProxy.js file, line 230 looks like this
>op.oncomplete = function () { hasCallback && win([]); };
> So clearly no data is being passed ([]) is an empty array.
> According to the documentation from Microsoft :-
> https://msdn.microsoft.com/en-us/library/windows.ui.xaml.controls.webview.invokescriptasync.aspx
> The invokeScriptAsync function can return a string.
> So if I modify line 230 to look like this
> op.oncomplete = function (e) { hasCallback && win([e.target.result]); };
> I get a string returned to my callback function.
> You could also modify the similar line in the injectScriptFile function, as
> it also calls invokeScriptAsync.
> I need the return value because the only way to comunicate between the page
> in the IAB and the app is to poll some sessionStorage and wait for the page
> to set some data.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9140) Unable to build android 4.0.x when behind a proxy
[ https://issues.apache.org/jira/browse/CB-9140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711075#comment-14711075 ] John Little commented on CB-9140: - Had another go with android 4.1.1, and cordova 5.1.1 and got it to work :D I found that by using the GRADLE_OPTS enviroment variable set to this set GRADLE_OPTS=-Dhttp.proxyHost=string -Dhttp.proxyPort=# -Dhttps.proxyHost=string -Dhttps.proxyPort=# It would all work. I dont think the gradle.properties file was not used because, even though I have gradle installed (version 2.2.1, 2.4 or 2.6) and cordova requirements android reported gradel was installed i.e. Requirements check results for android: Java JDK: installed . Android SDK: installed Android target: installed android-21,android-22,android-23,Google Inc.:Google AP Is:21,Google Inc.:Google APIs:22,Google Inc.:Google APIs:23 Gradle: installed It still wanted to install a local copy of gradle 2.2.1 and I assume that gradlew doesn't use the gradle.properties file So I now have android 4.1.1 building OK. > Unable to build android 4.0.x when behind a proxy > - > > Key: CB-9140 > URL: https://issues.apache.org/jira/browse/CB-9140 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CLI >Affects Versions: 4.0.0 > Environment: windows 8.1, Cordova 5.0.0 Node.js 0.12.4, npm 2.10.1, >Reporter: John Little >Assignee: Joe Bowser > > My development enviroment is behind a proxy. I have npm and git configured to > use the proxy. However I have been unable to configure gradle to work, I have > created a gradle-wrapper.properties file and set the http.proxyHost and > http.proxyPort correctly, with no luck. > I have even changed the script that produces the gradle build files to add > the parameters to the java command line, still with no luck. > I was able to manualy download the gradle-2.2.1-all.zip and get the buld > files to use that file (rather than try to download it). Unfortunatly it then > tried to download other maven files. > The gradle documentation seems to suggest that it should work with a proxy > but I had to give up and go back to android 3.7.2 which does build using ant. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7964) Add cordova-plugin-splashscreen support for browser platform
[ https://issues.apache.org/jira/browse/CB-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593276#comment-14593276 ] John Little commented on CB-7964: - See my comment about manualy downloading 'browser' platform 3.7.0-dev. I found that this fixes the problem. Hopefully there will be a new release soon :D > Add cordova-plugin-splashscreen support for browser platform > > > Key: CB-7964 > URL: https://issues.apache.org/jira/browse/CB-7964 > Project: Apache Cordova > Issue Type: Sub-task > Components: Browser >Reporter: Sergey Shakhnazarov > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-9150) InAppBrowser executeScript excepts if no data returned on Windows Phone platform
[ https://issues.apache.org/jira/browse/CB-9150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Little updated CB-9150: Summary: InAppBrowser executeScript excepts if no data returned on Windows Phone platform (was: executeScript excepts if no data returned on Windows Phone platform) > InAppBrowser executeScript excepts if no data returned on Windows Phone > platform > > > Key: CB-9150 > URL: https://issues.apache.org/jira/browse/CB-9150 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin InAppBrowser >Affects Versions: 5.0.0 > Environment: Cordova 5.0.0, Windows 3.8.1, InAppBrowser 1.0.0 >Reporter: John Little > > The executeScript function can return data across the inteface. > When using Windows Phone 8.1 if no data is returned the current code will > except, crashing the app. > I have found the following code to solve the problem > In file InAppBrowserProxy.js > Change lines 250 and 272 from > var result = [e.target.result]; > to > var result = []; > if(e && e.target) result = [e.target.result]; -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8662) Latest release of Cordova breaks http via proxy
[ https://issues.apache.org/jira/browse/CB-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Little updated CB-8662: Environment: Windows Node.js 0.12.0 npm 2.5.1 Cordova 4.3.0 Cordova 5.0.0 was: Windows Node.js 0.12.0 npm 2.5.1 Cordova 4.3.0 Affects Version/s: 4.3.0 5.0.0 > Latest release of Cordova breaks http via proxy > --- > > Key: CB-8662 > URL: https://issues.apache.org/jira/browse/CB-8662 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 5.0.0, 4.3.0 > Environment: Windows > Node.js 0.12.0 > npm 2.5.1 > Cordova 4.3.0 > Cordova 5.0.0 >Reporter: John Little > > I work behind a squid firewall and need the HTTP_PROXY settings in the npm > config to work. > After upgrading cordova to version 4.3.0 any package add's or upgrades using > cordova would fail with the following error :- > TypeError: Request path contains unescaped characters. > After a bit of searching I found this thread which sounded like my problem :- >https://github.com/npm/npm/issues/4569 > I followed the instructions and downloaded the latest tunnel-agent and copied > the files over the ones in my nodejs install directory. > It seems that the new cordova package provides an updated request module > which is not compatible with the tunnel-agent. > After this manual upgrade every thing works ok. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9140) Unable to build android 4.0.x when behind a proxy
[ https://issues.apache.org/jira/browse/CB-9140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580743#comment-14580743 ] John Little commented on CB-9140: - I am building on Windows 8.1, I have a .gradle directory in my home directory, I also have on in the build directory for my cordova project. I have tried putting a gradle.properties in both these directories. I have also tried putting them in the version specific ones, i.e. .gradle/2.2.1 None if this made any difference. I then modified the code that creates the gradle wrapper file and added -D parameters to the java task thats run, just incase the gradle.properties files was being ignored. Again the proxy was ignored. Any help/suggestions would be greatfully recieved :D > Unable to build android 4.0.x when behind a proxy > - > > Key: CB-9140 > URL: https://issues.apache.org/jira/browse/CB-9140 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CLI >Affects Versions: 4.0.0 > Environment: windows 8.1, Cordova 5.0.0 Node.js 0.12.4, npm 2.10.1, >Reporter: John Little >Assignee: Joe Bowser > > My development enviroment is behind a proxy. I have npm and git configured to > use the proxy. However I have been unable to configure gradle to work, I have > created a gradle-wrapper.properties file and set the http.proxyHost and > http.proxyPort correctly, with no luck. > I have even changed the script that produces the gradle build files to add > the parameters to the java command line, still with no luck. > I was able to manualy download the gradle-2.2.1-all.zip and get the buld > files to use that file (rather than try to download it). Unfortunatly it then > tried to download other maven files. > The gradle documentation seems to suggest that it should work with a proxy > but I had to give up and go back to android 3.7.2 which does build using ant. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9141) Unable to use Gradle behind a proxy
[ https://issues.apache.org/jira/browse/CB-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580701#comment-14580701 ] John Little commented on CB-9141: - I created this issue https://issues.apache.org/jira/browse/CB-9140 yesterday. I tried a number of different configurations to try and get gradle to work behinde a firewall, including the one you just sent, and gave up after spending all morning trying to get it to work. At no time did I ever see squid (the proxy being used) report an access to the gradle url. It would be great if the gradle configuration could work out the proxy settings from the node/npm configuration that is working, as thats how cordova gets the android platform files :D Thanks for the reply > Unable to use Gradle behind a proxy > --- > > Key: CB-9141 > URL: https://issues.apache.org/jira/browse/CB-9141 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CLI >Affects Versions: 4.0.0 > Environment: windows 8.1, Cordova 5.0.0 Node.js 0.12.4, npm 2.10.1, >Reporter: John Little >Assignee: Joe Bowser > > After being unable to build using gradle (issues with building behind a > proxy) I tried to build using ant, the default way with the previous version. > This doesn't work as the build process fails to create required directories. > I have given up with version 4.0.x and gon back to 3.7.x -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-9150) executeScript excepts if no data returned on Windows Phone platform
John Little created CB-9150: --- Summary: executeScript excepts if no data returned on Windows Phone platform Key: CB-9150 URL: https://issues.apache.org/jira/browse/CB-9150 Project: Apache Cordova Issue Type: Bug Components: Plugin InAppBrowser Affects Versions: 5.0.0 Environment: Cordova 5.0.0, Windows 3.8.1, InAppBrowser 1.0.0 Reporter: John Little The executeScript function can return data across the inteface. When using Windows Phone 8.1 if no data is returned the current code will except, crashing the app. I have found the following code to solve the problem In file InAppBrowserProxy.js Change lines 250 and 272 from var result = [e.target.result]; to var result = []; if(e && e.target) result = [e.target.result]; -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-9141) Unable to build using ant
John Little created CB-9141: --- Summary: Unable to build using ant Key: CB-9141 URL: https://issues.apache.org/jira/browse/CB-9141 Project: Apache Cordova Issue Type: Bug Components: Android, CLI Affects Versions: 4.0.0 Environment: windows 8.1, Cordova 5.0.0 Node.js 0.12.4, npm 2.10.1, Reporter: John Little After being unable to build using gradle (issues with building behind a proxy) I tried to build using ant, the default way with the previous version. This doesn't work as the build process fails to create required directories. I have given up with version 4.0.x and gon back to 3.7.x -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-9140) Unable to build android 4.0.x when behind a proxy
John Little created CB-9140: --- Summary: Unable to build android 4.0.x when behind a proxy Key: CB-9140 URL: https://issues.apache.org/jira/browse/CB-9140 Project: Apache Cordova Issue Type: Bug Components: Android, CLI Affects Versions: 4.0.0 Environment: windows 8.1, Cordova 5.0.0 Node.js 0.12.4, npm 2.10.1, Reporter: John Little My development enviroment is behind a proxy. I have npm and git configured to use the proxy. However I have been unable to configure gradle to work, I have created a gradle-wrapper.properties file and set the http.proxyHost and http.proxyPort correctly, with no luck. I have even changed the script that produces the gradle build files to add the parameters to the java command line, still with no luck. I was able to manualy download the gradle-2.2.1-all.zip and get the buld files to use that file (rather than try to download it). Unfortunatly it then tried to download other maven files. The gradle documentation seems to suggest that it should work with a proxy but I had to give up and go back to android 3.7.2 which does build using ant. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7964) Add cordova-plugin-splashscreen support for browser platform
[ https://issues.apache.org/jira/browse/CB-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578665#comment-14578665 ] John Little commented on CB-7964: - Unfortunatly the released 'browser' platform 3.6.0 doesn't export/define 'cordova/confighelper' which the spashscreen plugin requires, so it doesn't work. I manualy downloaded the latest 'browser' platform (3.7.0-dev) and used that to solve the problem. > Add cordova-plugin-splashscreen support for browser platform > > > Key: CB-7964 > URL: https://issues.apache.org/jira/browse/CB-7964 > Project: Apache Cordova > Issue Type: Sub-task > Components: Browser >Reporter: Sergey Shakhnazarov > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8662) Latest release of Cordova breaks http via proxy
[ https://issues.apache.org/jira/browse/CB-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578661#comment-14578661 ] John Little commented on CB-8662: - Upgraded to Cordova 5.0.0 and still had the same problem. I still need to replace the contents of %APPDATA%\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\node_modules\request\node_modules\tunnel-agent with a later version 0.4.1 to get things to work, found here https://github.com/mikeal/tunnel-agent > Latest release of Cordova breaks http via proxy > --- > > Key: CB-8662 > URL: https://issues.apache.org/jira/browse/CB-8662 > Project: Apache Cordova > Issue Type: Bug > Components: CLI > Environment: Windows > Node.js 0.12.0 > npm 2.5.1 > Cordova 4.3.0 >Reporter: John Little > > I work behind a squid firewall and need the HTTP_PROXY settings in the npm > config to work. > After upgrading cordova to version 4.3.0 any package add's or upgrades using > cordova would fail with the following error :- > TypeError: Request path contains unescaped characters. > After a bit of searching I found this thread which sounded like my problem :- >https://github.com/npm/npm/issues/4569 > I followed the instructions and downloaded the latest tunnel-agent and copied > the files over the ones in my nodejs install directory. > It seems that the new cordova package provides an updated request module > which is not compatible with the tunnel-agent. > After this manual upgrade every thing works ok. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8830) application locks up when run with "cordova serve"
[
https://issues.apache.org/jira/browse/CB-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516726#comment-14516726
]
John Little commented on CB-8830:
-
I was not aware there was a "browser" platform, I used the windows one as it is
doesn't require any binarys to work. The all the windows 8.1 interfaces are in
javascript and sort of work, if they were written with try/catches arround some
of the platform specific objects they would just work.
> application locks up when run with "cordova serve"
> --
>
> Key: CB-8830
> URL: https://issues.apache.org/jira/browse/CB-8830
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Device
> Environment: windows 8.1 and OSx
> Cordova 4.3.0
>Reporter: John Little
>
> When the Device plugin is added to a cordova project and the software is
> tested using the "cordova serve" option (run a local web server for testing
> with a browser) the software locks up and fails to start.
> There is an exception in the Device plugin as below
> Exception calling native with command :: Device :: getDeviceInfo
> ::exception=ReferenceError: 'Windows' is undefined
> This is not supprising as there is no device, it's just serving the app
> through a web server.
> However the software locks up because the "onCordovaInfoReady" is never fired.
> A simple fix is to modify the device.js file as below
>channel.onCordovaReady.subscribe(function() {
> var callFailed = true; // NEW assume the getInfo fails
> me.getInfo(function(info) {
> callFailed = false; // NEW it's all good
> //ignoring info.cordova returning from native, we should use
> value from cordova.version defined in cordova.js
> //TODO: CB-5105 native implementations should not return
> info.cordova
> var buildLabel = cordova.version;
> me.available = true;
> me.platform = info.platform;
> me.version = info.version;
> me.uuid = info.uuid;
> me.cordova = buildLabel;
> me.model = info.model;
> me.manufacturer = info.manufacturer || 'unknown';
> channel.onCordovaInfoReady.fire();
> },function(e) {
> // NEW failure will be handled below
> utils.alert("[ERROR] Error initializing Cordova: " + e);
> });
> // new code to stop the system locking up
> if(callFailed) {
> me.available = false;// NEW can't be available as getInfo failed
> channel.onCordovaInfoReady.fire(); // NEW fire event to allow
> system to work
> }
> With this mod inplace the software will work, obviously the device
> information is invalid.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8857) cordova prepare doesn't change windows manifest file's version entry
[ https://issues.apache.org/jira/browse/CB-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516721#comment-14516721 ] John Little commented on CB-8857: - Hi, You are correct I was doing a build for android and iOS but a prepare for windows (don't know why I did that). When I do a build the version number is set in the manifest files. I have setup to hook files that are run as part of the "before_prepare" step. 1 script collects the version number from the config.xml file and increments the 3rd number to give a unique build number. The script also writes a version.js file so I can easily get the version number in my software (it would be nice to have the version number in the cordova object). The second script collects the version number from the config.xml file and modifes the .appxmanifest file It would be nice to have the version number automaticaly set during the prepare phase. > cordova prepare doesn't change windows manifest file's version entry > > > Key: CB-8857 > URL: https://issues.apache.org/jira/browse/CB-8857 > Project: Apache Cordova > Issue Type: Bug > Components: Windows > Environment: Cordova: 4.3.0 > Windows: 3.8.0 >Reporter: John Little > > When I build/prepare my cordova app for android or iOS the system rebuilds > the AndroidManifest.xml and .pfile. Filling in the new version number from > the config.xml file. > Unfortunatly for windows the .appxmanifest are not changed. > This means that the app version number is not updated in the manifest. > Would it be possible to have cordova rebuld/modify the windows manifest files > with the version information from the config.xml file ? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8857) cordova prepare doesn't change windows manifest file's version entry
John Little created CB-8857: --- Summary: cordova prepare doesn't change windows manifest file's version entry Key: CB-8857 URL: https://issues.apache.org/jira/browse/CB-8857 Project: Apache Cordova Issue Type: Bug Components: Windows Environment: Cordova: 4.3.0 Windows: 3.8.0 Reporter: John Little When I build/prepare my cordova app for android or iOS the system rebuilds the AndroidManifest.xml and .pfile. Filling in the new version number from the config.xml file. Unfortunatly for windows the .appxmanifest are not changed. This means that the app version number is not updated in the manifest. Would it be possible to have cordova rebuld/modify the windows manifest files with the version information from the config.xml file ? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8830) application locks up when run with "cordova serve"
[
https://issues.apache.org/jira/browse/CB-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487380#comment-14487380
]
John Little commented on CB-8830:
-
Hmm this was a little more complicated than I first thought.
I have had to put a try/catch round the first use of the Windows object in the
DeviceProxy.js for both windows and windows8. This allows the detection of the
exception and allows the software to call the fail function.
I then modified the failed function to set "me.available = false" and call
"channel.onCordovaInfoReady.fire();" which alllows the software to continue.
I also removed the "utils.alert" call, as I didn't need it.
These modifications will allow the plugin to work when using "cordova serve" in
windows mode.
> application locks up when run with "cordova serve"
> --
>
> Key: CB-8830
> URL: https://issues.apache.org/jira/browse/CB-8830
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Device
> Environment: windows 8.1 and OSx
> Cordova 4.3.0
>Reporter: John Little
>
> When the Device plugin is added to a cordova project and the software is
> tested using the "cordova serve" option (run a local web server for testing
> with a browser) the software locks up and fails to start.
> There is an exception in the Device plugin as below
> Exception calling native with command :: Device :: getDeviceInfo
> ::exception=ReferenceError: 'Windows' is undefined
> This is not supprising as there is no device, it's just serving the app
> through a web server.
> However the software locks up because the "onCordovaInfoReady" is never fired.
> A simple fix is to modify the device.js file as below
>channel.onCordovaReady.subscribe(function() {
> var callFailed = true; // NEW assume the getInfo fails
> me.getInfo(function(info) {
> callFailed = false; // NEW it's all good
> //ignoring info.cordova returning from native, we should use
> value from cordova.version defined in cordova.js
> //TODO: CB-5105 native implementations should not return
> info.cordova
> var buildLabel = cordova.version;
> me.available = true;
> me.platform = info.platform;
> me.version = info.version;
> me.uuid = info.uuid;
> me.cordova = buildLabel;
> me.model = info.model;
> me.manufacturer = info.manufacturer || 'unknown';
> channel.onCordovaInfoReady.fire();
> },function(e) {
> // NEW failure will be handled below
> utils.alert("[ERROR] Error initializing Cordova: " + e);
> });
> // new code to stop the system locking up
> if(callFailed) {
> me.available = false;// NEW can't be available as getInfo failed
> channel.onCordovaInfoReady.fire(); // NEW fire event to allow
> system to work
> }
> With this mod inplace the software will work, obviously the device
> information is invalid.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8830) application locks up when run with "cordova serve"
John Little created CB-8830:
---
Summary: application locks up when run with "cordova serve"
Key: CB-8830
URL: https://issues.apache.org/jira/browse/CB-8830
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Device
Environment: windows 8.1 and OSx
Cordova 4.3.0
Reporter: John Little
When the Device plugin is added to a cordova project and the software is tested
using the "cordova serve" option (run a local web server for testing with a
browser) the software locks up and fails to start.
There is an exception in the Device plugin as below
Exception calling native with command :: Device :: getDeviceInfo
::exception=ReferenceError: 'Windows' is undefined
This is not supprising as there is no device, it's just serving the app through
a web server.
However the software locks up because the "onCordovaInfoReady" is never fired.
A simple fix is to modify the device.js file as below
channel.onCordovaReady.subscribe(function() {
var callFailed = true; // NEW assume the getInfo fails
me.getInfo(function(info) {
callFailed = false; // NEW it's all good
//ignoring info.cordova returning from native, we should use value
from cordova.version defined in cordova.js
//TODO: CB-5105 native implementations should not return
info.cordova
var buildLabel = cordova.version;
me.available = true;
me.platform = info.platform;
me.version = info.version;
me.uuid = info.uuid;
me.cordova = buildLabel;
me.model = info.model;
me.manufacturer = info.manufacturer || 'unknown';
channel.onCordovaInfoReady.fire();
},function(e) {
// NEW failure will be handled below
utils.alert("[ERROR] Error initializing Cordova: " + e);
});
// new code to stop the system locking up
if(callFailed) {
me.available = false;// NEW can't be available as getInfo failed
channel.onCordovaInfoReady.fire(); // NEW fire event to allow system
to work
}
With this mod inplace the software will work, obviously the device information
is invalid.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8635) InAppBrowser on Windows adds 40px gray border, wrapper div without class or id
[ https://issues.apache.org/jira/browse/CB-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380157#comment-14380157 ] John Little commented on CB-8635: - Hi I know its off topic but it is relevent to the Windows IAB Have you seen issue CB-8661 ? I have a fix which allows data to be returned from the executeScript call for windows > InAppBrowser on Windows adds 40px gray border, wrapper div without class or id > -- > > Key: CB-8635 > URL: https://issues.apache.org/jira/browse/CB-8635 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin InAppBrowser >Affects Versions: 3.6.0 > Environment: Windows 8.1, Windows Phone 8.1 >Reporter: Brandon Paddock > > The InAppBrowserProxy on Windows 8.1 does some weird things. One of them is > that it adds a wrapper div with a bunch of inline styles on it, including a > gray 40px border on all sides. This appears even if you set the "location=no" > option to disable the default browser controls. > Because this div is inserted directly under the body element with no id or > class, you can't override its styling via CSS (and since it uses inline > styles, you'd have to use !important to override them). > Suggested fixes: > 1) Assign a class name to the div so it can be styled. > 2) Don't use an inline style for the default styling. Use CSS. > 3) Don't put this weird gray border in the default styling (it isn't there on > Android so why put it there on Windows?) > 4) Or, remove the div entirely (at least in the location=no case). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8635) InAppBrowser on Windows adds 40px gray border, wrapper div without class or id
[ https://issues.apache.org/jira/browse/CB-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377971#comment-14377971 ] John Little commented on CB-8635: - No I don't want the browser hidden the user needs to see the data on it. I have no need for the grey border round the outside. If I want the user to be able to close the IAB themselves I will use the "location=yes" to provide the navigation bar. I would rather the plugin didn't add the border for me just incase the user gets stuck, my app will ensure that the external content the IAB is providing is working correctly. > InAppBrowser on Windows adds 40px gray border, wrapper div without class or id > -- > > Key: CB-8635 > URL: https://issues.apache.org/jira/browse/CB-8635 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin InAppBrowser >Affects Versions: 3.6.0 > Environment: Windows 8.1, Windows Phone 8.1 >Reporter: Brandon Paddock > > The InAppBrowserProxy on Windows 8.1 does some weird things. One of them is > that it adds a wrapper div with a bunch of inline styles on it, including a > gray 40px border on all sides. This appears even if you set the "location=no" > option to disable the default browser controls. > Because this div is inserted directly under the body element with no id or > class, you can't override its styling via CSS (and since it uses inline > styles, you'd have to use !important to override them). > Suggested fixes: > 1) Assign a class name to the div so it can be styled. > 2) Don't use an inline style for the default styling. Use CSS. > 3) Don't put this weird gray border in the default styling (it isn't there on > Android so why put it there on Windows?) > 4) Or, remove the div entirely (at least in the location=no case). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8635) InAppBrowser on Windows adds 40px gray border, wrapper div without class or id
[ https://issues.apache.org/jira/browse/CB-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377904#comment-14377904 ] John Little commented on CB-8635: - I my usage I want the IAB to be invisible to the user, and I have a timer which ensures that the IAB is closed if a sessionStorage variable is not set within a certain time. The user has no need to go back because the IAB forms part of my application and there is communication between the external web (IAB) and my app. So I still have a requirement for no border arround the IAB in Windows. Also if I need the user to be able to close the IAB I would enable the navigation bar (location=yes) which is under my control! So I see no real need for the borders as the navigation bar deals with the problem, you could even have a navigation bar with only the close (X) button on. > InAppBrowser on Windows adds 40px gray border, wrapper div without class or id > -- > > Key: CB-8635 > URL: https://issues.apache.org/jira/browse/CB-8635 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin InAppBrowser >Affects Versions: 3.6.0 > Environment: Windows 8.1, Windows Phone 8.1 >Reporter: Brandon Paddock > > The InAppBrowserProxy on Windows 8.1 does some weird things. One of them is > that it adds a wrapper div with a bunch of inline styles on it, including a > gray 40px border on all sides. This appears even if you set the "location=no" > option to disable the default browser controls. > Because this div is inserted directly under the body element with no id or > class, you can't override its styling via CSS (and since it uses inline > styles, you'd have to use !important to override them). > Suggested fixes: > 1) Assign a class name to the div so it can be styled. > 2) Don't use an inline style for the default styling. Use CSS. > 3) Don't put this weird gray border in the default styling (it isn't there on > Android so why put it there on Windows?) > 4) Or, remove the div entirely (at least in the location=no case). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8635) InAppBrowser on Windows adds 40px gray border, wrapper div without class or id
[ https://issues.apache.org/jira/browse/CB-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360615#comment-14360615 ] John Little commented on CB-8635: - Hi, I am currently editing the file InAppBrowserProxy.js in the plugins\org.apache.cordova.inappbrowser\src\windows (inside my product directory) and changing lines 115-116 to remove the 40px border width so browserWrap.style.borderWidth = "40px"; browserWrap.style.width = "calc(100% - 80px)"; browserWrap.style.height = "calc(100% - 80px)"; becomes browserWrap.style.borderWidth = "00px"; browserWrap.style.width = "calc(100% - 00px)"; browserWrap.style.height = "calc(100% - 00px)"; This is fine as a temporary solution but it would be great to have a fix. > InAppBrowser on Windows adds 40px gray border, wrapper div without class or id > -- > > Key: CB-8635 > URL: https://issues.apache.org/jira/browse/CB-8635 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin InAppBrowser >Affects Versions: 3.6.0 > Environment: Windows 8.1, Windows Phone 8.1 >Reporter: Brandon Paddock > > The InAppBrowserProxy on Windows 8.1 does some weird things. One of them is > that it adds a wrapper div with a bunch of inline styles on it, including a > gray 40px border on all sides. This appears even if you set the "location=no" > option to disable the default browser controls. > Because this div is inserted directly under the body element with no id or > class, you can't override its styling via CSS (and since it uses inline > styles, you'd have to use !important to override them). > Suggested fixes: > 1) Assign a class name to the div so it can be styled. > 2) Don't use an inline style for the default styling. Use CSS. > 3) Don't put this weird gray border in the default styling (it isn't there on > Android so why put it there on Windows?) > 4) Or, remove the div entirely (at least in the location=no case). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8611) Cannot add platform with node@0.12.0 inside authenticate proxy
[
https://issues.apache.org/jira/browse/CB-8611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360371#comment-14360371
]
John Little commented on CB-8611:
-
Hi
This is the same issue as I reported yesterday, see here
https://issues.apache.org/jira/browse/CB-8662
> Cannot add platform with node@0.12.0 inside authenticate proxy
> --
>
> Key: CB-8611
> URL: https://issues.apache.org/jira/browse/CB-8611
> Project: Apache Cordova
> Issue Type: Bug
> Environment: OS: Ubuntu 14.04 LTS x64
> Cordova: 4.3.0
>Reporter: Tomo Masakura
>Priority: Critical
>
> Cannot add platform with node@0.12.0 inside authenticate proxy.
> {quote}
> $ echo $http_proxy
> http://user:p...@proxy.example.com:8080/
> $ echo $https_proxy
> http://user:p...@proxy.example.com:8080/
> $ nvm use v0.12.0
> $ npm install -g cordova@4.3.0
> $ rm -rf ~/.cordova
> $ cordova create project1
> $ cd project1
> $ cordova platform add browser
> npm http GET https://registry.npmjs.org/cordova-browser/3.6.0
> TypeError: Request path contains unescaped characters.
> at new ClientRequest (_http_client.js:73:11)
> at TunnelingAgent.exports.request (http.js:49:10)
> at TunnelingAgent.createSocket
> (/home/masakura/.nvm/versions/node/v0.12.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/npm/node_modules/request/node_modules/tunnel-agent/index.js:117:25)
> at TunnelingAgent.createSecureSocket [as createSocket]
> (/home/masakura/.nvm/versions/node/v0.12.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/npm/node_modules/request/node_modules/tunnel-agent/index.js:184:41)
> at TunnelingAgent.addRequest
> (/home/masakura/.nvm/versions/node/v0.12.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/npm/node_modules/request/node_modules/tunnel-agent/index.js:80:8)
> at new ClientRequest (_http_client.js:154:16)
> at Object.exports.request (http.js:49:10)
> at Object.exports.request (https.js:136:15)
> at Request.start
> (/home/masakura/.nvm/versions/node/v0.12.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/npm/node_modules/request/index.js:594:30)
> at Request.end
> (/home/masakura/.nvm/versions/node/v0.12.0/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/npm/node_modules/request/index.js:1186:28)
> {quote}
> - node@0.10.36 is OK
> - cordova@4.2.0 and node@0.12.0 is OK
> - Same problem with OS X (Yosemite)
> - "cordova platform add android" is NG
> - "cordova plugin add org.apache.cordova.camera" is OK
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8662) Latest release of Cordova breaks http via proxy
John Little created CB-8662: --- Summary: Latest release of Cordova breaks http via proxy Key: CB-8662 URL: https://issues.apache.org/jira/browse/CB-8662 Project: Apache Cordova Issue Type: Bug Components: CLI Environment: Windows Node.js 0.12.0 npm 2.5.1 Cordova 4.3.0 Reporter: John Little I work behind a squid firewall and need the HTTP_PROXY settings in the npm config to work. After upgrading cordova to version 4.3.0 any package add's or upgrades using cordova would fail with the following error :- TypeError: Request path contains unescaped characters. After a bit of searching I found this thread which sounded like my problem :- https://github.com/npm/npm/issues/4569 I followed the instructions and downloaded the latest tunnel-agent and copied the files over the ones in my nodejs install directory. It seems that the new cordova package provides an updated request module which is not compatible with the tunnel-agent. After this manual upgrade every thing works ok. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8661) executeScript doesn't return the a result on Windows platform
John Little created CB-8661:
---
Summary: executeScript doesn't return the a result on Windows
platform
Key: CB-8661
URL: https://issues.apache.org/jira/browse/CB-8661
Project: Apache Cordova
Issue Type: Bug
Components: Plugin InAppBrowser, Windows
Environment: Windows 8
Latest version of Cordova 4.3.0
Latest version of Plugin InAppBrowser 0.6.0
Reporter: John Little
executeScript is supposed to provide a variable to the function called when the
script is completed as per this clip from the documentation :-
If the injected script is of type code, the callback executes with a single
parameter, which is the return value of the script, wrapped in an Array. For
multi-line scripts, this is the return value of the last statement, or the last
expression evaluated.
When running as a Windows app the array is empty.
Looking in the Windows InAppBrowserProxy.js file, line 230 looks like this
op.oncomplete = function () { hasCallback && win([]); };
So clearly no data is being passed ([]) is an empty array.
According to the documentation from Microsoft :-
https://msdn.microsoft.com/en-us/library/windows.ui.xaml.controls.webview.invokescriptasync.aspx
The invokeScriptAsync function can return a string.
So if I modify line 230 to look like this
op.oncomplete = function (e) { hasCallback && win([e.target.result]); };
I get a string returned to my callback function.
You could also modify the similar line in the injectScriptFile function, as it
also calls invokeScriptAsync.
I need the return value because the only way to comunicate between the page in
the IAB and the app is to poll some sessionStorage and wait for the page to set
some data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
