[jira] [Created] (CB-9080) Cordova CLI run for Android versions 4.1.x throws error
Josh Bavari created CB-9080: --- Summary: Cordova CLI run for Android versions 4.1.x throws error Key: CB-9080 URL: https://issues.apache.org/jira/browse/CB-9080 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 5.0.0 Environment: Cordova CLI 5.0.0 Cordova Lib 5.0.0 Mac Yosemite 10.10.2 Android platform tools 22 Android 4.1 Reporter: Josh Bavari Priority: Minor When running `cordova run android` and an Android v4.1 device connected, the `adb` command fails. You can read more about the error on the Ionic CLI issues, as ionic calls cordova: https://github.com/driftyco/ionic-cli/issues/441 Looking at the source code, the `device.js` file will try to run this command: 'adb install -s ' + resolvedTarget.target + ' -r -d ' + apk_path + '' As you can see, it passes the -d option, which works fine for most android 4.2+ devices. However, when Android 4.1 is involved, this error occurs: ``` BUILD SUCCESSFUL Total time: 2.551 secs Built the following apk(s): /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk Using apk: /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk Installing app on device... Running this command to install app to device: adb -s 192.168.56.102: install -r -d /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk OUTPUT: Error: Unknown option: -d usage: pm list packages [-f] [-d] [-e] [-s] [-3] [-i] [-u] [FILTER] pm list permission-groups pm list permissions [-g] [-f] [-d] [-u] [GROUP] pm list instrumentation [-f] [TARGET-PACKAGE] pm list features pm list libraries pm path PACKAGE pm install [-l] [-r] [-t] [-i INSTALLER_PACKAGE_NAME] [-s] [-f] [--algo algorithm name --key key-in-hex --iv IV-in-hex] PATH pm uninstall [-k] PACKAGE pm clear PACKAGE pm enable PACKAGE_OR_COMPONENT pm disable PACKAGE_OR_COMPONENT pm disable-user PACKAGE_OR_COMPONENT pm grant PACKAGE PERMISSION pm revoke PACKAGE PERMISSION pm set-install-location [0/auto] [1/internal] [2/external] pm get-install-location pm set-permission-enforced PERMISSION [true|false] ``` Now when I run with an Android 4.4 device attached: ``` Total time: 2.585 secs Built the following apk(s): /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk Using apk: /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk Installing app on device... Running this command to install app to device: adb -s 192.168.56.101: install -r -d /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk OUTPUT: pkg: /data/local/tmp/android-debug.apk Success Launching application... LAUNCH SUCCESS ``` My guess here is that this is an issue with the `adb` tool. Can anyone else confirm this is an issue? The adb tool does not work with `-d` on Android 4.1. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9080) Cordova CLI run for Android versions 4.1.x throws error
[ https://issues.apache.org/jira/browse/CB-9080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561232#comment-14561232 ] Josh Bavari commented on CB-9080: - In Cordova CLI 4.3.0 - this issue does not exist. Cordova Android 4.0.0: https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/device.js#L101 Cordova Android 3.7.0: https://github.com/apache/cordova-android/blob/3.7.1/bin/templates/cordova/lib/device.js#L103 As you can see - the `-d` flag was introduced in Android 4.0.0. Cordova CLI run for Android versions 4.1.x throws error --- Key: CB-9080 URL: https://issues.apache.org/jira/browse/CB-9080 Project: Apache Cordova Issue Type: Bug Components: Android, CLI Affects Versions: 5.0.0 Environment: Cordova CLI 5.0.0 Cordova Lib 5.0.0 Mac Yosemite 10.10.2 Android platform tools 22 Android 4.1 Reporter: Josh Bavari Priority: Minor When running `cordova run android` and an Android v4.1 device connected, the `adb` command fails. You can read more about the error on the Ionic CLI issues, as ionic calls cordova: https://github.com/driftyco/ionic-cli/issues/441 Looking at the source code, the `device.js` file will try to run this command: 'adb install -s ' + resolvedTarget.target + ' -r -d ' + apk_path + '' As you can see, it passes the -d option, which works fine for most android 4.2+ devices. However, when Android 4.1 is involved, this error occurs: ``` BUILD SUCCESSFUL Total time: 2.551 secs Built the following apk(s): /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk Using apk: /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk Installing app on device... Running this command to install app to device: adb -s 192.168.56.102: install -r -d /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk OUTPUT: Error: Unknown option: -d usage: pm list packages [-f] [-d] [-e] [-s] [-3] [-i] [-u] [FILTER] pm list permission-groups pm list permissions [-g] [-f] [-d] [-u] [GROUP] pm list instrumentation [-f] [TARGET-PACKAGE] pm list features pm list libraries pm path PACKAGE pm install [-l] [-r] [-t] [-i INSTALLER_PACKAGE_NAME] [-s] [-f] [--algo algorithm name --key key-in-hex --iv IV-in-hex] PATH pm uninstall [-k] PACKAGE pm clear PACKAGE pm enable PACKAGE_OR_COMPONENT pm disable PACKAGE_OR_COMPONENT pm disable-user PACKAGE_OR_COMPONENT pm grant PACKAGE PERMISSION pm revoke PACKAGE PERMISSION pm set-install-location [0/auto] [1/internal] [2/external] pm get-install-location pm set-permission-enforced PERMISSION [true|false] ``` Now when I run with an Android 4.4 device attached: ``` Total time: 2.585 secs Built the following apk(s): /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk Using apk: /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk Installing app on device... Running this command to install app to device: adb -s 192.168.56.101: install -r -d /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk OUTPUT: pkg: /data/local/tmp/android-debug.apk Success Launching application... LAUNCH SUCCESS ``` My guess here is that this is an issue with the `adb` tool. Can anyone else confirm this is an issue? The adb tool does not work with `-d` on Android 4.1. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-9080) Cordova CLI run for Android versions 4.1.x throws error
[ https://issues.apache.org/jira/browse/CB-9080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Bavari updated CB-9080: Component/s: Android Cordova CLI run for Android versions 4.1.x throws error --- Key: CB-9080 URL: https://issues.apache.org/jira/browse/CB-9080 Project: Apache Cordova Issue Type: Bug Components: Android, CLI Affects Versions: 5.0.0 Environment: Cordova CLI 5.0.0 Cordova Lib 5.0.0 Mac Yosemite 10.10.2 Android platform tools 22 Android 4.1 Reporter: Josh Bavari Priority: Minor When running `cordova run android` and an Android v4.1 device connected, the `adb` command fails. You can read more about the error on the Ionic CLI issues, as ionic calls cordova: https://github.com/driftyco/ionic-cli/issues/441 Looking at the source code, the `device.js` file will try to run this command: 'adb install -s ' + resolvedTarget.target + ' -r -d ' + apk_path + '' As you can see, it passes the -d option, which works fine for most android 4.2+ devices. However, when Android 4.1 is involved, this error occurs: ``` BUILD SUCCESSFUL Total time: 2.551 secs Built the following apk(s): /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk Using apk: /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk Installing app on device... Running this command to install app to device: adb -s 192.168.56.102: install -r -d /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk OUTPUT: Error: Unknown option: -d usage: pm list packages [-f] [-d] [-e] [-s] [-3] [-i] [-u] [FILTER] pm list permission-groups pm list permissions [-g] [-f] [-d] [-u] [GROUP] pm list instrumentation [-f] [TARGET-PACKAGE] pm list features pm list libraries pm path PACKAGE pm install [-l] [-r] [-t] [-i INSTALLER_PACKAGE_NAME] [-s] [-f] [--algo algorithm name --key key-in-hex --iv IV-in-hex] PATH pm uninstall [-k] PACKAGE pm clear PACKAGE pm enable PACKAGE_OR_COMPONENT pm disable PACKAGE_OR_COMPONENT pm disable-user PACKAGE_OR_COMPONENT pm grant PACKAGE PERMISSION pm revoke PACKAGE PERMISSION pm set-install-location [0/auto] [1/internal] [2/external] pm get-install-location pm set-permission-enforced PERMISSION [true|false] ``` Now when I run with an Android 4.4 device attached: ``` Total time: 2.585 secs Built the following apk(s): /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk Using apk: /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk Installing app on device... Running this command to install app to device: adb -s 192.168.56.101: install -r -d /Users/JoshBavari/Development/testing/s1/platforms/android/build/outputs/apk/android-debug.apk OUTPUT: pkg: /data/local/tmp/android-debug.apk Success Launching application... LAUNCH SUCCESS ``` My guess here is that this is an issue with the `adb` tool. Can anyone else confirm this is an issue? The adb tool does not work with `-d` on Android 4.1. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-6414) Cordova plugman will ignore config_munge features for config.xml if two are listed in plugin.xml
Josh Bavari created CB-6414:
---
Summary: Cordova plugman will ignore config_munge features for
config.xml if two are listed in plugin.xml
Key: CB-6414
URL: https://issues.apache.org/jira/browse/CB-6414
Project: Apache Cordova
Issue Type: Bug
Components: Plugman
Affects Versions: 3.4.0
Environment: Android
Reporter: Josh Bavari
Assignee: Josh Bavari
Priority: Minor
When using a phonegap plugin like the Facebook Connect plugin, there are two
series of listed config transforms, as such:
The config-file element,
config-file target=config.xml parent=/*
access origin=https://m.facebook.com; /
access origin=https://graph.facebook.com; /
access origin=https://api.facebook.com; /
access origin=https://*.fbcdn.net; /
access origin=https://*.akamaihd.net; /
/config-file
As well as the transform for Android:
config-file target=config.xml parent=/*
feature name=FacebookConnectPlugin
param name=android-package
value=org.apache.cordova.facebook.ConnectPlugin /
/feature
/config-file
Which after running 'cordova prepare android':
config_munge: {
res/xml/config.xml: {
/*: {
feature name=\Camera\param name=\android-package\
value=\org.apache.cordova.camera.CameraLauncher\ //feature: 1,
feature name=\Contacts\param name=\android-package\
value=\org.apache.cordova.contacts.ContactManager\ //feature: 1,
feature name=\Device\param name=\android-package\
value=\org.apache.cordova.device.Device\ //feature: 1,
feature name=\Notification\param name=\android-package\
value=\org.apache.cordova.dialogs.Notification\ //feature: 1,
feature name=\File\param name=\android-package\
value=\org.apache.cordova.file.FileUtils\ /param name=\onload\
value=\true\ //feature: 1,
feature name=\FileTransfer\param name=\android-package\
value=\org.apache.cordova.filetransfer.FileTransfer\ //feature: 1,
feature name=\Geolocation\param name=\android-package\
value=\org.apache.cordova.geolocation.GeoBroker\ //feature: 1,
feature name=\InAppBrowser\param name=\android-package\
value=\org.apache.cordova.inappbrowser.InAppBrowser\ //feature: 1,
feature name=\Media\param name=\android-package\
value=\org.apache.cordova.media.AudioHandler\ //feature: 1,
feature name=\Capture\param name=\android-package\
value=\org.apache.cordova.mediacapture.Capture\ //feature: 1,
feature name=\NetworkStatus\param
name=\android-package\
value=\org.apache.cordova.networkinformation.NetworkManager\ //feature: 1,
feature name=\SplashScreen\param name=\android-package\
value=\org.apache.cordova.splashscreen.SplashScreen\ //feature: 1
}
},
AndroidManifest.xml: {
/*: {
uses-permission
android:name=\android.permission.WRITE_EXTERNAL_STORAGE\ /: 5,
uses-permission
android:name=\android.permission.READ_CONTACTS\ /: 1,
uses-permission
android:name=\android.permission.WRITE_CONTACTS\ /: 1,
uses-permission
android:name=\android.permission.GET_ACCOUNTS\ /: 1,
uses-permission
android:name=\android.permission.ACCESS_COARSE_LOCATION\ /: 1,
uses-permission
android:name=\android.permission.ACCESS_FINE_LOCATION\ /: 1,
uses-permission
android:name=\android.permission.RECORD_AUDIO\ /: 2,
uses-permission
android:name=\android.permission.MODIFY_AUDIO_SETTINGS\ /: 1,
uses-permission
android:name=\android.permission.READ_PHONE_STATE\ /: 1,
uses-permission
android:name=\android.permission.RECORD_VIDEO\ /: 1,
uses-permission
android:name=\android.permission.ACCESS_NETWORK_STATE\ /: 1
},
application: {
meta-data android:name=\com.facebook.sdk.ApplicationId\
android:value=\@string/fb_app_id\ /: 1,
activity android:label=\@string/fb_app_name\
android:name=\com.facebook.LoginActivity\ /: 1
}
},
res/values/facebookconnect.xml: {
/*: {
string name=\fb_app_id\448/string: 1,
string name=\fb_app_name\RaiseMore/string: 1
}
},
config.xml: {
/*: {
access origin=\https://m.facebook.com\; /: 1,
access origin=\https://graph.facebook.com\; /: 1,
access origin=\https://api.facebook.com\; /: 1,
access origin=\https://*.fbcdn.net\; /: 1,
access origin=\https://*.akamaihd.net\; /: 1,
feature name=\FacebookConnectPlugin\param
[jira] [Commented] (CB-6414) Cordova plugman will ignore config_munge features for config.xml if two are listed in plugin.xml
[
https://issues.apache.org/jira/browse/CB-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963357#comment-13963357
]
Josh Bavari commented on CB-6414:
-
Steps to reproduce:
cordova create AndroidBug
cd AndroidBug
cordova platform add android
cordova plugin add https://github.com/phonegap/phonegap-facebook-plugin.git
--variable APP_ID='443' --variable APP_NAME='App'
cordova plugin add org.apache.cordova.camera
cordova plugin add org.apache.cordova.console
cordova plugin add org.apache.cordova.contacts
cordova plugin add org.apache.cordova.device
cordova plugin add org.apache.cordova.dialogs
cordova plugin add org.apache.cordova.file
cordova prepare android
Now - view platforms/android/res/xml/config.xml - you will only see the
feature elements for Android's Facebook plugin
This has been verified by Steve and Andrew.
Cordova plugman will ignore config_munge features for config.xml if two are
listed in plugin.xml
Key: CB-6414
URL: https://issues.apache.org/jira/browse/CB-6414
Project: Apache Cordova
Issue Type: Bug
Components: Plugman
Affects Versions: 3.4.0
Environment: Android
Reporter: Josh Bavari
Assignee: Josh Bavari
Priority: Minor
Original Estimate: 2h
Remaining Estimate: 2h
When using a phonegap plugin like the Facebook Connect plugin, there are two
series of listed config transforms, as such:
The config-file element,
config-file target=config.xml parent=/*
access origin=https://m.facebook.com; /
access origin=https://graph.facebook.com; /
access origin=https://api.facebook.com; /
access origin=https://*.fbcdn.net; /
access origin=https://*.akamaihd.net; /
/config-file
As well as the transform for Android:
config-file target=config.xml parent=/*
feature name=FacebookConnectPlugin
param name=android-package
value=org.apache.cordova.facebook.ConnectPlugin /
/feature
/config-file
Which after running 'cordova prepare android':
config_munge: {
res/xml/config.xml: {
/*: {
feature name=\Camera\param name=\android-package\
value=\org.apache.cordova.camera.CameraLauncher\ //feature: 1,
feature name=\Contacts\param name=\android-package\
value=\org.apache.cordova.contacts.ContactManager\ //feature: 1,
feature name=\Device\param name=\android-package\
value=\org.apache.cordova.device.Device\ //feature: 1,
feature name=\Notification\param
name=\android-package\ value=\org.apache.cordova.dialogs.Notification\
//feature: 1,
feature name=\File\param name=\android-package\
value=\org.apache.cordova.file.FileUtils\ /param name=\onload\
value=\true\ //feature: 1,
feature name=\FileTransfer\param
name=\android-package\
value=\org.apache.cordova.filetransfer.FileTransfer\ //feature: 1,
feature name=\Geolocation\param
name=\android-package\ value=\org.apache.cordova.geolocation.GeoBroker\
//feature: 1,
feature name=\InAppBrowser\param
name=\android-package\
value=\org.apache.cordova.inappbrowser.InAppBrowser\ //feature: 1,
feature name=\Media\param name=\android-package\
value=\org.apache.cordova.media.AudioHandler\ //feature: 1,
feature name=\Capture\param name=\android-package\
value=\org.apache.cordova.mediacapture.Capture\ //feature: 1,
feature name=\NetworkStatus\param
name=\android-package\
value=\org.apache.cordova.networkinformation.NetworkManager\ //feature:
1,
feature name=\SplashScreen\param
name=\android-package\
value=\org.apache.cordova.splashscreen.SplashScreen\ //feature: 1
}
},
AndroidManifest.xml: {
/*: {
uses-permission
android:name=\android.permission.WRITE_EXTERNAL_STORAGE\ /: 5,
uses-permission
android:name=\android.permission.READ_CONTACTS\ /: 1,
uses-permission
android:name=\android.permission.WRITE_CONTACTS\ /: 1,
uses-permission
android:name=\android.permission.GET_ACCOUNTS\ /: 1,
uses-permission
android:name=\android.permission.ACCESS_COARSE_LOCATION\ /: 1,
uses-permission
android:name=\android.permission.ACCESS_FINE_LOCATION\ /: 1,
uses-permission
android:name=\android.permission.RECORD_AUDIO\ /: 2,
uses-permission
android:name=\android.permission.MODIFY_AUDIO_SETTINGS\ /: 1,
uses-permission
android:name=\android.permission.READ_PHONE_STATE\ /: 1,
uses-permission
[jira] [Commented] (CB-6406) Orientation=portrait in config.xml causes problems
[ https://issues.apache.org/jira/browse/CB-6406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963361#comment-13963361 ] Josh Bavari commented on CB-6406: - I can confirm, this is working in the latest version. I ran into this, and upon getting master version of cli, it is corrected. Orientation=portrait in config.xml causes problems -- Key: CB-6406 URL: https://issues.apache.org/jira/browse/CB-6406 Project: Apache Cordova Issue Type: Bug Components: Android, CLI Reporter: Mateusz Mucha When config.xml contains preference name=Orientation value=portrait /, cordova prepare android (don't know about other platforms, will try it on mac/ios when I get back home) produces an error: muszek@dziobak:~/pgpc2$ cordova prepare [ReferenceError: a is not defined] muszek@dziobak:~/pgpc2$ The app is built and seems to function well (in fact I noticed the problem two weeks after I added the problematic entry in config.xml). The only side effect I noticed is that AndroidManifest.xml is not updated (at least android:versionName is not overwritten). I confirmed it on the freshly created repository. Here's the recording: http://asciinema.org/a/8671 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6401) org.apache.geolocation plugin fails silently
[ https://issues.apache.org/jira/browse/CB-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963363#comment-13963363 ] Josh Bavari commented on CB-6401: - Riku, what other plugins are you using? Would you mind showing those as well? org.apache.geolocation plugin fails silently Key: CB-6401 URL: https://issues.apache.org/jira/browse/CB-6401 Project: Apache Cordova Issue Type: Bug Components: Plugin Geolocation Affects Versions: 3.4.0 Reporter: Riku Raisanen geolocation fails silently on Android 4.4.2. After hours of debugging, I finally got it to work with the code on the dev branch for the plugin works (uses browsers geolocation instead of native one). With the master branch code, for whatever reason the res/xml/config.xml doesn't add the feature line: feature name=Geolocationparam name=android-package value=org.apache.cordova.geolocation.GeoBroker //feature and thus the geolocation silently fails. If I manually added the file and compiled an APK off of that, then geolocation worked again. Geolocation is a very central feature of phone apps, I can't understand how an issue like this would go unnoticed/unfixed for so long. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Bavari resolved CB-6279. - Resolution: Fixed Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6283) Add sorting options
[ https://issues.apache.org/jira/browse/CB-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960127#comment-13960127 ] Josh Bavari commented on CB-6283: - I'll get the download sorting fixed. Was going to wait on the combination, but for the sake of shipping, I will probably just get sorting for downloads working on search. Add sorting options --- Key: CB-6283 URL: https://issues.apache.org/jira/browse/CB-6283 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari Download count sorting, etc -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954692#comment-13954692 ] Josh Bavari commented on CB-6279: - Fixed the filters, improved styling, and removed the icons. Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6283) Add sorting options
[ https://issues.apache.org/jira/browse/CB-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954798#comment-13954798 ] Josh Bavari commented on CB-6283: - Ended up using basic Angular orderBy attribute and adding in the orderValue to the scope of the search controller. Easily now does sorting by ID and downloads. Add sorting options --- Key: CB-6283 URL: https://issues.apache.org/jira/browse/CB-6283 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari Download count sorting, etc -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6281) Expose more information on plugin details + style
[ https://issues.apache.org/jira/browse/CB-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954882#comment-13954882 ] Josh Bavari commented on CB-6281: - Ok - got the install command looking pretty. Styled the version drop down. Added in the Side bar for downloads, last updated, version, engine number, and license. Expose more information on plugin details + style - Key: CB-6281 URL: https://issues.apache.org/jira/browse/CB-6281 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951352#comment-13951352 ] Josh Bavari commented on CB-6279: - Cancel that last comment - ill get them since im on the task. Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951350#comment-13951350 ] Josh Bavari commented on CB-6279: - I hear and comply. You removing or me? Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946975#comment-13946975 ] Josh Bavari commented on CB-6279: - Yea, I'll push it up to my repo and send a PR. Yep. I'm using an angular filter for it. One caveat to it - if the user who submitted the plugin didnt specify platform, then it wont be able to be filtered. I put a message up when you click filters that states this so the user is not left wondering. Not much we can do about that. Ive noticed though that going forward there are more platforms specified. Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6286) Set results limit on search results and view all
[ https://issues.apache.org/jira/browse/CB-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946977#comment-13946977 ] Josh Bavari commented on CB-6286: - Not too worried about it, just wasn't sure where you stood on it. Set results limit on search results and view all Key: CB-6286 URL: https://issues.apache.org/jira/browse/CB-6286 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Environment: Need to add view next 25 results to the end of the viewAll page. This way we aren't retrieving all of the plugins before displaying. Reporter: Steve Gill -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6284) Add tests
[ https://issues.apache.org/jira/browse/CB-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946976#comment-13946976 ] Josh Bavari commented on CB-6284: - Awesome. I love karma. Its great. I was also looking through NPMjs's repo at their tests and how they test/mock out their couchDB instance. Check this out: https://github.com/npm/npmjs.org/tree/master/test Add tests - Key: CB-6284 URL: https://issues.apache.org/jira/browse/CB-6284 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill The site needs testing! -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6282) Add documentation publishing plugins + installing removing plugins
[ https://issues.apache.org/jira/browse/CB-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946978#comment-13946978 ] Josh Bavari commented on CB-6282: - You bet. Tell me a time and I'll make it work. Add documentation publishing plugins + installing removing plugins -- Key: CB-6282 URL: https://issues.apache.org/jira/browse/CB-6282 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill The home page has two spots for links to documentation. Need to create these pages and write the content for them. Some of the content for publishing plugins already exists in the plugman readme. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946992#comment-13946992 ] Josh Bavari commented on CB-6279: - Steve, I sent the PR to Github. I'm sorry its huge! A lot has changed since you were gone. Let me know if you need anything. Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6281) Expose more information on plugin details + style
[ https://issues.apache.org/jira/browse/CB-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947005#comment-13947005 ] Josh Bavari commented on CB-6281: - Yep, I have it replicated and everything. The 'most downloads' works fine. But something is bonkers with updated. It works on my other machine, just not my main machine. We can talk about it tomorrow if you want. Expose more information on plugin details + style - Key: CB-6281 URL: https://issues.apache.org/jira/browse/CB-6281 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-6285) Performance optimization review
[ https://issues.apache.org/jira/browse/CB-6285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Bavari reassigned CB-6285: --- Assignee: Josh Bavari Performance optimization review --- Key: CB-6285 URL: https://issues.apache.org/jira/browse/CB-6285 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Environment: The site needs a look over for ways to improve performance. Some of the views could be using more appropriate limits for document retrieval. Some new views can be written, etc. Need to identify and fix. Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6285) Performance optimization review
[
https://issues.apache.org/jira/browse/CB-6285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944754#comment-13944754
]
Josh Bavari commented on CB-6285:
-
Going ahead and owning this. Wrote a new view for searching / view all. Really
on those searches, we only need to pull back the following fields for the
search grid:
ID
Name
Description
Platforms
Engines (would be helpful)
Download count
Then for the plugin details, it would need a view that then contains all the
versions as it currently stands.
Something like this:
function searcher(doc) {
if (doc['dist-tags'] doc['dist-tags'].latest) {
var dist = doc.versions[doc['dist-tags'].latest];
//We have latest version, now get the platforms available.
var engines = dist dist.engines ? dist.engines : '';
var platforms = dist dist.platforms ? dist.platforms : '';
var downloads = 0; // todo: get proper download count
var obj = {
name: doc.name
, description: doc.description
, version: doc.dist
, downloads: downloads
, platforms: platforms
, engines: engines
};
emit(doc._id, obj);
}
}
Performance optimization review
---
Key: CB-6285
URL: https://issues.apache.org/jira/browse/CB-6285
Project: Apache Cordova
Issue Type: Sub-task
Components: Registry, Registry Web
Environment: The site needs a look over for ways to improve
performance. Some of the views could be using more appropriate limits for
document retrieval. Some new views can be written, etc. Need to identify and
fix.
Reporter: Steve Gill
Assignee: Josh Bavari
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6281) Expose more information on plugin details + style
[ https://issues.apache.org/jira/browse/CB-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944154#comment-13944154 ] Josh Bavari commented on CB-6281: - Cleaned up styles to look like the design. Only missing the Downloads section on the right side in gray. For some reason, the downloads dont work properly on my local CouchDB instance. That is the only reason I haven't gotten the downloads to show properly. Expose more information on plugin details + style - Key: CB-6281 URL: https://issues.apache.org/jira/browse/CB-6281 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6281) Expose more information on plugin details + style
[ https://issues.apache.org/jira/browse/CB-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944155#comment-13944155 ] Josh Bavari commented on CB-6281: - Also, added in the platforms, the contributors, cordova cli command to install the plugin, and the keywords to the plugin details page. Expose more information on plugin details + style - Key: CB-6281 URL: https://issues.apache.org/jira/browse/CB-6281 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-5817) Implement Site Layout in CSS Framework
[ https://issues.apache.org/jira/browse/CB-5817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Bavari reassigned CB-5817: --- Assignee: Josh Bavari Implement Site Layout in CSS Framework -- Key: CB-5817 URL: https://issues.apache.org/jira/browse/CB-5817 Project: Apache Cordova Issue Type: New Feature Components: Registry Web Reporter: Josh Bavari Assignee: Josh Bavari Original Estimate: 24h Remaining Estimate: 24h Implement the sites layout in a CSS framework (Steve was mentioning using TopCoat instead of Bootstrap) This task will involve all subtasks for its tasks. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Bavari reassigned CB-6279: --- Assignee: Josh Bavari Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944188#comment-13944188 ] Josh Bavari commented on CB-6279: - I have added filters on the search page. The filters added were ios, android, windows phone 7, windows phone 8, windows 8, ubuntu, and firefox os. I have added custom icons for these as well. I was going to add in those same icons in the grid so users can see at a distance what plugin is available for what platform without filtering. Is that ok [~stevegill]? Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6286) Set results limit on search results and view all
[ https://issues.apache.org/jira/browse/CB-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944187#comment-13944187 ] Josh Bavari commented on CB-6286: - Steve, I've worked in the filters on the search results - do you want me to tie in paging to the results or have you already started that? Set results limit on search results and view all Key: CB-6286 URL: https://issues.apache.org/jira/browse/CB-6286 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Environment: Need to add view next 25 results to the end of the viewAll page. This way we aren't retrieving all of the plugins before displaying. Reporter: Steve Gill -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-6283) Add sorting options
[ https://issues.apache.org/jira/browse/CB-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Bavari reassigned CB-6283: --- Assignee: Josh Bavari Add sorting options --- Key: CB-6283 URL: https://issues.apache.org/jira/browse/CB-6283 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari Download count sorting, etc -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6283) Add sorting options
[ https://issues.apache.org/jira/browse/CB-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944190#comment-13944190 ] Josh Bavari commented on CB-6283: - Thinking about switching the results using ng-grid. This gives a ton of sorting, paging, and other niceties we could use instead of just using the standard angular ng-repeat directive. Link for ng-grid: http://angular-ui.github.io/ng-grid/ Add sorting options --- Key: CB-6283 URL: https://issues.apache.org/jira/browse/CB-6283 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Download count sorting, etc -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6285) Performance optimization review
[ https://issues.apache.org/jira/browse/CB-6285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944196#comment-13944196 ] Josh Bavari commented on CB-6285: - I've been digging into couchDB the last few days. I've looked over how we can rework some of our views as well as how we can implement paging on the server. Also, some of our views aren't consistent. We are expecting view results from the search view to be the same as the _all_docs view, in which case they are not. I'll link more performance links as I get them. Performance optimization review --- Key: CB-6285 URL: https://issues.apache.org/jira/browse/CB-6285 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Environment: The site needs a look over for ways to improve performance. Some of the views could be using more appropriate limits for document retrieval. Some new views can be written, etc. Need to identify and fix. Reporter: Steve Gill -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6282) Add documentation publishing plugins + installing removing plugins
[ https://issues.apache.org/jira/browse/CB-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944198#comment-13944198 ] Josh Bavari commented on CB-6282: - I would love to contribute to this. When you get back steve, lets chat about this. Add documentation publishing plugins + installing removing plugins -- Key: CB-6282 URL: https://issues.apache.org/jira/browse/CB-6282 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill The home page has two spots for links to documentation. Need to create these pages and write the content for them. Some of the content for publishing plugins already exists in the plugman readme. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6284) Add tests
[ https://issues.apache.org/jira/browse/CB-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944199#comment-13944199 ] Josh Bavari commented on CB-6284: - As far as tests are concerned, what issues do we want to tackle and what is the priority for each? I can go ahead and get started with some Javascript tests for our controllers and services. Do we also want some automated API testing for our views, docs, etc? Add tests - Key: CB-6284 URL: https://issues.apache.org/jira/browse/CB-6284 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill The site needs testing! -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5817) Implement Site Layout in CSS Framework
[ https://issues.apache.org/jira/browse/CB-5817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937260#comment-13937260 ] Josh Bavari commented on CB-5817: - Hey Steve, I'm back on it man. I'm assuming those designs for the home view are still the same, correct? I figure i'll start cleaning up little bits and pieces of the styles and push some changes for you to look at. Implement Site Layout in CSS Framework -- Key: CB-5817 URL: https://issues.apache.org/jira/browse/CB-5817 Project: Apache Cordova Issue Type: New Feature Components: Registry Web Reporter: Josh Bavari Original Estimate: 24h Remaining Estimate: 24h Implement the sites layout in a CSS framework (Steve was mentioning using TopCoat instead of Bootstrap) This task will involve all subtasks for its tasks. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6281) Expose more information on plugin details + style
[ https://issues.apache.org/jira/browse/CB-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937364#comment-13937364 ] Josh Bavari commented on CB-6281: - Implementing styles according to this design: http://cl.ly/image/2n1p2s3E0a2t/o Expose more information on plugin details + style - Key: CB-6281 URL: https://issues.apache.org/jira/browse/CB-6281 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5817) Implement Site Layout in CSS Framework
[ https://issues.apache.org/jira/browse/CB-5817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875841#comment-13875841 ] Josh Bavari commented on CB-5817: - [~stevegill] I have updated the project with a ton of goodies. I dont have write access to the github repo, so I cant push. I've forked the repo, it can be found: https://github.com/jbavari/cordova-registry-web Branch CB-5817 I included a README for more info as to what's changing. Changes - including Grunt, topcoat framework with grids, layout done with grids, LESS reorganized to have modules for mixins, variables, layout, header, footer, individual pages, and previous CSS imports. Basically I re-org'd the LESS sheets to take advantage of the nice imports. Compile LESS how you normally would, or run npm install to get grunt and its plugins and then run `grunt less` Implement Site Layout in CSS Framework -- Key: CB-5817 URL: https://issues.apache.org/jira/browse/CB-5817 Project: Apache Cordova Issue Type: New Feature Components: Registry Web Reporter: Josh Bavari Original Estimate: 24h Remaining Estimate: 24h Implement the sites layout in a CSS framework (Steve was mentioning using TopCoat instead of Bootstrap) This task will involve all subtasks for its tasks. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5817) Implement Site Layout in CSS Framework
[ https://issues.apache.org/jira/browse/CB-5817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875942#comment-13875942 ] Josh Bavari commented on CB-5817: - [~stevegill], I'm still working on the responsive layout for mobile - should have that done either today or tomorrow. It's coming along really nicely. I'm really like how the search control is wired up, although I'm not sure I care much for the current look. I was unsure of where it stood due to the emails exchanged between Joni and the others. Implement Site Layout in CSS Framework -- Key: CB-5817 URL: https://issues.apache.org/jira/browse/CB-5817 Project: Apache Cordova Issue Type: New Feature Components: Registry Web Reporter: Josh Bavari Original Estimate: 24h Remaining Estimate: 24h Implement the sites layout in a CSS framework (Steve was mentioning using TopCoat instead of Bootstrap) This task will involve all subtasks for its tasks. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5817) Implement Site Layout in CSS Framework
Josh Bavari created CB-5817: --- Summary: Implement Site Layout in CSS Framework Key: CB-5817 URL: https://issues.apache.org/jira/browse/CB-5817 Project: Apache Cordova Issue Type: Sub-task Components: Registry Web Reporter: Josh Bavari Implement the sites layout in a CSS framework (Steve was mentioning using TopCoat instead of Bootstrap) This task will involve all subtasks for its tasks. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5818) Implement the home view for registry
Josh Bavari created CB-5818: --- Summary: Implement the home view for registry Key: CB-5818 URL: https://issues.apache.org/jira/browse/CB-5818 Project: Apache Cordova Issue Type: Sub-task Components: Registry Web Reporter: Josh Bavari This task will involve getting the home view/page working correctly when users visit the plugin registry. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5819) Implement the search results view
Josh Bavari created CB-5819: --- Summary: Implement the search results view Key: CB-5819 URL: https://issues.apache.org/jira/browse/CB-5819 Project: Apache Cordova Issue Type: Sub-task Components: Registry Web Reporter: Josh Bavari Task for getting the search results after a user has completed a search or someone links to the search results. Will include sub tasks. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5820) Implement the plugin details view
Josh Bavari created CB-5820: --- Summary: Implement the plugin details view Key: CB-5820 URL: https://issues.apache.org/jira/browse/CB-5820 Project: Apache Cordova Issue Type: Sub-task Components: Registry Web Reporter: Josh Bavari This task will focus on showing all details related to a cordova plugin that has been submitted to the registry. Sub tasks will include all details needed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (CB-5817) Implement Site Layout in CSS Framework
[ https://issues.apache.org/jira/browse/CB-5817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Bavari updated CB-5817: Issue Type: New Feature (was: Sub-task) Parent: (was: CB-5130) Implement Site Layout in CSS Framework -- Key: CB-5817 URL: https://issues.apache.org/jira/browse/CB-5817 Project: Apache Cordova Issue Type: New Feature Components: Registry Web Reporter: Josh Bavari Original Estimate: 24h Remaining Estimate: 24h Implement the sites layout in a CSS framework (Steve was mentioning using TopCoat instead of Bootstrap) This task will involve all subtasks for its tasks. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5821) Implement site layout in topcoat mobile light theme and grid
Josh Bavari created CB-5821: --- Summary: Implement site layout in topcoat mobile light theme and grid Key: CB-5821 URL: https://issues.apache.org/jira/browse/CB-5821 Project: Apache Cordova Issue Type: Sub-task Reporter: Josh Bavari Implement the overall header and footer as seen in the designs. Using topcoat mobile light theme and the topcoat grid. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (CB-5818) Implement the home view for registry
[ https://issues.apache.org/jira/browse/CB-5818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Bavari updated CB-5818: Issue Type: New Feature (was: Sub-task) Parent: (was: CB-5130) Implement the home view for registry Key: CB-5818 URL: https://issues.apache.org/jira/browse/CB-5818 Project: Apache Cordova Issue Type: New Feature Components: Registry Web Reporter: Josh Bavari This task will involve getting the home view/page working correctly when users visit the plugin registry. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5822) Create a search bar control to be used across the site for different pages
Josh Bavari created CB-5822: --- Summary: Create a search bar control to be used across the site for different pages Key: CB-5822 URL: https://issues.apache.org/jira/browse/CB-5822 Project: Apache Cordova Issue Type: Sub-task Reporter: Josh Bavari Find some way of sharing the search functionality across the home view, search results view, and the plugin details view. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5823) Include the search control at the top of the home view
Josh Bavari created CB-5823: --- Summary: Include the search control at the top of the home view Key: CB-5823 URL: https://issues.apache.org/jira/browse/CB-5823 Project: Apache Cordova Issue Type: Sub-task Reporter: Josh Bavari Have the search control be unfilled with a message: 'Find a plugin...' -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5824) Execute request to get the Most downloads count
Josh Bavari created CB-5824: --- Summary: Execute request to get the Most downloads count Key: CB-5824 URL: https://issues.apache.org/jira/browse/CB-5824 Project: Apache Cordova Issue Type: Sub-task Reporter: Josh Bavari Execute the api http request to get the most downloaded. Results should be shown on the left near the bottom and show download count next to a link to the plugin. The download link to the plugin should take it to the plugin details page with that plugin selected. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5825) Execute request to get last updated plugins
Josh Bavari created CB-5825: --- Summary: Execute request to get last updated plugins Key: CB-5825 URL: https://issues.apache.org/jira/browse/CB-5825 Project: Apache Cordova Issue Type: Sub-task Reporter: Josh Bavari Have some http request call that will get the last updated plugins from the registry. It should show the last updated date/time with a link with the plugin ID. The link should take the user to the plugin details page for that plugin. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5826) Have links in the middle of the home view for contrib/utilize links
Josh Bavari created CB-5826: --- Summary: Have links in the middle of the home view for contrib/utilize links Key: CB-5826 URL: https://issues.apache.org/jira/browse/CB-5826 Project: Apache Cordova Issue Type: Sub-task Reporter: Josh Bavari Under the search control, have the space be filled in with two links. The first link - information about contribute and the link to the contribution page. The other link -information about utilizing the cordova plugin by showing the documentation. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5818) Implement the home view for registry
[ https://issues.apache.org/jira/browse/CB-5818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875742#comment-13875742 ] Josh Bavari commented on CB-5818: - The home view design can be found here: http://cl.ly/image/2n3l1N0Z0g0w/o This page gives basic information about the registry, links for finding plugins, analytics about plugins, and a way to sign in or register. Implement the home view for registry Key: CB-5818 URL: https://issues.apache.org/jira/browse/CB-5818 Project: Apache Cordova Issue Type: New Feature Components: Registry Web Reporter: Josh Bavari This task will involve getting the home view/page working correctly when users visit the plugin registry. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5817) Implement Site Layout in CSS Framework
[ https://issues.apache.org/jira/browse/CB-5817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875743#comment-13875743 ] Josh Bavari commented on CB-5817: - For reference to put together the layout, the designs for each page can be found here: Home view: http://cl.ly/image/2n3l1N0Z0g0w/o Search results view: http://cl.ly/image/0c3X3T1E1L0j/o Search results view with filters: http://cl.ly/image/3W2f321I211r/o Plugin details view: http://cl.ly/image/2n1p2s3E0a2t/o Implement Site Layout in CSS Framework -- Key: CB-5817 URL: https://issues.apache.org/jira/browse/CB-5817 Project: Apache Cordova Issue Type: New Feature Components: Registry Web Reporter: Josh Bavari Original Estimate: 24h Remaining Estimate: 24h Implement the sites layout in a CSS framework (Steve was mentioning using TopCoat instead of Bootstrap) This task will involve all subtasks for its tasks. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (CB-5819) Implement the search results view
[ https://issues.apache.org/jira/browse/CB-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Bavari updated CB-5819: Issue Type: New Feature (was: Sub-task) Parent: (was: CB-5130) Implement the search results view - Key: CB-5819 URL: https://issues.apache.org/jira/browse/CB-5819 Project: Apache Cordova Issue Type: New Feature Components: Registry Web Reporter: Josh Bavari Original Estimate: 24h Remaining Estimate: 24h Task for getting the search results after a user has completed a search or someone links to the search results. Will include sub tasks. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5819) Implement the search results view
[ https://issues.apache.org/jira/browse/CB-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875744#comment-13875744 ] Josh Bavari commented on CB-5819: - There are filters available on the search results view, and it should look something like the following: No filters: http://cl.ly/image/0c3X3T1E1L0j/o Filters added: http://cl.ly/image/3W2f321I211r/o Implement the search results view - Key: CB-5819 URL: https://issues.apache.org/jira/browse/CB-5819 Project: Apache Cordova Issue Type: Sub-task Components: Registry Web Reporter: Josh Bavari Original Estimate: 24h Remaining Estimate: 24h Task for getting the search results after a user has completed a search or someone links to the search results. Will include sub tasks. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5827) Implement the filters on the search view
Josh Bavari created CB-5827: --- Summary: Implement the filters on the search view Key: CB-5827 URL: https://issues.apache.org/jira/browse/CB-5827 Project: Apache Cordova Issue Type: Sub-task Reporter: Josh Bavari Default the searching filters to be filtering by all platforms. If the user clicks the 'Filter by platform' link, show the filters available. Those filters: iOS Android Blackberry Windows Phone 7 Windows Phone 8 Windows 8 Firefox OS When any of those filters are applied, remove the filters from the list of plugins that match by that filter. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5828) Show the plugins that match the search
Josh Bavari created CB-5828: --- Summary: Show the plugins that match the search Key: CB-5828 URL: https://issues.apache.org/jira/browse/CB-5828 Project: Apache Cordova Issue Type: Sub-task Reporter: Josh Bavari Show a table of results from the users search of plugins/ It should contain: Plugin ID (as link to the plugin details view) Description of plugin Version # Download Count # -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5829) Have some kind of paging for the search results
Josh Bavari created CB-5829: --- Summary: Have some kind of paging for the search results Key: CB-5829 URL: https://issues.apache.org/jira/browse/CB-5829 Project: Apache Cordova Issue Type: Sub-task Reporter: Josh Bavari Allow for paging to keep the page snappy - only show a # of results Allow the users to page between results. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5830) Include search control on the search page
Josh Bavari created CB-5830: --- Summary: Include search control on the search page Key: CB-5830 URL: https://issues.apache.org/jira/browse/CB-5830 Project: Apache Cordova Issue Type: Sub-task Reporter: Josh Bavari Include the re-usable search control on the search results page Show whatever the user searched. Ex: If the user searched 'cordova', 'cordova' should show in the search control. When the user types anything, allow the user to click search. Once clicked, update the view based on their search results. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5820) Implement the plugin details view
[ https://issues.apache.org/jira/browse/CB-5820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875746#comment-13875746 ] Josh Bavari commented on CB-5820: - The design is found here: http://cl.ly/image/2n1p2s3E0a2t/o Implement the plugin details view - Key: CB-5820 URL: https://issues.apache.org/jira/browse/CB-5820 Project: Apache Cordova Issue Type: Sub-task Components: Registry Web Reporter: Josh Bavari This task will focus on showing all details related to a cordova plugin that has been submitted to the registry. Sub tasks will include all details needed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (CB-5820) Implement the plugin details view
[ https://issues.apache.org/jira/browse/CB-5820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Bavari updated CB-5820: Issue Type: New Feature (was: Sub-task) Parent: (was: CB-5130) Implement the plugin details view - Key: CB-5820 URL: https://issues.apache.org/jira/browse/CB-5820 Project: Apache Cordova Issue Type: New Feature Components: Registry Web Reporter: Josh Bavari This task will focus on showing all details related to a cordova plugin that has been submitted to the registry. Sub tasks will include all details needed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5831) Show the the plugin details
Josh Bavari created CB-5831: --- Summary: Show the the plugin details Key: CB-5831 URL: https://issues.apache.org/jira/browse/CB-5831 Project: Apache Cordova Issue Type: Sub-task Reporter: Josh Bavari The following should be shown on the page: A link that goes back to search results (with last searched term?) Plugin ID Description Maintainers Platforms supported Repository link (to Git repo) Issue tracker link Keywords The readme contained in the project (if one exists) A sidebar with analytics: Total download # Version Last updated date/time Engine number info License -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5130) Refactor the registry
[ https://issues.apache.org/jira/browse/CB-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871711#comment-13871711 ] Josh Bavari commented on CB-5130: - Steve, Ah gotcha. I pulled the npm-www code last night and got it up and running locally. I got back to looking at cordova registry tonight. I like where you are going with breaking the calls out from site.js. Are we wanting to use requireJS or some other client package tool to pull everything in or just loading scripts separately? I am stuck with some API calls 404'ing. I got the vhosts working by modifying my default.ini to accept my vhost (localhost:5483 - pl.cordova.io) - when it tries to do the API calls, it is failing to find the proper reference for the document I suppose. Here's what I did for vhosts to work locally: Added to /etc/hosts 127.0.0.1 pl.cordova.io Added to default.ini in /usr/local/etc/couchdb/default.ini [vhosts] pl.cordova.io = /registry/_design/ui/ Any thoughts? What did you do differently? Refactor the registry - Key: CB-5130 URL: https://issues.apache.org/jira/browse/CB-5130 Project: Apache Cordova Issue Type: Improvement Components: Registry, Registry Web Reporter: Steve Gill The registry web interface needs a refactor (really a start from scratch) I wanted to create a master issue to keep track of everything related to the refactor. Subtasks should be created for all of the things Feature Requests - Show readme on plugin page - Show download counts on plugin pages - New tab for popular repositories - Show new meta tag info on plugin pages (repo, issue, author, etc) [#CB-5128] -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5130) Refactor the registry
[ https://issues.apache.org/jira/browse/CB-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13869930#comment-13869930 ] Josh Bavari commented on CB-5130: - Hey Steve, Sounds great. I am in the IRC channel now. I will talk to you at 2PM PST. Refactor the registry - Key: CB-5130 URL: https://issues.apache.org/jira/browse/CB-5130 Project: Apache Cordova Issue Type: Improvement Components: Registry, Registry Web Reporter: Steve Gill The registry web interface needs a refactor (really a start from scratch) I wanted to create a master issue to keep track of everything related to the refactor. Subtasks should be created for all of the things Feature Requests - Show readme on plugin page - Show download counts on plugin pages - New tab for popular repositories - Show new meta tag info on plugin pages (repo, issue, author, etc) [#CB-5128] -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5770) cordova define statement that wraps plugin JS files potentially is commented out unintentionally
Josh Bavari created CB-5770:
---
Summary: cordova define statement that wraps plugin JS files
potentially is commented out unintentionally
Key: CB-5770
URL: https://issues.apache.org/jira/browse/CB-5770
Project: Apache Cordova
Issue Type: Bug
Components: Plugman
Affects Versions: 3.3.0, 3.2.0, 3.1.0
Environment: Mac OSX v10.8.5
Reporter: Josh Bavari
Priority: Minor
Fix For: 3.4.0
When adding plugins with plugman, the process wraps the containing javascript
content with the following:
cordova.define(moduleName, function(require, exports, module) {
scriptContent
});
If a plugin JS file has a comment at the end of the file that plugman is
wrapping with a cordova.define statement, the string that is concatenated at
the end, });, may be commented out.
For example, given the original plugin file before preparing:
var module = { .. code .. };
//Some comment comes here
The file after preparing:
cordova.define(moduleName, function(require, exports, module) {
var module = { .. code .. };
//Some comment comes here });
The fix is to add a new line before placing the end bracket and parenthesis.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (CB-5770) cordova define statement that wraps plugin JS files potentially is commented out unintentionally
[
https://issues.apache.org/jira/browse/CB-5770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13868324#comment-13868324
]
Josh Bavari commented on CB-5770:
-
The Pull request for CB-5770 is:
https://github.com/apache/cordova-plugman/pull/42
cordova define statement that wraps plugin JS files potentially is commented
out unintentionally
Key: CB-5770
URL: https://issues.apache.org/jira/browse/CB-5770
Project: Apache Cordova
Issue Type: Bug
Components: Plugman
Affects Versions: 3.1.0, 3.2.0, 3.3.0
Environment: Mac OSX v10.8.5
Reporter: Josh Bavari
Priority: Minor
Labels: plugin, plugins
Fix For: 3.4.0
Original Estimate: 1h
Remaining Estimate: 1h
When adding plugins with plugman, the process wraps the containing javascript
content with the following:
cordova.define(moduleName, function(require, exports, module) {
scriptContent
});
If a plugin JS file has a comment at the end of the file that plugman is
wrapping with a cordova.define statement, the string that is concatenated at
the end, });, may be commented out.
For example, given the original plugin file before preparing:
var module = { .. code .. };
//Some comment comes here
The file after preparing:
cordova.define(moduleName, function(require, exports, module) {
var module = { .. code .. };
//Some comment comes here });
The fix is to add a new line before placing the end bracket and parenthesis.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (CB-5130) Refactor the registry
[ https://issues.apache.org/jira/browse/CB-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13868327#comment-13868327 ] Josh Bavari commented on CB-5130: - Steve, I would absolutely love to dive in and help. I've never done much work with a CouchDB app, but open to learn grow. I'm relatively new here, and didnt get that design that was shared. Any chance I could bother you to look at it? Refactor the registry - Key: CB-5130 URL: https://issues.apache.org/jira/browse/CB-5130 Project: Apache Cordova Issue Type: Improvement Components: Registry, Registry Web Reporter: Steve Gill The registry web interface needs a refactor (really a start from scratch) I wanted to create a master issue to keep track of everything related to the refactor. Subtasks should be created for all of the things Feature Requests - Show readme on plugin page - Show download counts on plugin pages - New tab for popular repositories - Show new meta tag info on plugin pages (repo, issue, author, etc) [#CB-5128] -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5130) Refactor the registry
[ https://issues.apache.org/jira/browse/CB-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13868491#comment-13868491 ] Josh Bavari commented on CB-5130: - Hey Steve, First off, whoa, those new designs are awesome. Exciting changes, for sure. I'll begin looking over current code to familiarize myself a little bit with how it works currently. I'm located in Oklahoma City, OK. Monday would be good. As a heads up, Monday I will be having an MRI done on my shoulder. I am not sure how long exactly it will take. I will be available after it is complete. I would guess anytime after 2PM CST (12PM PST) Refactor the registry - Key: CB-5130 URL: https://issues.apache.org/jira/browse/CB-5130 Project: Apache Cordova Issue Type: Improvement Components: Registry, Registry Web Reporter: Steve Gill The registry web interface needs a refactor (really a start from scratch) I wanted to create a master issue to keep track of everything related to the refactor. Subtasks should be created for all of the things Feature Requests - Show readme on plugin page - Show download counts on plugin pages - New tab for popular repositories - Show new meta tag info on plugin pages (repo, issue, author, etc) [#CB-5128] -- This message was sent by Atlassian JIRA (v6.1.5#6160)
