[jira] [Comment Edited] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch

2018-09-08 Thread Mark Veenstra (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608058#comment-16608058
 ] 

Mark Veenstra edited comment on CB-13767 at 9/8/18 2:03 PM:


[~raphinesse] Just noticed that the CI was still using cordova@8.0.0 instead of 
the nightly. So I updated the CI to use the nightly correctly and build times 
are back to 6 mins again as in cordova@6.5.0. So this nightly definitely fixes 
that issue.

Sorry for the confusion and that I did not noticed that earlier


was (Author: markdark):
[~raphinesse] Just noticed that the CI was still using cordova@8.0.0 instead of 
the nightly. So I updated the CI to use the nightly correctly and build times 
are back to 6 mins again as in cordova@6.5.0. So this nightly definitely fixes 
that issue.

> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png, 
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may 
> be above average, but not extreme. I've updated the project from cordova 6.5 
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so 
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
>   23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
>   402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the 
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is 
> still like this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch

2018-09-08 Thread Mark Veenstra (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608058#comment-16608058
 ] 

Mark Veenstra commented on CB-13767:


[~raphinesse] Just noticed that the CI was still using cordova@8.0.0 instead of 
the nightly. So I updated the CI to use the nightly correctly and build times 
are back to 6 mins again as in cordova@6.5.0. So this nightly definitely fixes 
that issue.

> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png, 
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may 
> be above average, but not extreme. I've updated the project from cordova 6.5 
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so 
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
>   23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
>   402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the 
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is 
> still like this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch

2018-09-08 Thread Mark Veenstra (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608038#comment-16608038
 ] 

Mark Veenstra edited comment on CB-13767 at 9/8/18 12:49 PM:
-

Just verified that npm does install the plugins and platforms into the 
node_modules directory, but still when adding a platform after npm install 
command results into slow plugin discovery

EDIT: [~raphinesse]: Will gather the information you requested. And the command 
taking much time would be adding a platform, like "cordova platform add "


was (Author: markdark):
Just verified that npm does install the plugins and platforms into the 
node_modules directory, but still when adding a platform after npm install 
command results into slow plugin discovery

EDIT: [~raphinesse]: Will gather the information you requested

> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png, 
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may 
> be above average, but not extreme. I've updated the project from cordova 6.5 
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so 
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
>   23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
>   402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the 
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is 
> still like this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch

2018-09-08 Thread Mark Veenstra (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608038#comment-16608038
 ] 

Mark Veenstra edited comment on CB-13767 at 9/8/18 12:45 PM:
-

Just verified that npm does install the plugins and platforms into the 
node_modules directory, but still when adding a platform after npm install 
command results into slow plugin discovery

EDIT: [~raphinesse]: Will gather the information you requested


was (Author: markdark):
Just verified that npm does install the plugins and platforms into the 
node_modules directory, but still when adding a platform after npm install 
command results into slow plugin discovery

> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png, 
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may 
> be above average, but not extreme. I've updated the project from cordova 6.5 
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so 
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
>   23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
>   402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the 
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is 
> still like this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch

2018-09-08 Thread Mark Veenstra (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608038#comment-16608038
 ] 

Mark Veenstra commented on CB-13767:


Just verified that npm does install the plugins and platforms into the 
node_modules directory, but still when adding a platform after npm install 
command results into slow plugin discovery

> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png, 
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may 
> be above average, but not extreme. I've updated the project from cordova 6.5 
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so 
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
>   23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
>   402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the 
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is 
> still like this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch

2018-09-08 Thread Mark Veenstra (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608033#comment-16608033
 ] 

Mark Veenstra edited comment on CB-13767 at 9/8/18 12:19 PM:
-

Yeah all the settings are in package.json and we are in fact doing a "npm 
install" before doing the "cordova platform add android" or any other cordova 
command.

Not sure if the plugins are installed by npm or by cordova when adding the 
platform. I have to check this


was (Author: markdark):
We are in fact doing a "npm install" before doing the "cordova platform add 
android" or any other cordova command. 

> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png, 
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may 
> be above average, but not extreme. I've updated the project from cordova 6.5 
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so 
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
>   23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
>   402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the 
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is 
> still like this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch

2018-09-08 Thread Mark Veenstra (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608033#comment-16608033
 ] 

Mark Veenstra commented on CB-13767:


We are in fact doing a "npm install" before doing the "cordova platform add 
android" or any other cordova command. 

> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png, 
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may 
> be above average, but not extreme. I've updated the project from cordova 6.5 
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so 
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
>   23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
>   402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the 
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is 
> still like this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch

2018-09-07 Thread Mark Veenstra (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607182#comment-16607182
 ] 

Mark Veenstra commented on CB-13767:


Just tested the nightly you mentioned, but it does not show any improvement. It 
seems that downloading/discovering the plugins is really slow.

The CI/CD is always doing a clean build rather than a subsequent build. It 
seems that subsequent builds are faster in the nightly, but the initial build 
is slow because of the plugin discovery.

> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png, 
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may 
> be above average, but not extreme. I've updated the project from cordova 6.5 
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so 
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
>   23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
>   402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the 
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is 
> still like this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch

2018-09-07 Thread Mark Veenstra (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607143#comment-16607143
 ] 

Mark Veenstra commented on CB-13767:


[~raphinesse] Which nightly should I use. If i use cordova@nightly or 
cordova@8.0.1-nightly.2018.9.7.5f369671 it fails with:

No matching version found for cordova-create@1.1.3-nightly.2018.9.7.86b05858

> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png, 
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may 
> be above average, but not extreme. I've updated the project from cordova 6.5 
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so 
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
>   23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
>   402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the 
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is 
> still like this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch

2018-09-07 Thread Mark Veenstra (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607121#comment-16607121
 ] 

Mark Veenstra commented on CB-13767:


We are using GitLab CI/CD for auto build the Cordova projects. As all of the 
above we needed to migrate to the latest Cordova 8 version since deprecated 
warnings from Google.

But build times are massively increased, see these build times:

!image-2018-09-07-15-23-30-849.png!

Before Cordova 8 we had build times of 6-10 minutes:

!image-2018-09-07-15-24-06-688.png!

 

> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png, 
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may 
> be above average, but not extreme. I've updated the project from cordova 6.5 
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so 
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
>   23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
>   402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the 
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is 
> still like this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch

2018-09-07 Thread Mark Veenstra (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Veenstra updated CB-13767:
---
Attachment: image-2018-09-07-15-24-06-688.png

> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png, 
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may 
> be above average, but not extreme. I've updated the project from cordova 6.5 
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so 
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
>   23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
>   402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the 
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is 
> still like this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch

2018-09-07 Thread Mark Veenstra (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Veenstra updated CB-13767:
---
Attachment: image-2018-09-07-15-23-30-849.png

> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may 
> be above average, but not extreme. I've updated the project from cordova 6.5 
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so 
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
>   23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
>   402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the 
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is 
> still like this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14264) The file “embedded.mobileprovision” couldn’t be opened because there is no such file.

2018-08-09 Thread Mark Veenstra (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574913#comment-16574913
 ] 

Mark Veenstra commented on CB-14264:


For reference here an entry about the same issue in the phonegap-plugin-push: 
https://github.com/phonegap/phonegap-plugin-push/issues/2518

> The file “embedded.mobileprovision” couldn’t be opened because there is no 
> such file.
> -
>
> Key: CB-14264
> URL: https://issues.apache.org/jira/browse/CB-14264
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Reporter: Mark Veenstra
>Priority: Blocker
>
> The widely used plugin `phonegap-plugin-push` includes the Firebase iOS SDK 
> for push messaging with iOS through FCM. But if you want to use a debug build 
> which using the development certificates it currently thows the following 
> error:
> {code:java}
> 2018-08-09 11:05:48.622602+0200 MyApp[760:240424] 4.13.0 - 
> [Firebase/InstanceID][I-IID003014] Error while reading embedded 
> mobileprovision Error Domain=NSCocoaErrorDomain Code=260 "The file 
> “embedded.mobileprovision” couldn’t be opened because there is no such file." 
> UserInfo={NSFilePath=/var/containers/Bundle/Application/F8B23BB0-4A1E-42AA-9430-47867B80827A/MyApp.app/embedded.mobileprovision,
>  NSUnderlyingError=0x2811b29a0 {Error Domain=NSPOSIXErrorDomain Code=2 "No 
> such file or directory"}}
> {code}
> This error is thrown by Firebase 
> [here|https://github.com/firebase/firebase-ios-sdk/blob/master/Firebase/Auth/Source/FIRAuthAPNSTokenManager.m#L160].
> This is because this file is removed by the file [`copy-www-build-step.js`on 
> line 
> 56|https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/copy-www-build-step.js#L56].
>  If we comment out this line, al works like a charm and we can use the debug 
> release to test push messages through FCM.
> If we take a look at Firebase iOS SDK it states [`If the app does not contain 
> the embedded.mobileprovision which is stripped out by Apple when the app is 
> submitted to store, then it is highly likely that it is from Apple 
> Store.`|https://github.com/firebase/firebase-ios-sdk/blob/master/GoogleUtilities/Environment/third_party/GULAppEnvironmentUtil.m#L176].
>  
> Which means that if `cordova-ios` removes this file as it does Firebase 
> expects it to be a release build, which is incorrect and the error is thrown 
> and you will not receive a correct FCM token for debug purposes.
> So for the moment we created a hook that comments out the removal of 
> `embedded.mobileprovision` after platform add. Now all works like a charm. 
> But the main question is, should it be removed? Or how can we make sure 
> Firebase iOS SDK will not mark it as production without that file? 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-14264) The file “embedded.mobileprovision” couldn’t be opened because there is no such file.

2018-08-09 Thread Mark Veenstra (JIRA)
Mark Veenstra created CB-14264:
--

 Summary: The file “embedded.mobileprovision” couldn’t be opened 
because there is no such file.
 Key: CB-14264
 URL: https://issues.apache.org/jira/browse/CB-14264
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-ios
Reporter: Mark Veenstra


The widely used plugin `phonegap-plugin-push` includes the Firebase iOS SDK for 
push messaging with iOS through FCM. But if you want to use a debug build which 
using the development certificates it currently thows the following error:
{code:java}
2018-08-09 11:05:48.622602+0200 MyApp[760:240424] 4.13.0 - 
[Firebase/InstanceID][I-IID003014] Error while reading embedded mobileprovision 
Error Domain=NSCocoaErrorDomain Code=260 "The file “embedded.mobileprovision” 
couldn’t be opened because there is no such file." 
UserInfo={NSFilePath=/var/containers/Bundle/Application/F8B23BB0-4A1E-42AA-9430-47867B80827A/MyApp.app/embedded.mobileprovision,
 NSUnderlyingError=0x2811b29a0 {Error Domain=NSPOSIXErrorDomain Code=2 "No such 
file or directory"}}
{code}
This error is thrown by Firebase 
[here|https://github.com/firebase/firebase-ios-sdk/blob/master/Firebase/Auth/Source/FIRAuthAPNSTokenManager.m#L160].

This is because this file is removed by the file [`copy-www-build-step.js`on 
line 
56|https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/copy-www-build-step.js#L56].
 If we comment out this line, al works like a charm and we can use the debug 
release to test push messages through FCM.

If we take a look at Firebase iOS SDK it states [`If the app does not contain 
the embedded.mobileprovision which is stripped out by Apple when the app is 
submitted to store, then it is highly likely that it is from Apple 
Store.`|https://github.com/firebase/firebase-ios-sdk/blob/master/GoogleUtilities/Environment/third_party/GULAppEnvironmentUtil.m#L176].
 
Which means that if `cordova-ios` removes this file as it does Firebase expects 
it to be a release build, which is incorrect and the error is thrown and you 
will not receive a correct FCM token for debug purposes.

So for the moment we created a hook that comments out the removal of 
`embedded.mobileprovision` after platform add. Now all works like a charm. But 
the main question is, should it be removed? Or how can we make sure Firebase 
iOS SDK will not mark it as production without that file? 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-13933) Add an extra orientation event for the real orientation even when locked

2018-03-01 Thread Mark Veenstra (JIRA)
Mark Veenstra created CB-13933:
--

 Summary: Add an extra orientation event for the real orientation 
even when locked
 Key: CB-13933
 URL: https://issues.apache.org/jira/browse/CB-13933
 Project: Apache Cordova
  Issue Type: Improvement
  Components: cordova-plugin-screen-orientation
 Environment: On Android when you open the camera app for example and 
you turn it from portrait to landscape you can see the layout is locked to 
portrait, but the icons will turn.

We would like to do the same in Cordova. But the current plugin does not fire 
the real orientation of the device once it is locked. Also the plugin fires the 
orientation from JS point of view instead of native point of view.

For Android it should be possible to fire the "real" orientation even when 
locked to an orientation. See: [https://stackoverflow.com/a/45437200/1800695]

Would it be a good idea to add / trigger a JS event from the native indicating 
the real orientation of the device so you can turn buttons in the HTML based on 
that event, but stick to the portrait layout?
Reporter: Mark Veenstra






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13933) Add an extra orientation event for the real orientation even when locked

2018-03-01 Thread Mark Veenstra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Veenstra updated CB-13933:
---
Environment: (was: On Android when you open the camera app for example 
and you turn it from portrait to landscape you can see the layout is locked to 
portrait, but the icons will turn.

We would like to do the same in Cordova. But the current plugin does not fire 
the real orientation of the device once it is locked. Also the plugin fires the 
orientation from JS point of view instead of native point of view.

For Android it should be possible to fire the "real" orientation even when 
locked to an orientation. See: [https://stackoverflow.com/a/45437200/1800695]

Would it be a good idea to add / trigger a JS event from the native indicating 
the real orientation of the device so you can turn buttons in the HTML based on 
that event, but stick to the portrait layout?)

> Add an extra orientation event for the real orientation even when locked
> 
>
> Key: CB-13933
> URL: https://issues.apache.org/jira/browse/CB-13933
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-screen-orientation
>Reporter: Mark Veenstra
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13933) Add an extra orientation event for the real orientation even when locked

2018-03-01 Thread Mark Veenstra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Veenstra updated CB-13933:
---
Description: 
On Android when you open the camera app for example and you turn it from 
portrait to landscape you can see the layout is locked to portrait, but the 
icons will turn.

We would like to do the same in Cordova. But the current plugin does not fire 
the real orientation of the device once it is locked. Also the plugin fires the 
orientation from JS point of view instead of native point of view.

For Android it should be possible to fire the "real" orientation even when 
locked to an orientation. See: [https://stackoverflow.com/a/45437200/1800695]

Would it be a good idea to add / trigger a JS event from the native indicating 
the real orientation of the device so you can turn buttons in the HTML based on 
that event, but stick to the portrait layout?

> Add an extra orientation event for the real orientation even when locked
> 
>
> Key: CB-13933
> URL: https://issues.apache.org/jira/browse/CB-13933
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-screen-orientation
>Reporter: Mark Veenstra
>Priority: Major
>
> On Android when you open the camera app for example and you turn it from 
> portrait to landscape you can see the layout is locked to portrait, but the 
> icons will turn.
> We would like to do the same in Cordova. But the current plugin does not fire 
> the real orientation of the device once it is locked. Also the plugin fires 
> the orientation from JS point of view instead of native point of view.
> For Android it should be possible to fire the "real" orientation even when 
> locked to an orientation. See: [https://stackoverflow.com/a/45437200/1800695]
> Would it be a good idea to add / trigger a JS event from the native 
> indicating the real orientation of the device so you can turn buttons in the 
> HTML based on that event, but stick to the portrait layout?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13503) Problems with using plugins from local file system

2017-10-27 Thread Mark Veenstra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Veenstra updated CB-13503:
---
Description: 
I am struggling to get up and running with {{cordova@7.1.0}} sometime now. 
Maybe I am doing something wrong here but I can't figure it out. It seems to me 
something is going wrong with locally defined plugins that needs to be 
installed and the way it is saved into {{package.json}}.

So to get upgraded I first installed the latest version {{npm install -g 
cordova@7.1.0}}. Then I did a {{cordova prepare}}.
This {{prepare}} failed, after [some digging and 
trying|https://github.com/dpa99c/cordova-diagnostic-plugin/issues/245] it 
seemed that some locally plugins that needs to be installed into the project 
are interrupting other plugins. So I needed to disable the {{cordova-fetch}}. I 
set this globally with {{cordova config set fetch false}}.

After this config change the {{codova prepare}} command went all fine. So I 
thought this is it.
But when I tried to let my project be build by my CI server it failed on 
installating NPM packages.

Because a {{npm install}} command will install the dependencies defined in 
{{package.json}} it will install the cordova plugins also. But in the beginning 
my plugins are in there like this:

{code}
{
  "name": "myApp",
  "version": "1.0.0",
  "description": "myApp description",
  "dependencies": {
"cordova-android": "6.3.0",
"cordova-browser": "5.0.1",
"cordova-ios": "4.5.2",
"cordova-plugin-myplugin": "resources/cordova-plugin-myplugin",
"cordova-plugin-myplugin-locker": "resources/cordova-plugin-myplugin-locker"
  },
  "devDependencies": {
  },
  "scripts": {
  },
  "cordova": {
"platforms": [
  "browser",
  "android",
  "ios"
],
"plugins": {
  "cordova-plugin-myplugin": {},
  "cordova-plugin-myplugin-locker": {}
}
  }
}
{code}

With above {{npm install}} fails and tries to get the dependecies from git, 
which is incorrect. So I search the {{package.json}} definition and they say I 
should put {{file:}} in front of it, like this:

{code}
{
  "name": "myApp",
  "version": "1.0.0",
  "description": "myApp description",
  "dependencies": {
"cordova-android": "6.3.0",
"cordova-browser": "5.0.1",
"cordova-ios": "4.5.2",
"cordova-plugin-myplugin": "file:resources/cordova-plugin-myplugin",
"cordova-plugin-myplugin-locker": 
"file:resources/cordova-plugin-myplugin-locker"
  },
  "devDependencies": {
  },
  "scripts": {
  },
  "cordova": {
"platforms": [
  "browser",
  "android",
  "ios"
],
"plugins": {
  "cordova-plugin-myplugin": {},
  "cordova-plugin-myplugin-locker": {}
}
  }
}
{code}

Now NPM finds the dependecies OK, but now when I do a {{cordova prepare}} again 
it throws an error that the plugin can't be installed from 
{{file:resources/cordova-plugin-myplugin}}.

So I get stuck into different needs for different tools. Any ideas?

  was:
I am struggling to get up and running with {{cordova@7.1.0}} sometime now. 
Maybe I am doing something wrong here but I can't figure it out. It seems to me 
something is going wrong with locally defined plugins that needs to be 
installed and the way it is saved into {{package.json}}.

So to get upgraded I first installed the latest version {{npm install -g 
cordova@7.1.0}}. Then I did a {{cordova prepare}}.
This {{prepare}} failed, after [some digging and 
trying](https://github.com/dpa99c/cordova-diagnostic-plugin/issues/245) it 
seemed that some locally plugins that needs to be installed into the project 
are interrupting other plugins. So I needed to disable the {{cordova-fetch}}. I 
set this globally with {{cordova config set fetch false}}.

After this config change the {{codova prepare}} command went all fine. So I 
thought this is it.
But when I tried to let my project be build by my CI server it failed on 
installating NPM packages.

Because a {{npm install}} command will install the dependencies defined in 
{{package.json}} it will install the cordova plugins also. But in the beginning 
my plugins are in there like this:

{code:json}
{
  "name": "myApp",
  "version": "1.0.0",
  "description": "myApp description",
  "dependencies": {
"cordova-android": "6.3.0",
"cordova-browser": "5.0.1",
"cordova-ios": "4.5.2",
"cordova-plugin-myplugin": "resources/cordova-plugin-myplugin",
"cordova-plugin-myplugin-locker": "resources/cordova-plugin-myplugin-locker"
  },
  "devDependencies": {
  },
  "scripts": {
  },
  "cordova": {
"platforms": [
  "browser",
  "android",
  "ios"
],
"plugins": {
  "cordova-plugin-myplugin": {},
  "cordova-plugin-myplugin-locker": {}
}
  }
}
{code}

With above {{npm install}} fails and tries to get the dependecies from git, 
which is incorrect. So I search the {{package.json}} definition and they say I 
should put {{file:}} in front of 

[jira] [Created] (CB-13503) Problems with using plugins from local file system

2017-10-27 Thread Mark Veenstra (JIRA)
Mark Veenstra created CB-13503:
--

 Summary: Problems with using plugins from local file system
 Key: CB-13503
 URL: https://issues.apache.org/jira/browse/CB-13503
 Project: Apache Cordova
  Issue Type: Bug
  Components: AllPlatforms, cordova-fetch
Affects Versions: cordova@7.1.0
Reporter: Mark Veenstra
Priority: Blocker


I am struggling to get up and running with {{cordova@7.1.0}} sometime now. 
Maybe I am doing something wrong here but I can't figure it out. It seems to me 
something is going wrong with locally defined plugins that needs to be 
installed and the way it is saved into {{package.json}}.

So to get upgraded I first installed the latest version {{npm install -g 
cordova@7.1.0}}. Then I did a {{cordova prepare}}.
This {{prepare}} failed, after [some digging and 
trying](https://github.com/dpa99c/cordova-diagnostic-plugin/issues/245) it 
seemed that some locally plugins that needs to be installed into the project 
are interrupting other plugins. So I needed to disable the {{cordova-fetch}}. I 
set this globally with {{cordova config set fetch false}}.

After this config change the {{codova prepare}} command went all fine. So I 
thought this is it.
But when I tried to let my project be build by my CI server it failed on 
installating NPM packages.

Because a {{npm install}} command will install the dependencies defined in 
{{package.json}} it will install the cordova plugins also. But in the beginning 
my plugins are in there like this:

{code:json}
{
  "name": "myApp",
  "version": "1.0.0",
  "description": "myApp description",
  "dependencies": {
"cordova-android": "6.3.0",
"cordova-browser": "5.0.1",
"cordova-ios": "4.5.2",
"cordova-plugin-myplugin": "resources/cordova-plugin-myplugin",
"cordova-plugin-myplugin-locker": "resources/cordova-plugin-myplugin-locker"
  },
  "devDependencies": {
  },
  "scripts": {
  },
  "cordova": {
"platforms": [
  "browser",
  "android",
  "ios"
],
"plugins": {
  "cordova-plugin-myplugin": {},
  "cordova-plugin-myplugin-locker": {}
}
  }
}
{code}

With above {{npm install}} fails and tries to get the dependecies from git, 
which is incorrect. So I search the {{package.json}} definition and they say I 
should put {{file:}} in front of it, like this:

{code:json}
{
  "name": "myApp",
  "version": "1.0.0",
  "description": "myApp description",
  "dependencies": {
"cordova-android": "6.3.0",
"cordova-browser": "5.0.1",
"cordova-ios": "4.5.2",
"cordova-plugin-myplugin": "file:resources/cordova-plugin-myplugin",
"cordova-plugin-myplugin-locker": 
"file:resources/cordova-plugin-myplugin-locker"
  },
  "devDependencies": {
  },
  "scripts": {
  },
  "cordova": {
"platforms": [
  "browser",
  "android",
  "ios"
],
"plugins": {
  "cordova-plugin-myplugin": {},
  "cordova-plugin-myplugin-locker": {}
}
  }
}
{code}

Now NPM finds the dependecies OK, but now when I do a {{cordova prepare}} again 
it throws an error that the plugin can't be installed from 
{{file:resources/cordova-plugin-myplugin}}.

So I get stuck into different needs for different tools. Any ideas?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13228) cordova-browser@5 doesn't add with cordova<7

2017-10-26 Thread Mark Veenstra (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220518#comment-16220518
 ] 

Mark Veenstra commented on CB-13228:


[~stevegill] Today I tried to update again to latest cordova with the latest 
browser platform, but still no success:


{code}
user@user-laptop:~/Documenten/Projects/client$ cordova prepare --verbose
Resolving module name for q => q
Checking config.xml and package.json for saved platforms that haven't been 
added to the project
Config.xml and package.json platforms are different. Updating package.json with 
most current list of platforms.
Package.json and config.xml platforms are different. Updating config.xml with 
most current list of platforms.
Discovered platform "browser@5.0.1" in config.xml or package.json. Adding it to 
the project
Resolving module name for q => q
Using cordova-fetch for cordova-browser@5.0.1
Running command: npm install cordova-browser@5.0.1 --production --no-save
Command finished with error code 0: npm 
install,cordova-browser@5.0.1,--production,--no-save
Error: CordovaError: Failed to fetch platform cordova-browser@5.0.1
Probably this is either a connection problem, or platform spec is incorrect.
Check your connection and platform name/version/URL.
Failed to get absolute path to installed module
at 
/home/mva/.nvm/versions/node/v6.10.1/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/platform/addHelper.js:329:25
at _rejected 
(/home/mva/.nvm/versions/node/v6.10.1/lib/node_modules/cordova/node_modules/q/q.js:797:24)
at 
/home/mva/.nvm/versions/node/v6.10.1/lib/node_modules/cordova/node_modules/q/q.js:823:30
at Promise.when 
(/home/mva/.nvm/versions/node/v6.10.1/lib/node_modules/cordova/node_modules/cordova-fetch/node_modules/q/q.js:1142:31)
at Promise.promise.promiseDispatch 
(/home/mva/.nvm/versions/node/v6.10.1/lib/node_modules/cordova/node_modules/cordova-fetch/node_modules/q/q.js:808:41)
at 
/home/mva/.nvm/versions/node/v6.10.1/lib/node_modules/cordova/node_modules/cordova-fetch/node_modules/q/q.js:624:44
at runSingle 
(/home/mva/.nvm/versions/node/v6.10.1/lib/node_modules/cordova/node_modules/cordova-fetch/node_modules/q/q.js:137:13)
at flush 
(/home/mva/.nvm/versions/node/v6.10.1/lib/node_modules/cordova/node_modules/cordova-fetch/node_modules/q/q.js:125:13)
at _combinedTickCallback (internal/process/next_tick.js:73:7)
at process._tickCallback (internal/process/next_tick.js:104:9)
{code}


> cordova-browser@5 doesn't add with cordova<7
> 
>
> Key: CB-13228
> URL: https://issues.apache.org/jira/browse/CB-13228
> Project: Apache Cordova
>  Issue Type: Bug
>Affects Versions: browser@5.0.0
>Reporter: Steve Gill
>Assignee: Steve Gill
>  Labels: browser-next, easy-fix
> Fix For: 5.0.1
>
>
> {code}
> cordova platform add browser@latest --nofetch
> Warning: using prerelease version 7.0.2-dev (cordova-lib@7.0.2-dev)
> Adding browser project...
> Unable to load PlatformApi from platform. Error: Cannot find module 
> 'cordova-common'
> Error: Uncaught, unspecified "error" event. (The platform "browser" does not 
> appear to be a valid cordova platform. It is missing API.js. browser not 
> supported.)
> {code}
> I believe cordova-common wasn't properly bundled into cordova-browser@5. 
> Works fine if I add it locally. Easy fix



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13228) cordova-browser@5 doesn't add with cordova<7

2017-10-13 Thread Mark Veenstra (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203516#comment-16203516
 ] 

Mark Veenstra commented on CB-13228:


Is this issue still on the radar? cordova-browser@5 or even any cordova-browser 
platform does not work anymore with cordova@7.1.0

> cordova-browser@5 doesn't add with cordova<7
> 
>
> Key: CB-13228
> URL: https://issues.apache.org/jira/browse/CB-13228
> Project: Apache Cordova
>  Issue Type: Bug
>Affects Versions: 5.0.0
>Reporter: Steve Gill
>  Labels: browser-next, easy-fix
> Fix For: 5.0.1
>
>
> {code}
> cordova platform add browser@latest --nofetch
> Warning: using prerelease version 7.0.2-dev (cordova-lib@7.0.2-dev)
> Adding browser project...
> Unable to load PlatformApi from platform. Error: Cannot find module 
> 'cordova-common'
> Error: Uncaught, unspecified "error" event. (The platform "browser" does not 
> appear to be a valid cordova platform. It is missing API.js. browser not 
> supported.)
> {code}
> I believe cordova-common wasn't properly bundled into cordova-browser@5. 
> Works fine if I add it locally. Easy fix



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-12957) Do not use audio constraints in getUserMedia

2017-06-27 Thread Mark Veenstra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Veenstra updated CB-12957:
---
Description: 
Within the browser source of the {{cordova--plugin-camera}} there is a 
{{CameraProxy.js}} file that calls the {{navigator.getUserMedia()}} with audio 
enabled. Why is the audio enabled for taking a picture? Wouldn't it be better 
to disable audio?

See: 
https://github.com/apache/cordova-plugin-camera/blob/master/src/browser/CameraProxy.js#L112

Change it to:
{code:javascript}
navigator.getUserMedia({video: true, audio: false}, successCallback, 
errorCallback);
{code}

  was:
Within the browser source of the {{cordova--plugin-camera}} there is a 
{{CameraProxy.js}} file that calls the {{navigator.getUserMedia()} with audio 
enabled. Why is the audio enabled for taking a picture? Wouldn't it be better 
to disable audio?

See: 
https://github.com/apache/cordova-plugin-camera/blob/master/src/browser/CameraProxy.js#L112

Change it to:
{code:javascript}
navigator.getUserMedia({video: true, audio: false}, successCallback, 
errorCallback);
{code}


> Do not use audio constraints in getUserMedia
> 
>
> Key: CB-12957
> URL: https://issues.apache.org/jira/browse/CB-12957
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
> Environment: browsers
>Reporter: Mark Veenstra
>
> Within the browser source of the {{cordova--plugin-camera}} there is a 
> {{CameraProxy.js}} file that calls the {{navigator.getUserMedia()}} with 
> audio enabled. Why is the audio enabled for taking a picture? Wouldn't it be 
> better to disable audio?
> See: 
> https://github.com/apache/cordova-plugin-camera/blob/master/src/browser/CameraProxy.js#L112
> Change it to:
> {code:javascript}
> navigator.getUserMedia({video: true, audio: false}, successCallback, 
> errorCallback);
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-12957) Do not use audio constraints in getUserMedia

2017-06-27 Thread Mark Veenstra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Veenstra updated CB-12957:
---
Description: 
Within the browser source of the {{cordova--plugin-camera}} there is a 
{{CameraProxy.js}} file that calls the {{navigator.getUserMedia()} with audio 
enabled. Why is the audio enabled for taking a picture? Wouldn't it be better 
to disable audio?

See: 
https://github.com/apache/cordova-plugin-camera/blob/master/src/browser/CameraProxy.js#L112

Change it to:
{code:javascript}
navigator.getUserMedia({video: true, audio: false}, successCallback, 
errorCallback);
{code}

  was:
Within the browser source of the {{cordova--plugin-camera}} there is a 
{{CameraProxy.js}} file that calls the {{navigator.getUserMedia()} with audio 
enabled. Why is the audio enabled for taking a picture? Wouldn't it be better 
to disable audio?

See: 
https://github.com/apache/cordova-plugin-camera/blob/master/src/browser/CameraProxy.js#L112

Change it to:
{{navigator.getUserMedia({video: true, audio: false}, successCallback, 
errorCallback);}}


> Do not use audio constraints in getUserMedia
> 
>
> Key: CB-12957
> URL: https://issues.apache.org/jira/browse/CB-12957
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
> Environment: browsers
>Reporter: Mark Veenstra
>
> Within the browser source of the {{cordova--plugin-camera}} there is a 
> {{CameraProxy.js}} file that calls the {{navigator.getUserMedia()} with audio 
> enabled. Why is the audio enabled for taking a picture? Wouldn't it be better 
> to disable audio?
> See: 
> https://github.com/apache/cordova-plugin-camera/blob/master/src/browser/CameraProxy.js#L112
> Change it to:
> {code:javascript}
> navigator.getUserMedia({video: true, audio: false}, successCallback, 
> errorCallback);
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-12957) Do not use audio constraints in getUserMedia

2017-06-27 Thread Mark Veenstra (JIRA)
Mark Veenstra created CB-12957:
--

 Summary: Do not use audio constraints in getUserMedia
 Key: CB-12957
 URL: https://issues.apache.org/jira/browse/CB-12957
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-plugin-camera
 Environment: browsers
Reporter: Mark Veenstra


Within the browser source of the {{cordova--plugin-camera}} there is a 
{{CameraProxy.js}} file that calls the {{navigator.getUserMedia()} with audio 
enabled. Why is the audio enabled for taking a picture? Wouldn't it be better 
to disable audio?

See: 
https://github.com/apache/cordova-plugin-camera/blob/master/src/browser/CameraProxy.js#L112

Change it to:
{{navigator.getUserMedia({video: true, audio: false}, successCallback, 
errorCallback);}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-12009) target attribute ignored on iOS when installing a Cordova plugin

2017-04-13 Thread Mark Veenstra (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967199#comment-15967199
 ] 

Mark Veenstra edited comment on CB-12009 at 4/13/17 6:46 AM:
-

Hmm the documentation link I gave is down indeed.
But the link you just gave seems to tell the same.
We have tested the sounds in the {{Library/Sounds}} and in the {{Resources}} 
folder, but these don't seem to work (maybe because of the issue you just 
pointed out). We did notice that when we add the sounds to the library root and 
build an IPA / run from XCode the sounds don't work on first start of the app, 
but after you kill it and start it again the push notification custom sounds do 
work, but only when the sounds are in the app bundle roout (one directory 
higher than {{Resources}})


was (Author: markdark):
Hmm the documentation link I gave is down indeed.
But the link you just gave seems to tell the same.
We have tested the sounds in the {{Library/Sounds}} and in the {Resources} 
folder, but these don't seem to work (maybe because of the issue you just 
pointed out). We did notice that when we add the sounds to the library root and 
build an IPA / run from XCode the sounds don't work on first start of the app, 
but after you kill it and start it again the push notification custom sounds do 
work, but only when the sounds are in the app bundle roout (one directory 
higher than {Resources})

>  target attribute ignored on iOS when installing a Cordova 
> plugin
> 
>
> Key: CB-12009
> URL: https://issues.apache.org/jira/browse/CB-12009
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Affects Versions: 6.3.0, 6.3.1
>Reporter: Mark Veenstra
>Priority: Critical
> Fix For: cordova-ios@4.4.1
>
>
> In the Cordova plugin.xml documentation it is stated that the 
> {{}} tag can have an attribute {{target}}. See next link: 
> https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#resource-file
> But when I try to use this target attribute it is just ignored and all 
> {{}} configurations are added to the {{Resources}} directory 
> on iOS.
> It seems to me that the {{cordova-lib}} code just ignores this {{target}} 
> attribute, see next link: 
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/platforms/ios.js#L165
> The code grabbed from that link:
> {{destFile = path.resolve(project.resources_dir, path.basename(src));}}
> Here you can see the destFile is hardcoded for the resources_dir.
> We are trying to add push notification sounds to the iOS {{Resources}} 
> directory as well as adding it to either the bundle root or 
> {{Library/Sounds}}. Because we have seen that since iOS 10 we need to put the 
> sounds files elsewhere then the {{Resources}} directory to get it work. See: 
> https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/Chapters/TheNotificationPayload.html#//apple_ref/doc/uid/TP40008194-CH107-SW1



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-12009) target attribute ignored on iOS when installing a Cordova plugin

2017-04-13 Thread Mark Veenstra (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967199#comment-15967199
 ] 

Mark Veenstra edited comment on CB-12009 at 4/13/17 6:45 AM:
-

Hmm the documentation link I gave is down indeed.
But the link you just gave seems to tell the same.
We have tested the sounds in the {{Library/Sounds}} and in the {Resources} 
folder, but these don't seem to work (maybe because of the issue you just 
pointed out). We did notice that when we add the sounds to the library root and 
build an IPA / run from XCode the sounds don't work on first start of the app, 
but after you kill it and start it again the push notification custom sounds do 
work, but only when the sounds are in the app bundle roout (one directory 
higher than {Resources})


was (Author: markdark):
Hmm the documentation link I gave is down indeed.
But the link you just gave seems to tell the same.
We have tested the sounds in the {Library/Sounds} and in the {Resources} 
folder, but these don't seem to work (maybe because of the issue you just 
pointed out). We did notice that when we add the sounds to the library root and 
build an IPA / run from XCode the sounds don't work on first start of the app, 
but after you kill it and start it again the push notification custom sounds do 
work, but only when the sounds are in the app bundle roout (one directory 
higher than {Resources})

>  target attribute ignored on iOS when installing a Cordova 
> plugin
> 
>
> Key: CB-12009
> URL: https://issues.apache.org/jira/browse/CB-12009
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Affects Versions: 6.3.0, 6.3.1
>Reporter: Mark Veenstra
>Priority: Critical
> Fix For: cordova-ios@4.4.1
>
>
> In the Cordova plugin.xml documentation it is stated that the 
> {{}} tag can have an attribute {{target}}. See next link: 
> https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#resource-file
> But when I try to use this target attribute it is just ignored and all 
> {{}} configurations are added to the {{Resources}} directory 
> on iOS.
> It seems to me that the {{cordova-lib}} code just ignores this {{target}} 
> attribute, see next link: 
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/platforms/ios.js#L165
> The code grabbed from that link:
> {{destFile = path.resolve(project.resources_dir, path.basename(src));}}
> Here you can see the destFile is hardcoded for the resources_dir.
> We are trying to add push notification sounds to the iOS {{Resources}} 
> directory as well as adding it to either the bundle root or 
> {{Library/Sounds}}. Because we have seen that since iOS 10 we need to put the 
> sounds files elsewhere then the {{Resources}} directory to get it work. See: 
> https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/Chapters/TheNotificationPayload.html#//apple_ref/doc/uid/TP40008194-CH107-SW1



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-12009) target attribute ignored on iOS when installing a Cordova plugin

2017-04-13 Thread Mark Veenstra (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967199#comment-15967199
 ] 

Mark Veenstra edited comment on CB-12009 at 4/13/17 6:45 AM:
-

Hmm the documentation link I gave is down indeed.
But the link you just gave seems to tell the same.
We have tested the sounds in the {Library/Sounds} and in the {Resources} 
folder, but these don't seem to work (maybe because of the issue you just 
pointed out). We did notice that when we add the sounds to the library root and 
build an IPA / run from XCode the sounds don't work on first start of the app, 
but after you kill it and start it again the push notification custom sounds do 
work, but only when the sounds are in the app bundle roout (one directory 
higher than {Resources})


was (Author: markdark):
Hmm the documentation link I gave is down indeed.
But the link you just gave seems to tell the same.
We have tested the sounds in the `Library/Sounds` and in the `Resources` 
folder, but these don't seem to work (maybe because of the issue you just 
pointed out). We did notice that when we add the sounds to the library root and 
build an IPA / run from XCode the sounds don't work on first start of the app, 
but after you kill it and start it again the push notification custom sounds do 
work, but only when the sounds are in the app bundle roout (one directory 
higher than Resources)

>  target attribute ignored on iOS when installing a Cordova 
> plugin
> 
>
> Key: CB-12009
> URL: https://issues.apache.org/jira/browse/CB-12009
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Affects Versions: 6.3.0, 6.3.1
>Reporter: Mark Veenstra
>Priority: Critical
> Fix For: cordova-ios@4.4.1
>
>
> In the Cordova plugin.xml documentation it is stated that the 
> {{}} tag can have an attribute {{target}}. See next link: 
> https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#resource-file
> But when I try to use this target attribute it is just ignored and all 
> {{}} configurations are added to the {{Resources}} directory 
> on iOS.
> It seems to me that the {{cordova-lib}} code just ignores this {{target}} 
> attribute, see next link: 
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/platforms/ios.js#L165
> The code grabbed from that link:
> {{destFile = path.resolve(project.resources_dir, path.basename(src));}}
> Here you can see the destFile is hardcoded for the resources_dir.
> We are trying to add push notification sounds to the iOS {{Resources}} 
> directory as well as adding it to either the bundle root or 
> {{Library/Sounds}}. Because we have seen that since iOS 10 we need to put the 
> sounds files elsewhere then the {{Resources}} directory to get it work. See: 
> https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/Chapters/TheNotificationPayload.html#//apple_ref/doc/uid/TP40008194-CH107-SW1



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12009) target attribute ignored on iOS when installing a Cordova plugin

2017-04-13 Thread Mark Veenstra (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967199#comment-15967199
 ] 

Mark Veenstra commented on CB-12009:


Hmm the documentation link I gave is down indeed.
But the link you just gave seems to tell the same.
We have tested the sounds in the `Library/Sounds` and in the `Resources` 
folder, but these don't seem to work (maybe because of the issue you just 
pointed out). We did notice that when we add the sounds to the library root and 
build an IPA / run from XCode the sounds don't work on first start of the app, 
but after you kill it and start it again the push notification custom sounds do 
work, but only when the sounds are in the app bundle roout (one directory 
higher than Resources)

>  target attribute ignored on iOS when installing a Cordova 
> plugin
> 
>
> Key: CB-12009
> URL: https://issues.apache.org/jira/browse/CB-12009
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Affects Versions: 6.3.0, 6.3.1
>Reporter: Mark Veenstra
>Priority: Critical
> Fix For: cordova-ios@4.4.1
>
>
> In the Cordova plugin.xml documentation it is stated that the 
> {{}} tag can have an attribute {{target}}. See next link: 
> https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#resource-file
> But when I try to use this target attribute it is just ignored and all 
> {{}} configurations are added to the {{Resources}} directory 
> on iOS.
> It seems to me that the {{cordova-lib}} code just ignores this {{target}} 
> attribute, see next link: 
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/platforms/ios.js#L165
> The code grabbed from that link:
> {{destFile = path.resolve(project.resources_dir, path.basename(src));}}
> Here you can see the destFile is hardcoded for the resources_dir.
> We are trying to add push notification sounds to the iOS {{Resources}} 
> directory as well as adding it to either the bundle root or 
> {{Library/Sounds}}. Because we have seen that since iOS 10 we need to put the 
> sounds files elsewhere then the {{Resources}} directory to get it work. See: 
> https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/Chapters/TheNotificationPayload.html#//apple_ref/doc/uid/TP40008194-CH107-SW1



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-12105) window.device.model returns "Chrome" instead of "Edge" when using MS Edge

2016-11-02 Thread Mark Veenstra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Veenstra updated CB-12105:
---
Description: 
When building for platform browser the {{cordova-plugin-device}} (v1.3.2) 
returns "Chrome" instead of "Edge" when requesting {{window.device.model}} on 
an Edge browser.

In the {{DeviceProxy.js}} the following code is there: 
https://github.com/apache/cordova-plugin-device/blob/master/src/browser/DeviceProxy.js#L40

{code}
function getBrowserInfo(getModel) {
var userAgent = navigator.userAgent;
var returnVal = '';
var offset;

if ((offset = userAgent.indexOf('Chrome')) !== -1) {
returnVal = (getModel) ? 'Chrome' : userAgent.substring(offset + 7);
} else if ((offset = userAgent.indexOf('Safari')) !== -1) {
if (getModel) {
returnVal = 'Safari';
} else {
returnVal = userAgent.substring(offset + 7);

if ((offset = userAgent.indexOf('Version')) !== -1) {
returnVal = userAgent.substring(offset + 8);
}
}
} else if ((offset = userAgent.indexOf('Firefox')) !== -1) {
returnVal = (getModel) ? 'Firefox' : userAgent.substring(offset + 8);
} else if ((offset = userAgent.indexOf('MSIE')) !== -1) {
returnVal = (getModel) ? 'MSIE' : userAgent.substring(offset + 5);
} else if ((offset = userAgent.indexOf('Trident')) !== -1) {
returnVal = (getModel) ? 'MSIE' : '11';
}

if ((offset = returnVal.indexOf(';')) !== -1 || (offset = 
returnVal.indexOf(' ')) !== -1) {
returnVal = returnVal.substring(0, offset);
}

return returnVal;
}
{code}

The code above returns model Chrome as soon as it is in the userAgent string. 
MS Edge provides the following userAgent string: {{Mozilla/5.0 (Windows NT 
10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 
Safari/537.36 Edge/14.14393}}

So it seems we should be checking first if "Edge" is part of the userAgent. If 
so the browser would be Edge.

  was:
When building for platform browser the {{cordova-plugin-device}} (v1.3.2) 
returns "Chrome" instead of "Edge" when requesting `window.device.model` on an 
Edge browser.

In the `DeviceProxy.js` the following code is there: 
https://github.com/apache/cordova-plugin-device/blob/master/src/browser/DeviceProxy.js#L40

{code}
function getBrowserInfo(getModel) {
var userAgent = navigator.userAgent;
var returnVal = '';
var offset;

if ((offset = userAgent.indexOf('Chrome')) !== -1) {
returnVal = (getModel) ? 'Chrome' : userAgent.substring(offset + 7);
} else if ((offset = userAgent.indexOf('Safari')) !== -1) {
if (getModel) {
returnVal = 'Safari';
} else {
returnVal = userAgent.substring(offset + 7);

if ((offset = userAgent.indexOf('Version')) !== -1) {
returnVal = userAgent.substring(offset + 8);
}
}
} else if ((offset = userAgent.indexOf('Firefox')) !== -1) {
returnVal = (getModel) ? 'Firefox' : userAgent.substring(offset + 8);
} else if ((offset = userAgent.indexOf('MSIE')) !== -1) {
returnVal = (getModel) ? 'MSIE' : userAgent.substring(offset + 5);
} else if ((offset = userAgent.indexOf('Trident')) !== -1) {
returnVal = (getModel) ? 'MSIE' : '11';
}

if ((offset = returnVal.indexOf(';')) !== -1 || (offset = 
returnVal.indexOf(' ')) !== -1) {
returnVal = returnVal.substring(0, offset);
}

return returnVal;
}
{code}

The code above returns model Chrome as soon as it is in the userAgent string. 
MS Edge provides the following userAgent string: `Mozilla/5.0 (Windows NT 10.0; 
Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 
Safari/537.36 Edge/14.14393`

So it seems we should be checking first if "Edge" is part of the userAgent. If 
so the browser would be Edge.


> window.device.model returns "Chrome" instead of "Edge" when using MS Edge
> -
>
> Key: CB-12105
> URL: https://issues.apache.org/jira/browse/CB-12105
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Device
>Affects Versions: 6.3.2
>Reporter: Mark Veenstra
>Priority: Critical
>
> When building for platform browser the {{cordova-plugin-device}} (v1.3.2) 
> returns "Chrome" instead of "Edge" when requesting {{window.device.model}} on 
> an Edge browser.
> In the {{DeviceProxy.js}} the following code is there: 
> https://github.com/apache/cordova-plugin-device/blob/master/src/browser/DeviceProxy.js#L40
> {code}
> function getBrowserInfo(getModel) {
> var userAgent = navigator.userAgent;
> var returnVal = '';
> var offset;
> if ((offset = userAgent.indexOf('Chrome')) !== -1) {
> returnVal = 

[jira] [Created] (CB-12105) window.device.model returns "Chrome" instead of "Edge" when using MS Edge

2016-11-02 Thread Mark Veenstra (JIRA)
Mark Veenstra created CB-12105:
--

 Summary: window.device.model returns "Chrome" instead of "Edge" 
when using MS Edge
 Key: CB-12105
 URL: https://issues.apache.org/jira/browse/CB-12105
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Device
Affects Versions: 6.3.2
Reporter: Mark Veenstra
Priority: Critical


When building for platform browser the `cordova-plugin-device` (v1.3.2) returns 
"Chrome" instead of "Edge" when requesting `window.device.model` on an Edge 
browser.

In the `DeviceProxy.js` the following code is there: 
https://github.com/apache/cordova-plugin-device/blob/master/src/browser/DeviceProxy.js#L40

```
function getBrowserInfo(getModel) {
var userAgent = navigator.userAgent;
var returnVal = '';
var offset;

if ((offset = userAgent.indexOf('Chrome')) !== -1) {
returnVal = (getModel) ? 'Chrome' : userAgent.substring(offset + 7);
} else if ((offset = userAgent.indexOf('Safari')) !== -1) {
if (getModel) {
returnVal = 'Safari';
} else {
returnVal = userAgent.substring(offset + 7);

if ((offset = userAgent.indexOf('Version')) !== -1) {
returnVal = userAgent.substring(offset + 8);
}
}
} else if ((offset = userAgent.indexOf('Firefox')) !== -1) {
returnVal = (getModel) ? 'Firefox' : userAgent.substring(offset + 8);
} else if ((offset = userAgent.indexOf('MSIE')) !== -1) {
returnVal = (getModel) ? 'MSIE' : userAgent.substring(offset + 5);
} else if ((offset = userAgent.indexOf('Trident')) !== -1) {
returnVal = (getModel) ? 'MSIE' : '11';
}

if ((offset = returnVal.indexOf(';')) !== -1 || (offset = 
returnVal.indexOf(' ')) !== -1) {
returnVal = returnVal.substring(0, offset);
}

return returnVal;
}
```

The code above returns model Chrome as soon as it is in the userAgent string. 
MS Edge provides the following userAgent string: `Mozilla/5.0 (Windows NT 10.0; 
Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 
Safari/537.36 Edge/14.14393`

So it seems we should be checking first if "Edge" is part of the userAgent. If 
so the browser would be Edge.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-12105) window.device.model returns "Chrome" instead of "Edge" when using MS Edge

2016-11-02 Thread Mark Veenstra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Veenstra updated CB-12105:
---
Description: 
When building for platform browser the {{cordova-plugin-device}} (v1.3.2) 
returns "Chrome" instead of "Edge" when requesting `window.device.model` on an 
Edge browser.

In the `DeviceProxy.js` the following code is there: 
https://github.com/apache/cordova-plugin-device/blob/master/src/browser/DeviceProxy.js#L40

{code}
function getBrowserInfo(getModel) {
var userAgent = navigator.userAgent;
var returnVal = '';
var offset;

if ((offset = userAgent.indexOf('Chrome')) !== -1) {
returnVal = (getModel) ? 'Chrome' : userAgent.substring(offset + 7);
} else if ((offset = userAgent.indexOf('Safari')) !== -1) {
if (getModel) {
returnVal = 'Safari';
} else {
returnVal = userAgent.substring(offset + 7);

if ((offset = userAgent.indexOf('Version')) !== -1) {
returnVal = userAgent.substring(offset + 8);
}
}
} else if ((offset = userAgent.indexOf('Firefox')) !== -1) {
returnVal = (getModel) ? 'Firefox' : userAgent.substring(offset + 8);
} else if ((offset = userAgent.indexOf('MSIE')) !== -1) {
returnVal = (getModel) ? 'MSIE' : userAgent.substring(offset + 5);
} else if ((offset = userAgent.indexOf('Trident')) !== -1) {
returnVal = (getModel) ? 'MSIE' : '11';
}

if ((offset = returnVal.indexOf(';')) !== -1 || (offset = 
returnVal.indexOf(' ')) !== -1) {
returnVal = returnVal.substring(0, offset);
}

return returnVal;
}
{code}

The code above returns model Chrome as soon as it is in the userAgent string. 
MS Edge provides the following userAgent string: `Mozilla/5.0 (Windows NT 10.0; 
Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 
Safari/537.36 Edge/14.14393`

So it seems we should be checking first if "Edge" is part of the userAgent. If 
so the browser would be Edge.

  was:
When building for platform browser the `cordova-plugin-device` (v1.3.2) returns 
"Chrome" instead of "Edge" when requesting `window.device.model` on an Edge 
browser.

In the `DeviceProxy.js` the following code is there: 
https://github.com/apache/cordova-plugin-device/blob/master/src/browser/DeviceProxy.js#L40

```
function getBrowserInfo(getModel) {
var userAgent = navigator.userAgent;
var returnVal = '';
var offset;

if ((offset = userAgent.indexOf('Chrome')) !== -1) {
returnVal = (getModel) ? 'Chrome' : userAgent.substring(offset + 7);
} else if ((offset = userAgent.indexOf('Safari')) !== -1) {
if (getModel) {
returnVal = 'Safari';
} else {
returnVal = userAgent.substring(offset + 7);

if ((offset = userAgent.indexOf('Version')) !== -1) {
returnVal = userAgent.substring(offset + 8);
}
}
} else if ((offset = userAgent.indexOf('Firefox')) !== -1) {
returnVal = (getModel) ? 'Firefox' : userAgent.substring(offset + 8);
} else if ((offset = userAgent.indexOf('MSIE')) !== -1) {
returnVal = (getModel) ? 'MSIE' : userAgent.substring(offset + 5);
} else if ((offset = userAgent.indexOf('Trident')) !== -1) {
returnVal = (getModel) ? 'MSIE' : '11';
}

if ((offset = returnVal.indexOf(';')) !== -1 || (offset = 
returnVal.indexOf(' ')) !== -1) {
returnVal = returnVal.substring(0, offset);
}

return returnVal;
}
```

The code above returns model Chrome as soon as it is in the userAgent string. 
MS Edge provides the following userAgent string: `Mozilla/5.0 (Windows NT 10.0; 
Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 
Safari/537.36 Edge/14.14393`

So it seems we should be checking first if "Edge" is part of the userAgent. If 
so the browser would be Edge.


> window.device.model returns "Chrome" instead of "Edge" when using MS Edge
> -
>
> Key: CB-12105
> URL: https://issues.apache.org/jira/browse/CB-12105
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Device
>Affects Versions: 6.3.2
>Reporter: Mark Veenstra
>Priority: Critical
>
> When building for platform browser the {{cordova-plugin-device}} (v1.3.2) 
> returns "Chrome" instead of "Edge" when requesting `window.device.model` on 
> an Edge browser.
> In the `DeviceProxy.js` the following code is there: 
> https://github.com/apache/cordova-plugin-device/blob/master/src/browser/DeviceProxy.js#L40
> {code}
> function getBrowserInfo(getModel) {
> var userAgent = navigator.userAgent;
> var returnVal = '';
> var offset;
> if ((offset = userAgent.indexOf('Chrome')) !== -1) {
> returnVal = (getModel) ? 'Chrome' : 

[jira] [Updated] (CB-12009) target attribute ignored on iOS when installing a Cordova plugin

2016-10-13 Thread Mark Veenstra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Veenstra updated CB-12009:
---
Description: 
In the Cordova plugin.xml documentation it is stated that the 
{{}} tag can have an attribute {{target}}. See next link: 
https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#resource-file

But when I try to use this target attribute it is just ignored and all 
{{}} configurations are added to the {{Resources}} directory on 
iOS.
It seems to me that the {{cordova-lib}} code just ignores this {{target}} 
attribute, see next link: 
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/platforms/ios.js#L165

The code grabbed from that link:
{{destFile = path.resolve(project.resources_dir, path.basename(src));}}

Here you can see the destFile is hardcoded for the resources_dir.
We are trying to add push notification sounds to the iOS {{Resources}} 
directory as well as adding it to either the bundle root or {{Library/Sounds}}. 
Because we have seen that since iOS 10 we need to put the sounds files 
elsewhere then the {{Resources}} directory to get it work. See: 
https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/Chapters/TheNotificationPayload.html#//apple_ref/doc/uid/TP40008194-CH107-SW1



  was:
In the Cordova plugin.xml documentation it is stated that the 
{{}} tag can have an attribute {{target}}. See next link: 
https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#resource-file

But when I try to use this target attribute it is just ignored and all 
{{}} configurations are added to the {{Resources}} directory on 
iOS.
It seems to me that the {{cordova-lib}} code just ignores this {{target}} 
attribute, see next link: 
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/platforms/ios.js#L165

The code grabbed from that link:
{{destFile = path.resolve(project.resources_dir, path.basename(src));}}

Here you can see the destFile is hardcoded for the resources_dir.




> target attribute ignored on iOS when installing a Cordova plugin
> 
>
> Key: CB-12009
> URL: https://issues.apache.org/jira/browse/CB-12009
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Affects Versions: 6.3.0, 6.3.1
>Reporter: Mark Veenstra
>Priority: Critical
>
> In the Cordova plugin.xml documentation it is stated that the 
> {{}} tag can have an attribute {{target}}. See next link: 
> https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#resource-file
> But when I try to use this target attribute it is just ignored and all 
> {{}} configurations are added to the {{Resources}} directory 
> on iOS.
> It seems to me that the {{cordova-lib}} code just ignores this {{target}} 
> attribute, see next link: 
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/platforms/ios.js#L165
> The code grabbed from that link:
> {{destFile = path.resolve(project.resources_dir, path.basename(src));}}
> Here you can see the destFile is hardcoded for the resources_dir.
> We are trying to add push notification sounds to the iOS {{Resources}} 
> directory as well as adding it to either the bundle root or 
> {{Library/Sounds}}. Because we have seen that since iOS 10 we need to put the 
> sounds files elsewhere then the {{Resources}} directory to get it work. See: 
> https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/Chapters/TheNotificationPayload.html#//apple_ref/doc/uid/TP40008194-CH107-SW1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-12009) target attribute ignored on iOS when installing a Cordova plugin

2016-10-13 Thread Mark Veenstra (JIRA)
Mark Veenstra created CB-12009:
--

 Summary: target attribute ignored on iOS when installing a Cordova 
plugin
 Key: CB-12009
 URL: https://issues.apache.org/jira/browse/CB-12009
 Project: Apache Cordova
  Issue Type: Bug
  Components: iOS
Affects Versions: 6.3.0, 6.3.1
Reporter: Mark Veenstra
Priority: Critical


In the Cordova plugin.xml documentation it is stated that the 
{{}} tag can have an attribute {{target}}. See next link: 
https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#resource-file

But when I try to use this target attribute it is just ignored and all 
{{}} configurations are added to the {{Resources}} directory on 
iOS.
It seems to me that the {{cordova-lib}} code just ignores this {{target}} 
attribute, see next link: 
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/platforms/ios.js#L165

The code grabbed from that link:
{{destFile = path.resolve(project.resources_dir, path.basename(src));}}

Here you can see the destFile is hardcoded for the resources_dir.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-11313) Can't start media streaming on Android 6.0

2016-05-24 Thread Mark Veenstra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-11313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Veenstra updated CB-11313:
---
Description: 
We are trying to play online radio stations with Cordova, for example these 
stations:
http://www.hendrikjansen.nl/henk/streaming.html

But when we try the current released version {{2.3.0}} or the current dev 
{{2.3.1-dev}}, both give the same {{adb logcat}} output:

{code}
05-24 15:22:08.936 27095 27176 E MediaPlayer-JNI: JNIMediaPlayerFactory: 
bIsQCMediaPlayerPresent 0
05-24 15:22:08.936 27095 27176 E MediaPlayer-JNI: JNIMediaPlayerFactory: 
bIsQCMediaPlayerPresent 0
05-24 15:22:08.940   798  3345 I MediaFocusControl:  AudioFocus  
requestAudioFocus() from 
android.media.AudioManager@fd128bforg.apache.cordova.media.AudioHandler$1@932bb8c
 req=1flags=0x0
05-24 15:22:08.953 27095 27415 D MediaHTTPConnection: filterOutInternalHeaders: 
key=User-Agent, val= stagefright/1.2 (Linux;Android 6.0.1)
05-24 15:22:08.954 27095 27810 D MediaHTTPConnection: proxy null port 0
05-24 15:22:13.341   258 30530 I FFmpegExtractor: android-source:0xb5f4f8c0
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 I FFMPEG  : [mp3 @ 0xae696e00] Skipping 0 bytes 
of junk at 0.
05-24 15:22:13.343   258 30530 D FFmpegExtractor: suppoted codec(mp3) by 
official Stagefright
05-24 15:22:13.343   258 30530 D FFmpegExtractor: ffmpeg detected media content 
as 'audio/mpeg' with confidence 0.08
05-24 15:22:13.344   258 30529 D NuPlayerDriver: notifyListener_l(0xae76c0e0), 
(1, 0, 0)
05-24 15:22:13.345 27095 27176 D MediaPlayer: setSubtitleAnchor in MediaPlayer
05-24 15:22:13.347   258  2659 E MediaPlayerService: getDuration returned 
-2147483648
05-24 15:22:13.347 27095 27176 W MediaPlayer: Stream has no duration and is 
therefore not seekable.
05-24 15:22:13.347 27095 27176 E MediaPlayer: error (-2147483648, 0)
05-24 15:22:13.347 27095 27176 D AudioPlayer: Send a onStatus update for the 
new seek
05-24 15:22:13.348 27095 27176 E MediaPlayer: start called in state 0
05-24 15:22:13.348 27095 27176 E MediaPlayer: error (-38, 0)
05-24 15:22:13.348 27095 27176 E MediaPlayer: Attempt to call getDuration 
without a valid mediaplayer
05-24 15:22:13.348 27095 27176 E MediaPlayer: error (-38, 0)
05-24 15:22:13.348 27095 27176 E MediaPlayer: Error (-2147483648,0)
05-24 15:22:13.348 27095 27176 D AudioPlayer: on completion is calling stopped
05-24 15:22:13.349 27095 27176 E MediaPlayer: Error (-38,0)
05-24 15:22:13.349 27095 27176 D AudioPlayer: on completion is calling stopped
05-24 15:22:13.349 27095 27176 E MediaPlayer: Error (-38,0)
05-24 15:22:13.349 27095 27176 D AudioPlayer: on completion is calling stopped
{code}

If I comment out the lines 
https://github.com/apache/cordova-plugin-media/blob/master/src/android/AudioPlayer.java#L435
 ({{this.seekToPlaying(this.seekOnPrepared);}}) and 
https://github.com/apache/cordova-plugin-media/blob/master/src/android/AudioPlayer.java#L445
 ({{this.duration = getDurationInSeconds();}}). It does start the stream, but 
as soon as I receive a notification from a different app (for example a new 
WhatApp message) the MediaPlayer crashes.

  was:
We are trying to play online radio stations with Cordova, for example these 
stations:
http://www.hendrikjansen.nl/henk/streaming.html

But when we try the current released version {{2.3.0}} or the current dev 
`2.3.1-dev`, both give the same `adb logcat` output:

{code}
05-24 15:22:08.936 27095 27176 E MediaPlayer-JNI: JNIMediaPlayerFactory: 
bIsQCMediaPlayerPresent 0
05-24 15:22:08.936 27095 27176 E MediaPlayer-JNI: JNIMediaPlayerFactory: 
bIsQCMediaPlayerPresent 0
05-24 15:22:08.940   798  3345 I MediaFocusControl:  AudioFocus  
requestAudioFocus() from 
android.media.AudioManager@fd128bforg.apache.cordova.media.AudioHandler$1@932bb8c
 req=1flags=0x0
05-24 15:22:08.953 27095 27415 D MediaHTTPConnection: filterOutInternalHeaders: 
key=User-Agent, val= stagefright/1.2 (Linux;Android 6.0.1)
05-24 15:22:08.954 27095 27810 D MediaHTTPConnection: proxy null port 0
05-24 15:22:13.341   258 30530 I FFmpegExtractor: android-source:0xb5f4f8c0
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 I FFMPEG  : [mp3 @ 0xae696e00] Skipping 0 bytes 
of junk at 0.
05-24 15:22:13.343   258 30530 D FFmpegExtractor: suppoted codec(mp3) by 
official Stagefright
05-24 15:22:13.343   258 30530 D FFmpegExtractor: ffmpeg detected media content 
as 'audio/mpeg' with confidence 0.08
05-24 15:22:13.344   258 30529 D NuPlayerDriver: notifyListener_l(0xae76c0e0), 
(1, 0, 0)
05-24 15:22:13.345 27095 27176 D MediaPlayer: setSubtitleAnchor in 

[jira] [Updated] (CB-11313) Can't start media streaming on Android 6.0

2016-05-24 Thread Mark Veenstra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-11313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Veenstra updated CB-11313:
---
Description: 
We are trying to play online radio stations with Cordova, for example these 
stations:
http://www.hendrikjansen.nl/henk/streaming.html

But when we try the current released version {{2.3.0}} or the current dev 
`2.3.1-dev`, both give the same `adb logcat` output:

{code}
05-24 15:22:08.936 27095 27176 E MediaPlayer-JNI: JNIMediaPlayerFactory: 
bIsQCMediaPlayerPresent 0
05-24 15:22:08.936 27095 27176 E MediaPlayer-JNI: JNIMediaPlayerFactory: 
bIsQCMediaPlayerPresent 0
05-24 15:22:08.940   798  3345 I MediaFocusControl:  AudioFocus  
requestAudioFocus() from 
android.media.AudioManager@fd128bforg.apache.cordova.media.AudioHandler$1@932bb8c
 req=1flags=0x0
05-24 15:22:08.953 27095 27415 D MediaHTTPConnection: filterOutInternalHeaders: 
key=User-Agent, val= stagefright/1.2 (Linux;Android 6.0.1)
05-24 15:22:08.954 27095 27810 D MediaHTTPConnection: proxy null port 0
05-24 15:22:13.341   258 30530 I FFmpegExtractor: android-source:0xb5f4f8c0
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 I FFMPEG  : [mp3 @ 0xae696e00] Skipping 0 bytes 
of junk at 0.
05-24 15:22:13.343   258 30530 D FFmpegExtractor: suppoted codec(mp3) by 
official Stagefright
05-24 15:22:13.343   258 30530 D FFmpegExtractor: ffmpeg detected media content 
as 'audio/mpeg' with confidence 0.08
05-24 15:22:13.344   258 30529 D NuPlayerDriver: notifyListener_l(0xae76c0e0), 
(1, 0, 0)
05-24 15:22:13.345 27095 27176 D MediaPlayer: setSubtitleAnchor in MediaPlayer
05-24 15:22:13.347   258  2659 E MediaPlayerService: getDuration returned 
-2147483648
05-24 15:22:13.347 27095 27176 W MediaPlayer: Stream has no duration and is 
therefore not seekable.
05-24 15:22:13.347 27095 27176 E MediaPlayer: error (-2147483648, 0)
05-24 15:22:13.347 27095 27176 D AudioPlayer: Send a onStatus update for the 
new seek
05-24 15:22:13.348 27095 27176 E MediaPlayer: start called in state 0
05-24 15:22:13.348 27095 27176 E MediaPlayer: error (-38, 0)
05-24 15:22:13.348 27095 27176 E MediaPlayer: Attempt to call getDuration 
without a valid mediaplayer
05-24 15:22:13.348 27095 27176 E MediaPlayer: error (-38, 0)
05-24 15:22:13.348 27095 27176 E MediaPlayer: Error (-2147483648,0)
05-24 15:22:13.348 27095 27176 D AudioPlayer: on completion is calling stopped
05-24 15:22:13.349 27095 27176 E MediaPlayer: Error (-38,0)
05-24 15:22:13.349 27095 27176 D AudioPlayer: on completion is calling stopped
05-24 15:22:13.349 27095 27176 E MediaPlayer: Error (-38,0)
05-24 15:22:13.349 27095 27176 D AudioPlayer: on completion is calling stopped
{code}

If I comment out the lines 
https://github.com/apache/cordova-plugin-media/blob/master/src/android/AudioPlayer.java#L435
 (`this.seekToPlaying(this.seekOnPrepared);`) and 
https://github.com/apache/cordova-plugin-media/blob/master/src/android/AudioPlayer.java#L445
 (`this.duration = getDurationInSeconds();`). It does start the stream, but as 
soon as I receive a notification from a different app (for example a new 
WhatApp message) the MediaPlayer crashes.

  was:
We are trying to play online radio stations with Cordova, for example these 
stations:
http://www.hendrikjansen.nl/henk/streaming.html

But when we try the current released version `2.3.0` or the current dev 
`2.3.1-dev`, both give the same `adb logcat` output:

{code}
05-24 15:22:08.936 27095 27176 E MediaPlayer-JNI: JNIMediaPlayerFactory: 
bIsQCMediaPlayerPresent 0
05-24 15:22:08.936 27095 27176 E MediaPlayer-JNI: JNIMediaPlayerFactory: 
bIsQCMediaPlayerPresent 0
05-24 15:22:08.940   798  3345 I MediaFocusControl:  AudioFocus  
requestAudioFocus() from 
android.media.AudioManager@fd128bforg.apache.cordova.media.AudioHandler$1@932bb8c
 req=1flags=0x0
05-24 15:22:08.953 27095 27415 D MediaHTTPConnection: filterOutInternalHeaders: 
key=User-Agent, val= stagefright/1.2 (Linux;Android 6.0.1)
05-24 15:22:08.954 27095 27810 D MediaHTTPConnection: proxy null port 0
05-24 15:22:13.341   258 30530 I FFmpegExtractor: android-source:0xb5f4f8c0
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 I FFMPEG  : [mp3 @ 0xae696e00] Skipping 0 bytes 
of junk at 0.
05-24 15:22:13.343   258 30530 D FFmpegExtractor: suppoted codec(mp3) by 
official Stagefright
05-24 15:22:13.343   258 30530 D FFmpegExtractor: ffmpeg detected media content 
as 'audio/mpeg' with confidence 0.08
05-24 15:22:13.344   258 30529 D NuPlayerDriver: notifyListener_l(0xae76c0e0), 
(1, 0, 0)
05-24 15:22:13.345 27095 27176 D MediaPlayer: setSubtitleAnchor in 

[jira] [Updated] (CB-11313) Can't start media streaming on Android 6.0

2016-05-24 Thread Mark Veenstra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-11313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Veenstra updated CB-11313:
---
Description: 
We are trying to play online radio stations with Cordova, for example these 
stations:
http://www.hendrikjansen.nl/henk/streaming.html

But when we try the current released version `2.3.0` or the current dev 
`2.3.1-dev`, both give the same `adb logcat` output:

{code}
05-24 15:22:08.936 27095 27176 E MediaPlayer-JNI: JNIMediaPlayerFactory: 
bIsQCMediaPlayerPresent 0
05-24 15:22:08.936 27095 27176 E MediaPlayer-JNI: JNIMediaPlayerFactory: 
bIsQCMediaPlayerPresent 0
05-24 15:22:08.940   798  3345 I MediaFocusControl:  AudioFocus  
requestAudioFocus() from 
android.media.AudioManager@fd128bforg.apache.cordova.media.AudioHandler$1@932bb8c
 req=1flags=0x0
05-24 15:22:08.953 27095 27415 D MediaHTTPConnection: filterOutInternalHeaders: 
key=User-Agent, val= stagefright/1.2 (Linux;Android 6.0.1)
05-24 15:22:08.954 27095 27810 D MediaHTTPConnection: proxy null port 0
05-24 15:22:13.341   258 30530 I FFmpegExtractor: android-source:0xb5f4f8c0
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 I FFMPEG  : [mp3 @ 0xae696e00] Skipping 0 bytes 
of junk at 0.
05-24 15:22:13.343   258 30530 D FFmpegExtractor: suppoted codec(mp3) by 
official Stagefright
05-24 15:22:13.343   258 30530 D FFmpegExtractor: ffmpeg detected media content 
as 'audio/mpeg' with confidence 0.08
05-24 15:22:13.344   258 30529 D NuPlayerDriver: notifyListener_l(0xae76c0e0), 
(1, 0, 0)
05-24 15:22:13.345 27095 27176 D MediaPlayer: setSubtitleAnchor in MediaPlayer
05-24 15:22:13.347   258  2659 E MediaPlayerService: getDuration returned 
-2147483648
05-24 15:22:13.347 27095 27176 W MediaPlayer: Stream has no duration and is 
therefore not seekable.
05-24 15:22:13.347 27095 27176 E MediaPlayer: error (-2147483648, 0)
05-24 15:22:13.347 27095 27176 D AudioPlayer: Send a onStatus update for the 
new seek
05-24 15:22:13.348 27095 27176 E MediaPlayer: start called in state 0
05-24 15:22:13.348 27095 27176 E MediaPlayer: error (-38, 0)
05-24 15:22:13.348 27095 27176 E MediaPlayer: Attempt to call getDuration 
without a valid mediaplayer
05-24 15:22:13.348 27095 27176 E MediaPlayer: error (-38, 0)
05-24 15:22:13.348 27095 27176 E MediaPlayer: Error (-2147483648,0)
05-24 15:22:13.348 27095 27176 D AudioPlayer: on completion is calling stopped
05-24 15:22:13.349 27095 27176 E MediaPlayer: Error (-38,0)
05-24 15:22:13.349 27095 27176 D AudioPlayer: on completion is calling stopped
05-24 15:22:13.349 27095 27176 E MediaPlayer: Error (-38,0)
05-24 15:22:13.349 27095 27176 D AudioPlayer: on completion is calling stopped
{code}

If I comment out the lines 
https://github.com/apache/cordova-plugin-media/blob/master/src/android/AudioPlayer.java#L435
 (`this.seekToPlaying(this.seekOnPrepared);`) and 
https://github.com/apache/cordova-plugin-media/blob/master/src/android/AudioPlayer.java#L445
 (`this.duration = getDurationInSeconds();`). It does start the stream, but as 
soon as I receive a notification from a different app (for example a new 
WhatApp message) the MediaPlayer crashes.

  was:
We are trying to play online radio stations with Cordova, for example these 
stations:
http://www.hendrikjansen.nl/henk/streaming.html

But when we try the current released version `2.3.0` or the current dev 
`2.3.1-dev`, both give the same `adb logcat` output:

```
05-24 15:22:08.936 27095 27176 E MediaPlayer-JNI: JNIMediaPlayerFactory: 
bIsQCMediaPlayerPresent 0
05-24 15:22:08.936 27095 27176 E MediaPlayer-JNI: JNIMediaPlayerFactory: 
bIsQCMediaPlayerPresent 0
05-24 15:22:08.940   798  3345 I MediaFocusControl:  AudioFocus  
requestAudioFocus() from 
android.media.AudioManager@fd128bforg.apache.cordova.media.AudioHandler$1@932bb8c
 req=1flags=0x0
05-24 15:22:08.953 27095 27415 D MediaHTTPConnection: filterOutInternalHeaders: 
key=User-Agent, val= stagefright/1.2 (Linux;Android 6.0.1)
05-24 15:22:08.954 27095 27810 D MediaHTTPConnection: proxy null port 0
05-24 15:22:13.341   258 30530 I FFmpegExtractor: android-source:0xb5f4f8c0
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 I FFMPEG  : [mp3 @ 0xae696e00] Skipping 0 bytes 
of junk at 0.
05-24 15:22:13.343   258 30530 D FFmpegExtractor: suppoted codec(mp3) by 
official Stagefright
05-24 15:22:13.343   258 30530 D FFmpegExtractor: ffmpeg detected media content 
as 'audio/mpeg' with confidence 0.08
05-24 15:22:13.344   258 30529 D NuPlayerDriver: notifyListener_l(0xae76c0e0), 
(1, 0, 0)
05-24 15:22:13.345 27095 27176 D MediaPlayer: setSubtitleAnchor in MediaPlayer

[jira] [Created] (CB-11313) Can't start media streaming on Android 6.0

2016-05-24 Thread Mark Veenstra (JIRA)
Mark Veenstra created CB-11313:
--

 Summary: Can't start media streaming on Android 6.0
 Key: CB-11313
 URL: https://issues.apache.org/jira/browse/CB-11313
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Media
Reporter: Mark Veenstra


We are trying to play online radio stations with Cordova, for example these 
stations:
http://www.hendrikjansen.nl/henk/streaming.html

But when we try the current released version `2.3.0` or the current dev 
`2.3.1-dev`, both give the same `adb logcat` output:

```
05-24 15:22:08.936 27095 27176 E MediaPlayer-JNI: JNIMediaPlayerFactory: 
bIsQCMediaPlayerPresent 0
05-24 15:22:08.936 27095 27176 E MediaPlayer-JNI: JNIMediaPlayerFactory: 
bIsQCMediaPlayerPresent 0
05-24 15:22:08.940   798  3345 I MediaFocusControl:  AudioFocus  
requestAudioFocus() from 
android.media.AudioManager@fd128bforg.apache.cordova.media.AudioHandler$1@932bb8c
 req=1flags=0x0
05-24 15:22:08.953 27095 27415 D MediaHTTPConnection: filterOutInternalHeaders: 
key=User-Agent, val= stagefright/1.2 (Linux;Android 6.0.1)
05-24 15:22:08.954 27095 27810 D MediaHTTPConnection: proxy null port 0
05-24 15:22:13.341   258 30530 I FFmpegExtractor: android-source:0xb5f4f8c0
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 E FFMPEG  : FFSource getSize failed
05-24 15:22:13.343   258 30530 I FFMPEG  : [mp3 @ 0xae696e00] Skipping 0 bytes 
of junk at 0.
05-24 15:22:13.343   258 30530 D FFmpegExtractor: suppoted codec(mp3) by 
official Stagefright
05-24 15:22:13.343   258 30530 D FFmpegExtractor: ffmpeg detected media content 
as 'audio/mpeg' with confidence 0.08
05-24 15:22:13.344   258 30529 D NuPlayerDriver: notifyListener_l(0xae76c0e0), 
(1, 0, 0)
05-24 15:22:13.345 27095 27176 D MediaPlayer: setSubtitleAnchor in MediaPlayer
05-24 15:22:13.347   258  2659 E MediaPlayerService: getDuration returned 
-2147483648
05-24 15:22:13.347 27095 27176 W MediaPlayer: Stream has no duration and is 
therefore not seekable.
05-24 15:22:13.347 27095 27176 E MediaPlayer: error (-2147483648, 0)
05-24 15:22:13.347 27095 27176 D AudioPlayer: Send a onStatus update for the 
new seek
05-24 15:22:13.348 27095 27176 E MediaPlayer: start called in state 0
05-24 15:22:13.348 27095 27176 E MediaPlayer: error (-38, 0)
05-24 15:22:13.348 27095 27176 E MediaPlayer: Attempt to call getDuration 
without a valid mediaplayer
05-24 15:22:13.348 27095 27176 E MediaPlayer: error (-38, 0)
05-24 15:22:13.348 27095 27176 E MediaPlayer: Error (-2147483648,0)
05-24 15:22:13.348 27095 27176 D AudioPlayer: on completion is calling stopped
05-24 15:22:13.349 27095 27176 E MediaPlayer: Error (-38,0)
05-24 15:22:13.349 27095 27176 D AudioPlayer: on completion is calling stopped
05-24 15:22:13.349 27095 27176 E MediaPlayer: Error (-38,0)
05-24 15:22:13.349 27095 27176 D AudioPlayer: on completion is calling stopped
```

If I comment out the lines 
https://github.com/apache/cordova-plugin-media/blob/master/src/android/AudioPlayer.java#L435
 (`this.seekToPlaying(this.seekOnPrepared);`) and 
https://github.com/apache/cordova-plugin-media/blob/master/src/android/AudioPlayer.java#L445
 (`this.duration = getDurationInSeconds();`). It does start the stream, but as 
soon as I receive a notification from a different app (for example a new 
WhatApp message) the MediaPlayer crashes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-10061) The frame requesting access has a protocol of "https", the frame being accessed has a protocol of "http". Protocols must match.

2015-11-23 Thread Mark Veenstra (JIRA)
Mark Veenstra created CB-10061:
--

 Summary: The frame requesting access has a protocol of "https", 
the frame being accessed has a protocol of "http". Protocols must match.
 Key: CB-10061
 URL: https://issues.apache.org/jira/browse/CB-10061
 Project: Apache Cordova
  Issue Type: Bug
  Components: Browser
Affects Versions: 5.4.0
Reporter: Mark Veenstra
Assignee: Tim Barham


When I build and test a browser version of our app I got issues with the  
InAppBrowser plugin when opening a site that isn't on the same protocol as 
where I serve the app.

For example when I serve it locally I got these errors:
{code}
Uncaught SecurityError: Blocked a frame with origin "https://www.dominos.nl; 
from accessing a frame with origin "http://192.168.178.17:8100;.  The frame 
requesting access has a protocol of "https", the frame being accessed has a 
protocol of "http". Protocols must match.
{code}

I open the window as follows:
{code}
window.open('https://www.dominos.nl', '_blank', 
'location=yes,clearcache=yes,toolbar=yes,EnableViewPortScale=yes');
{code}

I have also tried to open the window with {{//www.dominos.nl}} but also with no 
success.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-9767) AngularJS/Cordova based website not loaded correctly

2015-10-08 Thread Mark Veenstra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-9767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Veenstra updated CB-9767:
--
Attachment: screenshot_inappbrowser.png

Incorrect display of same site in InAppBrowser on same Android device

> AngularJS/Cordova based website not loaded correctly
> 
>
> Key: CB-9767
> URL: https://issues.apache.org/jira/browse/CB-9767
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Reporter: Mark Veenstra
> Attachments: screenshot_chrome.png, screenshot_inappbrowser.png
>
>
> We are having issues with one specific site which isn't displayed correctly 
> within the InAppBrowser. It is the following site: 
> https://alzheimerassistent.nl/
> If you open this site in a normal mobile browser (Android or IOS) you will 
> see the site is responsive to the device viewport and readable.
> Once you open the site in the InAppBrowser the site isn't that great 
> optimized as it is in the normal browser of the phone. We can't seem to find 
> what the issue is here.
> The specific site is using AngularJS and also injects some Cordova stuff. 
> Maybe with this something is going wrong?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-9767) AngularJS/Cordova based website not loaded correctly

2015-10-08 Thread Mark Veenstra (JIRA)
Mark Veenstra created CB-9767:
-

 Summary: AngularJS/Cordova based website not loaded correctly
 Key: CB-9767
 URL: https://issues.apache.org/jira/browse/CB-9767
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin InAppBrowser
Reporter: Mark Veenstra


We are having issues with one specific site which isn't displayed correctly 
within the InAppBrowser. It is the following site: 
https://alzheimerassistent.nl/

If you open this site in a normal mobile browser (Android or IOS) you will see 
the site is responsive to the device viewport and readable.

Once you open the site in the InAppBrowser the site isn't that great optimized 
as it is in the normal browser of the phone. We can't seem to find what the 
issue is here.

The specific site is using AngularJS and also injects some Cordova stuff. Maybe 
with this something is going wrong?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-9767) AngularJS/Cordova based website not loaded correctly

2015-10-08 Thread Mark Veenstra (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-9767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Veenstra updated CB-9767:
--
Attachment: screenshot_chrome.png

Correct screenhot in a normal (Chrome) browser on Android

> AngularJS/Cordova based website not loaded correctly
> 
>
> Key: CB-9767
> URL: https://issues.apache.org/jira/browse/CB-9767
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Reporter: Mark Veenstra
> Attachments: screenshot_chrome.png
>
>
> We are having issues with one specific site which isn't displayed correctly 
> within the InAppBrowser. It is the following site: 
> https://alzheimerassistent.nl/
> If you open this site in a normal mobile browser (Android or IOS) you will 
> see the site is responsive to the device viewport and readable.
> Once you open the site in the InAppBrowser the site isn't that great 
> optimized as it is in the normal browser of the phone. We can't seem to find 
> what the issue is here.
> The specific site is using AngularJS and also injects some Cordova stuff. 
> Maybe with this something is going wrong?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org