[jira] [Commented] (CB-3768) Build to phone failing on Xcode 5 DP1 (OS X Mavericks)
[ https://issues.apache.org/jira/browse/CB-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879495#comment-13879495 ] Montyleena commented on CB-3768: @mohamed, i got the same error in XCode but the error came when i modified the CordovaLib.xcodeproj/project.pbxproj file using TextEdit. When i modified the file using XCode, the error didn't come anymore and my issue was solved. Build to phone failing on Xcode 5 DP1 (OS X Mavericks) -- Key: CB-3768 URL: https://issues.apache.org/jira/browse/CB-3768 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 2.5.0, 2.8.0 Reporter: Shazron Abdullah Assignee: Shazron Abdullah Labels: mavericks, xcode5 Fix For: 2.9.0 Attachments: linkerror.png I know it's a Dev Preview, but we should fix this as we go along the beta so we are not totally surprised when final goes out. More details here: https://github.com/shazron/phonegap-questions/issues/16 --- Been happily building to my phone with Xcode 4.6 (phonegap/cordova 2.5.0) installed ios7 developer preview and Xcode 5 DP and now building to the phone fails. (error screenshot here: http://d.pr/i/akfq, let me know if I can get specifics for you) Build succeeds and runs fine in iOS simulator. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Comment Edited] (CB-3768) Build to phone failing on Xcode 5 DP1 (OS X Mavericks)
[ https://issues.apache.org/jira/browse/CB-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879495#comment-13879495 ] Montyleena edited comment on CB-3768 at 1/23/14 6:45 AM: - @mohamed, i got the same error in XCode but the error came when i modified the CordovaLib.xcodeproj/project.pbxproj file using TextEdit. When i modified the file using XCode, the error didn't come anymore and my issue was solved. Also, the quick fix posted by [~shazron] doesn't work if you make the mentioned changes after opening your main PhoneGap project. You should open the CordovaLib project separately in XCode and then the quick fix will work. That's what happened at my end. was (Author: montylee): @mohamed, i got the same error in XCode but the error came when i modified the CordovaLib.xcodeproj/project.pbxproj file using TextEdit. When i modified the file using XCode, the error didn't come anymore and my issue was solved. Build to phone failing on Xcode 5 DP1 (OS X Mavericks) -- Key: CB-3768 URL: https://issues.apache.org/jira/browse/CB-3768 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 2.5.0, 2.8.0 Reporter: Shazron Abdullah Assignee: Shazron Abdullah Labels: mavericks, xcode5 Fix For: 2.9.0 Attachments: linkerror.png I know it's a Dev Preview, but we should fix this as we go along the beta so we are not totally surprised when final goes out. More details here: https://github.com/shazron/phonegap-questions/issues/16 --- Been happily building to my phone with Xcode 4.6 (phonegap/cordova 2.5.0) installed ios7 developer preview and Xcode 5 DP and now building to the phone fails. (error screenshot here: http://d.pr/i/akfq, let me know if I can get specifics for you) Build succeeds and runs fine in iOS simulator. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-3576) Add support for interstitial user confirmation of self-signed SSL certs to CordovaWebView and InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867479#comment-13867479
]
Montyleena commented on CB-3576:
Marcel, thanks for the detailed explanation :) The user confirmation is the
ideal solution to this.
Joe: You can't reject this outright without thinking about all types of
applications. The solution Marcel shared is the need of the hour specially for
Enterprise applications. You can either ignore user feedback or choose to do
some additional work and make it happen. It's always a good thing to give the
control to the user, and by blocking the URLs without asking the user, PhoneGap
is not doing that.
Add support for interstitial user confirmation of self-signed SSL certs to
CordovaWebView and InAppBrowser
--
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Improvement
Components: Android, iOS, Plugin InAppBrowser
Affects Versions: 2.7.0, 2.8.0
Environment: Android and iOS
Reporter: Montyleena
Priority: Minor
Labels: android, https, inappbrowser,, ios, ssl
Attachments: InAppBrowser.java
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
InAppBrowser should pick up the SSL settings from the main web view and once
we overwrite the onReceivedSslError() function, then it should allow such
URLs in the InAppBrowser too.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (CB-3576) Add support for self-signed SSL certficates in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13770511#comment-13770511
]
Montyleena commented on CB-3576:
Please check out my pull requests in that case:
iOS: https://github.com/apache/cordova-ios/pull/59
Android: https://github.com/apache/cordova-android/pull/63
You can compare the code changes and do similar change in your PhoneGap 3.0
code and then build a new PhoneGap 3.0 jar. For Android, you will need to
download PhoneGap's code and build it with the changes. For iOS, you can simply
make the changes in your existing XCode project as PhoneGap's code is included
in iOS project.
Add support for self-signed SSL certficates in InAppBrowser
---
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Improvement
Components: Android, iOS, Plugin InAppBrowser
Affects Versions: 2.7.0, 2.8.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Andrew Grieve
Labels: android, https, inappbrowser,, ios, ssl
Attachments: InAppBrowser.java
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
InAppBrowser should pick up the SSL settings from the main web view and once
we overwrite the onReceivedSslError() function, then it should allow such
URLs in the InAppBrowser too.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3576) Add support for self-signed SSL certficates in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13770461#comment-13770461
]
Montyleena commented on CB-3576:
If you are ok to use PhoneGap 2.8.0, i can provide you the working .jar file
for Android. Which platform are you working on?
Mods: Looking at the amount of queries in this thread alone, i hope this
feature gets included in future releases.
Add support for self-signed SSL certficates in InAppBrowser
---
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Improvement
Components: Android, iOS, Plugin InAppBrowser
Affects Versions: 2.7.0, 2.8.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Andrew Grieve
Labels: android, https, inappbrowser,, ios, ssl
Attachments: InAppBrowser.java
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
InAppBrowser should pick up the SSL settings from the main web view and once
we overwrite the onReceivedSslError() function, then it should allow such
URLs in the InAppBrowser too.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3576) Add support for self-signed SSL certficates in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754520#comment-13754520
]
Montyleena commented on CB-3576:
@Arjun, check my pull requests:
iOS: https://github.com/apache/cordova-ios/pull/59
Android: https://github.com/apache/cordova-android/pull/63
You can compare the code and check what i did to fix it
Add support for self-signed SSL certficates in InAppBrowser
---
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Improvement
Components: Android, iOS, Plugin InAppBrowser
Affects Versions: 2.7.0, 2.8.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Andrew Grieve
Labels: android, https, inappbrowser,, ios, ssl
Attachments: InAppBrowser.java
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
InAppBrowser should pick up the SSL settings from the main web view and once
we overwrite the onReceivedSslError() function, then it should allow such
URLs in the InAppBrowser too.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3576) Add support for self-signed SSL certficates in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754552#comment-13754552
]
Montyleena commented on CB-3576:
which platform are you working on? I can provide a patched file based on
PhoneGap 2.8.0
Add support for self-signed SSL certficates in InAppBrowser
---
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Improvement
Components: Android, iOS, Plugin InAppBrowser
Affects Versions: 2.7.0, 2.8.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Andrew Grieve
Labels: android, https, inappbrowser,, ios, ssl
Attachments: InAppBrowser.java
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
InAppBrowser should pick up the SSL settings from the main web view and once
we overwrite the onReceivedSslError() function, then it should allow such
URLs in the InAppBrowser too.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3576) Add support for self-signed SSL certficates in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754637#comment-13754637
]
Montyleena commented on CB-3576:
i would suggest you to compare the changes i have made in 2.8.0 and then
incorporate the change in 3.0 code and make your own PhoneGap lib
Add support for self-signed SSL certficates in InAppBrowser
---
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Improvement
Components: Android, iOS, Plugin InAppBrowser
Affects Versions: 2.7.0, 2.8.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Andrew Grieve
Labels: android, https, inappbrowser,, ios, ssl
Attachments: InAppBrowser.java
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
InAppBrowser should pick up the SSL settings from the main web view and once
we overwrite the onReceivedSslError() function, then it should allow such
URLs in the InAppBrowser too.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3576) Add support for self-signed SSL certficates in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745803#comment-13745803
]
Montyleena commented on CB-3576:
Wow, this is really a sad sad decision. Please check these enterprise apps:
https://itunes.apple.com/us/app/cinemate/id674386455?mt=8
https://play.google.com/store/apps/details?id=com.barco.cinemate
These apps do require privately signed URL access and i had to hack my way to
make it work in InAppBrowser. Lot of people have commented in this thread
itself that they do need this functionality. As i mentioned earlier, it's
possible to make it work in the main Cordova WebView by overwriting
onReceivedSslError(), then why there is no such option in the InAppBrowser? In
that case, you should remove this option from the main Cordova WebView too.
Joe Bowser wrote:
After reading the mailing list, it looks like this will NOT be added to
InAppBrowser, since there is very little reason to add it for a corp VPN
setup. (If your network is so secure, why do you need broken SSL?)
Corporate networks or VPNs are secure that's why we usually can't verify the
https identity through an external certification authority. You can't expect
them to change https to http for all internal sites just because InAppBrowser
doesn't handle it or give an option to the user if he wants to continue with
the link or block it.
If you compare InAppBrowser to a normal browser, a normal browser gives an
option to the user in case of a unverifiable https link, so i suppose this
should be the case for Cordova WebView as well as InAppBrowser, after all you
are treating InAppBrowser as a normal browser window.
Add support for self-signed SSL certficates in InAppBrowser
---
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Improvement
Components: Android, iOS, Plugin InAppBrowser
Affects Versions: 2.7.0, 2.8.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Joe Bowser
Labels: android, https, inappbrowser,, ios, ssl
Attachments: InAppBrowser.java
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
InAppBrowser should pick up the SSL settings from the main web view and once
we overwrite the onReceivedSslError() function, then it should allow such
URLs in the InAppBrowser too.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3576) Add support for self-signed SSL certficates in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13715165#comment-13715165
]
Montyleena commented on CB-3576:
Any update on this issue? Can my pull requests be merged?
Add support for self-signed SSL certficates in InAppBrowser
---
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Improvement
Components: Android, iOS, Plugin InAppBrowser
Affects Versions: 2.7.0, 2.8.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Steve Gill
Labels: android, https, inappbrowser,, ios, ssl
Attachments: InAppBrowser.java
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
InAppBrowser should pick up the SSL settings from the main web view and once
we overwrite the onReceivedSslError() function, then it should allow such
URLs in the InAppBrowser too.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3530) PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1
[ https://issues.apache.org/jira/browse/CB-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683068#comment-13683068 ] Montyleena commented on CB-3530: @Shazron, there is no issue with the functionality after getting this error but the InAppBrowser tool bar displays the message: Load Error so it's very misleading for the user, so this does needs to be fixed. This issue wasn't coming in 2.4.0 on iOS (i upgraded from 2.4.0 to 2.7.0 and now 2.8.0) PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1 Key: CB-3530 URL: https://issues.apache.org/jira/browse/CB-3530 Project: Apache Cordova Issue Type: Bug Components: iOS, Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Reporter: Montyleena Assignee: Shazron Abdullah Labels: crash, iOS,, inappbrowser, Fix For: 2.8.0 I have a PhoneGap app on iOS which was working fine with PhoneGap 2.3.0 but crashes with 2.7.0 with the following error: 2013-05-02 10:08:13.214 App[8896:c07] CDVWebViewDelegate: Navigation started when state=1 2013-05-02 10:08:13.215 App[8896:c07] Failed to load webpage with error: (null) The problem is: CDVWebViewDelegate.m: shouldStartLoadWithRequest() function: In switch case, default: error code is being passed as nil and in CDVInAppBrowser.m: didFailLoadWithError() function, error.localizedDescription is being referenced, which causes a crash as error object is nil. For now, i added a check in the above function to put default values for error code if the error object is nil. I hope this crash is fixed in the next PhoneGap release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3576) Privately signed https links don't work in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683069#comment-13683069
]
Montyleena commented on CB-3576:
I have added a pull request. Here are the links:
iOS: https://github.com/apache/cordova-ios/pull/59
Android: https://github.com/apache/cordova-android/pull/63
Let's hope this gets included in the next release.
Privately signed https links don't work in InAppBrowser
---
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Bug
Components: Plugin InAppBrowser
Affects Versions: 2.7.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Steve Gill
Labels: android, https, inappbrowser,, ios, ssl
Attachments: InAppBrowser.java
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
InAppBrowser should pick up the SSL settings from the main web view and once
we overwrite the onReceivedSslError() function, then it should allow such
URLs in the InAppBrowser too.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-3576) Privately signed https links don't work in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Montyleena updated CB-3576:
---
Affects Version/s: 2.8.0
Privately signed https links don't work in InAppBrowser
---
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Bug
Components: Plugin InAppBrowser
Affects Versions: 2.7.0, 2.8.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Steve Gill
Labels: android, https, inappbrowser,, ios, ssl
Attachments: InAppBrowser.java
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
InAppBrowser should pick up the SSL settings from the main web view and once
we overwrite the onReceivedSslError() function, then it should allow such
URLs in the InAppBrowser too.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3530) PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1
[ https://issues.apache.org/jira/browse/CB-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13681117#comment-13681117 ] Montyleena commented on CB-3530: I tested this today with 2.8.0 and the issue is not entirely fixed. The navigation doesn't break now and the app doesn't crash (compared to 2.7.0) but the error CDVWebViewDelegate: Navigation started when state=1 can still be seen on the XCode debug terminal and the InAppBrowser tool bar displays a Load Error so it's very misleading for the user. Here's the complete error trace: CDVWebViewDelegate: Navigation started when state=1 webView:didFailLoadWithError - CDVWebViewDelegate: Navigation started when state=1 It seems that the fix only handled nil being passed as error code but didn't handle the reason why CDVWebViewDelegate: Navigation started when state=1 error is coming PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1 Key: CB-3530 URL: https://issues.apache.org/jira/browse/CB-3530 Project: Apache Cordova Issue Type: Bug Components: iOS, Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Reporter: Montyleena Assignee: Shazron Abdullah Labels: crash, iOS,, inappbrowser, Fix For: 2.8.0 I have a PhoneGap app on iOS which was working fine with PhoneGap 2.3.0 but crashes with 2.7.0 with the following error: 2013-05-02 10:08:13.214 App[8896:c07] CDVWebViewDelegate: Navigation started when state=1 2013-05-02 10:08:13.215 App[8896:c07] Failed to load webpage with error: (null) The problem is: CDVWebViewDelegate.m: shouldStartLoadWithRequest() function: In switch case, default: error code is being passed as nil and in CDVInAppBrowser.m: didFailLoadWithError() function, error.localizedDescription is being referenced, which causes a crash as error object is nil. For now, i added a check in the above function to put default values for error code if the error object is nil. I hope this crash is fixed in the next PhoneGap release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CB-3530) PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1
[ https://issues.apache.org/jira/browse/CB-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montyleena reopened CB-3530: The issue is not entirely fixed. Please check my latest comment for more details. PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1 Key: CB-3530 URL: https://issues.apache.org/jira/browse/CB-3530 Project: Apache Cordova Issue Type: Bug Components: iOS, Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Reporter: Montyleena Assignee: Shazron Abdullah Labels: crash, iOS,, inappbrowser, Fix For: 2.8.0 I have a PhoneGap app on iOS which was working fine with PhoneGap 2.3.0 but crashes with 2.7.0 with the following error: 2013-05-02 10:08:13.214 App[8896:c07] CDVWebViewDelegate: Navigation started when state=1 2013-05-02 10:08:13.215 App[8896:c07] Failed to load webpage with error: (null) The problem is: CDVWebViewDelegate.m: shouldStartLoadWithRequest() function: In switch case, default: error code is being passed as nil and in CDVInAppBrowser.m: didFailLoadWithError() function, error.localizedDescription is being referenced, which causes a crash as error object is nil. For now, i added a check in the above function to put default values for error code if the error object is nil. I hope this crash is fixed in the next PhoneGap release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3576) Privately signed https links don't work in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13681914#comment-13681914
]
Montyleena commented on CB-3576:
I have fixed this issue for Android and iOS. I will try to generate a
contribute request so this can get included in the next release.
Privately signed https links don't work in InAppBrowser
---
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Bug
Components: Plugin InAppBrowser
Affects Versions: 2.7.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Steve Gill
Labels: android, https, inappbrowser,, ios, ssl
Attachments: InAppBrowser.java
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
InAppBrowser should pick up the SSL settings from the main web view and once
we overwrite the onReceivedSslError() function, then it should allow such
URLs in the InAppBrowser too.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3530) PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1
[ https://issues.apache.org/jira/browse/CB-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13679323#comment-13679323 ] Montyleena commented on CB-3530: Thanks for the fix! when can we expect 2.8.0 with this fix? PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1 Key: CB-3530 URL: https://issues.apache.org/jira/browse/CB-3530 Project: Apache Cordova Issue Type: Bug Components: iOS, Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Reporter: Montyleena Assignee: Shazron Abdullah Labels: crash, iOS,, inappbrowser, Fix For: 2.8.0 I have a PhoneGap app on iOS which was working fine with PhoneGap 2.3.0 but crashes with 2.7.0 with the following error: 2013-05-02 10:08:13.214 App[8896:c07] CDVWebViewDelegate: Navigation started when state=1 2013-05-02 10:08:13.215 App[8896:c07] Failed to load webpage with error: (null) The problem is: CDVWebViewDelegate.m: shouldStartLoadWithRequest() function: In switch case, default: error code is being passed as nil and in CDVInAppBrowser.m: didFailLoadWithError() function, error.localizedDescription is being referenced, which causes a crash as error object is nil. For now, i added a check in the above function to put default values for error code if the error object is nil. I hope this crash is fixed in the next PhoneGap release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3576) Privately signed https links don't work in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13676786#comment-13676786
]
Montyleena commented on CB-3576:
Another important finding:
I downloaded PhoneGap 2.7.0's source code and found that InAppBrowser.java
doesn't override onReceivedSslError() like CordovaWebViewClient.java does. I
added an implementation of onReceivedSslError() in InAppBrowser.java and did
handler.proceed() inside that and generated cordova-2.7.0.jar and ran my
application. As expected, i was able to open the https URL in InAppBrowser
after this.
So, it looks like:
InAppBrowser.java is missing the re-implementation of onReceivedSslError() and
even after this, we need some way to override this from the external code
because we don't have access to the InAppBrowser object from the PhoneGap app.
So, some form of flag or API needs to be provided through which we can set the
https URL preference similar to what we can do with the main Cordova web view
by overwriting onReceivedSslError().
Privately signed https links don't work in InAppBrowser
---
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Bug
Components: Plugin InAppBrowser
Affects Versions: 2.7.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Steve Gill
Labels: android, https, inappbrowser,, ios, ssl
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
InAppBrowser should pick up the SSL settings from the main web view and once
we overwrite the onReceivedSslError() function, then it should allow such
URLs in the InAppBrowser too.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CB-3576) Privately signed https links don't work in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13675635#comment-13675635
]
Montyleena edited comment on CB-3576 at 6/5/13 6:31 AM:
Another thing which points to this being a bug:
If we set android:debuggable=true in AndroidManifest.xml, the self-signed
https URLs start working in the main web view but doesn't work in the
InAppBrowser. If we set android:debuggable=false, the URLs get blocked in the
main web view but the solution i posted above works for the main web view only.
was (Author: montylee):
Another thing which points to this being a bug:
If we set android:debuggable=true in AndroidManifest.xml, the self-signed
https URL start working in the main web view but doesn't work in the
InAppBrowser. If we set android:debuggable=false, the URLs get blocked but
the solution i posted above works for the main web view only.
Privately signed https links don't work in InAppBrowser
---
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Bug
Components: Plugin InAppBrowser
Affects Versions: 2.7.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Steve Gill
Labels: android, https, inappbrowser,, ios, ssl
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
InAppBrowser should pick up the SSL settings from the main web view and once
we overwrite the onReceivedSslError() function, then it should allow such
URLs in the InAppBrowser too.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CB-3576) Allowing local https links in InAppBrowser
Montyleena created CB-3576:
--
Summary: Allowing local https links in InAppBrowser
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Improvement
Components: Plugin InAppBrowser
Affects Versions: 2.7.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Steve Gill
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Can we get this feature in PhoneGap? Other option will be to give a simple
API/interface to enable users to open such URLs instead of blocking them by
default.
Right now, we have to overwrite the following API in Android to access such
URLs:
public class CustomWebViewClient extends CordovaWebViewClient {
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
// Ignore SSL errors and proceed
Log.d(LOG_TAG, Ignoring SSL certificate errors...);
handler.proceed();
}
}
And similar type of code needs to be written for iOS.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-3576) Allowing local https links in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Montyleena updated CB-3576:
---
Description:
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Can we get this feature in PhoneGap? Other option will be to give a simple
API/interface to enable users to open such URLs instead of blocking them by
default.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
// Ignore SSL errors and proceed
Log.d(LOG_TAG, Ignoring SSL certificate errors...);
handler.proceed();
}
}
In the main class, use this as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
was:
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Can we get this feature in PhoneGap? Other option will be to give a simple
API/interface to enable users to open such URLs instead of blocking them by
default.
Right now, we have to overwrite the following API in Android to access such
URLs:
public class CustomWebViewClient extends CordovaWebViewClient {
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
// Ignore SSL errors and proceed
Log.d(LOG_TAG, Ignoring SSL certificate errors...);
handler.proceed();
}
}
And similar type of code needs to be written for iOS.
Allowing local https links in InAppBrowser
--
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Improvement
Components: Plugin InAppBrowser
Affects Versions: 2.7.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Steve Gill
Labels: https, ssl
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Can we get this feature in PhoneGap? Other option will be to give a simple
API/interface to enable users to open such URLs instead of blocking them by
default.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
// Ignore SSL errors and proceed
Log.d(LOG_TAG, Ignoring SSL certificate errors...);
handler.proceed();
}
}
In the main class, use this as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-3576) Allowing local https links in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Montyleena updated CB-3576:
---
Issue Type: Improvement (was: Bug)
Allowing local https links in InAppBrowser
--
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Improvement
Components: Plugin InAppBrowser
Affects Versions: 2.7.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Steve Gill
Labels: https, ssl
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Can we get this feature in PhoneGap? Other option will be to give a simple
API/interface to enable users to open such URLs instead of blocking them by
default.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
// Ignore SSL errors and proceed
Log.d(LOG_TAG, Ignoring SSL certificate errors...);
handler.proceed();
}
}
In the main class, use this as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-3576) Allowing local https links in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Montyleena updated CB-3576:
---
Issue Type: Bug (was: Improvement)
Allowing local https links in InAppBrowser
--
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Bug
Components: Plugin InAppBrowser
Affects Versions: 2.7.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Steve Gill
Labels: https, ssl
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Can we get this feature in PhoneGap? Other option will be to give a simple
API/interface to enable users to open such URLs instead of blocking them by
default.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
// Ignore SSL errors and proceed
Log.d(LOG_TAG, Ignoring SSL certificate errors...);
handler.proceed();
}
}
In the main class, use this as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3576) Allowing local https links in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13675625#comment-13675625
]
Montyleena commented on CB-3576:
Should the InAppBrowser obey the SSL rules set by the parent web view? Once, we
overwrite onReceivedSslError() of the main web view and write
handler.proceed(), then even InAppBrowser should allow the locally signed https
URLs.
Allowing local https links in InAppBrowser
--
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Improvement
Components: Plugin InAppBrowser
Affects Versions: 2.7.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Steve Gill
Labels: https, ssl
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Can we get this feature in PhoneGap? Other option will be to give a simple
API/interface to enable users to open such URLs instead of blocking them by
default.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
// Ignore SSL errors and proceed
Log.d(LOG_TAG, Ignoring SSL certificate errors...);
handler.proceed();
}
}
In the main class, use this as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3530) PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1
[ https://issues.apache.org/jira/browse/CB-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13675628#comment-13675628 ] Montyleena commented on CB-3530: Can you please check https://issues.apache.org/jira/browse/CB-3576 and https://issues.apache.org/jira/browse/CB-3531? I think CB-3576 can be fixed easily. It's really a problem that we can't access locally signed https URLs in InAppBrowser. PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1 Key: CB-3530 URL: https://issues.apache.org/jira/browse/CB-3530 Project: Apache Cordova Issue Type: Bug Components: iOS, Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Reporter: Montyleena Assignee: Shazron Abdullah Labels: crash, iOS,, inappbrowser, Fix For: 2.8.0 I have a PhoneGap app on iOS which was working fine with PhoneGap 2.3.0 but crashes with 2.7.0 with the following error: 2013-05-02 10:08:13.214 App[8896:c07] CDVWebViewDelegate: Navigation started when state=1 2013-05-02 10:08:13.215 App[8896:c07] Failed to load webpage with error: (null) The problem is: CDVWebViewDelegate.m: shouldStartLoadWithRequest() function: In switch case, default: error code is being passed as nil and in CDVInAppBrowser.m: didFailLoadWithError() function, error.localizedDescription is being referenced, which causes a crash as error object is nil. For now, i added a check in the above function to put default values for error code if the error object is nil. I hope this crash is fixed in the next PhoneGap release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-3576) Privately signed https links don't work in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Montyleena updated CB-3576:
---
Labels: android https inappbrowser, ios ssl (was: https ssl)
Description:
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
// Ignore SSL errors and proceed
Log.d(LOG_TAG, Ignoring SSL certificate errors...);
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
InAppBrowser should pick up the SSL settings from the main web view and once we
overwrite the onReceivedSslError() function, then it should allow such URLs in
the InAppBrowser too.
was:
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Can we get this feature in PhoneGap? Other option will be to give a simple
API/interface to enable users to open such URLs instead of blocking them by
default.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
// Ignore SSL errors and proceed
Log.d(LOG_TAG, Ignoring SSL certificate errors...);
handler.proceed();
}
}
In the main class, use this as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
Issue Type: Bug (was: Improvement)
Summary: Privately signed https links don't work in InAppBrowser (was:
Allowing local https links in InAppBrowser)
Privately signed https links don't work in InAppBrowser
---
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Bug
Components: Plugin InAppBrowser
Affects Versions: 2.7.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Steve Gill
Labels: android, https, inappbrowser,, ios, ssl
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
// Ignore SSL errors and proceed
Log.d(LOG_TAG, Ignoring SSL certificate errors...);
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
[jira] [Updated] (CB-3576) Privately signed https links don't work in InAppBrowser
[
https://issues.apache.org/jira/browse/CB-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Montyleena updated CB-3576:
---
Description:
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
InAppBrowser should pick up the SSL settings from the main web view and once we
overwrite the onReceivedSslError() function, then it should allow such URLs in
the InAppBrowser too.
was:
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
// Ignore SSL errors and proceed
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
InAppBrowser should pick up the SSL settings from the main web view and once we
overwrite the onReceivedSslError() function, then it should allow such URLs in
the InAppBrowser too.
Privately signed https links don't work in InAppBrowser
---
Key: CB-3576
URL: https://issues.apache.org/jira/browse/CB-3576
Project: Apache Cordova
Issue Type: Bug
Components: Plugin InAppBrowser
Affects Versions: 2.7.0
Environment: Android and iOS
Reporter: Montyleena
Assignee: Steve Gill
Labels: android, https, inappbrowser,, ios, ssl
Local https links are blocked by default in InAppBrowser (links using a local
SSL certificate which can't be verified by a 3rd party). Ideally, user should
be given an option to proceed or cancel the request like the default
desktop/mobile browsers do.
Right now, we have to overwrite the following API in Android to access such
URLs but onReceivedSslError() function gets called only for the main PhoneGap
window browser and not for InAppBrowser.
Create a new class:
public class CustomWebViewClient extends CordovaWebViewClient {
public static final String LOG_TAG = Plugin;
public CustomWebViewClient(DroidGap ctx) {
super(ctx);
Log.d(LOG_TAG, Constructor!);
}
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
handler.proceed();
}
}
In the main class, we use our custom class as a web view client
CordovaWebViewClient webViewClient = new CustomWebViewClient(this);
webViewClient.setWebView(this.appView);
this.appView.setWebViewClient(webViewClient);
And similar type of code needs to be written for iOS.
InAppBrowser should pick up the SSL settings from the main web view and once
we overwrite the onReceivedSslError() function, then it should allow such
URLs in the InAppBrowser too.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
[jira] [Commented] (CB-3531) InAppBrowser hangs the app in case of no/delayed response from server
[
https://issues.apache.org/jira/browse/CB-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672940#comment-13672940
]
Montyleena commented on CB-3531:
I modified some code in CDVInAppBrowser.m but it didn't fix the problem. Looks
like the main thread hangs as soon as we call [self.webView
loadRequest:request] and after that calling [self.webView stopLoading] or
[self.webView loadHTMLString:nil baseURL:nil] has no effect. I added some code
in the close() method. As soon as close() method is called, i tried setting the
URL to about:blank and then after a small delay i added the code to close the
InAppBrowser using dismissViewControllerAnimated:completion:.
The logic works with a normal web page i.e. when i click the Done button, it
sets the URL to about:blank and then after a delay, it closes the child browser
window. But when i open a non/slow responding page and click on Done button
before it has finished loading, the app doesn't respond. I tried setting the
URL to about:blank in the close() method and also tried calling [self.view
stopLoading] but it doesn't help.
The behavior is different in Android. In Android, i am able to click the Done
button and close the child browser but the main app remains in frozen state. I
couldn't modify and test the behavior in Android as only a compiled jar file is
given with PhoneGap.
Is there a way to make this more robust? i.e if a URL is not responding, then
we should be able to cancel that request so that it doesn't clog the main
thread. At least, on Android, can we try to fix this if possible? Maybe, you
can try stopping the URL loading request when Done button is clicked.
Here's a small .html code using which you can reproduce this (basically just
running an infinite while loop). Put this html in your local web server and
access it with InAppBrowser:
!DOCTYPE html
html
head
title
index
/title
style
/*page style*/
/style
/head
body
/body
script type=text/javascript
/* Page script*/
//window.setInterval(function(){
while(1){
console.log(interval);
}
//},500);
/script
/html
InAppBrowser hangs the app in case of no/delayed response from server
-
Key: CB-3531
URL: https://issues.apache.org/jira/browse/CB-3531
Project: Apache Cordova
Issue Type: Bug
Components: Plugin InAppBrowser
Affects Versions: 2.7.0
Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1
Android 4.1.2
Reporter: Montyleena
Assignee: Steve Gill
Labels: hangs, inappbrowser,
The InappBrowser hangs the entire application if the URL takes long time to
respond or doesn't respond. Even if we manage to close the InAppBrowser using
the Done button and return to the main application, the application stops
responding. The expected behavior is that once we close the child browser by
clicking the Done button, it should cancel the URL request but this doesn't
happen. The application remains in non-responding state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CB-3531) InAppBrowser hangs the app in case of no/delayed response from server
[
https://issues.apache.org/jira/browse/CB-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672940#comment-13672940
]
Montyleena edited comment on CB-3531 at 6/3/13 9:31 AM:
I modified some code in CDVInAppBrowser.m but it didn't fix the problem. Looks
like the main thread hangs as soon as we call [self.webView
loadRequest:request] and after that calling [self.webView stopLoading] or
[self.webView loadHTMLString:nil baseURL:nil] has no effect. I added some code
in the close() method. As soon as close() method is called, i tried setting the
URL to about:blank and then after a small delay i added the code to close the
InAppBrowser using dismissViewControllerAnimated:completion:.
The logic works with a normal web page i.e. when i click the Done button, it
sets the URL to about:blank and then after a delay, it closes the child browser
window. But when i open a non/slow responding page and click on Done button
before it has finished loading, the app doesn't respond. I tried setting the
URL to about:blank in the close() method and also tried calling [self.view
stopLoading] but it doesn't help.
The behavior is different in Android. In Android, i am able to click the Done
button and close the child browser but the main app remains in frozen state. I
couldn't modify and test the behavior in Android as only a compiled jar file is
given with PhoneGap.
Is there a way to make this more robust? i.e if a URL is not responding, then
we should be able to cancel that request so that it doesn't clog the main
thread. At least, on Android, can we try to fix this if possible? Maybe, you
can try stopping the URL loading request when Done button is clicked.
Here's a small .html code using which you can reproduce this (basically just
running an infinite while loop). Put this html in your local web server and
access it with InAppBrowser:
!DOCTYPE html
html
head
title
index
/title
style
/style
/head
body
/body
script type=text/javascript
//window.setInterval(function(){
while(1){
console.log(interval);
}
//},500);
/script
/html
was (Author: montylee):
I modified some code in CDVInAppBrowser.m but it didn't fix the problem.
Looks like the main thread hangs as soon as we call [self.webView
loadRequest:request] and after that calling [self.webView stopLoading] or
[self.webView loadHTMLString:nil baseURL:nil] has no effect. I added some code
in the close() method. As soon as close() method is called, i tried setting the
URL to about:blank and then after a small delay i added the code to close the
InAppBrowser using dismissViewControllerAnimated:completion:.
The logic works with a normal web page i.e. when i click the Done button, it
sets the URL to about:blank and then after a delay, it closes the child browser
window. But when i open a non/slow responding page and click on Done button
before it has finished loading, the app doesn't respond. I tried setting the
URL to about:blank in the close() method and also tried calling [self.view
stopLoading] but it doesn't help.
The behavior is different in Android. In Android, i am able to click the Done
button and close the child browser but the main app remains in frozen state. I
couldn't modify and test the behavior in Android as only a compiled jar file is
given with PhoneGap.
Is there a way to make this more robust? i.e if a URL is not responding, then
we should be able to cancel that request so that it doesn't clog the main
thread. At least, on Android, can we try to fix this if possible? Maybe, you
can try stopping the URL loading request when Done button is clicked.
Here's a small .html code using which you can reproduce this (basically just
running an infinite while loop). Put this html in your local web server and
access it with InAppBrowser:
!DOCTYPE html
html
head
title
index
/title
style
/*page style*/
/style
/head
body
/body
script type=text/javascript
/* Page script*/
//window.setInterval(function(){
while(1){
console.log(interval);
}
//},500);
/script
/html
InAppBrowser hangs the app in case of no/delayed response from server
-
Key: CB-3531
URL:
[jira] [Commented] (CB-3530) PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1
[ https://issues.apache.org/jira/browse/CB-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672825#comment-13672825 ] Montyleena commented on CB-3530: That's great! Thanks a lot! PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1 Key: CB-3530 URL: https://issues.apache.org/jira/browse/CB-3530 Project: Apache Cordova Issue Type: Bug Components: iOS, Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Reporter: Montyleena Assignee: Shazron Abdullah Labels: crash, iOS,, inappbrowser, Fix For: 2.8.0 I have a PhoneGap app on iOS which was working fine with PhoneGap 2.3.0 but crashes with 2.7.0 with the following error: 2013-05-02 10:08:13.214 App[8896:c07] CDVWebViewDelegate: Navigation started when state=1 2013-05-02 10:08:13.215 App[8896:c07] Failed to load webpage with error: (null) The problem is: CDVWebViewDelegate.m: shouldStartLoadWithRequest() function: In switch case, default: error code is being passed as nil and in CDVInAppBrowser.m: didFailLoadWithError() function, error.localizedDescription is being referenced, which causes a crash as error object is nil. For now, i added a check in the above function to put default values for error code if the error object is nil. I hope this crash is fixed in the next PhoneGap release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3531) InAppBrowser hangs the app in case of no/delayed response from server
[ https://issues.apache.org/jira/browse/CB-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672826#comment-13672826 ] Montyleena commented on CB-3531: Thanks for the workaround idea. I will try the same. To reproduce this, you need to open some URL where the JavaScript takes time to load (you would have often seem a warning on the browser and scripts are slowing down the page and if we want to disable the script). The URL i am testing with is a local one. I'll post here if i come across some external URL. InAppBrowser hangs the app in case of no/delayed response from server - Key: CB-3531 URL: https://issues.apache.org/jira/browse/CB-3531 Project: Apache Cordova Issue Type: Bug Components: Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Android 4.1.2 Reporter: Montyleena Assignee: Steve Gill Labels: hangs, inappbrowser, The InappBrowser hangs the entire application if the URL takes long time to respond or doesn't respond. Even if we manage to close the InAppBrowser using the Done button and return to the main application, the application stops responding. The expected behavior is that once we close the child browser by clicking the Done button, it should cancel the URL request but this doesn't happen. The application remains in non-responding state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CB-3531) InAppBrowser hangs the app in case of no/delayed response from server
[ https://issues.apache.org/jira/browse/CB-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672826#comment-13672826 ] Montyleena edited comment on CB-3531 at 6/3/13 5:09 AM: Thanks for the workaround idea. I will try the same. To reproduce this, you need to open some URL where the JavaScript takes time to load (you would have often seen a warning on the browser that scripts are slowing down the page and if we want to disable the script). The URL i am testing with is a local one. I'll post here if i come across some external URL. was (Author: montylee): Thanks for the workaround idea. I will try the same. To reproduce this, you need to open some URL where the JavaScript takes time to load (you would have often seem a warning on the browser and scripts are slowing down the page and if we want to disable the script). The URL i am testing with is a local one. I'll post here if i come across some external URL. InAppBrowser hangs the app in case of no/delayed response from server - Key: CB-3531 URL: https://issues.apache.org/jira/browse/CB-3531 Project: Apache Cordova Issue Type: Bug Components: Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Android 4.1.2 Reporter: Montyleena Assignee: Steve Gill Labels: hangs, inappbrowser, The InappBrowser hangs the entire application if the URL takes long time to respond or doesn't respond. Even if we manage to close the InAppBrowser using the Done button and return to the main application, the application stops responding. The expected behavior is that once we close the child browser by clicking the Done button, it should cancel the URL request but this doesn't happen. The application remains in non-responding state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CB-3531) InAppBrowser hangs the app in case of no/delayed response from server
[ https://issues.apache.org/jira/browse/CB-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672826#comment-13672826 ] Montyleena edited comment on CB-3531 at 6/3/13 5:12 AM: Thanks for the workaround idea. I will try the same (Hopefully the close event will get fired when i click close). To reproduce this, you need to open some URL where the JavaScript takes time to load (you would have often seen a warning on the browser that scripts are slowing down the page and if we want to disable the script). The URL i am testing with is a local one. I'll post here if i come across some external URL. was (Author: montylee): Thanks for the workaround idea. I will try the same. To reproduce this, you need to open some URL where the JavaScript takes time to load (you would have often seen a warning on the browser that scripts are slowing down the page and if we want to disable the script). The URL i am testing with is a local one. I'll post here if i come across some external URL. InAppBrowser hangs the app in case of no/delayed response from server - Key: CB-3531 URL: https://issues.apache.org/jira/browse/CB-3531 Project: Apache Cordova Issue Type: Bug Components: Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Android 4.1.2 Reporter: Montyleena Assignee: Steve Gill Labels: hangs, inappbrowser, The InappBrowser hangs the entire application if the URL takes long time to respond or doesn't respond. Even if we manage to close the InAppBrowser using the Done button and return to the main application, the application stops responding. The expected behavior is that once we close the child browser by clicking the Done button, it should cancel the URL request but this doesn't happen. The application remains in non-responding state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CB-3531) InAppBrowser hangs the app in case of no/delayed response from server
[ https://issues.apache.org/jira/browse/CB-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672826#comment-13672826 ] Montyleena edited comment on CB-3531 at 6/3/13 5:12 AM: Thanks for the workaround idea. I will try the same (Hopefully the close event will get fired when i click the Done button). To reproduce this, you need to open some URL where the JavaScript takes time to load (you would have often seen a warning on the browser that scripts are slowing down the page and if we want to disable the script). The URL i am testing with is a local one. I'll post here if i come across some external URL. was (Author: montylee): Thanks for the workaround idea. I will try the same (Hopefully the close event will get fired when i click close). To reproduce this, you need to open some URL where the JavaScript takes time to load (you would have often seen a warning on the browser that scripts are slowing down the page and if we want to disable the script). The URL i am testing with is a local one. I'll post here if i come across some external URL. InAppBrowser hangs the app in case of no/delayed response from server - Key: CB-3531 URL: https://issues.apache.org/jira/browse/CB-3531 Project: Apache Cordova Issue Type: Bug Components: Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Android 4.1.2 Reporter: Montyleena Assignee: Steve Gill Labels: hangs, inappbrowser, The InappBrowser hangs the entire application if the URL takes long time to respond or doesn't respond. Even if we manage to close the InAppBrowser using the Done button and return to the main application, the application stops responding. The expected behavior is that once we close the child browser by clicking the Done button, it should cancel the URL request but this doesn't happen. The application remains in non-responding state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3531) InAppBrowser hangs the app in case of no/delayed response from server
[ https://issues.apache.org/jira/browse/CB-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672830#comment-13672830 ] Montyleena commented on CB-3531: oh just read that we need to load about:blank before close, i am not sure i can do that. Let me try this and i will post the results here InAppBrowser hangs the app in case of no/delayed response from server - Key: CB-3531 URL: https://issues.apache.org/jira/browse/CB-3531 Project: Apache Cordova Issue Type: Bug Components: Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Android 4.1.2 Reporter: Montyleena Assignee: Steve Gill Labels: hangs, inappbrowser, The InappBrowser hangs the entire application if the URL takes long time to respond or doesn't respond. Even if we manage to close the InAppBrowser using the Done button and return to the main application, the application stops responding. The expected behavior is that once we close the child browser by clicking the Done button, it should cancel the URL request but this doesn't happen. The application remains in non-responding state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CB-3531) InAppBrowser hangs the app in case of no/delayed response from server
[ https://issues.apache.org/jira/browse/CB-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672830#comment-13672830 ] Montyleena edited comment on CB-3531 at 6/3/13 5:31 AM: oh just read that we need to load about:blank before close, i am not sure i can do that. I will try to trap the exit event for the InAppBrowser and see if i can load about:blank before the browser closes. I will post my findings here. was (Author: montylee): oh just read that we need to load about:blank before close, i am not sure i can do that. Let me try this and i will post the results here InAppBrowser hangs the app in case of no/delayed response from server - Key: CB-3531 URL: https://issues.apache.org/jira/browse/CB-3531 Project: Apache Cordova Issue Type: Bug Components: Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Android 4.1.2 Reporter: Montyleena Assignee: Steve Gill Labels: hangs, inappbrowser, The InappBrowser hangs the entire application if the URL takes long time to respond or doesn't respond. Even if we manage to close the InAppBrowser using the Done button and return to the main application, the application stops responding. The expected behavior is that once we close the child browser by clicking the Done button, it should cancel the URL request but this doesn't happen. The application remains in non-responding state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CB-3531) InAppBrowser hangs the app in case of no/delayed response from server
[ https://issues.apache.org/jira/browse/CB-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672830#comment-13672830 ] Montyleena edited comment on CB-3531 at 6/3/13 5:33 AM: oh just read that we need to load about:blank before close, i am not sure i can do that. I will try to trap the exit event for the InAppBrowser and see if i can load about:blank before the browser closes. I will post my findings here. Regarding your point about iOS, the issue comes on Android too. was (Author: montylee): oh just read that we need to load about:blank before close, i am not sure i can do that. I will try to trap the exit event for the InAppBrowser and see if i can load about:blank before the browser closes. I will post my findings here. InAppBrowser hangs the app in case of no/delayed response from server - Key: CB-3531 URL: https://issues.apache.org/jira/browse/CB-3531 Project: Apache Cordova Issue Type: Bug Components: Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Android 4.1.2 Reporter: Montyleena Assignee: Steve Gill Labels: hangs, inappbrowser, The InappBrowser hangs the entire application if the URL takes long time to respond or doesn't respond. Even if we manage to close the InAppBrowser using the Done button and return to the main application, the application stops responding. The expected behavior is that once we close the child browser by clicking the Done button, it should cancel the URL request but this doesn't happen. The application remains in non-responding state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3530) PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1
[ https://issues.apache.org/jira/browse/CB-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13671267#comment-13671267 ] Montyleena commented on CB-3530: Try with this URL: en.wikipedia.org/wiki/Hashtag Click on different items in the TOC like Origin, Style etc. if you don't get the error the 1st time after clicking on an item, then scroll to the top of this URL page and click on another link, eventually you will get the following error: CDVWebViewDelegate: Navigation started when state=1 webView: didFailLoadWithError - (null) *** WebKit discarded an uncaught exception in the webView:decidePolicyForNavigationAction:request:frame:decisionListener: delegate: NSInvalidArgumentException *** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[3] I can reproduce this even on the iPad simulator. After this error, all links stop working in the same instance of InAppBrowser and i get 3 lines of error mentioned above. PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1 Key: CB-3530 URL: https://issues.apache.org/jira/browse/CB-3530 Project: Apache Cordova Issue Type: Bug Components: iOS, Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Reporter: Montyleena Assignee: Shazron Abdullah Labels: crash, iOS,, inappbrowser, Fix For: 2.8.0 I have a PhoneGap app on iOS which was working fine with PhoneGap 2.3.0 but crashes with 2.7.0 with the following error: 2013-05-02 10:08:13.214 App[8896:c07] CDVWebViewDelegate: Navigation started when state=1 2013-05-02 10:08:13.215 App[8896:c07] Failed to load webpage with error: (null) The problem is: CDVWebViewDelegate.m: shouldStartLoadWithRequest() function: In switch case, default: error code is being passed as nil and in CDVInAppBrowser.m: didFailLoadWithError() function, error.localizedDescription is being referenced, which causes a crash as error object is nil. For now, i added a check in the above function to put default values for error code if the error object is nil. I hope this crash is fixed in the next PhoneGap release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3530) PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1
[ https://issues.apache.org/jira/browse/CB-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13671269#comment-13671269 ] Montyleena commented on CB-3530: Thanks! that sounds good. Will this fix be included in 2.8.0? Can you please also look at this issue: https://issues.apache.org/jira/browse/CB-3531 PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1 Key: CB-3530 URL: https://issues.apache.org/jira/browse/CB-3530 Project: Apache Cordova Issue Type: Bug Components: iOS, Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Reporter: Montyleena Assignee: Shazron Abdullah Labels: crash, iOS,, inappbrowser, Fix For: 2.8.0 I have a PhoneGap app on iOS which was working fine with PhoneGap 2.3.0 but crashes with 2.7.0 with the following error: 2013-05-02 10:08:13.214 App[8896:c07] CDVWebViewDelegate: Navigation started when state=1 2013-05-02 10:08:13.215 App[8896:c07] Failed to load webpage with error: (null) The problem is: CDVWebViewDelegate.m: shouldStartLoadWithRequest() function: In switch case, default: error code is being passed as nil and in CDVInAppBrowser.m: didFailLoadWithError() function, error.localizedDescription is being referenced, which causes a crash as error object is nil. For now, i added a check in the above function to put default values for error code if the error object is nil. I hope this crash is fixed in the next PhoneGap release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3531) InAppBrowser hangs the app in case of no/delayed response from server
[ https://issues.apache.org/jira/browse/CB-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13671270#comment-13671270 ] Montyleena commented on CB-3531: Does calling ref.close() from the main application cancel the URL request too? Maybe, we can call ref.close() explicitly when Done button is clicked. To reproduce this issue, we can access some URL where the script takes long time to respond InAppBrowser hangs the app in case of no/delayed response from server - Key: CB-3531 URL: https://issues.apache.org/jira/browse/CB-3531 Project: Apache Cordova Issue Type: Bug Components: Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Android 4.1.2 Reporter: Montyleena Assignee: Steve Gill Labels: hangs, inappbrowser, The InappBrowser hangs the entire application if the URL takes long time to respond or doesn't respond. Even if we manage to close the InAppBrowser using the Done button and return to the main application, the application stops responding. The expected behavior is that once we close the child browser by clicking the Done button, it should cancel the URL request but this doesn't happen. The application remains in non-responding state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3530) PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1
[ https://issues.apache.org/jira/browse/CB-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670030#comment-13670030 ] Montyleena commented on CB-3530: wow, thanks for the info. I hope this gets fixed in the next release. PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1 Key: CB-3530 URL: https://issues.apache.org/jira/browse/CB-3530 Project: Apache Cordova Issue Type: Bug Components: Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Reporter: Montyleena Assignee: Steve Gill Labels: crash, iOS,, inappbrowser, I have a PhoneGap app on iOS which was working fine with PhoneGap 2.3.0 but crashes with 2.7.0 with the following error: 2013-05-02 10:08:13.214 App[8896:c07] CDVWebViewDelegate: Navigation started when state=1 2013-05-02 10:08:13.215 App[8896:c07] Failed to load webpage with error: (null) The problem is: CDVWebViewDelegate.m: shouldStartLoadWithRequest() function: In switch case, default: error code is being passed as nil and in CDVInAppBrowser.m: didFailLoadWithError() function, error.localizedDescription is being referenced, which causes a crash as error object is nil. For now, i added a check in the above function to put default values for error code if the error object is nil. I hope this crash is fixed in the next PhoneGap release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CB-3530) PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1
[ https://issues.apache.org/jira/browse/CB-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670030#comment-13670030 ] Montyleena edited comment on CB-3530 at 5/30/13 4:23 AM: - wow, thanks for the info. Apparently, the error CDVWebViewDelegate: Navigation started when state=1 is only coming with 2.7.0, so I hope this gets fixed in the next release. was (Author: montylee): wow, thanks for the info. I hope this gets fixed in the next release. PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1 Key: CB-3530 URL: https://issues.apache.org/jira/browse/CB-3530 Project: Apache Cordova Issue Type: Bug Components: Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Reporter: Montyleena Assignee: Steve Gill Labels: crash, iOS,, inappbrowser, I have a PhoneGap app on iOS which was working fine with PhoneGap 2.3.0 but crashes with 2.7.0 with the following error: 2013-05-02 10:08:13.214 App[8896:c07] CDVWebViewDelegate: Navigation started when state=1 2013-05-02 10:08:13.215 App[8896:c07] Failed to load webpage with error: (null) The problem is: CDVWebViewDelegate.m: shouldStartLoadWithRequest() function: In switch case, default: error code is being passed as nil and in CDVInAppBrowser.m: didFailLoadWithError() function, error.localizedDescription is being referenced, which causes a crash as error object is nil. For now, i added a check in the above function to put default values for error code if the error object is nil. I hope this crash is fixed in the next PhoneGap release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CB-3530) PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1
[ https://issues.apache.org/jira/browse/CB-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670030#comment-13670030 ] Montyleena edited comment on CB-3530 at 5/30/13 4:24 AM: - wow, thanks for the info. Apparently, the error CDVWebViewDelegate: Navigation started when state=1 is only coming with 2.7.0. After getting this error, we see Load error in the InAppBrowser status bar. I hope this gets fixed in the next release. was (Author: montylee): wow, thanks for the info. Apparently, the error CDVWebViewDelegate: Navigation started when state=1 is only coming with 2.7.0, so I hope this gets fixed in the next release. PhoneGap app crashes on iOS with error CDVWebViewDelegate: Navigation started when state=1 Key: CB-3530 URL: https://issues.apache.org/jira/browse/CB-3530 Project: Apache Cordova Issue Type: Bug Components: Plugin InAppBrowser Affects Versions: 2.7.0 Environment: Mac OSX 10.8.3, XCode 4.6.2, iOS 6.1 Reporter: Montyleena Assignee: Steve Gill Labels: crash, iOS,, inappbrowser, I have a PhoneGap app on iOS which was working fine with PhoneGap 2.3.0 but crashes with 2.7.0 with the following error: 2013-05-02 10:08:13.214 App[8896:c07] CDVWebViewDelegate: Navigation started when state=1 2013-05-02 10:08:13.215 App[8896:c07] Failed to load webpage with error: (null) The problem is: CDVWebViewDelegate.m: shouldStartLoadWithRequest() function: In switch case, default: error code is being passed as nil and in CDVInAppBrowser.m: didFailLoadWithError() function, error.localizedDescription is being referenced, which causes a crash as error object is nil. For now, i added a check in the above function to put default values for error code if the error object is nil. I hope this crash is fixed in the next PhoneGap release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
