[jira] [Updated] (CB-14048) Inappbrowser allowedSchemes doesn't check empty string
[
https://issues.apache.org/jira/browse/CB-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reed Richards updated CB-14048:
---
Description:
The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if
_AllowSchemes_ contains empty string after having being loaded, respectively
only if _null_, which could lead to error in case a custom scheme is use but
not set as white listed schema
What I mean is that, if no _preference_ would be set in _config.xml_ but a
custom scheme would be used (my case) then the variable _allowSchemes_ won't be
_null_ but will contains an _empty string_
In InAppBrowser.java
{code:java}
else if (!url.startsWith("http:") && !url.startsWith("https:") &&
url.matches("^[a-z]*://.*?$")) {
if (allowedSchemes == null) {
String allowed = preferences.getString("AllowedSchemes", "");
allowedSchemes = allowed.split(",");
}
if (allowedSchemes != null) { // <--- If preference AllowedSchemes is
not specified, variable allowedSchemes not gonna be null but an array
containing an empty string
for (String scheme : allowedSchemes) {
if (url.startsWith(scheme)) {
if (url.startsWith(scheme)) { // <-- which leads to the
problem "urlidontwanttowhilelist://".startsWith("") == true{code}
I would like to improve this check for example like following
{code:java}
if (url.startsWith(scheme) && !"".equals(scheme)) {
{code}
Thx in advance for the improvement
was:
The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if
_AllowSchemes_ is empty after having being loaded, respectively only if _null_,
which could lead to error in case a custom scheme is use but not set as white
listed schema
What I mean is that, if no _preference_ would be set in _config.xml_ but a
custom scheme would be used (my case) then the variable _allowSchemes_ won't be
_null_ but an _empty string_
In InAppBrowser.java
{code:java}
else if (!url.startsWith("http:") && !url.startsWith("https:") &&
url.matches("^[a-z]*://.*?$")) {
if (allowedSchemes == null) {
String allowed = preferences.getString("AllowedSchemes", "");
allowedSchemes = allowed.split(",");
}
if (allowedSchemes != null) { // <--- If preference AllowedSchemes is
not specified, variable allowedSchemes gonna be empty ("") not null
for (String scheme : allowedSchemes) {
if (url.startsWith(scheme)) {
if (url.startsWith(scheme)) { // <-- which leads to the
problem "urlidontwanttowhilelist://".startsWith("") == true{code}
I would like to improve this check for example like following
{code:java}
if (url.startsWith(scheme) && !"".equals(scheme)) {
{code}
Thx in advance for the improvement
> Inappbrowser allowedSchemes doesn't check empty string
> --
>
> Key: CB-14048
> URL: https://issues.apache.org/jira/browse/CB-14048
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Reporter: Reed Richards
>Priority: Minor
>
> The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if
> _AllowSchemes_ contains empty string after having being loaded, respectively
> only if _null_, which could lead to error in case a custom scheme is use but
> not set as white listed schema
> What I mean is that, if no _preference_ would be set in _config.xml_ but a
> custom scheme would be used (my case) then the variable _allowSchemes_ won't
> be _null_ but will contains an _empty string_
>
> In InAppBrowser.java
>
> {code:java}
> else if (!url.startsWith("http:") && !url.startsWith("https:") &&
> url.matches("^[a-z]*://.*?$")) {
> if (allowedSchemes == null) {
> String allowed = preferences.getString("AllowedSchemes", "");
> allowedSchemes = allowed.split(",");
> }
> if (allowedSchemes != null) { // <--- If preference AllowedSchemes
> is not specified, variable allowedSchemes not gonna be null but an array
> containing an empty string
>for (String scheme : allowedSchemes) {
>if (url.startsWith(scheme)) {
> if (url.startsWith(scheme)) { // <-- which leads to the
> problem "urlidontwanttowhilelist://".startsWith("") == true{code}
>
> I would like to improve this check for example like following
>
> {code:java}
> if (url.startsWith(scheme) && !"".equals(scheme)) {
> {code}
>
> Thx in advance for the improvement
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14048) Inappbrowser allowedSchemes doesn't check empty string
[
https://issues.apache.org/jira/browse/CB-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reed Richards updated CB-14048:
---
Description:
The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if
_AllowSchemes_ is empty after having being loaded, respectively only if _null_,
which could lead to error in case a custom scheme is use but not set as white
listed schema
What I mean is that, if no _preference_ would be set in _config.xml_ but a
custom scheme would be used (my case) then the variable _allowSchemes_ won't be
_null_ but an _empty string_
In InAppBrowser.java
{code:java}
else if (!url.startsWith("http:") && !url.startsWith("https:") &&
url.matches("^[a-z]*://.*?$")) {
if (allowedSchemes == null) {
String allowed = preferences.getString("AllowedSchemes", "");
allowedSchemes = allowed.split(",");
}
if (allowedSchemes != null) { // <--- If preference AllowedSchemes is
not specified, variable allowedSchemes gonna be empty ("") not null
for (String scheme : allowedSchemes) {
if (url.startsWith(scheme)) {
if (url.startsWith(scheme)) { // <-- which leads to the
problem "urlidontwanttowhilelist://".startsWith("") == true{code}
I would like to improve this check for example like following
{code:java}
if (url.startsWith(scheme) && !"".equals(scheme)) {
{code}
Thx in advance for the improvement
was:
The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if
_AllowSchemes_ is empty after having being loaded, respectively only if _null_,
which could lead to error in case a custom scheme is use but not set as white
listed schema
What I mean is that, if no _preference_ would be set in _config.xml_ but a
custom scheme would be used (my case) then the variable _allowSchemes_ won't be
_null_ but an _empty string_
In InAppBrowser.java
{code:java}
else if (!url.startsWith("http:") && !url.startsWith("https:") &&
url.matches("^[a-z]*://.*?$")) {
if (allowedSchemes == null) {
String allowed = preferences.getString("AllowedSchemes", "");
allowedSchemes = allowed.split(",");
}
if (allowedSchemes != null) { // <--- If preference AllowedSchemes is
not specified, variable allowedSchemes gonna be empty ("") not null
for (String scheme : allowedSchemes) {
if (url.startsWith(scheme)) { // <-- which leads to the problem
"urlidontwanttowhilelist://".startsWith("") == true{code}
I would like to improve this check for example like following
{code:java}
if (allowedSchemes != null && !"".equals(allowedSchemes)) {
{code}
Thx in advance for the improvement
> Inappbrowser allowedSchemes doesn't check empty string
> --
>
> Key: CB-14048
> URL: https://issues.apache.org/jira/browse/CB-14048
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Reporter: Reed Richards
>Priority: Minor
>
> The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if
> _AllowSchemes_ is empty after having being loaded, respectively only if
> _null_, which could lead to error in case a custom scheme is use but not set
> as white listed schema
> What I mean is that, if no _preference_ would be set in _config.xml_ but a
> custom scheme would be used (my case) then the variable _allowSchemes_ won't
> be _null_ but an _empty string_
>
> In InAppBrowser.java
>
> {code:java}
> else if (!url.startsWith("http:") && !url.startsWith("https:") &&
> url.matches("^[a-z]*://.*?$")) {
> if (allowedSchemes == null) {
> String allowed = preferences.getString("AllowedSchemes", "");
> allowedSchemes = allowed.split(",");
> }
> if (allowedSchemes != null) { // <--- If preference AllowedSchemes
> is not specified, variable allowedSchemes gonna be empty ("") not null
>for (String scheme : allowedSchemes) {
>if (url.startsWith(scheme)) {
> if (url.startsWith(scheme)) { // <-- which leads to the
> problem "urlidontwanttowhilelist://".startsWith("") == true{code}
>
> I would like to improve this check for example like following
>
> {code:java}
> if (url.startsWith(scheme) && !"".equals(scheme)) {
> {code}
>
> Thx in advance for the improvement
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14048) Inappbrowser allowedSchemes doesn't check empty string
[
https://issues.apache.org/jira/browse/CB-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reed Richards updated CB-14048:
---
Priority: Minor (was: Major)
> Inappbrowser allowedSchemes doesn't check empty string
> --
>
> Key: CB-14048
> URL: https://issues.apache.org/jira/browse/CB-14048
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Reporter: Reed Richards
>Priority: Minor
>
> The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if
> _AllowSchemes_ is empty after having being loaded, respectively only if
> _null_, which could lead to error in case a custom scheme is use but not set
> as white listed schema
> What I mean is that, if no _preference_ would be set in _config.xml_ but a
> custom scheme would be used (my case) then the variable _allowSchemes_ won't
> be _null_ but an _empty string_
>
> In InAppBrowser.java
>
> {code:java}
> else if (!url.startsWith("http:") && !url.startsWith("https:") &&
> url.matches("^[a-z]*://.*?$")) {
> if (allowedSchemes == null) {
> String allowed = preferences.getString("AllowedSchemes", "");
> allowedSchemes = allowed.split(",");
> }
> if (allowedSchemes != null) { // <--- If preference AllowedSchemes
> is not specified, variable allowedSchemes gonna be empty ("") not null
>for (String scheme : allowedSchemes) {
>if (url.startsWith(scheme)) { // <-- which leads to the
> problem "urlidontwanttowhilelist://".startsWith("") == true{code}
>
> I would like to improve this check for example like following
>
> {code:java}
> if (allowedSchemes != null && !"".equals(allowedSchemes)) {
> {code}
>
> Thx in advance for the improvement
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14048) Inappbrowser allowedSchemes doesn't check empty string
[
https://issues.apache.org/jira/browse/CB-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reed Richards updated CB-14048:
---
Description:
The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if
_AllowSchemes_ is empty after having being loaded, respectively only if _null_,
which could lead to error in case a custom scheme is use but not set as white
listed schema
What I mean is that, if no _preference_ would be set in _config.xml_ but a
custom scheme would be used (my case) then the variable _allowSchemes_ won't be
_null_ but an _empty string_
In InAppBrowser.java
{code:java}
else if (!url.startsWith("http:") && !url.startsWith("https:") &&
url.matches("^[a-z]*://.*?$")) {
if (allowedSchemes == null) {
String allowed = preferences.getString("AllowedSchemes", "");
allowedSchemes = allowed.split(",");
}
if (allowedSchemes != null) { // <--- If preference AllowedSchemes is
not specified, variable allowedSchemes gonna be empty ("") not null
for (String scheme : allowedSchemes) {
if (url.startsWith(scheme)) { // <-- which leads to the problem
"urlidontwanttowhilelist://".startsWith("") == true{code}
I would like to improve this check for example like following
{code:java}
if (allowedSchemes != null && !"".equals(allowedSchemes)) {
{code}
Thx in advance for the improvement
was:
The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if
_AllowSchemes_ is empty after having being loaded, respectively only if _null_,
which could lead to error in case a custom scheme is use but not set as white
listed schema
What I mean is that, if no _preference_ would be set in _config.xml_ but a
custom scheme would be used (my case) then the variable _allowSchemes_ won't be
_null_ but an _empty string_
In InAppBrowser.java
{code:java}
else if (!url.startsWith("http:") && !url.startsWith("https:") &&
url.matches("^[a-z]*://.*?$")) {
if (allowedSchemes == null) {
String allowed = preferences.getString("AllowedSchemes", "");
allowedSchemes = allowed.split(",");
}
if (allowedSchemes != null) { // <--- If preference AllowedSchemes is
not specified, variable allowedSchemes gonna be empty ("") not null {code}
I would like to improve this check for example like following
{code:java}
if (allowedSchemes != null && !"".equals(allowedSchemes)) {
{code}
Thx in advance for the improvement
> Inappbrowser allowedSchemes doesn't check empty string
> --
>
> Key: CB-14048
> URL: https://issues.apache.org/jira/browse/CB-14048
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Reporter: Reed Richards
>Priority: Major
>
> The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if
> _AllowSchemes_ is empty after having being loaded, respectively only if
> _null_, which could lead to error in case a custom scheme is use but not set
> as white listed schema
> What I mean is that, if no _preference_ would be set in _config.xml_ but a
> custom scheme would be used (my case) then the variable _allowSchemes_ won't
> be _null_ but an _empty string_
>
> In InAppBrowser.java
>
> {code:java}
> else if (!url.startsWith("http:") && !url.startsWith("https:") &&
> url.matches("^[a-z]*://.*?$")) {
> if (allowedSchemes == null) {
> String allowed = preferences.getString("AllowedSchemes", "");
> allowedSchemes = allowed.split(",");
> }
> if (allowedSchemes != null) { // <--- If preference AllowedSchemes
> is not specified, variable allowedSchemes gonna be empty ("") not null
>for (String scheme : allowedSchemes) {
>if (url.startsWith(scheme)) { // <-- which leads to the
> problem "urlidontwanttowhilelist://".startsWith("") == true{code}
>
> I would like to improve this check for example like following
>
> {code:java}
> if (allowedSchemes != null && !"".equals(allowedSchemes)) {
> {code}
>
> Thx in advance for the improvement
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14048) Inappbrowser allowedSchemes doesn't check empty string
[
https://issues.apache.org/jira/browse/CB-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reed Richards updated CB-14048:
---
Description:
The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if
_AllowSchemes_ is empty after having being loaded, respectively only if _null_,
which could lead to error in case a custom scheme is use but not set as white
listed schema
What I mean is that, if no _preference_ would be set in _config.xml_ but a
custom scheme would be used (my case) then the variable _allowSchemes_ won't be
_null_ but an _empty string_
In InAppBrowser.java
{code:java}
else if (!url.startsWith("http:") && !url.startsWith("https:") &&
url.matches("^[a-z]*://.*?$")) {
if (allowedSchemes == null) {
String allowed = preferences.getString("AllowedSchemes", "");
allowedSchemes = allowed.split(",");
}
if (allowedSchemes != null) { // <--- If preference AllowedSchemes is
not specified, variable allowedSchemes gonna be empty ("") not null {code}
I would like to improve this check for example like following
{code:java}
if (allowedSchemes != null && !"".equals(allowedSchemes)) {
{code}
Thx in advance for the improvement
was:
The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if
_AllowSchemes_ is empty after having being loaded, respectively only if _null_,
which could lead to error in case a custom scheme is use but not set as white
listed schema
What I mean is that, if no _preference_ would be set in _config.xml_ but a
custom scheme would be used (my case) then the variable _allowSchemes_ won't be
_null_ but an _empty string_
In InAppBrowser.java
{code:java}
else if (!url.startsWith("http:") && !url.startsWith("https:") &&
url.matches("^[a-z]*://.*?$")) {
if (allowedSchemes == null) {
String allowed = preferences.getString("AllowedSchemes", "");
allowedSchemes = allowed.split(",");
}
if (allowedSchemes != null) { // <--- If AllowedSchemes is not
specified, allowedSchemes gonna be empty ("") not null {code}
I would like to improve this check for example like following
{code:java}
if (allowedSchemes != null && !"".equals(allowedSchemes)) {
{code}
Thx in advance for the improvement
> Inappbrowser allowedSchemes doesn't check empty string
> --
>
> Key: CB-14048
> URL: https://issues.apache.org/jira/browse/CB-14048
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Reporter: Reed Richards
>Priority: Major
>
> The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if
> _AllowSchemes_ is empty after having being loaded, respectively only if
> _null_, which could lead to error in case a custom scheme is use but not set
> as white listed schema
> What I mean is that, if no _preference_ would be set in _config.xml_ but a
> custom scheme would be used (my case) then the variable _allowSchemes_ won't
> be _null_ but an _empty string_
>
> In InAppBrowser.java
>
> {code:java}
> else if (!url.startsWith("http:") && !url.startsWith("https:") &&
> url.matches("^[a-z]*://.*?$")) {
> if (allowedSchemes == null) {
> String allowed = preferences.getString("AllowedSchemes", "");
> allowedSchemes = allowed.split(",");
> }
> if (allowedSchemes != null) { // <--- If preference AllowedSchemes
> is not specified, variable allowedSchemes gonna be empty ("") not null {code}
>
>
> I would like to improve this check for example like following
>
> {code:java}
> if (allowedSchemes != null && !"".equals(allowedSchemes)) {
> {code}
>
> Thx in advance for the improvement
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14048) Inappbrowser allowedSchemes doesn't check empty string
[
https://issues.apache.org/jira/browse/CB-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reed Richards updated CB-14048:
---
Description:
The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if
_AllowSchemes_ is empty after having being loaded, respectively only if _null_,
which could lead to error in case a custom scheme is use but not set as white
listed schema
What I mean is that, if no _preference_ would be set in _config.xml_ but a
custom scheme would be used (my case) then the variable _allowSchemes_ won't be
_null_ but an _empty string_
In InAppBrowser.java
{code:java}
else if (!url.startsWith("http:") && !url.startsWith("https:") &&
url.matches("^[a-z]*://.*?$")) {
if (allowedSchemes == null) {
String allowed = preferences.getString("AllowedSchemes", "");
allowedSchemes = allowed.split(",");
}
if (allowedSchemes != null) { // <--- If AllowedSchemes is not
specified, allowedSchemes gonna be empty ("") not null {code}
I would like to improve this check for example like following
{code:java}
if (allowedSchemes != null && !"".equals(allowedSchemes)) {
{code}
Thx in advance for the improvement
was:
The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if
AllowSchemes is empty after having being loaded, respectively only if null,
which could lead to error in case a custom scheme is use but not set as white
listed schema (which is my case)
What I mean is that, if no preference would be set in config.xml but a custom
scheme would be used (my case) then the variable allowSchemes won't be null but
an empty string
In InAppBrowser.java
else if (!url.startsWith("http:") && !url.startsWith("https:") &&
url.matches("^[a-z]*://.*?$")) {
if (allowedSchemes == null) {
String allowed = preferences.getString("AllowedSchemes", "");
allowedSchemes = allowed.split(",");
}
if (allowedSchemes != null) { // <--- If AllowedSchemes is not
specified, allowedSchemes gonna be empty "" not null
I would like to improve this check for example like following
if (allowedSchemes != null && !"".equals(allowedSchemes)) {
> Inappbrowser allowedSchemes doesn't check empty string
> --
>
> Key: CB-14048
> URL: https://issues.apache.org/jira/browse/CB-14048
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Reporter: Reed Richards
>Priority: Major
>
> The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if
> _AllowSchemes_ is empty after having being loaded, respectively only if
> _null_, which could lead to error in case a custom scheme is use but not set
> as white listed schema
> What I mean is that, if no _preference_ would be set in _config.xml_ but a
> custom scheme would be used (my case) then the variable _allowSchemes_ won't
> be _null_ but an _empty string_
>
> In InAppBrowser.java
>
> {code:java}
> else if (!url.startsWith("http:") && !url.startsWith("https:") &&
> url.matches("^[a-z]*://.*?$")) {
> if (allowedSchemes == null) {
> String allowed = preferences.getString("AllowedSchemes", "");
> allowedSchemes = allowed.split(",");
> }
> if (allowedSchemes != null) { // <--- If AllowedSchemes is not
> specified, allowedSchemes gonna be empty ("") not null {code}
>
>
> I would like to improve this check for example like following
>
> {code:java}
> if (allowedSchemes != null && !"".equals(allowedSchemes)) {
> {code}
>
> Thx in advance for the improvement
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14048) Inappbrowser allowedSchemes doesn't check empty string
Reed Richards created CB-14048:
--
Summary: Inappbrowser allowedSchemes doesn't check empty string
Key: CB-14048
URL: https://issues.apache.org/jira/browse/CB-14048
Project: Apache Cordova
Issue Type: Bug
Components: cordova-plugin-inappbrowser
Reporter: Reed Richards
The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if
AllowSchemes is empty after having being loaded, respectively only if null,
which could lead to error in case a custom scheme is use but not set as white
listed schema (which is my case)
What I mean is that, if no preference would be set in config.xml but a custom
scheme would be used (my case) then the variable allowSchemes won't be null but
an empty string
In InAppBrowser.java
else if (!url.startsWith("http:") && !url.startsWith("https:") &&
url.matches("^[a-z]*://.*?$")) {
if (allowedSchemes == null) {
String allowed = preferences.getString("AllowedSchemes", "");
allowedSchemes = allowed.split(",");
}
if (allowedSchemes != null) { // <--- If AllowedSchemes is not
specified, allowedSchemes gonna be empty "" not null
I would like to improve this check for example like following
if (allowedSchemes != null && !"".equals(allowedSchemes)) {
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13882) Device.model return iPhone8,1 on iPhone 6s / iOS 11.2.5
[ https://issues.apache.org/jira/browse/CB-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366623#comment-16366623 ] Reed Richards commented on CB-13882: [~jcesarmobile] my bad, sorry for the issue, I was tired. You are totally right, same in https://www.theiphonewiki.com/wiki/Models > Device.model return iPhone8,1 on iPhone 6s / iOS 11.2.5 > --- > > Key: CB-13882 > URL: https://issues.apache.org/jira/browse/CB-13882 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-device >Reporter: Reed Richards >Priority: Major > > Hi, > On my iPhone 6s / iOS 11.2.5, when I query the device.model I get iPhone8,1 > instead of iPhone6,1 > cordova-plugin-device version 2.0.1 > Best regards -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13882) Device.model return iPhone8,1 on iPhone 6s / iOS 11.2.5
Reed Richards created CB-13882: -- Summary: Device.model return iPhone8,1 on iPhone 6s / iOS 11.2.5 Key: CB-13882 URL: https://issues.apache.org/jira/browse/CB-13882 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-device Reporter: Reed Richards Hi, On my iPhone 6s / iOS 11.2.5, when I query the device.model I get iPhone8,1 instead of iPhone6,1 cordova-plugin-device version 2.0.1 Best regards -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Issue Comment Deleted] (CB-10950) Phonegap app in the background when capture and select image for gallery app stop/restart.
[ https://issues.apache.org/jira/browse/CB-10950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reed Richards updated CB-10950: --- Comment: was deleted (was: [~riknoll] [~ignaciotoptier] could confirm this, onResume is never throw when App restart after restart having been put in the background cordova-plugin-camera@3.0.0 cordova-android@6.4.0 tested on Android 8.1) > Phonegap app in the background when capture and select image for gallery app > stop/restart. > --- > > Key: CB-10950 > URL: https://issues.apache.org/jira/browse/CB-10950 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: 5.0.1 >Reporter: Lokesh Patel > Labels: android, triaged, wfc > > Hi, > In android application when the user tries for capturing images and select > image from gallery app stop/restart. > I found below details after search lots of google and forums: > " The Phonegap (Cordova) Camera Plugin calls the native camera and this makes > Android Garbage Collector to kill background applications." > Thanks, > Lokesh Patel -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10950) Phonegap app in the background when capture and select image for gallery app stop/restart.
[ https://issues.apache.org/jira/browse/CB-10950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321774#comment-16321774 ] Reed Richards commented on CB-10950: [~riknoll] [~ignaciotoptier] could confirm this, onResume is never throw when App restart after restart having been put in the background cordova-plugin-camera@3.0.0 cordova-android@6.4.0 tested on Android 8.1 > Phonegap app in the background when capture and select image for gallery app > stop/restart. > --- > > Key: CB-10950 > URL: https://issues.apache.org/jira/browse/CB-10950 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: 5.0.1 >Reporter: Lokesh Patel > Labels: android, triaged, wfc > > Hi, > In android application when the user tries for capturing images and select > image from gallery app stop/restart. > I found below details after search lots of google and forums: > " The Phonegap (Cordova) Camera Plugin calls the native camera and this makes > Android Garbage Collector to kill background applications." > Thanks, > Lokesh Patel -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13575) iOS Quirks: Internationalization of edit-config tags
[
https://issues.apache.org/jira/browse/CB-13575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274228#comment-16274228
]
Reed Richards commented on CB-13575:
@jcesarmobile kudos, thx for the clarification, all good now, I understood it
loud and clear :)
> iOS Quirks: Internationalization of edit-config tags
>
>
> Key: CB-13575
> URL: https://issues.apache.org/jira/browse/CB-13575
> Project: Apache Cordova
> Issue Type: Improvement
> Components: AllPlugins
>Reporter: Reed Richards
>
> With the release of the last plugins the 10th November 2017
> (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of
> `edit-config` become a must to display the users the usage description of the
> required permissions
> As far as I understand, right now it's only possible to specify one `string`
> value for an `edit-config` tag, for example:
> {code}
> mode="merge">
> need camera access to take pictures
>
> {code}
> This isn't unfortunately enough for apps operating in several languages,
> therefore, it should be possible for each `edit-config` tags to specify
> multiple languages like
> {code}
> mode="merge">
> need camera access to take pictures
> die Berechtigungen für den Zugriff zu deiner Kamera sind
> nötig
> autorises-tu l'accès à ton appareil photo?
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13575) iOS Quirks: Internationalization of edit-config tags
[
https://issues.apache.org/jira/browse/CB-13575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274093#comment-16274093
]
Reed Richards commented on CB-13575:
thx for your answer @jcesarmobile and for pointing out a solution!
even if I understand your point of view, I was hoping that you would find this
feature enough interesting to keep it in the roadmap of cordovaI mean there
are plenty of multi language apps using cordova in the world, I guess if
everybody don't have to write hooks, that would make some happy people ;)
> iOS Quirks: Internationalization of edit-config tags
>
>
> Key: CB-13575
> URL: https://issues.apache.org/jira/browse/CB-13575
> Project: Apache Cordova
> Issue Type: Improvement
> Components: AllPlugins
>Reporter: Reed Richards
>
> With the release of the last plugins the 10th November 2017
> (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of
> `edit-config` become a must to display the users the usage description of the
> required permissions
> As far as I understand, right now it's only possible to specify one `string`
> value for an `edit-config` tag, for example:
> {code}
> mode="merge">
> need camera access to take pictures
>
> {code}
> This isn't unfortunately enough for apps operating in several languages,
> therefore, it should be possible for each `edit-config` tags to specify
> multiple languages like
> {code}
> mode="merge">
> need camera access to take pictures
> die Berechtigungen für den Zugriff zu deiner Kamera sind
> nötig
> autorises-tu l'accès à ton appareil photo?
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13575) iOS Quirks: Internationalization of edit-config tags
[
https://issues.apache.org/jira/browse/CB-13575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reed Richards updated CB-13575:
---
Description:
With the release of the last plugins the 10th November 2017
(http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of
`edit-config` become a must to display the users the usage description of the
required permissions
As far as I understand, right now it's only possible to specify one `string`
value for an `edit-config` tag, for example:
{code}
need camera access to take pictures
{code}
This isn't unfortunately enough for apps operating in several languages,
therefore, it should be possible for each `edit-config` tags to specify
multiple languages like
{code}
need camera access to take pictures
die Berechtigungen für den Zugriff zu deiner Kamera sind
nötig
autorises-tu l'accès à ton appareil photo?
{code}
was:
With the release of the last plugins the 10th November 2017
(http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of
`edit-config` become a must to display the users the usage description of the
required permissions
As far as I understand, right now it's only possible to specify one `string`
value for an `edit-config` tag, for example:
{code}
need camera access to take pictures
{code}
This isn't unfortunately enough for apps operating in several languages,
therefore, it should be possible for each `edit-config` tags to specify
multiple languages like
{code}
need camera access to take pictures
die Berechtigungen für den Zugriff zu deine Kamera sind
nötig
autorises-tu l'accès à ton appareil photo?
{code}
> iOS Quirks: Internationalization of edit-config tags
>
>
> Key: CB-13575
> URL: https://issues.apache.org/jira/browse/CB-13575
> Project: Apache Cordova
> Issue Type: Improvement
> Components: AllPlugins
>Reporter: Reed Richards
>
> With the release of the last plugins the 10th November 2017
> (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of
> `edit-config` become a must to display the users the usage description of the
> required permissions
> As far as I understand, right now it's only possible to specify one `string`
> value for an `edit-config` tag, for example:
> {code}
> mode="merge">
> need camera access to take pictures
>
> {code}
> This isn't unfortunately enough for apps operating in several languages,
> therefore, it should be possible for each `edit-config` tags to specify
> multiple languages like
> {code}
> mode="merge">
> need camera access to take pictures
> die Berechtigungen für den Zugriff zu deiner Kamera sind
> nötig
> autorises-tu l'accès à ton appareil photo?
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13575) iOS Quirks: Internationalization of edit-config tags
[
https://issues.apache.org/jira/browse/CB-13575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reed Richards updated CB-13575:
---
Description:
With the release of the last plugins the 10th November 2017
(http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of
`edit-config` become a must to display the users the usage description of the
required permissions
As far as I understand, right now it's only possible to specify one `string`
value for an `edit-config` tag, for example:
{code}
need camera access to take pictures
{code}
This isn't unfortunately enough for apps operating in several languages,
therefore, it should be possible for each `edit-config` tags to specify
multiple languages like
{code}
need camera access to take pictures
die Berechtigungen für den Zugriff zu deine Kamera sind
nötig
autorises-tu l'accès à ton appareil photo?
{code}
was:
With the release of the last plugins the 10th November 2017
(http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of
`edit-config` become a must to display the users the usage description of the
required permissions
As far as I understand, right now it's only possible to specify one `string`
value for an `edit-config` tag, for example:
{code}
need camera access to take pictures
{code}
This isn't unfortunately enough for apps operating in several languages,
therefore, it should be possible for each `edit-config` tags to specify
multiple languages like
{code}
need camera access to take pictures
ja ja genau
c'est super
{code}
> iOS Quirks: Internationalization of edit-config tags
>
>
> Key: CB-13575
> URL: https://issues.apache.org/jira/browse/CB-13575
> Project: Apache Cordova
> Issue Type: Improvement
> Components: AllPlugins
>Reporter: Reed Richards
>
> With the release of the last plugins the 10th November 2017
> (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of
> `edit-config` become a must to display the users the usage description of the
> required permissions
> As far as I understand, right now it's only possible to specify one `string`
> value for an `edit-config` tag, for example:
> {code}
> mode="merge">
> need camera access to take pictures
>
> {code}
> This isn't unfortunately enough for apps operating in several languages,
> therefore, it should be possible for each `edit-config` tags to specify
> multiple languages like
> {code}
> mode="merge">
> need camera access to take pictures
> die Berechtigungen für den Zugriff zu deine Kamera sind
> nötig
> autorises-tu l'accès à ton appareil photo?
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13575) iOS Quirks: Internationalization of edit-config tags
[ https://issues.apache.org/jira/browse/CB-13575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reed Richards updated CB-13575: --- Summary: iOS Quirks: Internationalization of edit-config tags (was: Internationalization iOS Quirks edit-config tags) > iOS Quirks: Internationalization of edit-config tags > > > Key: CB-13575 > URL: https://issues.apache.org/jira/browse/CB-13575 > Project: Apache Cordova > Issue Type: Improvement > Components: AllPlugins >Reporter: Reed Richards > > With the release of the last plugins the 10th November 2017 > (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of > `edit-config` become a must to display the users the usage description of the > required permissions > As far as I understand, right now it's only possible to specify one `string` > value for an `edit-config` tag, for example: > mode="merge"> > need camera access to take pictures > > This isn't unfortunately enough for apps operating in several languages, > therefore, it should be possible for each `edit-config` tags to specify > multiple languages like > mode="merge"> > need camera access to take pictures > ja ja genau > c'est super > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13575) Internationalization iOS Quirks edit-config tags
Reed Richards created CB-13575: -- Summary: Internationalization iOS Quirks edit-config tags Key: CB-13575 URL: https://issues.apache.org/jira/browse/CB-13575 Project: Apache Cordova Issue Type: Improvement Components: AllPlugins Reporter: Reed Richards With the release of the last plugins the 10th November 2017 (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of `edit-config` become a must to display the users the usage description of the required permissions As far as I understand, right now it's only possible to specify one `string` value for an `edit-config` tag, for example: need camera access to take pictures This isn't unfortunately enough for apps operating in several languages, therefore, it should be possible for each `edit-config` tags to specify multiple languages like need camera access to take pictures ja ja genau c'est super -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-12094) StatusBar color always blue on Android with Ionic2/Crosswalk
[
https://issues.apache.org/jira/browse/CB-12094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reed Richards closed CB-12094.
--
Resolution: Invalid
There wasn't any issue regarding the color of the status bar.
See Ionic forum (link in content) for the solution regarding XWalk and Chrome
and the color of the status bar.
> StatusBar color always blue on Android with Ionic2/Crosswalk
> -
>
> Key: CB-12094
> URL: https://issues.apache.org/jira/browse/CB-12094
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Statusbar
>Reporter: Reed Richards
>
> Hi,
> With Ionic2 (RC.0 or RC.1) projects using Crosswalk the Statusbar is always
> blue with a white text.
> I tried to customize it with following line of codes
> StatusBar.backgroundColorByHexString("#00");
> This works for me, till I didn't reduce my app and open it again but doesn't
> seems to work to anyone else.
> Futhermore, when I use the hardware button to display all opened applications
> on my phone, with or without that above codes, the bar of my app is also
> displayed as blue with a white text
> Seems that many Ionic2 developpers are facing that issue, full story there
> https://forum.ionicframework.com/t/ionic2-rc0-and-ionic2-rc1-plugin-statusbar-not-working-in-android-with-crosswalk/66449/8
> Thx in advance for your help and feedback!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12094) StatusBar color always blue on Android with Ionic2/Crosswalk
[
https://issues.apache.org/jira/browse/CB-12094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reed Richards updated CB-12094:
---
Description:
Hi,
With Ionic2 (RC.0 or RC.1) projects using Crosswalk the Statusbar is always
blue with a white text.
I tried to customize it with following line of codes
StatusBar.backgroundColorByHexString("#00");
This works for me, till I didn't reduce my app and open it again but doesn't
seems to work to anyone else.
Futhermore, when I use the hardware button to display all opened applications
on my phone, with or without that above codes, the bar of my app is also
displayed as blue with a white text
Seems that many Ionic2 developpers are facing that issue, full story there
https://forum.ionicframework.com/t/ionic2-rc0-and-ionic2-rc1-plugin-statusbar-not-working-in-android-with-crosswalk/66449/8
Thx in advance for your help and feedback!
was:
Hi,
With Ionic2 (RC.0 or RC.1) projects using Crosswalk the Statusbar is always
blue with a white text.
I tried to customize it with following line of codes
StatusBar.backgroundColorByHexString("#00");
This works for me, till I didn't reduce my app and open it again but doesn't
seems to work to anyone else.
Futhermore, when I use the hardware to display all opened applications on my
phone, with or without that above codes, the bar of my app is also displayed as
blue with a white text
Seems that many Ionic2 developpers are facing that issue, full story there
https://forum.ionicframework.com/t/ionic2-rc0-and-ionic2-rc1-plugin-statusbar-not-working-in-android-with-crosswalk/66449/8
Thx in advance for your help and feedback!
> StatusBar color always blue on Android with Ionic2/Crosswalk
> -
>
> Key: CB-12094
> URL: https://issues.apache.org/jira/browse/CB-12094
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Statusbar
>Reporter: Reed Richards
>
> Hi,
> With Ionic2 (RC.0 or RC.1) projects using Crosswalk the Statusbar is always
> blue with a white text.
> I tried to customize it with following line of codes
> StatusBar.backgroundColorByHexString("#00");
> This works for me, till I didn't reduce my app and open it again but doesn't
> seems to work to anyone else.
> Futhermore, when I use the hardware button to display all opened applications
> on my phone, with or without that above codes, the bar of my app is also
> displayed as blue with a white text
> Seems that many Ionic2 developpers are facing that issue, full story there
> https://forum.ionicframework.com/t/ionic2-rc0-and-ionic2-rc1-plugin-statusbar-not-working-in-android-with-crosswalk/66449/8
> Thx in advance for your help and feedback!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12094) StatusBar color always blue on Android with Ionic2/Crosswalk
Reed Richards created CB-12094:
--
Summary: StatusBar color always blue on Android with
Ionic2/Crosswalk
Key: CB-12094
URL: https://issues.apache.org/jira/browse/CB-12094
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Statusbar
Reporter: Reed Richards
Hi,
With Ionic2 (RC.0 or RC.1) projects using Crosswalk the Statusbar is always
blue with a white text.
I tried to customize it with following line of codes
StatusBar.backgroundColorByHexString("#00");
This works for me, till I didn't reduce my app and open it again but doesn't
seems to work to anyone else.
Futhermore, when I use the hardware to display all opened applications on my
phone, with or without that above codes, the bar of my app is also displayed as
blue with a white text
Seems that many Ionic2 developpers are facing that issue, full story there
https://forum.ionicframework.com/t/ionic2-rc0-and-ionic2-rc1-plugin-statusbar-not-working-in-android-with-crosswalk/66449/8
Thx in advance for your help and feedback!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
