***UNCHECKED*** [jira] [Created] (CB-13837) TypeScript Definition for CameraPopoverOptions does not declare class

2018-01-26 Thread Ryan Murphy (JIRA)
Ryan Murphy created CB-13837:


 Summary: TypeScript Definition for CameraPopoverOptions does not 
declare class
 Key: CB-13837
 URL: https://issues.apache.org/jira/browse/CB-13837
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-plugin-camera
Reporter: Ryan Murphy


The docs for CameraPopoverOptions use it as a class.

>From docs: 
{code:javascript}
var cameraPopoverOptions = new CameraPopoverOptions(0, 0, 100, 100, 
Camera.PopoverArrowDirection.ARROW_ANY);
{code}
 

But the index.d.ts only define an interface, not declare a class, so using it 
as a class in a TypeScript file gives the error:
 {color:#ff}[ts] 'CameraPopoverOptions' only refers to a type, but is being 
used as a value here.{color}

The fix would be to declare a class and constructor.
{code:java}
declare class CameraPopoverOptions implements CameraPopoverOptions {
constructor(x?: number, y?: number, width?: number, height?: number, 
arrowDir?: number);
}
{code}




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13564) Multiple edit-config items for Info.plist causing error

2017-11-20 Thread Ryan Murphy (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260039#comment-16260039
 ] 

Ryan Murphy commented on CB-13564:
--

I encountered the same after following the docs for cordova-plugin-camera. I 
was able to patch it on my machine at `cordova/node_modules/cordova-common` in 
`ConfigChanges.js`. 

*From*
{code:javascript}
var file_xml = self.config_keeper.get(self.project_dir, self.platform, 
editchange.file).data;
var resolveEditTarget = xml_helpers.resolveParent(file_xml, editchange.target);
// etc...
{code}

*To:*
{code:javascript}
var file = self.config_keeper.get(self.project_dir, self.platform, 
editchange.file);
if (file.type === 'xml') {
var file_xml = file.data;
var resolveEditTarget = xml_helpers.resolveParent(file_xml, 
editchange.target);
// etc...
}
// else??
{code}


I'm not sure what the logic is actually doing, so I'm not sure if there should 
be an else for non-xml.

Also I'm making a huge assumption that file.type === 'xml' if it's not plist. 
The only type I encountered in my own usage was plist.

> Multiple edit-config items for Info.plist causing error
> ---
>
> Key: CB-13564
> URL: https://issues.apache.org/jira/browse/CB-13564
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli
>Reporter: Tom Bell
>
> I am on 7.1.0 of `cordova-cli`, there was no `7.1.0` in the "Affects 
> Versions" dropdown.
> I've updated `cordova-ios` to 4.5.3 and `cordova-plugin-contacts` to 3..0.0, 
> I've got the following 
> working:
> {code:xml}
>  target="NSContactsUsageDescription">
> We require permission to access your contacts so you can import 
> contacts into [redacted]
> 
> {code}
> However when I decided to move some stuff from an `after_prepare` hook 
> script, to use edit-config, it fails with an error `doc.find is not a 
> function`
> {code:xml}
>  target="NSContactsUsageDescription">
> We require permission to access your contacts so you can import 
> contacts into [redacted]
> 
> 
> UIStatusBarStyleLightContent
> 
> {code}
> If I take out the additional `` everything works.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-2415) On iOS the ajax error/fail callback is not called after server returns error code 401/unauthorized

2014-12-05 Thread Ryan Murphy (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235754#comment-14235754
 ] 

Ryan Murphy commented on CB-2415:
-

+1 for this getting fixed soon. For my enterprise clients I have no control 
over the HTTP responses. 
It's a really bad user experience to do always synchronous requests (especially 
since iOS 8 shortened the sync timeout). Or to always add a timeout on async 
requests and say "well, there was a timeout, I better treat it as a 401".


> On iOS the ajax error/fail callback is not called after server returns error 
> code 401/unauthorized
> --
>
> Key: CB-2415
> URL: https://issues.apache.org/jira/browse/CB-2415
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Affects Versions: 2.2.0
> Environment: OSX 10.8.2, Xcode 4.5.1, iOS Simulator 5.0, 5.1, 6.0, 
> cordova 2.2
>Reporter: Zach White
>  Labels: 401, BasicAuth, core
>
> I am seeing the same issue as reported in 
> [CB-2284|https://issues.apache.org/jira/browse/CB-2284] also in iOS. Ajax 
> calls with Authorization header set are not returning but are timing out when 
> the authorization credentials are invalid.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-6708) iOS Preserve GPS Metadata from Images picked from Gallery

2014-05-16 Thread Ryan Murphy (JIRA)
Ryan Murphy created CB-6708:
---

 Summary: iOS Preserve GPS Metadata from Images picked from Gallery
 Key: CB-6708
 URL: https://issues.apache.org/jira/browse/CB-6708
 Project: Apache Cordova
  Issue Type: Wish
  Components: Plugin Camera
Reporter: Ryan Murphy
Priority: Trivial


Images picked from the gallery do not preserve metadata when saved to tmp. 
Particularly they lose GPS metadata.

This extra metadata is available in asset.defaultRepresentation.metadata. 

I have a solution that works for my purpose. But currently only saving with 
asset.defaultRepresentation.fullResolutionImage.

Approach to get the asset: https://github.com/foundry/UIImageMetadata

Approach to save the asset: http://stackoverflow.com/a/15398387/618412 (answer 
from Andrew Theis).

Thanks for consideration.




--
This message was sent by Atlassian JIRA
(v6.2#6252)