[jira] [Comment Edited] (CB-5109) Windows 8.1 - InAppBrowser
[ https://issues.apache.org/jira/browse/CB-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14058822#comment-14058822 ] Sergey Grebnov edited comment on CB-5109 at 7/11/14 2:09 PM: - Hey Maxime, could you please add the following changes to the code 1. As part of Windows Universal Apps we support Windows 8.0 as well so the same proxy class will be applied to that target build platform as well. So we should use feature detection or another custom logic to decide whether we should proceed with the new or old api. We are working on reporting different values via cordova.platformId: 'windows8' for Windows 8.0 and 'windows' for Windows 8.1 and Phone 8.1 but this is not implemented yet. As a result we should have single src/windows/InAppBrowserProxy.js which works for all three platforms 2. Propose to duplicate 'windows8' section as 'windows' (exactly the same content) - this should be done since we are moving from windows8 to a new windows platform and we would like to deprecate/remove 'windows8' section in the future. How it currently works: new windows platform uses 'windows8' section if there is no 'windows' section as part of plugin was (Author: sgrebnov): Hey Maxime, could you please add the following changes to the code 1. As part of Windows Universal Apps we support Windows 8.0 as well so the same proxy class will be applied to that target build platform as well. So we should use feature detection or another custom logic to decide whether we should proceed with the new or old api. We are working on reporting different values via cordova.platformId: 'windows8' for Windows 8.0 and 'windows' for Windows 8.1 and Phone 8.1 but this is not implemented yet. As a result we should have single src/windows/InAppBrowserProxy.js which works for all three platforms 2. Propose to duplicate 'windows8' section as 'windows' (exactly the same content) - this should be done since we are moving from windows8 to a new windows8 platform and we would like to deprecate/remove 'windows8' section in the future. How it currently works: new windows platform uses 'windows8' section if there is no 'windows' section as part of plugin Windows 8.1 - InAppBrowser -- Key: CB-5109 URL: https://issues.apache.org/jira/browse/CB-5109 Project: Apache Cordova Issue Type: Sub-task Components: Plugin InAppBrowser, Windows 8 Reporter: Maxime LUCE Assignee: Sergey Grebnov In Windows 8.1, there is a new WebView control. It can be used to create an InAppBrowser implementation. http://msdn.microsoft.com/en-us/library/windows/apps/dn301831.aspx -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (CB-5109) Windows 8.1 - InAppBrowser
[ https://issues.apache.org/jira/browse/CB-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14055086#comment-14055086 ] Sergey Grebnov edited comment on CB-5109 at 7/8/14 4:14 PM: Yeah, having new InAppBrowser implementation would be awesome. Thx Maxime, I'm going to review your pull request on this week and will come back with, was (Author: sgrebnov): Yeah, this would be awesome. Thx Maxime, I'm going to review your pull request on this week Windows 8.1 - InAppBrowser -- Key: CB-5109 URL: https://issues.apache.org/jira/browse/CB-5109 Project: Apache Cordova Issue Type: Sub-task Components: Plugin InAppBrowser, Windows 8 Reporter: Maxime LUCE Assignee: Sergey Grebnov In Windows 8.1, there is a new WebView control. It can be used to create an InAppBrowser implementation. http://msdn.microsoft.com/en-us/library/windows/apps/dn301831.aspx -- This message was sent by Atlassian JIRA (v6.2#6252)
