[jira] [Comment Edited] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-09-06 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125372#comment-16125372
 ] 

Dave Alden edited comment on CB-7179 at 9/6/17 3:31 PM:


I'm continuing to push improvements to [my 
branch|https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview]
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* -on changing device orientation, webview content does not resize to fill page-
* -closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)-
* -security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation-


was (Author: dpa99c):
I'm continuing to push improvements to [my 
branch|https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview]
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* -on changing device orientation, webview content does not resize to fill page-
* -closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)-
* security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-09-05 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125372#comment-16125372
 ] 

Dave Alden edited comment on CB-7179 at 9/5/17 2:04 PM:


I'm continuing to push improvements to [my 
branch|https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview]
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* -on changing device orientation, webview content does not resize to fill page-
* -closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)-
* security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation


was (Author: dpa99c):
I'm continuing to push improvements to [my 
branch|https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview]
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* -on changing device orientation, webview content does not resize to fill page-
* closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)
* security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-08-14 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125372#comment-16125372
 ] 

Dave Alden edited comment on CB-7179 at 8/14/17 8:51 AM:
-

I'm continuing to push improvements to [my 
branch|https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview]
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* -on changing device orientation, webview content does not resize to fill page-
* closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)
* security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation


was (Author: dpa99c):
I'm continuing to push improvements to [my 
branch|https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview]
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* on changing device orientation, webview content does not resize to fill page
* closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)
* security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-08-14 Thread Dave Alden (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125372#comment-16125372
 ] 

Dave Alden edited comment on CB-7179 at 8/14/17 8:37 AM:
-

I'm continuing to push improvements to [my 
branch|https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview]
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* on changing device orientation, webview content does not resize to fill page
* closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)
* security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation


was (Author: dpa99c):
I'm continuing to push improvements to [my 
branch](https://github.com/dpa99c/cordova-plugin-themeablebrowser/tree/wkwebview)
 to iron out remaining issues I've found with using WKWebView to power the IAB. 

The issues I'm currently aware of in my branch are:
* on changing device orientation, webview content does not resize to fill page
* closing IAB does not full get rid of webview instance (it still remains 
visible in Safari Web Inspector)
* security warnings due to iframe injection - need to replace this with proper 
WKScriptMessageHandler implementation

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-07-22 Thread Niklas Merz (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097209#comment-16097209
 ] 

Niklas Merz edited comment on CB-7179 at 7/22/17 9:49 AM:
--

Dave Alden has taken my simple approach and improved it. I am linking the [pull 
request|https://github.com/NiklasMerz/cordova-plugin-inappbrowser/pull/1#pullrequestreview-51619777]
 here, if someone wants to contribute or review.


was (Author: niklasmerz):
Dave Alden has taken my simple approach and improved it. I am linking the [pull 
request|https://github.com/NiklasMerz/cordova-plugin-inappbrowser/pull/1#pullrequestreview-51619777]
 here, if someone wants to contribute.

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2017-06-29 Thread Niklas Merz (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062939#comment-16062939
 ] 

Niklas Merz edited comment on CB-7179 at 6/29/17 7:34 AM:
--

Hello,

We are experiencing a strange bug in InAppBrowser with UIWebView. Using the 
WKWebview plugin with Cordova solves this. I am currently trying to get the 
wkwebview branch working by myself but with my few ObjectiveC skill it is 
difficult to get it running.

WkWebview has introduced some improvements since opening this issue. Have you 
any plans on working on this? 

Edit: Now I am at a point where the InAppBrowser is working in WKWebview. How 
do the plans of the Cordova team look like? Do you want to support WKWebview 
and UIWebview?

Thanks
Niklas


was (Author: niklasmerz):
Hello,

We are experiencing a strange bug in InAppBrowser with UIWebView. Using the 
WKWebview plugin with Cordova solves this. I am currently trying to get the 
wkwebview branch working by myself but with my few ObjectiveC skill it is 
difficult to get it running.

WkWebview has introduced some improvements since opening this issue. Have you 
any plans on working on this? 

Thanks
Niklas

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2016-08-29 Thread JIRA

[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15445005#comment-15445005
 ] 

HÃ¥kon Nilsen edited comment on CB-7179 at 8/29/16 7:51 AM:
---

It has now been a year and a half since this was closed, and I must ask that 
this needs to be reopened.

When using WKWebView engine in Cordova, the InAppBrowser, based on UIWebView, 
cannot share the session. This means that the InAppBrowser cannot be used for 
anything that requires a session, as the InAppBrowser is practically an 
"incognito" window.

Right now I am forced to continue using UIWebView as my only browser, because 
the InAppBrowser is UIWebView. What I suggest is making an additional plugin 
for an InAppBrowser that uses UIWebView if the main webview is based on 
UIWebView, and uses WKWebView if the main webview is based on WKWebView. That 
way you can share the session in the InAppBrowser regardless of which engine 
you use.

Cordova with UIWebView using InAppBrowser with UIWebView --> works
Cordova with WKWebView using InAppBrowser with UIWebView --> doesn't work


was (Author: hnilsen):
I has now been a year and a half since this was closed, and I must ask that 
this needs to be reopened.

When using WKWebView engine in Cordova, the InAppBrowser, based on UIWebView, 
cannot share the session. This means that the InAppBrowser cannot be used for 
anything that requires a session, as the InAppBrowser is practically an 
"incognito" window.

Right now I am forced to continue using UIWebView as my only browser, because 
the InAppBrowser is UIWebView. What I suggest is making an additional plugin 
for an InAppBrowser that uses UIWebView if the main webview is based on 
UIWebView, and uses WKWebView if the main webview is based on WKWebView. That 
way you can share the session in the InAppBrowser regardless of which engine 
you use.

Cordova with UIWebView using InAppBrowser with UIWebView --> works
Cordova with WKWebView using InAppBrowser with UIWebView --> doesn't work

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Plugin InAppBrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org