[jira] [Comment Edited] (CB-8556) handleOpenURL functionality to be removed to a plugin

2015-03-12 Thread Shazron Abdullah (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-8556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359666#comment-14359666
 ] 

Shazron Abdullah edited comment on CB-8556 at 3/13/15 12:15 AM:


This is failing on CDVWKWebViewEngine because  CDVPageDidLoadNotification is 
not posted once the page is loaded.

{code}
 [[NSNotificationCenter defaultCenter] postNotification:[NSNotification 
notificationWithName:CDVPageDidLoadNotification object:self.webView]];
{code}

CDVWKWebViewEngine needs to have a navigationDelegate that implements:
{code}
- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation 
*)navigation
{code}
... which then will post CDVPageDidLoadNotification


was (Author: shazron):
This is failing on CDVWKWebViewEngine because  CDVPageDidLoadNotification is 
not posted once the page is loaded.

{code}
 [[NSNotificationCenter defaultCenter] postNotification:[NSNotification 
notificationWithName:CDVPageDidLoadNotification object:self.webView]];
{code}

> handleOpenURL functionality to be removed to a plugin
> -
>
> Key: CB-8556
> URL: https://issues.apache.org/jira/browse/CB-8556
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Affects Versions: 4.0.0
>Reporter: Shazron Abdullah
> Fix For: 4.0.0
>
>
> It's already pluginized due to CB-7606
> In 4.0.0, remove the plugin from core and put it in cordova-plugins. 
> Possibility of release as a core plugin, not sure.
> This will include functionality to configure the callback function that is 
> called, which is currently a global handleOpenURL function.
> Remove/edit the note here as well: 
> https://github.com/apache/cordova-ios/blob/b3c26fcd598da7c84f020f5a6b9309fe638cbb5d/guides/Cordova%20Custom%20URL%20Scheme%20Handling.md



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-8556) handleOpenURL functionality to be removed to a plugin

2015-03-02 Thread sandstrom (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-8556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343438#comment-14343438
 ] 

sandstrom edited comment on CB-8556 at 3/2/15 5:39 PM:
---

I'd vote for a core plugin!

In sync with Android, such that the two platforms behaves similarly on custom 
protocols/urls (to the extent possible).


was (Author: sandstrom):
I'd vote for a core plugin! In sync with Android, such that the two platforms 
behaves similarly on custom protocols/urls (to the extent possible).

> handleOpenURL functionality to be removed to a plugin
> -
>
> Key: CB-8556
> URL: https://issues.apache.org/jira/browse/CB-8556
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Reporter: Shazron Abdullah
> Fix For: 4.0.0
>
>
> It's already pluginized due to CB-7606
> In 4.0.0, remove the plugin from core and put it in cordova-plugins. 
> Possibility of release as a core plugin, not sure.
> This will include functionality to configure the callback function that is 
> called, which is currently a global handleOpenURL function.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org