[jira] [Commented] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

2017-11-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261595#comment-16261595
 ] 

ASF GitHub Bot commented on CB-10044:
-

maverickmishra closed pull request #116: CB-10044 FileTransfer plug in can 
upload parts of a file to implement resumablejs
URL: https://github.com/apache/cordova-plugin-file-transfer/pull/116
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/android/FileTransfer.java b/src/android/FileTransfer.java
index 0efbd4e..06af303 100644
--- a/src/android/FileTransfer.java
+++ b/src/android/FileTransfer.java
@@ -291,6 +291,11 @@ private void upload(final String source, final String 
target, JSONArray args, Ca
 final JSONObject headers = args.optJSONObject(8) == null ? 
params.optJSONObject("headers") : args.optJSONObject(8);
 final String objectId = args.getString(9);
 final String httpMethod = getArgument(args, 10, "POST");
+final String s_startByte = (args.isNull(11) ? "0" : getArgument(args, 
11, "POST"));
+final String s_endByte = (args.isNull(12) ? "-1" : getArgument(args, 
12, "POST"));
+
+final int startByte = Integer.parseInt(s_startByte);
+final int endByte = Integer.parseInt(s_endByte);
 
 final CordovaResourceApi resourceApi = webView.getResourceApi();
 
@@ -416,7 +421,11 @@ public void run() {
 
 int stringLength = beforeDataBytes.length + 
tailParamsBytes.length;
 if (readResult.length >= 0) {
-fixedLength = (int)readResult.length;
+if(endByte > 0){
+  fixedLength = endByte-startByte;;
+}else{
+  fixedLength = (int)readResult.length;
+}
 if (multipartFormUpload)
 fixedLength += stringLength;
 progress.setLengthComputable(true);
@@ -455,33 +464,48 @@ public void run() {
 sendStream.write(beforeDataBytes);
 totalBytes += beforeDataBytes.length;
 }
-
-// create a buffer of maximum size
-int bytesAvailable = 
readResult.inputStream.available();
-int bufferSize = Math.min(bytesAvailable, 
MAX_BUFFER_SIZE);
-byte[] buffer = new byte[bufferSize];
-
-// read file and write it into form...
-int bytesRead = readResult.inputStream.read(buffer, 0, 
bufferSize);
-
-long prevBytesRead = 0;
-while (bytesRead > 0) {
-result.setBytesSent(totalBytes);
-sendStream.write(buffer, 0, bytesRead);
-totalBytes += bytesRead;
-if (totalBytes > prevBytesRead + 102400) {
-prevBytesRead = totalBytes;
-Log.d(LOG_TAG, "Uploaded " + totalBytes + " of 
" + fixedLength + " bytes");
-}
-bytesAvailable = 
readResult.inputStream.available();
-bufferSize = Math.min(bytesAvailable, 
MAX_BUFFER_SIZE);
-bytesRead = readResult.inputStream.read(buffer, 0, 
bufferSize);
-
-// Send a progress event.
-progress.setLoaded(totalBytes);
-PluginResult progressResult = new 
PluginResult(PluginResult.Status.OK, progress.toJSONObject());
-progressResult.setKeepCallback(true);
-context.sendPluginResult(progressResult);
+if(endByte>0){ //This means we want to read just part 
of the file
+  int byteRange = endByte-startByte;
+  byte[] buffer = new byte[byteRange];
+  if(startByte > 0){ //Start from offset
+readResult.inputStream.skip(startByte);
+  }
+  int bytesRead = readResult.inputStream.read(buffer, 
0, byteRange);
+  totalBytes += byteRange;
+  result.setBytesSent(totalBytes);
+  sendStream.write(buffer, 0, bytesRead);
+  progress.setLoaded(totalBytes);
+  PluginResult progressResult = new 
PluginResult(PluginResult.Status.OK,

[jira] [Commented] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

2017-11-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261594#comment-16261594
 ] 

ASF GitHub Bot commented on CB-10044:
-

maverickmishra commented on issue #116: CB-10044 FileTransfer plug in can 
upload parts of a file to implement resumablejs
URL: 
https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-346182101
 
 
   With the new features introduced in 
[XMLHttpRequest](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest),
 this plugin is not needed any more. Migrating from this plugin to using the 
new features of 
[XMLHttpRequest](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest),
 is explained in this [Cordova blog 
post](https://cordova.apache.org/blog/2017/10/18/from-filetransfer-to-xhr2.html).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-file-transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Assignee: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

2017-11-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239744#comment-16239744
 ] 

ASF GitHub Bot commented on CB-10044:
-

ManicMapple commented on issue #116: CB-10044 FileTransfer plug in can upload 
parts of a file to implement resumablejs
URL: 
https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-342010245
 
 
   Is there an update on this? I want to implement a robust resumable file 
upload for large files, so reading parts of a file would be great.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-file-transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Assignee: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

2015-12-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15065863#comment-15065863
 ] 

ASF GitHub Bot commented on CB-10044:
-

Github user 2garryn commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-166144544
  
Ping @maortega 


> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Assignee: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

2015-12-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046515#comment-15046515
 ] 

ASF GitHub Bot commented on CB-10044:
-

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-162800441
  
Ping @maortega...


> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Assignee: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

2015-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025899#comment-15025899
 ] 

ASF GitHub Bot commented on CB-10044:
-

Github user stevengill commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-159452714
  
@daserge thoughts on merging this?


> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Assignee: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

2015-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026257#comment-15026257
 ] 

ASF GitHub Bot commented on CB-10044:
-

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-159499456
  
@stevengill, There are some questions and proposals on improvement for this 
PR - I believe they should be addressed first.
This is a new feature so it has a lower priority than existing bugs, which 
I'm looking into now.


> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Assignee: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

2015-11-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015451#comment-15015451
 ] 

ASF GitHub Bot commented on CB-10044:
-

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-158329499
  
Hi @maortega, thanks for the contribution!
A few notes on this:
* I believe it is better to move new parameters to 
[`FileUploadOptions`](https://github.com/apache/cordova-plugin-file-transfer/blob/97031b2d7528033c82bdff4659b9041dd9512a51/www/FileTransfer.js#L98),
* Can we move the args to the optional 
[Content-Range](https://tools.ietf.org/html/rfc7233#page-12) header?
* Can you please explain when are you sending `startByte` and `endByte` 
params in the POST? I can't see it in the code.


> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Assignee: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

2015-11-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015454#comment-15015454
 ] 

ASF GitHub Bot commented on CB-10044:
-

Github user daserge commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/116#discussion_r45447454
  
--- Diff: src/ios/CDVFileTransfer.m ---
@@ -259,13 +259,35 @@ - 
(NSURLRequest*)requestForUploadCommand:(CDVInvokedUrlCommand*)command fileData
 CFRelease(writeStream);
 }];
 } else {
+NSNumber* startByte = (NSNumber*)[command argumentAtIndex:11 
withDefault:0];
+NSNumber* endByte = (NSNumber*)[command argumentAtIndex:12 
withDefault:0];
+
+NSInteger i_startByte = [startByte integerValue];
+NSInteger i_endByte = [endByte integerValue];
+
+if(i_endByte == 0){
+i_endByte = -1;
+}
+NSRange chunkRange = NSMakeRange(i_startByte, 
i_endByte-i_startByte);
+NSData* chunkData = [fileData subdataWithRange:chunkRange];
+
 if (multipartFormUpload) {
-[postBodyBeforeFile appendData:fileData];
+[postBodyBeforeFile appendData:chunkData];
+//[postBodyBeforeFile appendData:fileData];
 [postBodyBeforeFile appendData:postBodyAfterFile];
 [req setHTTPBody:postBodyBeforeFile];
 } else {
-[req setHTTPBody:fileData];
+[req setHTTPBody:chunkData];
+//[req setHTTPBody:fileData];
 }
+
+// if (multipartFormUpload) {
+// [postBodyBeforeFile appendData:fileData];
+// [postBodyBeforeFile appendData:postBodyAfterFile];
+// [req setHTTPBody:postBodyBeforeFile];
+// } else {
+// [req setHTTPBody:fileData];
+// }
--- End diff --

Please remove unnecessary comments.


> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Assignee: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

2015-11-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015465#comment-15015465
 ] 

ASF GitHub Bot commented on CB-10044:
-

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-158332458
  
Also the test should be extended to verify the data received by [the 
server](https://github.com/apache/cordova-labs/blob/0987a423d8ba82901a39caf9d1c013f06192e83d/server.js#L37)
 - it echoes the received file params back so at least we can verify the file 
length now (see [verifyUpload 
function](https://github.com/apache/cordova-plugin-file-transfer/blob/97031b2d7528033c82bdff4659b9041dd9512a51/tests/tests.js#L696))
 and we should also verify the contents IMO.

The server responds back like this now:
```

{"fields":{},"files":{"file":{"size":17,"path":"C:\\Users\\SERGEY~1.SHA\\AppData\\Local\\Temp\\upload_d2fac85e424cb5bda30b5cb5900978f7","name":"fileToUpload.txt","type":null,"mtime":"2015-11-19T16:38:41.038Z"}}}
```


> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Assignee: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

2015-11-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014388#comment-15014388
 ] 

ASF GitHub Bot commented on CB-10044:
-

Github user stevengill commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-158201106
  
Could you add a test for this new usecase?


> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

2015-11-19 Thread Marco Antonio Ortega Moulin (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014273#comment-15014273
 ] 

Marco Antonio Ortega Moulin commented on CB-10044:
--

I already have the fix for this, I want this feature assigned to me. Thank you.

> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

2015-11-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014285#comment-15014285
 ] 

ASF GitHub Bot commented on CB-10044:
-

GitHub user maortega opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/116

CB-10044 FileTransfer plug in can upload parts of a file to implement 
resumablejs

By sending the startByte and endByte to the FileTransfer plugin we are able 
to upload parts of a file therefore we can integrate this with ResumableJS

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maortega/cordova-plugin-file-transfer master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #116


commit 2cf7acb9023bedc6d23e7ff765a78522b1677d5a
Author: MARCO ANTONIO ORTEGA 
Date:   2015-11-18T20:36:33Z

Optionally receive startByte and endByte

commit 824a5b223d02e12ab21430184486ed3d4b3ca7cc
Author: MARCO ANTONIO ORTEGA 
Date:   2015-11-19T16:37:05Z

Use byte range to send a portion of a file to be able to be compatible with 
resumablejs

commit 38cc769dc92b7f32e727021508b535f3ba42e402
Author: MARCO ANTONIO ORTEGA 
Date:   2015-11-19T16:47:19Z

Send byte range of file.

commit 8a642151a16c0aa275adf5b971b180c964e9bb8d
Author: MARCO ANTONIO ORTEGA 
Date:   2015-11-19T16:47:31Z

Merge branch 'feature/Accept_file_ranges' into develop

commit 33774fd8c8b1b493a92fd6dc5bcaf531ab7c6371
Author: MARCO ANTONIO ORTEGA 
Date:   2015-11-19T16:49:41Z

Merge branch 'release/1.1'




> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

2015-11-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014697#comment-15014697
 ] 

ASF GitHub Bot commented on CB-10044:
-

Github user maortega commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-158229415
  
Sure, test added.


> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Assignee: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org