[jira] [Commented] (CB-10045) Extend bootstrap stylings to docs
[ https://issues.apache.org/jira/browse/CB-10045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102593#comment-15102593 ] Richard B Knoll commented on CB-10045: -- [~rakatyal] Probably. > Extend bootstrap stylings to docs > - > > Key: CB-10045 > URL: https://issues.apache.org/jira/browse/CB-10045 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Richard B Knoll >Priority: Minor > > We don't control the HTML that is produced by Redcarpet in the docs > generation. That means that we can't apply CSS classes to them. Certain > elements (like tables) are probably better off having the bootstrap CSS > automatically applied. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10045) Extend bootstrap stylings to docs
[ https://issues.apache.org/jira/browse/CB-10045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102522#comment-15102522 ] Raghav commented on CB-10045: - [~riknoll]: Can we close this? > Extend bootstrap stylings to docs > - > > Key: CB-10045 > URL: https://issues.apache.org/jira/browse/CB-10045 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Richard B Knoll >Priority: Minor > > We don't control the HTML that is produced by Redcarpet in the docs > generation. That means that we can't apply CSS classes to them. Certain > elements (like tables) are probably better off having the bootstrap CSS > automatically applied. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10045) Extend bootstrap stylings to docs
[ https://issues.apache.org/jira/browse/CB-10045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015111#comment-15015111 ] ASF GitHub Bot commented on CB-10045: - Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/427#issuecomment-158266219 LGTM. > Extend bootstrap stylings to docs > - > > Key: CB-10045 > URL: https://issues.apache.org/jira/browse/CB-10045 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Richard B Knoll >Priority: Minor > > We don't control the HTML that is produced by Redcarpet in the docs > generation. That means that we can't apply CSS classes to them. Certain > elements (like tables) are probably better off having the bootstrap CSS > automatically applied. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10045) Extend bootstrap stylings to docs
[ https://issues.apache.org/jira/browse/CB-10045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015108#comment-15015108 ] ASF GitHub Bot commented on CB-10045: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/427 > Extend bootstrap stylings to docs > - > > Key: CB-10045 > URL: https://issues.apache.org/jira/browse/CB-10045 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Richard B Knoll >Priority: Minor > > We don't control the HTML that is produced by Redcarpet in the docs > generation. That means that we can't apply CSS classes to them. Certain > elements (like tables) are probably better off having the bootstrap CSS > automatically applied. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10045) Extend bootstrap stylings to docs
[ https://issues.apache.org/jira/browse/CB-10045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015106#comment-15015106 ] ASF subversion and git services commented on CB-10045: -- Commit 95c3b8c8623ea2ac748ceb25f66a5a272c028238 in cordova-docs's branch refs/heads/master from riknoll [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=95c3b8c ] CB-10045: Made table elements in docs extend bootstrap table classes. This closes #427. > Extend bootstrap stylings to docs > - > > Key: CB-10045 > URL: https://issues.apache.org/jira/browse/CB-10045 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Richard B Knoll >Priority: Minor > > We don't control the HTML that is produced by Redcarpet in the docs > generation. That means that we can't apply CSS classes to them. Certain > elements (like tables) are probably better off having the bootstrap CSS > automatically applied. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10045) Extend bootstrap stylings to docs
[ https://issues.apache.org/jira/browse/CB-10045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014323#comment-15014323 ] ASF GitHub Bot commented on CB-10045: - GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/427 CB-10045: Made table elements in docs extend bootstrap table classes I'm adding a docs page and need table styles. This affects the platform support table FYI. @dblotsky please review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/riknoll/cordova-docs CB-10045 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/427.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #427 commit 604519009c02e7d13a1fa106984ad7c119799980 Author: riknoll Date: 2015-11-19T20:44:46Z CB-10045: Made table elements in docs extend bootstrap table classes > Extend bootstrap stylings to docs > - > > Key: CB-10045 > URL: https://issues.apache.org/jira/browse/CB-10045 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Richard B Knoll >Priority: Minor > > We don't control the HTML that is produced by Redcarpet in the docs > generation. That means that we can't apply CSS classes to them. Certain > elements (like tables) are probably better off having the bootstrap CSS > automatically applied. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10045) Extend bootstrap stylings to docs
[ https://issues.apache.org/jira/browse/CB-10045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014309#comment-15014309 ] Richard B Knoll commented on CB-10045: -- At the very least, I think there is no harm in making tables extend the bootstrap styling. [~dblotsky] can you think of anything else? If any pages absolutely NEED to override the bootstrap CSS, they can always be written in HTML > Extend bootstrap stylings to docs > - > > Key: CB-10045 > URL: https://issues.apache.org/jira/browse/CB-10045 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Richard B Knoll >Priority: Minor > > We don't control the HTML that is produced by Redcarpet in the docs > generation. That means that we can't apply CSS classes to them. Certain > elements (like tables) are probably better off having the bootstrap CSS > automatically applied. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
