[jira] [Commented] (CB-10140) Use application id instead of package name when running
[ https://issues.apache.org/jira/browse/CB-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467626#comment-15467626 ] ASF GitHub Bot commented on CB-10140: - Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/244 @fredgalvao The PR was closed, not the issue. > Use application id instead of package name when running > --- > > Key: CB-10140 > URL: https://issues.apache.org/jira/browse/CB-10140 > Project: Apache Cordova > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Android, CLI >Reporter: Christian Cook >Priority: Minor > > I've been working on a new plugin for Cordova which will allow you to easily > deploy different build types in a system lifecycle e.g. alpha, beta and > store. This will allow multiple instances of the same app on your device in > different states. Currently I've hit a bit of an interesting bug/issue when > using this in conjunction with the run command. When the plugin operates it > dynamically changes the application id depending on the state so com.test.app > becomes com.test.app.alpha and so son. Because of this, when running the app > from the CLI it then starts using the incorrect ID (it uses the packageName > from the Android Manifest and tries to run nothing or the wrong instance). > EDIT: See the PR for a suggested fix, and if you wish to try and replicate > this issue the plugin is now available here: > https://github.com/CookieCookson/cordova-plugin-lifecycle -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10140) Use application id instead of package name when running
[ https://issues.apache.org/jira/browse/CB-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15466348#comment-15466348 ] ASF GitHub Bot commented on CB-10140: - Github user fredgalvao commented on the issue: https://github.com/apache/cordova-android/pull/244 @infil00p This issue still exists. For anyone changin applicationId on android, to use flavours or whitelabel-like solutions, running cordova will always try to launch the base package name. It should definitely launch the applicationId instead. I mistakenly created [another issue](https://issues.apache.org/jira/browse/CB-11374) a while ago for this, and I just now discovered this issue because of the mailing list notifications. I'd love to see this topic being fixed/improved. There are a few other comments in [this issue](https://issues.apache.org/jira/browse/CB-11373) as well, regarding this subject. > Use application id instead of package name when running > --- > > Key: CB-10140 > URL: https://issues.apache.org/jira/browse/CB-10140 > Project: Apache Cordova > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Android, CLI >Reporter: Christian Cook >Priority: Minor > > I've been working on a new plugin for Cordova which will allow you to easily > deploy different build types in a system lifecycle e.g. alpha, beta and > store. This will allow multiple instances of the same app on your device in > different states. Currently I've hit a bit of an interesting bug/issue when > using this in conjunction with the run command. When the plugin operates it > dynamically changes the application id depending on the state so com.test.app > becomes com.test.app.alpha and so son. Because of this, when running the app > from the CLI it then starts using the incorrect ID (it uses the packageName > from the Android Manifest and tries to run nothing or the wrong instance). > EDIT: See the PR for a suggested fix, and if you wish to try and replicate > this issue the plugin is now available here: > https://github.com/CookieCookson/cordova-plugin-lifecycle -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10140) Use application id instead of package name when running
[ https://issues.apache.org/jira/browse/CB-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15454695#comment-15454695 ] ASF GitHub Bot commented on CB-10140: - Github user CookieCookson commented on the issue: https://github.com/apache/cordova-android/pull/244 @infil00p I haven't had the time available to work any more on this, and have got around the issue by other means! I would say close it for now. > Use application id instead of package name when running > --- > > Key: CB-10140 > URL: https://issues.apache.org/jira/browse/CB-10140 > Project: Apache Cordova > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Android, CLI >Reporter: Christian Cook >Priority: Minor > > I've been working on a new plugin for Cordova which will allow you to easily > deploy different build types in a system lifecycle e.g. alpha, beta and > store. This will allow multiple instances of the same app on your device in > different states. Currently I've hit a bit of an interesting bug/issue when > using this in conjunction with the run command. When the plugin operates it > dynamically changes the application id depending on the state so com.test.app > becomes com.test.app.alpha and so son. Because of this, when running the app > from the CLI it then starts using the incorrect ID (it uses the packageName > from the Android Manifest and tries to run nothing or the wrong instance). > EDIT: See the PR for a suggested fix, and if you wish to try and replicate > this issue the plugin is now available here: > https://github.com/CookieCookson/cordova-plugin-lifecycle -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10140) Use application id instead of package name when running
[ https://issues.apache.org/jira/browse/CB-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15454696#comment-15454696 ] ASF GitHub Bot commented on CB-10140: - Github user CookieCookson closed the pull request at: https://github.com/apache/cordova-android/pull/244 > Use application id instead of package name when running > --- > > Key: CB-10140 > URL: https://issues.apache.org/jira/browse/CB-10140 > Project: Apache Cordova > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Android, CLI >Reporter: Christian Cook >Priority: Minor > > I've been working on a new plugin for Cordova which will allow you to easily > deploy different build types in a system lifecycle e.g. alpha, beta and > store. This will allow multiple instances of the same app on your device in > different states. Currently I've hit a bit of an interesting bug/issue when > using this in conjunction with the run command. When the plugin operates it > dynamically changes the application id depending on the state so com.test.app > becomes com.test.app.alpha and so son. Because of this, when running the app > from the CLI it then starts using the incorrect ID (it uses the packageName > from the Android Manifest and tries to run nothing or the wrong instance). > EDIT: See the PR for a suggested fix, and if you wish to try and replicate > this issue the plugin is now available here: > https://github.com/CookieCookson/cordova-plugin-lifecycle -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10140) Use application id instead of package name when running
[ https://issues.apache.org/jira/browse/CB-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453449#comment-15453449 ] ASF GitHub Bot commented on CB-10140: - Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/244 @CookieCookson This seems to have fallen by the wayside for quite a few months. Are you still looking to add this, or should I close it since it no longer merges cleanly? > Use application id instead of package name when running > --- > > Key: CB-10140 > URL: https://issues.apache.org/jira/browse/CB-10140 > Project: Apache Cordova > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Android, CLI >Reporter: Christian Cook >Priority: Minor > > I've been working on a new plugin for Cordova which will allow you to easily > deploy different build types in a system lifecycle e.g. alpha, beta and > store. This will allow multiple instances of the same app on your device in > different states. Currently I've hit a bit of an interesting bug/issue when > using this in conjunction with the run command. When the plugin operates it > dynamically changes the application id depending on the state so com.test.app > becomes com.test.app.alpha and so son. Because of this, when running the app > from the CLI it then starts using the incorrect ID (it uses the packageName > from the Android Manifest and tries to run nothing or the wrong instance). > EDIT: See the PR for a suggested fix, and if you wish to try and replicate > this issue the plugin is now available here: > https://github.com/CookieCookson/cordova-plugin-lifecycle -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10140) Use application id instead of package name when running
[ https://issues.apache.org/jira/browse/CB-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050617#comment-15050617 ] ASF GitHub Bot commented on CB-10140: - Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/244#issuecomment-163582855 Thanks for explanation, @CookieCookson > Use application id instead of package name when running > --- > > Key: CB-10140 > URL: https://issues.apache.org/jira/browse/CB-10140 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, CLI >Reporter: Christian Cook >Priority: Minor > > I've been working on a new plugin for Cordova which will allow you to easily > deploy different build types in a system lifecycle e.g. alpha, beta and > store. This will allow multiple instances of the same app on your device in > different states. Currently I've hit a bit of an interesting bug/issue when > using this in conjunction with the run command. When the plugin operates it > dynamically changes the application id depending on the state so com.test.app > becomes com.test.app.alpha and so son. Because of this, when running the app > from the CLI it then starts using the incorrect ID (it uses the packageName > from the Android Manifest and tries to run nothing or the wrong instance). > EDIT: See the PR for a suggested fix, and if you wish to try and replicate > this issue the plugin is now available here: > https://github.com/CookieCookson/cordova-plugin-lifecycle -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10140) Use application id instead of package name when running
[ https://issues.apache.org/jira/browse/CB-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050410#comment-15050410 ] ASF GitHub Bot commented on CB-10140: - Github user CookieCookson commented on the pull request: https://github.com/apache/cordova-android/pull/244#issuecomment-163540285 @vladimir-kotikov Thanks for the response! I have created the PR as a fix to an issue with a plugin I am developing. See https://github.com/CookieCookson/cordova-plugin-lifecycle and it should explain its use. I shall investigate check_reqs. > Use application id instead of package name when running > --- > > Key: CB-10140 > URL: https://issues.apache.org/jira/browse/CB-10140 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, CLI >Reporter: Christian Cook >Priority: Minor > > I've been working on a new plugin for Cordova which will allow you to easily > deploy different build types in a system lifecycle e.g. alpha, beta and > store. This will allow multiple instances of the same app on your device in > different states. Currently I've hit a bit of an interesting bug/issue when > using this in conjunction with the run command. When the plugin operates it > dynamically changes the application id depending on the state so com.test.app > becomes com.test.app.alpha and so son. Because of this, when running the app > from the CLI it then starts using the incorrect ID (it uses the packageName > from the Android Manifest and tries to run nothing or the wrong instance). > EDIT: See the PR for a suggested fix, and if you wish to try and replicate > this issue the plugin is now available here: > https://github.com/CookieCookson/cordova-plugin-lifecycle -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10140) Use application id instead of package name when running
[ https://issues.apache.org/jira/browse/CB-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048386#comment-15048386 ] ASF GitHub Bot commented on CB-10140: - Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/244#issuecomment-163165235 @CookieCookson, LGTM, though I'm not sure about situations when this would be useful. However the problem here is that aapt might be not in the $PATH, so probably you need to check this and set up $PATH correspondingly in [check_reqs](https://github.com/apache/cordova-android/blob/master/bin/lib/check_reqs.js) > Use application id instead of package name when running > --- > > Key: CB-10140 > URL: https://issues.apache.org/jira/browse/CB-10140 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, CLI >Reporter: Christian Cook >Priority: Minor > > I've been working on a new plugin for Cordova which will allow you to easily > deploy different build types in a system lifecycle e.g. alpha, beta and > store. This will allow multiple instances of the same app on your device in > different states. Currently I've hit a bit of an interesting bug/issue when > using this in conjunction with the run command. When the plugin operates it > dynamically changes the application id depending on the state so com.test.app > becomes com.test.app.alpha and so son. Because of this, when running the app > from the CLI it then starts using the incorrect ID (it uses the packageName > from the Android Manifest and tries to run nothing or the wrong instance). > EDIT: See the PR for a suggested fix, and if you wish to try and replicate > this issue the plugin is now available here: > https://github.com/CookieCookson/cordova-plugin-lifecycle -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10140) Use application id instead of package name when running
[ https://issues.apache.org/jira/browse/CB-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048335#comment-15048335 ] Christian Cook commented on CB-10140: - [~riknoll] I've submitted it as a PR and also included a link to the plugin to test with in the description. > Use application id instead of package name when running > --- > > Key: CB-10140 > URL: https://issues.apache.org/jira/browse/CB-10140 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, CLI >Reporter: Christian Cook >Priority: Minor > > I've been working on a new plugin for Cordova which will allow you to easily > deploy different build types in a system lifecycle e.g. alpha, beta and > store. This will allow multiple instances of the same app on your device in > different states. Currently I've hit a bit of an interesting bug/issue when > using this in conjunction with the run command. When the plugin operates it > dynamically changes the application id depending on the state so com.test.app > becomes com.test.app.alpha and so son. Because of this, when running the app > from the CLI it then starts using the incorrect ID (it uses the packageName > from the Android Manifest and tries to run nothing or the wrong instance). > EDIT: See the PR for a suggested fix, and if you wish to try and replicate > this issue the plugin is now available here: > https://github.com/CookieCookson/cordova-plugin-lifecycle -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10140) Use application id instead of package name when running
[ https://issues.apache.org/jira/browse/CB-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048322#comment-15048322 ] ASF GitHub Bot commented on CB-10140: - GitHub user CookieCookson opened a pull request: https://github.com/apache/cordova-android/pull/244 CB-10140 Use application id instead of package name when running You can merge this pull request into a Git repository by running: $ git pull https://github.com/CookieCookson/cordova-android applicationid Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/244.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #244 commit 6b0cdfc6b8cba99669ff689316533f6f48ecb110 Author: Christian Cook Date: 2015-12-03T14:00:36Z create aapt function to get application id from apk commit ea1e09fb85d65248030d406340b3ff49225fdebf Author: Christian Cook Date: 2015-12-03T14:00:54Z use application id in device installs commit 1ed0b8547fb4551416c471599c41e085d4a288cd Author: Christian Cook Date: 2015-12-04T11:04:59Z fixes applicationId not being set for uninstall process commit dd57d1542ad2a369955a39bffbcd4cdacef0df8c Author: Christian Cook Date: 2015-12-04T15:53:57Z uses application id on emulator install > Use application id instead of package name when running > --- > > Key: CB-10140 > URL: https://issues.apache.org/jira/browse/CB-10140 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, CLI >Reporter: Christian Cook >Priority: Minor > > I've been working on a new plugin for Cordova which will allow you to easily > deploy different build types in a system lifecycle e.g. alpha, beta and > store. This will allow multiple instances of the same app on your device in > different states. Currently I've hit a bit of an interesting bug/issue when > using this in conjunction with the run command. When the plugin operates it > dynamically changes the application id depending on the state so com.test.app > becomes com.test.app.alpha and so son. Because of this, when running the app > from the CLI it then starts using the incorrect ID (it uses the packageName > from the Android Manifest and tries to run nothing or the wrong instance). > Below I have put together a solution which solves this issue. Would somebody > be able to assess this and give me your thoughts on the improvement? > https://github.com/CookieCookson/cordova-android/compare/master...CookieCookson:applicationid -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10140) Use application id instead of package name when running
[ https://issues.apache.org/jira/browse/CB-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047822#comment-15047822 ] Richard B Knoll commented on CB-10140: -- [~Cookie_Cookson] This might be a bit easier to review if you submit it as a PR (just use the JIRA ID in the title and the ASF git bot will comment on this issue). > Use application id instead of package name when running > --- > > Key: CB-10140 > URL: https://issues.apache.org/jira/browse/CB-10140 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, CLI >Reporter: Christian Cook >Priority: Minor > > I've been working on a new plugin for Cordova which will allow you to easily > deploy different build types in a system lifecycle e.g. alpha, beta and > store. This will allow multiple instances of the same app on your device in > different states. Currently I've hit a bit of an interesting bug/issue when > using this in conjunction with the run command. When the plugin operates it > dynamically changes the application id depending on the state so com.test.app > becomes com.test.app.alpha and so son. Because of this, when running the app > from the CLI it then starts using the incorrect ID (it uses the packageName > from the Android Manifest and tries to run nothing or the wrong instance). > Below I have put together a solution which solves this issue. Would somebody > be able to assess this and give me your thoughts on the improvement? > https://github.com/CookieCookson/cordova-android/compare/master...CookieCookson:applicationid -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
