[jira] [Commented] (CB-10204) Fix getCurrentPosition options on Android

[Stelios Charmpalis (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089406#comment-15089406
 ] 

Stelios Charmpalis commented on CB-10204:
-

Hello guys,

When this update will be merged to a stable release?

> Fix getCurrentPosition options on Android
> -
>
> Key: CB-10204
> URL: https://issues.apache.org/jira/browse/CB-10204
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Geolocation
> Environment: Cordova 3.5.0, Plugin Geolocation 2.0.0
>Reporter: Timo Salola
>  Labels: Android, Triaged
>
> In the latest release there was created separate JS file for android. In 
> getCurrentPosition it does not verify that options are given resulting 
> javascript error when trying to access undefined as an array at 
> www/android/geolocation.js lines 33 and 34:
> {code:javascript}
> getCurrentPosition: function(success, error, args) {
> var win = function() {
>   var geo = 
> cordova.require('cordova/modulemapper').getOriginalSymbol(window, 
> 'navigator.geolocation');
>   geo.getCurrentPosition(success, error, {
> enableHighAccuracy: args[0],
> maximumAge: args[1]
>   });
> };
> exec(win, error, "Geolocation", "getPermission", []);
> }
> {code}
> Workaround this is to give empty array to getCurrentPosition as options:
> {code:javascript}
> navigator.geolocation.getCurrentPosition(onSuccess, onError, []);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10204) Fix getCurrentPosition options on Android

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15080796#comment-15080796
 ] 

ASF subversion and git services commented on CB-10204:
--

Commit 8cf37567c4c144303c59128664db71abe196bc23 in cordova-plugin-geolocation's 
branch refs/heads/master from sgrebnov
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-geolocation.git;h=8cf3756
 ]

CB-10204 Fix getCurrentPosition options on Android

github close #60


> Fix getCurrentPosition options on Android
> -
>
> Key: CB-10204
> URL: https://issues.apache.org/jira/browse/CB-10204
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Geolocation
> Environment: Cordova 3.5.0, Plugin Geolocation 2.0.0
>Reporter: Timo Salola
>Assignee: Sergey Grebnov
>  Labels: Android, Triaged
>
> In the latest release there was created separate JS file for android. In 
> getCurrentPosition it does not verify that options are given resulting 
> javascript error when trying to access undefined as an array at 
> www/android/geolocation.js lines 33 and 34:
> {code:javascript}
> getCurrentPosition: function(success, error, args) {
> var win = function() {
>   var geo = 
> cordova.require('cordova/modulemapper').getOriginalSymbol(window, 
> 'navigator.geolocation');
>   geo.getCurrentPosition(success, error, {
> enableHighAccuracy: args[0],
> maximumAge: args[1]
>   });
> };
> exec(win, error, "Geolocation", "getPermission", []);
> }
> {code}
> Workaround this is to give empty array to getCurrentPosition as options:
> {code:javascript}
> navigator.geolocation.getCurrentPosition(onSuccess, onError, []);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10204) Fix getCurrentPosition options on Android

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15080799#comment-15080799
 ] 

ASF GitHub Bot commented on CB-10204:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-geolocation/pull/60


> Fix getCurrentPosition options on Android
> -
>
> Key: CB-10204
> URL: https://issues.apache.org/jira/browse/CB-10204
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Geolocation
> Environment: Cordova 3.5.0, Plugin Geolocation 2.0.0
>Reporter: Timo Salola
>Assignee: Sergey Grebnov
>  Labels: Android, Triaged
>
> In the latest release there was created separate JS file for android. In 
> getCurrentPosition it does not verify that options are given resulting 
> javascript error when trying to access undefined as an array at 
> www/android/geolocation.js lines 33 and 34:
> {code:javascript}
> getCurrentPosition: function(success, error, args) {
> var win = function() {
>   var geo = 
> cordova.require('cordova/modulemapper').getOriginalSymbol(window, 
> 'navigator.geolocation');
>   geo.getCurrentPosition(success, error, {
> enableHighAccuracy: args[0],
> maximumAge: args[1]
>   });
> };
> exec(win, error, "Geolocation", "getPermission", []);
> }
> {code}
> Workaround this is to give empty array to getCurrentPosition as options:
> {code:javascript}
> navigator.geolocation.getCurrentPosition(onSuccess, onError, []);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10204) Fix getCurrentPosition options on Android

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15075824#comment-15075824
 ] 

ASF GitHub Bot commented on CB-10204:
-

Github user alsorokin commented on the pull request:


https://github.com/apache/cordova-plugin-geolocation/pull/60#issuecomment-168148369
  
:+1: 


> Fix getCurrentPosition options on Android
> -
>
> Key: CB-10204
> URL: https://issues.apache.org/jira/browse/CB-10204
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Geolocation
> Environment: Cordova 3.5.0, Plugin Geolocation 2.0.0
>Reporter: Timo Salola
>Assignee: Sergey Grebnov
>  Labels: Android, Triaged
>
> In the latest release there was created separate JS file for android. In 
> getCurrentPosition it does not verify that options are given resulting 
> javascript error when trying to access undefined as an array at 
> www/android/geolocation.js lines 33 and 34:
> {code:javascript}
> getCurrentPosition: function(success, error, args) {
> var win = function() {
>   var geo = 
> cordova.require('cordova/modulemapper').getOriginalSymbol(window, 
> 'navigator.geolocation');
>   geo.getCurrentPosition(success, error, {
> enableHighAccuracy: args[0],
> maximumAge: args[1]
>   });
> };
> exec(win, error, "Geolocation", "getPermission", []);
> }
> {code}
> Workaround this is to give empty array to getCurrentPosition as options:
> {code:javascript}
> navigator.geolocation.getCurrentPosition(onSuccess, onError, []);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10204) Fix getCurrentPosition options on Android

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074906#comment-15074906
 ] 

ASF GitHub Bot commented on CB-10204:
-

Github user vladimir-kotikov commented on the pull request:


https://github.com/apache/cordova-plugin-geolocation/pull/60#issuecomment-167973027
  
LGTM


> Fix getCurrentPosition options on Android
> -
>
> Key: CB-10204
> URL: https://issues.apache.org/jira/browse/CB-10204
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Geolocation
> Environment: Cordova 3.5.0, Plugin Geolocation 2.0.0
>Reporter: Timo Salola
>Assignee: Sergey Grebnov
>  Labels: Android, Triaged
>
> In the latest release there was created separate JS file for android. In 
> getCurrentPosition it does not verify that options are given resulting 
> javascript error when trying to access undefined as an array at 
> www/android/geolocation.js lines 33 and 34:
> {code:javascript}
> getCurrentPosition: function(success, error, args) {
> var win = function() {
>   var geo = 
> cordova.require('cordova/modulemapper').getOriginalSymbol(window, 
> 'navigator.geolocation');
>   geo.getCurrentPosition(success, error, {
> enableHighAccuracy: args[0],
> maximumAge: args[1]
>   });
> };
> exec(win, error, "Geolocation", "getPermission", []);
> }
> {code}
> Workaround this is to give empty array to getCurrentPosition as options:
> {code:javascript}
> navigator.geolocation.getCurrentPosition(onSuccess, onError, []);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10204) Fix getCurrentPosition options on Android

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073045#comment-15073045
 ] 

ASF GitHub Bot commented on CB-10204:
-

GitHub user sgrebnov opened a pull request:

https://github.com/apache/cordova-plugin-geolocation/pull/60

CB-10204 Fix getCurrentPosition options on Android

https://issues.apache.org/jira/browse/CB-10204

Args is an object, not array, and should be passed as-is.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-geolocation CB-10204

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-geolocation/pull/60.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #60


commit 50891ef85c7530a7eba74e0aece71de41171b27b
Author: sgrebnov 
Date:   2015-12-28T19:18:29Z

CB-10204 Fix getCurrentPosition options on Android




> Fix getCurrentPosition options on Android
> -
>
> Key: CB-10204
> URL: https://issues.apache.org/jira/browse/CB-10204
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Geolocation
> Environment: Cordova 3.5.0, Plugin Geolocation 2.0.0
>Reporter: Timo Salola
>Assignee: Sergey Grebnov
>  Labels: Android, Triaged
>
> In the latest release there was created separate JS file for android. In 
> getCurrentPosition it does not verify that options are given resulting 
> javascript error when trying to access undefined as an array at 
> www/android/geolocation.js lines 33 and 34:
> {code:javascript}
> getCurrentPosition: function(success, error, args) {
> var win = function() {
>   var geo = 
> cordova.require('cordova/modulemapper').getOriginalSymbol(window, 
> 'navigator.geolocation');
>   geo.getCurrentPosition(success, error, {
> enableHighAccuracy: args[0],
> maximumAge: args[1]
>   });
> };
> exec(win, error, "Geolocation", "getPermission", []);
> }
> {code}
> Workaround this is to give empty array to getCurrentPosition as options:
> {code:javascript}
> navigator.geolocation.getCurrentPosition(onSuccess, onError, []);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org