[jira] [Commented] (CB-10255) Add options to hide splashscreen navigation and status bars on Android
[ https://issues.apache.org/jira/browse/CB-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182617#comment-16182617 ] ASF GitHub Bot commented on CB-10255: - Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/45 Reading through the comments there seem to be problems with the functionality, right? > Add options to hide splashscreen navigation and status bars on Android > -- > > Key: CB-10255 > URL: https://issues.apache.org/jira/browse/CB-10255 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-splashscreen >Reporter: Sergey Shakhnazarov > Labels: android, triaged > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10255) Add options to hide splashscreen navigation and status bars on Android
[ https://issues.apache.org/jira/browse/CB-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181632#comment-16181632 ] ASF GitHub Bot commented on CB-10255: - Github user charlesbodman commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/45 Yeah, no doubt. Thanks. > Add options to hide splashscreen navigation and status bars on Android > -- > > Key: CB-10255 > URL: https://issues.apache.org/jira/browse/CB-10255 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-splashscreen >Reporter: Sergey Shakhnazarov > Labels: android, triaged > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10255) Add options to hide splashscreen navigation and status bars on Android
[ https://issues.apache.org/jira/browse/CB-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181569#comment-16181569 ] ASF GitHub Bot commented on CB-10255: - Github user TheBosZ commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/45 Doubt this will ever get merged since it's so old. PRs on Cordova stuff never get any attention so don't hold your breath. > Add options to hide splashscreen navigation and status bars on Android > -- > > Key: CB-10255 > URL: https://issues.apache.org/jira/browse/CB-10255 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-splashscreen >Reporter: Sergey Shakhnazarov > Labels: android, triaged > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10255) Add options to hide splashscreen navigation and status bars on Android
[ https://issues.apache.org/jira/browse/CB-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181557#comment-16181557 ] ASF GitHub Bot commented on CB-10255: - Github user charlesbodman commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/45 Did this ever get solved? > Add options to hide splashscreen navigation and status bars on Android > -- > > Key: CB-10255 > URL: https://issues.apache.org/jira/browse/CB-10255 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-splashscreen >Reporter: Sergey Shakhnazarov > Labels: android, triaged > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10255) Add options to hide splashscreen navigation and status bars on Android
[ https://issues.apache.org/jira/browse/CB-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291082#comment-15291082 ] ASF GitHub Bot commented on CB-10255: - Github user thom7kick commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-220321857 can u Add options to change colors of the splashscreen navigation and status bars on Android > Add options to hide splashscreen navigation and status bars on Android > -- > > Key: CB-10255 > URL: https://issues.apache.org/jira/browse/CB-10255 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin SplashScreen >Reporter: Sergey Shakhnazarov > Labels: android, triaged > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10255) Add options to hide splashscreen navigation and status bars on Android
[ https://issues.apache.org/jira/browse/CB-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15093516#comment-15093516 ] ASF GitHub Bot commented on CB-10255: - Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-170834623 Ping @TheBosZ... > Add options to hide splashscreen navigation and status bars on Android > -- > > Key: CB-10255 > URL: https://issues.apache.org/jira/browse/CB-10255 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin SplashScreen >Reporter: Sergey Shakhnazarov > Labels: android, triaged > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10255) Add options to hide splashscreen navigation and status bars on Android
[ https://issues.apache.org/jira/browse/CB-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15094227#comment-15094227 ] ASF GitHub Bot commented on CB-10255: - Github user TheBosZ commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-170969928 @daserge Sorry, got busy with something else. I can duplicate the behavior on all my test devices, but I can't figure out a way to prevent it. Even if I save the window styles and change them back, it will still do the content move. > Add options to hide splashscreen navigation and status bars on Android > -- > > Key: CB-10255 > URL: https://issues.apache.org/jira/browse/CB-10255 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin SplashScreen >Reporter: Sergey Shakhnazarov > Labels: android, triaged > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10255) Add options to hide splashscreen navigation and status bars on Android
[ https://issues.apache.org/jira/browse/CB-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072830#comment-15072830 ] ASF GitHub Bot commented on CB-10255: - Github user TheBosZ commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-167591082 Sounds good to me :+1: > Add options to hide splashscreen navigation and status bars on Android > -- > > Key: CB-10255 > URL: https://issues.apache.org/jira/browse/CB-10255 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin SplashScreen >Reporter: Sergey Shakhnazarov > Labels: android > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10255) Add options to hide splashscreen navigation and status bars on Android
[ https://issues.apache.org/jira/browse/CB-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072976#comment-15072976 ] ASF GitHub Bot commented on CB-10255: - Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-167622467 @TheBosZ, I've tested this once more and found a bug reproducing on 4.0.3 and 5.0.1 that there is a small content movement to the bottom (in case of 5.0.1 there are even several such movements) after splashscreen is hidden. This issue does not occur on 4.3 though. Looks like the window style changes don't get reset - could you please take a look? > Add options to hide splashscreen navigation and status bars on Android > -- > > Key: CB-10255 > URL: https://issues.apache.org/jira/browse/CB-10255 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin SplashScreen >Reporter: Sergey Shakhnazarov > Labels: android > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10255) Add options to hide splashscreen navigation and status bars on Android
[
https://issues.apache.org/jira/browse/CB-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071054#comment-15071054
]
ASF GitHub Bot commented on CB-10255:
-
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-167118349
Combining `splashDialog.getWindow().setFlags` and
`splashDialog.getWindow().getDecorView().setSystemUiVisibility` approach works
on 4.0.3 (with and without soft navbar), 4.3 and 5.1.1:
```java
if (isForceFullScreen()) {
splashDialog.getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,
WindowManager.LayoutParams.FLAG_FULLSCREEN);
splashDialog.getWindow().getDecorView().setSystemUiVisibility(
View.SYSTEM_UI_FLAG_HIDE_NAVIGATION |
View.SYSTEM_UI_FLAG_FULLSCREEN);
}
```
(the current code works properly only for >=Lollipop)
What do you think on updating to this?
> Add options to hide splashscreen navigation and status bars on Android
> --
>
> Key: CB-10255
> URL: https://issues.apache.org/jira/browse/CB-10255
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin SplashScreen
>Reporter: Sergey Shakhnazarov
> Labels: android
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10255) Add options to hide splashscreen navigation and status bars on Android
[ https://issues.apache.org/jira/browse/CB-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069855#comment-15069855 ] ASF GitHub Bot commented on CB-10255: - Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166941739 Added a Jira issue: [CB-10255 Add options to hide splashscreen navigation and status bars on Android](https://issues.apache.org/jira/browse/CB-10255). @TheBosZ, please squash the commits and rename the PR and the commit title to `CB-10255 Add options to hide splashscreen navigation and status bars on Android`. > Add options to hide splashscreen navigation and status bars on Android > -- > > Key: CB-10255 > URL: https://issues.apache.org/jira/browse/CB-10255 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin SplashScreen >Reporter: Sergey Shakhnazarov > Labels: android > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10255) Add options to hide splashscreen navigation and status bars on Android
[ https://issues.apache.org/jira/browse/CB-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070073#comment-15070073 ] ASF GitHub Bot commented on CB-10255: - Github user TheBosZ commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166975687 Okay, it was messy but I squished it into one commit and changed it to just be a single preference to force full screen. > Add options to hide splashscreen navigation and status bars on Android > -- > > Key: CB-10255 > URL: https://issues.apache.org/jira/browse/CB-10255 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin SplashScreen >Reporter: Sergey Shakhnazarov > Labels: android > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10255) Add options to hide splashscreen navigation and status bars on Android
[
https://issues.apache.org/jira/browse/CB-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070079#comment-15070079
]
ASF GitHub Bot commented on CB-10255:
-
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r48373317
--- Diff: src/android/SplashScreen.java ---
@@ -255,6 +259,10 @@ public void run() {
}
splashDialog.setContentView(splashImageView);
splashDialog.setCancelable(false);
+if (isForceFullScreen()) {
--- End diff --
Does it make sense to move this to `// check to see if the splash screen
should be full screen` condition above?
> Add options to hide splashscreen navigation and status bars on Android
> --
>
> Key: CB-10255
> URL: https://issues.apache.org/jira/browse/CB-10255
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin SplashScreen
>Reporter: Sergey Shakhnazarov
> Labels: android
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10255) Add options to hide splashscreen navigation and status bars on Android
[ https://issues.apache.org/jira/browse/CB-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070081#comment-15070081 ] ASF GitHub Bot commented on CB-10255: - Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166976789 :+1: thanks, @TheBosZ! I will merge this tomorrow. > Add options to hide splashscreen navigation and status bars on Android > -- > > Key: CB-10255 > URL: https://issues.apache.org/jira/browse/CB-10255 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin SplashScreen >Reporter: Sergey Shakhnazarov > Labels: android > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10255) Add options to hide splashscreen navigation and status bars on Android
[ https://issues.apache.org/jira/browse/CB-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070024#comment-15070024 ] ASF GitHub Bot commented on CB-10255: - Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166968629 Yeah, this is a good idea, kills two birds with one stone. > Add options to hide splashscreen navigation and status bars on Android > -- > > Key: CB-10255 > URL: https://issues.apache.org/jira/browse/CB-10255 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin SplashScreen >Reporter: Sergey Shakhnazarov > Labels: android > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10255) Add options to hide splashscreen navigation and status bars on Android
[
https://issues.apache.org/jira/browse/CB-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070086#comment-15070086
]
ASF GitHub Bot commented on CB-10255:
-
Github user TheBosZ commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r48373738
--- Diff: src/android/SplashScreen.java ---
@@ -255,6 +259,10 @@ public void run() {
}
splashDialog.setContentView(splashImageView);
splashDialog.setCancelable(false);
+if (isForceFullScreen()) {
--- End diff --
I was thinking about the same thing myself. The problem I think is how the
full screen is implemented. The way it's done there is the old-style (pre-4.1)
way and I don't think it hides the navigation bar.
I unfortunately don't have access to a device that old so I didn't want to
cause an error with older phones.
With some experimentation we could probably combine them.
> Add options to hide splashscreen navigation and status bars on Android
> --
>
> Key: CB-10255
> URL: https://issues.apache.org/jira/browse/CB-10255
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin SplashScreen
>Reporter: Sergey Shakhnazarov
> Labels: android
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
