[jira] [Commented] (CB-10284) Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
[
https://issues.apache.org/jira/browse/CB-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091662#comment-15091662
]
Sebastien commented on CB-10284:
Yep but if I still try to run the app using Cordova@5.3.3 (and the *plugins*
and *platforms* were added using Cordova@5.4.1+), I guess it won't work even
with the mentionned patch. In this case maybe a warning would still be needed?
> Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
>
>
> Key: CB-10284
> URL: https://issues.apache.org/jira/browse/CB-10284
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 5.4.0, 5.4.1
> Environment: Mac OS X 10.10.5
>Reporter: Sebastien
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: triaged
>
> Using Cordova CLI 5.3.3, try creating a new project and then adding the
> Android platform and the whitelist plugin (using `$ cordova plugin add
> cordova-plugin-whitelist@1.2.0`). Then open the _plugins/android.json_ file,
> its content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {
> "res/xml/config.xml": {
> "parents": {
> "/*": [
> {
> "xml": " name=\"android-package\"
> value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /> name=\"onload\" value=\"true\" />",
> "count": 1
> }
> ]
> }
> }
> }
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same
> exact thing. The file content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {}
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Notice that `config_munge.files` is empty. This is a major regression as
> plugins using this feature don't work at all sometimes even preventing the
> `deviceready` event to be triggered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10284) Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
[
https://issues.apache.org/jira/browse/CB-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091670#comment-15091670
]
Vladimir Kotikov commented on CB-10284:
---
Ah, yes. In this case the app will be broken. The patch only fixes the
migration from 5.3.3 to 5.4.0, assuming that you use one version of CLI for
current project.
> Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
>
>
> Key: CB-10284
> URL: https://issues.apache.org/jira/browse/CB-10284
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 5.4.0, 5.4.1
> Environment: Mac OS X 10.10.5
>Reporter: Sebastien
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: triaged
>
> Using Cordova CLI 5.3.3, try creating a new project and then adding the
> Android platform and the whitelist plugin (using `$ cordova plugin add
> cordova-plugin-whitelist@1.2.0`). Then open the _plugins/android.json_ file,
> its content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {
> "res/xml/config.xml": {
> "parents": {
> "/*": [
> {
> "xml": " name=\"android-package\"
> value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /> name=\"onload\" value=\"true\" />",
> "count": 1
> }
> ]
> }
> }
> }
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same
> exact thing. The file content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {}
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Notice that `config_munge.files` is empty. This is a major regression as
> plugins using this feature don't work at all sometimes even preventing the
> `deviceready` event to be triggered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10284) Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
[
https://issues.apache.org/jira/browse/CB-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091658#comment-15091658
]
Vladimir Kotikov commented on CB-10284:
---
[~SebastienP], thanks for details. It looks like you're run into exactly the
same problem as described in CB-9976. The fix has been pulled into master
already in https://github.com/apache/cordova-lib/pull/344 and will be available
in next cordova release, so i hope there is no need for any warnings.
> Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
>
>
> Key: CB-10284
> URL: https://issues.apache.org/jira/browse/CB-10284
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 5.4.0, 5.4.1
> Environment: Mac OS X 10.10.5
>Reporter: Sebastien
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: triaged
>
> Using Cordova CLI 5.3.3, try creating a new project and then adding the
> Android platform and the whitelist plugin (using `$ cordova plugin add
> cordova-plugin-whitelist@1.2.0`). Then open the _plugins/android.json_ file,
> its content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {
> "res/xml/config.xml": {
> "parents": {
> "/*": [
> {
> "xml": " name=\"android-package\"
> value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /> name=\"onload\" value=\"true\" />",
> "count": 1
> }
> ]
> }
> }
> }
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same
> exact thing. The file content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {}
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Notice that `config_munge.files` is empty. This is a major regression as
> plugins using this feature don't work at all sometimes even preventing the
> `deviceready` event to be triggered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10284) Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
[
https://issues.apache.org/jira/browse/CB-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091681#comment-15091681
]
Sebastien commented on CB-10284:
So maybe printing some kind of a warning to the terminal window, if the running
Cordova version is 5.4.0+ and there's a globally installed Cordova 5.3.3-,
could help developers.
> Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
>
>
> Key: CB-10284
> URL: https://issues.apache.org/jira/browse/CB-10284
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 5.4.0, 5.4.1
> Environment: Mac OS X 10.10.5
>Reporter: Sebastien
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: triaged
>
> Using Cordova CLI 5.3.3, try creating a new project and then adding the
> Android platform and the whitelist plugin (using `$ cordova plugin add
> cordova-plugin-whitelist@1.2.0`). Then open the _plugins/android.json_ file,
> its content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {
> "res/xml/config.xml": {
> "parents": {
> "/*": [
> {
> "xml": " name=\"android-package\"
> value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /> name=\"onload\" value=\"true\" />",
> "count": 1
> }
> ]
> }
> }
> }
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same
> exact thing. The file content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {}
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Notice that `config_munge.files` is empty. This is a major regression as
> plugins using this feature don't work at all sometimes even preventing the
> `deviceready` event to be triggered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10284) Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
[
https://issues.apache.org/jira/browse/CB-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092343#comment-15092343
]
Nikhil Khandelwal commented on CB-10284:
>From what I understand, the scenario is to use a new version of Cordova (in
>this case 5.4.x) to create a project, add plugins etc. and in the future use
>older version of Cordova (say 5.3.x) to manipulate it.
I agree the scenario is not supported. To add a warning we will have to update
older versions of Cordova i.e. 5.3.3. Perhaps when we made this breaking change
we should have bumped the major version of the Cordova CLI/lib - however, we
did not do that. Perhaps giving a warning here would be a nice improvement for
the future.
> Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
>
>
> Key: CB-10284
> URL: https://issues.apache.org/jira/browse/CB-10284
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 5.4.0, 5.4.1
> Environment: Mac OS X 10.10.5
>Reporter: Sebastien
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: triaged
>
> Using Cordova CLI 5.3.3, try creating a new project and then adding the
> Android platform and the whitelist plugin (using `$ cordova plugin add
> cordova-plugin-whitelist@1.2.0`). Then open the _plugins/android.json_ file,
> its content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {
> "res/xml/config.xml": {
> "parents": {
> "/*": [
> {
> "xml": " name=\"android-package\"
> value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /> name=\"onload\" value=\"true\" />",
> "count": 1
> }
> ]
> }
> }
> }
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same
> exact thing. The file content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {}
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Notice that `config_munge.files` is empty. This is a major regression as
> plugins using this feature don't work at all sometimes even preventing the
> `deviceready` event to be triggered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10284) Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
[
https://issues.apache.org/jira/browse/CB-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090992#comment-15090992
]
Sebastien commented on CB-10284:
OK so I managed to reproduce the issue.
- I have both Cordova@5.3.3 and Ionic@1.7.12 CLIs globally installed
- I start a new Ionic project like so `$ ionic start cordova-issue`, note that
the project is created using Cordova@5.3.3 this way
- I `$ cd cordova-issue && subl .` and change to content of the project
_package.json_ file to be:
{code:javascript|title="package.json"}
{
"private": true,
"name": "cordova-issue",
"version": "1.0.0",
"scripts": {
"postinstall": "rm -rf platforms plugins && ionic state restore",
"start": "npm install && ionic run android --device"
},
"devDependencies": {
"cordova": "5.4.1",
"ionic": "1.7.12"
},
"cordovaPlugins": [
"cordova-plugin-whitelist@1.2.0"
],
"cordovaPlatforms": [
"android@4.1.1"
]
}
{code}
- I also edit the _www/index.html_ file to add `https://code.jquery.com/jquery-2.2.0.min.js";>` just before
``
- Then I hook up an Android device, run `$ npm install && ionic run android
--device` and use Chome for remote debugging the application
- jQuery failed to load (_Failed to load resource: the server responded with a
status of 404 (Not Found)_) even if `` is present in
_config.xml_
Now I see what I did wrong: my `postinstall` NPM script uses the locally
installed Cordova@5.4.1 CLI to rebuild the _platforms_ and _plugins_
directories but then I run the application using the globally installed
Cordova@5.3.3 CLI so no surprise plugins don't load. If I just run `$ npm
start` everything works as expected using Cordova@5.4.1 all the way through.
My bad!
Maybe some kind of solution here would be to warn the developer that there is a
version mismatch that could lead to issues like this one :)
Thanks
> Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
>
>
> Key: CB-10284
> URL: https://issues.apache.org/jira/browse/CB-10284
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 5.4.0, 5.4.1
> Environment: Mac OS X 10.10.5
>Reporter: Sebastien
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: triaged
>
> Using Cordova CLI 5.3.3, try creating a new project and then adding the
> Android platform and the whitelist plugin (using `$ cordova plugin add
> cordova-plugin-whitelist@1.2.0`). Then open the _plugins/android.json_ file,
> its content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {
> "res/xml/config.xml": {
> "parents": {
> "/*": [
> {
> "xml": " name=\"android-package\"
> value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /> name=\"onload\" value=\"true\" />",
> "count": 1
> }
> ]
> }
> }
> }
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same
> exact thing. The file content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {}
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Notice that `config_munge.files` is empty. This is a major regression as
> plugins using this feature don't work at all sometimes even preventing the
> `deviceready` event to be triggered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10284) Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
[
https://issues.apache.org/jira/browse/CB-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088876#comment-15088876
]
Sebastien commented on CB-10284:
Yep, I think I'll be able to find some time maybe tomorrow or on sunday.
> Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
>
>
> Key: CB-10284
> URL: https://issues.apache.org/jira/browse/CB-10284
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 5.4.0, 5.4.1
> Environment: Mac OS X 10.10.5
>Reporter: Sebastien
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: triaged
>
> Using Cordova CLI 5.3.3, try creating a new project and then adding the
> Android platform and the whitelist plugin (using `$ cordova plugin add
> cordova-plugin-whitelist@1.2.0`). Then open the _plugins/android.json_ file,
> its content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {
> "res/xml/config.xml": {
> "parents": {
> "/*": [
> {
> "xml": " name=\"android-package\"
> value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /> name=\"onload\" value=\"true\" />",
> "count": 1
> }
> ]
> }
> }
> }
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same
> exact thing. The file content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {}
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Notice that `config_munge.files` is empty. This is a major regression as
> plugins using this feature don't work at all sometimes even preventing the
> `deviceready` event to be triggered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10284) Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
[
https://issues.apache.org/jira/browse/CB-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15087740#comment-15087740
]
Nikhil Khandelwal commented on CB-10284:
Reducing the priority. [~Sebastien] We need more info to proceed on this.
> Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
>
>
> Key: CB-10284
> URL: https://issues.apache.org/jira/browse/CB-10284
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 5.4.0, 5.4.1
> Environment: Mac OS X 10.10.5
>Reporter: Sebastien
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: triaged
>
> Using Cordova CLI 5.3.3, try creating a new project and then adding the
> Android platform and the whitelist plugin (using `$ cordova plugin add
> cordova-plugin-whitelist@1.2.0`). Then open the _plugins/android.json_ file,
> its content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {
> "res/xml/config.xml": {
> "parents": {
> "/*": [
> {
> "xml": " name=\"android-package\"
> value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /> name=\"onload\" value=\"true\" />",
> "count": 1
> }
> ]
> }
> }
> }
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same
> exact thing. The file content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {}
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Notice that `config_munge.files` is empty. This is a major regression as
> plugins using this feature don't work at all sometimes even preventing the
> `deviceready` event to be triggered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10284) Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
[
https://issues.apache.org/jira/browse/CB-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085212#comment-15085212
]
Vladimir Kotikov commented on CB-10284:
---
This is not a bug but expected behaviour.
Since the PlatformApi refactoring the location for this file has changed. The
correct version of this file is now being kept in
{{platforms//.json}}, i.e. in your case in
{{platforms/android/android.json}}. This was made because the platforms now do
not depend on CLI/Plugman in terms of plugin installation, and hence need to
store related information (already installed plugins, config munge, etc.)
inside of platform folder. The old file is still exists though, because CLI
still need to persist installed plugins names and dependencies information.
Please also see CB-9976 for more context
> Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
>
>
> Key: CB-10284
> URL: https://issues.apache.org/jira/browse/CB-10284
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 5.4.0, 5.4.1
> Environment: Mac OS X 10.10.5
>Reporter: Sebastien
>Assignee: Vladimir Kotikov
>Priority: Blocker
> Labels: patch
>
> Using Cordova CLI 5.3.3, try creating a new project and then adding the
> Android platform and the whitelist plugin (using `$ cordova plugin add
> cordova-plugin-whitelist@1.2.0`). Then open the _plugins/android.json_ file,
> its content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {
> "res/xml/config.xml": {
> "parents": {
> "/*": [
> {
> "xml": " name=\"android-package\"
> value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /> name=\"onload\" value=\"true\" />",
> "count": 1
> }
> ]
> }
> }
> }
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same
> exact thing. The file content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {}
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Notice that `config_munge.files` is empty. This is a major regression as
> plugins using this feature don't work at all sometimes even preventing the
> `deviceready` event to be triggered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10284) Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
[
https://issues.apache.org/jira/browse/CB-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085266#comment-15085266
]
Sebastien commented on CB-10284:
OK but why is none of my plugins working then using Cordova CLI 5.4.0+?
> Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
>
>
> Key: CB-10284
> URL: https://issues.apache.org/jira/browse/CB-10284
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 5.4.0, 5.4.1
> Environment: Mac OS X 10.10.5
>Reporter: Sebastien
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: triaged
>
> Using Cordova CLI 5.3.3, try creating a new project and then adding the
> Android platform and the whitelist plugin (using `$ cordova plugin add
> cordova-plugin-whitelist@1.2.0`). Then open the _plugins/android.json_ file,
> its content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {
> "res/xml/config.xml": {
> "parents": {
> "/*": [
> {
> "xml": " name=\"android-package\"
> value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /> name=\"onload\" value=\"true\" />",
> "count": 1
> }
> ]
> }
> }
> }
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same
> exact thing. The file content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {}
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Notice that `config_munge.files` is empty. This is a major regression as
> plugins using this feature don't work at all sometimes even preventing the
> `deviceready` event to be triggered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10284) Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
[
https://issues.apache.org/jira/browse/CB-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085299#comment-15085299
]
Sebastien commented on CB-10284:
Use Cordova CLI 5.3.3, add the Android@4.1.1 platform and the
cordova-plugin-whitelist@1.2.0, add in config.xml if not
present, then add an external like Google analytics or whatever to
the index.html file. Now run the app in the simulator/device of your choice.
The external script loads fine.
Use Cordova CLI 5.4.0 or 5.4.1, add the Android@4.1.1 platform and the
cordova-plugin-whitelist@1.2.0, add in config.xml if not
present, then add an external like Google analytics or whatever to
the index.html file. Now run the app in the simulator/device of your choice.
The external script doesn't load.
I think every plugin making use of the `munge` feature now break. Or maybe I'm
missing something?
> Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
>
>
> Key: CB-10284
> URL: https://issues.apache.org/jira/browse/CB-10284
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 5.4.0, 5.4.1
> Environment: Mac OS X 10.10.5
>Reporter: Sebastien
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: triaged
>
> Using Cordova CLI 5.3.3, try creating a new project and then adding the
> Android platform and the whitelist plugin (using `$ cordova plugin add
> cordova-plugin-whitelist@1.2.0`). Then open the _plugins/android.json_ file,
> its content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {
> "res/xml/config.xml": {
> "parents": {
> "/*": [
> {
> "xml": " name=\"android-package\"
> value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /> name=\"onload\" value=\"true\" />",
> "count": 1
> }
> ]
> }
> }
> }
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same
> exact thing. The file content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {}
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Notice that `config_munge.files` is empty. This is a major regression as
> plugins using this feature don't work at all sometimes even preventing the
> `deviceready` event to be triggered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10284) Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
[
https://issues.apache.org/jira/browse/CB-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085330#comment-15085330
]
Sebastien commented on CB-10284:
I originally assumed that it was related to _plugins/android.json_ because I
didn't know about the new file location. But the problem remains though.
> Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
>
>
> Key: CB-10284
> URL: https://issues.apache.org/jira/browse/CB-10284
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 5.4.0, 5.4.1
> Environment: Mac OS X 10.10.5
>Reporter: Sebastien
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: triaged
>
> Using Cordova CLI 5.3.3, try creating a new project and then adding the
> Android platform and the whitelist plugin (using `$ cordova plugin add
> cordova-plugin-whitelist@1.2.0`). Then open the _plugins/android.json_ file,
> its content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {
> "res/xml/config.xml": {
> "parents": {
> "/*": [
> {
> "xml": " name=\"android-package\"
> value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /> name=\"onload\" value=\"true\" />",
> "count": 1
> }
> ]
> }
> }
> }
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same
> exact thing. The file content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {}
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Notice that `config_munge.files` is empty. This is a major regression as
> plugins using this feature don't work at all sometimes even preventing the
> `deviceready` event to be triggered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10284) Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
[
https://issues.apache.org/jira/browse/CB-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085281#comment-15085281
]
Vladimir Kotikov commented on CB-10284:
---
Could you please post a repro steps to get a broken project?
> Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
>
>
> Key: CB-10284
> URL: https://issues.apache.org/jira/browse/CB-10284
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 5.4.0, 5.4.1
> Environment: Mac OS X 10.10.5
>Reporter: Sebastien
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: triaged
>
> Using Cordova CLI 5.3.3, try creating a new project and then adding the
> Android platform and the whitelist plugin (using `$ cordova plugin add
> cordova-plugin-whitelist@1.2.0`). Then open the _plugins/android.json_ file,
> its content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {
> "res/xml/config.xml": {
> "parents": {
> "/*": [
> {
> "xml": " name=\"android-package\"
> value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /> name=\"onload\" value=\"true\" />",
> "count": 1
> }
> ]
> }
> }
> }
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same
> exact thing. The file content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {}
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Notice that `config_munge.files` is empty. This is a major regression as
> plugins using this feature don't work at all sometimes even preventing the
> `deviceready` event to be triggered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10284) Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
[
https://issues.apache.org/jira/browse/CB-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085513#comment-15085513
]
Vladimir Kotikov commented on CB-10284:
---
Unfortunately, still no repro. Here is my steps:
1. create a new blank application
2. modify www/index.html, add the following script element: {{http://code.jquery.com/jquery-1.11.3.js";
id="jquery">}}
ensure that config.xml has an {{}} tag
3. add platform, plugin and run the app: {{cordova platform add android@4.1.1
&& cordova plugin add cordova-plugin-whitelist@1.2.0 && cordova run android
--device}}
4. attach Chrome inspector to running app to see if the external script was
loaded
I tried this on three cordova versions: 5.3.3, 5.4.0 and current master
version. In all three cases, jquery was loaded successfully and there was no
error messages in console apart from some spam, posted by whitelist plugin.
Regarding ??I think every plugin making use of the `munge` feature now break.
Or maybe I'm missing something??? - To understand if the munge has been applied
properly you can check your application's config.xml after build - in case of
whitelist plugin the following snippet should be added to your
{{platofms/android/res/xml/config.xml}} file:
{code:title=plugin.xml}
{code}
> Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
>
>
> Key: CB-10284
> URL: https://issues.apache.org/jira/browse/CB-10284
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 5.4.0, 5.4.1
> Environment: Mac OS X 10.10.5
>Reporter: Sebastien
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: triaged
>
> Using Cordova CLI 5.3.3, try creating a new project and then adding the
> Android platform and the whitelist plugin (using `$ cordova plugin add
> cordova-plugin-whitelist@1.2.0`). Then open the _plugins/android.json_ file,
> its content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {
> "res/xml/config.xml": {
> "parents": {
> "/*": [
> {
> "xml": " name=\"android-package\"
> value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /> name=\"onload\" value=\"true\" />",
> "count": 1
> }
> ]
> }
> }
> }
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same
> exact thing. The file content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {}
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Notice that `config_munge.files` is empty. This is a major regression as
> plugins using this feature don't work at all sometimes even preventing the
> `deviceready` event to be triggered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10284) Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
[
https://issues.apache.org/jira/browse/CB-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085516#comment-15085516
]
Vladimir Kotikov commented on CB-10284:
---
[~SebastienP], for further investigation could you please post any error
messages, produced by WebView. You can get them from Chrome WebInspector
console.
> Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
>
>
> Key: CB-10284
> URL: https://issues.apache.org/jira/browse/CB-10284
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 5.4.0, 5.4.1
> Environment: Mac OS X 10.10.5
>Reporter: Sebastien
>Assignee: Vladimir Kotikov
>Priority: Minor
> Labels: triaged
>
> Using Cordova CLI 5.3.3, try creating a new project and then adding the
> Android platform and the whitelist plugin (using `$ cordova plugin add
> cordova-plugin-whitelist@1.2.0`). Then open the _plugins/android.json_ file,
> its content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {
> "res/xml/config.xml": {
> "parents": {
> "/*": [
> {
> "xml": " name=\"android-package\"
> value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /> name=\"onload\" value=\"true\" />",
> "count": 1
> }
> ]
> }
> }
> }
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same
> exact thing. The file content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {}
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Notice that `config_munge.files` is empty. This is a major regression as
> plugins using this feature don't work at all sometimes even preventing the
> `deviceready` event to be triggered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10284) Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
[
https://issues.apache.org/jira/browse/CB-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084069#comment-15084069
]
Nikhil Khandelwal commented on CB-10284:
[~vladimir.kotikov] Can you take a look at this one?
> Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
>
>
> Key: CB-10284
> URL: https://issues.apache.org/jira/browse/CB-10284
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 5.4.0, 5.4.1
> Environment: Mac OS X 10.10.5
>Reporter: Sebastien
>Assignee: Vladimir Kotikov
>Priority: Blocker
> Labels: patch
>
> Using Cordova CLI 5.3.3, try creating a new project and then adding the
> Android platform and the whitelist plugin (using `$ cordova plugin add
> cordova-plugin-whitelist@1.2.0`). Then open the _plugins/android.json_ file,
> its content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {
> "res/xml/config.xml": {
> "parents": {
> "/*": [
> {
> "xml": " name=\"android-package\"
> value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /> name=\"onload\" value=\"true\" />",
> "count": 1
> }
> ]
> }
> }
> }
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same
> exact thing. The file content is:
> {code:javascript|title=plugins/android.json}
> {
> "prepare_queue": {
> "installed": [],
> "uninstalled": []
> },
> "config_munge": {
> "files": {}
> },
> "installed_plugins": {
> "cordova-plugin-whitelist": {
> "PACKAGE_NAME": "com.my-app.dev"
> }
> },
> "dependent_plugins": {}
> }
> {code}
> Notice that `config_munge.files` is empty. This is a major regression as
> plugins using this feature don't work at all sometimes even preventing the
> `deviceready` event to be triggered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
