[jira] [Commented] (CB-10433) Timeout when tests don't run
[
https://issues.apache.org/jira/browse/CB-10433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144907#comment-15144907
]
ASF GitHub Bot commented on CB-10433:
-
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/76#issuecomment-183422034
I updated the error message based on @nikhilkh's feedback. I also pushed
the emulator retry logic to this branch (which was a bad idea) and now I need
to split up this PR. I'm going to merge in the first two commits of this PR if
it looks good and open another for the Android retry stuff. @nikhilkh can you
take a quick look at e6afb23 to see if the error message update is okay?
> Timeout when tests don't run
>
>
> Key: CB-10433
> URL: https://issues.apache.org/jira/browse/CB-10433
> Project: Apache Cordova
> Issue Type: Test
> Components: mobile-spec
>Reporter: Sarangan Rajamanickam
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged, windows-store-8.1, wp8.1
>
> During the Apache CI Build, there are several instances where mobilespec
> tests don't run for whatever reason and the logging message we see is
> misleading, we should fix it.
> Some of the links are:
> 1. https://ci.apache.org/builders/cordova-ios/builds/1534
> 2. https://ci.apache.org/builders/cordova-ios/builds/1543
> 3. https://ci.apache.org/builders/cordova-ios/builds/1553
> 4. https://ci.apache.org/builders/cordova-ios/builds/1570
> 5. https://ci.apache.org/builders/cordova-windows-phone8.1/builds/1402
> Noticed this error majority of the times in iOS. But, today (01/25) happened
> in WP8.1 also.
> ==
> Content for logs:
> .query failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> .query failed for mobilespec_results { [Error: connect ETIMEDOUT]
> code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> .query failed for
> mobilespec_results { [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno:
> 'ETIMEDOUT', syscall: 'connect' }
> .query failed for mobilespec_results {
> [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall:
> 'connect' }
> query
> failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10433) Timeout when tests don't run
[
https://issues.apache.org/jira/browse/CB-10433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144970#comment-15144970
]
ASF GitHub Bot commented on CB-10433:
-
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-medic/pull/76#issuecomment-183432634
LGTM
> Timeout when tests don't run
>
>
> Key: CB-10433
> URL: https://issues.apache.org/jira/browse/CB-10433
> Project: Apache Cordova
> Issue Type: Test
> Components: mobile-spec
>Reporter: Sarangan Rajamanickam
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged, windows-store-8.1, wp8.1
>
> During the Apache CI Build, there are several instances where mobilespec
> tests don't run for whatever reason and the logging message we see is
> misleading, we should fix it.
> Some of the links are:
> 1. https://ci.apache.org/builders/cordova-ios/builds/1534
> 2. https://ci.apache.org/builders/cordova-ios/builds/1543
> 3. https://ci.apache.org/builders/cordova-ios/builds/1553
> 4. https://ci.apache.org/builders/cordova-ios/builds/1570
> 5. https://ci.apache.org/builders/cordova-windows-phone8.1/builds/1402
> Noticed this error majority of the times in iOS. But, today (01/25) happened
> in WP8.1 also.
> ==
> Content for logs:
> .query failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> .query failed for mobilespec_results { [Error: connect ETIMEDOUT]
> code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> .query failed for
> mobilespec_results { [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno:
> 'ETIMEDOUT', syscall: 'connect' }
> .query failed for mobilespec_results {
> [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall:
> 'connect' }
> query
> failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10433) Timeout when tests don't run
[
https://issues.apache.org/jira/browse/CB-10433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145052#comment-15145052
]
ASF GitHub Bot commented on CB-10433:
-
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/76
> Timeout when tests don't run
>
>
> Key: CB-10433
> URL: https://issues.apache.org/jira/browse/CB-10433
> Project: Apache Cordova
> Issue Type: Test
> Components: mobile-spec
>Reporter: Sarangan Rajamanickam
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged, windows-store-8.1, wp8.1
>
> During the Apache CI Build, there are several instances where mobilespec
> tests don't run for whatever reason and the logging message we see is
> misleading, we should fix it.
> Some of the links are:
> 1. https://ci.apache.org/builders/cordova-ios/builds/1534
> 2. https://ci.apache.org/builders/cordova-ios/builds/1543
> 3. https://ci.apache.org/builders/cordova-ios/builds/1553
> 4. https://ci.apache.org/builders/cordova-ios/builds/1570
> 5. https://ci.apache.org/builders/cordova-windows-phone8.1/builds/1402
> Noticed this error majority of the times in iOS. But, today (01/25) happened
> in WP8.1 also.
> ==
> Content for logs:
> .query failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> .query failed for mobilespec_results { [Error: connect ETIMEDOUT]
> code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> .query failed for
> mobilespec_results { [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno:
> 'ETIMEDOUT', syscall: 'connect' }
> .query failed for mobilespec_results {
> [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall:
> 'connect' }
> query
> failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10433) Timeout when tests don't run
[
https://issues.apache.org/jira/browse/CB-10433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145051#comment-15145051
]
ASF subversion and git services commented on CB-10433:
--
Commit 94554b93afb6721da6051bee520ea9fce72c0b3c in cordova-medic's branch
refs/heads/master from riknoll
[ https://git-wip-us.apache.org/repos/asf?p=cordova-medic.git;h=94554b9 ]
CB-10433: Removing the ETIMEDOUT errors in medic-run. This closes #76
Also clarifying that no mobilespec results probably means crash
> Timeout when tests don't run
>
>
> Key: CB-10433
> URL: https://issues.apache.org/jira/browse/CB-10433
> Project: Apache Cordova
> Issue Type: Test
> Components: mobile-spec
>Reporter: Sarangan Rajamanickam
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged, windows-store-8.1, wp8.1
>
> During the Apache CI Build, there are several instances where mobilespec
> tests don't run for whatever reason and the logging message we see is
> misleading, we should fix it.
> Some of the links are:
> 1. https://ci.apache.org/builders/cordova-ios/builds/1534
> 2. https://ci.apache.org/builders/cordova-ios/builds/1543
> 3. https://ci.apache.org/builders/cordova-ios/builds/1553
> 4. https://ci.apache.org/builders/cordova-ios/builds/1570
> 5. https://ci.apache.org/builders/cordova-windows-phone8.1/builds/1402
> Noticed this error majority of the times in iOS. But, today (01/25) happened
> in WP8.1 also.
> ==
> Content for logs:
> .query failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> .query failed for mobilespec_results { [Error: connect ETIMEDOUT]
> code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> .query failed for
> mobilespec_results { [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno:
> 'ETIMEDOUT', syscall: 'connect' }
> .query failed for mobilespec_results {
> [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall:
> 'connect' }
> query
> failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10433) Timeout when tests don't run
[
https://issues.apache.org/jira/browse/CB-10433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145660#comment-15145660
]
ASF GitHub Bot commented on CB-10433:
-
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/76#discussion_r52818827
--- Diff: medic/medic-run.js ---
@@ -404,26 +459,51 @@ function main() {
}
// run the code
-// NOTE:
-// this is ASYNCHRONOUS
util.medicLog("running:");
util.medicLog("" + runCommandDevice);
-shelljs.exec(runCommandDevice, {silent: false, async: true},
function (returnCode, output) {
-if (failedBecauseNoDevice(output)) {
-util.medicLog("no device found, so switching to emulator");
+var runDeviceResult = shelljs.exec(runCommandDevice, {silent:
false, async: false});
+
+if (failedBecauseNoDevice(runDeviceResult.output)) {
+util.medicLog("no device found, so switching to emulator");
+
+// Because the Android emulator script uses promises, we need
to
+// abstract the run step into a function
+var runOnEmulator = function() {
util.medicLog("running:");
util.medicLog("" + runCommandEmulator);
-shelljs.exec(runCommandEmulator, {silent: false, async:
true}, function (returnCode, output) {
-if (cordovaReturnedError(returnCode, output)) {
-util.fatal("running on emulator failed");
+
+var runEmulatorResult = shelljs.exec(runCommandEmulator,
{silent: false, async: false});
+if (cordovaReturnedError(runEmulatorResult.code,
runEmulatorResult.output)) {
+util.fatal("running on emulator failed");
+} else {
+startPollingForTestResults(couchdbURI, buildId,
timeout);
+}
+};
+
+if (platform === util.ANDROID) {
+// We need to start the emulator first. We can't use
"cordova run"
--- End diff --
Nitpick: please add a blank line before comments.
> Timeout when tests don't run
>
>
> Key: CB-10433
> URL: https://issues.apache.org/jira/browse/CB-10433
> Project: Apache Cordova
> Issue Type: Test
> Components: mobile-spec
>Reporter: Sarangan Rajamanickam
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged, windows-store-8.1, wp8.1
>
> During the Apache CI Build, there are several instances where mobilespec
> tests don't run for whatever reason and the logging message we see is
> misleading, we should fix it.
> Some of the links are:
> 1. https://ci.apache.org/builders/cordova-ios/builds/1534
> 2. https://ci.apache.org/builders/cordova-ios/builds/1543
> 3. https://ci.apache.org/builders/cordova-ios/builds/1553
> 4. https://ci.apache.org/builders/cordova-ios/builds/1570
> 5. https://ci.apache.org/builders/cordova-windows-phone8.1/builds/1402
> Noticed this error majority of the times in iOS. But, today (01/25) happened
> in WP8.1 also.
> ==
> Content for logs:
> .query failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> .query failed for mobilespec_results { [Error: connect ETIMEDOUT]
> code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> .query failed for
> mobilespec_results { [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno:
> 'ETIMEDOUT', syscall: 'connect' }
> .query failed for mobilespec_results {
> [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall:
> 'connect' }
> query
> failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10433) Timeout when tests don't run
[
https://issues.apache.org/jira/browse/CB-10433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139928#comment-15139928
]
ASF GitHub Bot commented on CB-10433:
-
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/76#discussion_r52387149
--- Diff: medic/medic-run.js ---
@@ -372,13 +372,13 @@ function main() {
// timeout needs to be in milliseconds, but it's
// given in seconds, so we multiply by 1000
testwait.init(couchdbURI);
-testwait.waitTestsCompleted(buildId, timeout * 1000).then(
+testwait.waitTestsCompleted(buildId, timeout * 1000, false).then(
function onFulfilled(value) {
-util.medicLog("got test results");
+util.medicLog("Successfully found test results");
process.exit(0);
},
function onRejected(error) {
-console.error("didn't get test results: " + error);
+console.error("Could not find test results: " + error);
--- End diff --
It will be great to suggest that a failure indicates a crashed app.
Checking platform specific logs for crash reason is a good idea.
> Timeout when tests don't run
>
>
> Key: CB-10433
> URL: https://issues.apache.org/jira/browse/CB-10433
> Project: Apache Cordova
> Issue Type: Test
> Components: mobile-spec
>Reporter: Sarangan Rajamanickam
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged, windows-store-8.1, wp8.1
>
> During the Apache CI Build, there are several instances where mobilespec
> tests don't run for whatever reason and the logging message we see is
> misleading, we should fix it.
> Some of the links are:
> 1. https://ci.apache.org/builders/cordova-ios/builds/1534
> 2. https://ci.apache.org/builders/cordova-ios/builds/1543
> 3. https://ci.apache.org/builders/cordova-ios/builds/1553
> 4. https://ci.apache.org/builders/cordova-ios/builds/1570
> 5. https://ci.apache.org/builders/cordova-windows-phone8.1/builds/1402
> Noticed this error majority of the times in iOS. But, today (01/25) happened
> in WP8.1 also.
> ==
> Content for logs:
> .query failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> .query failed for mobilespec_results { [Error: connect ETIMEDOUT]
> code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> .query failed for
> mobilespec_results { [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno:
> 'ETIMEDOUT', syscall: 'connect' }
> .query failed for mobilespec_results {
> [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall:
> 'connect' }
> query
> failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10433) Timeout when tests don't run
[
https://issues.apache.org/jira/browse/CB-10433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139866#comment-15139866
]
ASF GitHub Bot commented on CB-10433:
-
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-medic/pull/76
CB-10433: Removing the ETIMEDOUT errors in medic-run
Occasionally, requests to couchdb fail for mysterious reasons when
medic-run does its polling for mobilespec results. These were being reported a
lot as the cause of CI issues, but in fact they are not. Only a few requests
fail out of multiple poll attempts and sometimes these messages show up in
successful runs. This removes the annoying ETIMEDOUT messages and replaces them
with brief stats at the end of the polling.
@dblotsky @nikhilkh @rakatyal please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-medic CB-10433
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-medic/pull/76.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #76
> Timeout when tests don't run
>
>
> Key: CB-10433
> URL: https://issues.apache.org/jira/browse/CB-10433
> Project: Apache Cordova
> Issue Type: Test
> Components: mobile-spec
>Reporter: Sarangan Rajamanickam
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged, windows-store-8.1, wp8.1
>
> During the Apache CI Build, there are several instances where mobilespec
> tests don't run for whatever reason and the logging message we see is
> misleading, we should fix it.
> Some of the links are:
> 1. https://ci.apache.org/builders/cordova-ios/builds/1534
> 2. https://ci.apache.org/builders/cordova-ios/builds/1543
> 3. https://ci.apache.org/builders/cordova-ios/builds/1553
> 4. https://ci.apache.org/builders/cordova-ios/builds/1570
> 5. https://ci.apache.org/builders/cordova-windows-phone8.1/builds/1402
> Noticed this error majority of the times in iOS. But, today (01/25) happened
> in WP8.1 also.
> ==
> Content for logs:
> .query failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> .query failed for mobilespec_results { [Error: connect ETIMEDOUT]
> code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> .query failed for
> mobilespec_results { [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno:
> 'ETIMEDOUT', syscall: 'connect' }
> .query failed for mobilespec_results {
> [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall:
> 'connect' }
> query
> failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10433) Timeout when tests don't run
[
https://issues.apache.org/jira/browse/CB-10433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139943#comment-15139943
]
ASF GitHub Bot commented on CB-10433:
-
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/76#issuecomment-182121613
LGTM.
> Timeout when tests don't run
>
>
> Key: CB-10433
> URL: https://issues.apache.org/jira/browse/CB-10433
> Project: Apache Cordova
> Issue Type: Test
> Components: mobile-spec
>Reporter: Sarangan Rajamanickam
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged, windows-store-8.1, wp8.1
>
> During the Apache CI Build, there are several instances where mobilespec
> tests don't run for whatever reason and the logging message we see is
> misleading, we should fix it.
> Some of the links are:
> 1. https://ci.apache.org/builders/cordova-ios/builds/1534
> 2. https://ci.apache.org/builders/cordova-ios/builds/1543
> 3. https://ci.apache.org/builders/cordova-ios/builds/1553
> 4. https://ci.apache.org/builders/cordova-ios/builds/1570
> 5. https://ci.apache.org/builders/cordova-windows-phone8.1/builds/1402
> Noticed this error majority of the times in iOS. But, today (01/25) happened
> in WP8.1 also.
> ==
> Content for logs:
> .query failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> .query failed for mobilespec_results { [Error: connect ETIMEDOUT]
> code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
> .query failed for
> mobilespec_results { [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno:
> 'ETIMEDOUT', syscall: 'connect' }
> .query failed for mobilespec_results {
> [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall:
> 'connect' }
> query
> failed for mobilespec_results { [Error: connect ETIMEDOUT] code:
> 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
