[jira] [Commented] (CB-10474) Gathering logs fails in cordova-ios CI
[
https://issues.apache.org/jira/browse/CB-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131282#comment-15131282
]
ASF GitHub Bot commented on CB-10474:
-
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-179507278
LGTM.
> Gathering logs fails in cordova-ios CI
> --
>
> Key: CB-10474
> URL: https://issues.apache.org/jira/browse/CB-10474
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic
> Environment: OSX
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged
>
> In the cordova-ios Build Bot CI, the gathering logs step always fails. It
> tries to {{cat}} a file for the log that does not exist. Here is an example
> build:
> https://ci.apache.org/builders/cordova-ios/builds/1607/steps/gathering-logs/logs/stdio
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10474) Gathering logs fails in cordova-ios CI
[
https://issues.apache.org/jira/browse/CB-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131663#comment-15131663
]
ASF subversion and git services commented on CB-10474:
--
Commit 50d20dca3173fd658c09b104c086b81c4ef64163 in cordova-medic's branch
refs/heads/master from Richard Knoll
[ https://git-wip-us.apache.org/repos/asf?p=cordova-medic.git;h=50d20dc ]
CB-10474: Fix medic-log behavior for cordova-ios. Adding --app flag to
medic-log for iOS. This closes #73.
> Gathering logs fails in cordova-ios CI
> --
>
> Key: CB-10474
> URL: https://issues.apache.org/jira/browse/CB-10474
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic
> Environment: OSX
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged
>
> In the cordova-ios Build Bot CI, the gathering logs step always fails. It
> tries to {{cat}} a file for the log that does not exist. Here is an example
> build:
> https://ci.apache.org/builders/cordova-ios/builds/1607/steps/gathering-logs/logs/stdio
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10474) Gathering logs fails in cordova-ios CI
[
https://issues.apache.org/jira/browse/CB-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131664#comment-15131664
]
ASF GitHub Bot commented on CB-10474:
-
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/73
> Gathering logs fails in cordova-ios CI
> --
>
> Key: CB-10474
> URL: https://issues.apache.org/jira/browse/CB-10474
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic
> Environment: OSX
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged
>
> In the cordova-ios Build Bot CI, the gathering logs step always fails. It
> tries to {{cat}} a file for the log that does not exist. Here is an example
> build:
> https://ci.apache.org/builders/cordova-ios/builds/1607/steps/gathering-logs/logs/stdio
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10474) Gathering logs fails in cordova-ios CI
[
https://issues.apache.org/jira/browse/CB-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128951#comment-15128951
]
ASF GitHub Bot commented on CB-10474:
-
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178801188
@dblotsky I don't think there is an easy way to get the running simulator,
so instead I am going to move the simulator choosing logic from `cordova run`
to medic and pass the `--target` flag. I'll probably just do the same thing as
above, which is choosing the last iPhone that appears in the list of devices.
They list in order (with newest devices appearing at the bottom), so this
method will end up choosing iPhone-6s-plus for now. I'll copy the same function
in medic-run.js and medic-log.js to ensure they choose the same thing. Is that
alright with you? It works for CI, but it will fail on a user's machine if they
manually started another simulator (which shouldn't be a big deal, won't come
up on buildbot).
> Gathering logs fails in cordova-ios CI
> --
>
> Key: CB-10474
> URL: https://issues.apache.org/jira/browse/CB-10474
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic
> Environment: OSX
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged
>
> In the cordova-ios Build Bot CI, the gathering logs step always fails. It
> tries to {{cat}} a file for the log that does not exist. Here is an example
> build:
> https://ci.apache.org/builders/cordova-ios/builds/1607/steps/gathering-logs/logs/stdio
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10474) Gathering logs fails in cordova-ios CI
[
https://issues.apache.org/jira/browse/CB-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129465#comment-15129465
]
ASF GitHub Bot commented on CB-10474:
-
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178919636
Alright I'm going to leave it as is and I'll change it if it becomes an
issue.
> Gathering logs fails in cordova-ios CI
> --
>
> Key: CB-10474
> URL: https://issues.apache.org/jira/browse/CB-10474
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic
> Environment: OSX
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged
>
> In the cordova-ios Build Bot CI, the gathering logs step always fails. It
> tries to {{cat}} a file for the log that does not exist. Here is an example
> build:
> https://ci.apache.org/builders/cordova-ios/builds/1607/steps/gathering-logs/logs/stdio
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10474) Gathering logs fails in cordova-ios CI
[
https://issues.apache.org/jira/browse/CB-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127388#comment-15127388
]
ASF GitHub Bot commented on CB-10474:
-
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178293314
@dblotsky no problem; we need to be in a cordova project for that command
(`cordova run --list`) to work anyway, so I'll just call `pushd` here as well.
Thanks for investigating!
> Gathering logs fails in cordova-ios CI
> --
>
> Key: CB-10474
> URL: https://issues.apache.org/jira/browse/CB-10474
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic
> Environment: OSX
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged
>
> In the cordova-ios Build Bot CI, the gathering logs step always fails. It
> tries to {{cat}} a file for the log that does not exist. Here is an example
> build:
> https://ci.apache.org/builders/cordova-ios/builds/1607/steps/gathering-logs/logs/stdio
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10474) Gathering logs fails in cordova-ios CI
[
https://issues.apache.org/jira/browse/CB-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127468#comment-15127468
]
ASF GitHub Bot commented on CB-10474:
-
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/73#discussion_r51514684
--- Diff: medic/medic-log.js ---
@@ -69,18 +70,72 @@ function logBlackberry() {
return;
}
-function logIOS() {
-var logScriptpath = path.join("mobilespec", "platforms", "ios",
"cordova", "console.log");
-var command = "cat " + logScriptpath;
+function logIOS(appPath) {
+// We need to print out the system log for the simulator app. In order
to figure
+// out the path to that file, we need to find the ID of the simulator
running
+// mobilespec
+
+// First, figure out the simulator that ran mobilespec. "cordova run""
just chooses
+// the last simulator in this list that starts with the word "iPhone"
+shelljs.pushd(appPath);
+
+var findSimCommand = getLocalCLI() + " run --list --emulator | grep
^iPhone | tail -n1";
--- End diff --
The `grep` and `tail` calls won't work on the Windows build machines. Is it
a long task to do this in JS? If it's much more difficult, we can just add some
steps to install Unix tools on Windows for our build machine docs.
> Gathering logs fails in cordova-ios CI
> --
>
> Key: CB-10474
> URL: https://issues.apache.org/jira/browse/CB-10474
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic
> Environment: OSX
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged
>
> In the cordova-ios Build Bot CI, the gathering logs step always fails. It
> tries to {{cat}} a file for the log that does not exist. Here is an example
> build:
> https://ci.apache.org/builders/cordova-ios/builds/1607/steps/gathering-logs/logs/stdio
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10474) Gathering logs fails in cordova-ios CI
[
https://issues.apache.org/jira/browse/CB-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127461#comment-15127461
]
ASF GitHub Bot commented on CB-10474:
-
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178318882
I tried this on my machine and I ran into an issue where it couldn't find
the deployed simulator because there were other non-deployed simulators
installed. Is there a way to filter by running emulators? If now, we can still
work around this by ensuring that there are no more than one simulators
installed on the build machine.
> Gathering logs fails in cordova-ios CI
> --
>
> Key: CB-10474
> URL: https://issues.apache.org/jira/browse/CB-10474
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic
> Environment: OSX
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged
>
> In the cordova-ios Build Bot CI, the gathering logs step always fails. It
> tries to {{cat}} a file for the log that does not exist. Here is an example
> build:
> https://ci.apache.org/builders/cordova-ios/builds/1607/steps/gathering-logs/logs/stdio
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10474) Gathering logs fails in cordova-ios CI
[
https://issues.apache.org/jira/browse/CB-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127296#comment-15127296
]
ASF GitHub Bot commented on CB-10474:
-
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178267393
@riknoll: The value returned by `getLocalCLI()` is used after
`shell.pushd()` is called [here][pushd] to get into the `mobilespec` app
directory in `medic-run`, and in `medic-log` this does not happen. Sorry, this
is was a result of my unclear coding.
[pushd]:
https://github.com/apache/cordova-medic/blob/master/medic/medic-run.js#L389
> Gathering logs fails in cordova-ios CI
> --
>
> Key: CB-10474
> URL: https://issues.apache.org/jira/browse/CB-10474
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic
> Environment: OSX
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged
>
> In the cordova-ios Build Bot CI, the gathering logs step always fails. It
> tries to {{cat}} a file for the log that does not exist. Here is an example
> build:
> https://ci.apache.org/builders/cordova-ios/builds/1607/steps/gathering-logs/logs/stdio
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10474) Gathering logs fails in cordova-ios CI
[
https://issues.apache.org/jira/browse/CB-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127477#comment-15127477
]
ASF GitHub Bot commented on CB-10474:
-
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/73#discussion_r51514920
--- Diff: medic/medic-log.js ---
@@ -69,18 +70,72 @@ function logBlackberry() {
return;
}
-function logIOS() {
-var logScriptpath = path.join("mobilespec", "platforms", "ios",
"cordova", "console.log");
-var command = "cat " + logScriptpath;
+function logIOS(appPath) {
+// We need to print out the system log for the simulator app. In order
to figure
+// out the path to that file, we need to find the ID of the simulator
running
+// mobilespec
+
+// First, figure out the simulator that ran mobilespec. "cordova run""
just chooses
+// the last simulator in this list that starts with the word "iPhone"
+shelljs.pushd(appPath);
+
+var findSimCommand = getLocalCLI() + " run --list --emulator | grep
^iPhone | tail -n1";
--- End diff --
I don't think any part of this will work on Windows. Every command is
either Unix or OSX specific.
> Gathering logs fails in cordova-ios CI
> --
>
> Key: CB-10474
> URL: https://issues.apache.org/jira/browse/CB-10474
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic
> Environment: OSX
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged
>
> In the cordova-ios Build Bot CI, the gathering logs step always fails. It
> tries to {{cat}} a file for the log that does not exist. Here is an example
> build:
> https://ci.apache.org/builders/cordova-ios/builds/1607/steps/gathering-logs/logs/stdio
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10474) Gathering logs fails in cordova-ios CI
[
https://issues.apache.org/jira/browse/CB-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127478#comment-15127478
]
ASF GitHub Bot commented on CB-10474:
-
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/73#discussion_r51514960
--- Diff: medic/medic-log.js ---
@@ -69,18 +70,72 @@ function logBlackberry() {
return;
}
-function logIOS() {
-var logScriptpath = path.join("mobilespec", "platforms", "ios",
"cordova", "console.log");
-var command = "cat " + logScriptpath;
+function logIOS(appPath) {
+// We need to print out the system log for the simulator app. In order
to figure
+// out the path to that file, we need to find the ID of the simulator
running
+// mobilespec
+
+// First, figure out the simulator that ran mobilespec. "cordova run""
just chooses
+// the last simulator in this list that starts with the word "iPhone"
+shelljs.pushd(appPath);
+
+var findSimCommand = getLocalCLI() + " run --list --emulator | grep
^iPhone | tail -n1";
--- End diff --
Why would the Windows build machines run this? It's iOS
> Gathering logs fails in cordova-ios CI
> --
>
> Key: CB-10474
> URL: https://issues.apache.org/jira/browse/CB-10474
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic
> Environment: OSX
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged
>
> In the cordova-ios Build Bot CI, the gathering logs step always fails. It
> tries to {{cat}} a file for the log that does not exist. Here is an example
> build:
> https://ci.apache.org/builders/cordova-ios/builds/1607/steps/gathering-logs/logs/stdio
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10474) Gathering logs fails in cordova-ios CI
[
https://issues.apache.org/jira/browse/CB-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127544#comment-15127544
]
ASF GitHub Bot commented on CB-10474:
-
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178333571
@dblotsky I'm not sure; I copied `cordova run's logic for choosing the
emulator. This does not support choosing a specific simulator, just the
default. I'll look into ios-sim to see if it has any sort of API to get the
running one. Otherwise, we can configure medic to always launch to a
preconfigured simulator (say iPhone 6s) and pass that into `run` and `log` as
flags.
> Gathering logs fails in cordova-ios CI
> --
>
> Key: CB-10474
> URL: https://issues.apache.org/jira/browse/CB-10474
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic
> Environment: OSX
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged
>
> In the cordova-ios Build Bot CI, the gathering logs step always fails. It
> tries to {{cat}} a file for the log that does not exist. Here is an example
> build:
> https://ci.apache.org/builders/cordova-ios/builds/1607/steps/gathering-logs/logs/stdio
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10474) Gathering logs fails in cordova-ios CI
[
https://issues.apache.org/jira/browse/CB-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127494#comment-15127494
]
ASF GitHub Bot commented on CB-10474:
-
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/73#discussion_r51515589
--- Diff: medic/medic-log.js ---
@@ -69,18 +70,72 @@ function logBlackberry() {
return;
}
-function logIOS() {
-var logScriptpath = path.join("mobilespec", "platforms", "ios",
"cordova", "console.log");
-var command = "cat " + logScriptpath;
+function logIOS(appPath) {
+// We need to print out the system log for the simulator app. In order
to figure
+// out the path to that file, we need to find the ID of the simulator
running
+// mobilespec
+
+// First, figure out the simulator that ran mobilespec. "cordova run""
just chooses
+// the last simulator in this list that starts with the word "iPhone"
+shelljs.pushd(appPath);
+
+var findSimCommand = getLocalCLI() + " run --list --emulator | grep
^iPhone | tail -n1";
--- End diff --
I only just realised this. Please disregard my comment. :P
> Gathering logs fails in cordova-ios CI
> --
>
> Key: CB-10474
> URL: https://issues.apache.org/jira/browse/CB-10474
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic
> Environment: OSX
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged
>
> In the cordova-ios Build Bot CI, the gathering logs step always fails. It
> tries to {{cat}} a file for the log that does not exist. Here is an example
> build:
> https://ci.apache.org/builders/cordova-ios/builds/1607/steps/gathering-logs/logs/stdio
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10474) Gathering logs fails in cordova-ios CI
[
https://issues.apache.org/jira/browse/CB-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127434#comment-15127434
]
ASF GitHub Bot commented on CB-10474:
-
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-178308453
@dblotsky updated
> Gathering logs fails in cordova-ios CI
> --
>
> Key: CB-10474
> URL: https://issues.apache.org/jira/browse/CB-10474
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic
> Environment: OSX
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged
>
> In the cordova-ios Build Bot CI, the gathering logs step always fails. It
> tries to {{cat}} a file for the log that does not exist. Here is an example
> build:
> https://ci.apache.org/builders/cordova-ios/builds/1607/steps/gathering-logs/logs/stdio
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10474) Gathering logs fails in cordova-ios CI
[
https://issues.apache.org/jira/browse/CB-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124365#comment-15124365
]
ASF GitHub Bot commented on CB-10474:
-
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/73#issuecomment-177000279
@riknoll I think for Android it gets called directly, so we can do the same
for iOS for now maybe.
> Gathering logs fails in cordova-ios CI
> --
>
> Key: CB-10474
> URL: https://issues.apache.org/jira/browse/CB-10474
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic
> Environment: OSX
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
> Labels: found-by-ci, ios, triaged
>
> In the cordova-ios Build Bot CI, the gathering logs step always fails. It
> tries to {{cat}} a file for the log that does not exist. Here is an example
> build:
> https://ci.apache.org/builders/cordova-ios/builds/1607/steps/gathering-logs/logs/stdio
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
