[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431767#comment-15431767
 ] 

ASF GitHub Bot commented on CB-10577:
-

Github user vldmrrr closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/162


> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430763#comment-15430763
 ] 

ASF GitHub Bot commented on CB-10577:
-

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-plugin-file/pull/162
  
@vldmrrr, this issue has been fixed already in #167. Please close this PR


> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288180#comment-15288180
 ] 

ASF GitHub Bot commented on CB-10577:
-

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/162#issuecomment-219921199
  
Cordova CI Build has completed successfully. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file/pull/162/commits/8bf089b48ec73dace1bd077ad57e134a10c0161d)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=windows-slave,platformName=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=windows-slave,platformName=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=windows-slave,platformName=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=windows-slave,platformName=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=windows-slave,platformName=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=windows-slave,platformName=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=windows-slave,platformName=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=windows-slave,platformName=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=windows-slave,platformName=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=windows-slave,platformName=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=windows-slave,platformName=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=mac-slave,platformName=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=mac-slave,platformName=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=mac-slave,platformName=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=mac-slave,platformName=ios/artifact/)
 |
| [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=mac-slave,platformName=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=mac-slave,platformName=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=mac-slave,platformName=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/4//label=mac-slave,platformName=android/artifact/)
 |
 



> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189781#comment-15189781
 ] 

ASF subversion and git services commented on CB-10577:
--

Commit 2132bbf2d8bd1d45f500270b64f348f8ba001b75 in cordova-plugin-file's branch 
refs/heads/master from [~jasongin]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=2132bbf ]

CB-10577: Windows resolveLocalFileSystemURL should omit trailing slash for file


> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189782#comment-15189782
 ] 

ASF subversion and git services commented on CB-10577:
--

Commit f863542a7f8fc70e922c358eb132265b181b51e1 in cordova-plugin-file's branch 
refs/heads/master from [~purplecabbage]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=f863542 ]

Merge branch 'CB-10577a' of https://github.com/jasongin/cordova-plugin-file


> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189783#comment-15189783
 ] 

ASF GitHub Bot commented on CB-10577:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/169


> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189759#comment-15189759
 ] 

ASF GitHub Bot commented on CB-10577:
-

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/169#issuecomment-195004006
  
LGTM. Tested on windows phone 8.1 emulator and Windows 10


> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187536#comment-15187536
 ] 

ASF GitHub Bot commented on CB-10577:
-

GitHub user jasongin opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/169

CB-10577: Windows resolveLocalFileSystemURL should omit trailing slash for 
file

The FileEntry constructor should remove any trailing slash from its path. 
This parallels the existing DirectoryEntry constructor code which adds a 
trailing slash if missing.

This is actually not a Windows-specific fix, but it fixes a file plugin 
test case failure that was observed on Windows after I recently added that test 
case to validate an Android fix. Windows already invokes the correct 
FileEntry/DirEntry constructor based on the actual file/directory status of the 
path, so fixing the trailing slash is all that is needed.

@riknoll or @rakatyal please review

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jasongin/cordova-plugin-file CB-10577a

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/169.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #169


commit 2132bbf2d8bd1d45f500270b64f348f8ba001b75
Author: Jason Ginchereau 
Date:   2016-03-09T17:54:44Z

CB-10577: Windows resolveLocalFileSystemURL should omit trailing slash for 
file




> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186010#comment-15186010
 ] 

ASF subversion and git services commented on CB-10577:
--

Commit 3e09b31fd7530e02a2f70ea3d7b8d53cd99941cc in cordova-plugin-file's branch 
refs/heads/master from [~jasongin]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=3e09b31 ]

CB-10577: Android resolveLocalFileSystemURL should detect directory vs file. 
This closes #167


> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186011#comment-15186011
 ] 

ASF GitHub Bot commented on CB-10577:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/167


> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181396#comment-15181396
 ] 

ASF GitHub Bot commented on CB-10577:
-

Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/167#issuecomment-192543406
  
LGTM.


> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181391#comment-15181391
 ] 

ASF GitHub Bot commented on CB-10577:
-

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/167#issuecomment-192542492
  
LGTM


> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15180639#comment-15180639
 ] 

ASF GitHub Bot commented on CB-10577:
-

GitHub user jasongin opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/167

CB-10577: Android resolveLocalFileSystemURL should detect directory

@rakatyal or @riknoll please review

There were two places in the Android file plugin code that didn't do the 
right thing when resolving a URI whose trailing slash didn't match the 
directory vs file status.

1. In LocalFileSystem.toLocalUri(), the returned path should never have a 
terminating slash if the path does not point to a directory.

2. In FileUtils.resolveLocalFileSystemUri(), resolving a cdvfile:// (aka 
"local") URI now converts to native URI and back to a local URI (making use of 
the change above) in order to force resolution of whether the path points to a 
file or a directory and fix the terminating slash character accordingly. This 
is only done for local URIs, because for native URIs the resolveNativeUri() 
call would already have called toLocalUri() so doing it again would be 
redundant in that case.

I added automated test cases for resolving native URI files and directories 
using mismatched trailing slashes. As for cdvfile:// URIs, we currently only 
have manual test cases for those (at the bottom of tests.js) and they aren't 
very thorough. I manually tested this fix with cdvfile:// URIs.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jasongin/cordova-plugin-file CB-10577

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/167.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #167


commit 89ccaf2d4c3b2ffbdbdc79804238c083ce9f2c30
Author: Jason Ginchereau 
Date:   2016-03-04T20:02:10Z

CB-10577: Android resolveLocalFileSystemURL should detect directory vs file




> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[Jason Ginchereau (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172463#comment-15172463
 ] 

Jason Ginchereau commented on CB-10577:
---

Setting priority to Critical as this is something that really should be fixed 
soon.

> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
>Priority: Critical
>  Labels: android, triaged
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10577) Android plugin file: resolveLocalFileSystemURL produce incorrect value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139741#comment-15139741
 ] 

ASF GitHub Bot commented on CB-10577:
-

GitHub user vldmrrr opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/162

CB-10577 Check if URL points to file or directory.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vldmrrr/cordova-plugin-file CB-10577

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #162


commit 5bccee81923384c2c5c4e4e80026ad5f7027dcff
Author: vladimir 
Date:   2016-02-09T20:54:58Z

Check if URL point to file or directory.




> Android plugin file: resolveLocalFileSystemURL produce incorrect value
> --
>
> Key: CB-10577
> URL: https://issues.apache.org/jira/browse/CB-10577
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: vldm
> Attachments: index.js
>
>
> On android resolveLocalFileSystemURL  sets isDirectory and isFile properties 
> based on argument URL having trailing slash, and not on actual object type. 
> See attached test program, which currently outputs the following:
>  cdvfile://localhost/temporary/tst is file
>  cdvfile://localhost/temporary/tst/ is directory
> Correct output shall be:
>  cdvfile://localhost/temporary/tst is directory
>  cdvfile://localhost/temporary/tst/ is directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org