[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306522#comment-15306522
]
ASF subversion and git services commented on CB-10622:
--
Commit 89b01aa33d9613deb28914d47f7bad424603da45 in cordova-windows's branch
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=89b01aa ]
CB-10622 Fix MRTImage tests failures on Node 6.x
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Vladimir Kotikov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221556#comment-15221556
]
ASF subversion and git services commented on CB-10622:
--
Commit 57df16dd72722590a8181be995914301f0777f46 in cordova-windows's branch
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=57df16d ]
CB-10622 Upgrade cordova-common to work with 'target'-defined icons
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Vladimir Kotikov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221557#comment-15221557
]
ASF subversion and git services commented on CB-10622:
--
Commit 8224a6ea31c628ac2bdccdc43522c532fa66568e in cordova-windows's branch
refs/heads/4.3.x from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=8224a6e ]
CB-10622 Upgrade cordova-common to work with 'target'-defined icons
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Vladimir Kotikov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215572#comment-15215572
]
ASF GitHub Bot commented on CB-10622:
-
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/149
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215571#comment-15215571
]
ASF GitHub Bot commented on CB-10622:
-
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/162
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215570#comment-15215570
]
ASF GitHub Bot commented on CB-10622:
-
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/159
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215569#comment-15215569
]
ASF subversion and git services commented on CB-10622:
--
Commit 10594681c9331f2be9bfd30d54a0c170e36a84f3 in cordova-windows's branch
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=1059468 ]
CB-10622 Support any MRT qualifiers for Windows icons
This closes #159, closes #162, closes #149
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215564#comment-15215564
]
ASF GitHub Bot commented on CB-10622:
-
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/159#issuecomment-202743738
Reviewed and verified on sample config/images :+1:
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206283#comment-15206283
]
ASF GitHub Bot commented on CB-10622:
-
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/162#issuecomment-199794196
@stebi, thanks for your contribution, but the issue has been fixed already
in dependency module. See apache/cordova-lib#392 The fix will be available in
next cordova-windows release
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206009#comment-15206009
]
ASF GitHub Bot commented on CB-10622:
-
GitHub user stebi opened a pull request:
https://github.com/apache/cordova-windows/pull/162
CB-10622 Fix targetsize images being ignored
In the icon tag in config.xml the icon-"target" attribute is not read, so
MRT images are not loaded at all
e.g.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stebi/cordova-windows master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/162.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #162
commit 1ce0435659f4727dd4ce9c07532eea17a892ff9e
Author: Steffen Binas
Date: 2016-03-22T08:45:33Z
CB-10622 Fix targetsize images being ignored
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204446#comment-15204446
]
ASF GitHub Bot commented on CB-10622:
-
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-199339254
@limebreaker, this problem has been fixed in
https://github.com/apache/cordova-lib/pull/392
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201246#comment-15201246
]
ASF GitHub Bot commented on CB-10622:
-
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-windows/pull/159
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202786#comment-15202786
]
ASF GitHub Bot commented on CB-10622:
-
Github user limebreaker commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-198710562
Hello, could it be that the target attr. in:
is actually completely ignored as I always get no img.target in line 360:
var images =
config.getIcons('windows').concat(config.getSplashScreens('windows')); and
therefor always "The following image is skipped due to unsupported size".
It seems that the config.getIcons never parses and adds the target
attribute. The only way to get it work for me is using width & height
attribute. Running win 8.1 cordova 6.0.0 , windows 4.3.1
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201275#comment-15201275
]
ASF GitHub Bot commented on CB-10622:
-
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/159#discussion_r56635687
--- Diff: spec/unit/Prepare.Win10.spec.js ---
@@ -380,3 +383,79 @@ describe('A Windows 10 project should apply the uap:
namespace prefix to certain
expect(testResults.location).toBe('DeviceCapability');
});
});
+
+describe('copyIcons method', function () {
+var copyImages = prepare.__get__('copyImages');
+
+var PROJECT = '/some/path';
+
+function createMockConfig(images) {
+var result = jasmine.createSpyObj('config', ['getIcons',
'getSplashScreens']);
+result.getIcons.andReturn(images);
+result.getSplashScreens.andReturn([]);
+
+return result;
+}
+
+beforeEach(function () {
+spyOn(shell, 'cp');
+});
+
+it('should guess target filename based on icon size', function () {
+var images = [
+{src: 'res/Windows/Square44x44Logo_100.png', width: '44',
height: '44' },
+{src: 'res/Windows/Square44x44Logo_240.png', width: '106',
height: '106' }
+];
+
+var config = createMockConfig(images);
+
+copyImages(config, PROJECT);
+
+expect(shell.cp).toHaveBeenCalledWith('-f',
path.normalize('res/Windows/Square44x44Logo_100.png'), path.join(PROJECT,
'images/Square44x44Logo.scale-100.png'));
+expect(shell.cp).toHaveBeenCalledWith('-f',
path.normalize('res/Windows/Square44x44Logo_240.png'), path.join(PROJECT,
'images/Square44x44Logo.scale-240.png'));
+});
+
+it('should ignore unknown icon sizes and emit a warning', function () {
+var config = createMockConfig([
+{src: 'res/Windows/UnknownImage.png', width: '999', height:
'999' },
+]);
+
+var warnSpy = jasmine.createSpy('warn');
+events.on('warn', warnSpy);
+copyImages(config, PROJECT);
+expect(shell.cp).not.toHaveBeenCalled();
+expect(warnSpy.calls[0].args[0]).toMatch('image is skipped');
+});
+
+describe('when "target" attribute is specified for the image',
function () {
+it('should copy all images with the same base name and extension
to destination dir', function () {
+var matchingFiles = [
+'res/Windows/Square44x44.scale-100.png',
+'res/Windows/Square44x44.targetsize-16.png',
+'res/Windows/Square44x44.scale-150_targetsize-16.png',
+'res/Windows/Square44x44.targetsize-16_scale-200.png',
--- End diff --
From
[doc](https://msdn.microsoft.com/en-us/library/windows/apps/hh965372.aspx) the
syntax is:
> The dotted segment in the file just before the file extension is
considered a token that indicates qualifiers. Multiple qualifiers are separated
by an underscore, and qualifiers are traditionally specified with their name
and value
It's not very clear what happens if the last segment doesn't match any
qualifier or has some incorrect qualifier name/value, so i preferred not to
perform any validation here.
Also i've just checked and it seems that MSBuild already does some basic
validation and emits a warning in this case
```
e:\PROJECTS\Temp\foo
λ cordova build windows
Building project:
e:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Windows.jsproj
Configuration : debug
Platform : anycpu
MakePRI : warning 0xdef00520: Invalid qualifier: DIMENSION-240
[e:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Windows.jsproj]
MakePRI : warning 0xdef00520: Invalid qualifier: SCALE-FOO
[e:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Windows.jsproj]
MakePRI : warning 0xdef00520: Invalid qualifier: SCALE-240_DIMENSION-FOO
[e:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Windows.jsproj]
```
the build succeeds though, and the resultant package contains improperly
named files, so i think we could rely on MSBuild here.
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through t
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201249#comment-15201249
]
ASF GitHub Bot commented on CB-10622:
-
GitHub user vladimir-kotikov reopened a pull request:
https://github.com/apache/cordova-windows/pull/159
CB-10622 Support any MRT qualifiers for Windows icons
JIRA [CB-10622](https://issues.apache.org/jira/browse/CB-10622)
This PR fixes copying MRT images with qualifiers other that `scale-*`
This is an alternative for #149
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-10622
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/159.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #159
commit eecfb1b03e616942cd7ccb38225258daea60f1cf
Author: Vladimir Kotikov
Date: 2016-03-14T12:24:15Z
CB-10622 Support any MRT qualifiers for Windows icons
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195618#comment-15195618
]
ASF GitHub Bot commented on CB-10622:
-
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/159#issuecomment-196917001
Yup - now I understand - we need not need to add to that array.
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195614#comment-15195614
]
ASF GitHub Bot commented on CB-10622:
-
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/159#discussion_r56196972
--- Diff: spec/unit/Prepare.Win10.spec.js ---
@@ -380,3 +383,79 @@ describe('A Windows 10 project should apply the uap:
namespace prefix to certain
expect(testResults.location).toBe('DeviceCapability');
});
});
+
+describe('copyIcons method', function () {
+var copyImages = prepare.__get__('copyImages');
+
+var PROJECT = '/some/path';
+
+function createMockConfig(images) {
+var result = jasmine.createSpyObj('config', ['getIcons',
'getSplashScreens']);
+result.getIcons.andReturn(images);
+result.getSplashScreens.andReturn([]);
+
+return result;
+}
+
+beforeEach(function () {
+spyOn(shell, 'cp');
+});
+
+it('should guess target filename based on icon size', function () {
+var images = [
+{src: 'res/Windows/Square44x44Logo_100.png', width: '44',
height: '44' },
+{src: 'res/Windows/Square44x44Logo_240.png', width: '106',
height: '106' }
+];
+
+var config = createMockConfig(images);
+
+copyImages(config, PROJECT);
+
+expect(shell.cp).toHaveBeenCalledWith('-f',
path.normalize('res/Windows/Square44x44Logo_100.png'), path.join(PROJECT,
'images/Square44x44Logo.scale-100.png'));
+expect(shell.cp).toHaveBeenCalledWith('-f',
path.normalize('res/Windows/Square44x44Logo_240.png'), path.join(PROJECT,
'images/Square44x44Logo.scale-240.png'));
+});
+
+it('should ignore unknown icon sizes and emit a warning', function () {
+var config = createMockConfig([
+{src: 'res/Windows/UnknownImage.png', width: '999', height:
'999' },
+]);
+
+var warnSpy = jasmine.createSpy('warn');
+events.on('warn', warnSpy);
+copyImages(config, PROJECT);
+expect(shell.cp).not.toHaveBeenCalled();
+expect(warnSpy.calls[0].args[0]).toMatch('image is skipped');
+});
+
+describe('when "target" attribute is specified for the image',
function () {
+it('should copy all images with the same base name and extension
to destination dir', function () {
+var matchingFiles = [
+'res/Windows/Square44x44.scale-100.png',
+'res/Windows/Square44x44.targetsize-16.png',
+'res/Windows/Square44x44.scale-150_targetsize-16.png',
+'res/Windows/Square44x44.targetsize-16_scale-200.png',
--- End diff --
Does the qualifier not have to be following a specific syntax for it to
work? Should we validate that?
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195214#comment-15195214
]
ASF GitHub Bot commented on CB-10622:
-
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/159#issuecomment-196800034
@nikhilkh, the items from this array is used only when icon is defined
using `width` and `height`. As we decided to recommend using `target` to define
icons, should we still continue supporting all available scales for
`width`/`height`-defined icons?
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195203#comment-15195203
]
ASF GitHub Bot commented on CB-10622:
-
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-196797804
The PR with documentation: https://github.com/apache/cordova-docs/pull/558
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193708#comment-15193708
]
ASF GitHub Bot commented on CB-10622:
-
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/159#issuecomment-196426787
do we need to add scale 200/400 here:
https://github.com/apache/cordova-windows/pull/159/files#diff-32bff2189ca335a5581636fff314a504R315
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193631#comment-15193631
]
ASF GitHub Bot commented on CB-10622:
-
Github user SunboX commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-196412080
Oh, thanks for the hint! This is great! :smile:
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193396#comment-15193396
]
ASF GitHub Bot commented on CB-10622:
-
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/159
CB-10622 Support any MRT qualifiers for Windows icons
JIRA [CB-10622](https://issues.apache.org/jira/browse/CB-10622)
This PR fixes copying MRT images with qualifiers other that `scale-*`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-10622
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/159.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #159
commit eecfb1b03e616942cd7ccb38225258daea60f1cf
Author: Vladimir Kotikov
Date: 2016-03-14T12:24:15Z
CB-10622 Support any MRT qualifiers for Windows icons
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193061#comment-15193061
]
ASF GitHub Bot commented on CB-10622:
-
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-196243570
This is not yet documented, but we're in process of adding docs and
examples for `target` attribute
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193059#comment-15193059
]
ASF GitHub Bot commented on CB-10622:
-
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-196243378
@SunboX, for adding icons with scale factors other than `scale-100` and
`scale-240` you need to use `target` attribute as following:
```xml
```
instead of adding separate `` tag for each image
```xml
```
When `target` attribute is specified every image that matches regexp
`/Square71x71Logo(\.scale\-\d+)?\.png/` will be copied to application's
`images` directory.
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187252#comment-15187252
]
ASF GitHub Bot commented on CB-10622:
-
Github user SunboX commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-194349294
You should allow scale 200 images for UWP10 apps. The scale 100 images look
a bit blurry on a Lumia 950 and scale 240 is no longer supported:
```js
// Platform default images
var platformImages = [
{dest: 'Square150x150Logo.scale-100.png', width: 150, height: 150},
{dest: 'Square150x150Logo.scale-200.png', width: 300, height: 300},
{dest: 'Square30x30Logo.scale-100.png', width: 30, height: 30},
{dest: 'StoreLogo.scale-100.png', width: 50, height: 50},
{dest: 'SplashScreen.scale-100.png', width: 620, height: 300},
{dest: 'SplashScreen.scale-200.png', width: 1240, height: 600},
// scaled images are specified here for backward compatibility only
so we can find them by size
{dest: 'StoreLogo.scale-240.png', width: 120, height: 120},
{dest: 'Square44x44Logo.scale-100.png', width: 44, height: 44},
{dest: 'Square44x44Logo.scale-200.png', width: 88, height: 88},
{dest: 'Square44x44Logo.scale-240.png', width: 106, height: 106},
{dest: 'Square70x70Logo.scale-100.png', width: 70, height: 70},
{dest: 'Square71x71Logo.scale-100.png', width: 71, height: 71},
{dest: 'Square71x71Logo.scale-200.png', width: 142, height: 142},
{dest: 'Square71x71Logo.scale-240.png', width: 170, height: 170},
{dest: 'Square150x150Logo.scale-240.png', width: 360, height: 360},
{dest: 'Square310x310Logo.scale-100.png', width: 310, height: 310},
{dest: 'Square310x310Logo.scale-200.png', width: 620, height: 620},
{dest: 'Wide310x150Logo.scale-100.png', width: 310, height: 150},
{dest: 'Wide310x150Logo.scale-240.png', width: 744, height: 360},
{dest: 'SplashScreenPhone.scale-240.png', width: 1152, height: 1920}
];
```
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173313#comment-15173313
]
ASF GitHub Bot commented on CB-10622:
-
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/392#issuecomment-190575330
We need to add this to the docs. @andorman - Could you submit a PR to this
page?
https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/config_ref/images.md
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169121#comment-15169121
]
ASF GitHub Bot commented on CB-10622:
-
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/392
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169119#comment-15169119
]
ASF subversion and git services commented on CB-10622:
--
Commit 84d4ea0c04b57e0907a9b68a1e9063792a95817b in cordova-lib's branch
refs/heads/master from [~andor]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=84d4ea0 ]
CB-10622 fix target attribute being ignored for images in config.xml. This
closes #392
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15168999#comment-15168999
]
ASF GitHub Bot commented on CB-10622:
-
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/392#issuecomment-189269844
@andorman, i'll take care of tests. Thanks
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15168937#comment-15168937
]
ASF GitHub Bot commented on CB-10622:
-
Github user andorman commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-189263000
@vladimir-kotikov The supported image types and namings can be found here:
https://msdn.microsoft.com/en-us/library/windows/apps/mt412102.aspx
Either "scale" or "targetsize" should be provided. Though, I see that
"targetsize-*_altform-unplated" images will still be ignored. The regex should
be modified to include those as well.
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15168692#comment-15168692
]
ASF GitHub Bot commented on CB-10622:
-
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/392#issuecomment-189176531
LGTM. @andorman, It'd be great if you could add a couple of tests for this?
@nikhilkh, it looks like `target` attribute for images is not documented in
[Icons and Splash Screens
guide](http://cordova.apache.org/docs/en/latest/config_ref/images.html). Should
this be included into documentation improvements effort?
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15168684#comment-15168684
]
ASF GitHub Bot commented on CB-10622:
-
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-189172760
From what i understand the corresponding JIRA contains two separate issues
and one of them is a regression (see apache/cordova-lib#392), but second one
isn't (the one fixed by this change).
@andorman, what if both `scale` and `targetsize` qualifiers present in
image name? Would image then get copied properly?
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15168203#comment-15168203
]
ASF GitHub Bot commented on CB-10622:
-
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/392#issuecomment-189058742
@vladimir-kotikov to review
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>Assignee: Sergey Grebnov
> Labels: mustfix, triaged
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151404#comment-15151404
]
ASF GitHub Bot commented on CB-10622:
-
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-185457013
I'm curious - is this a recent regression?
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148408#comment-15148408
]
ASF GitHub Bot commented on CB-10622:
-
Github user andorman commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-184611560
@sgrebnov Sorry for screwing up my previous PR, I opened a new one instead.
I hope it's alright this time.
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148403#comment-15148403
]
ASF GitHub Bot commented on CB-10622:
-
GitHub user andorman opened a pull request:
https://github.com/apache/cordova-windows/pull/149
CB-10622 fix targetsize images being ignored
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andorman/cordova-windows master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/149.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #149
commit 1073c6e18729a3690b9d152638f0423826b71a3f
Author: Andor Polgari
Date: 2016-02-16T10:13:42Z
CB-10622 fix targetsize images being ignored
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148404#comment-15148404
]
ASF GitHub Bot commented on CB-10622:
-
GitHub user andorman opened a pull request:
https://github.com/apache/cordova-lib/pull/392
CB-10622 fix target attribute being ignored for images in config.xml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andorman/cordova-lib master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/392.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #392
commit 8b93650c0d5595d79c2a3432097b0f9f4f64b643
Author: Andor Polgari
Date: 2016-02-16T10:17:27Z
CB-10622 fix target attribute being ignored for images in config.xml
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148286#comment-15148286
]
ASF GitHub Bot commented on CB-10622:
-
Github user andorman closed the pull request at:
https://github.com/apache/cordova-windows/pull/148
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148285#comment-15148285
]
ASF GitHub Bot commented on CB-10622:
-
Github user andorman closed the pull request at:
https://github.com/apache/cordova-lib/pull/391
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[
https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148109#comment-15148109
]
ASF GitHub Bot commented on CB-10622:
-
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/148#issuecomment-184521979
Hey @andorman, the PR's source and destination branches are incorrect - you
can see there are many unrelated commits/changes here.
> Windows MRT images are not parsed from config.xml
> -
>
> Key: CB-10622
> URL: https://issues.apache.org/jira/browse/CB-10622
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.0.0
>Reporter: Andor Polgari
>
> MRT images on Windows are not working correctly through the config.xml file.
> "Target" attribute is not parsed from config and not all kind of images are
> recognized ("scale" only, "targetsize" images are ignored)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10622) Windows MRT images are not parsed from config.xml
[ https://issues.apache.org/jira/browse/CB-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147842#comment-15147842 ] ASF GitHub Bot commented on CB-10622: - GitHub user andorman opened a pull request: https://github.com/apache/cordova-windows/pull/148 CB-10622 Fix targetsize images being ignored Only "scale" images were properly recognized, targetsize icons were ignored. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/cordova-windows master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/148.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #148 commit e09485425a68cca4ee3410e265f1810b8c3d0943 Author: Vladimir Kotikov Date: 2016-01-11T11:41:30Z Set VERSION to 4.4.0-dev (via coho) commit 684a1ee4180943ce76cfa6a4295d78aa5fd12477 Author: Vladimir Kotikov Date: 2016-01-11T11:41:42Z Update JS snapshot to version 4.4.0-dev (via coho) commit 1c44ff5e8ab8372d559fd0fcf535615e05bd3c88 Author: Vladimir Kotikov Date: 2016-01-12T10:54:55Z CB-9828 Adds missing semver to bundled dependencies commit 2347f3a75d71ffa1d3e8b95d60af2bb037e38fe7 Author: sgrebnov Date: 2016-01-14T08:04:57Z CB-10356 "npm install" fails for cordova-windows github close #137 commit c1b80be51cdbd90160b6cb8162350bced8e1c44b Author: Alexander Sorokin Date: 2016-01-13T15:48:37Z CB-10344 Fixed icons and splashscreens parsing github close #136 commit 7652e14c31b68916f30f699f7144a809c9e228a3 Author: sgrebnov Date: 2016-01-14T12:13:51Z CB-10234 Better error message when Windows10 requires 'arch' flag github close #138 commit d5079b99bdb0ab5fe7d75ed13853de762e0cf254 Author: Byoungro So Date: 2016-01-18T22:02:40Z CB-10381 fix the bug when removing a plugin with a tag commit 59a23ce16d311d022dbc2c3ad0d9af3493992f9b Author: Vladimir Kotikov Date: 2016-01-11T11:45:23Z CB-10299 Updated RELEASENOTES for release 4.3.0 commit 0977140a2441824d9a77e6a8aeefd29d3a33fe19 Author: Vladimir Kotikov Date: 2016-01-26T10:35:17Z CB-10394 Do not cache manifest file while getting package name commit 35f48b4ea005b92a8b956f313a66ca3beabc82a9 Author: daserge Date: 2016-01-26T08:32:16Z CB-10440 Add CSS color names support for BackgroundColor on Windows commit e1056e1852c33749f0d42d04c5dce0e966c39547 Author: daserge Date: 2016-01-27T19:48:13Z CB-10446 Windows 10 Cordova Application restart instead of resume commit 8e1aa3a023e0b3b4a425c3b865c4d6fa549a578f Author: daserge Date: 2016-01-30T08:29:08Z CB-10487 WindowsStoreIdentityName should be lowercased in Application.StartPage commit 515f51f7e285767360f208c9ecd3ace1ed7c175f Author: Vladimir Kotikov Date: 2016-02-01T09:58:30Z CB-10495 Set VERSION to 4.4.0-dev (via coho) commit 15155e0b790a4af494e11660f820ab1ac67afcef Author: Vladimir Kotikov Date: 2016-02-01T09:58:43Z CB-10495 Update JS snapshot to version 4.4.0-dev (via coho) commit 826670cc51e109ea358eff3dd1d832ecc6762a5c Author: Vladimir Kotikov Date: 2016-02-01T10:12:34Z CB-10495 Updated RELEASENOTES for release 4.3.1 commit d783f2073430492e59d99009b30411fb8e8e897a Author: daserge Date: 2016-02-03T07:52:05Z CB-10480 Remove Windows 8 template from cordova-windows Adds a friendly error message for windows-target-version = 8.0 commit 5f15c5eb0fc07cb3a37aaa2f436d03208b1cb80a Author: daserge Date: 2016-02-03T07:53:28Z CB-10480 Remove Windows 8 template from cordova-windows Updated check_reqs Updated the docs commit 92a298a3189ce8ce9fe6973b49dbdc777835a62b Author: daserge Date: 2016-02-03T07:53:36Z CB-10480 Remove Windows 8 template from cordova-windows Updated the tests commit 1410f3c3d97425369ea32ec6c05c72ac02b39b75 Author: Marco Biasini Date: 2016-02-10T08:11:55Z CB-10326 Don't copy `resource-file` files at plugin install time Instead, reference the file in the plugin directory. This allows to have multiple source files map to the same destination file inside the build directory and choose the appropriate file based on the build configuration, e.g. architecture. Github close #139 > Windows MRT images are not parsed from config.xml > - > > Key: CB-10622 > URL: https://issues.apache.org/jira/browse/CB-10622 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib, Windows >Affects Versions: 6.0.0 >Reporter: Andor Polgari > > MRT images on Windows are not working correctly through the config.xml file. > "Target" attribute is not parsed from config
