[jira] [Commented] (CB-10689) Apostrophe isn't escaped in the name of an application
[ https://issues.apache.org/jira/browse/CB-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696127#comment-15696127 ] Johnathan Skinner commented on CB-10689: I've managed to come up with a work-around by changing the app name to use the unicode right single quote apostrophe ’ instead of the regular apostrophe ' but I'm not sure if this has other consequences... hopefully it'll work until this issues is resolved. > Apostrophe isn't escaped in the name of an application > -- > > Key: CB-10689 > URL: https://issues.apache.org/jira/browse/CB-10689 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Joe Bowser >Priority: Minor > Labels: triaged > > Steps to reproduce: > 1. Create an application with an apostrophe in the name > 2. Add Android > 3. Build App > Expected: > App should build > What happens: > Build errors out with an error containing this line: > platforms/android/build/intermediates/res/merged/debug/values/values.xml:4 : > AAPT: Apostrophe not preceded by \ -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10689) Apostrophe isn't escaped in the name of an application
[ https://issues.apache.org/jira/browse/CB-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696076#comment-15696076 ] Johnathan Skinner commented on CB-10689: This is not fixed! Please re-open and address. I cannot build my project because the name has an apostrophe in it. Please fix soon... I've put far too much work into my app and the branding to have to throw it all away because the compiler can't handle the name I've chosen. Much appreciated, thanks. > Apostrophe isn't escaped in the name of an application > -- > > Key: CB-10689 > URL: https://issues.apache.org/jira/browse/CB-10689 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Joe Bowser >Priority: Minor > Labels: triaged > > Steps to reproduce: > 1. Create an application with an apostrophe in the name > 2. Add Android > 3. Build App > Expected: > App should build > What happens: > Build errors out with an error containing this line: > platforms/android/build/intermediates/res/merged/debug/values/values.xml:4 : > AAPT: Apostrophe not preceded by \ -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10689) Apostrophe isn't escaped in the name of an application
[ https://issues.apache.org/jira/browse/CB-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234602#comment-15234602 ] ASF GitHub Bot commented on CB-10689: - Github user revolunet commented on the pull request: https://github.com/apache/cordova-android/pull/272#issuecomment-208196549 @jfrumar Hi, tried with amperstand, ex "Black & White" in `config.xml/widget/name` and no issue here. can you explain the issue further please ? > Apostrophe isn't escaped in the name of an application > -- > > Key: CB-10689 > URL: https://issues.apache.org/jira/browse/CB-10689 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Joe Bowser >Priority: Minor > Labels: triaged > > Steps to reproduce: > 1. Create an application with an apostrophe in the name > 2. Add Android > 3. Build App > Expected: > App should build > What happens: > Build errors out with an error containing this line: > platforms/android/build/intermediates/res/merged/debug/values/values.xml:4 : > AAPT: Apostrophe not preceded by \ -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10689) Apostrophe isn't escaped in the name of an application
[ https://issues.apache.org/jira/browse/CB-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233639#comment-15233639 ] ASF GitHub Bot commented on CB-10689: - Github user jfrumar commented on the pull request: https://github.com/apache/cordova-android/pull/272#issuecomment-207818513 We also have trouble with app names that include ampersands. Could we include those in the regexp replacement pattern? > Apostrophe isn't escaped in the name of an application > -- > > Key: CB-10689 > URL: https://issues.apache.org/jira/browse/CB-10689 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Joe Bowser >Priority: Minor > Labels: triaged > > Steps to reproduce: > 1. Create an application with an apostrophe in the name > 2. Add Android > 3. Build App > Expected: > App should build > What happens: > Build errors out with an error containing this line: > platforms/android/build/intermediates/res/merged/debug/values/values.xml:4 : > AAPT: Apostrophe not preceded by \ -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10689) Apostrophe isn't escaped in the name of an application
[ https://issues.apache.org/jira/browse/CB-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232978#comment-15232978 ] ASF GitHub Bot commented on CB-10689: - Github user akofman commented on the pull request: https://github.com/apache/cordova-android/pull/272#issuecomment-207612423 Ok perfect ! :+1: > Apostrophe isn't escaped in the name of an application > -- > > Key: CB-10689 > URL: https://issues.apache.org/jira/browse/CB-10689 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Joe Bowser >Priority: Minor > Labels: triaged > > Steps to reproduce: > 1. Create an application with an apostrophe in the name > 2. Add Android > 3. Build App > Expected: > App should build > What happens: > Build errors out with an error containing this line: > platforms/android/build/intermediates/res/merged/debug/values/values.xml:4 : > AAPT: Apostrophe not preceded by \ -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10689) Apostrophe isn't escaped in the name of an application
[ https://issues.apache.org/jira/browse/CB-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232970#comment-15232970 ] ASF GitHub Bot commented on CB-10689: - Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/272#issuecomment-207611395 @akofman After doing some triage, we should probably tweak this for an earlier CB that deals with the same thing. > Apostrophe isn't escaped in the name of an application > -- > > Key: CB-10689 > URL: https://issues.apache.org/jira/browse/CB-10689 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Joe Bowser >Priority: Minor > Labels: triaged > > Steps to reproduce: > 1. Create an application with an apostrophe in the name > 2. Add Android > 3. Build App > Expected: > App should build > What happens: > Build errors out with an error containing this line: > platforms/android/build/intermediates/res/merged/debug/values/values.xml:4 : > AAPT: Apostrophe not preceded by \ -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10689) Apostrophe isn't escaped in the name of an application
[ https://issues.apache.org/jira/browse/CB-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232963#comment-15232963 ] Joe Bowser commented on CB-10689: - That general case is CB-8250 > Apostrophe isn't escaped in the name of an application > -- > > Key: CB-10689 > URL: https://issues.apache.org/jira/browse/CB-10689 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Joe Bowser >Priority: Minor > Labels: triaged > > Steps to reproduce: > 1. Create an application with an apostrophe in the name > 2. Add Android > 3. Build App > Expected: > App should build > What happens: > Build errors out with an error containing this line: > platforms/android/build/intermediates/res/merged/debug/values/values.xml:4 : > AAPT: Apostrophe not preceded by \ -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10689) Apostrophe isn't escaped in the name of an application
[ https://issues.apache.org/jira/browse/CB-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210964#comment-15210964 ] ASF GitHub Bot commented on CB-10689: - Github user akofman commented on the pull request: https://github.com/apache/cordova-android/pull/272#issuecomment-201023548 @infil00p any status about that ? It's a quite annoying issue when you have an app with an apostrophe and having to juggle between ios and android. Thanks ! > Apostrophe isn't escaped in the name of an application > -- > > Key: CB-10689 > URL: https://issues.apache.org/jira/browse/CB-10689 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Joe Bowser >Priority: Minor > Labels: triaged > > Steps to reproduce: > 1. Create an application with an apostrophe in the name > 2. Add Android > 3. Build App > Expected: > App should build > What happens: > Build errors out with an error containing this line: > platforms/android/build/intermediates/res/merged/debug/values/values.xml:4 : > AAPT: Apostrophe not preceded by \ -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10689) Apostrophe isn't escaped in the name of an application
[ https://issues.apache.org/jira/browse/CB-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193237#comment-15193237 ] Julien Bouquillon commented on CB-10689: indeed, fixed thanks :) > Apostrophe isn't escaped in the name of an application > -- > > Key: CB-10689 > URL: https://issues.apache.org/jira/browse/CB-10689 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Joe Bowser >Priority: Minor > Labels: triaged > > Steps to reproduce: > 1. Create an application with an apostrophe in the name > 2. Add Android > 3. Build App > Expected: > App should build > What happens: > Build errors out with an error containing this line: > platforms/android/build/intermediates/res/merged/debug/values/values.xml:4 : > AAPT: Apostrophe not preceded by \ -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10689) Apostrophe isn't escaped in the name of an application
[ https://issues.apache.org/jira/browse/CB-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193225#comment-15193225 ] ASF GitHub Bot commented on CB-10689: - Github user akofman commented on the pull request: https://github.com/apache/cordova-android/pull/272#issuecomment-196298323 I think you should perform a global replacement instead of just the first occurence : `name.replace(/\'/g,'\\\'');` > Apostrophe isn't escaped in the name of an application > -- > > Key: CB-10689 > URL: https://issues.apache.org/jira/browse/CB-10689 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Joe Bowser >Priority: Minor > Labels: triaged > > Steps to reproduce: > 1. Create an application with an apostrophe in the name > 2. Add Android > 3. Build App > Expected: > App should build > What happens: > Build errors out with an error containing this line: > platforms/android/build/intermediates/res/merged/debug/values/values.xml:4 : > AAPT: Apostrophe not preceded by \ -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10689) Apostrophe isn't escaped in the name of an application
[ https://issues.apache.org/jira/browse/CB-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190633#comment-15190633 ] Julien Bouquillon commented on CB-10689: Hi, Bug confirmed and just pushed a fix here : https://github.com/apache/cordova-android/pull/272 > Apostrophe isn't escaped in the name of an application > -- > > Key: CB-10689 > URL: https://issues.apache.org/jira/browse/CB-10689 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Joe Bowser >Priority: Minor > Labels: triaged > > Steps to reproduce: > 1. Create an application with an apostrophe in the name > 2. Add Android > 3. Build App > Expected: > App should build > What happens: > Build errors out with an error containing this line: > platforms/android/build/intermediates/res/merged/debug/values/values.xml:4 : > AAPT: Apostrophe not preceded by \ -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
