[jira] [Commented] (CB-11139) Reuse PluginManager class to add/rm plugins in cordova-windows

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270236#comment-15270236
 ] 

ASF subversion and git services commented on CB-11139:
--

Commit 033956d1f561a0d3321199115d7b556ea6ed7d8e in cordova-windows's branch 
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=033956d ]

CB-11139 Use PluginManager from common to install/uninstall plugins

 This closes #171


> Reuse PluginManager class to add/rm plugins in cordova-windows
> --
>
> Key: CB-11139
> URL: https://issues.apache.org/jira/browse/CB-11139
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Windows
>Affects Versions: 4.4.0
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11139) Reuse PluginManager class to add/rm plugins in cordova-windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270237#comment-15270237
 ] 

ASF GitHub Bot commented on CB-11139:
-

Github user vladimir-kotikov closed the pull request at:

https://github.com/apache/cordova-windows/pull/171


> Reuse PluginManager class to add/rm plugins in cordova-windows
> --
>
> Key: CB-11139
> URL: https://issues.apache.org/jira/browse/CB-11139
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Windows
>Affects Versions: 4.4.0
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11139) Reuse PluginManager class to add/rm plugins in cordova-windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15264837#comment-15264837
 ] 

ASF GitHub Bot commented on CB-11139:
-

Github user jasongin commented on the pull request:

https://github.com/apache/cordova-windows/pull/171#issuecomment-215891369
  
:+1:


> Reuse PluginManager class to add/rm plugins in cordova-windows
> --
>
> Key: CB-11139
> URL: https://issues.apache.org/jira/browse/CB-11139
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Windows
>Affects Versions: 4.4.0
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11139) Reuse PluginManager class to add/rm plugins in cordova-windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262705#comment-15262705
 ] 

ASF GitHub Bot commented on CB-11139:
-

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-windows/pull/171#issuecomment-215523674
  
@jasongin Can you please help review? Related to apache/cordova-android#301


> Reuse PluginManager class to add/rm plugins in cordova-windows
> --
>
> Key: CB-11139
> URL: https://issues.apache.org/jira/browse/CB-11139
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Windows
>Affects Versions: 4.4.0
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11139) Reuse PluginManager class to add/rm plugins in cordova-windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261900#comment-15261900
 ] 

ASF GitHub Bot commented on CB-11139:
-

Github user codecov-io commented on the pull request:

https://github.com/apache/cordova-windows/pull/171#issuecomment-215373720
  
## [Current coverage][cc-pull] is **100%**
> Merging [#171][cc-pull] into [master][cc-base-branch] will not change 
coverage

```diff
@@ master   #171   diff @@
==
  Files14 14  
  Lines  3202   3213+11   
  Methods 339341 +2   
  Messages  0  0  
  Branches451451  
==
+ Hits   3202   3213+11   
  Misses0  0  
  Partials  0  0  
```



> Powered by [Codecov](https://codecov.io?src=pr). Last updated by eed7ebe
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr
[cc-pull]: https://codecov.io/gh/apache/cordova-windows/pull/171?src=pr


> Reuse PluginManager class to add/rm plugins in cordova-windows
> --
>
> Key: CB-11139
> URL: https://issues.apache.org/jira/browse/CB-11139
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Windows
>Affects Versions: 4.4.0
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11139) Reuse PluginManager class to add/rm plugins in cordova-windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261891#comment-15261891
 ] 

ASF GitHub Bot commented on CB-11139:
-

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-windows/pull/171

CB-11139 Use PluginManager from common to install/uninstall plugins

This PR removes a lot of the code, related to plugin installation in favor 
of unified `PluginManager` class, available since `cordova-common@1.2.0` (see 
[CB-10833](https://issues.apache.org/jira/browse/CB-10833) and 
apache/cordova-lib#414)

JIRA: [CB-11139](https://issues.apache.org/jira/browse/CB-11139)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows CB-11139

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/171.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #171


commit 65a084a623592967a68aa9e7c7cf2d62fd362118
Author: Vladimir Kotikov 
Date:   2016-04-22T12:38:15Z

CB-11139 Use PluginManager from common to install/uninstall plugins




> Reuse PluginManager class to add/rm plugins in cordova-windows
> --
>
> Key: CB-11139
> URL: https://issues.apache.org/jira/browse/CB-11139
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Windows
>Affects Versions: 4.4.0
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org