[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2017-04-27 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987443#comment-15987443
 ] 

ASF subversion and git services commented on CB-11154:
--

Commit 24a7eb4faa363a82d5f73c8441dd266921d44627 in 
cordova-plugin-globalization's branch refs/heads/1.0.x from [~alsorokin]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-globalization.git;h=24a7eb4
 ]

CB-11154 (Windows) Return IANA timezone as an empty string instead of undefined


> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2017-03-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893401#comment-15893401
 ] 

ASF subversion and git services commented on CB-11154:
--

Commit 985f754f0bc04f29c26b3cad80bb76a6bd79df22 in 
cordova-plugin-globalization's branch refs/heads/1.0.x from [~kosssi]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-globalization.git;h=985f754
 ]

CB-11154: (Android, iOS) Add IANA timezone

 This closes #53


> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2017-03-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893402#comment-15893402
 ] 

ASF subversion and git services commented on CB-11154:
--

Commit 3d455677b0a470fd7b8735d1c369e1f714bf1ff3 in 
cordova-plugin-globalization's branch refs/heads/1.0.x from [~alsorokin]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-globalization.git;h=3d45567
 ]

CB-11154 (Windows) Return IANA timezone as an empty string instead of undefined


> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2017-01-11 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817691#comment-15817691
 ] 

ASF subversion and git services commented on CB-11154:
--

Commit 24a7eb4faa363a82d5f73c8441dd266921d44627 in 
cordova-plugin-globalization's branch refs/heads/master from [~alsorokin]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-globalization.git;h=24a7eb4
 ]

CB-11154 (Windows) Return IANA timezone as an empty string instead of undefined


> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2017-01-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817693#comment-15817693
 ] 

ASF GitHub Bot commented on CB-11154:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-globalization/pull/54


> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2017-01-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817684#comment-15817684
 ] 

ASF GitHub Bot commented on CB-11154:
-

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-plugin-globalization/pull/54
  
  it


> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2017-01-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815305#comment-15815305
 ] 

ASF GitHub Bot commented on CB-11154:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-globalization/pull/54
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-globalization/pull/54/commits/24a7eb4faa363a82d5f73c8441dd266921d44627)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/25/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/25//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/25//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/25//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/25//PLATFORM=windows-10-store/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/25//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/25//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/25//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/25//PLATFORM=ios/artifact/)
 |
| [Android 4.4]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/25//PLATFORM=android-4.4/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/25//PLATFORM=android-4.4/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/25//PLATFORM=android-4.4/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/25//PLATFORM=android-4.4/artifact/)
 |
| [Android 5.1]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/25//PLATFORM=android-5.1/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/25//PLATFORM=android-5.1/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/25//PLATFORM=android-5.1/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/25//PLATFORM=android-5.1/artifact/)
 |
 



> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2017-01-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815255#comment-15815255
 ] 

ASF GitHub Bot commented on CB-11154:
-

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-globalization/pull/54

CB-11154 (Windows) Return IANA timezone as an empty string instead of…

… undefined

### Platforms affected
Windows

### What does this PR do?
Adds an empty IANA Timezone value to DatePattern object on Windows platform.
https://issues.apache.org/jira/browse/CB-11154

### What testing has been done on this change?
Paramedic testing on Windows 10 and Android 4.4

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-globalization 
CB-11154

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-globalization/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #54


commit 24a7eb4faa363a82d5f73c8441dd266921d44627
Author: Alexander Sorokin 
Date:   2017-01-10T15:16:52Z

CB-11154 (Windows) Return IANA timezone as an empty string instead of 
undefined




> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2017-01-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15803952#comment-15803952
 ] 

ASF GitHub Bot commented on CB-11154:
-

Github user kosssi commented on the issue:

https://github.com/apache/cordova-plugin-globalization/pull/53
  
thanks @shazron  


> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2017-01-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802693#comment-15802693
 ] 

ASF GitHub Bot commented on CB-11154:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-globalization/pull/53


> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2017-01-05 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802692#comment-15802692
 ] 

ASF subversion and git services commented on CB-11154:
--

Commit 83f6cce89128cc569985681a05b92e1ef516fd0c in 
cordova-plugin-globalization's branch refs/heads/master from [~kosssi]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-globalization.git;h=83f6cce
 ]

CB-11154: (Android, iOS) Add IANA timezone

 This closes #53


> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2017-01-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15800849#comment-15800849
 ] 

ASF GitHub Bot commented on CB-11154:
-

Github user kosssi commented on the issue:

https://github.com/apache/cordova-plugin-globalization/pull/53
  
Thanks @shazron 

- [x] update https://github.com/MSOpenTech/cordova-plugin-globalization to 
https://github.com/apache/cordova-plugin-globalization
- [x] I fix timezone test:

```
expect(a.timezone).toBeDefined();
expect(typeof a.timezone).toBe('string');
if (!isBrowser) {
// The browser platform partially supports 'timezone'. 
Only Chrome returns 'timezone' property.
// Its format is "Part of the world/{City}". Other 
browsers return empty string.
// 
https://github.com/MSOpenTech/cordova-plugin-globalization/blob/21f8a0ffa5aa2497ee970b6b5092b4c65fc4bf7e/README.md#browser-quirks-4
expect(a.pattern.length > 0).toBe(true);
}
expect(a.timezone.length > 0).toBe(true);
```

to

```
expect(a.timezone).toBeDefined();
expect(typeof a.timezone).toBe('string');
if (!isBrowser) {
// The browser platform partially supports 'timezone'. 
Only Chrome returns 'timezone' property.
// Its format is "Part of the world/{City}". Other 
browsers return empty string.
// 
https://github.com/apache/cordova-plugin-globalization/blob/21f8a0ffa5aa2497ee970b6b5092b4c65fc4bf7e/README.md#browser-quirks-4
expect(a.timezone.length > 0).toBe(true);
}
```

- [x] Add test to timezone_iana


> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2017-01-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15800845#comment-15800845
 ] 

ASF GitHub Bot commented on CB-11154:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-globalization/pull/53
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-globalization/pull/53/commits/0a4ebe6dad2b8386e706695629a33be7b0a23631)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/24/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/24//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/24//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/24//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/24//PLATFORM=windows-10-store/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/24//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/24//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/24//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/24//PLATFORM=ios/artifact/)
 |
| [Android 4.4]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/24//PLATFORM=android-4.4/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/24//PLATFORM=android-4.4/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/24//PLATFORM=android-4.4/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/24//PLATFORM=android-4.4/artifact/)
 |
| [Android 5.1]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/24//PLATFORM=android-5.1/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/24//PLATFORM=android-5.1/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/24//PLATFORM=android-5.1/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/24//PLATFORM=android-5.1/artifact/)
 |
 



> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2017-01-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798877#comment-15798877
 ] 

ASF GitHub Bot commented on CB-11154:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-globalization/pull/53
  
Reviewing this now.


> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2016-12-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15780039#comment-15780039
 ] 

ASF GitHub Bot commented on CB-11154:
-

Github user kosssi commented on the issue:

https://github.com/apache/cordova-plugin-globalization/pull/53
  
Hello @shazron, @stevengill

Can you review this PR?

You can see more documentation for IANA Timezone (naming convention for 
time zones):
- https://en.wikipedia.org/wiki/IANA_time_zone_database
- https://www.iana.org/time-zones

You can see more example:
- America/Los_Angeles
- Europe/Paris
- America/New_York

Thanks for this plugin ❤️ 


> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2016-12-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722564#comment-15722564
 ] 

ASF GitHub Bot commented on CB-11154:
-

Github user kosssi commented on the issue:

https://github.com/apache/cordova-plugin-globalization/pull/53
  
Youhou


> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2016-11-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689202#comment-15689202
 ] 

ASF GitHub Bot commented on CB-11154:
-

Github user kosssi commented on the issue:

https://github.com/apache/cordova-plugin-globalization/pull/53
  
Who can merge it ?


> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2016-11-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636963#comment-15636963
 ] 

ASF GitHub Bot commented on CB-11154:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-globalization/pull/53
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-globalization/pull/53/commits/c7eb92e78a92d8bfee78ca4cbf4d5e966e575f08)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/23//PLATFORM=android/artifact/)
 |
 



> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2016-11-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636943#comment-15636943
 ] 

ASF GitHub Bot commented on CB-11154:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-globalization/pull/53
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-globalization/pull/53/commits/247e4027124f1792e33ea2377efa1ec721d7b726)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/22//PLATFORM=android/artifact/)
 |
 



> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2016-11-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635985#comment-15635985
 ] 

ASF GitHub Bot commented on CB-11154:
-

GitHub user kosssi opened a pull request:

https://github.com/apache/cordova-plugin-globalization/pull/53

CB-11154: (Android, iOS) Add IANA timezone



### Platforms affected
Android, iOS

### What does this PR do?
Add IANA timezone

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cozy/cordova-plugin-globalization master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-globalization/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #53


commit 247e4027124f1792e33ea2377efa1ec721d7b726
Author: Simon Constans 
Date:   2016-11-04T09:50:06Z

CB-11154: (Android, iOS) Add IANA timezone




> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2016-09-26 Thread Richard (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523165#comment-15523165
 ] 

Richard commented on CB-11154:
--

Any chance that this could be implemented? It seems like a small enough change. 
I installed this plugin specifically to get the long form timezone name.

> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2016-05-22 Thread Mathieu Gagnon (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295565#comment-15295565
 ] 

Mathieu Gagnon commented on CB-11154:
-

i suggest { timezone : "full" } to get the IANA and {timezone : "short"} as the 
default.

I can do android, ios and update the readme. 

> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2016-05-10 Thread Simon Constans (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278873#comment-15278873
 ] 

Simon Constans commented on CB-11154:
-

Hello [~nikhilkh]

When I read the description on the README for me they are already a mistake:

timezone: The abbreviated name of the time zone on the client. (String)

https://en.wikipedia.org/wiki/List_of_time_zone_abbreviations it's first 
column, for Paris is CEST.

Actually it's inconsistent for all platforms :
 - browser return "Europe/Paris" on chrome
 - android return "UTC+02"...
 - I think iOS is the same "UTC+02"

If you want use moment.js it's more easy with "Europe/Paris"

I can make a pull request with another name but I think it's not a good idea.

> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

2016-05-04 Thread Nikhil Khandelwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271001#comment-15271001
 ] 

Nikhil Khandelwal commented on CB-11154:


That will be a breaking change if we integrate it - perhaps we can add another 
property that will be in the IANA format.

> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org