[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

2016-05-06 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274927#comment-15274927
 ] 

ASF subversion and git services commented on CB-11196:
--

Commit e0fcadc8d662b66031dff5db5d692cde7f9ef980 in cordova-docs's branch 
refs/heads/master from Richard Knoll
[ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=e0fcadc ]

CB-11196: Converting mark elements in docs to platform logos

Changes the XML references to display platform logos rather
than lists of highlighted platform names. Also adds new logos
for the OS X and Browser platforms that will appear both in
the docs and in plugin search.

This closes #593


> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

2016-05-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274928#comment-15274928
 ] 

ASF GitHub Bot commented on CB-11196:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/593


> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

2016-05-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271663#comment-15271663
 ] 

ASF GitHub Bot commented on CB-11196:
-

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/593#issuecomment-217042218
  
 


> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

2016-05-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271660#comment-15271660
 ] 

ASF GitHub Bot commented on CB-11196:
-

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/593#issuecomment-217041794
  
Wohoo!  


> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

2016-05-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271646#comment-15271646
 ] 

ASF GitHub Bot commented on CB-11196:
-

Github user jasongin commented on the pull request:

https://github.com/apache/cordova-docs/pull/593#issuecomment-217040413
  
 


> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

2016-05-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271429#comment-15271429
 ] 

ASF GitHub Bot commented on CB-11196:
-

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/593#issuecomment-217001592
  
@jasongin @rakatyal @purplecabbage updated. iOS logo back to normal and new 
logo for OS X.


![new_logos_xml_2](https://cloud.githubusercontent.com/assets/13754588/15029050/adc6f10e-1200-11e6-94c7-c1010f453ad9.PNG)


![new_logos_plugin](https://cloud.githubusercontent.com/assets/13754588/15029053/b19ca5d0-1200-11e6-95db-ff007a7a92f9.PNG)




> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

2016-05-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269612#comment-15269612
 ] 

ASF GitHub Bot commented on CB-11196:
-

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/593#issuecomment-216668274
  
@jasongin maybe I can see about getting [this 
logo](http://www.apple.com/osx/) for OS X.

Title text is added by docs.js 
[here](https://github.com/apache/cordova-docs/pull/593/commits/2db61d31e3b73733449a075d0330dd4f781de0e2#diff-ab90a31f2984d41d3f15121f790a71deR138).
 I hate doing it in the JS, but that's the only way if we ant to use the `== 
mark ==` syntax


> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

2016-05-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269609#comment-15269609
 ] 

ASF GitHub Bot commented on CB-11196:
-

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-docs/pull/593#issuecomment-216667182
  
Diffing an svg file also sucks.


> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

2016-05-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269606#comment-15269606
 ] 

ASF GitHub Bot commented on CB-11196:
-

Github user jasongin commented on the pull request:

https://github.com/apache/cordova-docs/pull/593#issuecomment-21788
  
Do the icons have title text? If so I can't find it in the code.


> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

2016-05-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269594#comment-15269594
 ] 

ASF GitHub Bot commented on CB-11196:
-

Github user jasongin commented on the pull request:

https://github.com/apache/cordova-docs/pull/593#issuecomment-216665227
  
> The Apple logo is now used to indicate the OS X platform.
This is confusing to me, given that I never think about using Cordova to 
develop apps for OS X, and my iPhone has a prominent Apple logo on the back.


> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

2016-05-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269571#comment-15269571
 ] 

ASF GitHub Bot commented on CB-11196:
-

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/593#issuecomment-216662778
  
Also note that this changes the iOS logo (see leftmost logo in attached 
image). The Apple logo is now used to indicate the OS X platform. The new iOS 
logo is sort of hard to see in the xml docs, but looks much better in the 
plugin search. All of the logos have alt-text that says the platform they 
represent.


> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

2016-05-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269564#comment-15269564
 ] 

ASF GitHub Bot commented on CB-11196:
-

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/593#issuecomment-216661665
  
@rakatyal @nikhilkh please review.


> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

2016-05-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269561#comment-15269561
 ] 

ASF GitHub Bot commented on CB-11196:
-

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/593#issuecomment-216661525
  
Here is what it looks like. The logos appear under the attribute name.


![new_logos_xml](https://cloud.githubusercontent.com/assets/13754588/14998002/775ed502-1136-11e6-9b50-3e2f66994547.PNG)



> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

2016-05-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269553#comment-15269553
 ] 

ASF GitHub Bot commented on CB-11196:
-

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-docs/pull/593

CB-11196: Converting mark elements in docs to platform logos

Changes the XML references to display platform logos rather than lists of 
highlighted platform names. Also adds new logos for iOS, OS X, and Browser 
platforms that will appear both in the docs and in plugin search.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs CB-11196

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/593.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #593


commit 2db61d31e3b73733449a075d0330dd4f781de0e2
Author: Richard Knoll 
Date:   2016-05-03T20:40:42Z

CB-11196: Converting mark elements in docs to platform logos

Changes the XML references to display platform logos rather
than lists of highlighted platform names. Also adds new logos
for iOS, OS X, and Browser platforms that will appear both in
the docs and in plugin search.




> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org