[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392508#comment-15392508 ] ASF subversion and git services commented on CB-11241: -- Commit 070a6f07af5b8f10fd8d552c2d556903945cf28f in cordova-windows's branch refs/heads/4.4.x from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=070a6f0 ] CB-11241 Return adding BOM to www back to prepare > File encoding test fails with UTF-8 file encoding error on windows store > submission > --- > > Key: CB-11241 > URL: https://issues.apache.org/jira/browse/CB-11241 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.0, 4.4.1 >Reporter: Michael Schmidt > Labels: triaged > > File encoding test > ``` > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file > as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the > file as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save > the file as UTF-8 (including Byte Order Mark). > File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\plugins\cordova-plugin-console\www\console-via-logger.js is not > properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark). > ... > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387435#comment-15387435 ] ASF GitHub Bot commented on CB-11241: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/187 > File encoding test fails with UTF-8 file encoding error on windows store > submission > --- > > Key: CB-11241 > URL: https://issues.apache.org/jira/browse/CB-11241 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.0, 4.4.1 >Reporter: Michael Schmidt > Labels: triaged > > File encoding test > ``` > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file > as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the > file as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save > the file as UTF-8 (including Byte Order Mark). > File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\plugins\cordova-plugin-console\www\console-via-logger.js is not > properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark). > ... > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387436#comment-15387436 ] ASF subversion and git services commented on CB-11241: -- Commit 58080c4c48f6496dc21fa7b9ae85c189f8eeb1d9 in cordova-windows's branch refs/heads/master from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=58080c4 ] CB-11241 Return adding BOM to www back to prepare > File encoding test fails with UTF-8 file encoding error on windows store > submission > --- > > Key: CB-11241 > URL: https://issues.apache.org/jira/browse/CB-11241 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.0, 4.4.1 >Reporter: Michael Schmidt > Labels: triaged > > File encoding test > ``` > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file > as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the > file as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save > the file as UTF-8 (including Byte Order Mark). > File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\plugins\cordova-plugin-console\www\console-via-logger.js is not > properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark). > ... > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386513#comment-15386513 ] ASF GitHub Bot commented on CB-11241: - Github user toddm commented on the issue: https://github.com/apache/cordova-windows/pull/187 :shipit: > File encoding test fails with UTF-8 file encoding error on windows store > submission > --- > > Key: CB-11241 > URL: https://issues.apache.org/jira/browse/CB-11241 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.0, 4.4.1 >Reporter: Michael Schmidt > Labels: triaged > > File encoding test > ``` > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file > as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the > file as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save > the file as UTF-8 (including Byte Order Mark). > File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\plugins\cordova-plugin-console\www\console-via-logger.js is not > properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark). > ... > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386136#comment-15386136 ] ASF GitHub Bot commented on CB-11241: - Github user purplecabbage commented on the issue: https://github.com/apache/cordova-windows/pull/187 +1 :shipit: > File encoding test fails with UTF-8 file encoding error on windows store > submission > --- > > Key: CB-11241 > URL: https://issues.apache.org/jira/browse/CB-11241 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.0, 4.4.1 >Reporter: Michael Schmidt > Labels: triaged > > File encoding test > ``` > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file > as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the > file as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save > the file as UTF-8 (including Byte Order Mark). > File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\plugins\cordova-plugin-console\www\console-via-logger.js is not > properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark). > ... > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[
https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386130#comment-15386130
]
ASF GitHub Bot commented on CB-11241:
-
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/187#discussion_r71557328
--- Diff: template/cordova/lib/prepare.js ---
@@ -512,8 +515,6 @@ function addBOMSignature(directory) {
});
--- End diff --
+1
> File encoding test fails with UTF-8 file encoding error on windows store
> submission
> ---
>
> Key: CB-11241
> URL: https://issues.apache.org/jira/browse/CB-11241
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
>Affects Versions: 4.4.0, 4.4.1
>Reporter: Michael Schmidt
> Labels: triaged
>
> File encoding test
> ```
> FAILED
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file
> as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the
> file as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save
> the file as UTF-8 (including Byte Order Mark).
> File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8
> (including Byte Order Mark).
> File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8
> (including Byte Order Mark).
> File www\plugins\cordova-plugin-console\www\console-via-logger.js is not
> properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark).
> ...
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8
> form with a corresponding byte-order mark (BOM) in order to benefit from
> bytecode caching and to avoid other runtime error conditions.
> How to fix: Open the affected file, and select "Save As..." option from the
> File menu in Visual Studio. Select the drop-down control next to the Save
> button and select "Save with Encoding..." option. From the Advanced save
> options dialog, choose the "Unicode (UTF-8 with signature)" option and click
> the OK button.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385724#comment-15385724 ] ASF GitHub Bot commented on CB-11241: - Github user sgrebnov commented on the issue: https://github.com/apache/cordova-windows/pull/187 LGTM :+1: > File encoding test fails with UTF-8 file encoding error on windows store > submission > --- > > Key: CB-11241 > URL: https://issues.apache.org/jira/browse/CB-11241 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.0, 4.4.1 >Reporter: Michael Schmidt > Labels: triaged > > File encoding test > ``` > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file > as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the > file as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save > the file as UTF-8 (including Byte Order Mark). > File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\plugins\cordova-plugin-console\www\console-via-logger.js is not > properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark). > ... > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385659#comment-15385659 ] Roberto De Simone commented on CB-11241: [~vladimir.kotikov] thanks for the info! > File encoding test fails with UTF-8 file encoding error on windows store > submission > --- > > Key: CB-11241 > URL: https://issues.apache.org/jira/browse/CB-11241 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.0, 4.4.1 >Reporter: Michael Schmidt > Labels: triaged > > File encoding test > ``` > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file > as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the > file as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save > the file as UTF-8 (including Byte Order Mark). > File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\plugins\cordova-plugin-console\www\console-via-logger.js is not > properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark). > ... > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[
https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385628#comment-15385628
]
Vladimir Kotikov commented on CB-11241:
---
[~rdesimone], the PR also should fix you problem about not adding BOM to
{{.htm}} files
> File encoding test fails with UTF-8 file encoding error on windows store
> submission
> ---
>
> Key: CB-11241
> URL: https://issues.apache.org/jira/browse/CB-11241
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
>Affects Versions: 4.4.0, 4.4.1
>Reporter: Michael Schmidt
> Labels: triaged
>
> File encoding test
> ```
> FAILED
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file
> as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the
> file as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save
> the file as UTF-8 (including Byte Order Mark).
> File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8
> (including Byte Order Mark).
> File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8
> (including Byte Order Mark).
> File www\plugins\cordova-plugin-console\www\console-via-logger.js is not
> properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark).
> ...
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8
> form with a corresponding byte-order mark (BOM) in order to benefit from
> bytecode caching and to avoid other runtime error conditions.
> How to fix: Open the affected file, and select "Save As..." option from the
> File menu in Visual Studio. Select the drop-down control next to the Save
> button and select "Save with Encoding..." option. From the Advanced save
> options dialog, choose the "Unicode (UTF-8 with signature)" option and click
> the OK button.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385617#comment-15385617 ] ASF GitHub Bot commented on CB-11241: - Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/187 /cc @sgrebnov, @purplecabbage. Could you please take a look? > File encoding test fails with UTF-8 file encoding error on windows store > submission > --- > > Key: CB-11241 > URL: https://issues.apache.org/jira/browse/CB-11241 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.0, 4.4.1 >Reporter: Michael Schmidt > Labels: triaged > > File encoding test > ``` > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file > as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the > file as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save > the file as UTF-8 (including Byte Order Mark). > File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\plugins\cordova-plugin-console\www\console-via-logger.js is not > properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark). > ... > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383697#comment-15383697 ] ASF GitHub Bot commented on CB-11241: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/187 ## [Current coverage][cc-pull] is **72.57%** > Merging [#187][cc-pull] into [master][cc-base-branch] will decrease coverage by **0.08%** ```diff @@ master #187 diff @@ == Files14 14 Lines 1931 1929 -2 Methods 359359 Messages 0 0 Branches387387 == - Hits 1403 1400 -3 - Misses 528529 +1 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [aef95b0...14e648b][cc-compare] [cc-base-branch]: https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr [cc-compare]: https://codecov.io/gh/apache/cordova-windows/compare/aef95b000764d8df9177ad808b6e45d7a59f4de6...14e648bc5d6238e98a7f6e9e7b77441cf10ec7cd?src=pr [cc-pull]: https://codecov.io/gh/apache/cordova-windows/pull/187?src=pr > File encoding test fails with UTF-8 file encoding error on windows store > submission > --- > > Key: CB-11241 > URL: https://issues.apache.org/jira/browse/CB-11241 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.0, 4.4.1 >Reporter: Michael Schmidt > Labels: triaged > > File encoding test > ``` > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file > as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the > file as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save > the file as UTF-8 (including Byte Order Mark). > File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\plugins\cordova-plugin-console\www\console-via-logger.js is not > properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark). > ... > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383696#comment-15383696 ] ASF GitHub Bot commented on CB-11241: - GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/187 CB-11241 Return adding BOM to www back to prepare This PR reverts changes, made in #134 The reason of reverting is that original change causes the problems with submitting apps to Windows store when app is built using Visual Studio. For more background see JIRA issue [CB-11241](https://issues.apache.org/jira/browse/CB-11241) You can merge this pull request into a Git repository by running: $ git pull https://github.com/vladimir-kotikov/cordova-windows CB-11241 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/187.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #187 commit 7320b38bab131c3af4e49d4f14a0472c2a3682b6 Author: Vladimir Kotikov Date: 2016-07-19T07:02:54Z CB-11241 Return adding BOM to www back to prepare > File encoding test fails with UTF-8 file encoding error on windows store > submission > --- > > Key: CB-11241 > URL: https://issues.apache.org/jira/browse/CB-11241 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.0, 4.4.1 >Reporter: Michael Schmidt > Labels: triaged > > File encoding test > ``` > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file > as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the > file as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save > the file as UTF-8 (including Byte Order Mark). > File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\plugins\cordova-plugin-console\www\console-via-logger.js is not > properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark). > ... > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382960#comment-15382960 ] Roberto De Simone commented on CB-11241: Running cordova build solves most of the encoding problems. But we also have templates with the extension "tmpl.htm". Before running prepare or build, they are UTF-8 encoded. These files have to manually resaved in Visual Studio. Anyhow this is a very stupid issue. > File encoding test fails with UTF-8 file encoding error on windows store > submission > --- > > Key: CB-11241 > URL: https://issues.apache.org/jira/browse/CB-11241 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib, Windows >Affects Versions: 6.1.1 >Reporter: Michael Schmidt > Labels: cannot-reproduce, triaged, wfc > > File encoding test > ``` > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file > as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the > file as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save > the file as UTF-8 (including Byte Order Mark). > File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\plugins\cordova-plugin-console\www\console-via-logger.js is not > properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark). > ... > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382913#comment-15382913 ] Roberto De Simone commented on CB-11241: Preparing our app for store. After validating facing the same problem. We don't use cordova build in our build process. We run prepare and afterwards build in VS. This has to be fixed with very high priority!!! > File encoding test fails with UTF-8 file encoding error on windows store > submission > --- > > Key: CB-11241 > URL: https://issues.apache.org/jira/browse/CB-11241 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib, Windows >Affects Versions: 6.1.1 >Reporter: Michael Schmidt > Labels: cannot-reproduce, triaged, wfc > > File encoding test > ``` > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file > as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the > file as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save > the file as UTF-8 (including Byte Order Mark). > File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\plugins\cordova-plugin-console\www\console-via-logger.js is not > properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark). > ... > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380933#comment-15380933 ] Wolfgang Koller commented on CB-11241: -- So without reverting the commit mentioned above it seems to me as if the release using Visual Studio is not possible - very inconvient. I've reverted to 4.2.0 in the meantime - I think this issue should be fixed quickly? > File encoding test fails with UTF-8 file encoding error on windows store > submission > --- > > Key: CB-11241 > URL: https://issues.apache.org/jira/browse/CB-11241 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib, Windows >Affects Versions: 6.1.1 >Reporter: Michael Schmidt > Labels: cannot-reproduce, triaged, wfc > > File encoding test > ``` > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file > as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the > file as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save > the file as UTF-8 (including Byte Order Mark). > File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\plugins\cordova-plugin-console\www\console-via-logger.js is not > properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark). > ... > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297922#comment-15297922 ] Vladimir Kotikov commented on CB-11241: --- [~nikhilkh], the change was made in order to keep the order of operations (prepare -> 'pre_package hook' -> 'bomify' -> build) after adding simulation for pre_package hook [here|https://github.com/apache/cordova-lib/pull/356]. Since 'prepare' functionality is now offered by platform and platform is not aware of hooks functionality, the only chance to insert 'pre_package' hook before adding BOM signatures was to move this functionality to 'build' module and call it right before build stage. Although there were a recommendations to make this change, I personally don't think that it was really necessary - [a quick search on Github|https://github.com/search?l=xml&p=1&q=pre_package&type=Code&utf8=%E2%9C%93] shows that 'pre_package' hook mostly used for things, different than changing files inside 'www' and hence there is no big difference in firing it before or after BOM has added to 'www' files. So IMO [this change|https://github.com/apache/cordova-windows/pull/134] to Windows platform can be reverted to restore the original behavior of 'prepare' command. Thoughts? > File encoding test fails with UTF-8 file encoding error on windows store > submission > --- > > Key: CB-11241 > URL: https://issues.apache.org/jira/browse/CB-11241 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib, Windows >Affects Versions: 6.1.1 >Reporter: Michael Schmidt > Labels: cannot-reproduce, triaged, wfc > > File encoding test > ``` > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file > as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the > file as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save > the file as UTF-8 (including Byte Order Mark). > File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\plugins\cordova-plugin-console\www\console-via-logger.js is not > properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark). > ... > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297158#comment-15297158 ] Nikhil Khandelwal commented on CB-11241: [~vladimir.kotikov] Do you know why we made this change? [~rakatyal] FYI. > File encoding test fails with UTF-8 file encoding error on windows store > submission > --- > > Key: CB-11241 > URL: https://issues.apache.org/jira/browse/CB-11241 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib, Windows >Affects Versions: 6.1.1 >Reporter: Michael Schmidt > Labels: cannot-reproduce, triaged, wfc > > File encoding test > ``` > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file > as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the > file as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save > the file as UTF-8 (including Byte Order Mark). > File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\plugins\cordova-plugin-console\www\console-via-logger.js is not > properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark). > ... > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15288933#comment-15288933 ] Michael Schmidt commented on CB-11241: -- Ok, cordova prepare changed it's behaviour since January - adding the BOM attribute now only takes place in the build step instead of the prepare step. background: * CB-10193 Add BOM to www files at build stage instead of prepare http://mail-archives.apache.org/mod_mbox/cordova-commits/201601.mbox/%3c05738d19a02748cb8d40df330d6b8...@git.apache.org%3E * http://markmail.org/thread/cg5s2jvxvyyqcqpd My workflow for debugging (and creating releases manually) is as follows: * build js-app - with angular, ionic, with gulp & browserify * 'cordova prepare' * release ios & android platforms in automated process * manually release windows platform ** open windows VM ** open visual studio ** deploy app ** create app package from within visual studio -> this process worked for ages & now broke after upgrading the cordova version to 6.1.1 -> the BOM gets added using the 'cordova build' command overall this change seems to be confusing: - 'cordova prepare' used to "prepare" the sources for packaging - across all platforms. 'cordova build' used to package the sources for each platform - now 'cordova prepare' doesn't completely prepare the sources as only the windows needs an additional step - which is 'hidden' in the build phase > File encoding test fails with UTF-8 file encoding error on windows store > submission > --- > > Key: CB-11241 > URL: https://issues.apache.org/jira/browse/CB-11241 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib, Windows >Affects Versions: 6.1.1 >Reporter: Michael Schmidt > Labels: cannot-reproduce, triaged, wfc > > File encoding test > ``` > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file > as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the > file as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save > the file as UTF-8 (including Byte Order Mark). > File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\plugins\cordova-plugin-console\www\console-via-logger.js is not > properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark). > ... > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15288868#comment-15288868 ] Michael Schmidt commented on CB-11241: -- Similar issue on stack overflow: http://stackoverflow.com/questions/37025521/cordova-windows-10-build-fails-validation-no-utf8-files#comment61801606_37025521 > File encoding test fails with UTF-8 file encoding error on windows store > submission > --- > > Key: CB-11241 > URL: https://issues.apache.org/jira/browse/CB-11241 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib, Windows >Affects Versions: 6.1.1 >Reporter: Michael Schmidt > Labels: cannot-reproduce, triaged, wfc > > File encoding test > ``` > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file > as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the > file as UTF-8 (including Byte Order Mark). > File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save > the file as UTF-8 (including Byte Order Mark). > File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 > (including Byte Order Mark). > File www\plugins\cordova-plugin-console\www\console-via-logger.js is not > properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark). > ... > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
[
https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286723#comment-15286723
]
Vladimir Kotikov commented on CB-11241:
---
[~mobidev3], I can't reproduce this. Using the steps below i'm getting an app
that passes File encoding test from Windows Cert Kit:
cordova create foo && cd foo
cordova platform add windows // Windows@4.3.2 is installing by default
cordova build windows
{noformat}
d:\PROJECTS\Temp\foo (master -> origin)
λ file platforms/windows/www/*.js
platforms/windows/www/cordova.js: UTF-8 Unicode (with BOM) text
platforms/windows/www/cordova_plugins.js: UTF-8 Unicode (with BOM) text
d:\PROJECTS\Temp\foo (master -> origin)
λ file platforms/windows/www/**/*.js
platforms/windows/www/cordova-js-src/exec.js: UTF-8 Unicode (with BOM) text
platforms/windows/www/cordova-js-src/platform.js: UTF-8 Unicode (with BOM) text
platforms/windows/www/js/index.js:UTF-8 Unicode (with BOM) text
{noformat}
Could you please provide steps to reproduce the problem? Also, which version of
cordova-windows platform are you using?
> File encoding test fails with UTF-8 file encoding error on windows store
> submission
> ---
>
> Key: CB-11241
> URL: https://issues.apache.org/jira/browse/CB-11241
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Windows
>Affects Versions: 6.1.1
>Reporter: Michael Schmidt
> Labels: cannot-reproduce, triaged, wfc
>
> File encoding test
> ```
> FAILED
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file
> as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the
> file as UTF-8 (including Byte Order Mark).
> File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save
> the file as UTF-8 (including Byte Order Mark).
> File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8
> (including Byte Order Mark).
> File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8
> (including Byte Order Mark).
> File www\plugins\cordova-plugin-console\www\console-via-logger.js is not
> properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order Mark).
> ...
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8
> form with a corresponding byte-order mark (BOM) in order to benefit from
> bytecode caching and to avoid other runtime error conditions.
> How to fix: Open the affected file, and select "Save As..." option from the
> File menu in Visual Studio. Select the drop-down control next to the Save
> button and select "Save with Encoding..." option. From the Advanced save
> options dialog, choose the "Unicode (UTF-8 with signature)" option and click
> the OK button.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
