[jira] [Commented] (CB-11579) Windows: "cordova clean windows" command fails due to undefined variable
[
https://issues.apache.org/jira/browse/CB-11579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399362#comment-15399362
]
ASF subversion and git services commented on CB-11579:
--
Commit 38ec99c8049ea84e8c4c199ef61cd7b053bbe9aa in cordova-windows's branch
refs/heads/master from [~Nikita Matrosov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=38ec99c ]
CB-11579 windows: fix bug with 'cordova clean windows'
This closes #189
> Windows: "cordova clean windows" command fails due to undefined variable
>
>
> Key: CB-11579
> URL: https://issues.apache.org/jira/browse/CB-11579
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
>Affects Versions: 4.4.1
>Reporter: James White
> Labels: windows
>
> Running the *cordova clean windows* command in a Windows Cordova platform
> project fails with the following error:
> {color:red}
> Error: TypeError: Cannot read property 'root' of undefined
> at cleanImages
> (C:\project\myapp\platforms\windows\cordova\lib\prepare.js:396:71)
> {color}
> It looks like the *cleanImages* function in *prepare.js* isn't being passed
> the *locations* parameter on line 484.
> If I change line 484 from
> {code:Javascript}
> cleanImages(projectRoot, projectConfig);
> {code}
> to
> {code:Javascript}
> cleanImages(projectRoot, projectConfig, self.locations);
> {code}
> it completes the icon and splash screen image removal as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11579) Windows: "cordova clean windows" command fails due to undefined variable
[
https://issues.apache.org/jira/browse/CB-11579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399363#comment-15399363
]
ASF GitHub Bot commented on CB-11579:
-
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/189
> Windows: "cordova clean windows" command fails due to undefined variable
>
>
> Key: CB-11579
> URL: https://issues.apache.org/jira/browse/CB-11579
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
>Affects Versions: 4.4.1
>Reporter: James White
> Labels: windows
>
> Running the *cordova clean windows* command in a Windows Cordova platform
> project fails with the following error:
> {color:red}
> Error: TypeError: Cannot read property 'root' of undefined
> at cleanImages
> (C:\project\myapp\platforms\windows\cordova\lib\prepare.js:396:71)
> {color}
> It looks like the *cleanImages* function in *prepare.js* isn't being passed
> the *locations* parameter on line 484.
> If I change line 484 from
> {code:Javascript}
> cleanImages(projectRoot, projectConfig);
> {code}
> to
> {code:Javascript}
> cleanImages(projectRoot, projectConfig, self.locations);
> {code}
> it completes the icon and splash screen image removal as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11579) Windows: "cordova clean windows" command fails due to undefined variable
[
https://issues.apache.org/jira/browse/CB-11579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395405#comment-15395405
]
ASF GitHub Bot commented on CB-11579:
-
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/189
## [Current coverage][cc-pull] is 73.30% (diff: 100%)
> Merging [#189][cc-pull] into [master][cc-base-branch] will increase
coverage by **0.25%**
```diff
@@ master #189 diff @@
==
Files14 14
Lines 1937 1937
Methods 360360
Messages 0 0
Branches390390
==
+ Hits 1415 1420 +5
+ Misses 522517 -5
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update
[7f379ff...6a60c60][cc-compare]
[cc-base-branch]:
https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr
[cc-compare]:
https://codecov.io/gh/apache/cordova-windows/compare/7f379ff33494ed40ba2315178f31dc973d0f958d...6a60c6060b1a09f98260d48bc707dbecd0d2ad0d?src=pr
[cc-pull]: https://codecov.io/gh/apache/cordova-windows/pull/189?src=pr
> Windows: "cordova clean windows" command fails due to undefined variable
>
>
> Key: CB-11579
> URL: https://issues.apache.org/jira/browse/CB-11579
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
>Affects Versions: 4.4.1
>Reporter: James White
> Labels: windows
>
> Running the *cordova clean windows* command in a Windows Cordova platform
> project fails with the following error:
> {color:red}
> Error: TypeError: Cannot read property 'root' of undefined
> at cleanImages
> (C:\project\myapp\platforms\windows\cordova\lib\prepare.js:396:71)
> {color}
> It looks like the *cleanImages* function in *prepare.js* isn't being passed
> the *locations* parameter on line 484.
> If I change line 484 from
> {code:Javascript}
> cleanImages(projectRoot, projectConfig);
> {code}
> to
> {code:Javascript}
> cleanImages(projectRoot, projectConfig, self.locations);
> {code}
> it completes the icon and splash screen image removal as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11579) Windows: "cordova clean windows" command fails due to undefined variable
[
https://issues.apache.org/jira/browse/CB-11579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395388#comment-15395388
]
ASF GitHub Bot commented on CB-11579:
-
GitHub user matrosovN opened a pull request:
https://github.com/apache/cordova-windows/pull/189
CB-11579 windows: fix bug with 'cordova clean windows' command
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosovN/cordova-windows master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/189.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #189
> Windows: "cordova clean windows" command fails due to undefined variable
>
>
> Key: CB-11579
> URL: https://issues.apache.org/jira/browse/CB-11579
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
>Affects Versions: 4.4.1
>Reporter: James White
> Labels: windows
>
> Running the *cordova clean windows* command in a Windows Cordova platform
> project fails with the following error:
> {color:red}
> Error: TypeError: Cannot read property 'root' of undefined
> at cleanImages
> (C:\project\myapp\platforms\windows\cordova\lib\prepare.js:396:71)
> {color}
> It looks like the *cleanImages* function in *prepare.js* isn't being passed
> the *locations* parameter on line 484.
> If I change line 484 from
> {code:Javascript}
> cleanImages(projectRoot, projectConfig);
> {code}
> to
> {code:Javascript}
> cleanImages(projectRoot, projectConfig, self.locations);
> {code}
> it completes the icon and splash screen image removal as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
