[jira] [Commented] (CB-11641) MediaError object missing message member
[
https://issues.apache.org/jira/browse/CB-11641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599497#comment-17599497
]
ASF subversion and git services commented on CB-11641:
--
Commit 081fa5ed2fe9492b1b8a02272796901c64658894 in cordova-plugin-media's
branch refs/heads/master from エリス
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-media.git;h=081fa5e ]
feat(android): add 'message' field to media error CB-11641 (#357)
* CB-11641 android: add 'message' field to media error
It was not possible before to get error message.This updated Android
implementation to return error code with message similar to iOS.
* style: apply lint corrections
* refactor(android): private API sendStatusChange
Co-authored-by: Nikita Matrosov
> MediaError object missing message member
>
>
> Key: CB-11641
> URL: https://issues.apache.org/jira/browse/CB-11641
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media
>Affects Versions: 2.3.0
> Environment: Building on OSX 10.11.5, Android 5.1.1 and 5.2.0
>Reporter: Madison Dickson
>Assignee: Nikita Matrosov
>Priority: Minor
> Labels: pull-request-available
>
> on iOS, the MediaError object contains both the error code and the message.
> On Android, the object is missing the message.
> {code}
> new Media(this.src,
> // success callback
> successCallback,
> // error callback
> function(err) {
> console.log("recordAudio():Audio Error Code: "+ err.code + ", "+
> err.message, err);
> if(app.file){
> app.file.release();
> app.file = null;
> // app.stop();
> }
> }
> {code}
> outputs: {{recordAudio():Audio Error Code: 0, undefined}}
> I have seen both error code 0 and error code 1, the former of which is not
> documented.
> https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-media/index.html#mediaerror
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11641) MediaError object missing message member
[
https://issues.apache.org/jira/browse/CB-11641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525311#comment-15525311
]
ASF GitHub Bot commented on CB-11641:
-
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/117
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-media/pull/117/commits/9d0261c3ac9b7ccd1dc0d6873bd181f5121e6e68)
**Dashboard** -
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80/)
| Builder Name | Console Output | Test Report | Device Logs |
| :---: | :---: | :---: | :---:|
| [Windows 8.1 Store](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-8.1-store/)
| [Link](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-8.1-store/console)
| [Link](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-8.1-store/testReport/)
| [Link](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-8.1-store/artifact/)
|
| [Windows 10 Store](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-10-store/)
| [Link](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-10-store/console)
| [Link](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-10-store/testReport/)
| [Link](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-10-store/artifact/)
|
| [Windows 8.1 Phone](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-8.1-phone/)
| [Link](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-8.1-phone/console)
| [Link](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-8.1-phone/testReport/)
| [Link](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=windows-8.1-phone/artifact/)
|
| [iOS](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=ios/)
| [Link](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=ios/console)
| [Link](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=ios/testReport/)
| [Link](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=ios/artifact/)
|
| [Android](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=android/)
| [Link](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=android/console)
| [Link](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=android/testReport/)
| [Link](
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/80//PLATFORM=android/artifact/)
|
> MediaError object missing message member
>
>
> Key: CB-11641
> URL: https://issues.apache.org/jira/browse/CB-11641
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Media
>Affects Versions: 2.3.0
> Environment: Building on OSX 10.11.5, Android 5.1.1 and 5.2.0
>Reporter: Madison Dickson
>Assignee: Nikita Matrosov
>Priority: Minor
>
> on iOS, the MediaError object contains both the error code and the message.
> On Android, the object is missing the message.
> {code}
> new Media(this.src,
> // success callback
> successCallback,
> // error callback
> function(err) {
> console.log("recordAudio():Audio Error Code: "+ err.code + ", "+
> err.message, err);
> if(app.file){
> app.file.release();
> app.file = null;
> // app.stop();
> }
> }
> {code}
> outputs: {{recordAudio():Audio Error Code: 0, undefined}}
> I have seen both error code 0 and error code 1, the former of which is not
> documented.
> https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-media/index.html#mediaerror
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11641) MediaError object missing message member
[
https://issues.apache.org/jira/browse/CB-11641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525285#comment-15525285
]
ASF GitHub Bot commented on CB-11641:
-
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/117
CB-11641 android: add 'message' field to media error
### Platforms affected
Android
### What does this PR do?
It was not possible before to get error message.This updated Android
implementation to return error code with message similar to iOS.
### What testing has been done on this change?
Auto test
### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to secret...@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-plugin-media
CB-11641-check
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #117
commit 9d0261c3ac9b7ccd1dc0d6873bd181f5121e6e68
Author: Nikita Matrosov
Date: 2016-09-27T06:49:24Z
CB-11641 android: add 'message' field to media error
It was not possible before to get error message.This updated Android
implementation to return error code with message similar to iOS.
> MediaError object missing message member
>
>
> Key: CB-11641
> URL: https://issues.apache.org/jira/browse/CB-11641
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Media
>Affects Versions: 2.3.0
> Environment: Building on OSX 10.11.5, Android 5.1.1 and 5.2.0
>Reporter: Madison Dickson
>Assignee: Nikita Matrosov
>Priority: Minor
>
> on iOS, the MediaError object contains both the error code and the message.
> On Android, the object is missing the message.
> {code}
> new Media(this.src,
> // success callback
> successCallback,
> // error callback
> function(err) {
> console.log("recordAudio():Audio Error Code: "+ err.code + ", "+
> err.message, err);
> if(app.file){
> app.file.release();
> app.file = null;
> // app.stop();
> }
> }
> {code}
> outputs: {{recordAudio():Audio Error Code: 0, undefined}}
> I have seen both error code 0 and error code 1, the former of which is not
> documented.
> https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-media/index.html#mediaerror
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
