[jira] [Commented] (CB-11657) Windows app fails WACK test due to missing UTF BOM
[ https://issues.apache.org/jira/browse/CB-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415387#comment-15415387 ] ASF GitHub Bot commented on CB-11657: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/192 > Windows app fails WACK test due to missing UTF BOM > -- > > Key: CB-11657 > URL: https://issues.apache.org/jira/browse/CB-11657 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.2 >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: reproduced, triaged > Fix For: 4.4.3 > > > After building app for store and running WACK it fails with the following > error: > File encoding test > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File C:\Program > Files\WindowsApps\57757VladimirKotikov.CordovaTest123_1.1.0.0_x64__gpj6r6j8n5kcg\www\cordova_plugins.js > is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte > Order Mark). > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11657) Windows app fails WACK test due to missing UTF BOM
[ https://issues.apache.org/jira/browse/CB-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415386#comment-15415386 ] ASF subversion and git services commented on CB-11657: -- Commit 455bf4b62683ab380904f2e78eebe77d4a7fdb5c in cordova-windows's branch refs/heads/master from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=455bf4b ] CB-11657 Add bom to www after plugin operations Since cordova is not calling `prepare` immediately after plugin has been installed/removed, we need to take care of adding BOM ourselves. Otherwise user can run into situation when project, built from Visual Studio immediately after installation/removal of plugin, will not pass WACK tests due to missing BOM in some files. > Windows app fails WACK test due to missing UTF BOM > -- > > Key: CB-11657 > URL: https://issues.apache.org/jira/browse/CB-11657 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.2 >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: reproduced, triaged > Fix For: 4.4.3 > > > After building app for store and running WACK it fails with the following > error: > File encoding test > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File C:\Program > Files\WindowsApps\57757VladimirKotikov.CordovaTest123_1.1.0.0_x64__gpj6r6j8n5kcg\www\cordova_plugins.js > is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte > Order Mark). > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11657) Windows app fails WACK test due to missing UTF BOM
[ https://issues.apache.org/jira/browse/CB-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415361#comment-15415361 ] ASF GitHub Bot commented on CB-11657: - Github user toddm commented on the issue: https://github.com/apache/cordova-windows/pull/192 :shipit: > Windows app fails WACK test due to missing UTF BOM > -- > > Key: CB-11657 > URL: https://issues.apache.org/jira/browse/CB-11657 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.2 >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: reproduced, triaged > Fix For: 4.4.3 > > > After building app for store and running WACK it fails with the following > error: > File encoding test > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File C:\Program > Files\WindowsApps\57757VladimirKotikov.CordovaTest123_1.1.0.0_x64__gpj6r6j8n5kcg\www\cordova_plugins.js > is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte > Order Mark). > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11657) Windows app fails WACK test due to missing UTF BOM
[ https://issues.apache.org/jira/browse/CB-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415129#comment-15415129 ] ASF GitHub Bot commented on CB-11657: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/192 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/192?src=pr) is 74.25% (diff: 25.00%) > Merging [#192](https://codecov.io/gh/apache/cordova-windows/pull/192?src=pr) into [master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) will increase coverage by **0.03%** ```diff @@ master #192 diff @@ == Files14 14 Lines 1939 1942 +3 Methods 361362 +1 Messages 0 0 Branches391391 == + Hits 1439 1442 +3 Misses 500500 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [7ad7258...455bf4b](https://codecov.io/gh/apache/cordova-windows/compare/7ad7258f81c7c0a37c5bf1c717491f377fe85b87...455bf4b62683ab380904f2e78eebe77d4a7fdb5c?src=pr) > Windows app fails WACK test due to missing UTF BOM > -- > > Key: CB-11657 > URL: https://issues.apache.org/jira/browse/CB-11657 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.2 >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: reproduced, triaged > Fix For: 4.4.3 > > > After building app for store and running WACK it fails with the following > error: > File encoding test > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File C:\Program > Files\WindowsApps\57757VladimirKotikov.CordovaTest123_1.1.0.0_x64__gpj6r6j8n5kcg\www\cordova_plugins.js > is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte > Order Mark). > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11657) Windows app fails WACK test due to missing UTF BOM
[ https://issues.apache.org/jira/browse/CB-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415105#comment-15415105 ] ASF GitHub Bot commented on CB-11657: - Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/192 LGTM :+1: > Windows app fails WACK test due to missing UTF BOM > -- > > Key: CB-11657 > URL: https://issues.apache.org/jira/browse/CB-11657 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.2 >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: reproduced, triaged > Fix For: 4.4.3 > > > After building app for store and running WACK it fails with the following > error: > File encoding test > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File C:\Program > Files\WindowsApps\57757VladimirKotikov.CordovaTest123_1.1.0.0_x64__gpj6r6j8n5kcg\www\cordova_plugins.js > is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte > Order Mark). > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11657) Windows app fails WACK test due to missing UTF BOM
[ https://issues.apache.org/jira/browse/CB-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415092#comment-15415092 ] ASF GitHub Bot commented on CB-11657: - Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/192 @daserge. @sgrebnov, could you please take a look /cc @toddm > Windows app fails WACK test due to missing UTF BOM > -- > > Key: CB-11657 > URL: https://issues.apache.org/jira/browse/CB-11657 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.2 >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: reproduced, triaged > Fix For: 4.4.3 > > > After building app for store and running WACK it fails with the following > error: > File encoding test > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File C:\Program > Files\WindowsApps\57757VladimirKotikov.CordovaTest123_1.1.0.0_x64__gpj6r6j8n5kcg\www\cordova_plugins.js > is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte > Order Mark). > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11657) Windows app fails WACK test due to missing UTF BOM
[ https://issues.apache.org/jira/browse/CB-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415088#comment-15415088 ] ASF GitHub Bot commented on CB-11657: - GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/192 CB-11657 Add bom to www after plugin operations JIRA [CB-11657](https://issues.apache.org/jira/browse/CB-11657) This PR addresses WACK validation issues when app has been built from VS after installing/restoring plugins. In this case some files, added by plugins would not have BOM You can merge this pull request into a Git repository by running: $ git pull https://github.com/vladimir-kotikov/cordova-windows CB-11657 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/192.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #192 commit 455bf4b62683ab380904f2e78eebe77d4a7fdb5c Author: Vladimir Kotikov Date: 2016-08-10T10:04:24Z CB-11657 Add bom to www after plugin operations Since cordova is not calling `prepare` immediately after plugin has been installed/removed, we need to take care of adding BOM ourselves. Otherwise user can run into situation when project, built from Visual Studio immediately after installation/removal of plugin, will not pass WACK tests due to missing BOM in some files. > Windows app fails WACK test due to missing UTF BOM > -- > > Key: CB-11657 > URL: https://issues.apache.org/jira/browse/CB-11657 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.2 >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: reproduced, triaged > Fix For: 4.4.3 > > > After building app for store and running WACK it fails with the following > error: > File encoding test > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File C:\Program > Files\WindowsApps\57757VladimirKotikov.CordovaTest123_1.1.0.0_x64__gpj6r6j8n5kcg\www\cordova_plugins.js > is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte > Order Mark). > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11657) Windows app fails WACK test due to missing UTF BOM
[ https://issues.apache.org/jira/browse/CB-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405672#comment-15405672 ] Vladimir Kotikov commented on CB-11657: --- [~daserge], please disregard my previous comment > Windows app fails WACK test due to missing UTF BOM > -- > > Key: CB-11657 > URL: https://issues.apache.org/jira/browse/CB-11657 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.2 >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: reproduced, triaged > Fix For: 4.4.3 > > > After building app for store and running WACK it fails with the following > error: > File encoding test > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File C:\Program > Files\WindowsApps\57757VladimirKotikov.CordovaTest123_1.1.0.0_x64__gpj6r6j8n5kcg\www\cordova_plugins.js > is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte > Order Mark). > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11657) Windows app fails WACK test due to missing UTF BOM
[ https://issues.apache.org/jira/browse/CB-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405670#comment-15405670 ] Vladimir Kotikov commented on CB-11657: --- [~daserge] to see if it related somehow to activation event issue. Also can you add a link to that issue here? > Windows app fails WACK test due to missing UTF BOM > -- > > Key: CB-11657 > URL: https://issues.apache.org/jira/browse/CB-11657 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 4.4.2 >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: reproduced, triaged > Fix For: 4.4.3 > > > After building app for store and running WACK it fails with the following > error: > File encoding test > FAILED > UTF-8 file encoding > Error Found: The UTF-8 file encoding test detected the following errors: > File C:\Program > Files\WindowsApps\57757VladimirKotikov.CordovaTest123_1.1.0.0_x64__gpj6r6j8n5kcg\www\cordova_plugins.js > is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte > Order Mark). > Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 > form with a corresponding byte-order mark (BOM) in order to benefit from > bytecode caching and to avoid other runtime error conditions. > How to fix: Open the affected file, and select "Save As..." option from the > File menu in Visual Studio. Select the drop-down control next to the Save > button and select "Save with Encoding..." option. From the Advanced save > options dialog, choose the "Unicode (UTF-8 with signature)" option and click > the OK button. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
