[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507246#comment-15507246
 ] 

ASF GitHub Bot commented on CB-11792:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/259


> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-20 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507244#comment-15507244
 ] 

ASF subversion and git services commented on CB-11792:
--

Commit ff3df9b7e7ab37e935e1e1d38a0b1cbeff46d029 in cordova-ios's branch 
refs/heads/master from [~shazron]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=ff3df9b ]

CB-11792 - Fixed configuration file could not be parsed due to preprocessing 
errors

 This closes #259


> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507242#comment-15507242
 ] 

ASF GitHub Bot commented on CB-11792:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/259
  
@dpogue Thanks for testing! Merging.


> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507198#comment-15507198
 ] 

ASF GitHub Bot commented on CB-11792:
-

Github user dpogue commented on the issue:

https://github.com/apache/cordova-ios/pull/259
  
Tested this and I'm not getting any errors from the xcconfig :+1:
Thanks Shaz!


> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505887#comment-15505887
 ] 

ASF GitHub Bot commented on CB-11792:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-ios/pull/259
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-ios/pull/259?src=pr) is 56.89% 
(diff: 75.00%)
> Merging [#259](https://codecov.io/gh/apache/cordova-ios/pull/259?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) 
will increase coverage by **0.19%**

```diff
@@ master   #259   diff @@
==
  Files12 12  
  Lines  1090   1102+12   
  Methods 169171 +2   
  Messages  0  0  
  Branches176176  
==
+ Hits618627 +9   
- Misses  472475 +3   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[b5fb016...5e77c10](https://codecov.io/gh/apache/cordova-ios/compare/b5fb016b9f81426f9173ae36b7084fa7913dbd8f...5e77c1086d016eca67168c807a824cd3d71d6ce5?src=pr)


> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505842#comment-15505842
 ] 

ASF GitHub Bot commented on CB-11792:
-

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-ios/pull/259

CB-11792 - Fixed configuration file could not be parsed due to 
preprocessing errors



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-ios CB-11792.2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/259.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #259


commit 5e77c1086d016eca67168c807a824cd3d71d6ce5
Author: Shazron Abdullah 
Date:   2016-09-20T07:12:37Z

CB-11792 - Fixed configuration file could not be parsed due to 
preprocessing errors




> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-20 Thread Shazron Abdullah (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505830#comment-15505830
 ] 

Shazron Abdullah commented on CB-11792:
---

Because of the redirection, I had to add this ignore directive in the 
build.xcconfig files:
{code}
// @COCOAPODS_SILENCE_WARNINGS@ //
{code}

This is to suppress this warning:
{code}
[!] CocoaPods did not set the base configuration of your project because your 
project already has a custom config set. In order for CocoaPods integration to 
work at all, please either set the base configurations of the target 
`TestClient` to `Pods/Target Support 
Files/Pods-TestClient/Pods-TestClient.debug.xcconfig` or include the 
`Pods/Target Support Files/Pods-TestClient/Pods-TestClient.debug.xcconfig` in 
your build configuration.
{code}
See: 
https://github.com/CocoaPods/CocoaPods/commit/2ab324a719713aa26109d29bb2b5e06e2120abd7

> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-20 Thread Shazron Abdullah (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505807#comment-15505807
 ] 

Shazron Abdullah commented on CB-11792:
---

This issue wasn't found in testing because I was monitoring stdout which is too 
verbose (usually the errors happen at the end, and I didn't see this). It 
exists if you look at stderr.

> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-16 Thread Darryl Pogue (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497096#comment-15497096
 ] 

Darryl Pogue commented on CB-11792:
---

That sounds good to me

> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497088#comment-15497088
 ] 

ASF GitHub Bot commented on CB-11792:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/248
  
@dpogue check out my proposed fix in 
https://issues.apache.org/jira/browse/CB-11792?focusedCommentId=15495523=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15495523


> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-16 Thread Shazron Abdullah (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495523#comment-15495523
 ] 

Shazron Abdullah commented on CB-11792:
---

The only thing I can think of is, to replace the direct reference with an 
indirect reference -- reference to a file that exists that we create, but that 
file will be empty. For arguments sake, let's call it `pod.xcconfig`

Before a first time `pod install` (or every single time, doesn't matter), we 
write the appropriate "#include" in the `pod.xcconfig` file (overwriting its 
contents each time).

> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495507#comment-15495507
 ] 

ASF GitHub Bot commented on CB-11792:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/248
  
Re-opened issue


> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-09-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495043#comment-15495043
 ] 

ASF GitHub Bot commented on CB-11792:
-

Github user dpogue commented on the issue:

https://github.com/apache/cordova-ios/pull/248
  
This is causing Xcodebuild to ignore the Cordova build.xcconfig files:

```
Ignoring configuration file 
'/Users/ayogo/Jenkins/workspace/cordova-app/platforms/ios/cordova/build-release.xcconfig'
 because it could not be loaded.
Reason: File could not be parsed due to preprocessing errors:
build-release.xcconfig line 26: Unable to find included file 
"Pods/Target Support Files/Pods-HelloCordova/Pods-HelloCordova.release.xcconfig"
```


> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-08-31 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453713#comment-15453713
 ] 

ASF subversion and git services commented on CB-11792:
--

Commit a67823e711850bc2a57ab412bb310e3e8351f353 in cordova-ios's branch 
refs/heads/master from [~shazron]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=a67823e ]

CB-11792 - Add Cocoapods .xcconfig includes to build.xcconfig files in 
template, modify create script

 This closes #248


> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-08-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453714#comment-15453714
 ] 

ASF GitHub Bot commented on CB-11792:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/248


> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11792) Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify create script

2016-08-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453635#comment-15453635
 ] 

ASF GitHub Bot commented on CB-11792:
-

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-ios/pull/248

CB-11792 - Add Cocoapods .xcconfig includes to build.xcconfig files in 
template, modify create script



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-ios CB-11792

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/248.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #248


commit b45d5891ede5d9e711b24897c118540c574daa64
Author: Shazron Abdullah 
Date:   2016-08-31T22:52:14Z

CB-11792 - Add Cocoapods .xcconfig includes to build.xcconfig files in 
template, modify create script




> Add Cocoapods .xcconfig includes to build.xcconfig files in template, modify 
> create script
> --
>
> Key: CB-11792
> URL: https://issues.apache.org/jira/browse/CB-11792
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: iOS
>Reporter: Shazron Abdullah
>
> 1. The platforms/ios/cordova/build-debug.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 2. The platforms/ios/cordova/build-release.xcconfig file needs to add this 
> reference at the end: #include "Pods/Target Support 
> Files/Pods-PROJECTNAME/Pods-PROJECTNAME.debug.xcconfig"
> 3. The create script should replace PROJECTNAME with the correct project name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org