[jira] [Commented] (CB-11818) cordova-plugin-wkwebview-engine leaks memory
[ https://issues.apache.org/jira/browse/CB-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730646#comment-15730646 ] ASF subversion and git services commented on CB-11818: -- Commit 608855bbcb2f16e307f45aca6beef5a4f75e1b36 in cordova-plugin-wkwebview-engine's branch refs/heads/1.1.x from [~lucatorella] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-wkwebview-engine.git;h=608855b ] CB-11818 - Avoid retain cycle: WKUserContentController retains its message handler, to break it we cannot pass directly CDVWKWebViewEngine's instance This closes #17 > cordova-plugin-wkwebview-engine leaks memory > > > Key: CB-11818 > URL: https://issues.apache.org/jira/browse/CB-11818 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Reporter: Luca Torella >Assignee: Shazron Abdullah > > WKUserContentController retains its message handler, this cause the > CDVWKWebViewEngine to have a retain cycle and potentially leak memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11818) cordova-plugin-wkwebview-engine leaks memory
[ https://issues.apache.org/jira/browse/CB-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15530433#comment-15530433 ] ASF subversion and git services commented on CB-11818: -- Commit 608855bbcb2f16e307f45aca6beef5a4f75e1b36 in cordova-plugin-wkwebview-engine's branch refs/heads/master from [~lucatorella] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-wkwebview-engine.git;h=608855b ] CB-11818 - Avoid retain cycle: WKUserContentController retains its message handler, to break it we cannot pass directly CDVWKWebViewEngine's instance This closes #17 > cordova-plugin-wkwebview-engine leaks memory > > > Key: CB-11818 > URL: https://issues.apache.org/jira/browse/CB-11818 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Reporter: Luca Torella >Assignee: Shazron Abdullah > > WKUserContentController retains its message handler, this cause the > CDVWKWebViewEngine to have a retain cycle and potentially leak memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11818) cordova-plugin-wkwebview-engine leaks memory
[ https://issues.apache.org/jira/browse/CB-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15530434#comment-15530434 ] ASF GitHub Bot commented on CB-11818: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 > cordova-plugin-wkwebview-engine leaks memory > > > Key: CB-11818 > URL: https://issues.apache.org/jira/browse/CB-11818 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Reporter: Luca Torella >Assignee: Shazron Abdullah > > WKUserContentController retains its message handler, this cause the > CDVWKWebViewEngine to have a retain cycle and potentially leak memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11818) cordova-plugin-wkwebview-engine leaks memory
[ https://issues.apache.org/jira/browse/CB-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528779#comment-15528779 ] ASF GitHub Bot commented on CB-11818: - Github user lucatorella commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 It was not fixed > cordova-plugin-wkwebview-engine leaks memory > > > Key: CB-11818 > URL: https://issues.apache.org/jira/browse/CB-11818 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Reporter: Luca Torella >Assignee: Shazron Abdullah > > WKUserContentController retains its message handler, this cause the > CDVWKWebViewEngine to have a retain cycle and potentially leak memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11818) cordova-plugin-wkwebview-engine leaks memory
[ https://issues.apache.org/jira/browse/CB-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508784#comment-15508784 ] ASF GitHub Bot commented on CB-11818: - Github user lucatorella commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 I haven't checked. I can easily check next week when I've access to a Mac again > cordova-plugin-wkwebview-engine leaks memory > > > Key: CB-11818 > URL: https://issues.apache.org/jira/browse/CB-11818 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine >Reporter: Luca Torella >Assignee: Shazron Abdullah > > WKUserContentController retains its message handler, this cause the > CDVWKWebViewEngine to have a retain cycle and potentially leak memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11818) cordova-plugin-wkwebview-engine leaks memory
[ https://issues.apache.org/jira/browse/CB-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491953#comment-15491953 ] ASF GitHub Bot commented on CB-11818: - Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 Do you know if this was fixed in iOS 10? > cordova-plugin-wkwebview-engine leaks memory > > > Key: CB-11818 > URL: https://issues.apache.org/jira/browse/CB-11818 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin WKWebViewEngine >Reporter: Luca Torella >Assignee: Shazron Abdullah > > WKUserContentController retains its message handler, this cause the > CDVWKWebViewEngine to have a retain cycle and potentially leak memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11818) cordova-plugin-wkwebview-engine leaks memory
[ https://issues.apache.org/jira/browse/CB-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473440#comment-15473440 ] Shazron Abdullah commented on CB-11818: --- Looks like this is the inspiration for the code: http://stackoverflow.com/a/33365424/219684 (and related discussion). Question: Does this occur on iOS 10? (i.e. has the bug been fixed in iOS 10) > cordova-plugin-wkwebview-engine leaks memory > > > Key: CB-11818 > URL: https://issues.apache.org/jira/browse/CB-11818 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin WKWebViewEngine >Reporter: Luca Torella > > WKUserContentController retains its message handler, this cause the > CDVWKWebViewEngine to have a retain cycle and potentially leak memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11818) cordova-plugin-wkwebview-engine leaks memory
[ https://issues.apache.org/jira/browse/CB-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473397#comment-15473397 ] ASF GitHub Bot commented on CB-11818: - Github user lucatorella commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 Sorry, just updated the title > cordova-plugin-wkwebview-engine leaks memory > > > Key: CB-11818 > URL: https://issues.apache.org/jira/browse/CB-11818 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Luca Torella > > WKUserContentController retains its message handler, this cause the > CDVWKWebViewEngine to have a retain cycle and potentially leak memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11818) cordova-plugin-wkwebview-engine leaks memory
[ https://issues.apache.org/jira/browse/CB-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473375#comment-15473375 ] ASF GitHub Bot commented on CB-11818: - Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 Found it - CB-11818. Unfortunately I can't edit the issue title, can you please update it. Thanks! > cordova-plugin-wkwebview-engine leaks memory > > > Key: CB-11818 > URL: https://issues.apache.org/jira/browse/CB-11818 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Luca Torella > > WKUserContentController retains its message handler, this cause the > CDVWKWebViewEngine to have a retain cycle and potentially leak memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11818) cordova-plugin-wkwebview-engine leaks memory
[ https://issues.apache.org/jira/browse/CB-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469925#comment-15469925 ] Luca Torella commented on CB-11818: --- Fixed with https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 > cordova-plugin-wkwebview-engine leaks memory > > > Key: CB-11818 > URL: https://issues.apache.org/jira/browse/CB-11818 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Luca Torella > > WKUserContentController retains its message handler, this cause the > CDVWKWebViewEngine to have a retain cycle and potentially leak memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
