[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202575#comment-16202575 ] ASF GitHub Bot commented on CB-11858: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/78 > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202572#comment-16202572 ] ASF subversion and git services commented on CB-11858: -- Commit b03a8313ef12240436b32abb693eec9e6dcd07a2 in cordova-plugin-statusbar's branch refs/heads/master from [~bowserj] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=b03a831 ] Merge branch 'CB-11858' of github.com:urmx/cordova-plugin-statusbar This closes #78 > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202571#comment-16202571 ] ASF subversion and git services commented on CB-11858: -- Commit dd879140c42fa09c4274a76b9693be16e7f24f2a in cordova-plugin-statusbar's branch refs/heads/master from Max Ruman [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=dd87914 ] CB-11858: (android) Add StatusBarStyle feature support for Android M+ > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199415#comment-16199415 ] ASF GitHub Bot commented on CB-11858: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/64 > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199412#comment-16199412 ] ASF GitHub Bot commented on CB-11858: - Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/64 Closing in favour of #78 > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199411#comment-16199411 ] ASF GitHub Bot commented on CB-11858: - Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 BTW: I'm going to go with this one since it merges more cleanly. I'm going to close #64 > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199410#comment-16199410 ] ASF GitHub Bot commented on CB-11858: - Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 What happens when we test this on Android versions earlier than Android M? We currently support every Android version higher than API 19, so if we could get some more testing on this, that would be greatly appreciated. > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156485#comment-16156485 ] ASF GitHub Bot commented on CB-11858: - Github user markv commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 @filmaj @urmx @tobiasviehweger can we get this PR merged? Thanks > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006374#comment-16006374 ] ASF GitHub Bot commented on CB-11858: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/64 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-statusbar/pull/64/commits/abc46a7a63777eef170c610541047f503f7bd08f) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/52/) 24 tests run, 0 skipped, 0 failed. > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006346#comment-16006346 ] ASF GitHub Bot commented on CB-11858: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/64 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-statusbar/pull/64/commits/d84388013ab32fb848d67ebfc58ad828ea4cd4b5) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/51/) 24 tests run, 0 skipped, 0 failed. > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006328#comment-16006328 ] ASF GitHub Bot commented on CB-11858: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/64 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-statusbar/pull/64/commits/374203281b46f2c6532957e5edee7f784280b988) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/50/) 24 tests run, 0 skipped, 0 failed. > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006296#comment-16006296 ] ASF GitHub Bot commented on CB-11858: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/64 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-statusbar/pull/64/commits/e6e914759313ff7681d25f6d26e2268f690f7659) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/49/) 24 tests run, 0 skipped, 0 failed. > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983263#comment-15983263 ] ASF GitHub Bot commented on CB-11858: - Github user hollyschinsky commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 @filmaj @urmx @tobiasviehweger It's a bit confusing with iOS because the status bar styling has changed several times and the `blacktranslucent` and `blackopaque` were deprecated in iOS7. My blog post was correct at the time but since the deprecation, the code in the StatusBar plugin has been updated. If you look at these methods now, those two deprecated styles are [only specifically applied when the version is pre 7](https://github.com/apache/cordova-plugin-statusbar/blob/master/src/ios/CDVStatusBar.m#L311-329). Otherwise that code will set it to the `UIStatusBarStyleLightContent` style - which is light foreground color (white text). This is the recommended setting [based on the apple docs](https://developer.apple.com/reference/uikit/uistatusbarstyle?language=objc) for those deprecated values. Also, make note that the `lightcontent` style preference is [automatically added to the platform config.xml](https://github.com/apache/cordova-plugin-statusbar/blob/master/plugin.xml#L59-L66) when you add the StatusBar plugin for iOS. So unless the developer specifically sets something else for that it in the root project config.xml, that is going to be what is set by default (not to be confused with the `default` style setting itself which is the opposite and dark foreground color (black text) for light backgrounds :/). > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982880#comment-15982880 ] ASF GitHub Bot commented on CB-11858: - Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 Excellent, thanks for signing the ICLA! Ping @hollyschinsky - can you check what @urmx and @tobiasviehweger mention here with respect to the blacktranslucent/blackopaque bits mentioned in your blog post? > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982674#comment-15982674 ] ASF GitHub Bot commented on CB-11858: - Github user urmx commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 @tobiasviehweger For the blacktranslucent behavior, I used this [plugin README](https://github.com/apache/cordova-plugin-statusbar/blob/master/README.md#statusbarstyleblacktranslucent): > Use the blackTranslucent statusbar (light text, for dark backgrounds). And I also had a look on [Apple Developer](https://developer.apple.com/reference/uikit/uibarstyle) about [blackTranslucent](https://developer.apple.com/reference/uikit/uibarstyle/1623394-blacktranslucent): > Deprecated. Use black and set the isTranslucent property to true instead. So it's the same as [black](https://developer.apple.com/reference/uikit/uibarstyle/1623396-black): > Use a black background with light content. And now both blackTranslucent and blackOpaque seem both deprecated in [UIStatusBarStyle](https://developer.apple.com/reference/uikit/uistatusbarstyle) (as you mentioned in your PR). However, the [devgirl blog](http://devgirl.org/2014/07/31/phonegap-developers-guid/) you used as a reference state the opposite: > The default and blacktranslucent values display black foreground text and icons. > The lightcontent and blackopaque values display white foreground text and icons. So if she's right, we also have to change this plugin README. And for the default value in Android, I used lightContent (white on black) because it's backward compatible with the current style (white status bar text). > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982654#comment-15982654 ] ASF GitHub Bot commented on CB-11858: - Github user urmx commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 @filmaj Yes, I also did 3 days ago. > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982412#comment-15982412 ] ASF GitHub Bot commented on CB-11858: - Github user tobiasviehweger commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 @filmaj @urmx We probably should also check about the blacktranslucent one. It seems we implemented that differently, but I din't quite remember why.. Also we have other defaults (default vs. lightcontent). I remember changing that to unify the behaviour across iOS and Android. @urmx Any thoughts? > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982401#comment-15982401 ] ASF GitHub Bot commented on CB-11858: - Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 Cool, so we can fall back on your PR should @urmx be unable to. What about you, @urmx ? > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982381#comment-15982381 ] ASF GitHub Bot commented on CB-11858: - Github user tobiasviehweger commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 @filmaj I did, actually. > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982203#comment-15982203 ] ASF GitHub Bot commented on CB-11858: - Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 Two PRs for the same feature, wow! Thanks you two. Have either of you signed an ICLA? > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978795#comment-15978795 ] ASF GitHub Bot commented on CB-11858: - Github user tobiasviehweger commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 Just fyi, I also did some things a long time ago in #64. Nothing did happen to it though > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978637#comment-15978637 ] ASF GitHub Bot commented on CB-11858: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-statusbar/pull/78/commits/dd879140c42fa09c4274a76b9693be16e7f24f2a) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/46/) 24 tests run, 0 skipped, 0 failed. > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978591#comment-15978591 ] ASF GitHub Bot commented on CB-11858: - Github user urmx commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/64 According to [this plugin README][1] and the [official Apple reference][1], the deprecated styles "blackTranslucent", "blackOpaque" and "black" are meant to be used for a light content on dark background. [1]: https://github.com/apache/cordova-plugin-statusbar/blob/master/README.md [2]: https://developer.apple.com/reference/uikit/uibarstyle So I propose a new PR #78 for this feature. > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978585#comment-15978585 ] ASF GitHub Bot commented on CB-11858: - GitHub user urmx opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/78 CB-11858: (android) Add StatusBarStyle feature support for Android M+ ### Platforms affected Android 6.0+ (API level 23+) ### What does this PR do? This PR add StatusBarStyle feature support for Android 6.0+ (Marshmallow, API level 23+). The existing "StatusBarStyle" preference is used, and according to the README.md, the possible case-insensitive values are: - __default__: dark content (for light backgrounds) - __lightcontent__: light content (for dark backgrounds) - __blacktranslucent__: light content (for dark backgrounds) - __blackopaque__: light content (for dark backgrounds) This value can also be changed with the existing javascript functions: - `StatusBar.styleDefault()` - `StatusBar.styleLightContent()` - `StatusBar.styleBlackTranslucent()` - `StatusBar.styleBlackOpaque()` The default value is "__lightcontent__" as specified in the README (thus backward compatible with the previous style). ### What testing has been done on this change? - Default value (no StatusBarStyle parameter in config.xml) in a Cordova project on a Xperia Z3 Android 6.0.1 - The four StatusBarStyle values (lower and mixed cases) in config.xml in a Cordova project on a Xperia Z3 Android 6.0.1 - An invalid value "foo" in config.xml in a Cordova project on a Xperia Z3 Android 6.0.1 - The four StatusBar.style* methods in Chrome Remote Debugger on a Xperia Z3 Android 6.0.1 - Travis CI on this branch ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/urmx/cordova-plugin-statusbar CB-11858 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-statusbar/pull/78.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #78 commit dd879140c42fa09c4274a76b9693be16e7f24f2a Author: Max Ruman Date: 2017-04-21T10:55:58Z CB-11858: (android) Add StatusBarStyle feature support for Android M+ > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565760#comment-15565760 ] ASF GitHub Bot commented on CB-11858: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/64 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-statusbar/pull/64/commits/374203281b46f2c6532957e5edee7f784280b988) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/29//PLATFORM=android/artifact/) | > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561648#comment-15561648 ] ASF GitHub Bot commented on CB-11858: - Github user tobiasviehweger commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/64 Just read up again on the expected behaviour here: http://devgirl.org/2014/07/31/phonegap-developers-guid/ It seems blacktranslucent & blackopaque should not be used anymore, so it would be probably good to deprecate them - I did not quite understood that they are the same as default & lightcontent. Also, implemented the following methods: - styleDefault - styleBlackTranslucent - styleLightContent - styleBlackOpaque > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15495671#comment-15495671 ] ASF GitHub Bot commented on CB-11858: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/64 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-statusbar/pull/64/commits/5ff4e56a921c2cd45a64a65505a21be66ec644c4) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=android/artifact/) | > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15495609#comment-15495609 ] ASF GitHub Bot commented on CB-11858: - GitHub user tobiasviehweger opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/64 CB-11858: Add possibility to utilize Android M feature "LightStatusBar" ### Platforms affected Android 6.0+ ### What does this PR do? This PR adds support for the LightStatusBar style in Android. I re-used the already existing config "StatusBarStyle" for this, as it has a similar effect on iOS (changing the foreground color of the status bar to black instead of white). Something I'd like to discuss is, if "lightcontent" is the correct default value. The documentation says it is, but I don't think it actually is on iOS, is it? I think the iOS default is actually blackopaque? Let me know what you think :) ### What testing has been done on this change? Tested in emulator & on Samsung Galaxy S7. ### Checklist - [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sovanta/cordova-plugin-statusbar master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-statusbar/pull/64.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #64 commit 5ff4e56a921c2cd45a64a65505a21be66ec644c4 Author: Tobias Viehweger Date: 2016-09-15T15:34:45Z CB-11858: Add possibility to utilize Android M feature "LightStatusBar" > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11858) Add possibility to utilize Android M feature "LightStatusBar"
[ https://issues.apache.org/jira/browse/CB-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15495600#comment-15495600 ] Tobias Viehweger commented on CB-11858: --- Could someone assign this to me? Thanks :) > Add possibility to utilize Android M feature "LightStatusBar" > - > > Key: CB-11858 > URL: https://issues.apache.org/jira/browse/CB-11858 > Project: Apache Cordova > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Statusbar >Affects Versions: 2.2.0 > Environment: Android >Reporter: Tobias Viehweger >Priority: Minor > Labels: easyfix > > Since Android M, it's supported to have a light status bar, which will have > black text, instead of white text. That allows to have status bar backgrounds > that might be lighter than before. > There is already something similar for iOS (StatusBarStyle), so it would be > easy to add. I already have the code here > (https://github.com/sovanta/cordova-plugin-statusbar/commit/ef318e777d50918aeb9f7d86bb29a759dd8d3830), > I just need to go through the ICLA signing.. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
